From nobody Thu Apr 2 21:30:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20CF9C54EE9 for ; Tue, 20 Sep 2022 23:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbiITXcu (ORCPT ); Tue, 20 Sep 2022 19:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231244AbiITXcI (ORCPT ); Tue, 20 Sep 2022 19:32:08 -0400 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05E63786EF for ; Tue, 20 Sep 2022 16:32:01 -0700 (PDT) Received: by mail-pf1-x449.google.com with SMTP id z6-20020aa78886000000b005470014dc57so2483184pfe.1 for ; Tue, 20 Sep 2022 16:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date; bh=skon94oxKuHPyrSCQoqZBUe63SjQdco2L+TbbL4uBCU=; b=Hjp5g7m53/Dp91nmfe9aQvSSNCbSbLS48fRz6LVQD2ydP8OXIfzIUK1tUakIx5EKft qfTTKIJcO3HY41/Pzswr910irQbCD7Tat2fl1zSM5/d67ufO5XF9mXgjMrLg3DaYK63D ImyCFmQ8Z4EX6ExTelVtXumWpd3yWus80WizoQPv9NdS09OZVbimaQ1wgDOGZtMpv+LM KDd24x5tdembE2fpMbCxFockYMcaNTK2CekzpPtgRvVCKYE98YxKnoEBTHzA+hA9/gpK VGDw9iW9WdsjpqbZhJoYFTor86nTVAyUCGGtIzkL5TStsn2pTS2yfsrPqPJ4jOzfyuKI 0NMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date; bh=skon94oxKuHPyrSCQoqZBUe63SjQdco2L+TbbL4uBCU=; b=fs7R2lLtTXgjPFjphf3B5r3s3l3f0poawuuPP9qXgq+0e76NH5dB8zhiu681V8BGJL /0iwZbyNvRE+v53Mg6kt5mNGV1vAudi4GBIA+SChBgRe66t6vjkK+gruW8mpzD3szDhO AY3h5byObEn1fHbR3yS4jhcj7V6YHsX2OZjCtpDD0cg9ZXGmhbAmi8whCmmwHLRld56S 0t5h9ZGaP2QU537GcDO1FNL+x6M0ZNxLNSUjWSg5Cl6Lrzi2vZRDCiULgEudnEVyji+x ERe+dBL1vsUis+Njum3bVG8Fx38ZW4TeFvDWb1ffjCRcU4JdRfEidcdW62KhJwX4qgIU R1SA== X-Gm-Message-State: ACrzQf17DF6I6dk/0OfyxOmFNhRcEC46oksF470o6zgRnt6IOB9Vh+kJ 5n9I5QVHDItVfEJKqdGVOyhttAuikMU= X-Google-Smtp-Source: AMsMyM6dxZVAHo63ijsllpicyTPhfqV0yiHEH8OlJFbFOU4rMaDxHlrLk7dkWcMJdTG4jA0OB93KEwVbFkE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:24d:0:b0:439:3804:d0ff with SMTP id 74-20020a63024d000000b004393804d0ffmr22380275pgc.414.1663716720540; Tue, 20 Sep 2022 16:32:00 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 20 Sep 2022 23:31:20 +0000 In-Reply-To: <20220920233134.940511-1-seanjc@google.com> Mime-Version: 1.0 References: <20220920233134.940511-1-seanjc@google.com> X-Mailer: git-send-email 2.37.3.968.ga6b4b080e4-goog Message-ID: <20220920233134.940511-15-seanjc@google.com> Subject: [PATCH v3 14/28] KVM: SVM: Add helper to perform final AVIC "kick" of single vCPU From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alejandro Jimenez , Suravee Suthikulpanit , Maxim Levitsky , Li RongQing Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a helper to perform the final kick, two instances of the ICR decoding is one too many. No functional change intended. Signed-off-by: Sean Christopherson Reviewed-by: Maxim Levitsky --- arch/x86/kvm/svm/avic.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index 40a1ea21074d..dd0e41d454a7 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -317,6 +317,16 @@ void avic_ring_doorbell(struct kvm_vcpu *vcpu) put_cpu(); } =20 + +static void avic_kick_vcpu(struct kvm_vcpu *vcpu, u32 icrl) +{ + vcpu->arch.apic->irr_pending =3D true; + svm_complete_interrupt_delivery(vcpu, + icrl & APIC_MODE_MASK, + icrl & APIC_INT_LEVELTRIG, + icrl & APIC_VECTOR_MASK); +} + /* * A fast-path version of avic_kick_target_vcpus(), which attempts to match * destination APIC ID to vCPU without looping through all vCPUs. @@ -415,11 +425,7 @@ static int avic_kick_target_vcpus_fast(struct kvm *kvm= , struct kvm_lapic *source if (unlikely(!target_vcpu)) return 0; =20 - target_vcpu->arch.apic->irr_pending =3D true; - svm_complete_interrupt_delivery(target_vcpu, - icrl & APIC_MODE_MASK, - icrl & APIC_INT_LEVELTRIG, - icrl & APIC_VECTOR_MASK); + avic_kick_vcpu(target_vcpu, icrl); return 0; } =20 @@ -443,13 +449,8 @@ static void avic_kick_target_vcpus(struct kvm *kvm, st= ruct kvm_lapic *source, */ kvm_for_each_vcpu(i, vcpu, kvm) { if (kvm_apic_match_dest(vcpu, source, icrl & APIC_SHORT_MASK, - dest, icrl & APIC_DEST_MASK)) { - vcpu->arch.apic->irr_pending =3D true; - svm_complete_interrupt_delivery(vcpu, - icrl & APIC_MODE_MASK, - icrl & APIC_INT_LEVELTRIG, - icrl & APIC_VECTOR_MASK); - } + dest, icrl & APIC_DEST_MASK)) + avic_kick_vcpu(vcpu, icrl); } } =20 --=20 2.37.3.968.ga6b4b080e4-goog