From nobody Thu Apr 2 22:57:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35306C6FA8B for ; Tue, 20 Sep 2022 10:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbiITKbp (ORCPT ); Tue, 20 Sep 2022 06:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230461AbiITKbT (ORCPT ); Tue, 20 Sep 2022 06:31:19 -0400 Received: from mail-m11875.qiye.163.com (mail-m11875.qiye.163.com [115.236.118.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D6C34AD59 for ; Tue, 20 Sep 2022 03:31:15 -0700 (PDT) Received: from localhost.localdomain (unknown [58.22.7.114]) by mail-m11875.qiye.163.com (Hmail) with ESMTPA id A4626280B8F; Tue, 20 Sep 2022 18:31:13 +0800 (CST) From: Jianqun Xu To: linus.walleij@linaro.org, heiko@sntech.de, brgl@bgdev.pl, andriy.shevchenko@linux.intel.com Cc: robert.moore@intel.com, robh@kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, lenb@kernel.org, rafael@kernel.org, Jianqun Xu Subject: [PATCH 05/20] pinctrl/rockchip: of_populate_platform for gpio only for of node Date: Tue, 20 Sep 2022 18:30:53 +0800 Message-Id: <20220920103108.23074-6-jay.xu@rock-chips.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920103108.23074-1-jay.xu@rock-chips.com> References: <20220920103108.23074-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVlDHk4ZVkxKQh4aGRlOS0lIT1UTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVSktLVUtZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PQg6SSo*ST0hDBxPLQsSLyEs Kz0wFElVSlVKTU1ITU1CQ0xPSEpCVTMWGhIXVREaAlUDDjsJFBgQVhgTEgsIVRgUFkVZV1kSC1lB WU5DVUlJVUxVSkpPWVdZCAFZQUlPSUs3Bg++ X-HM-Tid: 0a835a73ad052eb1kusna4626280b8f Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" As the of_populate_platform named with prefix "of_", it should be done only when the of node is exist. Signed-off-by: Jianqun Xu --- drivers/pinctrl/pinctrl-rockchip.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-r= ockchip.c index 8f102f327af8..42aa3552417a 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3296,12 +3296,11 @@ static int rockchip_pinctrl_probe(struct platform_d= evice *pdev) void __iomem *base; int ret; =20 - if (!is_of_node(fwnode)) - return dev_err_probe(dev, -ENODEV, "device tree node not found\n"); - - ret =3D of_platform_populate(np, NULL, NULL, dev); - if (ret) - return dev_err_probe(dev, ret, "failed to register gpio device\n"); + if (is_of_node(fwnode)) { + ret =3D of_platform_populate(np, NULL, NULL, dev); + if (ret) + return dev_err_probe(dev, ret, "failed to register gpio device\n"); + } =20 info =3D devm_kzalloc(dev, sizeof(*info), GFP_KERNEL); if (!info) --=20 2.25.1