From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E273BECAAD8 for ; Tue, 20 Sep 2022 05:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230238AbiITFwF (ORCPT ); Tue, 20 Sep 2022 01:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbiITFv6 (ORCPT ); Tue, 20 Sep 2022 01:51:58 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2047.outbound.protection.outlook.com [40.107.93.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7E3B5AC68; Mon, 19 Sep 2022 22:51:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7PZ1Oawcxuoou+FmO0EiFwYYOtMAYlgFugw2cFD3ENO9l/USDA41OUHVg9elzxNJ2+1h/DCyGn3LjGy9iTLFaFOvdHjZ6wFnlrdSdt+lUYWdyOy62BqT/u1h62XoXZ5MQ/WFByMLzr+py9waORDsxDHMGkVBi/tVHQV3LKMXYPwuIU8uVH+Hg8nhLx2F6vTHrXFqsJuGrkiAn4Lmdw4Ci/Shu/MKfRwJ0UUdtTBk0odGOSi7uaqRMlND1y++0fjzLFzs5ucdasTdvAvkc0c5EPDVB42NjU3R1YiQ6Fku5nZ9gqBCY9Gg9SE61NQODeHseaeCY/cti/ptrZ8+dhzsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=80GXYjiKOseHTX6Hxl7idTbFp4NgLAPmI9B5hy+1E5w=; b=UEkf/XTe5t4o8jWbxOBh1V1DS4SxH931BwFVq3euh8Bx9f2u5u0T31Vhf4/EkeQHfFj+GdVk3QRLJBAPPX14P4hOXwspT2kFkcAzcWov3uBnxid8hxorMPzQ+U4xNGd4k80uUkpt0KCLalH7WXKri/OkU4KZ/uhgZDcxtxY+qFQvYRF/0nQaO4OPjncrJA6mGptI7FruXxg5Ph71DONihvhftnYAVfvLql2E9W5U+WQHpToqQZP5B0ou2vfE4o7t4qwAmBUYwMS782k92pM1DXM16EhyB1t506WWT7khus2rPQlXD/fMIa4gEEtcSZhU3RTRB3voBeyPvekNGIDptQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=80GXYjiKOseHTX6Hxl7idTbFp4NgLAPmI9B5hy+1E5w=; b=HLCemPUqSBBhPP89e+x+yEy/RdA+GjqS7DDJ/Tbga5lOerrEKMV+B/P1BiCPTEHDqLEttKL0GG4xuum0GYj1RMmNBQrM65x6iBoRfr6W4UiffEzYEsjbWxUWljQmEAf/dVVRRPAhcYRDrBMTucK0T+FQ/PHqJx+DsVHO7zzEa+c= Received: from MW2PR16CA0042.namprd16.prod.outlook.com (2603:10b6:907:1::19) by SJ0PR12MB6901.namprd12.prod.outlook.com (2603:10b6:a03:47e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Tue, 20 Sep 2022 05:51:51 +0000 Received: from CO1NAM11FT070.eop-nam11.prod.protection.outlook.com (2603:10b6:907:1:cafe::ed) by MW2PR16CA0042.outlook.office365.com (2603:10b6:907:1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 05:51:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT070.mail.protection.outlook.com (10.13.175.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:51:51 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:51:49 -0500 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:51:44 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 1/8] dt-bindings: dmaengine: xilinx_dma: Add xlnx,axistream-connected property Date: Tue, 20 Sep 2022 11:21:12 +0530 Message-ID: <20220920055119.12634-2-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT070:EE_|SJ0PR12MB6901:EE_ X-MS-Office365-Filtering-Correlation-Id: efa68603-1edd-451f-1c12-08da9acc370e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pCAA89qshgyT33HETayKdjTUaSgtczHkkkW8Y9TY14D3VZRVdTaMkl1NXTjXIwRj6tIJADqe3Hp6q3GAWrl4ZjRtFV5P++17ZxXHZMvImSUPQBSNtLOiv/mGGQj0WU+3gCvVjH9NlL3ikqPZ97vnXOi0Qs8NEzBmKsjNcROG7OsF/5ySDy9ajZUE6yA+X35d3hpgPfnWKjVvqZQxzdyYLbBA2AQAMWFSVzH6BOleS0bZDj32kdepxxzXZ1cLY8n9cwfFl2/U8GnaWFNPCKNOQtrSpRwPT0ak33UqGkDNv10NcSIoqFJiLAf0nByyZG/dk6xYTHsAlEQsTNMKMYqPRbw39bvQrwMzys2LOuEr4gjL/1Wt1Z6mWiSzdM1Nv/pO1NrKHyW/sC3lJfBaTa9FN7gNQwqmV+2LlcwKrPiv8Pa6uE94fqSQUiKMN3MQGIyF/t68nOYfVovQ7njhI4QbWQcnd1tMU+qvfhuj4nhk69nPubx2yeukX7cRryyCgl541lDjboBHEXb+Tmuku/kPxGQzrgq55pu1Ij6WqyCsMzQmxC0VF/ATHtXmQ6/F8iFf0Rg/gg5ueqCAKxL0G5Q5HRA8as4CC4r7080QAbhhAU5r9XlH2MGPYih/8M2vUzT8fHimxos3pofQAN17cpb9BLcZuXWR88/joFPUjwH5X9mfhMXD+H+7qA8VEgGjd7dqpovJ/QDQMMAINavagvURX9sRIdaVOlBG3U/avFMoTPUOCnLq4k+17QerkWfJiFredec78ViaE/AeVcQyEaEuH9+rB4kwN1HFLkTxo1JP4mwZBhdR5lzKSsDlg4jh0633 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(36860700001)(40480700001)(81166007)(103116003)(86362001)(110136005)(8676002)(40460700003)(82740400003)(41300700001)(4326008)(70206006)(82310400005)(54906003)(70586007)(316002)(2906002)(356005)(8936002)(5660300002)(47076005)(1076003)(2616005)(478600001)(426003)(336012)(186003)(26005)(6666004)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:51:51.2149 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efa68603-1edd-451f-1c12-08da9acc370e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT070.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6901 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Radhey Shyam Pandey Add an optional DMA property 'xlnx,axistream-connected'. This can be specified to indicate that DMA is connected to a streaming IP in the hardware design and dma driver needs to do some additional handling i.e pass metadata and perform streaming IP specific configuration. Signed-off-by: Radhey Shyam Pandey Acked-by: Rob Herring Signed-off-by: Sarath Babu Naidu Gaddam --- Changes in V3: - Add Rob acked-by. Changes in V2: - Rename xlnx,axieth-connected to xlnx,axistream-connected to make it generic. --- Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/= Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index d1700a5c36bf..18445aa092ab 100644 --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt @@ -49,6 +49,8 @@ Optional properties for AXI DMA and MCDMA: register as configured in h/w. Takes values {8...26}. If the property is missing or invalid then the default value 23 is used. This is the maximum value that is supported by all IP versions. +- xlnx,axistream-connected: Tells whether DMA is connected to AXI stream I= P. + Optional properties for VDMA: - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. It takes following values: --=20 2.25.1 From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3136C54EE9 for ; Tue, 20 Sep 2022 05:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbiITFwt (ORCPT ); Tue, 20 Sep 2022 01:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230284AbiITFwZ (ORCPT ); Tue, 20 Sep 2022 01:52:25 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2056.outbound.protection.outlook.com [40.107.244.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E95CC5C366; Mon, 19 Sep 2022 22:52:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXf3o5eFY51hyed8GAinbTKbSfLLe2Q8MNoHNXACLVPSp81tO77QtTGpI7xJqwNx7CEoF3MySrzzn+rod4WDcjF9bWOL+hsflDOCFFyAm18C12VN+ewvIkH35OCJ68XdgRAcE5f4yZqHWfzFBecbrELIZ3qiD3oh0IIU8bORaDrMX9ljKMFP33YfoaHnwqirgmqetD7kOW3/asqmiNXUQ1SuAoNpkxaGTrP7QfuJ2vGUWEPwqAsb/XsG1FToDTw0gLzA/BKRATkhXBCl8JjZWRmY9gOJGrvwh/ThGA6hEs9aDhPXPq35gjOcxgHgcglAdbCHeOWmplACT+TlQsbfEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=by1agEk8lfjHamMfPOHjuYzSqx0rNXcSt8vz4Buuj5k=; b=n/j4CjwsE9htoF7IB6Rf5Kjs02OYYIahB77apEzJyqScQEym7D11dJf2A/8gQvsVehOKR8+AVI+Sh+zp7bfzEwWNVpqeCBJrpMaR5xMlRjoxyFF0J8KPffCsq91EGLjmouid3jXO3uSIxGjRxZR2wW9KmcXbcc64odTNo7sG1ymkDm203dTNZrOnqtp+8d4qcx6/ldV/h1VrW2qHwNEwKa0lxJRSXHDIoUmSgZT9Dyj8xvKE1aIjro1ow6Zmpw0hwaQDCWdqHQYQ27i2km7G3A//rBm6SwRf74ZTKYLELUS4T2YN9M2koiPL2x8sputcacnnass3/j2pIbKsEhB6zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=by1agEk8lfjHamMfPOHjuYzSqx0rNXcSt8vz4Buuj5k=; b=uuo+CePM9e51+OCR9BuY3UdPp43icgn2G+Wpq+zDzvdaIf+/ET1o03P3Gslrsw3sIjN4HGp6Es/YUpNZXbASDkTQQLWqztdDxptuXPNts0xaWuGnEcW1uxnJxS+KUOEWuWkaOCp2J9J3w/s40NI1SzMCUyq7gdLk0Sfd8zzBmx4= Received: from DS7PR03CA0160.namprd03.prod.outlook.com (2603:10b6:5:3b2::15) by IA1PR12MB6412.namprd12.prod.outlook.com (2603:10b6:208:3af::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 05:52:07 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::7a) by DS7PR03CA0160.outlook.office365.com (2603:10b6:5:3b2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 05:52:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:52:07 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:52:02 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 19 Sep 2022 22:51:55 -0700 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:51:50 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 2/8] dt-bindings: dmaengine: xilinx_dma: Add xlnx,irq-delay property Date: Tue, 20 Sep 2022 11:21:13 +0530 Message-ID: <20220920055119.12634-3-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT023:EE_|IA1PR12MB6412:EE_ X-MS-Office365-Filtering-Correlation-Id: 615c0844-c905-437b-97c6-08da9acc40a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m+W7MgBjzMeAgdfkXrbKa9rHSZwXA8HpuNDC8IgQ0lx4uyQcq6y62svTH4Te096mAP00YyGziJDa6uR4QUgWkRDeH2GgFqCtrqO74KCtj7gM9BHFDRaxccriI92Wgdqd8drWpbVaj63EzXIJe+MoJumnjU4IVosmjPLDAkiJ0SfUEkDL0sO/b0+/TzPRoDOIqPZVwoi24xfvslGYk5sJfFlCgzSYWu/yNqWaxOdpKKGRvtN/lrLSxlaAO5Qx4Wgn57474b5sXsG0ED3NJWsf5Kle+wlU70kMz+Tu9UhQvcWPRRzRerJHAZCDRu7YE4JxKc3Agml6DBzYWE3k6eQGRB83kMSSDchCtwoALHPCCycBqZj8fEarP1MYj1otrWFx8Y8clws5Ewp5Fru855u/KNySRoXZZyulrL80OsWOktNSIh9+DXpAWbQrCeMrMnE1xIf4oZNc9/lCWe+Glai8NExwoVEVmIRQFUNvjAxcEYQUwFtld24ZMpUPvd+HODAjNoVUWg4tapK8Ieo6GewXJYuJzucPTN5UnELzuHBolalSvZeBDGYDyBvYHpXChngEsHobY+J8EuX46GykhFdI30FtnkIWdddK35ow6okrz/mEDTxfYQKdnKw40JM3LECVKq6K8PgU4IwTzzfANolWem2+BgIBKhzj/GeF/Hea4FA5yiA1JUSQLNZ41V9S0wDm7WXFdBFw2UjkOMts4IsvA60lYr5dz4yNb0n+aJ5BvacKA1xqhcqI3qDXzv8Xht9rJv/NMYd3fB0/RV+AqGvFToAoc9v0LOZc64Xeo+uJiR3X7tVfBiVDJsTD9JaI56ls X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199015)(40470700004)(46966006)(36840700001)(26005)(2616005)(82740400003)(81166007)(478600001)(2906002)(5660300002)(82310400005)(36860700001)(86362001)(36756003)(356005)(103116003)(40460700003)(336012)(1076003)(186003)(40480700001)(6666004)(47076005)(426003)(83380400001)(41300700001)(4326008)(316002)(54906003)(8676002)(110136005)(8936002)(70206006)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:52:07.3681 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 615c0844-c905-437b-97c6-08da9acc40a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6412 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Radhey Shyam Pandey Add an optional AXI DMA property 'xlnx,irq-delay'. It specifies interrupt timeout value and causes the DMA engine to generate an interrupt after the delay time period has expired. Timer begins counting at the end of a packet and resets with receipt of a new packet or a timeout event occurs. This property is useful when AXI DMA is connected to the streaming IP i.e axiethernet where inter packet latency is critical while still taking the benefit of interrupt coalescing. Signed-off-by: Radhey Shyam Pandey Acked-by: Rob Herring Signed-off-by: Sarath Babu Naidu Gaddam --- Changes in V3: - Add rob acked-by. Changes in V2: - New patch. Introduce xlnx,irq-delay property for low latency usecases. --- Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/= Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index 18445aa092ab..9793523633a4 100644 --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt @@ -50,7 +50,9 @@ Optional properties for AXI DMA and MCDMA: is missing or invalid then the default value 23 is used. This is the maximum value that is supported by all IP versions. - xlnx,axistream-connected: Tells whether DMA is connected to AXI stream I= P. - +- xlnx,irq-delay: Tells the interrupt delay timeout value. Valid range is = from + 0-255. Setting this value to zero disables the delay timer interrupt. + 1 timeout interval =3D 125 * clock period of SG clock. Optional properties for VDMA: - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. It takes following values: --=20 2.25.1 From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E0BFECAAD8 for ; Tue, 20 Sep 2022 05:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230234AbiITFw5 (ORCPT ); Tue, 20 Sep 2022 01:52:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbiITFwb (ORCPT ); Tue, 20 Sep 2022 01:52:31 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2070.outbound.protection.outlook.com [40.107.244.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F00495C36B; Mon, 19 Sep 2022 22:52:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l8n3syWT3SYC2x8quXw4pjaFredARrJi5I77VKTUgXLQ4qnZ9i1Uaj3RMakJI0OFKnVkgk4tA9UGB0uy9fBRdTjc7F9JF5qJADgnNPhMgnqKnKCTG1dnvr1rVoa6heKklKbzU6H7/z6cCZ7ElpuDI9ctgf//0OqfayvhSys5qaWDe1JdZs/mYK3H6swLwZ3zFgNReDWn4kQkEAjsjjzR7PboA8NAgxfxA3JdF1AXm6fkqu1tEvVcWYrw61ev4yUqmmI/YcJgsNtSogmriej81D0f+I2H2ZwrL50hiIQ3ZK8MzponNSN6Ri4ZJkhUHov9JopTcP2YsznIAMjXcWQU0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SsfkHru5jDLTHqTP3k+GMFvfvcpFEaANUHC77uktaTE=; b=KXuCLDbP9/2fIt26dEW4ve+9FNirywts/mTVTTWLXtBmt5C9COc4LjveCOAN4NQld+zkz1Pg41ho0PmTPBlj/dOeGMn7SPhyxpGO1I/aFU6hAF+cN4RQblILAbn1U7vxuvmVQr80yMv1tu3btzgYZaB3xo6kPeKk5vgx5JzKulJipnbGdnIB9H4v9LHterpeHGFooC+KQ+XW4cpHo8whKkkcy5dDE/thN+uVYBfnYSKZYD4Ee/+r2+3eyd7S9Bs/FLy+Rby140GUSDkWodsiLqjfvofjyzVgesXItl1N+2iNM1dTo4x1RbdrcOfOEI7lxNmqXftqAsSgPL41l14SMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SsfkHru5jDLTHqTP3k+GMFvfvcpFEaANUHC77uktaTE=; b=zsNqez/J5ZoVujVSHt3Ol/56dLgfla94qmauYGPwjcSd0PVImN7X+qcc5UJrjEF9ERP/OcteewHqu8x8/YxGpZLDtVaPO6S7EjsBAUEVdVrYVu8cs3A71nWX+De3/KkVlKcYOIJSJOtlzv51Ctp4/vJc2kl4jfX8thN/v+/FdlA= Received: from DS7PR03CA0168.namprd03.prod.outlook.com (2603:10b6:5:3b2::23) by CH2PR12MB4087.namprd12.prod.outlook.com (2603:10b6:610:7f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 05:52:08 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::ac) by DS7PR03CA0168.outlook.office365.com (2603:10b6:5:3b2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 05:52:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:52:08 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:52:03 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 19 Sep 2022 22:52:00 -0700 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:51:55 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 3/8] dmaengine: xilinx_dma: Pass AXI4-Stream control words to dma client Date: Tue, 20 Sep 2022 11:21:14 +0530 Message-ID: <20220920055119.12634-4-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT023:EE_|CH2PR12MB4087:EE_ X-MS-Office365-Filtering-Correlation-Id: aa6614b6-be3e-4c77-3e73-08da9acc414c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KMKWH7UNHDyniNtbwya0GkZCIoAqkf6eKtr9wr/JmnKMROU7Ddtxi9Io4zzVth+gcw7myqkinAwddDx97B/Ijf4fLT755LmlvIOlrc9KbG3kxT6a0nKrmRXmKXuGXZmGx/mk8JiHy2uAkGZkvYowtEjJaZqH+BY4WIgjnbfZ872UUb9e2jmUxK6X92XXsYlOh1FpT7BptsXnJ+TLvK0U9JZ6Phj4CcfNArpxoHcOZT7eIyU409xoRAhJm6OtjeCybYAddfF1B6euKSsuoqzPqA3TcvJyBNXTtufC+nc8X1SnxovQIKYoSQUJAG+pKP46OKI33239J/7XKVwHQetU/qa0+LAbeQes8VDo5StFjFeCkGZ4AkGciYpTh0yZs2miLdNu5Bl+4bKqv8OM0+WxhAXfIpYYi3M8JNFbyq4nN9ncEf6+7i8I6VeqVLfLSC1Ox/JjMujXcSComFp89pZ4gotERv9K8hfCTJU3l1dtK+GiDAHK0zN46/fwn1yoOfZ66fYPVM2eMOJ0P3KF9gngx1d6Rou4kIOD8/924kyabPaDYg9xePZZuLnvgwXb/eb/iccwQpVWjn4J5IsOuXdXYcOM38aqH1ea/bcdWZdp5OCn/vIqI6JU5jTrQ8YqOSj3EaLcbqCUkIPhogpxAo1hFq4OosJQteqFS9azDQRXvLPpceoEj6TdgYQwzvxA9YXgjnFXRFKxZ2lDk0JjEeEvwcUVjBfrs1A3d2RrIIayl0nl34saoCwIG7CLfbMw49zGLfox845F94/ar22BBXYtj8lizUVGTEf1tNc2Zv9sVl4nd3Dbx6mJ21xBslL/MxJ3 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(2906002)(5660300002)(82740400003)(8936002)(478600001)(6666004)(54906003)(40460700003)(316002)(8676002)(4326008)(103116003)(110136005)(70206006)(86362001)(70586007)(81166007)(356005)(40480700001)(41300700001)(36756003)(2616005)(82310400005)(1076003)(186003)(336012)(426003)(47076005)(36860700001)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:52:08.4774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa6614b6-be3e-4c77-3e73-08da9acc414c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4087 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Radhey Shyam Pandey Read DT property to check if AXI DMA is connected to streaming IP i.e axiethernet. If connected pass AXI4-Stream control words to dma client using metadata_ops dmaengine API. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Sarath Babu Naidu Gaddam --- Changes in V3: - None. Changes in V2: - Use descriptor metadata API to pass control words to dma client. - Rephrased commit description to be inline with implementation. --- drivers/dma/xilinx/xilinx_dma.c | 37 +++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index 6276934d4d2b..12b1281b19bf 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -493,6 +493,7 @@ struct xilinx_dma_config { * @s2mm_chan_id: DMA s2mm channel identifier * @mm2s_chan_id: DMA mm2s channel identifier * @max_buffer_len: Max buffer length + * @has_axistream_connected: AXI DMA connected to AXI Stream IP */ struct xilinx_dma_device { void __iomem *regs; @@ -511,6 +512,7 @@ struct xilinx_dma_device { u32 s2mm_chan_id; u32 mm2s_chan_id; u32 max_buffer_len; + bool has_axistream_connected; }; =20 /* Macros */ @@ -623,6 +625,29 @@ static inline void xilinx_aximcdma_buf(struct xilinx_d= ma_chan *chan, } } =20 +/** + * xilinx_dma_get_metadata_ptr- Populate metadata pointer and payload leng= th + * @tx: async transaction descriptor + * @payload_len: metadata payload length + * @max_len: metadata max length + * Return: The app field pointer. + */ +static void *xilinx_dma_get_metadata_ptr(struct dma_async_tx_descriptor *t= x, + size_t *payload_len, size_t *max_len) +{ + struct xilinx_dma_tx_descriptor *desc =3D to_dma_tx_descriptor(tx); + struct xilinx_axidma_tx_segment *seg; + + *max_len =3D *payload_len =3D sizeof(u32) * XILINX_DMA_NUM_APP_WORDS; + seg =3D list_first_entry(&desc->segments, + struct xilinx_axidma_tx_segment, node); + return seg->hw.app; +} + +static struct dma_descriptor_metadata_ops xilinx_dma_metadata_ops =3D { + .get_ptr =3D xilinx_dma_get_metadata_ptr, +}; + /* -----------------------------------------------------------------------= ------ * Descriptors and segments alloc and free */ @@ -2326,6 +2351,9 @@ static struct dma_async_tx_descriptor *xilinx_dma_pre= p_dma_cyclic( segment->hw.control |=3D XILINX_DMA_BD_EOP; } =20 + if (chan->xdev->has_axistream_connected) + desc->async_tx.metadata_ops =3D &xilinx_dma_metadata_ops; + return &desc->async_tx; =20 error: @@ -3064,6 +3092,11 @@ static int xilinx_dma_probe(struct platform_device *= pdev) } } =20 + if (xdev->dma_config->dmatype =3D=3D XDMA_TYPE_AXIDMA) { + xdev->has_axistream_connected =3D + of_property_read_bool(node, "xlnx,axistream-connected"); + } + if (xdev->dma_config->dmatype =3D=3D XDMA_TYPE_VDMA) { err =3D of_property_read_u32(node, "xlnx,num-fstores", &num_frames); @@ -3089,6 +3122,10 @@ static int xilinx_dma_probe(struct platform_device *= pdev) else xdev->ext_addr =3D false; =20 + /* Set metadata mode */ + if (xdev->has_axistream_connected) + xdev->common.desc_metadata_modes =3D DESC_METADATA_ENGINE; + /* Set the dma mask bits */ dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width)); =20 --=20 2.25.1 From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0855C54EE9 for ; Tue, 20 Sep 2022 05:52:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbiITFww (ORCPT ); Tue, 20 Sep 2022 01:52:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbiITFw3 (ORCPT ); Tue, 20 Sep 2022 01:52:29 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACA295C36A; Mon, 19 Sep 2022 22:52:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/f7xUi7WYfbM+p/+Tn3WoiTTwziyhX2VNTSV191GmRIFs+qIaA0AFM4QbtOqlP1s1AH2/2Q5+j/FbpvTUZNFNe+bcyv1d+rWA4Af8YUspCf9FVgpehucSNqNyoaGPcAzP+xUX4RSp3ClQc7HIo10MyZ/kirclgUNil54iSNccDMD7hnbZwQmb75sfvmPbPg8SlOWdIUsq+5QtZcr9xz0UiLx3IPpXZ6X8j2L1HsKJGCWs0ziHRE56oP3onR60n7u8OVKVorEATVPC1bm7xy+7y2vBbTG6dZoWg/5T8WjRnB9TwrZdjYWlgSg4OeZhRrwSIP3HEL6E73CrHJPywy4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0L1hnS9Go4bLhQehQ9IwY0iWbv7nxAHNngpfz3PXWz8=; b=SgSv3HZOTN3Q0tbWKqYj+VY2/jyZ1lDJhz3SnQ065e36qLbxKM8jDX94LLftXuYKOmySipHkWeKHZ5WF8+vbtHnKoE3Sq6FqGX1qoCPA4ZGyhoh++mueUDX2dosxHXjLc2JqTDhwVeDFEjgXDlbQ09PdI9A0veYjPLpS7xXl8gACjvoZ88dRIS1HWBNKSFaUbD5r1VXsDvEbLzOJzLBWXrqhTGzK/7CHHpxey5baGY1xtOzOeiT1jl2+6LBQGj2/m4K2LXSykFrIv6MFrFMTyGL6eLc5MjJx4+6cJOSIljgvXDhlreFrjKLecqoIH7tcLBVbWwMVtavGbgcf0CQY7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0L1hnS9Go4bLhQehQ9IwY0iWbv7nxAHNngpfz3PXWz8=; b=GVfBUO5ETreIFPaWG2vU8h1uBSD3aP3kHmy5/31/PtujhU43TNKcWheB5TkdWqPqDFnmcCiIa3p5u+9ilL+mjTX+2eFuB7TkFSr2CCEfQbV/G2vdGfVd1qZzialMxuRnNR/Mx44+nXv0ek1/S0vZ0fsrY54/BnAn6pbHs/YeiKE= Received: from DM6PR05CA0063.namprd05.prod.outlook.com (2603:10b6:5:335::32) by MW4PR12MB7215.namprd12.prod.outlook.com (2603:10b6:303:228::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 20 Sep 2022 05:52:09 +0000 Received: from DM6NAM11FT051.eop-nam11.prod.protection.outlook.com (2603:10b6:5:335:cafe::b6) by DM6PR05CA0063.outlook.office365.com (2603:10b6:5:335::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.5 via Frontend Transport; Tue, 20 Sep 2022 05:52:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT051.mail.protection.outlook.com (10.13.172.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:52:08 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:52:06 -0500 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:52:01 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 4/8] dmaengine: xilinx_dma: Increase AXI DMA transaction segment count Date: Tue, 20 Sep 2022 11:21:15 +0530 Message-ID: <20220920055119.12634-5-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT051:EE_|MW4PR12MB7215:EE_ X-MS-Office365-Filtering-Correlation-Id: 24cd9928-706f-4372-9bea-08da9acc4184 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OBQ4jOII7Mw1MYS4m7Tu70695iouFbMrI6Z0wXeF9ucjSHj2f1DU2x0H6JpCdn7kuRRDLwcYGFAN7s4T9vCS/+DaKDOzqBox1cBsWcYpuegybRFRA+r+4dqRhvOgRsNfZLBWfwRk3eb5EyDx4qrTWELZPntr7gohQ+2wwGYVZGHQxaFTFcL/bzMlD1IRvtzqZfPxSnCVWSRUpp+fXFb58cWMFimIlQqv9hJ0FkMC80lSkwcC64roO2vEaN1SHhBTwNBussIzFEbEuGhVZ1yH0fCkSgcGc/0ybtJLFME6C4hJZRTuRiKEfzuY3ABz/ND2n8ym8S18MlC2Of9o/TQR9WbhHE9yrCTf60XVWgHc89Qiy/HQpxAltBEkRkOj5h0xze6BtcVMNurG0YKNiq8REZBbyT635pxMoChKZeVEJCdEoE9yaKvNeoaCskpa6yaq83bzs56d02482gDAQcEB0+lKih7xy72eXFR+8v9AFssfHH02DqnNYMIwEgwAVOTkRXnbE0CPYfHiawipw5PAecFwQbJhRyBrA+mCTZwLAEZAANd/WTp01wfW6kLJUzlhzqWcSEl11Qv0pxaug1f6qoegi1eAHOi0PxXMO+NqFEHn3UkYUt/oUPsNatBCtun8yX8wB0ipWk2kErk3FulLqFxaCvhGcPJj8Z8kB2qZKiHjOVBCrQoyaDzxxDtMNZFjiqOQvqaVZ2DAD73bekEZVEet5PxGB0ZysFNRuupMQwEnALq56tkOQye5Evrk4t8XAf5kfzwxDSekGvt2Aq/lOvl0kQZIVP+/V/PJJIEqbPmE72urZYpEVYKxBqaLEhoy X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(26005)(6666004)(54906003)(82310400005)(4326008)(1076003)(8676002)(5660300002)(70206006)(47076005)(40480700001)(478600001)(81166007)(2906002)(83380400001)(336012)(103116003)(70586007)(40460700003)(4744005)(186003)(36860700001)(41300700001)(110136005)(316002)(2616005)(8936002)(356005)(36756003)(86362001)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:52:08.8468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24cd9928-706f-4372-9bea-08da9acc4184 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT051.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Radhey Shyam Pandey Increase AXI DMA transaction segments count to ensure that even in high load we always get a free segment in prepare descriptor for a DMA_SLAVE transaction. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Sarath Babu Naidu Gaddam --- Changes in V3 and V2: - None --- drivers/dma/xilinx/xilinx_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index 12b1281b19bf..8c6065cbda79 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -178,7 +178,7 @@ #define XILINX_DMA_BD_SOP BIT(27) #define XILINX_DMA_BD_EOP BIT(26) #define XILINX_DMA_COALESCE_MAX 255 -#define XILINX_DMA_NUM_DESCS 255 +#define XILINX_DMA_NUM_DESCS 512 #define XILINX_DMA_NUM_APP_WORDS 5 =20 /* AXI CDMA Specific Registers/Offsets */ --=20 2.25.1 From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BE8ECAAD8 for ; Tue, 20 Sep 2022 05:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230108AbiITFxT (ORCPT ); Tue, 20 Sep 2022 01:53:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbiITFwh (ORCPT ); Tue, 20 Sep 2022 01:52:37 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2065.outbound.protection.outlook.com [40.107.96.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71DD85B7A0; Mon, 19 Sep 2022 22:52:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ecJwSfOvT+OgklGJknckA+xJF4G5fo3dnZ5cvSxGtTfgG+bpJVgInI5FrH7wRawsqGOH/HMLRVj9u0lofWfsHM+jBiJfZnLXe7AGg5fBnqLj9+5y24sTBrTOLpS5oj0SMu0idTRHtnklGGmg/xJxS2z3yumVShW+Ic/XNcoLVsroW8JoC0nh7Qk0evR6H79oPvDR3iW9qL0Wd4gX9Y1PB4pY4l1eqrbTEQjIjTBFPGQCr5zQfee6sprbONjHyrgGD7fOexSO/TVQHzitMbwaL73se50pIPIZmE0XlBN5M2eWrgee2wM6OpRWIWpEbPYxZqQlkYJR6nJyLrOH1zo5GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9mhFhnS+Urh09YvvwKS45o6I5uLgqubiJ+Dih9n90Zs=; b=ln4v4vCQ8GOUM8hGrgjO0aUXQP2OpRICXhEeLeCtUwp/k8E3H/b2/goVDWjy84amlrFBkslHH1GrZoMT7+efxWyfN81Vc3eMHaMYL0yOiKY/SCWePxzDstwol+qOUSgb++Xt6bvxb095o/gTjF82Y3hTUYEILK4+UuKQcXDbHkeJOTUDWWVdSYm77FQSEZ2lEbQchTMjqAo0s33QEO5vlafqqPBUi7iWSblURgBx/MmWsldNt1D8sbuwt6/afEfndiMluhGWx8+5EzlFX4KBpg7VkegdZlMgkm0KvVg6Dth5/HyCK3bDU5ai3ou0umFvyvXRZHZon3qYrEC1rQ13pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9mhFhnS+Urh09YvvwKS45o6I5uLgqubiJ+Dih9n90Zs=; b=JGW6uPVO2u5rikZ+hB/IKGXjnKf5uXRpVYGG+GgoJgSobylblKjxPP8EycelxsQ8yxEUCKWbn5YyrZ2GI73+aKICnnQMPDHtuoLGc9gOsuswjmSOCNlSLPmshDei74CgH3hsQjjgyIepPbV5KgCM9x/FvlSSvzJ8aLs85Qgnu78= Received: from DM6PR14CA0054.namprd14.prod.outlook.com (2603:10b6:5:18f::31) by DS7PR12MB5934.namprd12.prod.outlook.com (2603:10b6:8:7d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Tue, 20 Sep 2022 05:52:19 +0000 Received: from DM6NAM11FT079.eop-nam11.prod.protection.outlook.com (2603:10b6:5:18f:cafe::1e) by DM6PR14CA0054.outlook.office365.com (2603:10b6:5:18f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 05:52:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT079.mail.protection.outlook.com (10.13.173.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:52:19 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:52:17 -0500 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:52:07 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 5/8] dmaengine: xilinx_dma: Freeup active list based on descriptor completion bit Date: Tue, 20 Sep 2022 11:21:16 +0530 Message-ID: <20220920055119.12634-6-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT079:EE_|DS7PR12MB5934:EE_ X-MS-Office365-Filtering-Correlation-Id: d0723519-286d-4658-b59b-08da9acc47a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vw47WI7KC2w5tPWq35rtVOCh3q8NqroGINak2QflujJApGySxOvwp2jPG6UKNuBOCZAtWYbRqXfuNhMeyUlXOIt0xbTr/DzuBEo8wJ6UeAb8TKbyMyFMxT0ulBmWKGTBjrKxdQ4qxHcMrodDmt/51pm0ixO1WLo26mFWwIjVhLTmGqHNsyJ5ZJO2KK+j41/Cr5eHXac3StS8st23VjnBlmaWkEMVrsCSKEu3ZUmCkEOyGzcLpY9g73E3/jWyuwqTEeshij0g29BuoL48RTio8VJRvhu+xcdtv5RhTu1EFJJ2SiC069QPhlEU4b6ps3oGugsraJtDP0PXg/Cj1dn4lhdHE+aOYzfgD6qNuEsXSynlIgngJI7qnhcW/BlcIlvmDO3bfHJpjeQJB6eKTqAXO7GfPzNvjc9l58CYlxVZD3VUJrDijBTQJQgtLEq8xV2jvDYsF/vTnraJl9yRS0J/BmPFRfsbhuuNsB9uCCT+YQb83iUhbI/+BscvUAOtUFdL27bRhy9WlQcSwimBysSpUYSV4ykIw68hOVz3uffCcZBS9COeOTf7mvmV0ySUJCLLvPzUW5Uirhyomzl+2vFR9y78YySaL8cZZoK6tAL2EuN0irnU7V8WxdF5MumN5rFHGmtyiYCLRakUnxmKGD4RGuaxCPTfg0eCEKZLY2TmIwpj4U/5u+inOWolr9XHm2DEJqEOJs+fhxDylMos102N1TLINUAy9KRJSuTxmAMSf6yIWpI7zFxAPnwdchnzFeuomSYlKYKTj1OGthAQ9aMaXuMfYhcMIgPwFQcB/jNkkIBgl8I4GGCSPxch0qz4Z0Xt X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(8676002)(40480700001)(336012)(82740400003)(426003)(2616005)(1076003)(186003)(356005)(81166007)(86362001)(47076005)(36860700001)(5660300002)(8936002)(41300700001)(70586007)(4326008)(70206006)(2906002)(82310400005)(6666004)(26005)(103116003)(54906003)(110136005)(40460700003)(478600001)(36756003)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:52:19.1260 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0723519-286d-4658-b59b-08da9acc47a2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT079.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5934 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Radhey Shyam Pandey AXIDMA IP in SG mode sets completion bit to 1 when the transfer is completed. Read this bit to move descriptor from active list to the done list. This feature is needed when interrupt delay timeout and IRQThreshold is enabled i.e Dly_IrqEn is triggered w/o completing interrupt threshold. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Sarath Babu Naidu Gaddam --- Changes in V3: - Addressed RFC V2 review comment in xilinx_dma_complete_descriptor. "remove hardcoding for axidma_tx_segment". - Below review comment is in pipeline. We are facing a race issue when addressing it. we will fix it in the next version. "chan->idle =3D true; in xilinx_dma_irq_handler() needs to be gated on the active_list being empty". Changes in V2: - Check BD completion bit only for SG mode. - Modify the logic to have early return path. --- drivers/dma/xilinx/xilinx_dma.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index 8c6065cbda79..1488cc6a299a 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -177,6 +177,7 @@ #define XILINX_DMA_CR_COALESCE_SHIFT 16 #define XILINX_DMA_BD_SOP BIT(27) #define XILINX_DMA_BD_EOP BIT(26) +#define XILINX_DMA_BD_COMP_MASK BIT(31) #define XILINX_DMA_COALESCE_MAX 255 #define XILINX_DMA_NUM_DESCS 512 #define XILINX_DMA_NUM_APP_WORDS 5 @@ -1706,6 +1707,14 @@ static void xilinx_dma_complete_descriptor(struct xi= linx_dma_chan *chan) return; =20 list_for_each_entry_safe(desc, next, &chan->active_list, node) { + if (chan->xdev->dma_config->dmatype =3D=3D XDMA_TYPE_AXIDMA) { + struct xilinx_axidma_tx_segment *seg; + + seg =3D list_last_entry(&desc->segments, + struct xilinx_axidma_tx_segment, node); + if (!(seg->hw.status & XILINX_DMA_BD_COMP_MASK) && chan->has_sg) + break; + } if (chan->has_sg && chan->xdev->dma_config->dmatype !=3D XDMA_TYPE_VDMA) desc->residue =3D xilinx_dma_get_residue(chan, desc); --=20 2.25.1 From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B63FEC6FA82 for ; Tue, 20 Sep 2022 05:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230236AbiITFxW (ORCPT ); Tue, 20 Sep 2022 01:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230185AbiITFwj (ORCPT ); Tue, 20 Sep 2022 01:52:39 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2047.outbound.protection.outlook.com [40.107.243.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F525C371; Mon, 19 Sep 2022 22:52:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BpXX6KhKqNHnv8qX3kaaNZm+BOjl7/if+3G1/gWtxoyYlcqKm4TAls9bwl9ysxbmpl55RCYOIFdHRW6CmOnutKJ/klHyWgVev1crIfM3PZn6v3wBvPxOjzLclbp9ut+MZebgqNiiLbEE5AsU6qlLA2M24F8QlX49vwNGAyc6KcjOZboURF5bBiC5GwzRHoZyQMH6OUjn6RRe6M+d21zjmooxU3hYg0t0agqJeL9ttW9W02G52/JkECPcuKv2exIbjyFvclfZGD22X5PRnfalQsV6AsHAdQHTiYBxRlwqkIXmgdXWu8eVLX/OEtNQk7A1nRVkAe31jA248E72weA1Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O2on7t20UqBPdj91RrUyO1ZFtWUiY5NWAr5k45JDPsI=; b=NbWdGHDpY72QBrCwkSfOYw2yftRWmyJi4HJ9uQzdUYXmLK7y3TLAohlfgdeiBYOF98iHq8wpzCvbgJedVVdYFLCLXJXsT2VmE/x6weknpV/ct32y1rvI6O3cMs6oKsZ7H1EVKIogQzae+ei769/LCzvwnQzX1ZYTZFb+Hdp/4nsYVooH9HT+fuA7hS5zDHlOp2Yo1As5wuqE5toReD2MYSDMCOBdmMCBV4nnXDLP1NFw6AJb9kSTUuOhXHPz0djGnwqociZHZEww2v4zRR2GWiz0oxh6CmIvPyRnY0cEWFxSnx4dwFpRCsfK2O9tZpDaTKFPSdN4uvsg/DLQY8c8lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O2on7t20UqBPdj91RrUyO1ZFtWUiY5NWAr5k45JDPsI=; b=ysl7uIyUfrLIKpmCBc07o94T9oyVZCbpiYiH0ZfYZhI/nveqYIz05BOcz9Hs9TNfybSPiIZbN4byCrYntjRAmJ7jfYmxPG32P7sqp04/iE6J5UO445LFMU4+MkyjFXY8NDa0j9zE952Lld+9j5ECprJ4wK7QNjTAB8Rt8Pg0w6g= Received: from MW4PR04CA0354.namprd04.prod.outlook.com (2603:10b6:303:8a::29) by DS0PR12MB6389.namprd12.prod.outlook.com (2603:10b6:8:cf::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Tue, 20 Sep 2022 05:52:26 +0000 Received: from CO1NAM11FT084.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::56) by MW4PR04CA0354.outlook.office365.com (2603:10b6:303:8a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21 via Frontend Transport; Tue, 20 Sep 2022 05:52:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT084.mail.protection.outlook.com (10.13.174.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:52:25 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:52:23 -0500 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:52:18 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 6/8] dmaengine: xilinx_dma: Use tasklet_hi_schedule for timing critical usecase Date: Tue, 20 Sep 2022 11:21:17 +0530 Message-ID: <20220920055119.12634-7-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT084:EE_|DS0PR12MB6389:EE_ X-MS-Office365-Filtering-Correlation-Id: 01ccae9e-a837-40ff-1798-08da9acc4b9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SHVstLJQyF/YVH5VTLlmaY+jOdtPIm2gt3eeWU+daXY2qxGMYdlRS0mMydvmEywcyQma3QgbwAc/HFQrvb7cRZ2WKE3YdEdpyQF3PmsPCYDX0Lowd//DJXJNK/O71GG1a/ABS3PhGWjL5QcnscFi33lwZS+tiTBw1KdiZroJK8a1vewmg1HZDHg3GnbMEhHe4GUopyl/eE55+ZRSntZHlBW16GHVKoDZNwXiyQ9aC+3F10yOjIt8qelnP8XRy8OX6LdRbgXXozR90LOBAPNDN1nQI46c5RLQILVpK1tnXBrW9zZOQXx5/Ps90HGChCYVCC8qV4iy+r4p73ZSqibKgRmH1+DNbzToQIEzmHI0gEv3Rucb9TOvcrz6x61v4PFY8n1uCv/qz0j+TRV4c79HjsASMSveNscoWWmWywBJWLz7+ECmVcKDPeGKkeC1Gs3oBFJ5OJ/WIpOUbdYpHfjgFc1ioAT2KeQQ2aVyCLA4snZAJ2JZalzJWGQvEzcR4WM2bdDfiH5D/AVhiHE0c+ZYKgCGCoYYi8BwhTceDsx5e5lAeHa2Iz/BGp9MgFrgF/EQPiiceVvZ+W7tHrxQpvY4nylsrwEEJFuLHqiDCPfGPsZk1+GXQLtVICFo59UNkHvWZI5UDjgtG/iPw8Vfl5MYtIklrDxj97q0xahBixyOFn4f4JMTBln6mivdstOLYqyy8scORRbcK5cXrCUb0Foa3uEpIDCPxTkgRH1F5WWxrnNXaCdvcrStRt29dxQzi/EvG+AwB4XpdMz/5aNYkM079iKzpMaa21wTTwGhyldyKbbiOpqur5Z+N11nkmOK345I X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(8676002)(40480700001)(336012)(82740400003)(426003)(2616005)(1076003)(186003)(83380400001)(356005)(81166007)(86362001)(47076005)(36860700001)(5660300002)(8936002)(41300700001)(4744005)(70586007)(4326008)(70206006)(2906002)(82310400005)(26005)(103116003)(54906003)(110136005)(40460700003)(478600001)(36756003)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:52:25.7220 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01ccae9e-a837-40ff-1798-08da9acc4b9d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT084.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6389 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Radhey Shyam Pandey Schedule tasklet with high priority to ensure that callback processing is prioritized. It improves throughput for netdev dma clients. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Sarath Babu Naidu Gaddam --- Changes in V2 and V3: - None --- drivers/dma/xilinx/xilinx_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index 1488cc6a299a..8126a56980f2 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -1848,7 +1848,7 @@ static irqreturn_t xilinx_mcdma_irq_handler(int irq, = void *data) spin_unlock(&chan->lock); } =20 - tasklet_schedule(&chan->tasklet); + tasklet_hi_schedule(&chan->tasklet); return IRQ_HANDLED; } =20 --=20 2.25.1 From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8C8C54EE9 for ; Tue, 20 Sep 2022 05:53:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbiITFx3 (ORCPT ); Tue, 20 Sep 2022 01:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbiITFwl (ORCPT ); Tue, 20 Sep 2022 01:52:41 -0400 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2074.outbound.protection.outlook.com [40.107.95.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89C055B7AA; Mon, 19 Sep 2022 22:52:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TX/OwwWjFk3rPgVBF+r7gsRQCTz2ke8h0ePtxoPbnkVjbL0woRD3alYHqtf2bVtF8Blb1zoqMJsfQzOwskGtZdYN3WKB0tDz0Bd9ssjqeZzNV83Udrp/jnumGGM9HpRrmWTYpsGYVmTyAB/VjGHq1S207xu6zN4yOnanLrQlOzU/a0AMAkh2YyXb5TVzz9v2O3BqdxoFeCAlP6mZctjO1MYOtXIjt9ZTbYEKwE2fYBotgJnlRpviOde824sbTKgaJbVeub+wDRhj6XhBOWix/hzFWURihx3P6kEkRvQWIiAlhOkV8S4QexIgchrqZUG6eu4Yobi2h0sawOhMauGLXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bnpwph5R6qP5xt+g37ou8wG6vU34LAc/PW94akfEYXY=; b=Ss041XX/OjI0mSMsCZY4UMF1l8FXic+4v2kaWog9Jzb34RUX96CtrSJ7JtbXsP2KJpLBD7QgPr5V8lti6Hwpv74kW4OMas1j/j9Z0clzODCVPk4SmRUJJZTDnW717U9Iu4oUcQOI1nd/doqoReLYMGle4HkFt9PRub24GOcNS/xfQs6tXQqASZhp/0WSlbHCvlD1Prkp4DlOFu+NmS/cFPyF5h81Uewf5RM9Yq18klS4neao7Z0v4bXFZAkcf+ym0LwpRxITdx3S0vwYFsS497naiRVzTKygZFaBtC8Ir2tJ87/v7+EvlwZ+Wsd0RvmYOsRecns3QWvQpguT2njGYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bnpwph5R6qP5xt+g37ou8wG6vU34LAc/PW94akfEYXY=; b=5u16mFQkMqbl/VnkV0Np18xVD9UZMFU/ocPcNDMAGdLsAj/GCms6UKHKSwNCuBVy2VyHs3HV3aHXgtUsVGc7baMYP44mwg7Qd7hK3F+jCOysPOqmJUgHqV6r97+Oq06lmkgH6VZ97r4YWDQSsnKIHKzE1PMKcX8Dc0PYHl2oCho= Received: from DM6PR03CA0006.namprd03.prod.outlook.com (2603:10b6:5:40::19) by BL0PR12MB4849.namprd12.prod.outlook.com (2603:10b6:208:1c2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 05:52:30 +0000 Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:5:40:cafe::41) by DM6PR03CA0006.outlook.office365.com (2603:10b6:5:40::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 05:52:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:52:30 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:52:29 -0500 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:52:23 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 7/8] dmaengine: xilinx_dma: Program interrupt delay timeout Date: Tue, 20 Sep 2022 11:21:18 +0530 Message-ID: <20220920055119.12634-8-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT014:EE_|BL0PR12MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: b289f2fc-def5-45a4-8af8-08da9acc4e63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L3HkMCITttPEFhvdcH3tAUk2xsDbtFPf2TUlZfCId6qwxagOvVTkBZlyBCy80RUZ7x07bHM7I9MeX5Zp7r6UrJBQkY5CZl73vqudvH+tYEfKJ9JtNqPZQ7U4W37cY4R6lzskVVFCrSyWy58vVVHMB79DAfj17b8PHwVoBcoFCBoc5Un4qxSWYZhU12myHgNirdC3+M9yhO4jBg7Y7KzINBPudfiLm+QQHy1EykYjatqODukP5JeiW5fcBoBsA1ruQjSbJ2z7iSUBljfmACqiVslxhN7pgycMVlnmTxol/43Yy7PSN6yf07C+Uo0yYPpXI65IGb4hLUDqGht990dbBSXEgHF95SP5vYqrAFdlHfEGKx/irPpCBqtFavv57qfoFG2Cr3Q66Bw661cfbqCtpFwi0Yx0ZYw2hgEBlhPcOIJtu0r/80i3JTCxu8Kz26s/BD6E/x/IJjcCg8tOcn8fM/OcGLXafLtwC+RyFtcgknHnbJMmO5wiuA1C+CaPef32T+yiR2ciLQexeJpawys/y1cLvibHa6QPJ6Xhp70qwKyuHEd4i1cHHZWHBTW/2nRFkDjXg5dhIipC12a9yvlDZaWH1zKJ/LYfY09UPzWFcHG6LUzJTfVdqhio6hDvj29S/CBwPHYdNGPjQ/9mrA069Ih0mtu/blTvDk7dcS2cc4V1oL1W4M6kCtOdSapAi5SuCsKPE6MGUhRLo0z2ZCSWenFD99AbjWs7WuHsIQZGdhjG++rSWdETEiwe0y7bn3BScHSLeLYlVAISzISt0Oei2iQuDKHgbdyoJghUunk5tGplq/LQgjBIHgcLWv+WbKSz X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(40480700001)(36756003)(2906002)(316002)(426003)(36860700001)(47076005)(8676002)(82740400003)(4326008)(5660300002)(103116003)(70206006)(70586007)(8936002)(86362001)(110136005)(54906003)(336012)(1076003)(186003)(478600001)(2616005)(356005)(81166007)(26005)(6666004)(83380400001)(41300700001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:52:30.4561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b289f2fc-def5-45a4-8af8-08da9acc4e63 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Radhey Shyam Pandey Program IRQDelay for AXI DMA. The interrupt timeout mechanism causes the DMA engine to generate an interrupt after the delay time period has expired. It enables dmaengine to respond in real-time even though interrupt coalescing is configured. It also remove the placeholder for delay interrupt and merge it with frame completion interrupt. Since by default interrupt delay timeout is disabled this feature addition has no functional impact on VDMA and CDMA IP's. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Sarath Babu Naidu Gaddam --- Changes in V3: - None. Changes in V2: - Read irq delay timeout value from DT. - Merge interrupt processing for frame done and delay interrupt. --- drivers/dma/xilinx/xilinx_dma.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index 8126a56980f2..bd8f09837141 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -173,8 +173,10 @@ #define XILINX_DMA_MAX_TRANS_LEN_MAX 23 #define XILINX_DMA_V2_MAX_TRANS_LEN_MAX 26 #define XILINX_DMA_CR_COALESCE_MAX GENMASK(23, 16) +#define XILINX_DMA_CR_DELAY_MAX GENMASK(31, 24) #define XILINX_DMA_CR_CYCLIC_BD_EN_MASK BIT(4) #define XILINX_DMA_CR_COALESCE_SHIFT 16 +#define XILINX_DMA_CR_DELAY_SHIFT 24 #define XILINX_DMA_BD_SOP BIT(27) #define XILINX_DMA_BD_EOP BIT(26) #define XILINX_DMA_BD_COMP_MASK BIT(31) @@ -411,6 +413,7 @@ struct xilinx_dma_tx_descriptor { * @stop_transfer: Differentiate b/w DMA IP's quiesce * @tdest: TDEST value for mcdma * @has_vflip: S2MM vertical flip + * @irq_delay: Interrupt delay timeout */ struct xilinx_dma_chan { struct xilinx_dma_device *xdev; @@ -449,6 +452,7 @@ struct xilinx_dma_chan { int (*stop_transfer)(struct xilinx_dma_chan *chan); u16 tdest; bool has_vflip; + u8 irq_delay; }; =20 /** @@ -1561,6 +1565,9 @@ static void xilinx_dma_start_transfer(struct xilinx_d= ma_chan *chan) if (chan->has_sg) xilinx_write(chan, XILINX_DMA_REG_CURDESC, head_desc->async_tx.phys); + reg &=3D ~XILINX_DMA_CR_DELAY_MAX; + reg |=3D chan->irq_delay << XILINX_DMA_CR_DELAY_SHIFT; + dma_ctrl_write(chan, XILINX_DMA_REG_DMACR, reg); =20 xilinx_dma_start(chan); =20 @@ -1896,15 +1903,8 @@ static irqreturn_t xilinx_dma_irq_handler(int irq, v= oid *data) } } =20 - if (status & XILINX_DMA_DMASR_DLY_CNT_IRQ) { - /* - * Device takes too long to do the transfer when user requires - * responsiveness. - */ - dev_dbg(chan->dev, "Inter-packet latency too long\n"); - } - - if (status & XILINX_DMA_DMASR_FRM_CNT_IRQ) { + if (status & (XILINX_DMA_DMASR_FRM_CNT_IRQ | + XILINX_DMA_DMASR_DLY_CNT_IRQ)) { spin_lock(&chan->lock); xilinx_dma_complete_descriptor(chan); chan->idle =3D true; @@ -2831,6 +2831,8 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_de= vice *xdev, /* Retrieve the channel properties from the device tree */ has_dre =3D of_property_read_bool(node, "xlnx,include-dre"); =20 + of_property_read_u8(node, "xlnx,irq-delay", &chan->irq_delay); + chan->genlock =3D of_property_read_bool(node, "xlnx,genlock-mode"); =20 err =3D of_property_read_u32(node, "xlnx,datawidth", &value); --=20 2.25.1 From nobody Thu Apr 2 22:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ABF4C6FA82 for ; Tue, 20 Sep 2022 05:53:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbiITFxi (ORCPT ); Tue, 20 Sep 2022 01:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbiITFwm (ORCPT ); Tue, 20 Sep 2022 01:52:42 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2078.outbound.protection.outlook.com [40.107.243.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5805C52DC9; Mon, 19 Sep 2022 22:52:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fy/bOUTMVXK63dFN4vIOiHbiJT0buqiuyVEK4kgH510XJj8QLFKqf3A3nHhaf2s4IAjV/S9aUppC39X9Ah2YUhBiI411oWdO517E8zMS12Hb751hG7tX2LxnOZspkgd3CmXspDCuM/NQwp7mf964hQuJarZL6j4PikO+/3ATOtchlZmSEcMjwPcv8Iu5BRxNDjLe7XfvS4EPI8d+NSewbpEM094KM8FzCtfUDoFFrUjG7bQi5GUu7PXcES1BQM7JUgaoCXM0bFbpLuVWYtVJO636DgXknwtsHVsqbQHHF6fIPrO8rd4He3+P+Hqr6ofn8bK64vU/z9NrE0qwXLHEZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5orUK8nBhqdBEDHMBnoAS1sySktbTfLp0NvAF44yLqo=; b=j9a4SVAklk4hzCzRHfXbLOwFaBNYhqMO3NttszJlj8JU79Y4723p2yen3LJOyY70rAnlmj0PNV9J8cby5crdNYMWRbiOIRc4kgvVh4I6WNK8T5zcz3ri10nsWK1pXVzhw9jBEFCEffGSsaxYvzCF0iKW8xc8QU4IRfDu5PK2C/1d2i4K+QIg0S7kDOt0rBA3czAq/cF00zsn4rbK4gTAV5PwpqMWcZeQTYxLS22VpGVRHmwYvHwOI93x/9mDMc+w+j02v4jkOUJulodpok+2UoqOBDjIwXQ3Ys4fpcS7TUNdy3M3Lufv4ndO5xK9EfMpACBh/5MMebtV9n6ENzyvIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5orUK8nBhqdBEDHMBnoAS1sySktbTfLp0NvAF44yLqo=; b=OBrMi4TC/L6pa0Uej1j1uNEROrJx2B4MG99WgFtsl6SR773aILjrRqhBvpV2eQBoC6pKWjT7YEGlIAGBpy0CHg6ymfMs/adx19FnoKB06m6RvxJ2MFTnYmJhvMIlQnUYEXKEXEsX+UU8EUNHJhwGY8Qa/nYQNU/bvKO2EAgr+9A= Received: from DS7PR05CA0019.namprd05.prod.outlook.com (2603:10b6:5:3b9::24) by MW4PR12MB7144.namprd12.prod.outlook.com (2603:10b6:303:21b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 05:52:36 +0000 Received: from DM6NAM11FT009.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b9:cafe::73) by DS7PR05CA0019.outlook.office365.com (2603:10b6:5:3b9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.7 via Frontend Transport; Tue, 20 Sep 2022 05:52:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT009.mail.protection.outlook.com (10.13.173.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 05:52:36 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 20 Sep 2022 00:52:36 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 19 Sep 2022 22:52:35 -0700 Received: from xhdswatia40.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 20 Sep 2022 00:52:29 -0500 From: Sarath Babu Naidu Gaddam To: , , , , CC: , , , , , , , , , , Subject: [RFC V3 PATCH 8/8] dmaengine: xilinx_dma: Add device_config support Date: Tue, 20 Sep 2022 11:21:19 +0530 Message-ID: <20220920055119.12634-9-sarath.babu.naidu.gaddam@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT009:EE_|MW4PR12MB7144:EE_ X-MS-Office365-Filtering-Correlation-Id: 39d919ff-300a-44b9-d5c3-08da9acc5210 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IC7I6Rc1AFhhmzGiUiTSXmFCpGMsH4htFm8YdGK84Gppx7Q6fqk9RDYtj5rEIK8ib5PLXyc+IHNlfT3E+gRUehepvCxC/dCdCYoUs/N69j/dJRmNQvTv50lOHJuTWhS0NKmnrTtWZhbVoM+uJij/T2wvbmw03+cmNtYwsRMf9aITM/9yrPYjys7SKD0hasvHyS8HzJsA4mpQVo52L4j0GSEUPaKg4v72HdysqtBGKzmyzJC10yWuX78fUfkEy4UU6e8jxa53BXmlJBqFp6lchRsolDbxpbUcZ92FHJJgBAD7vQwdk3c+TNijUJtyMdjXZA/uZILPh+AHNb+o9E0m46NzyyZvI0KyIXaDd+Fdz7mTD9t2GTOG6dKGsiIfcm7kBCP3hE/VCE3/9yuo8ArCAh6SDj+JMSqX6ktz3Vkbnf8XQAHUrkc0c4Kc49vlp4/n4UdJHCyAWkZoQA1uM85jx/P0UCzfe7ND1LULATUFpQnZCC7tgMQZ7GWw+aZSeBvdFnPaAC1zmEXsK9/3uzVpL+Y5mGyygxz98IvbieVNlwIe1YjlFCr3JrQlS/4TEz16bLyGM4GCAZFTse1ILTMevxruB8u3TXOs1sl2qX7rf4JPmItUixpEwtiLFQ+CQNtcp/U/T46oWroni4uHtsXu7DqYo2w8sQC+iw/kp85IOxNYLoz/j6FWGLZz13GPfOqeIOkLXnyMU20RTQ6AkAZvhCFNFbF3lkGKU5wqzKwGX7khYQq1PIe9Pml09b9CH/9O24a59HftpdtJmI6zZnaJZGvWQykkItK1ZyOqRgp2+KOx35pRFF+fZ6ruVCkGK0O3 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(426003)(47076005)(186003)(1076003)(336012)(2616005)(82740400003)(81166007)(356005)(36860700001)(5660300002)(2906002)(8936002)(41300700001)(40480700001)(40460700003)(82310400005)(478600001)(26005)(6666004)(316002)(8676002)(70206006)(70586007)(54906003)(110136005)(4326008)(103116003)(36756003)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 05:52:36.6093 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39d919ff-300a-44b9-d5c3-08da9acc5210 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7144 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" DMA clients (ethernet driver) can use this interface to pass get/set coalesce information. Signed-off-by: Sarath Babu Naidu Gaddam --- At present device_config support to program coalesce is only for AXIDMA and once the RFC is accepted it will extended to other IP variants. Changes in V3: - New patch. --- drivers/dma/xilinx/xilinx_dma.c | 37 ++++++++++++++++++++++++++++++++- include/linux/dma/xilinx_dma.h | 16 ++++++++++++++ 2 files changed, 52 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index bd8f09837141..0a994c5f3ae0 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -414,6 +414,7 @@ struct xilinx_dma_tx_descriptor { * @tdest: TDEST value for mcdma * @has_vflip: S2MM vertical flip * @irq_delay: Interrupt delay timeout + * @has_static_coalesce: Used to check static/dynamic coalesce selection */ struct xilinx_dma_chan { struct xilinx_dma_device *xdev; @@ -453,6 +454,7 @@ struct xilinx_dma_chan { u16 tdest; bool has_vflip; u8 irq_delay; + u8 has_static_coalesce; }; =20 /** @@ -1555,7 +1557,7 @@ static void xilinx_dma_start_transfer(struct xilinx_d= ma_chan *chan) =20 reg =3D dma_ctrl_read(chan, XILINX_DMA_REG_DMACR); =20 - if (chan->desc_pendingcount <=3D XILINX_DMA_COALESCE_MAX) { + if (!(chan->has_static_coalesce) && chan->desc_pendingcount <=3D XILINX_D= MA_COALESCE_MAX) { reg &=3D ~XILINX_DMA_CR_COALESCE_MAX; reg |=3D chan->desc_pendingcount << XILINX_DMA_CR_COALESCE_SHIFT; @@ -1696,6 +1698,39 @@ static void xilinx_dma_issue_pending(struct dma_chan= *dchan) static int xilinx_dma_device_config(struct dma_chan *dchan, struct dma_slave_config *config) { + struct xilinx_dma_chan *chan =3D to_xilinx_chan(dchan); + u32 regval; + + if (chan->xdev->dma_config->dmatype =3D=3D XDMA_TYPE_AXIDMA) { + struct xilinx_peri_config *pconfig =3D config->peripheral_config; + + if (!pconfig || config->peripheral_size !=3D sizeof(*pconfig)) + return -EINVAL; + + switch (pconfig->cmd) { + case XILINX_DMA_GET_COALESCE: + regval =3D dma_ctrl_read(chan, XILINX_DMA_REG_DMACR); + regval &=3D XILINX_DMA_CR_COALESCE_MAX; + *((int *)pconfig->data) =3D regval >> XILINX_DMA_CR_COALESCE_SHIFT; + + break; + case XILINX_DMA_SET_COALESCE: + if ((*(int *)pconfig->data) <=3D XILINX_DMA_COALESCE_MAX) { + regval =3D dma_ctrl_read(chan, XILINX_DMA_REG_DMACR); + regval &=3D ~XILINX_DMA_CR_COALESCE_MAX; + regval |=3D ((*(int *)pconfig->data) << + XILINX_DMA_CR_COALESCE_SHIFT); + + dma_ctrl_write(chan, XILINX_DMA_REG_DMACR, regval); + chan->has_static_coalesce =3D 1; + } + + break; + default: + return -EINVAL; + } + } + return 0; } =20 diff --git a/include/linux/dma/xilinx_dma.h b/include/linux/dma/xilinx_dma.h index 0dde1a46ab75..ce0267baf5eb 100644 --- a/include/linux/dma/xilinx_dma.h +++ b/include/linux/dma/xilinx_dma.h @@ -41,5 +41,21 @@ struct xilinx_vdma_config { =20 int xilinx_vdma_channel_set_config(struct dma_chan *dchan, struct xilinx_vdma_config *cfg); +/** + * struct xilinx_peri_config -Configuration structure for user + * configurable commands and associated data. + *cmd: cmd for passing any slave info. Example: ethtool get/set c= oalesce + *data: data for cmd argument + */ +struct xilinx_peri_config { + int cmd; + void *data; +}; + +/** + * XILINX_DMA_GET/SET COALSCE -setting IP coalesce parameters + */ +#define XILINX_DMA_GET_COALESCE 1 +#define XILINX_DMA_SET_COALESCE 2 =20 #endif --=20 2.25.1