From nobody Thu Apr 2 23:11:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D6BC6FA82 for ; Tue, 20 Sep 2022 01:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbiITBkW (ORCPT ); Mon, 19 Sep 2022 21:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbiITBkK (ORCPT ); Mon, 19 Sep 2022 21:40:10 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60FE02C110 for ; Mon, 19 Sep 2022 18:40:09 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id s90-20020a17090a2f6300b00203a685a1aaso979602pjd.1 for ; Mon, 19 Sep 2022 18:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=z/jZBVKHrf7HtYZLUnYAd+Pe60b/PHa+auZtuaqhfT8=; b=GELw6kxnmMIS54piuXw1D2jHzquqtEbGgnBs1BoRuUm/1Xl0oB9ap2tJJB/hxxTv1B SNAg8ndEWyfQ523jqnXCxak6uTgDRMv5IjZGLDRRrxB07tS2RGhAnRp8i0mGU4JyPtDm uu+kzt5BgQhpGe9g7hyoEXVP57PHv1aILausGS8gM/xxdLELmLWx2LU1c83GXwGNkXVA SkdsjhH+R5BDrl+flKUj8j2LmOzBqNmyRJ7GQ9kxtoBZRYIPprRsz5UAyJF6gslGxhCS X/RR7wdmt4qZqZKqmGtWZ6YeN9MOF1D6eKRO3aLGYt82foLuIXD/ret3zOn1/gVOn+dS LLow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=z/jZBVKHrf7HtYZLUnYAd+Pe60b/PHa+auZtuaqhfT8=; b=7xW7SIAoxpm8PeaTjmKkRp9O/7NwC/EykMCrXEdzWEOrbl8VAh5xxq7HGw+k9fa+vb FyTFJWwkpvY2KVxUhB9pOAw9kPhZ/+bIScb9M7THhd7VsSFzYGZ/CxqVxjfgNfmPw+46 kIA9WdCbiugVG5j74O/IMdok02q6BkifEzqZGoXeTdvESyHX2tG24xAa5JGpQnEBw4F3 H9u3P7tdykGU78i1+qWeJqFDvw0yCzGygG2FEKI1SL4T+nC2ZhNyeKmTf3bkagBQnF6Q oFf05Yi27hUdAUhZU8A0Qqkn6eqxRM33jL3OpEKkQuccThbaRcCGRnwUE1w9Ik7oEsQH 8LxA== X-Gm-Message-State: ACrzQf1yig2F90Mud9O1E17UG+iFY5bq9NjeKxgm7i9QwWwPnhWHrlLc AUzartUXaFw/mj8Gln8eV+RidhmaQcM= X-Google-Smtp-Source: AMsMyM4ETgQztLEpmaQaOo8LEKK4XfhB73+RL6w9h0K4bSCtQwNdDamzeXqbSejusoWT0rH3Xnw0oA== X-Received: by 2002:a17:902:f550:b0:178:5b6a:3a1c with SMTP id h16-20020a170902f55000b001785b6a3a1cmr2540647plf.36.1663638008472; Mon, 19 Sep 2022 18:40:08 -0700 (PDT) Received: from daehojeong-desktop.mtv.corp.google.com ([2620:15c:211:201:720f:7de4:678:7fcb]) by smtp.gmail.com with ESMTPSA id m67-20020a633f46000000b00439c6a4e1ccsm54809pga.62.2022.09.19.18.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 18:40:08 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong Subject: [PATCH] f2fs: introduce F2FS_IOC_START_ATOMIC_REPLACE Date: Mon, 19 Sep 2022 18:40:03 -0700 Message-Id: <20220920014003.2295811-1-daeho43@gmail.com> X-Mailer: git-send-email 2.37.3.968.ga6b4b080e4-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daeho Jeong introduce a new ioctl to replace the whole content of a file atomically, which means it induces truncate and content update at the same time. We can start it with F2FS_IOC_START_ATOMIC_REPLACE and complete it with F2FS_IOC_COMMIT_ATOMIC_WRITE. Or abort it with F2FS_IOC_ABORT_ATOMIC_WRITE. Signed-off-by: Daeho Jeong --- v2: add undefined ioctl number reported by --- fs/f2fs/data.c | 3 +++ fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 12 ++++++++++-- fs/f2fs/segment.c | 14 +++++++++++++- include/uapi/linux/f2fs.h | 1 + 5 files changed, 28 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 6cd29a575105..d3d32db3a25d 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -3438,6 +3438,9 @@ static int prepare_atomic_write_begin(struct f2fs_sb_= info *sbi, else if (*blk_addr !=3D NULL_ADDR) return 0; =20 + if (is_inode_flag_set(inode, FI_ATOMIC_REPLACE)) + goto reserve_block; + /* Look for the block in the original inode */ err =3D __find_data_block(inode, index, &ori_blk_addr); if (err) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 539da7f12cfc..2c49da12d6d8 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -764,6 +764,7 @@ enum { FI_COMPRESS_RELEASED, /* compressed blocks were released */ FI_ALIGNED_WRITE, /* enable aligned write */ FI_COW_FILE, /* indicate COW file */ + FI_ATOMIC_REPLACE, /* indicate atomic replace */ FI_MAX, /* max flag, never be used */ }; =20 diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 4f9b80c41b1e..4abd9d2a55b3 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1982,7 +1982,7 @@ static int f2fs_ioc_getversion(struct file *filp, uns= igned long arg) return put_user(inode->i_generation, (int __user *)arg); } =20 -static int f2fs_ioc_start_atomic_write(struct file *filp) +static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) { struct inode *inode =3D file_inode(filp); struct user_namespace *mnt_userns =3D file_mnt_user_ns(filp); @@ -2051,6 +2051,12 @@ static int f2fs_ioc_start_atomic_write(struct file *= filp) =20 isize =3D i_size_read(inode); fi->original_i_size =3D isize; + if (truncate) { + set_inode_flag(inode, FI_ATOMIC_REPLACE); + truncate_inode_pages_final(inode->i_mapping); + f2fs_i_size_write(inode, 0); + isize =3D 0; + } f2fs_i_size_write(fi->cow_inode, isize); =20 spin_lock(&sbi->inode_lock[ATOMIC_FILE]); @@ -4080,7 +4086,9 @@ static long __f2fs_ioctl(struct file *filp, unsigned = int cmd, unsigned long arg) case FS_IOC_GETVERSION: return f2fs_ioc_getversion(filp, arg); case F2FS_IOC_START_ATOMIC_WRITE: - return f2fs_ioc_start_atomic_write(filp); + return f2fs_ioc_start_atomic_write(filp, false); + case F2FS_IOC_START_ATOMIC_REPLACE: + return f2fs_ioc_start_atomic_write(filp, true); case F2FS_IOC_COMMIT_ATOMIC_WRITE: return f2fs_ioc_commit_atomic_write(filp); case F2FS_IOC_ABORT_ATOMIC_WRITE: diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 143b7ea0fb8e..c524538a9013 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -263,14 +263,26 @@ static void __complete_revoke_list(struct inode *inod= e, struct list_head *head, bool revoke) { struct revoke_entry *cur, *tmp; + pgoff_t start_index =3D 0; + bool truncate =3D is_inode_flag_set(inode, FI_ATOMIC_REPLACE); =20 list_for_each_entry_safe(cur, tmp, head, list) { - if (revoke) + if (revoke) { __replace_atomic_write_block(inode, cur->index, cur->old_addr, NULL, true); + } else if (truncate) { + f2fs_truncate_hole(inode, start_index, cur->index); + start_index =3D cur->index + 1; + } + list_del(&cur->list); kmem_cache_free(revoke_entry_slab, cur); } + + if (!revoke && truncate) { + f2fs_do_truncate_blocks(inode, start_index * PAGE_SIZE, false); + clear_inode_flag(inode, FI_ATOMIC_REPLACE); + } } =20 static int __f2fs_commit_atomic_write(struct inode *inode) diff --git a/include/uapi/linux/f2fs.h b/include/uapi/linux/f2fs.h index 3121d127d5aa..955d440be104 100644 --- a/include/uapi/linux/f2fs.h +++ b/include/uapi/linux/f2fs.h @@ -42,6 +42,7 @@ struct f2fs_comp_option) #define F2FS_IOC_DECOMPRESS_FILE _IO(F2FS_IOCTL_MAGIC, 23) #define F2FS_IOC_COMPRESS_FILE _IO(F2FS_IOCTL_MAGIC, 24) +#define F2FS_IOC_START_ATOMIC_REPLACE _IO(F2FS_IOCTL_MAGIC, 25) =20 /* * should be same as XFS_IOC_GOINGDOWN. --=20 2.37.3.968.ga6b4b080e4-goog