From nobody Tue May 7 05:13:30 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE4FC47088 for ; Fri, 2 Dec 2022 17:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234154AbiLBRWA (ORCPT ); Fri, 2 Dec 2022 12:22:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233497AbiLBRVx (ORCPT ); Fri, 2 Dec 2022 12:21:53 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B56AE7861 for ; Fri, 2 Dec 2022 09:21:52 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id n20so13157198ejh.0 for ; Fri, 02 Dec 2022 09:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EhS+JBqxHQJxyGff9DpvK+kt09IedMih5IP8k22GY28=; b=CDmPCRBe4IMk6p0oPlsz1zfKi7fsgZn30ytnDuUodDsq+R0J3sCgnUXk2+KAwY84qz dhYh/JyqBoWJgHb86Hw+Uc/s6Ej7yTzgzxNPALs9bCzWRbpPq++MZeNZxEd9DTOyXmWf oNAHsYnMqAvXhSUylCHPDssa5ks2raFhpco4s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EhS+JBqxHQJxyGff9DpvK+kt09IedMih5IP8k22GY28=; b=nWjexhNurlx1TUSfpVgTC6DWE1ZeopgpvhdIL78ziAlHBfzcoR4abWQ2JwSGsxvQYx gVy3bXKBonibiHw0JE7PmOkJCeQdp21VYgJnxEK4yeB3/thO1Pzgh45rPBga0ibk5lvy jqXCWWKC6LUcX0D07+sLzmWycAVpLx3sEUD2FLF3gYlmVPeuzopSkxtLiY9dLqTHkRXK 17TR4fhrnQf92eaSj2bDYGJtkGqeQjHr3yKxxlztY0Ifte1IrwaAaLP7Re6CB3SjGwiQ cGbZsPPiwm/OIAwR6O86+WplIXYEQk0yAyicUbYGCbYTOCyCyZkjKtydVkQpmk4GJJ0u ibsA== X-Gm-Message-State: ANoB5plUFYnUq83Aojc4wNfrnTpxbqTYVibRAO+KQG2qa7FV0Scbc6K5 mb9SQFzK6qUgX3sVxe1TUb6U2w== X-Google-Smtp-Source: AA0mqf7JWgDbMIHLMrOHMVSeCYaxJbQsRDC1nP0YmwjU76wCPH/5s9B8MdAkRHhsIDfobJHnnQ/z6w== X-Received: by 2002:a17:906:2352:b0:7ad:a030:487e with SMTP id m18-20020a170906235200b007ada030487emr62542555eja.508.1670001710996; Fri, 02 Dec 2022 09:21:50 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id fe17-20020a1709072a5100b007be301a1d51sm3206685ejc.211.2022.12.02.09.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 09:21:50 -0800 (PST) From: Ricardo Ribalda Date: Fri, 02 Dec 2022 18:21:35 +0100 Subject: [PATCH RESEND v2 1/7] media: uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20220920-resend-v4l2-compliance-v2-1-b0ceb15353ac@chromium.org> References: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> In-Reply-To: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org, Ricardo Ribalda , linux-kernel@vger.kernel.org, Hans Verkuil X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=5265; i=ribalda@chromium.org; h=from:subject:message-id; bh=tVt2FQwFWMzsSMl0muyb+NJLs92ZMfXZ/5urTCanEaY=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjijQj5Jwb/s3MtZM6LnzqyJVwaqUWM2+ULqkL3TGt 3vilUAyJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY4o0IwAKCRDRN9E+zzrEiOlCEA Ca5s+4X4YKwXvy9cPwI/cDHlh15ZgXJZ+3di0azDRwhMWVjUZDovHBJhz7sDnwO7gWCn7omPDq5mdF IEgEJw5ZyyqjFp33oDe4xjBdafldE23hYh8gXUj6DjyxsdkSrLbUaZfS+PeCeiHNEVu8FWnsvEtwkJ Nv34577sjadbyXkNpaQFJFAdfbB5BOy667bUv06sCYdrzNAlXS1JyJmanypFGF4pUHAuQLH74LdWHq Z55HJJQCp8e+PqgHP/Lenhxe6FbBNvjIQ8D2abzxdOENvF8lND3G5q1zWbXYD+BeLFjhhq0bh/iIY4 bQdpdusLhL3llwyD88qaeaYOv/vnKpjGwdkRsVYuO8CaHQEaxNO/zjJ6k9NM0zU6fSCeC06MlmKup8 qKk1p4Cmm/nK6UDPpDOV+iA5LCFocWb9ADgm30RqsBKBr7+j7Of+D9KaNXWr6JUk5lTbPcIEBthnaf Qsg7kW2hihNgm1+AehAEodK3mqIcw29zpU2PCtERvf7hHZ7rD75wYTfFWBz3TM+PnTARDuVI/aXLDF b7tTXVdx8zezvsWCO91S80571pnbwQEUbKcA8R1b9+8Uv3CcvyjEo8Oi/XrtrQxJ+NpmgbK2h7GaaX 3554EW94M64DmLTeV+PNX7aObgbodMhFZahMNMoXg3zysIb3cHGxA89rBW0A== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil Check for inactive controls in uvc_ctrl_is_accessible(). Use the new value for the master_id controls if present, otherwise use the existing value to determine if it is OK to set the control. Doing this here avoids attempting to set an inactive control, which will return an error from the USB device, which returns an invalid errorcode. This fixes: warn: v4l2-test-controls.cpp(483): s_ctrl returned EIO =C2=A0 warn: v4l2-test-controls.cpp(483): s_ctrl returned EIO test VIDIOC_G/S_CTRL: OK =C2=A0 warn: v4l2-test-controls.cpp(739): s_ext_ctrls returned EIO =C2=A0 warn: v4l2-test-controls.cpp(739): s_ext_ctrls returned EIO =C2=A0 warn: v4l2-test-controls.cpp(816): s_ext_ctrls returned EIO test VIDIOC_G/S/TRY_EXT_CTRLS: OK Tested with: v4l2-ctl -c auto_exposure=3D1 OK v4l2-ctl -c exposure_time_absolute=3D251 OK v4l2-ctl -c auto_exposure=3D3 OK v4l2-ctl -c exposure_time_absolute=3D251 VIDIOC_S_EXT_CTRLS: failed: Input/output error exposure_time_absolute: Input/output error ERROR v4l2-ctl -c auto_exposure=3D3,exposure_time_absolute=3D251,auto_exposure=3D1 v4l2-ctl -C auto_exposure,exposure_time_absolute =C2=A0 auto_exposure: 1 exposure_time_absolute: 251 Reviewed-by: Ricardo Ribalda Signed-off-by: Hans Verkuil --- drivers/media/usb/uvc/uvc_ctrl.c | 47 ++++++++++++++++++++++++++++++++++++= +++- drivers/media/usb/uvc/uvc_v4l2.c | 4 ++-- drivers/media/usb/uvc/uvcvideo.h | 3 ++- 3 files changed, 50 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 8c208db9600b..7153ee5aabb1 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1064,11 +1064,33 @@ static int uvc_query_v4l2_class(struct uvc_video_ch= ain *chain, u32 req_id, return 0; } =20 +/** + * uvc_ctrl_is_accessible() - Check if a control can be read/writen/tried. + * @chain: uvc_video_chain that the controls belong to. + * @v4l2_id: video4linux id of the control. + * @ctrl: Other controls that will be accessed in the ioctl. + * @ioctl: ioctl used to access the control. + * + * Check if a control can be accessed by a specicific ioctl operation, + * assuming that other controls are also going to be accessed by that ioct= l. + * We need to check the value of the other controls, to support operations + * where a master value is changed with a slave value. Eg. + * auto_exposure=3D1,exposure_time_absolute=3D251 + * + */ int uvc_ctrl_is_accessible(struct uvc_video_chain *chain, u32 v4l2_id, - bool read) + const struct v4l2_ext_controls *ctrls, + unsigned long ioctl) { + struct uvc_control_mapping *master_map =3D NULL; + struct uvc_control *master_ctrl =3D NULL; struct uvc_control_mapping *mapping; struct uvc_control *ctrl; + bool read =3D ioctl =3D=3D VIDIOC_G_EXT_CTRLS; + bool try =3D ioctl =3D=3D VIDIOC_TRY_EXT_CTRLS; + s32 val; + int ret; + int i; =20 if (__uvc_query_v4l2_class(chain, v4l2_id, 0) >=3D 0) return -EACCES; @@ -1083,6 +1105,29 @@ int uvc_ctrl_is_accessible(struct uvc_video_chain *c= hain, u32 v4l2_id, if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR) && !read) return -EACCES; =20 + if (read || try || !mapping->master_id) + return 0; + + /* + * Iterate backwards in cases where the master control is accessed + * multiple times in the same ioctl. We want the last value. + */ + for (i =3D ctrls->count - 1; i >=3D 0; i--) { + if (ctrls->controls[i].id =3D=3D mapping->master_id) + return ctrls->controls[i].value =3D=3D + mapping->master_manual ? 0 : -EACCES; + } + + __uvc_find_control(ctrl->entity, mapping->master_id, &master_map, + &master_ctrl, 0); + + if (!master_ctrl || !(master_ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR)) + return 0; + + ret =3D __uvc_ctrl_get(chain, master_ctrl, master_map, &val); + if (ret >=3D 0 && val !=3D mapping->master_manual) + return -EACCES; + return 0; } =20 diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 4cc3fa6b8c98..d95168cdc2d1 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1020,8 +1020,8 @@ static int uvc_ctrl_check_access(struct uvc_video_cha= in *chain, int ret =3D 0; =20 for (i =3D 0; i < ctrls->count; ++ctrl, ++i) { - ret =3D uvc_ctrl_is_accessible(chain, ctrl->id, - ioctl =3D=3D VIDIOC_G_EXT_CTRLS); + ret =3D uvc_ctrl_is_accessible(chain, ctrl->id, ctrls, + ioctl); if (ret) break; } diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 24c911aeebce..644d5fcf2eef 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -905,7 +905,8 @@ static inline int uvc_ctrl_rollback(struct uvc_fh *hand= le) int uvc_ctrl_get(struct uvc_video_chain *chain, struct v4l2_ext_control *x= ctrl); int uvc_ctrl_set(struct uvc_fh *handle, struct v4l2_ext_control *xctrl); int uvc_ctrl_is_accessible(struct uvc_video_chain *chain, u32 v4l2_id, - bool read); + const struct v4l2_ext_controls *ctrls, + unsigned long ioctl); =20 int uvc_xu_ctrl_query(struct uvc_video_chain *chain, struct uvc_xu_control_query *xqry); --=20 2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae From nobody Tue May 7 05:13:30 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D439CC4321E for ; Fri, 2 Dec 2022 17:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233509AbiLBRWF (ORCPT ); Fri, 2 Dec 2022 12:22:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233664AbiLBRVy (ORCPT ); Fri, 2 Dec 2022 12:21:54 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E0466F0F6 for ; Fri, 2 Dec 2022 09:21:53 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id td2so13070550ejc.5 for ; Fri, 02 Dec 2022 09:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zQFSXPNg1gYWDjvMJz4jAnc9KE0EX4hKeDHlzX5rMq8=; b=BnzWpCO8mKVwdT7GTBAEcgvYbnL01MbI5NQsr83wBtyLA52vq8ngug/Do3zkiBUTGU EFl1ygWJntPuZIG82M32FyljDEI925ivDIflHNPNj/4vs3/lo3hJx+86WVXnlJiu3J2c S82/5sdSnehGTxs2P7Qm+mLT4cQUErat50eHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zQFSXPNg1gYWDjvMJz4jAnc9KE0EX4hKeDHlzX5rMq8=; b=azs6djI7GnN8Ej1PtUtnTUEW4XKRQZpsePdJ8CJ7BCuhZYx/Eo39B8y8wv6fqjJbqu 2Q7BEiuTGyAjlX7fn6uXvICmPBfDCN4mYYFPZW4Rof+RmhK7jegfEUUg4ikn5QeUukEd NkzgchJ/CPjD/pjLelJVP39Y+jHnNv2zsUojSKDL276QgMJN9g4iEwFE7dSSK5o5x9yW JT+Sbl/OVbhAGm13I/tuaD4gOlNFYS76CNHotBMLI3MRvMQ+EJTAL38hHKcZJotk9Tmp wjmaE0sVSRkv9d9DT4W93Meyas7dNnFnoBMwJvF3cKdWXytq4njDp3hjO67xbfi8ktxp 3xJw== X-Gm-Message-State: ANoB5pk1/8PsJjRKR+Sg1sNX0HvuD4AwqhqxvO1qWD4dDyPJatCojgXx vMIR8dW3bMQW71d+3iNcOcLmmQ== X-Google-Smtp-Source: AA0mqf4+9k23pGxMtPaDV7JNlE7qOO4EcQSAltmwU541N1ARqTeqfv6lznQMxyulYOVRBeA6QaPnPw== X-Received: by 2002:a17:906:a198:b0:7b4:bc42:3b44 with SMTP id s24-20020a170906a19800b007b4bc423b44mr54135498ejy.101.1670001711651; Fri, 02 Dec 2022 09:21:51 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id fe17-20020a1709072a5100b007be301a1d51sm3206685ejc.211.2022.12.02.09.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 09:21:51 -0800 (PST) From: Ricardo Ribalda Date: Fri, 02 Dec 2022 18:21:36 +0100 Subject: [PATCH RESEND v2 2/7] media: uvcvideo: improve error logging in uvc_query_ctrl() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20220920-resend-v4l2-compliance-v2-2-b0ceb15353ac@chromium.org> References: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> In-Reply-To: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org, Ricardo Ribalda , linux-kernel@vger.kernel.org, Hans Verkuil X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=1265; i=ribalda@chromium.org; h=from:subject:message-id; bh=rgm9ldOQdFvtTQWrF5DcxtzEXVIXvtMre8cRCEzUeW8=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjijQkk2KiH3FCrs6/9FkXB8JArDKnUjOw4uk6Fbtq tybbomSJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY4o0JAAKCRDRN9E+zzrEiFFZD/ 44nlgQCwCgK7bIXKPqOnXBjUX/CBmpUHIfxXj/WT7srZAhrBEf52wH6Z+F3HUfHHnysgURi+FmipeW eanU/JiSfbgezrCmitzwHf/MZx0ugYok1EBad4MXzQid7LYim1h8MbG0FXViYI2DazlxdVEVxGw83K uGOpjPnUbwqr1RzrJfGVQqzg6YtFv6qs96q+sbD8f8j6sKPIszBB9zk4z2hzcu7jzNW4kGWa9d5n5S uRnD55iYeMYIgfeMc4uUzQE6e+m2KDZEGg9ilTutFYMKkSyM3YDLhXMIlS6DX/nJ9SdEn6RF+hbDuk MMZH0R/Hf4VFsnnlKOclKCGHBU3WOBID8LLJ7JbLdKzKQVR7YeKbKpR8xEAqyl9RXzGttP3XxG/4ej zk6bn+zSrjgVqKdNUOU+6xZSS8wtFi9cuyG/0rrlJUIQP/Yjkay+45QwlfZRZYmboc91bNjzYj6iif 3acLBeKaHDp1jKDnX42a5YVmNke18FNKUGCv5j1sDS9cb1eIWJwAfvDyTNyBf4TcuE3rByLUh9uhOQ epjRq9+/JZ9ZwmJF95UhecCD4aiKFVYzCxASZ47wB6XyalMRyJiTnu3cO2h6rIjzRhLn2vbk950J23 QxVYNTgEWAgfSLdCv+UUP8TaXwWa74cfPhNKhCDrJPkUEriwiD76ol3tn/Ug== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil If __uvc_query_ctrl() failed with a non-EPIPE error, then report that with dev_err. If an error code is obtained, then report that with dev_dbg. Reviewed-by: Ricardo Ribalda Signed-off-by: Hans Verkuil --- drivers/media/usb/uvc/uvc_video.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_= video.c index 170a008f4006..2cf7f692c0bb 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -79,13 +79,14 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8= unit, if (likely(ret =3D=3D size)) return 0; =20 - dev_err(&dev->udev->dev, - "Failed to query (%s) UVC control %u on unit %u: %d (exp. %u).\n", - uvc_query_name(query), cs, unit, ret, size); - - if (ret !=3D -EPIPE) + if (ret !=3D -EPIPE) { + dev_err(&dev->udev->dev, + "Failed to query (%s) UVC control %u on unit %u: %d (exp. %u).\n", + uvc_query_name(query), cs, unit, ret, size); return ret; + } =20 + /* reuse data[0] to request the error code. */ tmp =3D *(u8 *)data; =20 ret =3D __uvc_query_ctrl(dev, UVC_GET_CUR, 0, intfnum, --=20 2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae From nobody Tue May 7 05:13:30 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C7FC4321E for ; Fri, 2 Dec 2022 17:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233956AbiLBRWK (ORCPT ); Fri, 2 Dec 2022 12:22:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233809AbiLBRVy (ORCPT ); Fri, 2 Dec 2022 12:21:54 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF6A2E7879 for ; Fri, 2 Dec 2022 09:21:53 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id bj12so13034889ejb.13 for ; Fri, 02 Dec 2022 09:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bxw2Ty4M46rsTuihUXRiS/Nyvg7teTU6EvDgGOU8X18=; b=jJEVHDdlvpUPCZhRaERran9eUhOM2qlOOFnRvqqedej3zPhgq021ZTuEjKL2vx3Out b4kvxDCjksOswC5RpRzF5475S3alzk2VfBobREeil0g6d3/kqEjadY7zGkArNg7AirEA lZs9jbuWvXKaDNHErwa1oINVxV5f3Y8fHla3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bxw2Ty4M46rsTuihUXRiS/Nyvg7teTU6EvDgGOU8X18=; b=qFKH+7/XvwGibP4KvoUM4WG39+VNgqamLbQrz68OsIMg6IiEF5w5jPJkzBbD2gJvT7 pEhN66RCGr/Gxiaccz0APVsr4vi6qzey4zW7PggHDhxPBJUr2wYSNwNq3Oe49ImiLRkZ 8jD2S3jDYTcMsDlpM0FnYDlK1pi8/emLoys/6YIgYiQUQHdYwr11nfwDe32TC/jzxI7b F7ndY9Tr2LyNatHgjzmTOddjQkmhO9MU2sosIyewnhCsuVIop54+QQqKI3DCM5H38UUB lK4kkE2RPK/88DNn6eUKoi3ITq5MVCznvK2w5bW5TRjYav4fRYHE5ipUA2y72kjsNPme FSOg== X-Gm-Message-State: ANoB5plwx7OLGJWu7MK5uwWyrqviVcEjeb/NIctK7//e8s6D8fVCfctX FVpgm3lmKeMKxDHBwW+0GqUs7A== X-Google-Smtp-Source: AA0mqf5ngiwbD9mStRSED8Dqbs841Uw8JJSsairpGupHjMXbrcVc0NQ0viZ2vxp9N3+lD4bS/MV+DA== X-Received: by 2002:a17:906:a019:b0:7be:e774:5aad with SMTP id p25-20020a170906a01900b007bee7745aadmr11360543ejy.426.1670001712399; Fri, 02 Dec 2022 09:21:52 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id fe17-20020a1709072a5100b007be301a1d51sm3206685ejc.211.2022.12.02.09.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 09:21:52 -0800 (PST) From: Ricardo Ribalda Date: Fri, 02 Dec 2022 18:21:37 +0100 Subject: [PATCH RESEND v2 3/7] media: uvcvideo: Return -EACCES for Wrong state error MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20220920-resend-v4l2-compliance-v2-3-b0ceb15353ac@chromium.org> References: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> In-Reply-To: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org, Ricardo Ribalda , linux-kernel@vger.kernel.org, Hans Verkuil X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=982; i=ribalda@chromium.org; h=from:subject:message-id; bh=0oIT1Gw1hO0u+7q6An7Ai/dJe13xUDjVNu6Ry1clGFI=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjijQmpIoIjFr3y9ZZLwbmXpabLfWEY4uztWa1E3R0 pSoPKi2JAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY4o0JgAKCRDRN9E+zzrEiAbNEA CaYQocLmpu+Q7+j7T3rRhdnpqASN9EbtMtNzOxii2/ubnfHq8sWhoBFOqlh5IlyN5ItBymGP5ZUzVQ F9Jm+m2UXqvIMvNJAFdDpMyh39BGX53KocfkJJz1w3OO6q0uD/owPRd0P30tC0c6PTIunSLHguVnDz m3bP+NxPjJth125jxjTCyBPG416uvP3gRcAYT/nH61IDmaMMutBFgBkxTMhdRCkCc0iQ1notbaFR4c M5jXlHqroH9o1iYVed2w69/mTRUJSXkv/u06WKGmr3VLD/WhQ/WjkaPbO9eGUEOdrHBuGC1/nUWGik LEWOvGvOpYV/3QWlbs0ThkJDeqy5ZhPuVLAepKGLSEI722isfSbCt2gH8mdawjwS5rFEfM4glXY77g 8FzLCNdn9/CPEyoyH9+mDzSPmx/zl4Rojhbygg3inwSyvkZIZMpkGOk6J9hM83bX79TsxiJgq1bv3A DwZAR4Tz5YlrCsGQYCmcjQb0k3VnP32Iszz/y9nFMfW1dQVZO2ed71fvMK1QStR2CNXtLeAcPTXL87 5agpKQmlJA7QANvJRYHbu9ftRXFAhOC2FjTe9ZoqclTupa/XTX8GCyY15ibV+a65ueo2Xe6weBxJtO Q4ofJX028Tnd37JPaCN+e71KmtbiqLQMFPa449J5eeoUuW083H9WX/Tk2fww== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For error 2 (Wrong state) return -EACCES instead of -EILSEQ. EACCES is a much more appropriate error code. EILSEQ will return "Invalid or incomplete multibyte or wide character." in strerror(), which is a *very* confusing message. Suggested-by: Hans Verkuil Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_= video.c index 2cf7f692c0bb..497073a50194 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -108,7 +108,7 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8= unit, case 1: /* Not ready */ return -EBUSY; case 2: /* Wrong state */ - return -EILSEQ; + return -EACCES; case 3: /* Power */ return -EREMOTE; case 4: /* Out of range */ --=20 2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae From nobody Tue May 7 05:13:30 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A26C4321E for ; Fri, 2 Dec 2022 17:22:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234096AbiLBRWS (ORCPT ); Fri, 2 Dec 2022 12:22:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233973AbiLBRVz (ORCPT ); Fri, 2 Dec 2022 12:21:55 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AECFC9D2C3 for ; Fri, 2 Dec 2022 09:21:54 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id bj12so13034963ejb.13 for ; Fri, 02 Dec 2022 09:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z1aPiVVPlDCTllBooA/cyjkx+Y2V7OSiqGOhFRZ36VQ=; b=IxByCPcfz52cTjbTUwN9fgOj6PnMnGahYA4D0I8s/mvxj1OKSMmPnHkCkGnL21MAiv W7aVZXSCrZ8kgANumWp6xzJCsnhy3ss+ZEB1/naDxPGe0nKDm4mcF8ZkLBFwGU/7MHUM wgXDwFDZB+bbqMRHRn6N4fuN5u8qtqUfTzdZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z1aPiVVPlDCTllBooA/cyjkx+Y2V7OSiqGOhFRZ36VQ=; b=QfGyDIjxkaiHftn1kn5JIg4Dh1WWj6NlDvpEwaRPcSoBrCLS37BVOKvpBiuAK+OwEe wtZ84Bw6R35aphOTcp0FjsjwtfSHOfE/wuFyWOBmWDxjxMIQUrBhffxcEDM17WWOA1Ig U1d50H4R1Ei+VhWwuvZVgKhSd8UO34BtyAqbLtjCxzpFF4q+1nUvCu7iVwu8FSvE10Zb YHnATB3ugMFS2TYW/EDfVqo/Q8jI/yD67phMCP1oT0+5Rx49SnUpO4CDQAWCmDx0GCi6 JAcNm8wPtKpyqZ1ouYBYEkTa3HxtMhd9lw0xuUbgBCHpMHEQ26R/zro5zwckHusTEGnA 0Aqg== X-Gm-Message-State: ANoB5pkqPg8GLVmpQ0hwlYaIZYPZyamFXScz2EPe+p/fFTRdICe2FLwh Ap0vAo6ghMfFvR7tutDeq3BvYQ== X-Google-Smtp-Source: AA0mqf58vmIx5s+b1HfIhaIXZqjzqJHQji7aPfW00SR16AxnjCB2+Pf4gGBLfuGY1HlfhBUVWHh2Bw== X-Received: by 2002:a17:906:4e8c:b0:7ba:9c18:1204 with SMTP id v12-20020a1709064e8c00b007ba9c181204mr39579362eju.262.1670001713325; Fri, 02 Dec 2022 09:21:53 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id fe17-20020a1709072a5100b007be301a1d51sm3206685ejc.211.2022.12.02.09.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 09:21:52 -0800 (PST) From: Ricardo Ribalda Date: Fri, 02 Dec 2022 18:21:38 +0100 Subject: [PATCH RESEND v2 4/7] media: uvcvideo: Do not return positive errors in uvc_query_ctrl() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20220920-resend-v4l2-compliance-v2-4-b0ceb15353ac@chromium.org> References: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> In-Reply-To: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org, Ricardo Ribalda , linux-kernel@vger.kernel.org, Hans Verkuil X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=963; i=ribalda@chromium.org; h=from:subject:message-id; bh=CrX1QP0MUpT5GPNS9+y3kLIDIjsOHF6cFLdPMYSyV0Y=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjijQop6CSX4WKA8eEwB7KCAVyCeS/f5mL+1jPm51Z w2ePrMCJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY4o0KAAKCRDRN9E+zzrEiBncD/ 4ymJjJEZahs1/dcQ6bbs2dRSxIPYY4z6ip53LnN1v8aiXVNs38zmQpamI0E4D3idP8W8YLqFaUpJj1 VuaKlsIMzd0FkwkrmL2FX9c/5Pcxeq7kXRZ3dimv52i7KkU51etyTQiNT+HNHsiRW6iFoyu3nF2krB Ifu8QTRJ/FMW/aFQK3aQgQIIP1WdH2FoJZxyHTU0cJufBFZOxvpTw349g4ameJ4Yd4RLDs8enVf2fD CUVspusW9j5a2FKBq3JS6qBAhDNoyC5r0OU6DEg4WSTiSsKG/6YFMZ7AnwuDq00PjyQQBVJegS2LBl 7SzZBdSNaD27CvrqPPY+oHRSGdYAc+4AnV9qcAraJaVCoa1Ym1JgCTJx0PMmq3ar7nNBg9qBmUkpl9 CPhJsK5t9zTK1WmLo/PsCyBfpnh61KWNX5t/lMcn1YwwU6aj1a1vTtSKVXWuFc3+Trzp76KThakFyy 0ZIjsXZQSbphInK/AyKcmo0UMbfi+gLUzsfogSvNnucR9aJQpHo2xThNPnkJPiL0+fUrSQ4eZOaFMP dVOlJ3CmM/z9ZVyiaHXWfPf48pkriKxLwNn7jegVhXLir88b9SCyhbzwEEgWk8ZapV40Lkd9gBme6G HRAVQIqF9M2BxQkAdLZAeyxDtB4Nb9Etfwq1kSToDJ0lWWYk67/eUxZjee4A== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the returned size of the query does not match the expected size or it is zero, return -EPIPE instead of 0 or a positive value. Suggested-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_= video.c index 497073a50194..902f2817a743 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -83,7 +83,7 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 u= nit, dev_err(&dev->udev->dev, "Failed to query (%s) UVC control %u on unit %u: %d (exp. %u).\n", uvc_query_name(query), cs, unit, ret, size); - return ret; + return ret < 0 ? ret : -EPIPE; } =20 /* reuse data[0] to request the error code. */ --=20 2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae From nobody Tue May 7 05:13:30 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FB0C47089 for ; Fri, 2 Dec 2022 17:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233809AbiLBRWP (ORCPT ); Fri, 2 Dec 2022 12:22:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234096AbiLBRV4 (ORCPT ); Fri, 2 Dec 2022 12:21:56 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67717E7879 for ; Fri, 2 Dec 2022 09:21:55 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id bj12so13035029ejb.13 for ; Fri, 02 Dec 2022 09:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1TOCYbcSDGYo9uBDae2YM90jdMCkFXFL9pKLx8gH8lk=; b=Rv8G+gUWpIQ0RpbmMyAexFTzcwXByWUGtbzZhNjQV34dWvYdqMGVOyV2zgXVLnStUI JreWZrXYPkvYSMfX3iLfHq8zfjqx+7nFjRu1T6UvpwfVUHXcrrefkFAztT2nA9iV1aBf 9PKgvJcAuYoIrWWM1bdOOwvDxl6pCt6GEzHVw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1TOCYbcSDGYo9uBDae2YM90jdMCkFXFL9pKLx8gH8lk=; b=fXfSVmleq67wo/EW62J0MlZKtaGCNmZy7jNpY0yoFQPhimoEwCH1YTC3O62hSMpqrX 3Yf/OnYfMArNrEKYn9/f5VsPkxOTqLkEXvFv2HlQGS1oszj7XgS5OgparkWMtPjJLXGD tAkCiz1TeYChwQfrjp8z4Hi4OEs60rD4r77PnymecVZjV6goeeAyeUCVbNiB0j7wHJ7M IS3iO25u9pPUT5wm/qZaHcXL+1z7FzcYXOj34kO1m01/vzypcZYJu8Z5dZ5Mi8W0+o+b BH9VVPo9Kk1MCsDN/ooKbCSHmJWQKYcmX97zD+6S5HDGXAzjtuOnlfGhS3FeIO8dGmGE FMtQ== X-Gm-Message-State: ANoB5pkCTkkE6I99etkNH+Yf1YApqsor5dHu4fKHx5kS9YWeipGntPrj WbWCTKcbrlz9iFDCMdltnUel3w== X-Google-Smtp-Source: AA0mqf4YI5O/1Q0etPueEfxbOhCrWpfHsgxQYe97PVIfsp7yScExzeZqmoEDXX7hwm2eGhImyXPRwA== X-Received: by 2002:a17:906:a387:b0:7bc:2ad:7c1e with SMTP id k7-20020a170906a38700b007bc02ad7c1emr34567522ejz.588.1670001713981; Fri, 02 Dec 2022 09:21:53 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id fe17-20020a1709072a5100b007be301a1d51sm3206685ejc.211.2022.12.02.09.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 09:21:53 -0800 (PST) From: Ricardo Ribalda Date: Fri, 02 Dec 2022 18:21:39 +0100 Subject: [PATCH RESEND v2 5/7] media: uvcvideo: Fix handling on Bitmask controls MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20220920-resend-v4l2-compliance-v2-5-b0ceb15353ac@chromium.org> References: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> In-Reply-To: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org, Ricardo Ribalda , linux-kernel@vger.kernel.org, Hans Verkuil X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=4061; i=ribalda@chromium.org; h=from:subject:message-id; bh=Q6Ty28eEyDWUJosEKd4UTXCsSOQeb3Aa2fdI+JNxN3I=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjijQpN+Gp11+KJtyf2NqCaonYO3z4AG74/0P4ktMz X+9mnGyJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY4o0KQAKCRDRN9E+zzrEiDabD/ 4hdednARo9vIZ63cZE6rj/LqS7zBcNbf4ARBjcT0uoLqLwPIoOBReqPeG7oJyDA7hLjdCVFOvjQpLp C2Cskx1EE/9OoCEVpnh8KpSiqv4vOdkh9MrXErvEs3ftBp4ygmFnC1epjDrjn7R5YzQAyMdNdew04S qOmrIGTuDkPpo0rwg+zjuwMuPSUwmAuHr21BHWQpCEp10jfllYv8bc5Wpnh7c3u+36ri8mTD5ACwva EcWSQjHA1/krvk24Rm/78XqJWJ/l6ocDc+1vLfspiPYs/jzKO1UxAJwHY6FpYWeQLVApg2KyVPVuaf Ha6Xc5oFzZOZKJdzbjtNtIt5ds5L5zpUS6TtQEWdoWHsLZneng1Md9yh7PuCSmDq2dCSLBqxCP6Ujw kw+qmFX5Y550YZ+alIAdvaqxkIrWNB1jR962Mxg7bD4Zm+FOHlFlA/O7EO5TXGB+Kj+7DVrARWAXxL d/x8eUeFbdqXGhxDtt/FPH64Qz5pIrgElhgSfQplbJo2XSkCyArPy8d3C5bAHQk0AbW0A59U9+P6DX 9Xn0B6UzUIwaxA89+K7Md2aTY/wxc5bQ4ZlUOJw+tKmbb1PtGpDGNrn+vwm4SVXjR5JNBgV9xqHJ5N J1RsVk6vooHSyqNZPxJ888bSHIsN3xBVxlQG7/n8vad5+q4YuseFYRFGI4iQ== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Minimum and step values for V4L2_CTRL_TYPE_BITMASK controls should be 0. There is no need to query the camera firmware about this and maybe get invalid results. Also value should be masked to the max value advertised by the hardware. Finally, handle uvc 1.5 mask controls that use MAX instead of RES to describe the valid bits. Fixes v4l2-compliane: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(97): minimum must be 0 for a b= itmask control test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: FAIL Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 53 +++++++++++++++++++++++++++++++-----= ---- 1 file changed, 41 insertions(+), 12 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 7153ee5aabb1..526572044e82 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1145,6 +1145,25 @@ static const char *uvc_map_get_name(const struct uvc= _control_mapping *map) return "Unknown Control"; } =20 +static u32 uvc_get_ctrl_bitmap(struct uvc_control *ctrl, + struct uvc_control_mapping *mapping) +{ + /* + * Some controls, like CT_AE_MODE_CONTROL use GET_RES to + * represent the number of bits supported, those controls + * do not list GET_MAX as supported. + */ + if (ctrl->info.flags & UVC_CTRL_FLAG_GET_MAX) + return mapping->get(mapping, UVC_GET_MAX, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); + + if (ctrl->info.flags & UVC_CTRL_FLAG_GET_RES) + return mapping->get(mapping, UVC_GET_RES, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); + + return ~0; +} + static int __uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, struct uvc_control *ctrl, struct uvc_control_mapping *mapping, @@ -1219,6 +1238,12 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_ch= ain *chain, v4l2_ctrl->step =3D 0; return 0; =20 + case V4L2_CTRL_TYPE_BITMASK: + v4l2_ctrl->minimum =3D 0; + v4l2_ctrl->maximum =3D uvc_get_ctrl_bitmap(ctrl, mapping); + v4l2_ctrl->step =3D 0; + return 0; + default: break; } @@ -1320,19 +1345,14 @@ int uvc_query_v4l2_menu(struct uvc_video_chain *cha= in, =20 menu_info =3D &mapping->menu_info[query_menu->index]; =20 - if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_BITMASK && - (ctrl->info.flags & UVC_CTRL_FLAG_GET_RES)) { - s32 bitmap; - + if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_BITMASK) { if (!ctrl->cached) { ret =3D uvc_ctrl_populate_cache(chain, ctrl); if (ret < 0) goto done; } =20 - bitmap =3D mapping->get(mapping, UVC_GET_RES, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); - if (!(bitmap & menu_info->value)) { + if (!(uvc_get_ctrl_bitmap(ctrl, mapping) & menu_info->value)) { ret =3D -EINVAL; goto done; } @@ -1815,6 +1835,18 @@ int uvc_ctrl_set(struct uvc_fh *handle, value =3D xctrl->value; break; =20 + case V4L2_CTRL_TYPE_BITMASK: + if (!ctrl->cached) { + ret =3D uvc_ctrl_populate_cache(chain, ctrl); + if (ret < 0) + return ret; + } + + xctrl->value =3D max(0, xctrl->value); + xctrl->value &=3D uvc_get_ctrl_bitmap(ctrl, mapping); + value =3D xctrl->value; + break; + case V4L2_CTRL_TYPE_BOOLEAN: xctrl->value =3D clamp(xctrl->value, 0, 1); value =3D xctrl->value; @@ -1829,17 +1861,14 @@ int uvc_ctrl_set(struct uvc_fh *handle, * Valid menu indices are reported by the GET_RES request for * UVC controls that support it. */ - if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_BITMASK && - (ctrl->info.flags & UVC_CTRL_FLAG_GET_RES)) { + if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_BITMASK) { if (!ctrl->cached) { ret =3D uvc_ctrl_populate_cache(chain, ctrl); if (ret < 0) return ret; } =20 - step =3D mapping->get(mapping, UVC_GET_RES, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); - if (!(step & value)) + if (!(uvc_get_ctrl_bitmap(ctrl, mapping) & value)) return -EINVAL; } =20 --=20 2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae From nobody Tue May 7 05:13:30 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35420C4321E for ; Fri, 2 Dec 2022 17:22:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233982AbiLBRWY (ORCPT ); Fri, 2 Dec 2022 12:22:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234145AbiLBRV5 (ORCPT ); Fri, 2 Dec 2022 12:21:57 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 031F36F0F6 for ; Fri, 2 Dec 2022 09:21:56 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id fy37so13028749ejc.11 for ; Fri, 02 Dec 2022 09:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kFcyBpj+roptImEjPj9piLF8BA0R7w/IlAfi2K8P7bY=; b=GJGQWn6xnoSY7Etym9vgtQmRI7e2aKzTXyoq8ceLg89ytjx8ExTNQ/K3mgnmQxKtcM hV1qZaRprsc75L8mzCcjtuWDDX0QUncg3zNHukS6UtvicoqqzZzmEFsPMGLmZLcl4ddi +W+iDxLGFAOL9kjjX+260929kQNvNuKcnyfvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kFcyBpj+roptImEjPj9piLF8BA0R7w/IlAfi2K8P7bY=; b=zOCpEILkT7cOlfVJyrGY1HhPE/hdg3Yl/esyEimqTVsrn9ftXdMEYV5U5cC01g1U1+ 8k7GWsdihDEuArMBd6UNb5UiuUmDHLAv8WTmXgBdXI+g6KjO27BeHBlc1KK91kQoMMTQ O/I7wpFDdSyHmngY4Oqh9K59JdZGyXow3ldfrpFxBD6I4dVbZCgliqhJKuj6k8GML49Q OWC7+1y8GhxwjbpeBIjH42yRAy/7aY81XmNgyPnt9STt1hCyfnFDPOjl6UaPfVR26uct d29S8pYhNP1YPmkv5MbuT6/YsNFnDFE3l+f7k2Zhqa3kUU0o/zo03FVPe2+na7F37t2R rKIA== X-Gm-Message-State: ANoB5pkjuGCNMCXl//Xuc7U4uj1+9iM2sbrsf0obVZ2SYzgpOHaAaaru r/5Qym3CAY3tEefQowR2MZKE+A== X-Google-Smtp-Source: AA0mqf5/3EwwkFDNDpt4/RX5co4CpiVNv6SPq1gFyPHwyy3dZwynpKBaFQPb68/oRUU3CmpSgDkXlA== X-Received: by 2002:a17:906:5792:b0:7c0:9e1d:c83b with SMTP id k18-20020a170906579200b007c09e1dc83bmr11992942ejq.68.1670001714555; Fri, 02 Dec 2022 09:21:54 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id fe17-20020a1709072a5100b007be301a1d51sm3206685ejc.211.2022.12.02.09.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 09:21:54 -0800 (PST) From: Ricardo Ribalda Date: Fri, 02 Dec 2022 18:21:40 +0100 Subject: [PATCH RESEND v2 6/7] media: uvcvideo: Implement mask for V4L2_CTRL_TYPE_MENU MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20220920-resend-v4l2-compliance-v2-6-b0ceb15353ac@chromium.org> References: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> In-Reply-To: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org, Ricardo Ribalda , linux-kernel@vger.kernel.org, Hans Verkuil X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=5794; i=ribalda@chromium.org; h=from:subject:message-id; bh=u0yMi5/b9HeKgqPvAbyKu4QWjgjZ09vQlVYM51vM0MI=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjijQrqdm7x9AeEez0Rs5z96/uVtOCtyrQXMM4olmo 9fU5NWeJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY4o0KwAKCRDRN9E+zzrEiFiMD/ wIK6XzjhijxUt99b5c1npLY+opxvbJa7ZuQpbCKzCAytyeXZd/lkx1P4vRq//8LVYj5gI3nBbbQMl+ DBCXnM2x/kcUEOFfPv0XM3KbzvNr8aS56CvNEbF9BIqeAyBYxrjHth2EjXhhZdqY8Md3FfiN9YL0Rs JMVjuNsBYziJXZSwg8sm0Yb3ZbqabHwTZqUzivRHf5TcOVS9Sskd/gJsh7uVAI9i3fGQ1ilZFSVA9v PCe77hdQT5gZCm1UXPLWffMH3Rl5FFbLSESokwnuELflSggl73hc+ShGHv2gKJLbLriSvlUnH2XB6h 4d+/hWENuAtgp7hDqbFDSNZFDBGPdBFJOkOIMrZIL/qP+oIlt32JPENS8JFRulB5flYlCUoYgLDzZH kJO1eDIO+AQv9TYKWjg2ie+2foaalLXA976Vm1iE0lcirnzkILGoAhCZOYH2dwh/0pQaLtvwdeR40E tzuSKxr6wyxtpeKMq0szztkA4rXpestkiE1DGnwR9vSWGSGxWtiJn4uf3093Hk9ahgCQWimIBoIgmD xXx7nl+afITvGrEhERBwHbDyWC9bLy7f1V70j94fwlKZVLc7IaNLoTfPvI+O9i1GGWLuQSDm8DCGbD E5eZWh3mnFARiiHwaXW/6SRIw3v2pCcbQo7J9Gi+gO21EA1F7mVqJLDqJhsQ== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the count with a mask field that lets us choose not only the max value, but also the minimum value and what values are valid in between. Signed-off-by: Ricardo Ribalda Suggested-by: Laurent Pinchart Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_ctrl.c | 30 ++++++++++++++++++++---------- drivers/media/usb/uvc/uvc_driver.c | 2 +- drivers/media/usb/uvc/uvc_v4l2.c | 2 +- drivers/media/usb/uvc/uvcvideo.h | 2 +- 4 files changed, 23 insertions(+), 13 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 526572044e82..df273b829961 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -6,6 +6,7 @@ * Laurent Pinchart (laurent.pinchart@ideasonboard.com) */ =20 +#include #include #include #include @@ -524,7 +525,7 @@ static const struct uvc_control_mapping uvc_ctrl_mappin= gs[] =3D { .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_BITMASK, .menu_info =3D exposure_auto_controls, - .menu_count =3D ARRAY_SIZE(exposure_auto_controls), + .menu_mask =3D BIT_MASK(ARRAY_SIZE(exposure_auto_controls)), .slave_ids =3D { V4L2_CID_EXPOSURE_ABSOLUTE, }, }, { @@ -730,7 +731,7 @@ static const struct uvc_control_mapping uvc_ctrl_mappin= gs_uvc11[] =3D { .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_ENUM, .menu_info =3D power_line_frequency_controls, - .menu_count =3D ARRAY_SIZE(power_line_frequency_controls) - 1, + .menu_mask =3D BIT_MASK(ARRAY_SIZE(power_line_frequency_controls) - 1), }, }; =20 @@ -744,7 +745,7 @@ static const struct uvc_control_mapping uvc_ctrl_mappin= gs_uvc15[] =3D { .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_ENUM, .menu_info =3D power_line_frequency_controls, - .menu_count =3D ARRAY_SIZE(power_line_frequency_controls), + .menu_mask =3D BIT_MASK(ARRAY_SIZE(power_line_frequency_controls)), }, }; =20 @@ -974,7 +975,9 @@ static s32 __uvc_ctrl_get_value(struct uvc_control_mapp= ing *mapping, const struct uvc_menu_info *menu =3D mapping->menu_info; unsigned int i; =20 - for (i =3D 0; i < mapping->menu_count; ++i, ++menu) { + for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i, ++menu) { + if (!test_bit(i, &mapping->menu_mask)) + continue; if (menu->value =3D=3D value) { value =3D i; break; @@ -1212,12 +1215,14 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_c= hain *chain, =20 switch (mapping->v4l2_type) { case V4L2_CTRL_TYPE_MENU: - v4l2_ctrl->minimum =3D 0; - v4l2_ctrl->maximum =3D mapping->menu_count - 1; + v4l2_ctrl->minimum =3D ffs(mapping->menu_mask) - 1; + v4l2_ctrl->maximum =3D fls(mapping->menu_mask) - 1; v4l2_ctrl->step =3D 1; =20 menu =3D mapping->menu_info; - for (i =3D 0; i < mapping->menu_count; ++i, ++menu) { + for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i, ++menu) { + if (!test_bit(i, &mapping->menu_mask)) + continue; if (menu->value =3D=3D v4l2_ctrl->default_value) { v4l2_ctrl->default_value =3D i; break; @@ -1338,7 +1343,7 @@ int uvc_query_v4l2_menu(struct uvc_video_chain *chain, goto done; } =20 - if (query_menu->index >=3D mapping->menu_count) { + if (!test_bit(query_menu->index, &mapping->menu_mask)) { ret =3D -EINVAL; goto done; } @@ -1853,8 +1858,13 @@ int uvc_ctrl_set(struct uvc_fh *handle, break; =20 case V4L2_CTRL_TYPE_MENU: - if (xctrl->value < 0 || xctrl->value >=3D mapping->menu_count) + if (xctrl->value < (ffs(mapping->menu_mask) - 1) || + xctrl->value > (fls(mapping->menu_mask) - 1)) return -ERANGE; + + if (!test_bit(xctrl->value, &mapping->menu_mask)) + return -EINVAL; + value =3D mapping->menu_info[xctrl->value].value; =20 /* @@ -2301,7 +2311,7 @@ static int __uvc_ctrl_add_mapping(struct uvc_video_ch= ain *chain, =20 INIT_LIST_HEAD(&map->ev_subs); =20 - size =3D sizeof(*mapping->menu_info) * mapping->menu_count; + size =3D sizeof(*mapping->menu_info) * fls(mapping->menu_mask); map->menu_info =3D kmemdup(mapping->menu_info, size, GFP_KERNEL); if (map->menu_info =3D=3D NULL) { kfree(map->name); diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc= _driver.c index 9c05776f11d1..abdb9ca7eed6 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -2675,7 +2675,7 @@ static const struct uvc_control_mapping uvc_ctrl_powe= r_line_mapping_limited =3D { .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_ENUM, .menu_info =3D power_line_frequency_controls_limited, - .menu_count =3D ARRAY_SIZE(power_line_frequency_controls_limited), + .menu_mask =3D BIT_MASK(ARRAY_SIZE(power_line_frequency_controls_limited)= ), }; =20 static const struct uvc_device_info uvc_ctrl_power_line_limited =3D { diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index d95168cdc2d1..e6792fd46bf5 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -80,7 +80,7 @@ static int uvc_ioctl_ctrl_map(struct uvc_video_chain *cha= in, goto free_map; } =20 - map->menu_count =3D xmap->menu_count; + map->menu_mask =3D BIT_MASK(xmap->menu_count); break; =20 default: diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 644d5fcf2eef..7e2339fc256e 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -255,7 +255,7 @@ struct uvc_control_mapping { u32 data_type; =20 const struct uvc_menu_info *menu_info; - u32 menu_count; + unsigned long menu_mask; =20 u32 master_id; s32 master_manual; --=20 2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae From nobody Tue May 7 05:13:30 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27617C4708E for ; Fri, 2 Dec 2022 17:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233824AbiLBRW1 (ORCPT ); Fri, 2 Dec 2022 12:22:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233837AbiLBRWC (ORCPT ); Fri, 2 Dec 2022 12:22:02 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 222699D2C3 for ; Fri, 2 Dec 2022 09:21:57 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id fy37so13028865ejc.11 for ; Fri, 02 Dec 2022 09:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EjhL47z9Nl+DaAg29fxcGxhmqEDsIaNpB1QWBqLjg58=; b=gUybeRSnsTC0aPYHfRkd5QF9Nu44JbnujAhiWe8zqjr0Na8yfDqSl4ugB+81lmz0qV EZHYcR0O8pfYxb5qaPjjJsyKJNE9VIWMvCr+dNxSTLpvwo73ZLiqppnhEl+gvTftUMUT gMLacG2c4ujg6pOGC7I1P9mR8FUnfz3GEtZLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EjhL47z9Nl+DaAg29fxcGxhmqEDsIaNpB1QWBqLjg58=; b=8PNGiKB25gv+m9eQbaLTbN9/z4awQEZL2A8HL2I5kITfC4iX3aEuK5GDS2alIqo8nO RGSAq6w9Xy2I6jKSo1zyjitJo7mDFvlW6rD4s2VcF5z06d5r9sfhPa8/LZK+4+lU93Nt T1XlRHPFOyVHkvfgNHntBQo405G3Ul0lkMsjg1EgjKC2euLiKeDcYzD29d5y/tI0bDSd 3x67KA8Ei02nW7Y/zjiUc8XRsJdzv3bLVTNskrkFqWhjPTOgjlX3XUphzho4WBz/8+tp xG1HHeNq205iq2ML5Zw+WVKFjeVWrj9hzldeWEomjGr3L1e4W73KmbjeHhDk+UwlxwzQ RgVg== X-Gm-Message-State: ANoB5pkxKBOIGUcEINU3JlmLNMOW7/7sCgfO/7zAQqxbvD1GoixjiAUZ preMmg/2QE5l7rK2tRel0g/U9Q== X-Google-Smtp-Source: AA0mqf5PKE8Pht6Z/r4N0ReXRIVBfmjamBnYSYrpzoEcdDOrUxewhHkjUzYLXu23ZB3eNAlGoPZWMA== X-Received: by 2002:a17:907:986b:b0:7ad:b7c2:a2f7 with SMTP id ko11-20020a170907986b00b007adb7c2a2f7mr45617347ejc.227.1670001715642; Fri, 02 Dec 2022 09:21:55 -0800 (PST) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id fe17-20020a1709072a5100b007be301a1d51sm3206685ejc.211.2022.12.02.09.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 09:21:55 -0800 (PST) From: Ricardo Ribalda Date: Fri, 02 Dec 2022 18:21:41 +0100 Subject: [PATCH RESEND v2 7/7] media: uvcvideo: Use standard names for menus MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20220920-resend-v4l2-compliance-v2-7-b0ceb15353ac@chromium.org> References: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> In-Reply-To: <20220920-resend-v4l2-compliance-v2-0-b0ceb15353ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: Hans Verkuil , Hans Verkuil , linux-media@vger.kernel.org, Ricardo Ribalda , linux-kernel@vger.kernel.org, Hans Verkuil X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=12904; i=ribalda@chromium.org; h=from:subject:message-id; bh=CQ0Q3iEnjgF/RdatrIffgvHt8KgiNN9Adkhd3ymwRxg=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjijQsHCyx0OPBe0KIY2MAlct06a6Z8vNSFlgl59Ra dYmEr3CJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY4o0LAAKCRDRN9E+zzrEiLsDEA CbR5VB6GomNQ5k9uB94p/hQJV0SIQWBUa1L1ZtyRc0ovxw0Baysc6YVnr/xgxS7zexj467+n+mEHXB ppsw/DtQnuiJa/vv4/XcCYbwTG0kM/KiS5vTLznCfHnToC/DLQTQvytS+s70W8fv6cy8KwGOOtVUAg 4HwFFbT2DT1RKEs87bqcBOZtBPKHM+913oSyL8iPB3/663JNjJFhVtjTOD1EPuupo92WfcTUT5Jeno U66lZpxDDF1AElyCvOTeoBW3/FsE6i17nNLGGzuk96+0NhyKvvFmmBY2p8K8BhX5v/7lsISQze3kfR JdqNgcUcQ9a6ruuuUdVOPPEQPsnhcb04xB094umEdomMsa+FiD6ELNnnQ+CDhKcSGIH+Nkv2LIJGbo 60tCcPqk5K5LmUmqOAFov5EJUW6fO0DIHIjQ3xgccJhb57+c3yz1+rycQNueAGvQD32EdQqb0SVVFI ZsLOqP5i1ZBju9p79IeytwsmP+sBZBtp33Dr2vNz4v9Y3eDK9DyYiMWx8j8xmI6cHsvtIET54rzBYH Rxbx49rc74D9Mbro2Bakfb1sHri+/WveUWyZopShstgiwCTxS11WoKLBNKX9HgwdcumFu66bJMzPYU 4Y/EFhHF9Cx0Wcpvht5clDthsQuavOLQi9B4dmYM3rxkYzPRt5X44KNJJh5A== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of duplicating the menu info, use the one from the core. Also, do not use extra memory for 1:1 mappings. Signed-off-by: Ricardo Ribalda Suggested-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_ctrl.c | 116 +++++++++++++++++++++++++--------= ---- drivers/media/usb/uvc/uvc_driver.c | 9 +-- drivers/media/usb/uvc/uvc_v4l2.c | 81 ++++++++++++++++++++------ drivers/media/usb/uvc/uvcvideo.h | 3 +- include/uapi/linux/uvcvideo.h | 3 +- 5 files changed, 146 insertions(+), 66 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index df273b829961..5c28d8aace37 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -363,19 +363,31 @@ static const u32 uvc_control_classes[] =3D { V4L2_CID_USER_CLASS, }; =20 -static const struct uvc_menu_info power_line_frequency_controls[] =3D { - { 0, "Disabled" }, - { 1, "50 Hz" }, - { 2, "60 Hz" }, - { 3, "Auto" }, -}; +static const int exposure_auto_mapping[] =3D { 2, 1, 4, 8 }; =20 -static const struct uvc_menu_info exposure_auto_controls[] =3D { - { 2, "Auto Mode" }, - { 1, "Manual Mode" }, - { 4, "Shutter Priority Mode" }, - { 8, "Aperture Priority Mode" }, -}; +static u32 uvc_mapping_get_menu_value(struct uvc_control_mapping *mapping, + u32 idx) +{ + if (!test_bit(idx, &mapping->menu_mask)) + return 0; + + if (mapping->menu_mapping) + return mapping->menu_mapping[idx]; + + return idx; +} + +static const char +*uvc_mapping_get_menu_name(struct uvc_control_mapping *mapping, u32 idx) +{ + if (!test_bit(idx, &mapping->menu_mask)) + return NULL; + + if (mapping->menu_names) + return mapping->menu_names[idx]; + + return v4l2_ctrl_get_menu(mapping->id)[idx]; +} =20 static s32 uvc_ctrl_get_zoom(struct uvc_control_mapping *mapping, u8 query, const u8 *data) @@ -524,8 +536,8 @@ static const struct uvc_control_mapping uvc_ctrl_mappin= gs[] =3D { .offset =3D 0, .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_BITMASK, - .menu_info =3D exposure_auto_controls, - .menu_mask =3D BIT_MASK(ARRAY_SIZE(exposure_auto_controls)), + .menu_mapping =3D exposure_auto_mapping, + .menu_mask =3D GENMASK(ARRAY_SIZE(exposure_auto_mapping) - 1, 0), .slave_ids =3D { V4L2_CID_EXPOSURE_ABSOLUTE, }, }, { @@ -730,8 +742,7 @@ static const struct uvc_control_mapping uvc_ctrl_mappin= gs_uvc11[] =3D { .offset =3D 0, .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_ENUM, - .menu_info =3D power_line_frequency_controls, - .menu_mask =3D BIT_MASK(ARRAY_SIZE(power_line_frequency_controls) - 1), + .menu_mask =3D GENMASK(V4L2_CID_POWER_LINE_FREQUENCY_60HZ, 0), }, }; =20 @@ -744,8 +755,7 @@ static const struct uvc_control_mapping uvc_ctrl_mappin= gs_uvc15[] =3D { .offset =3D 0, .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_ENUM, - .menu_info =3D power_line_frequency_controls, - .menu_mask =3D BIT_MASK(ARRAY_SIZE(power_line_frequency_controls)), + .menu_mask =3D GENMASK(V4L2_CID_POWER_LINE_FREQUENCY_AUTO, 0), }, }; =20 @@ -972,13 +982,17 @@ static s32 __uvc_ctrl_get_value(struct uvc_control_ma= pping *mapping, s32 value =3D mapping->get(mapping, UVC_GET_CUR, data); =20 if (mapping->v4l2_type =3D=3D V4L2_CTRL_TYPE_MENU) { - const struct uvc_menu_info *menu =3D mapping->menu_info; unsigned int i; =20 - for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i, ++menu) { + for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i) { + u32 menu_value; + if (!test_bit(i, &mapping->menu_mask)) continue; - if (menu->value =3D=3D value) { + + menu_value =3D uvc_mapping_get_menu_value(mapping, i); + + if (menu_value =3D=3D value) { value =3D i; break; } @@ -1174,7 +1188,6 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_cha= in *chain, { struct uvc_control_mapping *master_map =3D NULL; struct uvc_control *master_ctrl =3D NULL; - const struct uvc_menu_info *menu; unsigned int i; =20 memset(v4l2_ctrl, 0, sizeof(*v4l2_ctrl)); @@ -1219,11 +1232,15 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_c= hain *chain, v4l2_ctrl->maximum =3D fls(mapping->menu_mask) - 1; v4l2_ctrl->step =3D 1; =20 - menu =3D mapping->menu_info; - for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i, ++menu) { + for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i) { + u32 menu_value; + if (!test_bit(i, &mapping->menu_mask)) continue; - if (menu->value =3D=3D v4l2_ctrl->default_value) { + + menu_value =3D uvc_mapping_get_menu_value(mapping, i); + + if (menu_value =3D=3D v4l2_ctrl->default_value) { v4l2_ctrl->default_value =3D i; break; } @@ -1322,11 +1339,11 @@ int uvc_query_v4l2_ctrl(struct uvc_video_chain *cha= in, int uvc_query_v4l2_menu(struct uvc_video_chain *chain, struct v4l2_querymenu *query_menu) { - const struct uvc_menu_info *menu_info; struct uvc_control_mapping *mapping; struct uvc_control *ctrl; u32 index =3D query_menu->index; u32 id =3D query_menu->id; + const char *name; int ret; =20 memset(query_menu, 0, sizeof(*query_menu)); @@ -1348,22 +1365,28 @@ int uvc_query_v4l2_menu(struct uvc_video_chain *cha= in, goto done; } =20 - menu_info =3D &mapping->menu_info[query_menu->index]; - if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_BITMASK) { + u32 menu_value; + if (!ctrl->cached) { ret =3D uvc_ctrl_populate_cache(chain, ctrl); if (ret < 0) goto done; } =20 - if (!(uvc_get_ctrl_bitmap(ctrl, mapping) & menu_info->value)) { + menu_value =3D uvc_mapping_get_menu_value(mapping, + query_menu->index); + if (!(uvc_get_ctrl_bitmap(ctrl, mapping) & menu_value)) { ret =3D -EINVAL; goto done; } } =20 - strscpy(query_menu->name, menu_info->name, sizeof(query_menu->name)); + name =3D uvc_mapping_get_menu_name(mapping, query_menu->index); + if (name) + strscpy(query_menu->name, name, sizeof(query_menu->name)); + else + ret =3D -EINVAL; =20 done: mutex_unlock(&chain->ctrl_mutex); @@ -1865,7 +1888,7 @@ int uvc_ctrl_set(struct uvc_fh *handle, if (!test_bit(xctrl->value, &mapping->menu_mask)) return -EINVAL; =20 - value =3D mapping->menu_info[xctrl->value].value; + value =3D uvc_mapping_get_menu_value(mapping, xctrl->value); =20 /* * Valid menu indices are reported by the GET_RES request for @@ -2311,12 +2334,28 @@ static int __uvc_ctrl_add_mapping(struct uvc_video_= chain *chain, =20 INIT_LIST_HEAD(&map->ev_subs); =20 - size =3D sizeof(*mapping->menu_info) * fls(mapping->menu_mask); - map->menu_info =3D kmemdup(mapping->menu_info, size, GFP_KERNEL); - if (map->menu_info =3D=3D NULL) { - kfree(map->name); - kfree(map); - return -ENOMEM; + if (mapping->menu_mapping && mapping->menu_mask) { + size =3D sizeof(mapping->menu_mapping[0]) * + fls(mapping->menu_mask); + map->menu_mapping =3D kmemdup(mapping->menu_mapping, size, + GFP_KERNEL); + if (!map->menu_mapping) { + kfree(map->name); + kfree(map); + return -ENOMEM; + } + } + if (mapping->menu_names && mapping->menu_mask) { + size =3D sizeof(mapping->menu_names[0]) * + fls(mapping->menu_mask); + map->menu_names =3D kmemdup(mapping->menu_names, size, + GFP_KERNEL); + if (!map->menu_names) { + kfree(map->menu_mapping); + kfree(map->name); + kfree(map); + return -ENOMEM; + } } =20 if (map->get =3D=3D NULL) @@ -2661,7 +2700,8 @@ static void uvc_ctrl_cleanup_mappings(struct uvc_devi= ce *dev, =20 list_for_each_entry_safe(mapping, nm, &ctrl->info.mappings, list) { list_del(&mapping->list); - kfree(mapping->menu_info); + kfree(mapping->menu_names); + kfree(mapping->menu_mapping); kfree(mapping->name); kfree(mapping); } diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc= _driver.c index abdb9ca7eed6..97c267e75fa4 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -2661,11 +2661,6 @@ MODULE_PARM_DESC(timeout, "Streaming control request= s timeout"); * Driver initialization and cleanup */ =20 -static const struct uvc_menu_info power_line_frequency_controls_limited[] = =3D { - { 1, "50 Hz" }, - { 2, "60 Hz" }, -}; - static const struct uvc_control_mapping uvc_ctrl_power_line_mapping_limite= d =3D { .id =3D V4L2_CID_POWER_LINE_FREQUENCY, .entity =3D UVC_GUID_UVC_PROCESSING, @@ -2674,8 +2669,8 @@ static const struct uvc_control_mapping uvc_ctrl_powe= r_line_mapping_limited =3D { .offset =3D 0, .v4l2_type =3D V4L2_CTRL_TYPE_MENU, .data_type =3D UVC_CTRL_DATA_TYPE_ENUM, - .menu_info =3D power_line_frequency_controls_limited, - .menu_mask =3D BIT_MASK(ARRAY_SIZE(power_line_frequency_controls_limited)= ), + .menu_mask =3D GENMASK(V4L2_CID_POWER_LINE_FREQUENCY_60HZ, + V4L2_CID_POWER_LINE_FREQUENCY_50HZ), }; =20 static const struct uvc_device_info uvc_ctrl_power_line_limited =3D { diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index e6792fd46bf5..89581c1559df 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -25,6 +25,64 @@ =20 #include "uvcvideo.h" =20 +static int uvc_control_xu_2_mapping(struct uvc_control_mapping *map, + struct uvc_xu_control_mapping *xmap) +{ + char (*names)[UVC_MENU_NAME_LEN]; + unsigned int i; + u32 *mapping; + size_t size; + + /* Prevent excessive memory consumption, as well as integer + * overflows. + */ + if (xmap->menu_count =3D=3D 0 || + xmap->menu_count > UVC_MAX_CONTROL_MENU_ENTRIES) + return -EINVAL; + + map->menu_mask =3D BIT_MASK(xmap->menu_count); + + size =3D xmap->menu_count * sizeof(*map->menu_mapping); + mapping =3D kzalloc(size, GFP_KERNEL); + if (!mapping) + return -ENOMEM; + + for (i =3D 0; i < xmap->menu_count ; i++) + if (copy_from_user(&mapping[i], &xmap->menu_info[i].value, + sizeof(mapping[i]))) { + kfree(mapping); + return -ENOMEM; + } + + map->menu_mapping =3D mapping; + + /* + * Always use the standard naming if available. + */ + if (v4l2_ctrl_get_menu(map->id)) + return 0; + + size =3D xmap->menu_count * sizeof(map->menu_names[0]); + names =3D kzalloc(size, GFP_KERNEL); + if (!names) { + kfree(mapping); + return -ENOMEM; + } + + for (i =3D 0; i < xmap->menu_count ; i++) { + /* sizeof(names[i]) - 1: to take care of \0 */ + if (copy_from_user(&names[i], &xmap->menu_info[i].name, + sizeof(names[i]) - 1)) { + kfree(names); + kfree(mapping); + return -ENOMEM; + } + } + map->menu_names =3D names; + + return 0; +} + /* ------------------------------------------------------------------------ * UVC ioctls */ @@ -32,7 +90,6 @@ static int uvc_ioctl_ctrl_map(struct uvc_video_chain *cha= in, struct uvc_xu_control_mapping *xmap) { struct uvc_control_mapping *map; - unsigned int size; int ret; =20 map =3D kzalloc(sizeof(*map), GFP_KERNEL); @@ -63,24 +120,9 @@ static int uvc_ioctl_ctrl_map(struct uvc_video_chain *c= hain, break; =20 case V4L2_CTRL_TYPE_MENU: - /* - * Prevent excessive memory consumption, as well as integer - * overflows. - */ - if (xmap->menu_count =3D=3D 0 || - xmap->menu_count > UVC_MAX_CONTROL_MENU_ENTRIES) { - ret =3D -EINVAL; - goto free_map; - } - - size =3D xmap->menu_count * sizeof(*map->menu_info); - map->menu_info =3D memdup_user(xmap->menu_info, size); - if (IS_ERR(map->menu_info)) { - ret =3D PTR_ERR(map->menu_info); + ret =3D uvc_control_xu_2_mapping(map, xmap); + if (ret) goto free_map; - } - - map->menu_mask =3D BIT_MASK(xmap->menu_count); break; =20 default: @@ -92,7 +134,8 @@ static int uvc_ioctl_ctrl_map(struct uvc_video_chain *ch= ain, =20 ret =3D uvc_ctrl_add_mapping(chain, map); =20 - kfree(map->menu_info); + kfree(map->menu_names); + kfree(map->menu_mapping); free_map: kfree(map); =20 diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 7e2339fc256e..8ebd7ee2934d 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -254,7 +254,8 @@ struct uvc_control_mapping { enum v4l2_ctrl_type v4l2_type; u32 data_type; =20 - const struct uvc_menu_info *menu_info; + const u32 *menu_mapping; + const char (*menu_names)[UVC_MENU_NAME_LEN]; unsigned long menu_mask; =20 u32 master_id; diff --git a/include/uapi/linux/uvcvideo.h b/include/uapi/linux/uvcvideo.h index 8288137387c0..1b64b6aa40b5 100644 --- a/include/uapi/linux/uvcvideo.h +++ b/include/uapi/linux/uvcvideo.h @@ -36,9 +36,10 @@ UVC_CTRL_FLAG_GET_MAX | UVC_CTRL_FLAG_GET_RES | \ UVC_CTRL_FLAG_GET_DEF) =20 +#define UVC_MENU_NAME_LEN 32 struct uvc_menu_info { __u32 value; - __u8 name[32]; + __u8 name[UVC_MENU_NAME_LEN]; }; =20 struct uvc_xu_control_mapping { --=20 2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae