From nobody Fri Apr 3 02:23:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D86FAC32771 for ; Sun, 18 Sep 2022 17:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbiIRR5V (ORCPT ); Sun, 18 Sep 2022 13:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbiIRR5O (ORCPT ); Sun, 18 Sep 2022 13:57:14 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E97E1659B for ; Sun, 18 Sep 2022 10:57:13 -0700 (PDT) Received: from dslb-188-096-149-102.188.096.pools.vodafone-ip.de ([188.96.149.102] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oZyXU-0006VL-C6; Sun, 18 Sep 2022 19:57:08 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 2/6] staging: r8188eu: update status before wps success blinking Date: Sun, 18 Sep 2022 19:56:56 +0200 Message-Id: <20220918175700.215170-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220918175700.215170-1-martin@kaiser.cx> References: <20220918175700.215170-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Always update the status variables in rtw_led_control when we start blinking to show that wps was successful. The if statements are not necessary. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_led.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188= eu/core/rtw_led.c index 389fb2cc7379..eac35f048f52 100644 --- a/drivers/staging/r8188eu/core/rtw_led.c +++ b/drivers/staging/r8188eu/core/rtw_led.c @@ -324,20 +324,11 @@ void rtw_led_control(struct adapter *padapter, enum L= ED_CTL_MODE LedAction) case LED_CTL_STOP_WPS: cancel_delayed_work(&pLed->blink_work); =20 - if (pLed->bLedNoLinkBlinkInProgress) - pLed->bLedNoLinkBlinkInProgress =3D false; - - if (pLed->bLedLinkBlinkInProgress) - pLed->bLedLinkBlinkInProgress =3D false; - - if (pLed->bLedBlinkInProgress) - pLed->bLedBlinkInProgress =3D false; - - if (pLed->bLedScanBlinkInProgress) - pLed->bLedScanBlinkInProgress =3D false; - - if (!pLed->bLedWPSBlinkInProgress) - pLed->bLedWPSBlinkInProgress =3D true; + pLed->bLedNoLinkBlinkInProgress =3D false; + pLed->bLedLinkBlinkInProgress =3D false; + pLed->bLedBlinkInProgress =3D false; + pLed->bLedScanBlinkInProgress =3D false; + pLed->bLedWPSBlinkInProgress =3D true; =20 pLed->CurrLedState =3D LED_BLINK_WPS_STOP; if (pLed->bLedOn) { --=20 2.30.2