From nobody Fri Apr 3 03:53:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FB6C54EE9 for ; Fri, 16 Sep 2022 12:30:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231579AbiIPMaE (ORCPT ); Fri, 16 Sep 2022 08:30:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231514AbiIPM3m (ORCPT ); Fri, 16 Sep 2022 08:29:42 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B4AAF5B for ; Fri, 16 Sep 2022 05:29:29 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id bg5-20020a05600c3c8500b003a7b6ae4eb2so19760565wmb.4 for ; Fri, 16 Sep 2022 05:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=f8P6NdaxW6n0MxKc6m48JQ99Q9yCqPt9CXBbjR8xRMU=; b=tX3mOonKXJPL1OZFdAVC68GaOsmTp9e/LPG3v7bWq8bnkc4cpgBSt5Zx3ixiaofOCO pkTfI7Tjrj1iiX311Yatu82wewCJaj6s1Li8LN8gH4iO1KSpXFUMj7K7n05rPOlObRl+ lIsiw8DsjibgmO8KSS15CnoN/OA/SXlDfoW6PVJQqat95zUdR53tAHPZrVTRfoSLtub0 cIHG8IGR65Lwyq0hVj4rIaxKwkB2fypk2HLxc6J3uBGqxwhERlG1iVUNtjmZ+g6/QPlO Z8KDdWzFeFI0534Hp6+vI5D48DH0oRbdkVYeIQ2i/XjuKOEvhlZKtPdpWkCiA4HBqkn7 W/zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=f8P6NdaxW6n0MxKc6m48JQ99Q9yCqPt9CXBbjR8xRMU=; b=SBCe3x6Y708QjMf7U4oiWPV5Iwcctr8kxZHj1QiKMCuCvme9bR0799mI7/05oeuFkc mdo0D99sKNCYOG53JogdgBL1Fj6iBVhdcowuKqqvmgSL1+B2ZKk6n+Y0LotVfW8rakLN FMI4EnNA0lU3J2reNUIVM3RJ/Ddy7STuAkgHY/zhQXKUUj2U0w3XjPBn0DzxjSgDx8R1 n+Cd95g0ItImTo3CaOkYhT4CKDtC8mkdYVi2qmGixpTA7iCip65KBV0i0A4VMZowFUid 70FIjnvNGifTlMOZgL3E0ylBGLkNCdJtwI1txU5AKtbD/Wx5LOpBNl1zHJdFTgp3ykgA /PpA== X-Gm-Message-State: ACrzQf2KDo2b5t7GRRslErq3/BkvUI8AeGwHvTqNOjlYKID2SQ5kR2HK vtCOyrGjiBhCWCi9+HRLlxsc6Q== X-Google-Smtp-Source: AMsMyM5BXScGtyIuzMOl/K3AX8gg9CaoIh8aIhAZyU4j72K9ld7E6e3s4wK/ApZOPQJkoJf8azFQUA== X-Received: by 2002:a05:600c:34c2:b0:3b4:7a98:5f5a with SMTP id d2-20020a05600c34c200b003b47a985f5amr3162839wmq.156.1663331368019; Fri, 16 Sep 2022 05:29:28 -0700 (PDT) Received: from srini-hackbase.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id m188-20020a1c26c5000000b003b4a68645e9sm1990825wmm.34.2022.09.16.05.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 05:29:27 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , stable@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 1/4] slimbus: qcom-ngd: use correct error in message of pdr_add_lookup() failure Date: Fri, 16 Sep 2022 13:29:07 +0100 Message-Id: <20220916122910.170730-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> References: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski Use correct error code, instead of previous 'ret' value, when printing error from pdr_add_lookup() failure. Cc: Fixes: e1ae85e1830e ("slimbus: qcom-ngd-ctrl: add Protection Domain Restart= Support") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index 0aa8408464ad..f4f330b9fa72 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1581,8 +1581,9 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_d= evice *pdev) =20 pds =3D pdr_add_lookup(ctrl->pdr, "avs/audio", "msm/adsp/audio_pd"); if (IS_ERR(pds) && PTR_ERR(pds) !=3D -EALREADY) { + ret =3D PTR_ERR(pds); dev_err(dev, "pdr add lookup failed: %d\n", ret); - return PTR_ERR(pds); + return ret; } =20 platform_driver_register(&qcom_slim_ngd_driver); --=20 2.25.1 From nobody Fri Apr 3 03:53:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D18EC54EE9 for ; Fri, 16 Sep 2022 12:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231493AbiIPM3u (ORCPT ); Fri, 16 Sep 2022 08:29:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231305AbiIPM3k (ORCPT ); Fri, 16 Sep 2022 08:29:40 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD6010FE for ; Fri, 16 Sep 2022 05:29:30 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so5258112wmq.1 for ; Fri, 16 Sep 2022 05:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=I5+a1QqwYJyDVCXJAIa2b2pM30dX36e5vx2XWxYNEV0=; b=l8U22qeDLoG6bQDYeGUJjpLo/DRhBjday95PJXEIzMSqXXXHiA4xaCoDfTzVfQ/CVq qU6Pfy8XwKvcfsHDCSNgrIGDB6AGGPCOlyRF0YLdG7VzRXkNcrn1B19w3xyKbupqRCS9 FPHhnbZGoW5HJbs0/yrFp670RaB9M1vUXHmabImT3ZeF+8Qkl8//PoktWo0AmIAOL0+0 VGUYCvJ+Aos7ipIj7453Q3y5srYvlMzTH0T75kw80aoiMuRuDc+SuhmeC+ruXEW8VOFi u9jk+gql0l/Dc0VZRkrHxYtIItiPFPUAXCsrJdbeHSwBWnho9W8e6Qy4c5vQOfeaB+V2 ZJ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=I5+a1QqwYJyDVCXJAIa2b2pM30dX36e5vx2XWxYNEV0=; b=eilw6xMmk7HPyXySga5z98HsZuOG7Ig5p2ITVF6a40U6sgtuc9PCEorUHXarAKT5O+ vRUWNsGq5vSlWYt9ilHBfxfh3CURGvdpH5R3Yv8CFLo2hnQj6MPJlDkm8IIH8iVV8Yfs Vd+OkhsN2Y7ziuJ9zPoTJnBQH8Navt1zB6b3WovdSUPCpdqaa3sg7OF579Auosq+/ARz AFTZUVYjTWuh3sZ1NM2owJ7Z33H4Xdcpb/PT/BaW10YWEql9e2yeAfg+qAA2KjXgrPus 8Z1fnY8X4iyKz21Vx8kBey2VOjaK4kl2mkedJ0E106hXMtQ9XqaQxSRWLgvROjz6Jeaj W5Pw== X-Gm-Message-State: ACrzQf03FjfAiB0W6bfApEayxKgdVXInPJS5mhMTZ9cOg7yW8GzJ28qr XtYvCd1tZmFagJpMNkatnOUxTA== X-Google-Smtp-Source: AMsMyM4hiJXwY5TumSy3scrgqTr6Dy3ZxbhqEUmo1iJI4hfLpyRhZmvrwpb/08j8H+qL8RcHuN2ddg== X-Received: by 2002:a05:600c:4ec8:b0:3b4:bdc6:9b3d with SMTP id g8-20020a05600c4ec800b003b4bdc69b3dmr1876174wmq.181.1663331368894; Fri, 16 Sep 2022 05:29:28 -0700 (PDT) Received: from srini-hackbase.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id m188-20020a1c26c5000000b003b4a68645e9sm1990825wmm.34.2022.09.16.05.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 05:29:28 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , stable@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 2/4] slimbus: qcom-ngd: cleanup in probe error path Date: Fri, 16 Sep 2022 13:29:08 +0100 Message-Id: <20220916122910.170730-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> References: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski Add proper error path in probe() to cleanup resources previously acquired/allocated to fix warnings visible during probe deferral: notifier callback qcom_slim_ngd_ssr_notify already registered WARNING: CPU: 6 PID: 70 at kernel/notifier.c:28 notifier_chain_register+0= x5c/0x90 Modules linked in: CPU: 6 PID: 70 Comm: kworker/u16:1 Not tainted 6.0.0-rc3-next-20220830 #3= 80 Call trace: notifier_chain_register+0x5c/0x90 srcu_notifier_chain_register+0x44/0x90 qcom_register_ssr_notifier+0x38/0x4c qcom_slim_ngd_ctrl_probe+0xd8/0x400 platform_probe+0x6c/0xe0 really_probe+0xbc/0x2d4 __driver_probe_device+0x78/0xe0 driver_probe_device+0x3c/0x12c __device_attach_driver+0xb8/0x120 bus_for_each_drv+0x78/0xd0 __device_attach+0xa8/0x1c0 device_initial_probe+0x18/0x24 bus_probe_device+0xa0/0xac deferred_probe_work_func+0x88/0xc0 process_one_work+0x1d4/0x320 worker_thread+0x2cc/0x44c kthread+0x110/0x114 ret_from_fork+0x10/0x20 Cc: Fixes: e1ae85e1830e ("slimbus: qcom-ngd-ctrl: add Protection Domain Restart= Support") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index f4f330b9fa72..bacc6af1d51e 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1576,18 +1576,27 @@ static int qcom_slim_ngd_ctrl_probe(struct platform= _device *pdev) ctrl->pdr =3D pdr_handle_alloc(slim_pd_status, ctrl); if (IS_ERR(ctrl->pdr)) { dev_err(dev, "Failed to init PDR handle\n"); - return PTR_ERR(ctrl->pdr); + ret =3D PTR_ERR(ctrl->pdr); + goto err_pdr_alloc; } =20 pds =3D pdr_add_lookup(ctrl->pdr, "avs/audio", "msm/adsp/audio_pd"); if (IS_ERR(pds) && PTR_ERR(pds) !=3D -EALREADY) { ret =3D PTR_ERR(pds); dev_err(dev, "pdr add lookup failed: %d\n", ret); - return ret; + goto err_pdr_lookup; } =20 platform_driver_register(&qcom_slim_ngd_driver); return of_qcom_slim_ngd_register(dev, ctrl); + +err_pdr_alloc: + qcom_unregister_ssr_notifier(ctrl->notifier, &ctrl->nb); + +err_pdr_lookup: + pdr_handle_release(ctrl->pdr); + + return ret; } =20 static int qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) --=20 2.25.1 From nobody Fri Apr 3 03:53:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E31C3C54EE9 for ; Fri, 16 Sep 2022 12:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbiIPM34 (ORCPT ); Fri, 16 Sep 2022 08:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbiIPM3l (ORCPT ); Fri, 16 Sep 2022 08:29:41 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CDB01103 for ; Fri, 16 Sep 2022 05:29:31 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id n8so8471006wmr.5 for ; Fri, 16 Sep 2022 05:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ZIu7s3K4+u7oP2s+yRQB4MCBJbH4a9+nIR767W2HTCo=; b=HM0PX8aBtfDpBSw8wWnR+KIEZ5a+cvTFkcvdZLX41FPb2v5LpVB4XaCOUdCO3NHX/N msjEPqqhauJ/vGN7IGoHL0dCihZ/POVO10DiF5QIjnI8w9AaRMNd1EJTBo6fOqr6ExsJ 8LT5qQPclOQ0H8j2ZgcXno1rp1/wgiMV/Xn7hUynite/sshc7hbG9cgJC4ywlES95ITy oW+h9g4JSaC9L9YJUl9M75vSmbvGIm3nebis86mN4zVpREMZSVUofCdjUasT1FYcvG7y xg6+YnbFUFZfDDsBDyMWddwCYTwHMo+8Ku1wcTYsKZw3xrBAVKvY+KLc2d84F/cjZGuM c0Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ZIu7s3K4+u7oP2s+yRQB4MCBJbH4a9+nIR767W2HTCo=; b=e8UB182IhLVqJokd7VA71+CGCuxP+GXmHt7Vvcg80bm1HhzyD3uAwjYuurFDscAaj0 VZgO206tEHCKLsxMO9nhegEeyD8/MiZZFtTaL+Ltg0lHvOOWaW0Ad7rv5uP9p6e+MSrG ndPtIn9yjC3IHpf+XQ7ZqS14ll3w/KNBYBTSjkznpQig4dfSLDbIN8k2m1wVMzpvm/eA E8QWn6M0Tb8wyXFg8WEdOk2H29ukWwoijUjbbDtzkuCSQ1BmlAD/RItq/oCMl4l9MXI5 X5exofYEoBmAbC9JMy/lIgjKs12YR72Jlsw/6kFLALrE7DLC1uiR1RPKG0KdN77nhhB7 MagA== X-Gm-Message-State: ACrzQf11Ve0bWIjQmzmboB3Iv7NmvVrjv4Y+YOe1DR+R/ukjyAdKbjDy cRbetxztLog7ezCQ5/cHLn6DIw== X-Google-Smtp-Source: AMsMyM4XDPi1HUFDfx+5m1YH4AhqH2iOV44V4I7kCA1hJXDpEsim4II/VGFLyyUOJ5EQbgVBizhexA== X-Received: by 2002:a05:600c:4f11:b0:3b4:bf6c:4566 with SMTP id l17-20020a05600c4f1100b003b4bf6c4566mr1048183wmq.34.1663331370096; Fri, 16 Sep 2022 05:29:30 -0700 (PDT) Received: from srini-hackbase.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id m188-20020a1c26c5000000b003b4a68645e9sm1990825wmm.34.2022.09.16.05.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 05:29:29 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Srinivas Kandagatla Subject: [PATCH 3/4] slimbus: qcom-ngd: simplify error paths with dev_err_probe Date: Fri, 16 Sep 2022 13:29:09 +0100 Message-Id: <20220916122910.170730-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> References: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski Use dev_err_probe to skip printing of deferred probe errors and to simplify error paths. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index bacc6af1d51e..cec11aa106bf 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1543,10 +1543,8 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_= device *pdev) =20 ret =3D devm_request_irq(dev, ret, qcom_slim_ngd_interrupt, IRQF_TRIGGER_HIGH, "slim-ngd", ctrl); - if (ret) { - dev_err(&pdev->dev, "request IRQ failed\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "request IRQ failed\n"); =20 ctrl->nb.notifier_call =3D qcom_slim_ngd_ssr_notify; ctrl->notifier =3D qcom_register_ssr_notifier("lpass", &ctrl->nb); @@ -1575,15 +1573,14 @@ static int qcom_slim_ngd_ctrl_probe(struct platform= _device *pdev) =20 ctrl->pdr =3D pdr_handle_alloc(slim_pd_status, ctrl); if (IS_ERR(ctrl->pdr)) { - dev_err(dev, "Failed to init PDR handle\n"); - ret =3D PTR_ERR(ctrl->pdr); + ret =3D dev_err_probe(dev, PTR_ERR(ctrl->pdr), + "Failed to init PDR handle\n"); goto err_pdr_alloc; } =20 pds =3D pdr_add_lookup(ctrl->pdr, "avs/audio", "msm/adsp/audio_pd"); if (IS_ERR(pds) && PTR_ERR(pds) !=3D -EALREADY) { - ret =3D PTR_ERR(pds); - dev_err(dev, "pdr add lookup failed: %d\n", ret); + ret =3D dev_err_probe(dev, PTR_ERR(pds), "pdr add lookup failed\n"); goto err_pdr_lookup; } =20 --=20 2.25.1 From nobody Fri Apr 3 03:53:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC2BBC54EE9 for ; Fri, 16 Sep 2022 12:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231651AbiIPM37 (ORCPT ); Fri, 16 Sep 2022 08:29:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231486AbiIPM3l (ORCPT ); Fri, 16 Sep 2022 08:29:41 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CFF61116 for ; Fri, 16 Sep 2022 05:29:32 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id ay36so6422623wmb.0 for ; Fri, 16 Sep 2022 05:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=aibk6Jc9VAZ5PSG3dauyBZkAwA2GeZcL8c5pEn//11Y=; b=dCMChoikGfDu/Q7zhcPNMzfo026BbCwMA3C7i5Fm9nvwoPi575yXSnt4ZuYHMSk5Sn Tyt1zN7NM59PJkR2Cuisk/zqJOa+u8bU3MRLlLRQJh5HBi/gv3wySgf5clxHTWMjz6rW ErssEs+4vHQy/6Wl6yBWs+x9eq0QRS6TBTynf+YOD/XBL0dDCG+R7H6YCPjSWSA7mWvV +OSfVnV2js8b68fqwJcsOCTXVB5b3+ahiy+vhR+GOdXexkRoeZDvxuFdhcUYmJ6p+nfZ d5NSiBRudN7sjIMzCL4EJA7aodL0tY7BdzZlYR2P+Q67/yId2AvUVoTK172t97fv0eE0 7OSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=aibk6Jc9VAZ5PSG3dauyBZkAwA2GeZcL8c5pEn//11Y=; b=i7Lf++4RkShvVvQCFkGJkKO9gJ957aQhposWgg4r2kdBcwBfLRhPhWBoJ2Of1CUFO5 hmvUUjo3Rino5ZlaokzgB0QhkgTRseqX3Ko4IatBt/WtMK2BBwPFXPl5FMi2jIp9JDT4 8HnBHL+vWL0fP/PE/4FXJFtD4LeLPILzJjU7b7asjipkq+nPF7i/nCD7KaFtENp+b4oX KlbyRpDgOphjpQNd+L9s+/od0FV1ELDG0ch5QPpIHiJFDodkdVHzlmPq/boE//VKRkep 0hyYD0cRI+oCHedA3D9tivM8zYp62IBoQ8jy68Sn9hfKZyEMVn7n9NZa/TWi+czZiOiW RkzQ== X-Gm-Message-State: ACgBeo1t1W9Wxro+7zOmteObCS3bywEjBx2QObGlyVbbTFzdjym+8v5y fMSaIGbMZA8pPwYiFMCoQHbfKg== X-Google-Smtp-Source: AA6agR61DbWvoQEMtBUS/Q/nln2iLqn51Y07MebWxX2PHXX7J9JqoQjso//12id3wZBzWiyzkDCLxQ== X-Received: by 2002:a05:600c:348e:b0:3b4:a9f1:c240 with SMTP id a14-20020a05600c348e00b003b4a9f1c240mr6304682wmq.192.1663331371025; Fri, 16 Sep 2022 05:29:31 -0700 (PDT) Received: from srini-hackbase.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id m188-20020a1c26c5000000b003b4a68645e9sm1990825wmm.34.2022.09.16.05.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 05:29:30 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Srinivas Kandagatla Subject: [PATCH 4/4] slimbus: qcom-ngd-ctrl: allow compile testing without QCOM_RPROC_COMMON Date: Fri, 16 Sep 2022 13:29:10 +0100 Message-Id: <20220916122910.170730-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> References: <20220916122910.170730-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski The Qualcomm common remote-proc code (CONFIG_QCOM_RPROC_COMMON) has necessary stubs, so it is not needed for compile testing. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig index 1235b7dc8496..2ed821f75816 100644 --- a/drivers/slimbus/Kconfig +++ b/drivers/slimbus/Kconfig @@ -22,7 +22,8 @@ config SLIM_QCOM_CTRL =20 config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" - depends on HAS_IOMEM && DMA_ENGINE && NET && QCOM_RPROC_COMMON + depends on HAS_IOMEM && DMA_ENGINE && NET + depends on QCOM_RPROC_COMMON || COMPILE_TEST depends on ARCH_QCOM || COMPILE_TEST select QCOM_QMI_HELPERS select QCOM_PDR_HELPERS --=20 2.25.1