From nobody Fri Apr 3 05:15:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4D8ECAAD8 for ; Fri, 16 Sep 2022 04:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229708AbiIPE2M (ORCPT ); Fri, 16 Sep 2022 00:28:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbiIPE14 (ORCPT ); Fri, 16 Sep 2022 00:27:56 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06ACC90192; Thu, 15 Sep 2022 21:27:55 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 70A335C0216; Fri, 16 Sep 2022 00:27:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 16 Sep 2022 00:27:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1663302474; x=1663388874; bh=Hs EeHUxeyjrWeBuU3VZqny77i56V+x03du1DVM7uI8w=; b=brIryO/EcVwIjqFUBL smIzOJN05x3U1vMGm6yDn94n6te/A2IkvkNLzmWLHStTaD95qm9cGsGtj0DeyQMs jDwV2iCjZ9r8Ge5ZlePd3apRUwiIcP813e4j4MumD6Pe06b4J+Ha44yNdOCGR3qO M+Ol/5ItXWL9sYZ/d5okCmb1JXGTFaEDRArXYpJyubo5mz/D6Na+PK/WifflXzND kuWnfyUEE9UzjfzP8FCob+2NjIc95uNByLV3RFLj4AcDZVtP3Ed/FqQgvURX7Vzl /fYYZTL2RJEjmwJmjocDw6Qiyk2xAhjtBBpoMIorcV/ZOUUHQp1IlgADnAFfF5HH Y1lw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1663302474; x=1663388874; bh=HsEeHUxeyjrWe BuU3VZqny77i56V+x03du1DVM7uI8w=; b=eVaRb/oGyl2kcifsoa38TGZsG6VYf kZ8yH4JwF0s9VzYbcEyR8tuzpPxYFLibAiHeLPTaIfimFtwST8GHND0kue+CHssL gejfibC81ReGsw7vhBa3l0cZ68qm5Su5wn01q+ms7Ee5wCbrk9rsa9gyDAfR5anu eEWIWxE6bfKjiRWcdXdltS3TVI6a6n+74dFAQDQhb6+orzPYJap3zfLT4Tt3Yqxh Rxd9Z7c59Y2Z9ZG7Or9vWqs/rLuYd1ZS3fwrESI+EH5bEd5vAaHuB5Rf1DfRUVTZ zOTVwRmE78qUZ9MDSb8EfhN2do3lJTzmHa2XZzDPBwaRGL41FqfzaoUKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduledgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepudekteeuudehtdelteevgfduvddvjefhfedulefgudevgeeghefg udefiedtveetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 00:27:53 -0400 (EDT) From: Samuel Holland To: Chen-Yu Tsai , Jernej Skrabec Cc: Samuel Holland , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: [PATCH v3 1/2] ARM: dts: axp803/axp81x: Drop GPIO LDO pinctrl nodes Date: Thu, 15 Sep 2022 23:27:50 -0500 Message-Id: <20220916042751.47906-2-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220916042751.47906-1-samuel@sholland.org> References: <20220916042751.47906-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The "ldo-io0" and "ldo-io1" regulators are enabled/disabled by toggling the pinmux between two functions. This happens in the regulator driver. Setting the pinmux to "ldo" in the DT is inappropriate because it would enable the regulator before the driver has a chance to set the correct initial voltage. Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec --- Changes in v3: - Added patch to remove existing "ldo" pinctrl nodes arch/arm/boot/dts/axp81x.dtsi | 14 -------------- arch/arm64/boot/dts/allwinner/axp803.dtsi | 10 ---------- 2 files changed, 24 deletions(-) diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi index b93387b0c1c3..ebaf1c3ce8db 100644 --- a/arch/arm/boot/dts/axp81x.dtsi +++ b/arch/arm/boot/dts/axp81x.dtsi @@ -62,16 +62,6 @@ axp_gpio: gpio { compatible =3D "x-powers,axp813-gpio"; gpio-controller; #gpio-cells =3D <2>; - - gpio0_ldo: gpio0-ldo-pin { - pins =3D "GPIO0"; - function =3D "ldo"; - }; - - gpio1_ldo: gpio1-ldo-pin { - pins =3D "GPIO1"; - function =3D "ldo"; - }; }; =20 battery_power_supply: battery-power { @@ -144,15 +134,11 @@ reg_fldo3: fldo3 { }; =20 reg_ldo_io0: ldo-io0 { - pinctrl-names =3D "default"; - pinctrl-0 =3D <&gpio0_ldo>; /* Disable by default to avoid conflicts with GPIO */ status =3D "disabled"; }; =20 reg_ldo_io1: ldo-io1 { - pinctrl-names =3D "default"; - pinctrl-0 =3D <&gpio1_ldo>; /* Disable by default to avoid conflicts with GPIO */ status =3D "disabled"; }; diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi b/arch/arm64/boot/dt= s/allwinner/axp803.dtsi index 578ef368e2b4..a6b4b87f185d 100644 --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi @@ -25,16 +25,6 @@ axp_gpio: gpio { compatible =3D "x-powers,axp803-gpio", "x-powers,axp813-gpio"; gpio-controller; #gpio-cells =3D <2>; - - gpio0_ldo: gpio0-ldo-pin { - pins =3D "GPIO0"; - function =3D "ldo"; - }; - - gpio1_ldo: gpio1-ldo-pin { - pins =3D "GPIO1"; - function =3D "ldo"; - }; }; =20 battery_power_supply: battery-power { --=20 2.35.1 From nobody Fri Apr 3 05:15:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8798DC54EE9 for ; Fri, 16 Sep 2022 04:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbiIPE2E (ORCPT ); Fri, 16 Sep 2022 00:28:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbiIPE14 (ORCPT ); Fri, 16 Sep 2022 00:27:56 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D387DF6F; Thu, 15 Sep 2022 21:27:55 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 654335C021B; Fri, 16 Sep 2022 00:27:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 16 Sep 2022 00:27:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1663302475; x=1663388875; bh=Di L2PG2GPLYyviQvFsfljqZCMe4E9U/861rwG5Z393w=; b=MB7zTG8SQEPBaX9Ot2 tY+J8n7TdmNpnL0bMVPP6DelmfZAiyxOh2qVyvwJ1kwxMI6s1thRylaissHVz6FC 3iDYypwTg/uCxlNl7maMRnpr5p9szPOXMT24aF+bZ4hLujFIQn0TbHruNTOAneCQ nvRWgbxn72FDauaobaZfwSRn8p27ap1j2EWo3pWTTjybH6t2OKD2ArxUnWpAnJJG ynZlFfYbcoiW01u5GWXfAVV+5pDmPyVtLicie00tcGhC7Feb2N8s1Nccm8k1a6u+ Kn9RnXXxVPGd1A5qJYD4J+yzqh2bZGvnrVZaHbsYVoo1aeIT+5oqDmscia/R3ZKk bvVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1663302475; x=1663388875; bh=DiL2PG2GPLYyv iQvFsfljqZCMe4E9U/861rwG5Z393w=; b=AtM5RRrFTK1SCq1ILeiSqYx4Icenk XXWdIiKJaaK0j6mDjrR8NEduxZjyA3XZrOkUI0DNspOUUs8DNl80dQzGn8RCG1Jl Jew7y4d2QmS47w20Pycn1vdFyRKjR8yLU+dGs9c27tyAAy4yN2kt4nBjQpoYXOi3 N4yNBGX1aKrOKrPWIIR+ADJWT7z+uAvBAC5s0zrv53Gg/W1CiWc0UTsJx34SelAU G7Fotm/1wbUSIy+5G/LMD0wDfvgriyKKEN8v5gBS6zbNMQ1rHcWyNgrGh1u8z7ZH iYZpP8o0NZ1invbK4fnSLvuqz4+zrKR3akkN9wbzSJY2/avPTt1IRQGRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduledgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepudekteeuudehtdelteevgfduvddvjefhfedulefgudevgeeghefg udefiedtveetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 00:27:54 -0400 (EDT) From: Samuel Holland To: Chen-Yu Tsai , Jernej Skrabec Cc: Samuel Holland , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: [PATCH v3 2/2] ARM: dts: axp22x/axp809: Add GPIO controller nodes Date: Thu, 15 Sep 2022 23:27:51 -0500 Message-Id: <20220916042751.47906-3-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220916042751.47906-1-samuel@sholland.org> References: <20220916042751.47906-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" These PMICs all contain a GPIO controller. Now that the binding for this variant is documented, wire up the controller in the device tree. Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec --- Changes in v3: - Remove "ldo" pinctrl children from new nodes arch/arm/boot/dts/axp22x.dtsi | 6 ++++++ arch/arm/boot/dts/axp809.dtsi | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi index a020c12b2884..f79650afd0a7 100644 --- a/arch/arm/boot/dts/axp22x.dtsi +++ b/arch/arm/boot/dts/axp22x.dtsi @@ -67,6 +67,12 @@ battery_power_supply: battery-power { status =3D "disabled"; }; =20 + axp_gpio: gpio { + compatible =3D "x-powers,axp221-gpio"; + gpio-controller; + #gpio-cells =3D <2>; + }; + regulators { /* Default work frequency for buck regulators */ x-powers,dcdc-freq =3D <3000>; diff --git a/arch/arm/boot/dts/axp809.dtsi b/arch/arm/boot/dts/axp809.dtsi index ab8e5f2d9246..d134d4c00bd8 100644 --- a/arch/arm/boot/dts/axp809.dtsi +++ b/arch/arm/boot/dts/axp809.dtsi @@ -50,4 +50,11 @@ &axp809 { compatible =3D "x-powers,axp809"; interrupt-controller; #interrupt-cells =3D <1>; + + axp_gpio: gpio { + compatible =3D "x-powers,axp809-gpio", + "x-powers,axp221-gpio"; + gpio-controller; + #gpio-cells =3D <2>; + }; }; --=20 2.35.1