From nobody Fri Apr 3 05:19:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE864C6FA89 for ; Thu, 15 Sep 2022 15:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbiIOPiE (ORCPT ); Thu, 15 Sep 2022 11:38:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiIOPiB (ORCPT ); Thu, 15 Sep 2022 11:38:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5E7B82D09 for ; Thu, 15 Sep 2022 08:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663256276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GXoqsn/bnF/+v01p/YrE+6QGhTzDYbDEdVNXy7Olx1g=; b=PtzzjgO8cmEwx4MLrJJ+9Jpt00U5x1mYhAYO4BMLyX1FYvjKWVI8k/VdEjEZslLJ68FMo8 ZkOTXykN2IH6W1rk6K9AP9SbYVLvc7CJv1j8sWESyswMbP8uBIhLfHtU887feGjErcspBN hPUGLHLSQRyQDgixXqddmefpZiVtPtg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-9-u4PCpoPOe5J9RS1KHPUA-1; Thu, 15 Sep 2022 11:37:53 -0400 X-MC-Unique: 9-u4PCpoPOe5J9RS1KHPUA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2523B29324B3; Thu, 15 Sep 2022 15:37:53 +0000 (UTC) Received: from pauld.bos.com (dhcp-17-237.bos.redhat.com [10.18.17.237]) by smtp.corp.redhat.com (Postfix) with ESMTP id E69002166B29; Thu, 15 Sep 2022 15:37:52 +0000 (UTC) From: Phil Auld To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Peter Zijlstra , Valentin Schneider , Steven Price , Mark Rutland , Frederic Weisbecker Subject: [RESEND PATCH v4 1/2] cpuhp: make target_store() a nop when target == state Date: Thu, 15 Sep 2022 11:37:50 -0400 Message-Id: <20220915153751.2123654-2-pauld@redhat.com> In-Reply-To: <20220915153751.2123654-1-pauld@redhat.com> References: <20220915153751.2123654-1-pauld@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Writing the current state back in hotplug/target calls cpu_down() which will set cpu dying even when it isn't and then nothing will ever clear it. A stress test that reads values and writes them back for all cpu device files in sysfs will trigger the BUG() in select_fallback_rq once all cpus are marked as dying. kernel/cpu.c::target_store() ... if (st->state < target) ret =3D cpu_up(dev->id, target); else ret =3D cpu_down(dev->id, target); cpu_down() -> cpu_set_state() bool bringup =3D st->state < target; ... if (cpu_dying(cpu) !=3D !bringup) set_cpu_dying(cpu, !bringup); Fix this by letting state=3D=3Dtarget fall through in the target_store() conditional. Also make sure st->target =3D=3D target in that case. Signed-off-by: Phil Auld Reviewed-by: Valentin Schneider Fixes: 757c989b9994 ("cpu/hotplug: Make target state writeable") Cc: Thomas Gleixner Cc: "Peter Zijlstra (Intel)" Cc: Steven Price Cc: Mark Rutland Cc: Frederic Weisbecker --- kernel/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index bbad5e375d3b..979de993f853 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -2326,8 +2326,10 @@ static ssize_t target_store(struct device *dev, stru= ct device_attribute *attr, =20 if (st->state < target) ret =3D cpu_up(dev->id, target); - else + else if (st->state > target) ret =3D cpu_down(dev->id, target); + else if (WARN_ON(st->target !=3D target)) + st->target =3D target; out: unlock_device_hotplug(); return ret ? ret : count; --=20 2.31.1 From nobody Fri Apr 3 05:19:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6939ECAAA1 for ; Thu, 15 Sep 2022 15:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229850AbiIOPiK (ORCPT ); Thu, 15 Sep 2022 11:38:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiIOPiD (ORCPT ); Thu, 15 Sep 2022 11:38:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FE6382FA1 for ; Thu, 15 Sep 2022 08:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663256277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MeijtbKvrYGzYu1cjjokAKVDKvkSgGK6+5a9Mt5coG4=; b=N+2ypnB/vVV2u7p3mhJr9x53dj38wPqrrgknTF7jioIG3D3NacWcB87RwnGYcwcZr/0gSI 48u4avVsKuoWLP3YqgwLRinDVMr3Ulu3rxl+0wYrJP9veJ+DgFDptEqNX7u+0npcYnQbyD /7p6RVlMfDobKgy3fElC6CAcYqzOdwQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-wpxUSTTZPyCSvepizFF92A-1; Thu, 15 Sep 2022 11:37:53 -0400 X-MC-Unique: wpxUSTTZPyCSvepizFF92A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60680382ECD0; Thu, 15 Sep 2022 15:37:53 +0000 (UTC) Received: from pauld.bos.com (dhcp-17-237.bos.redhat.com [10.18.17.237]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D9792166B26; Thu, 15 Sep 2022 15:37:53 +0000 (UTC) From: Phil Auld To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Peter Zijlstra , Valentin Schneider , Steven Price , Mark Rutland , Frederic Weisbecker Subject: [RESEND PATCH v4 2/2] cpuhp: Set cpuhp target for boot cpu Date: Thu, 15 Sep 2022 11:37:51 -0400 Message-Id: <20220915153751.2123654-3-pauld@redhat.com> In-Reply-To: <20220915153751.2123654-1-pauld@redhat.com> References: <20220915153751.2123654-1-pauld@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since the boot cpu does not go through the hotplug process it ends up with state =3D=3D CPUHP_ONLINE but target =3D=3D CPUHP_OFFLINE. So set the target to match in boot_cpu_hotplug_init(). Signed-off-by: Phil Auld Reviewed-by: Valentin Schneider Cc: Thomas Gleixner Cc: "Peter Zijlstra (Intel)" Cc: Steven Price Cc: Mark Rutland Cc: Frederic Weisbecker --- kernel/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/cpu.c b/kernel/cpu.c index 979de993f853..3f704a8896b0 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -2690,6 +2690,7 @@ void __init boot_cpu_hotplug_init(void) cpumask_set_cpu(smp_processor_id(), &cpus_booted_once_mask); #endif this_cpu_write(cpuhp_state.state, CPUHP_ONLINE); + this_cpu_write(cpuhp_state.target, CPUHP_ONLINE); } =20 /* --=20 2.31.1