From nobody Sun Apr 5 16:33:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E47ECAAD3 for ; Thu, 15 Sep 2022 12:43:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbiIOMnB (ORCPT ); Thu, 15 Sep 2022 08:43:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbiIOMmu (ORCPT ); Thu, 15 Sep 2022 08:42:50 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A974489CFA for ; Thu, 15 Sep 2022 05:42:38 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id a80so9356108pfa.4 for ; Thu, 15 Sep 2022 05:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=t5M7NGDngN2+Zs7ekggybVds5iPQe8oTPjWTdXRHUpI=; b=yMB1ygNra22/dbB0LtinX5144RnJbP9QRbAMuXVq5qwgke2ZDqiUIlIkg373jaw409 ky5nHLN+VRcOUPJKsbcqA6nX6ejCJDGnV/EZJx9Mdqiuc1HnEaMEwLMr0iCRD0aIftj+ L7Trba18ZKseDR23Wwn2d0kJP/GdzkOvXi8Ao1b5rZ4NOf8X63ggOtslfSgJ3eN0csts sKDusv3Mk0t0UUcRn+Bze7XLFmwVgjmv8Pn7Q7iW2gy5ZKCSjy9trv3ugk6E24JZPoYb l9gPP7E67+SsDIvX8LXpLpLW98y4QmgeuyDvyp3a5Pp6srZEK71u4IBrHSKl+eKM3Suk Wemw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=t5M7NGDngN2+Zs7ekggybVds5iPQe8oTPjWTdXRHUpI=; b=AYxmcZ8cHAD+KzkrFf8dHBht5PrVUuaeq3GAOu+fQzj5zKGeKdtUkbGUrcA0Prsw1w N0FLib/nBYKBbMac/uuyAgceGYWzLXdi30pUtZieC20s2ZUGNah7wrSX3zrLlS0VMzT3 CRP3t4QkDPPZMfpq9fgc5o4WUpwCLCTAnQ5j56YsNYeevtVnD3RqgAvIHgwKXhBzuxcp Mh/GXyRlBb6Nu2BM9XjWzb+Sc0Q0qWnRiW7sCopeY9ChVSvrIRWse9L0wE6IVOkB9l4p ZI2KWhaUloqBj1q3J7dNQOotot4zDt90CnJSr3jRIkBIHWgLaiePQ75uMiVuOT0+Ly9I by8g== X-Gm-Message-State: ACgBeo3Qto1hhJCSqeRQwbffeXOeQXNP2Zu6DhKaz6fTEP0hdDDGdoSq GHKmua+bq19oITvMemR3elA2bU4SCOSIBw== X-Google-Smtp-Source: AA6agR6/XAjdH9+npfmFldAa27FSTWW5L+DsOFy757wu75dK8NFSHbGVIh2sRGCJTxkzf4PehyCZ/g== X-Received: by 2002:a63:8848:0:b0:434:b5d7:b4fa with SMTP id l69-20020a638848000000b00434b5d7b4famr35413685pgd.181.1663245757953; Thu, 15 Sep 2022 05:42:37 -0700 (PDT) Received: from C02G705SMD6V.bytedance.net ([61.120.150.76]) by smtp.gmail.com with ESMTPSA id p8-20020a170902780800b001637529493esm12721906pll.66.2022.09.15.05.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 05:42:37 -0700 (PDT) From: Jia Zhu To: linux-erofs@lists.ozlabs.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yinxin.x@bytedance.com, jefflexu@linux.alibaba.com, Jia Zhu Subject: [PATCH V4 2/6] erofs: code clean up for fscache Date: Thu, 15 Sep 2022 20:42:09 +0800 Message-Id: <20220915124213.25767-3-zhujia.zj@bytedance.com> X-Mailer: git-send-email 2.37.0 (Apple Git-136) In-Reply-To: <20220915124213.25767-1-zhujia.zj@bytedance.com> References: <20220915124213.25767-1-zhujia.zj@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Some cleanups. No logic changes. Suggested-by: Jingbo Xu Signed-off-by: Jia Zhu --- fs/erofs/fscache.c | 36 ++++++++++++++++++------------------ fs/erofs/internal.h | 17 ++++++++--------- fs/erofs/super.c | 22 +++++++++------------- 3 files changed, 35 insertions(+), 40 deletions(-) diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c index 8e01d89c3319..d72e2a7ea6ab 100644 --- a/fs/erofs/fscache.c +++ b/fs/erofs/fscache.c @@ -417,9 +417,8 @@ const struct address_space_operations erofs_fscache_acc= ess_aops =3D { .readahead =3D erofs_fscache_readahead, }; =20 -int erofs_fscache_register_cookie(struct super_block *sb, - struct erofs_fscache **fscache, - char *name, bool need_inode) +struct erofs_fscache *erofs_fscache_register_cookie(struct super_block *sb, + char *name, bool need_inode) { struct fscache_volume *volume =3D EROFS_SB(sb)->volume; struct erofs_fscache *ctx; @@ -428,7 +427,7 @@ int erofs_fscache_register_cookie(struct super_block *s= b, =20 ctx =3D kzalloc(sizeof(*ctx), GFP_KERNEL); if (!ctx) - return -ENOMEM; + return ERR_PTR(-ENOMEM); =20 cookie =3D fscache_acquire_cookie(volume, FSCACHE_ADV_WANT_CACHE_SIZE, name, strlen(name), NULL, 0, 0); @@ -458,40 +457,32 @@ int erofs_fscache_register_cookie(struct super_block = *sb, ctx->inode =3D inode; } =20 - *fscache =3D ctx; - return 0; + return ctx; =20 err_cookie: fscache_unuse_cookie(ctx->cookie, NULL, NULL); fscache_relinquish_cookie(ctx->cookie, false); - ctx->cookie =3D NULL; err: kfree(ctx); - return ret; + return ERR_PTR(ret); } =20 -void erofs_fscache_unregister_cookie(struct erofs_fscache **fscache) +void erofs_fscache_unregister_cookie(struct erofs_fscache *ctx) { - struct erofs_fscache *ctx =3D *fscache; - if (!ctx) return; =20 fscache_unuse_cookie(ctx->cookie, NULL, NULL); fscache_relinquish_cookie(ctx->cookie, false); - ctx->cookie =3D NULL; - iput(ctx->inode); - ctx->inode =3D NULL; - kfree(ctx); - *fscache =3D NULL; } =20 int erofs_fscache_register_fs(struct super_block *sb) { struct erofs_sb_info *sbi =3D EROFS_SB(sb); struct fscache_volume *volume; + struct erofs_fscache *fscache; char *name; int ret =3D 0; =20 @@ -502,12 +493,19 @@ int erofs_fscache_register_fs(struct super_block *sb) volume =3D fscache_acquire_volume(name, NULL, NULL, 0); if (IS_ERR_OR_NULL(volume)) { erofs_err(sb, "failed to register volume for %s", name); - ret =3D volume ? PTR_ERR(volume) : -EOPNOTSUPP; - volume =3D NULL; + kfree(name); + return volume ? PTR_ERR(volume) : -EOPNOTSUPP; } =20 sbi->volume =3D volume; kfree(name); + + fscache =3D erofs_fscache_register_cookie(sb, sbi->opt.fsid, true); + /* acquired volume will be relinquished in kill_sb() */ + if (IS_ERR(fscache)) + return PTR_ERR(fscache); + + sbi->s_fscache =3D fscache; return ret; } =20 @@ -515,6 +513,8 @@ void erofs_fscache_unregister_fs(struct super_block *sb) { struct erofs_sb_info *sbi =3D EROFS_SB(sb); =20 + erofs_fscache_unregister_cookie(sbi->s_fscache); fscache_relinquish_volume(sbi->volume, NULL, false); + sbi->s_fscache =3D NULL; sbi->volume =3D NULL; } diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index cfee49d33b95..aa71eb65e965 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h @@ -610,27 +610,26 @@ static inline int z_erofs_load_lzma_config(struct sup= er_block *sb, int erofs_fscache_register_fs(struct super_block *sb); void erofs_fscache_unregister_fs(struct super_block *sb); =20 -int erofs_fscache_register_cookie(struct super_block *sb, - struct erofs_fscache **fscache, - char *name, bool need_inode); -void erofs_fscache_unregister_cookie(struct erofs_fscache **fscache); +struct erofs_fscache *erofs_fscache_register_cookie(struct super_block *sb, + char *name, bool need_inode); +void erofs_fscache_unregister_cookie(struct erofs_fscache *fscache); =20 extern const struct address_space_operations erofs_fscache_access_aops; #else static inline int erofs_fscache_register_fs(struct super_block *sb) { - return 0; + return -EOPNOTSUPP; } static inline void erofs_fscache_unregister_fs(struct super_block *sb) {} =20 -static inline int erofs_fscache_register_cookie(struct super_block *sb, - struct erofs_fscache **fscache, - char *name, bool need_inode) +static inline +struct erofs_fscache *erofs_fscache_register_cookie(struct super_block *sb, + char *name, bool need_inode) { return -EOPNOTSUPP; } =20 -static inline void erofs_fscache_unregister_cookie(struct erofs_fscache **= fscache) +static inline void erofs_fscache_unregister_cookie(struct erofs_fscache *f= scache) { } #endif diff --git a/fs/erofs/super.c b/fs/erofs/super.c index 9716d355a63e..79e871c04fe2 100644 --- a/fs/erofs/super.c +++ b/fs/erofs/super.c @@ -224,10 +224,10 @@ static int erofs_init_device(struct erofs_buf *buf, s= truct super_block *sb, struct erofs_device_info *dif, erofs_off_t *pos) { struct erofs_sb_info *sbi =3D EROFS_SB(sb); + struct erofs_fscache *fscache; struct erofs_deviceslot *dis; struct block_device *bdev; void *ptr; - int ret; =20 ptr =3D erofs_read_metabuf(buf, sb, erofs_blknr(*pos), EROFS_KMAP); if (IS_ERR(ptr)) @@ -245,10 +245,10 @@ static int erofs_init_device(struct erofs_buf *buf, s= truct super_block *sb, } =20 if (erofs_is_fscache_mode(sb)) { - ret =3D erofs_fscache_register_cookie(sb, &dif->fscache, - dif->path, false); - if (ret) - return ret; + fscache =3D erofs_fscache_register_cookie(sb, dif->path, false); + if (IS_ERR(fscache)) + return PTR_ERR(fscache); + dif->fscache =3D fscache; } else { bdev =3D blkdev_get_by_path(dif->path, FMODE_READ | FMODE_EXCL, sb->s_type); @@ -706,11 +706,6 @@ static int erofs_fc_fill_super(struct super_block *sb,= struct fs_context *fc) if (err) return err; =20 - err =3D erofs_fscache_register_cookie(sb, &sbi->s_fscache, - sbi->opt.fsid, true); - if (err) - return err; - err =3D super_setup_bdi(sb); if (err) return err; @@ -817,7 +812,8 @@ static int erofs_release_device_info(int id, void *ptr,= void *data) fs_put_dax(dif->dax_dev, NULL); if (dif->bdev) blkdev_put(dif->bdev, FMODE_READ | FMODE_EXCL); - erofs_fscache_unregister_cookie(&dif->fscache); + erofs_fscache_unregister_cookie(dif->fscache); + dif->fscache =3D NULL; kfree(dif->path); kfree(dif); return 0; @@ -889,7 +885,6 @@ static void erofs_kill_sb(struct super_block *sb) =20 erofs_free_dev_context(sbi->devs); fs_put_dax(sbi->dax_dev, NULL); - erofs_fscache_unregister_cookie(&sbi->s_fscache); erofs_fscache_unregister_fs(sb); kfree(sbi->opt.fsid); kfree(sbi); @@ -909,7 +904,8 @@ static void erofs_put_super(struct super_block *sb) iput(sbi->managed_cache); sbi->managed_cache =3D NULL; #endif - erofs_fscache_unregister_cookie(&sbi->s_fscache); + erofs_fscache_unregister_fs(sb); + sbi->s_fscache =3D NULL; } =20 static struct file_system_type erofs_fs_type =3D { --=20 2.20.1