From nobody Fri Apr 3 06:45:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8411CECAAD3 for ; Wed, 14 Sep 2022 16:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbiINQow (ORCPT ); Wed, 14 Sep 2022 12:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbiINQoi (ORCPT ); Wed, 14 Sep 2022 12:44:38 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2073.outbound.protection.outlook.com [40.107.94.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A1FCDFE3; Wed, 14 Sep 2022 09:44:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b1/XTMSMAPT06yOTmfutAMcH8+aQofpWxm4ZptZxEXb/SXr38qYSiwh12SwhF4ioKmPtpTDxh/+BeDbA8AKrtAbAjSgdny4f9jSmEZtLr9Ni5AmdAB1rmIoy3I77oaUhfinjXCFZJ/i1bY53bl/76McXWIeOL2lruCdlL2GJxXYAJuCsfyKUViQa61WLZRHhUF3BxNiDsBRLReiouk7/iq16O5fOknsUL4m9Z1HSBEAhlavp3Oj2OLNKFd1u62WFHm0R3Y5dmgElptT5JscZncoXOkVsRqj5dAHjiJmLUSx+1pughpFjyPI/cholhmwYXusED7SaZWPdKNtjJZ0ZVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gchUWKBAKuchaeGM+DQztQFBRXMefRz7sl/QTpXGgP8=; b=OOIgCEd6I1cRPdP0HLsXFxuXQ3CdYrdl3X+O/SxUxA2kiCn88Ye6EuXyThRoJ6U4KsENI9GeYSu8WAtecZ4OpYlcQw41HxdTtQvNgceobpwBDGIvrJQHzWjoNStVNq6aA7gHw2NJnSYouong5WDxblRpNilJKyKM/CiBLyxY5GGGkd61FGvwogJFzPQY3YwiExAfwD16O2l3YtlLWSHnsZFPbo3c8hE4TRgkKqyc462P/NkRfMorOG4ivCGQyEp0/68vxpncAIh81xlo3ZZ8GRV1mP4Lt7IEDlYsi/QGnwI6xTRaevSrarXvQUxf3PEpPC4C0b4NZPfz0g6k1WXaiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gchUWKBAKuchaeGM+DQztQFBRXMefRz7sl/QTpXGgP8=; b=j2bRW8NSDzT7jxbOTQJS+DnBLJM4jtjVG6RxQ+DDc81LEloJaxqVl3MzqF+4bM4ZHdor6DXmK1BFDoW1xHkPskBitKp/1MJc9y0JTdc3wh7stpL6/DyIjDNgy/YcRm7Ncc6CdIA8COOHwHEpHgqrrUq8gBoXSQPW9pUI0EsXtLU= Received: from BN9PR03CA0362.namprd03.prod.outlook.com (2603:10b6:408:f7::7) by DM6PR12MB4314.namprd12.prod.outlook.com (2603:10b6:5:211::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Wed, 14 Sep 2022 16:44:31 +0000 Received: from BN8NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::6d) by BN9PR03CA0362.outlook.office365.com (2603:10b6:408:f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14 via Frontend Transport; Wed, 14 Sep 2022 16:44:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT034.mail.protection.outlook.com (10.13.176.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:44:31 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 11:44:26 -0500 From: Arvind Yadav To: , , , , , , , , , , , , CC: Arvind Yadav , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH v4 1/6] dma-buf: Remove the signaled bit status check Date: Wed, 14 Sep 2022 22:13:16 +0530 Message-ID: <20220914164321.2156-2-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com> References: <20220914164321.2156-1-Arvind.Yadav@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT034:EE_|DM6PR12MB4314:EE_ X-MS-Office365-Filtering-Correlation-Id: 699c2846-648f-45c6-f20d-08da967065a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rAUPCm2+IJkxVWWUQSXFgO0H7VInCjG8F3NVAGWFqQY8IlHUPHG9Ofd1MoLX+iF8HYpRhCePFhvVU2GU8P5n3aEq3EQc79nCRSxhf1CE5rR8jEfOX+wAHRp/RYNHGpMc4wUSTfhY0uetC7VYo2vuTFZ05pyXMsMwnrjtQpE0gnZgAFjbARk2fqh76UDDUKa5aKiedavEd9etdpeimjdYyr9jNxh4R1JTIMRcfZCqoTUEyG7dsTRfA+Iu5EANiXb/lrpn0/UIW0oWA+bDvrlRhuriRPqb/Eerhtwl1aiZFYXtnip6TKz2Mufbwf76P4OmkOjhrHvcW1wjmeevuLhU1vxPnX6ZGOEIEqvAbUVWJxbCOMVqZr7nRd4kYSEgxhFszuBhV4kzf47fJGWtOoIHYG0LsEvLiOOP0DEhzgbG5CqHeljZqTAfqN05Qh5ij38coMAtaJim6FSfNzD7CqtiJX5kLN8kkV+CIxJUj/mVOac9jFB9HWeiNfY5La9A3WDKij85O6JPCf2ctwhNMGhsCZafHuAZNgGBo9TEQScoeViGmdhV55P0k34P+TotbU8F/8rqcNYAY2F+AX0pllpCke5vXfq+jkFhcXHFwLC1RRpzPazFXPc6U2B1j4juVW/7Dm/nGox5RCwDMv9Jt/bGJ0IW+5mOR+l3ij1z+D1GZLcICaTmqXM9211UuDeueZ1JG5G07Q1I69mYS+iCxrNsTUDjU3thp9NUGrQy3qQvqccE5O/nSGd1W8USZwr+KaQWew4Xpx6dQ8MVJFFxORWB12S1nUIX8qSt3aGRZCkJ23iTzMODNtWD42vTYTSscwZicYx7nqMPB8PJZwMh10obHMmQayLSAM/P26SfeVx83FA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(26005)(70206006)(1076003)(316002)(7696005)(47076005)(36860700001)(70586007)(5660300002)(8676002)(4744005)(41300700001)(83380400001)(6666004)(66574015)(8936002)(82310400005)(356005)(40480700001)(86362001)(2616005)(921005)(2906002)(82740400003)(36756003)(4326008)(336012)(81166007)(54906003)(40460700003)(16526019)(110136005)(186003)(478600001)(426003)(83996005)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 16:44:31.1664 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 699c2846-648f-45c6-f20d-08da967065a6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4314 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the signaled bit status check because it is returning early when the fence is already signaled and __dma_fence_enable_signaling is checking the status of signaled bit again. Signed-off-by: Arvind Yadav Reviewed-by: Christian K=C3=B6nig --- Changes in v1, v2: This new patch was not part of previous series. --- drivers/dma-buf/dma-fence.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 066400ed8841..64c99739ad23 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -601,9 +601,6 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fe= nce) { unsigned long flags; =20 - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) - return; - spin_lock_irqsave(fence->lock, flags); __dma_fence_enable_signaling(fence); spin_unlock_irqrestore(fence->lock, flags); --=20 2.25.1 From nobody Fri Apr 3 06:45:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF54ECAAD3 for ; Wed, 14 Sep 2022 16:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229603AbiINQpL (ORCPT ); Wed, 14 Sep 2022 12:45:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbiINQpG (ORCPT ); Wed, 14 Sep 2022 12:45:06 -0400 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2050.outbound.protection.outlook.com [40.107.212.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 260744D833; Wed, 14 Sep 2022 09:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xy5uQsNhf2fgkX2EK4nUqhSMOBUKXviGkybVHHSd8pLD5ReMcl9mLZsl3dPW/O83GwAdkDK8UTYNCoj7pckw5s3ULRI8fRt8RGjPmLKA7DS7KYoSIEBWVsamf07/jJtbrcG0ANnqFPc3Ujpy6bmEzZheMzhGpKK5Z1ZbfulTGvhfd8TVB/q3SCNTMiqxLHsp9kknNZnBzl9JA87+lzb/YGl6w5ey9iW5GSfleswM5hPkxeQV0ldElvGbbdI+EsOnTPLezsI49TLFK7mKUMhiTNTzkmmTmgbcr6Tki21Z5XxRfKMQBKchh/BtewHp0ed2QmKvIPRtYYehxTCvNLsa6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EHKQo3CbRkA/356+OZefIRvz4ZXAuBE+hL6lilRuDE4=; b=I5Vbup2Uuf9rFsAB3Y5xu8zImvQbcA9/H6Jk2hHoPx7VWhs6DdyYzkev5GihJADsBFW33tXtIPYCXruBAK5eB+8MdKt6fbEl6cJmDGhAAS8NdsKQ2mB7i4dbHDbebOLT22SUdV68vlKFSikinWomX8Z+BPSXTkmzv8K/fVhpOIpznfu2zAZFgKbqu8+YBnVI0b4wxpvorAlEW+em8JTXUJHDjIpU3uBcYCFWa5FLFrFPnI2HMNyrmmunZ5fmekRO8PTR7CkGiZHYXbV/Al6r8JFH3L0yMFobMwRgmQZoJzTntmt2gOYLEDAuIXnCCTAEfeZNVsVBZeaPFKVaea4uqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHKQo3CbRkA/356+OZefIRvz4ZXAuBE+hL6lilRuDE4=; b=LSSS96hhKQSV3AhNHtxdv9LDHkP2gJP+xkf7DemcGHMdj1jVGK6NF34xLpMXjxJVBA6CsBS+xDAvt9zMlz1q/B4tcuGoLnuGMVrNEjBiKXDF2dTTX6ws0DQg+4xj8yrtI+HjcFOqaJCxjM9kI8V3YiLwasGLhsdfJSD3+MT+ZwQ= Received: from BN0PR08CA0030.namprd08.prod.outlook.com (2603:10b6:408:142::9) by MW4PR12MB7013.namprd12.prod.outlook.com (2603:10b6:303:218::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 14 Sep 2022 16:44:57 +0000 Received: from BN8NAM11FT073.eop-nam11.prod.protection.outlook.com (2603:10b6:408:142:cafe::4a) by BN0PR08CA0030.outlook.office365.com (2603:10b6:408:142::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 14 Sep 2022 16:44:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT073.mail.protection.outlook.com (10.13.177.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:44:56 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 11:44:52 -0500 From: Arvind Yadav To: , , , , , , , , , , , , CC: Arvind Yadav , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH v4 2/6] dma-buf: set signaling bit for the stub fence Date: Wed, 14 Sep 2022 22:13:17 +0530 Message-ID: <20220914164321.2156-3-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com> References: <20220914164321.2156-1-Arvind.Yadav@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT073:EE_|MW4PR12MB7013:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c6c9833-ff8a-4ebe-57a3-08da967074ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iPa48RNuGwLMybk1SNRLkEicIjC766KkT2LDIljdi3+FVr0kRRPerOtvb66ZvySqq9PztYYRS1qFZhh+jXDhQ59Nvdjl+Mzg7gw9PYxvj2ze/TGqgzBXLNfAWSKO7gJXfHGHvN1pxOfU/CgsnfHcrLdOUqYvkyRgE6IvzaFLD4GdC3ZnmsgzJi+0KDwyd1rGpYnaKaYhrleEcG4ZQfEivDJVqeyxgLt+whXz2g2hJQ0BMbkdgezpWjTXbmQTRSmsn4/g8UtQgH/XW/B/mI8I0gF3UOLff1Kr0az9YY4HxrRcd6TskHywd5Ic8GiCcg+X8Jgc6CCHmNdZYRCfsu7dKZvcEKyyu9yjC7+evWU7lAinXSwgr7hPh0JRjYFhbbNEjrQo7eJBWNPbwbv//2CJtkPrONtR4SEOuajWXG2ViB7X0WeImmGDInOwGAJmr3RrrzjxHE3lVB1jgyPF1HSRTQVUMOfw9Fm4r/FcY7TKwGAZZl28k4tuNF0gw5SRvtD0oiakAn2chF3B6wlkEkhK0ttGZDCmKBTkqsD064NfF9dIpSV7ZJ8XDQy7HOjdY1V2+ALFZN8Jy1/sKs3ReItoLjJUhqDoXhVslMRftv15KuZRJrMhni4d3H3fc2ymIgbEIaaXp7FL2EMLqquna6mY/f85DLWatLWMP+tvXAsa7B27RDii59+usIpHuKLuxhsWjl5I6X+RyjqRJTHiP5CDnrYhu7CXMxw1URbnyW0UOvRfcEwyU8xPkpUbNtLJ7I4sipd+kpJc4lX5dlCOoZgqKPQqEUIXiJoUS58fN00l2NIB/+AKkBxru9qvBTlckem90Kbolfzfeu18mgI6Tivx/n3JGw7cVvZyVE+2DQUB4kuBWfG0TOs0ztpRqrCQ8XPD X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199015)(40470700004)(36840700001)(46966006)(47076005)(82740400003)(81166007)(36756003)(356005)(426003)(921005)(336012)(316002)(2616005)(40480700001)(82310400005)(1076003)(6666004)(2906002)(8676002)(40460700003)(110136005)(66574015)(70206006)(186003)(7696005)(83380400001)(26005)(478600001)(86362001)(54906003)(41300700001)(70586007)(16526019)(5660300002)(4326008)(36860700001)(8936002)(83996005)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 16:44:56.4438 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c6c9833-ff8a-4ebe-57a3-08da967074ba X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT073.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7013 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Here's setting software signaling bit for the stub fence which is always signaled. If this fence signaling bit is not set then the AMD GPU scheduler will cause a GPU reset due to a GPU scheduler cleanup activity timeout. Signed-off-by: Arvind Yadav Reviewed-by: Christian K=C3=B6nig --- Changes in v1 : 1- Addressing Christian's comment to remove unnecessary callback. 2- Replacing CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS. 3- The version of this patch is also changed and previously it was [PATCH 3/4] Changes in v2 : 1 - perviously using __dma_fence_enable_signaling() for enable signaling. 2 - #ifdef CONFIG_DEBUG_WW_MUTEX_SLOWPATH removed Changes in v3 : 1 - Enable Signaling bit for dma_fence_allocate_private_stub. --- drivers/dma-buf/dma-fence.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 64c99739ad23..645c158b7e01 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -136,6 +136,10 @@ struct dma_fence *dma_fence_get_stub(void) &dma_fence_stub_ops, &dma_fence_stub_lock, 0, 0); + + set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, + &dma_fence_stub.flags); + dma_fence_signal_locked(&dma_fence_stub); } spin_unlock(&dma_fence_stub_lock); @@ -161,6 +165,10 @@ struct dma_fence *dma_fence_allocate_private_stub(void) &dma_fence_stub_ops, &dma_fence_stub_lock, 0, 0); + + set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, + &dma_fence_stub.flags); + dma_fence_signal(fence); =20 return fence; --=20 2.25.1 From nobody Fri Apr 3 06:45:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 610F7ECAAD3 for ; Wed, 14 Sep 2022 16:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbiINQpQ (ORCPT ); Wed, 14 Sep 2022 12:45:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbiINQpK (ORCPT ); Wed, 14 Sep 2022 12:45:10 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2064.outbound.protection.outlook.com [40.107.243.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EBA75E66B; Wed, 14 Sep 2022 09:45:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jVxetlU+uOgHWViT9jwU345uTFS3xdnGLDaq8HgE0AkYEjsJJX9hGoFWukfHON84Xu90b3j2bKmBvcS293GBlCzwC/9lFTb8Z2YvUO1YD1MevaTsyImG6l9nFmE+DmGfvHdbMLkZPNNNk9ZjyfL1XFGpqhcrCmhu0oXWPt0NysIghte08p1lXavqigm1F4vGyTvYVqqFkCuoijtCzr4st5Q1v0odOLP5sCIYquI4Qk3H7Za1TC+6XL2iMQ4VwlNczMmI6+Yxi5ZO/3znqdaLzTluyYtSclK/K4Do35cdELkdfgfV0j+JBWBpgtUkilZUkrmeREwnmQow2rK/YlSG+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MBSapcCiT/BYGpsHztm/uk8Z1kATGs0rsIgxxHpXsZU=; b=g2Tal5JmDO5VJgsnc3VYqkGLQoVBGkrANHWWM5WE9wobOByPWQrRo3MS3napyOX+eDJxRJpjYyrb+eunCLcH2ye65CZ5e2b/MUJUM8hObcMx0NUR2/6ijUuRrerWvV0KNgBIkYkd6MLWkf9esGr7S2apAjTG8MGLUMmtRpQQUktKzZxONXvPdQxeJloj28OG5nKrNQoqdA0zwEWunHmKxGtJ9ytuA3Jpgf/QA3ids7Efq8Pl5qJWYkLq0839yuXJJczRgPFcgy1QGlFu0t/u0CNv/0qHysIr1a7UZcSkg28gWcMs4QrksZCJ/dQm+nBaugKpaFPGElbZ9nZFXh2Onw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MBSapcCiT/BYGpsHztm/uk8Z1kATGs0rsIgxxHpXsZU=; b=sViw5iIXknSjwiTidbaUaxhKT5Yl3E2cuIrNGyYqivg9m1HiFUifpAq5qxvssTerWkpYzMcjh8lkb2Nujw+w0OzNAaHK+zJwpyrKsn7xrXEJ90S2pXgbyx2/47E/3+aHhW3CwqYHUrToNJ8G3oDEL74BoZsc1tPCj8pjqFJkPbI= Received: from BN9PR03CA0589.namprd03.prod.outlook.com (2603:10b6:408:10d::24) by SA0PR12MB7002.namprd12.prod.outlook.com (2603:10b6:806:2c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Wed, 14 Sep 2022 16:45:03 +0000 Received: from BN8NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10d:cafe::e) by BN9PR03CA0589.outlook.office365.com (2603:10b6:408:10d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Wed, 14 Sep 2022 16:45:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT096.mail.protection.outlook.com (10.13.177.195) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:45:03 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 11:44:58 -0500 From: Arvind Yadav To: , , , , , , , , , , , , CC: Arvind Yadav , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH v4 3/6] dma-buf: Enable signaling on fence for selftests Date: Wed, 14 Sep 2022 22:13:18 +0530 Message-ID: <20220914164321.2156-4-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com> References: <20220914164321.2156-1-Arvind.Yadav@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT096:EE_|SA0PR12MB7002:EE_ X-MS-Office365-Filtering-Correlation-Id: 3acdc078-57f5-40f1-1dec-08da967078e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lDUII2ZbnIWNGl3AmYZmZThP41o9gJd4ck5VSkfbTK0b+v/V3Iu43PRwsrgRsW8vBhGt3gWatv+WwGhHczahUmh2Gk0OuVFDdzOzMMmFXIY+ZT7BJsgCA5+p3ZsxVrcEWA0ET9Rnng3ZeAgIaF8GjWUJNjNpyW1qLWhx3nRpqmIe79SEp9iugc+Pr9QbZnSL8nOFRBEU209nCAAQSTj5KeF/TZj7V6YVN6qHjfc1LQjkvIMTAxipLEdVNUWMImNNQIsnlHOT0+qT3GvimwhTCDqNupsXlUW81G/QR2sgXiRTIMfz4ZolVsQn4eNeZ7oHcB6pGlILsANvH8kg3grTzyF6g7w7LP0hO2RtLMTroOfULqFvLjMiY7b5aCSvXKO89RNF0aNEL2dOat6l87kjjXzKyPr4iJvTUVzONyF7xNTGgRYfmPevMHS0djJcP9gySHW50p3JYPcYeqkAMFq6KfLSAzKIV6mOSOAlvTB2gDZ4IFIHOU2Bu9P/pL5ox9N+X9SlKHDzHOZ5qeDavNTSgWsXcC3QBRRpjOwuMoyQTag4v3X+BMZGfD2Qhf3yec2Bx5axfeQF+1u2gZmzJTpMkfQ8XDQ5wXVApPDzf3arkLRUHSW20YndGyI5E8tcMCfQ2+I0AO65v5ASqDKLjNHosujnnwqhjRoetRSIbHEn/oEMB0pFknmrz9gTO96DT9t0W5KPWg9ZRO1NQDzcrWN8fuYuaDiVt87198Zqy9vgEvi47BHkcS7DX6gdjBnj/VvZoSOzFD5nBAVgspRDS7QzZzPOsxNCjnyj/zQTFnjjGKbcuiQ6qxKviDPcqLWXvty9oP+tcae7fyyBGIzMqo3kbBCilFOf+JHnOePd2p4l6JHf68nIdjkIXHMBq2icKG1u X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(40460700003)(110136005)(5660300002)(316002)(6666004)(2906002)(41300700001)(2616005)(478600001)(8676002)(426003)(47076005)(26005)(36756003)(8936002)(70206006)(16526019)(336012)(1076003)(66574015)(356005)(186003)(83380400001)(81166007)(36860700001)(70586007)(40480700001)(54906003)(82310400005)(921005)(82740400003)(4326008)(86362001)(7696005)(83996005)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 16:45:03.4309 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3acdc078-57f5-40f1-1dec-08da967078e2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7002 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Here's enabling software signaling on fence for selftest. Signed-off-by: Arvind Yadav Reviewed-by: Christian K=C3=B6nig --- Changes in v1 : 1- Addressing Christian's comment to remove unnecessary callback. 2- Replacing CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS. 3- The version of this patch is also changed and previously it was [PATCH 4/4] Changes in v2 : 1- #ifdef CONFIG_DEBUG_WW_MUTEX_SLOWPATH removed --- drivers/dma-buf/st-dma-fence-chain.c | 4 ++++ drivers/dma-buf/st-dma-fence-unwrap.c | 22 ++++++++++++++++++++++ drivers/dma-buf/st-dma-fence.c | 16 ++++++++++++++++ drivers/dma-buf/st-dma-resv.c | 10 ++++++++++ 4 files changed, 52 insertions(+) diff --git a/drivers/dma-buf/st-dma-fence-chain.c b/drivers/dma-buf/st-dma-= fence-chain.c index 8ce1ea59d31b..0a9b099d0518 100644 --- a/drivers/dma-buf/st-dma-fence-chain.c +++ b/drivers/dma-buf/st-dma-fence-chain.c @@ -87,6 +87,8 @@ static int sanitycheck(void *arg) if (!chain) err =3D -ENOMEM; =20 + dma_fence_enable_sw_signaling(chain); + dma_fence_signal(f); dma_fence_put(f); =20 @@ -143,6 +145,8 @@ static int fence_chains_init(struct fence_chains *fc, u= nsigned int count, } =20 fc->tail =3D fc->chains[i]; + + dma_fence_enable_sw_signaling(fc->chains[i]); } =20 fc->chain_length =3D i; diff --git a/drivers/dma-buf/st-dma-fence-unwrap.c b/drivers/dma-buf/st-dma= -fence-unwrap.c index 4105d5ea8dde..f0cee984b6c7 100644 --- a/drivers/dma-buf/st-dma-fence-unwrap.c +++ b/drivers/dma-buf/st-dma-fence-unwrap.c @@ -102,6 +102,8 @@ static int sanitycheck(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + array =3D mock_array(1, f); if (!array) return -ENOMEM; @@ -124,12 +126,16 @@ static int unwrap_array(void *arg) if (!f1) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f1); + f2 =3D mock_fence(); if (!f2) { dma_fence_put(f1); return -ENOMEM; } =20 + dma_fence_enable_sw_signaling(f2); + array =3D mock_array(2, f1, f2); if (!array) return -ENOMEM; @@ -164,12 +170,16 @@ static int unwrap_chain(void *arg) if (!f1) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f1); + f2 =3D mock_fence(); if (!f2) { dma_fence_put(f1); return -ENOMEM; } =20 + dma_fence_enable_sw_signaling(f2); + chain =3D mock_chain(f1, f2); if (!chain) return -ENOMEM; @@ -204,12 +214,16 @@ static int unwrap_chain_array(void *arg) if (!f1) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f1); + f2 =3D mock_fence(); if (!f2) { dma_fence_put(f1); return -ENOMEM; } =20 + dma_fence_enable_sw_signaling(f2); + array =3D mock_array(2, f1, f2); if (!array) return -ENOMEM; @@ -248,12 +262,16 @@ static int unwrap_merge(void *arg) if (!f1) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f1); + f2 =3D mock_fence(); if (!f2) { err =3D -ENOMEM; goto error_put_f1; } =20 + dma_fence_enable_sw_signaling(f2); + f3 =3D dma_fence_unwrap_merge(f1, f2); if (!f3) { err =3D -ENOMEM; @@ -296,10 +314,14 @@ static int unwrap_merge_complex(void *arg) if (!f1) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f1); + f2 =3D mock_fence(); if (!f2) goto error_put_f1; =20 + dma_fence_enable_sw_signaling(f2); + f3 =3D dma_fence_unwrap_merge(f1, f2); if (!f3) goto error_put_f2; diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c index c8a12d7ad71a..fb6e0a6ae2c9 100644 --- a/drivers/dma-buf/st-dma-fence.c +++ b/drivers/dma-buf/st-dma-fence.c @@ -102,6 +102,8 @@ static int sanitycheck(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_fence_signal(f); dma_fence_put(f); =20 @@ -117,6 +119,8 @@ static int test_signaling(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + if (dma_fence_is_signaled(f)) { pr_err("Fence unexpectedly signaled on creation\n"); goto err_free; @@ -190,6 +194,8 @@ static int test_late_add_callback(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_fence_signal(f); =20 if (!dma_fence_add_callback(f, &cb.cb, simple_callback)) { @@ -282,6 +288,8 @@ static int test_status(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + if (dma_fence_get_status(f)) { pr_err("Fence unexpectedly has signaled status on creation\n"); goto err_free; @@ -308,6 +316,8 @@ static int test_error(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_fence_set_error(f, -EIO); =20 if (dma_fence_get_status(f)) { @@ -337,6 +347,8 @@ static int test_wait(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + if (dma_fence_wait_timeout(f, false, 0) !=3D -ETIME) { pr_err("Wait reported complete before being signaled\n"); goto err_free; @@ -379,6 +391,8 @@ static int test_wait_timeout(void *arg) if (!wt.f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(wt.f); + if (dma_fence_wait_timeout(wt.f, false, 1) !=3D -ETIME) { pr_err("Wait reported complete before being signaled\n"); goto err_free; @@ -458,6 +472,8 @@ static int thread_signal_callback(void *arg) break; } =20 + dma_fence_enable_sw_signaling(f1); + rcu_assign_pointer(t->fences[t->id], f1); smp_wmb(); =20 diff --git a/drivers/dma-buf/st-dma-resv.c b/drivers/dma-buf/st-dma-resv.c index 813779e3c9be..15dbea1462ed 100644 --- a/drivers/dma-buf/st-dma-resv.c +++ b/drivers/dma-buf/st-dma-resv.c @@ -45,6 +45,8 @@ static int sanitycheck(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_fence_signal(f); dma_fence_put(f); =20 @@ -69,6 +71,8 @@ static int test_signaling(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_resv_init(&resv); r =3D dma_resv_lock(&resv, NULL); if (r) { @@ -114,6 +118,8 @@ static int test_for_each(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_resv_init(&resv); r =3D dma_resv_lock(&resv, NULL); if (r) { @@ -173,6 +179,8 @@ static int test_for_each_unlocked(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_resv_init(&resv); r =3D dma_resv_lock(&resv, NULL); if (r) { @@ -244,6 +252,8 @@ static int test_get_fences(void *arg) if (!f) return -ENOMEM; =20 + dma_fence_enable_sw_signaling(f); + dma_resv_init(&resv); r =3D dma_resv_lock(&resv, NULL); if (r) { --=20 2.25.1 From nobody Fri Apr 3 06:45:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A686ECAAD3 for ; Wed, 14 Sep 2022 16:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbiINQp3 (ORCPT ); Wed, 14 Sep 2022 12:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbiINQpU (ORCPT ); Wed, 14 Sep 2022 12:45:20 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2045.outbound.protection.outlook.com [40.107.92.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59DBE7A511; Wed, 14 Sep 2022 09:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AcJCHpc1gRl15Hzee7Y5D31RL8L/jc8NuK+g0e6k+iSjj+CUWRpKk+57gtg7QLDKVK722Y33kGzvbyTZKZKFTaoLN+ruVdkC5f1nqjbpImCyQ+M3MeJOP09zLTIMIfz+exj/ABCfyTCSqmRdnEMCRvWRxkVp3KC7yaaoiC59I65vVl6xACEFzGMA+skUCBDjzVLrT6t2XnqQI/YUX7REBeFIXaLph/7ML8p27JEbgtij0t13cI1zYUcvfWVhqQOqnve/zyxzKrAaPJpusEpWDzXFv03gminxjlnG18lEXxygpOpyaEX5a54YlyDp6LdTNFkUwZF9Zkvt9rOwvHOsjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ZzSUSxOvuyCkf0z40GZtftSHrd6mN/ynXq1eT8AQD0=; b=T+dWf9pV2v+k+g4k4LozooqWsoSn9PCCijHeWfE3uzXS7F1bF3lr7FTYtcBP6NCvSCk1FeeBuikLLphH1AdNwMhoLAlrh6MGlewEaR7A/xU+r7jmL2bQ/JJH4qD00FUzEyfx+Y5slFk8qRZfqXl8KrBGaiJrcvskcTme35V+Bpt09RWmK9ae9Nruk4xhFoqBDfUYBwVDft3HPo9XP9s5vCUF8puiIAfgo/hfO33gLKPiYKo+fJ25c2IIqTGmQfCFEAhuYtX0D5C04APTXSX/8bdu/H78fD+mb3Z/YbYPxdC9Yb6zvg7pdwegO6ZaZShyHaZkPVN+U+vYgboDUr9+rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ZzSUSxOvuyCkf0z40GZtftSHrd6mN/ynXq1eT8AQD0=; b=0uvw0NKctlPDG8oqpmSRUobE7iB8rBLtSUtQYCHlTctNN6pg3DZ+m1mxFO7LfdserSo0oJYvr5JQ3Kx+SzetGnWMZFBGO7WPtNFgIUBo7VeRLEgNunrQMl4V0eE7lq+YytJthtWHUBXcIHZiHOpaGTkeAL8H/nV5H4nU0IOzmzE= Received: from BN9PR03CA0736.namprd03.prod.outlook.com (2603:10b6:408:110::21) by CY8PR12MB7657.namprd12.prod.outlook.com (2603:10b6:930:9d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 14 Sep 2022 16:45:10 +0000 Received: from BN8NAM11FT110.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::5a) by BN9PR03CA0736.outlook.office365.com (2603:10b6:408:110::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14 via Frontend Transport; Wed, 14 Sep 2022 16:45:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT110.mail.protection.outlook.com (10.13.176.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:45:09 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 11:45:05 -0500 From: Arvind Yadav To: , , , , , , , , , , , , CC: Arvind Yadav Subject: [PATCH v4 4/6] dma-buf: dma_fence_wait must enable signaling Date: Wed, 14 Sep 2022 22:13:19 +0530 Message-ID: <20220914164321.2156-5-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com> References: <20220914164321.2156-1-Arvind.Yadav@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT110:EE_|CY8PR12MB7657:EE_ X-MS-Office365-Filtering-Correlation-Id: d893f585-94e8-4633-6294-08da96707c87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Px3CnwKFXlejpA705iuXXqHEEdF7Kb9tMBIdNiMfQDw3iWla62y60C7n2rtDQme5jOM5Fsw4ko5oVYTmnKEJ+KA9EvzxvFGS13DdwtVe3rwIVVh7i1eKPfZ5uDYDJ5/yCI3roeiiXVmnf5WD5ywXX3+3ilzM2WKqlB6tiKR94VoKIq96cCUjuVcFJY1hOXJEwE/hcvuc93Mm0FP2MhNtQRxkZhrLFxga3qrKpKWqXUCcHFxopYr9X9mNL3SvYAUKV3WzUDWMZMS2MMPXAy5THOvE4snFJg2RNkGX3EpK1j+NAqhYXM+T8gcnVVrcK66t07vtm972twCsrnIzZvvIWc5HATgd0Fxyctniwwsz0rWYUCnCfivIlKr1Jg8iWijFETVAw5/nxhImE0WTaJ9eFHoicrzFM7dbJZByCajSw0D0C2SJnP4rCSjd6RytH61D276sRho1OYklyBagjeEZwFa18aocKUZ391mH/25fjsJmNP3JLWX+cD5UODGXYp43T8+QvlMsy/eH9VTP5ZRl3voyqe+SmfhdFfgfl58IygHV6YpRUxxBXAwB8oHsgZEyaHQY+1iGKt8TvCp3S0RDc5kJ7rxiqR6Jyj9E52eCv2G0RTC/ayRYFgIlwMWWKWLHEUtQHjAV0B1gAKwvkwafbjPYRypU5wccvp6iKW5dM99Qo0o3xhKHbxht63/zPL7oENz8oEV2O/CnILqVmnxTajGdto0j8cC3W9hoLtsFg5yrOAFZC4ebuQABQ6AJWLvlM062fVEMb5FU1w6bFIFMC1GtDcNxrYEr/4qmqwKBF2uSaRmGIDwMnpGF//HBZhV8barTQtmySep5vo/sHfRPRKu85KV0JOAFymPdNaUG+zrwom/Zz8UCMNQcM+jQE47p X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(40460700003)(6666004)(356005)(8936002)(16526019)(316002)(110136005)(47076005)(70586007)(478600001)(336012)(1076003)(36756003)(70206006)(36860700001)(86362001)(2906002)(41300700001)(2616005)(83380400001)(426003)(7696005)(4326008)(81166007)(4744005)(82740400003)(26005)(5660300002)(186003)(82310400005)(40480700001)(921005)(8676002)(2101003)(36900700001)(83996005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 16:45:09.5472 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d893f585-94e8-4633-6294-08da96707c87 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT110.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7657 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" dma_fence_wait() should always enable signaling even when the fence is already signaled. Signed-off-by: Arvind Yadav Reviewed-by: Christian K=C3=B6nig --- Changes in v1..v3: This new patch was not part of previous series. --- drivers/dma-buf/dma-fence.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 645c158b7e01..a5fbf1c1e0ea 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -508,6 +508,8 @@ dma_fence_wait_timeout(struct dma_fence *fence, bool in= tr, signed long timeout) =20 __dma_fence_might_wait(); =20 + dma_fence_enable_sw_signaling(fence); + trace_dma_fence_wait_start(fence); if (fence->ops->wait) ret =3D fence->ops->wait(fence, intr, timeout); @@ -771,9 +773,6 @@ dma_fence_default_wait(struct dma_fence *fence, bool in= tr, signed long timeout) goto out; } =20 - if (!__dma_fence_enable_signaling(fence)) - goto out; - if (!timeout) { ret =3D 0; goto out; --=20 2.25.1 From nobody Fri Apr 3 06:45:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D49C6FA82 for ; Wed, 14 Sep 2022 16:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230159AbiINQpg (ORCPT ); Wed, 14 Sep 2022 12:45:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiINQp1 (ORCPT ); Wed, 14 Sep 2022 12:45:27 -0400 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2081.outbound.protection.outlook.com [40.107.95.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAC187F129; Wed, 14 Sep 2022 09:45:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BDE7h54DYeb3N4+BK169l+TPRz+5gwQ8TX/f2x9gBakL9q3cwWWc3jbK4F7CY5Lifnu4fWtaKUNxi4kPK5MndwLdRSuG/OM0KuqE0NOBqRq1MqRERM0XhNRgLzb5Q0iV4b0R4ry3HnYByEK6H/gxvzB1B/i8X4jwSvkayhB4LRsfIH4wWuagRLbohm8BtnlMq6AYRAEYtVu4sPDDaiZiXPQJu3JvavfmaaYgI9wKFElyIV2w4Bmd+H6I5l9KNdYv7XVA6aCobxLT6mt9MbcTL3AU/T0TQVXVRtlF6ZfDH9fgbFC0TWGeKpdvu2P1/dBpuDbgqIl5OU/X21eQ7wyvTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QNZHcCXbB0y3I6Ipa8Icz0vIG/QLZZEeWB5qf6doeWY=; b=Igvhi4e0TCTeRWN8j3HsLCbzun1Uwq0y2soVHOxxhaJ/q5ivuREYo4m9vqlu8UdSmCGKR0q62ebc6pMcnSpnHDRyScax6IctjAu2d/2V2WWFYo/PGNHDFsLZo/3h8qmg2hDtaPsMw0LQwMLFW3VmQoNFbDo5Nhzm+0FxS45NcSkZZFFI9lUzGTbKYoiX5cr9vfgqVrQNQ4HSM5MDNO98dbGMxFTkbB6o4PsaBX1ZNE+V5JFMImqf6Jgiqe4AaMcw+oSV1ljgiSyFVfafzUGECLmOiN0v/3pGYtCKwvNGWEcXtxHY2ikiZAPbYmyvzdXOPrAeZKivd1MB4IrhVkGMGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNZHcCXbB0y3I6Ipa8Icz0vIG/QLZZEeWB5qf6doeWY=; b=BizFPFHll80W3rARLIjN3el1JsYUKF0h5CtTjmE2X/K+O/VHidNVnU40iYRlnoVu5h2auwvC0U3spT+SOZ7BvqwhXOX+O955hIvBZToCgCLCHCqK+UXjCrXmtRwY3x+hEr51g7yO9MPmN4Sm8rrUlCkCv25DWkJuz5wD+jre1DA= Received: from BN9P221CA0022.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::14) by CH2PR12MB4120.namprd12.prod.outlook.com (2603:10b6:610:7b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Wed, 14 Sep 2022 16:45:16 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::c8) by BN9P221CA0022.outlook.office365.com (2603:10b6:408:10a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:45:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:45:16 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 11:45:12 -0500 From: Arvind Yadav To: , , , , , , , , , , , , CC: Arvind Yadav Subject: [PATCH v4 5/6] drm/sched: Use parent fence instead of finished Date: Wed, 14 Sep 2022 22:13:20 +0530 Message-ID: <20220914164321.2156-6-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com> References: <20220914164321.2156-1-Arvind.Yadav@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT068:EE_|CH2PR12MB4120:EE_ X-MS-Office365-Filtering-Correlation-Id: 225b18ad-86b3-422d-9498-08da967080c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +4Nur2dsnFH0PeghFNHP+i59dFgYfaZf3mL9q6RmvGrosdKDx7JXTeyJdxdK2WmkniVv3L1qE8F6U6TjiVnI1jJPZGNPEaREFCsnX/mUG+CzFGIcDIXh8Qd15+UyxRkJE2tiEDnY2VjaLQsoVRJqkOgLgc9yEEaZj1kQIrnUCs53i5wUceqiVjNzKgxBPvowfPQHxrytIzPApCdDrb/2dhhtDwYZP0FIGMSB7q5YDl7bqn7ggukyIvjzwIRMT/t4UdgWoOY6pEtmWzP35qlGRUcNkJ6eB61g6R8VbeZTma68ZnsOnkyc8E1MlWM4H9U9YhMgIQg40cYnBzi7DQuQGKC8WbZzWiWLgsuUKLpIXzKyZbTaC0YWmRVyEOqZUa+u5TdFcElX375lnjDi+XVbgL6Nrm6OnL5NA/HqMQJCA8OIgQvvMuDJXef0npotd0UiuKH+XgB9s6G3q2TGPsj8e/ETy8MhcH/wYAlHqnpj1GNWiv8Ve48b7BlErsn63WETKrI5ZdS4IlpO8EqA6g1zud/INYKwBUPjMD/o2SbHc7g7IE04dOT3GbAJ+/IFXAXzd7ys+Cm4SqsOxrkJuTigp0GP4KYy66mzZzCWeUnBMGNey+qcDXgWUCIQpYh3gpTRVYGBVs7ptVY9M8CBAdf3TBPUn4fFV0VNW5x68MzFNp0yFH81S3YJB3Oc7vZcD8gwyjcTBe6BQq05W52+kODY7ftCh/z0660XtowJadBdDaAiWo0wYuY41sSPmbLWk9pjtBBqKiGiFGZaFiwaMxjEQO4gUrujAHBsIhbEbchfFXNL8qaURscqyAm/iTkk6dBfOflR/5jPYNI9CKgrPLDyejJVr4+CgO6OgrLxOe9vkpFYEfs7+KVhap/KknIEDvkD X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199015)(36840700001)(40470700004)(46966006)(40460700003)(478600001)(4326008)(2906002)(110136005)(8936002)(426003)(70206006)(186003)(6666004)(2616005)(7696005)(336012)(40480700001)(36756003)(26005)(1076003)(82740400003)(47076005)(921005)(83380400001)(8676002)(81166007)(36860700001)(16526019)(356005)(5660300002)(86362001)(316002)(82310400005)(41300700001)(70586007)(83996005)(2101003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 16:45:16.6501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 225b18ad-86b3-422d-9498-08da967080c5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4120 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Using the parent fence instead of the finished fence to get the job status. This change is to avoid GPU scheduler timeout error which can cause GPU reset. Signed-off-by: Arvind Yadav Reviewed-by: Andrey Grodzovsky --- changes in v1,v2 - Enable signaling for finished fence in sche_main() is removed --- drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sched= uler/sched_main.c index e0ab14e0fb6b..2ac28ad11432 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -829,7 +829,7 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sch= ed) job =3D list_first_entry_or_null(&sched->pending_list, struct drm_sched_job, list); =20 - if (job && dma_fence_is_signaled(&job->s_fence->finished)) { + if (job && dma_fence_is_signaled(job->s_fence->parent)) { /* remove job from pending_list */ list_del_init(&job->list); =20 @@ -841,7 +841,7 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sch= ed) =20 if (next) { next->s_fence->scheduled.timestamp =3D - job->s_fence->finished.timestamp; + job->s_fence->parent->timestamp; /* start TO timer for next job */ drm_sched_start_timeout(sched); } --=20 2.25.1 From nobody Fri Apr 3 06:45:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A1FECAAD3 for ; Wed, 14 Sep 2022 16:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229659AbiINQp7 (ORCPT ); Wed, 14 Sep 2022 12:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbiINQp3 (ORCPT ); Wed, 14 Sep 2022 12:45:29 -0400 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2043.outbound.protection.outlook.com [40.107.95.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA3FF80B78; Wed, 14 Sep 2022 09:45:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c2pBOfYEE0K6PXJ6wVX3ER8qVuitEz/loWAAHyXaNOLRtn7YU/ZxU/rTWXkdVmdtrXKNuIqFsVl7oUnFtTdoERosBszVWlXIFdBt4JJiNpGwicrA6eZPVg/noSqwBRN+Cw3tupU9S8nz6f1kxMuF28JC1TGgoGwEjymwj4BYYceNPz9tVTA3IjyiYVNmwxgUs9c6t/qrBZtJJ4QaCsjZ3Mh10psYlsa8Oryn/Ls2K4QYIrN+OkQv8ASzQ9gZX+9ZC4xAvl4WDwLITJKNZ4r2zVkj6GrJ5+U/BkO0sNYgHp6FYjHKaGp9YcwkjYrxev2wUJjMROH7Dknm2DSlK0SBWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dw9IR5MMDiZdAPbhcsufZeUb0iTvdlY6ZZ/KqPzOlIs=; b=lDQ0K8yuVgbfoz5aS/PWxrlFYsKBiS1Q4noftYn0USajq2dhl5q/wN2Yc9ZBz1nn1pQO/upTTtXbwwBO4JtlTYIgweihBz4AQqB8GSrTQzArDFfjQ1xAnIuZYA/gQUpRcTUGva7dSXJjlElenBPpjoBDZGW3vYCuocnzt8txCfj2civSwPh8MjxBGFlkLhYiDSvi3HMoQZYaM156aOdR45OKwOAnAlpZlknZqQjUf0QPk/RIBqgxvcrC1MzBXo4EFFkLSO3ubhFgBzH4v4gK7qwobv1VzL6NI3LqqPVI7ynjHXvy9+0ckvfgqeicV1i/UPygU/3kOT3KLHBquk4lUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dw9IR5MMDiZdAPbhcsufZeUb0iTvdlY6ZZ/KqPzOlIs=; b=PF8vn4ZMQopZKbG2fVNW1A9BFKkSoccK2ZiFEYqj9A95Ve6ogOB4zZM0ZMO1h+8RN9lBSIoTA/MepU1uLOUUG9Itj2O9WIk/QyttShdw9Iml6hnZs6n5akhSRMDHKX9/KdFMa01UUdDmEjF+QNMwF4wF50LMdAxg/owDf1pKGns= Received: from BN9PR03CA0158.namprd03.prod.outlook.com (2603:10b6:408:f4::13) by SA1PR12MB7341.namprd12.prod.outlook.com (2603:10b6:806:2ba::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 14 Sep 2022 16:45:24 +0000 Received: from BN8NAM11FT072.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f4:cafe::8e) by BN9PR03CA0158.outlook.office365.com (2603:10b6:408:f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:45:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT072.mail.protection.outlook.com (10.13.176.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 16:45:24 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 14 Sep 2022 11:45:19 -0500 From: Arvind Yadav To: , , , , , , , , , , , , CC: Arvind Yadav Subject: [PATCH v4 6/6] dma-buf: Check status of enable-signaling bit on debug Date: Wed, 14 Sep 2022 22:13:21 +0530 Message-ID: <20220914164321.2156-7-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com> References: <20220914164321.2156-1-Arvind.Yadav@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT072:EE_|SA1PR12MB7341:EE_ X-MS-Office365-Filtering-Correlation-Id: 77829df5-388c-4f70-88aa-08da96708531 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hhmhOhzONlaYYao0J3YtV8GewMIF9Mdhq8XX6Cb6bHlgsbYYQP1aA8qtmSICiL8zhwfyEayx6rKZyeq71aNi5GgWzY2T6aJfFGPcBkHADs/C/XJOqJPd4cBMp54wDeHF18LjA0kLfmeit4ACpKADWQ1joEXKH/a/t5GdZHTGbViI9V95pBY9T81AngKQmNv5hLzopYHKj4JOA8ZoeeDHs8X5ijJbFE6J7qfjX7eIwqDK5wG/tkBc9cmXoNn88J+/bkhnf6ot/KOJDqylhvfa4CHc2tW3zfLkPvYV7rLiGROZuue1s7oKHJWCHwyFZYD4DDivB7mwxz8ba7lxrlo5Upa/D7CVC6bGHoVbDMUoiXAKY3IHj4h+PdtDaOFhlEkXV9pKejUCDrO0hFoW7+YcXr4ARc6ttf9dEkjhF4LMdteFUbu1qJAw3ZCEGQRaGQqTnhnDngqxPBty03q4ITAa+jj0yaoElWVQV+0Iv3XUxoiPqZTtwRmqmJ9In7jR9VskqEHNp74+kGIijgyjk3QQ25r/5qio8nyiGDDYcDcrfiBs1immy8od3dlKYtE/8va8tEpjkhcGJ3rMiXndUuC/vXVmxF8gmysAztHGercNtDajswwDfz++5tHgqudhw952OadujVZmYQnSvLoP+gTFBb6c6tdpfnRIs2/hcgvlAGEq2rYYvcunp9rcb0nDaJKmf3iu3WJMUM+S+K7dtxfwE6SZf259y5WwGFJRjigaOwmiNU4VcgdOq7iNFk5cvNfphzfQkAfD0bTGGkXNZb4zPhUjfp1XqDlv5fiEPwfmGdtNigKVzdeOE5xsP+LpFrgT6x0nw4X7y12diujEfKqnMGYxQlzgbMnETR5ZyHsiD2g= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(41300700001)(82310400005)(356005)(70206006)(86362001)(8676002)(81166007)(4326008)(7696005)(6666004)(47076005)(40460700003)(316002)(40480700001)(186003)(70586007)(426003)(110136005)(2906002)(16526019)(336012)(5660300002)(36860700001)(26005)(921005)(1076003)(82740400003)(8936002)(83380400001)(478600001)(2616005)(36756003)(2101003)(36900700001)(83996005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 16:45:24.0841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77829df5-388c-4f70-88aa-08da96708531 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT072.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7341 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fence signaling must be enabled to make sure that the dma_fence_is_signaled() function ever returns true. Since drivers and implementations sometimes mess this up, this ensures=C2=A0correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING is used during debugging. This should make any implementation bugs resulting in not signaled fences much more obvious. Signed-off-by: Arvind Yadav Reviewed-by: Christian K=C3=B6nig --- Changes in v1,v2 : 1- Addressing Christian's comment to replace CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS. 2- As per Christian's comment moving this patch at last so The version of this patch is also changed and previously it was [PATCH 1/4] Changes in v3:=20 1 - Adding new config DMABUF_DEBUG_ENABLE_SIGNALING. 2 - Replace CONFIG_DEBUG_WW_MUTEX_SLOWPATH to new CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING. --- drivers/dma-buf/Kconfig | 7 +++++++ include/linux/dma-fence.h | 5 +++++ 2 files changed, 12 insertions(+) diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig index e4dc53a36428..c991e6a51510 100644 --- a/drivers/dma-buf/Kconfig +++ b/drivers/dma-buf/Kconfig @@ -65,6 +65,13 @@ config DMABUF_SELFTESTS default n depends on DMA_SHARED_BUFFER =20 +config DMABUF_DEBUG_ENABLE_SIGNALING + bool "DMA Fence enable signaling debug checks" + default n + depends on DMA_SHARED_BUFFER + help + This option enables additional checks for software signaling of fence. + menuconfig DMABUF_HEAPS bool "DMA-BUF Userland Memory Heaps" select DMA_SHARED_BUFFER diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index 775cdc0b4f24..01e1fa4d3cec 100644 --- a/include/linux/dma-fence.h +++ b/include/linux/dma-fence.h @@ -428,6 +428,11 @@ dma_fence_is_signaled_locked(struct dma_fence *fence) static inline bool dma_fence_is_signaled(struct dma_fence *fence) { +#ifdef CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING + if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags)) + return false; +#endif + if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) return true; =20 --=20 2.25.1