From nobody Sun Apr 5 22:52:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F100AC54EE9 for ; Tue, 13 Sep 2022 17:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232443AbiIMRLi (ORCPT ); Tue, 13 Sep 2022 13:11:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232383AbiIMRLU (ORCPT ); Tue, 13 Sep 2022 13:11:20 -0400 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 232C5870BA for ; Tue, 13 Sep 2022 09:00:02 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R631e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VPhRr.u_1663082568; Received: from localhost.localdomain(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VPhRr.u_1663082568) by smtp.aliyun-inc.com; Tue, 13 Sep 2022 23:22:49 +0800 From: Xin Hao To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xhao@linux.alibaba.com Subject: [PATCH] mm/damon: simplify scheme create in lru_sort.c Date: Tue, 13 Sep 2022 23:22:45 +0800 Message-Id: <20220913152245.25224-1-xhao@linux.alibaba.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In damon_lru_sort_new_hot_scheme() and damon_lru_sort_new_cold_scheme(), they have so much in common, so we can combine them into a single function, and we just need to distinguish their differences. Signed-off-by: Xin Hao --- mm/damon/lru_sort.c | 82 +++++++++++++++++---------------------------- 1 file changed, 30 insertions(+), 52 deletions(-) diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c index 8415e18fcf0e..62063ed43224 100644 --- a/mm/damon/lru_sort.c +++ b/mm/damon/lru_sort.c @@ -257,15 +257,15 @@ module_param(nr_cold_quota_exceeds, ulong, 0400); static struct damon_ctx *ctx; static struct damon_target *target; -/* Create a DAMON-based operation scheme for hot memory regions */ -static struct damos *damon_lru_sort_new_hot_scheme(unsigned int hot_thres) +static inline struct damos *damon_lru_sort_new_scheme(unsigned int thres, + enum damos_action action) { struct damos_access_pattern pattern =3D { /* Find regions having PAGE_SIZE or larger size */ .min_sz_region =3D PAGE_SIZE, .max_sz_region =3D ULONG_MAX, /* and accessed for more than the threshold */ - .min_nr_accesses =3D hot_thres, + .min_nr_accesses =3D 0, .max_nr_accesses =3D UINT_MAX, /* no matter its age */ .min_age_region =3D 0, @@ -292,60 +292,38 @@ static struct damos *damon_lru_sort_new_hot_scheme(un= signed int hot_thres) .weight_age =3D 0, }; - return damon_new_scheme( - &pattern, - /* prioritize those on LRU lists, as soon as found */ - DAMOS_LRU_PRIO, - /* under the quota. */ - "a, - /* (De)activate this according to the watermarks. */ - &wmarks); + switch (action) { + case DAMOS_LRU_PRIO: + pattern.min_nr_accesses =3D thres; + break; + case DAMOS_LRU_DEPRIO: + pattern.min_age_region =3D thres; + quota.weight_nr_accesses =3D 0; + quota.weight_age =3D 1; + break; + default: + return NULL; + } + + return damon_new_scheme(&pattern, + /* mark those as not accessed, as soon as found */ + action, + /* under the quota. */ + "a, + /* (De)activate this according to the watermarks. */ + &wmarks); +} + +/* Create a DAMON-based operation scheme for hot memory regions */ +static struct damos *damon_lru_sort_new_hot_scheme(unsigned int hot_thres) +{ + return damon_lru_sort_new_scheme(hot_thres, DAMOS_LRU_PRIO); } /* Create a DAMON-based operation scheme for cold memory regions */ static struct damos *damon_lru_sort_new_cold_scheme(unsigned int cold_thre= s) { - struct damos_access_pattern pattern =3D { - /* Find regions having PAGE_SIZE or larger size */ - .min_sz_region =3D PAGE_SIZE, - .max_sz_region =3D ULONG_MAX, - /* and not accessed at all */ - .min_nr_accesses =3D 0, - .max_nr_accesses =3D 0, - /* for min_age or more micro-seconds */ - .min_age_region =3D cold_thres, - .max_age_region =3D UINT_MAX, - }; - struct damos_watermarks wmarks =3D { - .metric =3D DAMOS_WMARK_FREE_MEM_RATE, - .interval =3D wmarks_interval, - .high =3D wmarks_high, - .mid =3D wmarks_mid, - .low =3D wmarks_low, - }; - struct damos_quota quota =3D { - /* - * Do not try LRU-lists sorting of cold pages for more than - * half of quota_ms milliseconds within - * quota_reset_interval_ms. - */ - .ms =3D quota_ms / 2, - .sz =3D 0, - .reset_interval =3D quota_reset_interval_ms, - /* Within the quota, mark colder regions not accessed first. */ - .weight_sz =3D 0, - .weight_nr_accesses =3D 0, - .weight_age =3D 1, - }; - - return damon_new_scheme( - &pattern, - /* mark those as not accessed, as soon as found */ - DAMOS_LRU_DEPRIO, - /* under the quota. */ - "a, - /* (De)activate this according to the watermarks. */ - &wmarks); + return damon_lru_sort_new_scheme(cold_thres, DAMOS_LRU_DEPRIO); } static int damon_lru_sort_apply_parameters(void) -- 2.31.0