From nobody Fri Dec 19 07:47:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A6B6C6FA89 for ; Tue, 13 Sep 2022 14:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232781AbiIMOKx (ORCPT ); Tue, 13 Sep 2022 10:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232674AbiIMOJe (ORCPT ); Tue, 13 Sep 2022 10:09:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E0C357E33; Tue, 13 Sep 2022 07:09:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD25C6149A; Tue, 13 Sep 2022 14:09:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1BEFC433C1; Tue, 13 Sep 2022 14:09:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663078143; bh=150roaC0CNIdd5b+cfmwKH6lTavcFXqnMha7Lc8lO5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QNV6y5rkjCyM1Bs5r0PBBZ2pNnZaBbGngwF/R02m/B1Uu8qNkYkPI5H3bQMN66xIw J56KnWJUFEdZCcYpdcqmGJg40V6bbbCepWm+Esxg2IqTnhrYG2FDfZ9X0klWJkj6E2 16fIOxC3bxnptS1KwkoafPfkOn9+o0ojIwTlGfUY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yu Zhe , Helge Deller , Sasha Levin Subject: [PATCH 5.19 029/192] fbdev: omapfb: Fix tests for platform_get_irq() failure Date: Tue, 13 Sep 2022 16:02:15 +0200 Message-Id: <20220913140411.367155335@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140410.043243217@linuxfoundation.org> References: <20220913140410.043243217@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Yu Zhe [ Upstream commit acf4c6205e862304681234a6a4375b478af12552 ] The platform_get_irq() returns negative error codes. It can't actually return zero. Signed-off-by: Yu Zhe Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/omap/omapfb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/o= map/omapfb_main.c index 292fcb0a24fc9..6ff237cee7f87 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -1643,14 +1643,14 @@ static int omapfb_do_probe(struct platform_device *= pdev, goto cleanup; } fbdev->int_irq =3D platform_get_irq(pdev, 0); - if (!fbdev->int_irq) { + if (fbdev->int_irq < 0) { dev_err(&pdev->dev, "unable to get irq\n"); r =3D ENXIO; goto cleanup; } =20 fbdev->ext_irq =3D platform_get_irq(pdev, 1); - if (!fbdev->ext_irq) { + if (fbdev->ext_irq < 0) { dev_err(&pdev->dev, "unable to get irq\n"); r =3D ENXIO; goto cleanup; --=20 2.35.1