From nobody Sun Sep 14 22:53:34 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0180DC6FA82 for ; Tue, 13 Sep 2022 14:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234030AbiIMObm (ORCPT ); Tue, 13 Sep 2022 10:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234110AbiIMO3P (ORCPT ); Tue, 13 Sep 2022 10:29:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1376269F7B; Tue, 13 Sep 2022 07:18:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD331614D3; Tue, 13 Sep 2022 14:18:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D29BFC433B5; Tue, 13 Sep 2022 14:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663078710; bh=jdQJzVCzjLUTb3ZpmMeyFG8CG9PEmt2WyOOQ37iFBTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y2hrCpHHV5L/kOt67Up9LO12mClC8D5pPLkBxcfbrCOHt5S/2vcVIp9bTa45iUXoH l/dZSQjUWeDkG+BEnpH1ulXjuK8GLxElRHTy5FiIRCKuIAg1qf6SnJK6Cuv5WrjtEA wDP70Tl1Y62XvlNgWDb7tCxIrZa6Dn4sqZn6J3kg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Vasut , Fabio Estevam , Lucas Stach , Shawn Guo , Sasha Levin Subject: [PATCH 5.15 053/121] soc: imx: gpcv2: Assert reset before ungating clock Date: Tue, 13 Sep 2022 16:04:04 +0200 Message-Id: <20220913140359.635650807@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140357.323297659@linuxfoundation.org> References: <20220913140357.323297659@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Marek Vasut [ Upstream commit df88005bd81b80c944d185554e264a4b0f993c37 ] In case the power domain clock are ungated before the reset is asserted, the system might freeze completely. This is likely due to a device is an undefined state being attached to bus, which sporadically leads to a bus hang. Assert the reset before the clock are enabled to assure the device is in defined state before being attached to bus. Fixes: fe58c887fb8ca ("soc: imx: gpcv2: add support for optional resets") Signed-off-by: Marek Vasut Reviewed-by: Fabio Estevam Reviewed-by: Lucas Stach Signed-off-by: Shawn Guo Signed-off-by: Sasha Levin --- drivers/soc/imx/gpcv2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index b4aa28420f2a8..4dc3a3f73511e 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -237,6 +237,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *g= enpd) } } =20 + reset_control_assert(domain->reset); + /* Enable reset clocks for all devices in the domain */ ret =3D clk_bulk_prepare_enable(domain->num_clks, domain->clks); if (ret) { @@ -244,7 +246,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *g= enpd) goto out_regulator_disable; } =20 - reset_control_assert(domain->reset); + /* delays for reset to propagate */ + udelay(5); =20 if (domain->bits.pxx) { /* request the domain to power up */ --=20 2.35.1