From nobody Mon Apr 6 04:45:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C837C6FA82 for ; Mon, 12 Sep 2022 18:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbiILS2w (ORCPT ); Mon, 12 Sep 2022 14:28:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbiILS2D (ORCPT ); Mon, 12 Sep 2022 14:28:03 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F0A24457D; Mon, 12 Sep 2022 11:26:03 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id x1so9385669plv.5; Mon, 12 Sep 2022 11:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=vLd5VxDvs/Hufc5GkPRPWmylC7gs4hvMBc2dqzKoD6A=; b=WNJCwZID7CkpmvEX4T+7USbTmGXoHffHzo+rEl63koqVWcf7eY6LSJiv6m4DzXWKju Q3VVtg18aweL3nEBz278LZM+K1LQ0FZEFIDzjLvQKFb7FguYNR1WqVRGMFm6PTskTT9X cEjNqo5gk/BCu4LgGzkBaBxJzZWQTOfSyfBANKkpxFGesnbd50kz8TnxVCK4uS9iX0Ek tBosUTXNGu8omozjBO0YgXnWIyOBIWToBExHSD2T0R/ap4VScRAArQh3ERiIiH2Hp0pj JcxSsb6b0w+coJV60XwT9oKrxLVB5YeMg+hJr0EV1w0uFJzfQneIGM4uv/EUr07UOjux aRFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=vLd5VxDvs/Hufc5GkPRPWmylC7gs4hvMBc2dqzKoD6A=; b=oyxymysEh2h6OPjxSLHn6lOpy12W5R1zPkdz2lY/nbwKg6aYDGmHLzo48JZ1qAMJIo z9+Hpow1omAEZrKTtvwvGwwC90QFMAQZmdLAspSDwBqKw9a6sEZXrxFv7rPiyjt+cQfb Geq7CkbrREbCCBscKbgMNtjg+n7TdbXMixvlRk8pnV4QqfOq+akdNGxOZdTxOeOIxCsO IYI/ud43UgcEu27teSH0sBfnWNT+9WLSi6um+A05gwHc+lsfwkDOxV+PgNkmWHPTuwwu 62pOxy+VtT8AtMOrxX3hvvfKGhHQl36+P+2RChMC/jnFoQWliLMjasQECn2B797UDbnp mPoA== X-Gm-Message-State: ACgBeo0Y9i4rQ0HFYPHsK3E9XdUfp/VliKhYrdZQ4YtbGQOVD/3R1zDo 7Ap4w1DTPOkrqq3Ctx6+/IG5sCt7N3D4rw== X-Google-Smtp-Source: AA6agR7iDlj9L6+RcerHeiF3O8KlHHxg60Q8EuLWPkI0PI6FFqq4ogQKOParnfoCjUzfF4ngvFwvrg== X-Received: by 2002:a17:90a:31c5:b0:200:a749:4857 with SMTP id j5-20020a17090a31c500b00200a7494857mr26059975pjf.148.1663007147823; Mon, 12 Sep 2022 11:25:47 -0700 (PDT) Received: from vmfolio.. (c-73-189-111-8.hsd1.ca.comcast.net. [73.189.111.8]) by smtp.googlemail.com with ESMTPSA id x127-20020a626385000000b0053b2681b0e0sm5916894pfb.39.2022.09.12.11.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 11:25:47 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, "Vishal Moola (Oracle)" Subject: [PATCH v2 16/23] f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() Date: Mon, 12 Sep 2022 11:22:17 -0700 Message-Id: <20220912182224.514561-17-vishal.moola@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220912182224.514561-1-vishal.moola@gmail.com> References: <20220912182224.514561-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Convert function to use folios. This is in preparation for the removal of find_get_pages_range_tag(). Initially the function was checking if the previous page index is truly the previous page i.e. 1 index behind the current page. To convert to folios and maintain this check we need to make the check folio->index !=3D prev + folio_nr_pages(previous folio) since we don't know how many pages are in a folio. At index i =3D=3D 0 the check is guaranteed to succeed, so to workaround in= dexing bounds we can simply ignore the check for that specific index. This makes t= he initial assignment of prev trivial, so I removed that as well. Also modified a comment in commit_checkpoint for consistency. Signed-off-by: Vishal Moola (Oracle) --- fs/f2fs/checkpoint.c | 49 +++++++++++++++++++++++--------------------- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 8259e0fa97e1..9f6694f7d723 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -377,59 +377,62 @@ long f2fs_sync_meta_pages(struct f2fs_sb_info *sbi, e= num page_type type, { struct address_space *mapping =3D META_MAPPING(sbi); pgoff_t index =3D 0, prev =3D ULONG_MAX; - struct pagevec pvec; + struct folio_batch fbatch; long nwritten =3D 0; - int nr_pages; + int nr_folios; struct writeback_control wbc =3D { .for_reclaim =3D 0, }; struct blk_plug plug; =20 - pagevec_init(&pvec); + folio_batch_init(&fbatch); =20 blk_start_plug(&plug); =20 - while ((nr_pages =3D pagevec_lookup_tag(&pvec, mapping, &index, - PAGECACHE_TAG_DIRTY))) { + while ((nr_folios =3D filemap_get_folios_tag(mapping, &index, + (pgoff_t)-1, + PAGECACHE_TAG_DIRTY, &fbatch))) { int i; =20 - for (i =3D 0; i < nr_pages; i++) { - struct page *page =3D pvec.pages[i]; + for (i =3D 0; i < nr_folios; i++) { + struct folio *folio =3D fbatch.folios[i]; =20 - if (prev =3D=3D ULONG_MAX) - prev =3D page->index - 1; - if (nr_to_write !=3D LONG_MAX && page->index !=3D prev + 1) { - pagevec_release(&pvec); + if (nr_to_write !=3D LONG_MAX && i !=3D 0 && + folio->index !=3D prev + + folio_nr_pages(fbatch.folios[i-1])) { + folio_batch_release(&fbatch); goto stop; } =20 - lock_page(page); + folio_lock(folio); =20 - if (unlikely(page->mapping !=3D mapping)) { + if (unlikely(folio->mapping !=3D mapping)) { continue_unlock: - unlock_page(page); + folio_unlock(folio); continue; } - if (!PageDirty(page)) { + if (!folio_test_dirty(folio)) { /* someone wrote it for us */ goto continue_unlock; } =20 - f2fs_wait_on_page_writeback(page, META, true, true); + f2fs_wait_on_page_writeback(&folio->page, META, + true, true); =20 - if (!clear_page_dirty_for_io(page)) + if (!folio_clear_dirty_for_io(folio)) goto continue_unlock; =20 - if (__f2fs_write_meta_page(page, &wbc, io_type)) { - unlock_page(page); + if (__f2fs_write_meta_page(&folio->page, &wbc, + io_type)) { + folio_unlock(folio); break; } - nwritten++; - prev =3D page->index; + nwritten +=3D folio_nr_pages(folio); + prev =3D folio->index; if (unlikely(nwritten >=3D nr_to_write)) break; } - pagevec_release(&pvec); + folio_batch_release(&fbatch); cond_resched(); } stop: @@ -1381,7 +1384,7 @@ static void commit_checkpoint(struct f2fs_sb_info *sb= i, }; =20 /* - * pagevec_lookup_tag and lock_page again will take + * filemap_get_folios_tag and lock_page again will take * some extra time. Therefore, f2fs_update_meta_pages and * f2fs_sync_meta_pages are combined in this function. */ --=20 2.36.1