From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B45AECAAD5 for ; Mon, 12 Sep 2022 06:18:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbiILGSA (ORCPT ); Mon, 12 Sep 2022 02:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiILGR5 (ORCPT ); Mon, 12 Sep 2022 02:17:57 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3C826540 for ; Sun, 11 Sep 2022 23:17:55 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id bn9so9324520ljb.6 for ; Sun, 11 Sep 2022 23:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=FI26vxDVvyB2ohU/Q2Xw8ikZ3CFzmn6rrr4FY2O/Oys=; b=M0/8cQ6sJ4K05sra8GufO8vQBqNlJPjWcLf14zPEPSFzixoHFP7lUzgkk1ARR51TeD zVL0FCRQL/lxz2tJC+yLAB0KHo7W6oI8AtKn8ui2NOoI+GT//J9OvBGzheOh7vZyDG/G PZuDZGh99myHf4APLISsDxePYWxV87UaEXASXFhDhyb4U0VAdhbFtp5ttGi/OL5PrTlw Ln+W2VBT1q/6QGJuCNIyWeemzQU9yShfSEt4KFJ99U8HeSwEZp23CPRta6kSl0KmwKhh T18kT+5/mn6MJ2ZZJc5CM18b7l0OXzPXwPaXo3+Bf8SDgUdqWpxZ38spoTu45GVB8tSu r7WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=FI26vxDVvyB2ohU/Q2Xw8ikZ3CFzmn6rrr4FY2O/Oys=; b=0A4nYsHC4vwpX9sLLo03Rgibg+u650eWheFu7FuBkHg+sYZPHNRDoSKUmh+MFJb0x+ cGiLvapn+897GxiYXwrKfSEcFNl5JiIepAjaNouQtVoJJD6EMCwVG42+3LPVzwWhJs9a S9ToQhmxk2PLZwipxcjotVBESbPXeDnnTJd4rK1lYchMTQE7BHTJ5VsVuZG2bhbearv3 8YF0TgSZX+UYda8eOgctvFEI/a1mGcG6Nkqh5z2/govBudWcwjcd+6DCnWTwArO4Awsv JKGHVI9rXCgi0dzSvqxdw6Vr/IcEIVUDag796s33Fiv6ft1e5gp3PBgLLMFZM915ZHrJ twXg== X-Gm-Message-State: ACgBeo0gWmXD561AT1jID6xakYvVQCYNt0wyU4PaL0uSUI/tIDzV+reD GwKXYmDLCe6h+/M28Q6Vnd2xeA== X-Google-Smtp-Source: AA6agR44iRqUM/EedU02ObBZe5dzrKszQKQeOKL35am5SOOWpwqC6LYWeNVNuIx/lpXvoVe9ByPhqw== X-Received: by 2002:a05:651c:88b:b0:261:ba8e:717a with SMTP id d11-20020a05651c088b00b00261ba8e717amr7167538ljq.401.1662963473811; Sun, 11 Sep 2022 23:17:53 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:53 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 01/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:07 +0200 Message-Id: <20220912061746.6311-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iskren Chernev Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index d8443811767d..8a2b4767c7b6 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -59,8 +59,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6115-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6115-tlmm-state" + additionalProperties: false =20 '$defs': qcom-sm6115-tlmm-state: @@ -155,25 +156,25 @@ examples: gpio-ranges =3D <&tlmm 0 0 114>; =20 sdc2_on_state: sdc2-on-state { - clk { + clk-pins { pins =3D "sdc2_clk"; bias-disable; drive-strength =3D <16>; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; bias-pull-up; drive-strength =3D <10>; }; =20 - data { + data-pins { pins =3D "sdc2_data"; bias-pull-up; drive-strength =3D <10>; }; =20 - sd-cd { + sd-cd-pins { pins =3D "gpio88"; function =3D "gpio"; bias-pull-up; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A994AECAAA1 for ; Mon, 12 Sep 2022 06:18:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbiILGSH (ORCPT ); Mon, 12 Sep 2022 02:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiILGSC (ORCPT ); Mon, 12 Sep 2022 02:18:02 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F0AD2655D for ; Sun, 11 Sep 2022 23:17:58 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id v6so9372662ljj.0 for ; Sun, 11 Sep 2022 23:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=vyYamw1Du4HV9eH+g+rE4fAB7iezBD0VnqsswMEZh9Q=; b=OMp8EudE35YyzNGuCOAeWC5WjdioYM252RuRUFtRRdYynw6J1BBqWiYPEsWt0+FPUj M49nt1W2kDIRmNE30QLul3sMweSnC1Pryl8QRXnMDx9CRYVEbdO25JbtbhMt6n75bpPv TKpKrO/2m5eBEn3fYF+TyMEBXCSLYpkfCrYFGWld0R7oXpWV4qbShAC5FNrpKZYlmOcQ u+MzhKiSMFMXj4xGLmhO4xXND1soJIx01JMcBXMOrgk+PQ1ANQUN8tVb9p87/Tel+WME XEjDA5DSuc2WH0NIcOFpMGOjXmO+5H0CiMCgcDxQrWAO1tvg2/n0zuwPfk1xytg2M2Zk MEDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=vyYamw1Du4HV9eH+g+rE4fAB7iezBD0VnqsswMEZh9Q=; b=COnzcFcAa5A6zhlebQRcGO1e7KMw4HRxyZuevCk2tTvqYa0PfpAY+CCgLyMgQj59J3 4uccvocCbGXEXs10Znr1ztgNGVaXJ3qszrwRyOdvHPTXYLGvovykP2yNMQgzdmEwi/Ib Epq75upqW74yiaRlUXutcCsZ+JQxBZ/4NW0t4OJ2l3WWhNkkRs4VC56Dpj2+fwZz8fGR fzxrN/scTzNs5cLZVkTjUI/t6bhfTPIfVxih9FdbmkVNzbcBRKDWh7c2IGpOeVTskwDD x4eyN0uYMsE2I9Trqlb4t3SuDL3y173Wp0iUXMkwaW/Ca6hUHhqwUDc9XqMFvq20a2/R FVSg== X-Gm-Message-State: ACgBeo3hljVYJRNpDvHIcrE3PbGtvoCXqZQSmRSgRz3yt1REav6RAo9P /yr9YlbsBNHoABtEhNWQFYqNNUsd8o831A== X-Google-Smtp-Source: AA6agR6zRnH0MEqYlMZz4QKOqoGTt9It9V5BpYycR4WeATh2oNCyf5EySkBoW8N2AOkwOV8LKEpDcQ== X-Received: by 2002:a05:651c:2205:b0:25f:dda5:1e65 with SMTP id y5-20020a05651c220500b0025fdda51e65mr7827812ljq.240.1662963477269; Sun, 11 Sep 2022 23:17:57 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:56 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 02/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: require function on GPIOs Date: Mon, 12 Sep 2022 08:17:08 +0200 Message-Id: <20220912061746.6311-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Require function on GPIOs (so not on SD card pins). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iskren Chernev Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index 8a2b4767c7b6..28b29bf714b4 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -69,7 +69,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -121,6 +120,16 @@ patternProperties: required: - pins =20 + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" + then: + required: + - function + additionalProperties: false =20 allOf: --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D400AECAAA1 for ; Mon, 12 Sep 2022 06:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229505AbiILGSL (ORCPT ); Mon, 12 Sep 2022 02:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiILGSD (ORCPT ); Mon, 12 Sep 2022 02:18:03 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43E4527B05 for ; Sun, 11 Sep 2022 23:18:00 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id x10so9325034ljq.4 for ; Sun, 11 Sep 2022 23:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=9Ga8X9++qfiAWh6BldRFQQXZ+w/+Bj3hqeXHqr2J+Og=; b=MkBeGITuxFq8B3+KVWBocBoRpwWOeyxi8nZNPC8gDPapMrUfABNQNHYoT6po/jKQ5+ e1VTrtMkTuqcE905n9OiwleCv6rFy/3aaV0PFkzgCEQ8+37T8AskyCus6SVBPGArFshL qUPVYA6/44Rkfh+VVsK3cGvG+wTnn0QvvWutx1Ss2+PP+DvMsDtoU00GkgtTLIJQMJSp GMTHvYzGdrNLQeGge7FahsKMZgUKKQNTevza9SC/Swenraqm18KtZXRCzac7s0mn4kJe L0RR1CdvuIPBQj+wZ4HMWMDG/3WazUFHZg6xJ7f3S4EdCI2P42jvoLqaYtBhFkge5z6N WhxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=9Ga8X9++qfiAWh6BldRFQQXZ+w/+Bj3hqeXHqr2J+Og=; b=kHP5ie2hCDS+59aF9eQ39BMEP3oCHw6cxHDkEgVkh/h/mBvMokbsnYzUKa9vUvj0ux /wRgFE/X7ykIksd+8bTU+RQEDnccnoknt02blWZn8auI3zhR1XKUKcyQLC9CpKb5ALM7 MrWmvgLoEtBzOPukNVOgoBBLG7xGM4uM4WG9M1YSZUt0D7MAx2LE9XMjP5aWOl5RlGD8 QR7mawHoXp2na/ikVx44TmQs9Hj7HDLHRxFCN065zZ3EsaGpxv3uncT1hcU9T5Ksgaz8 ukhU5OlhiRNDIaaXYClTMC7vH9NS/xVCDf+pGMGZVtAAvQTFjs4FYUqrJTWOthwcMR+0 R8Ug== X-Gm-Message-State: ACgBeo11MHiHiVDX+auKqcJ4aNW7VgsDkJHDRBEIp5rbdXHAtMOTntk2 832bfGPFlZwjU9BGlzMv3/5dwg== X-Google-Smtp-Source: AA6agR7QhocX1THln9X3pKtbHqBNFAiz5uUKM16iZZhYB3tXzCoHbb7kshkUQUZ50OlscMKuzjhY/g== X-Received: by 2002:a2e:a801:0:b0:261:91a3:bc44 with SMTP id l1-20020a2ea801000000b0026191a3bc44mr7194605ljq.497.1662963478460; Sun, 11 Sep 2022 23:17:58 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:58 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 03/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:09 +0200 Message-Id: <20220912061746.6311-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iskren Chernev Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 80 +++++++++---------- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index 28b29bf714b4..e39fbb36d8c1 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -150,44 +150,44 @@ additionalProperties: false =20 examples: - | - #include - tlmm: pinctrl@500000 { - compatible =3D "qcom,sm6115-tlmm"; - reg =3D <0x500000 0x400000>, - <0x900000 0x400000>, - <0xd00000 0x400000>; - reg-names =3D "west", "south", "east"; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 114>; - - sdc2_on_state: sdc2-on-state { - clk-pins { - pins =3D "sdc2_clk"; - bias-disable; - drive-strength =3D <16>; - }; - - cmd-pins { - pins =3D "sdc2_cmd"; - bias-pull-up; - drive-strength =3D <10>; - }; - - data-pins { - pins =3D "sdc2_data"; - bias-pull-up; - drive-strength =3D <10>; - }; - - sd-cd-pins { - pins =3D "gpio88"; - function =3D "gpio"; - bias-pull-up; - drive-strength =3D <2>; - }; - }; + #include + tlmm: pinctrl@500000 { + compatible =3D "qcom,sm6115-tlmm"; + reg =3D <0x500000 0x400000>, + <0x900000 0x400000>, + <0xd00000 0x400000>; + reg-names =3D "west", "south", "east"; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 114>; + + sdc2_on_state: sdc2-on-state { + clk-pins { + pins =3D "sdc2_clk"; + bias-disable; + drive-strength =3D <16>; + }; + + cmd-pins { + pins =3D "sdc2_cmd"; + bias-pull-up; + drive-strength =3D <10>; + }; + + data-pins { + pins =3D "sdc2_data"; + bias-pull-up; + drive-strength =3D <10>; + }; + + sd-cd-pins { + pins =3D "gpio88"; + function =3D "gpio"; + bias-pull-up; + drive-strength =3D <2>; + }; }; + }; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6BDC6FA8B for ; Mon, 12 Sep 2022 06:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbiILGSV (ORCPT ); Mon, 12 Sep 2022 02:18:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbiILGSI (ORCPT ); Mon, 12 Sep 2022 02:18:08 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F4527FE5 for ; Sun, 11 Sep 2022 23:18:01 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id i26so13131729lfp.11 for ; Sun, 11 Sep 2022 23:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=XDfWSSZYnHMYa3I+jtVKxklgIjaIvR8V4Z96XPKAank=; b=JJKAJOgELOlwmCL+BnBq3mbcAiPTeSYOKDMEIK2H/haWGfWpmu5/LPNSSOZnV63G0k 95Jr1uJEPAqaSaQXQbMRndo54Vxe+8a3prJ4xoHZmET55DephfF8RQoUH/fUyXNZkNQ0 T+9xh9L8WQu3OeN0C4kERarcfgvWPnLEitgZGiQpD70oA0ocS0zNrWn+mJXsF46FmELY CicZzhYFu00I2xV42gltvePL1dvwP7GoVOcGOLWvWSO2DPOnNitLjo0b5CH1drHzoaki fXqAZzTyj1vOAlB1YTlsMDuQI8xFyJxT1kwQ0Xo2/wBhLcLRUlvIEZeOeERcUMR/XDI9 74wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=XDfWSSZYnHMYa3I+jtVKxklgIjaIvR8V4Z96XPKAank=; b=FNEvCrMSdgQLvmvs/H7RcQjHYSYLfJM7HO0Y6fp0WGFGZsAH3LhEbWhAiZhz/zHTzh xtESmVd3oADis5hwxtYNjjJ6JPtC8+Tz7tYGwD6f3eZunz2pJP5ovdRPfFcPO+mABlyZ tVvexQmQqQ6CsDMwgJzWuvusXHm0ZP6CSv2ZDwzZpjVvjF48ltYcH2g6yLFhj7fwfNWZ kSMFgWqDye0o2lhSFJdA5clOmF/GszD7f6BlKKDh93CCTf2PzcysJZoLFvN5jM1ozq0n w6ncIYDkM1yzJzFGx/pbAvn8iVQiGUi8hjNyk8UFQ7TCMPM/uyZyMlcXJND6/4aFLGDh leCg== X-Gm-Message-State: ACgBeo3voF7BkV7DUIV9nWW/XPHZvbg1Vtg/k32Se0NKxAGJtCCsDTw6 gWMT+MwQZ5ChiJ/DnxpatQm8cA== X-Google-Smtp-Source: AA6agR6517MOdeUu/5+gzOzJj9LdfjK+/YCE3DzsF+tfaNofqE16a2BHRWuHpPnAx08dbTwm0qPPwA== X-Received: by 2002:ac2:5a46:0:b0:498:f53b:d19a with SMTP id r6-20020ac25a46000000b00498f53bd19amr5921684lfn.674.1662963479739; Sun, 11 Sep 2022 23:17:59 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:59 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 04/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:10 +0200 Message-Id: <20220912061746.6311-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index c8eec845ade9..84ed16f9915d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -51,8 +51,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6125-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6125-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm6125-tlmm-state: --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5504FECAAD5 for ; Mon, 12 Sep 2022 06:18:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbiILGSh (ORCPT ); Mon, 12 Sep 2022 02:18:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbiILGSI (ORCPT ); Mon, 12 Sep 2022 02:18:08 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DB6E286F0 for ; Sun, 11 Sep 2022 23:18:02 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id by6so9298156ljb.11 for ; Sun, 11 Sep 2022 23:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=fEX3mEf1YS0VEGkwrFu/5ECJ6Ev0hCKVagP2clm1WMU=; b=fVTuBzBUkJ22VyHG6FNWHCYgoRTNWjgDMyVIXuk5sPhnDy9eMiAtlWYY0PFzdJhw/U 9+5yWBbsHubw+nvqkA1HLrAS/8/1lKSI5915T74J9v3RSmSdCTTb2ln2Mzu/JiXtj3FS 1MvRPCL0Fgc68BNi4TdRhQmgamnDzYCS2SyWM62/DGd0wh9wSpjiSqyyPqLoPWD0bFc4 NZig99eryWwBIx55fgIpZSlt1dV7SbwapfQ+IWbWLtWq4Twl0Sxb/mXCLlWbuvHGahnO wnSj3BnhqAjSGvLRc8QAuakyz8X1izLxPP0juDBdmNoLgP0IfekWnN7fOnFYPg4moGi6 4xrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=fEX3mEf1YS0VEGkwrFu/5ECJ6Ev0hCKVagP2clm1WMU=; b=4Iy7AhasCWebhItwn5YbGxg1+EEdhxsMQoj3l2FA3hyZyOvs69aq8DvNoOqJ3UP4Kd J6DVStJzhg0HYhfy/9ZUbe1VoncyJC05yPx+0lNlCpO0GwVqPWgTVMnaCHUDRLcRyXkl 0dbkFyumwgdWRrph2r1jYiOr4DmPBctevEnmIh+1SJZAI7wwPuFGVnYshgwVK5pBTXDn 5tLddRLOFtHVcW7+vO4OertcRJURe6uOTdNbJw9gfZhldnMw/fp56zd2ZkziDwC3N+dg /rkUtftsqYzNBWjJ+P4lJKasAT62Bg18ATZYQOA/TXmgFaAI3FWu8gJ+LI5AqbDyrvbc X+WQ== X-Gm-Message-State: ACgBeo0YYx5hjHdwvdOdAj6C7cvxYPSubfYCMkY9V+pyutVgkkRzeca6 43QlQxlxXtbDfWJsl5luUmkNEw== X-Google-Smtp-Source: AA6agR4M8TAMHhPFbvbyPN9nvAjoUxf1GnokNm6GLAPiY8e/5IWPCyGMpO033fwrrhvc4VXrB2/CtQ== X-Received: by 2002:a2e:5cb:0:b0:26a:b1bc:bba5 with SMTP id 194-20020a2e05cb000000b0026ab1bcbba5mr6959655ljf.93.1662963480813; Sun, 11 Sep 2022 23:18:00 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:00 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 05/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:11 +0200 Message-Id: <20220912061746.6311-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index 84ed16f9915d..735eb5d6834d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -61,7 +61,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -112,7 +111,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio[0-9]|[1-9][0-9]|1[0-2][0-9]|13[0-2]$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40AB5C6FA82 for ; Mon, 12 Sep 2022 06:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbiILGS0 (ORCPT ); Mon, 12 Sep 2022 02:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbiILGSI (ORCPT ); Mon, 12 Sep 2022 02:18:08 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CE0228716 for ; Sun, 11 Sep 2022 23:18:03 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id p5so9308001ljc.13 for ; Sun, 11 Sep 2022 23:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=F43nv8/M+cL0CQPWEGRQlPTNWaqRQm3bONcFJuSIY7A=; b=A7XnkFV8JygYpzI+K7FIUb7NSbKPQhJ86e+gadfJ11SGAzkTHjVP0B8wKi1WlLAjDT FxcV6fLHq2EaU1ynM4X1z0909bqA1Rt2dWAXubIwo5+YLV9qELixFeCC9xo8/2NQSi/t wo0HHxNzmJRyIBQ00wsdrn4xJyTx1SrUm7/nfb61Cr2CAAAdOF1cocWDfK0oCvhTevjT C1jJlK12W68d4kY6OxSPKSqYI75TsVAfq6h3HFRZxfN7eE1Ri6RIW6NyARAVo9S9+7Pj v+58UdCE9hIUhsl+pom7C9P7uCJAXfk/rLEQ+RvbGaw5dQxr5UODLFUfPBCkDw7B2yjz ELUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=F43nv8/M+cL0CQPWEGRQlPTNWaqRQm3bONcFJuSIY7A=; b=wnbU3QderjubRmHmsn7Tg6BlrcRmOyqsWzpJhKFVnni40wPBV9xQ/83m882Z3vw18i Qr09YxpVV8Ye387pZzx2+e2WJYy7cPnuyGnzB4bC2XbsMw/cijfR1/P6w13EeMoJbdEI iksa14VfWvjD7NIWXdpNSNpdzqqxhe7+xqNd1zdEVyon98wE45LQB8Bdh+Mg8odx0Qqk k6A6OjwzT4c3ySUIBuSu1NgNEADDrEyEhEgI/jVrTGuW/a3ZGargj7U+zsSMIv1Q7JMd C0FQsbY6xuZvCxbe6Xvw5Etu95sNHTwDa0ruYDlTXfbLoff8zh/k8OCm1ZfuERyCmgVr B3eQ== X-Gm-Message-State: ACgBeo3b9DAPrKiM8kEdIHHmKbRYJZ1Xf/C6ZdxumOPGvFSdrJl9AogP IgnfS7U2brRi3wEusQvb5TINZQ== X-Google-Smtp-Source: AA6agR7X1hSRlJCWjl1EPIyxzpnPf13OnmsIlWlF9PER1H8bs5y2ZqqsChORkdl64SClLdzgNvYEKw== X-Received: by 2002:a2e:a587:0:b0:25f:e6ac:c287 with SMTP id m7-20020a2ea587000000b0025fe6acc287mr7087104ljp.416.1662963482077; Sun, 11 Sep 2022 23:18:02 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:01 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 06/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: extend example Date: Mon, 12 Sep 2022 08:17:12 +0200 Message-Id: <20220912061746.6311-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Extend example with children for pin configuration and indent it with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 46 +++++++++++++------ 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index 735eb5d6834d..5cb8b272cb7d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -126,17 +126,37 @@ $defs: =20 examples: - | - #include - pinctrl@500000 { - compatible =3D "qcom,sm6125-tlmm"; - reg =3D <0x00500000 0x400000>, - <0x00900000 0x400000>, - <0x00d00000 0x400000>; - reg-names =3D "west", "south", "east"; - interrupts =3D ; - gpio-controller; - gpio-ranges =3D <&tlmm 0 0 134>; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; + #include + pinctrl@500000 { + compatible =3D "qcom,sm6125-tlmm"; + reg =3D <0x00500000 0x400000>, + <0x00900000 0x400000>, + <0x00d00000 0x400000>; + reg-names =3D "west", "south", "east"; + interrupts =3D ; + gpio-controller; + gpio-ranges =3D <&tlmm 0 0 134>; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + + sdc2-off-state { + clk-pins { + pins =3D "sdc2_clk"; + drive-strength =3D <2>; + bias-disable; + }; + + cmd-pins { + pins =3D "sdc2_cmd"; + drive-strength =3D <2>; + bias-pull-up; + }; + + data-pins { + pins =3D "sdc2_data"; + drive-strength =3D <2>; + bias-pull-up; + }; }; + }; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DEF7ECAAD5 for ; Mon, 12 Sep 2022 06:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229702AbiILGSp (ORCPT ); Mon, 12 Sep 2022 02:18:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbiILGST (ORCPT ); Mon, 12 Sep 2022 02:18:19 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71FC828E3A for ; Sun, 11 Sep 2022 23:18:05 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id z25so13181946lfr.2 for ; Sun, 11 Sep 2022 23:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=u03qsv1ayfTU6Jx4uWdo7qxMiGgjgckKImKOyJnLF5w=; b=a5qFYMQoEm1+4yxovQ3Ef2O3ttvBtdH7U35anDVIDhwwF3yBcFOQRM5LKQrrNPePsF 8PxmivF0jtVa9KJghmdDhWsQ8cvJJvP7ILP+eJGQU1U4bWzCQW5so4ZJP2Z1Ndv3uGM3 0nZT2DY3G0VxfQeLEInmx1sN35jA8rLWDgnyng58y92crc0H1hdwWUjRNO4TmenMReAN pizRxzbEwBkf0/B3twPCX8Y+SAZlhc+wEgbb2Ev00YEx7cswtb2JJKaMDqWA/5EShrZw f/8FV5aASHlNPV9gT+ywkmfiPZ+TzLxygAZFRmDCT2HmFo+9KPfLzP/QCtM/g9Csj/J4 AQ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=u03qsv1ayfTU6Jx4uWdo7qxMiGgjgckKImKOyJnLF5w=; b=w4IqBN88tGGxuPVduZ8j47Wi9q6u3I6aAiRM/0BJ9Fss03GOCdLWaunffVvscxduOM wnb8koDxC2XYbI9sYeDkjEiK9k1AvSGH11vEyvs49rkQFNQkgOBYQyLFsx/fJ7c1m2Xs QXwiQDFaemEtdeRgmf9CDY/TRpC4Fu/5zQtxn4xYIwoA1HrnYPmyv4UOMBlzCKutgjwf thrl3dvkmIYVpj2Z9VvQJQVnXba9ryCTVXraOP1+meqwmuL7arEa8diGdu4YPceyzSCj mitffvT1LMfP9bdAcMpMScInzcGJqtd5o5egcW9gc2olpAIygKmxXUoBnpXw7MUNLza6 atDw== X-Gm-Message-State: ACgBeo3I3ZeHNH5crOiRekYSCa4JOtU+u4UcqH7MxHwNKZOToB9y55rd 9mBUK8ICb0qije0028Kk/rUMog== X-Google-Smtp-Source: AA6agR7nDfo2PcytVMo1uVWx8E8ef+HVm/VXHhh3lbmOPty2aOgtyO7Da6aBn+MTpiTn9sJssYEe2Q== X-Received: by 2002:a05:6512:3ca2:b0:497:9db7:ec10 with SMTP id h34-20020a0565123ca200b004979db7ec10mr9150052lfv.350.1662963483323; Sun, 11 Sep 2022 23:18:03 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:02 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 07/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:13 +0200 Message-Id: <20220912061746.6311-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 898608671c4b..85a4ff5a5625 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6350-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6350-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm6350-tlmm-state: @@ -133,13 +134,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio25"; function =3D "qup13_f2"; bias-disable; }; =20 - tx { + tx-pins { pins =3D "gpio26"; function =3D "qup13_f2"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00796C6FA82 for ; Mon, 12 Sep 2022 06:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbiILGSa (ORCPT ); Mon, 12 Sep 2022 02:18:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiILGSP (ORCPT ); Mon, 12 Sep 2022 02:18:15 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F24602873D for ; Sun, 11 Sep 2022 23:18:04 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id y29so9324725ljq.7 for ; Sun, 11 Sep 2022 23:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=QW6MO1hMHGswxNmgzSJJEoxkkpvgP7Us3KREmZxCiHY=; b=Yu9BrTqQcEnJxEPrrVuFTQnTOJd6wG3FOfZq1tyHXe7MODQglhQ2YwW76KKgFxHMtc eaBS3IIh7jA1ahDEkBkygX8QqnmH9rBo9aOmDD3Mfs9/TcUZxYucYXClO5a3o+Yh52/C Icgoa7DM9ftsY0BycYjoANiKt9ZF7Nlz6lAMvTg6KCDb5AJLEyvx6j7embQb+xf4vuyi MI2w39tuOb10Rig5XHBJC4tWxhqCZr1HY9n+mgOSA+26ZVCrt+tMZwtrbloqbDXY+rmb 0XKTEvffzZwuYjPPiGqWiAS7buUNtsO3eZkWWUaH2YjlrEWmQRNP4Fb9LynxIJYu23/i 3vpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=QW6MO1hMHGswxNmgzSJJEoxkkpvgP7Us3KREmZxCiHY=; b=20RU2SaXxM3OMucbc2laE0K7havG/PJfukbi6C1eq4XjwyI+UiQNKgZG4mCP22kToo Zz/QJ3vV47Of5JwA1RhbB2F1ZzJJ6JmOh7HFxS6L1Ri3japmoLKwCbD6ruFUkA8Zzx8d RZr8sSbxzT+UyOvpssHCFDVgm7Ts7dzViexxwAPWtJeXx3DJvkQnC80C74NN8BMO9p/N o38kUyzH2VUb5gSTl23yKJ1RP1PNAPQosWdUleij41dAesDewISh4yK3Tmhvj5AerFA4 Hlss2ITWEbo3QRpmalGqWldpCpijSMcb1ZImhGUNrvxfJuumVNLJNK5ll37sUkBmJ7dV nLhA== X-Gm-Message-State: ACgBeo0JFGgQ6fspDn4NSxzvl0IeCVWDEwCOj1mPjoTimhoiiF9q1F4N jKRbpE3y5X4870C7JoyEp1rGCA== X-Google-Smtp-Source: AA6agR5e30kVHJtnGRAqmDS1vesInkLLMyggYUjIYvaBWvXOR2+0CczdiEDd5g3ruvNG032Y0ncEQQ== X-Received: by 2002:a2e:a4b1:0:b0:26c:521:76b5 with SMTP id g17-20020a2ea4b1000000b0026c052176b5mr1205004ljm.258.1662963484412; Sun, 11 Sep 2022 23:18:04 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:03 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 08/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:14 +0200 Message-Id: <20220912061746.6311-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 85a4ff5a5625..0c4bf6e90ba0 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -111,7 +110,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-7])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC21EECAAD5 for ; Mon, 12 Sep 2022 06:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbiILGSn (ORCPT ); Mon, 12 Sep 2022 02:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbiILGSS (ORCPT ); Mon, 12 Sep 2022 02:18:18 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5CB929811 for ; Sun, 11 Sep 2022 23:18:06 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id p5so9308120ljc.13 for ; Sun, 11 Sep 2022 23:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=dSJXKFEZI4T1kbFyh1aKF3VNgs72FXruybc3OKrfZRY=; b=OYnKB00l/lh4t3hosBq7sPudQrWN98jkklZEAM7wrHZi4WRJJajlSYWbsOBWEy3Wt9 U1iez3g/sOAZKFkfCcBbuWBUWQDoKoRT0myMJDLjDxCe9KpU4SF1Az8dgLJehCrHr4N7 8z/qDb+zcwkmGUzk5D3bLU27DBEr679mqRbq7icqKrDI4md4sdevTtMakMBAeCtQd4E/ PEvsnB/cETQ2SuffQMPKzJodb+P/n4qSehEtma4eBOFgNpAHrblENdQV0qKFr9og88p1 KkpIwz3fF/yfcYvD/tmyGxk0wjHSeuXVpKJUgcWZNrB4Dda91TN4JxwcvRngNuBuW5jO BbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=dSJXKFEZI4T1kbFyh1aKF3VNgs72FXruybc3OKrfZRY=; b=Tl4ikGFgPOccxXSomk5veXExV680yzm736z17SwSdQ9gViebNUdd+ZpzobhcxwQPja EOXOIdKXbpbwOgT+/Z5FMvd7+bQhqH4mNLJEkVZi2H8J29Bw8pBKnDLN7UtFOdYE7hYk Fr5AJ3dp+ZU/4U31A9Pfps0/zyOhJu2VtQUfY4Trw0Hlk+ptyAyURo09Tw2HEqLxAXul 8HNVcoVPQEcYIGECjdyXXrv/F60x7Zi7Q83TFpSKLLc6yuRLsVSliYtLEj5iNHJ2Gg1h V7vENwTTUxF3qfQRT+XdSGgfGOMQ+cof3CRKHzzErpRwCzMdFqaWMDe5OWsVVZHeibtd ZHhA== X-Gm-Message-State: ACgBeo01s6RT8A07sEc/esQA4GQ1ediFrOZXU5Wk0t7OewVOTICUAVsL jHpIcWX4CQQq/mQ7+0QMU8+XeQ== X-Google-Smtp-Source: AA6agR4WQR1eg6E6HyOOHovMK/iMZcVJ/7te7mGe79HMH/duPhKgGkTmuwVbvSO0omzw1OLxa0OTbA== X-Received: by 2002:a2e:5356:0:b0:26b:dce1:419d with SMTP id t22-20020a2e5356000000b0026bdce1419dmr5323661ljd.52.1662963485739; Sun, 11 Sep 2022 23:18:05 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:05 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 09/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:15 +0200 Message-Id: <20220912061746.6311-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 0c4bf6e90ba0..856b9c567ecb 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -125,34 +125,34 @@ $defs: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sm6350-tlmm"; - reg =3D <0x0f100000 0x300000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 157>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio25"; - function =3D "qup13_f2"; - bias-disable; - }; - - tx-pins { - pins =3D "gpio26"; - function =3D "qup13_f2"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sm6350-tlmm"; + reg =3D <0x0f100000 0x300000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 157>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio25"; + function =3D "qup13_f2"; + bias-disable; + }; + + tx-pins { + pins =3D "gpio26"; + function =3D "qup13_f2"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B5EFECAAA1 for ; Mon, 12 Sep 2022 06:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229815AbiILGTA (ORCPT ); Mon, 12 Sep 2022 02:19:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbiILGSV (ORCPT ); Mon, 12 Sep 2022 02:18:21 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07C8828701 for ; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id a14so7212842ljj.8 for ; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=32LY4IbEPjFm8JO/WRWi4obqGJa0d6BNeLwZ83eH6po=; b=WCnkuogqu7kQCyySlMwsIlulnXgYiVr5RxZd68Qj3KB00YqxTjGtAKuc5MwsQUHYoo kmK7+WEA7Fth5kid6mrA6rake6R8gFokF85xN1GI6iScDaLEzR0h1TDpljBwlbgW/p7X ffW19PP6q8Q5dpemuB3THQcZlHqbFkaPyrjCDSEU9Fl92TDLrAvUHkziNM5vJLRB2iAl Go7KqodPT3JDgg2zeUgsw8JeSH6t2509Ofvlyv1rdH9ORY6NjQnFjOgnf1Ibnqo8lOfg gze82PO3WkTsIAeKtfsPenMyjUk+Ai+ivJBYCzFU87NWz+rnKgMb2sAdT/rl55qP/ank FPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=32LY4IbEPjFm8JO/WRWi4obqGJa0d6BNeLwZ83eH6po=; b=Ez+i5+Qao5LyDKVxi8DKZC/OwojTIXq5VmLhthpuAeG1qrvgpDb5tml5n9CMClKveQ u2hl4U8EEFNz19HXyzF2sXjClFTm5SbtxCJxvyGzhNferxiTaUB4+4ji6sIkvTtFpPnn I3ijDV1RN6Vbpr/G2N2aKysZlpAjmEwvCBQru5fvl63LF4nBDYgzUMQ5/5l5UfXrEQKQ tx5yxP7tyF28hoe/J+01lug0kI1/rbYdE+MGCii2h2it0Z9dM3w7V5fRdIOGO8Bd1shh aaHgxgB9yVe0lHyQLJn/agqUX/K5VdU9Ya0n2TT8cegASCzwnTr3g7jjHUOFMdCgR2Re jv6A== X-Gm-Message-State: ACgBeo3pZ9Q4KVFr9bMqFHAW1KL7zFE/z027x4rErhWzqIp82QY7G2mk FIHUvTnSCRFw5ICCY59Gz8jaVg== X-Google-Smtp-Source: AA6agR7+hZOh3OMyOgpPiLFCoMoouG6n4+mB59qgB2hYJA/6/Y1BW+Jo7prrvciHrP4MVH/mpR/vUw== X-Received: by 2002:a2e:8190:0:b0:26b:d94b:75e9 with SMTP id e16-20020a2e8190000000b0026bd94b75e9mr5994084ljg.379.1662963486842; Sun, 11 Sep 2022 23:18:06 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:06 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 10/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:16 +0200 Message-Id: <20220912061746.6311-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yam= l b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index 3908807a8339..50f0ca5ab7e7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6375-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6375-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm6375-tlmm-state: @@ -142,13 +143,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio18"; function =3D "qup13_f2"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio19"; function =3D "qup13_f2"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BA4C6FA82 for ; Mon, 12 Sep 2022 06:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbiILGSu (ORCPT ); Mon, 12 Sep 2022 02:18:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbiILGSU (ORCPT ); Mon, 12 Sep 2022 02:18:20 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F4D286C8 for ; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id a3so1166566lfk.9 for ; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ozqjcsR32neOzHv2L/2DOKBG63rqHKYUg3f24PJLOOc=; b=HRXfYKOKYFo928QWTJ3XEeNmTLfXNxtR/ON4IvkVbjcN2wLb8jBCHmxgVK2bIH+8U4 JLBAdj5mQHCnpyskwRIu/VmQAcGkVCJjQNYYxMO9kPn73S8X9Ieeav7pmBRHGOMvM7Bs COPnYkj5ggVLHo5DVdGM0fyxdRlD61E5cKhIxmtoQAJRAURxh8kHGpujtgiwZFmzsqNj u/PIRrv7ne0/H8f6rM+Az/m5beHkqfCi1/m5mrcNCP5idGwfj5GqS1DE9SHlDU74zPoz lNDwjZFnf1veGs4hNVh2azL7A7+pB9IBnxl2fyZo/tEoKWPDiXRNkzvoY9U33H0Fh26U ViFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ozqjcsR32neOzHv2L/2DOKBG63rqHKYUg3f24PJLOOc=; b=58ovApDifP0MIkc7uPyzCm2uOJuaK62vgx2DBYqFbPanJPjY1rzlxNd2x4cMQZYQCp mNVkPJoExrxuR8061kRsFfq9+jcuq3MoPhvzfuE00Tndt12ai9lDNbVBynMgNQah+ZeL kWZ1lDVvO47u/vzmM2Xg0+igSulFKUGC5hiZbvglJ+E6ztpzoAF55sptfkiBjQUrPLuY VfS3VKWgGP8TVQ4sjtYGgmCXFu2MqPd3R3yRL4gQH++rRgq/TBnBV+COGOCPvGIOltTt d9CArM5KfpFjRGfJPD9M5S377nAEoI0PLZZpuTVvxnp9ltz9sojc3RJmiiT9pAhp+zML fGXg== X-Gm-Message-State: ACgBeo3NQV6gE42w+9ej0GaH3nA9cJpz38J3cF77S43aMbsUFgIPgXtq kzHESQ4Wj3DXbp625o8hIvR42g== X-Google-Smtp-Source: AA6agR5vkTc5bkDXc5Fm76W7X9SzYXQM9MwiJVKojNzC/A4IpZJDSLBmWCYARjlCcfu3cz7vOxslGA== X-Received: by 2002:a05:6512:3f18:b0:492:ed03:1aa8 with SMTP id y24-20020a0565123f1800b00492ed031aa8mr9230762lfa.515.1662963488072; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:07 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 11/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:17 +0200 Message-Id: <20220912061746.6311-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yam= l b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index 50f0ca5ab7e7..dbd91d6b63b3 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -120,7 +119,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-6])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876D7ECAAD5 for ; Mon, 12 Sep 2022 06:19:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbiILGTE (ORCPT ); Mon, 12 Sep 2022 02:19:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiILGSW (ORCPT ); Mon, 12 Sep 2022 02:18:22 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25E7527CF3 for ; Sun, 11 Sep 2022 23:18:09 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id z25so13182258lfr.2 for ; Sun, 11 Sep 2022 23:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=BzxKI895lpDHkY+H8tKxOiDzUL4EnCHd/mNz95fFCeE=; b=Xlg2dIPv8xQTI2AgZqSOy0a3Aoq6/qTwvZp96vZCURU6ZFq6elhBgbi+MDZ+FWhwl7 rHCaWo2Dg7AdG/tHit2VZWr5/Mwq7CAI4JXV91OO88J9cb61e4OTOiONNSU3QCw85qi1 HsXwbWSs84Zn5XJ/YMcrDGhtEBXk7DD80Hfh72uoSZBRhnp3u0NLHCxcT3X+NSMSufXA bOA/spka51nXO7cPIyvCzg9A9DMeYSuWkVQaNVn+6CBxYd1BF9/MOBeK80Z7XrClV1t9 paOd+HnY92BLRntDxYOFYqHXmudEkD+IvsJs1rJ4XEAfy2ZaMH6GRnmFNjdd1tolLBUF YehQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=BzxKI895lpDHkY+H8tKxOiDzUL4EnCHd/mNz95fFCeE=; b=AAajTahjYROyntYviwpt8lziNETw0BB5FMuE/iVR0oqXNcfEzQGo8HXlDRsx+/KLSe PW2xyEAak55slxqOzOQbhH0CT2jT9G686cUY+3MvPNyT63gR8ygZaSdzrOx8Q8Jfl0Li FQ94Z3VWti7NIsDZhjT4nID3HVJQCQMFQ97+VT++VYwDjiLuzMxgKkBMlMXH186g/UNE aTQvE0lXp9Zri5MSdz9A1HXBITthROBwVPQ9Rhf5Dy0RcIEH5zy+gQIUVLHpHXtTl5h2 sZTfnTo0VTiNTeNjbihoo9Fnt0b1iHhWiv98oQtgKCfVT/EdtB7C4WCDwjYzhwURFgkx WaYw== X-Gm-Message-State: ACgBeo2g2QgAVuVCtFyKI1Wjbfycg9a5hPUVON77reEwJ8hHcqaR/ShB MTMWDglsyaZd5TdCgVku+sH/3w== X-Google-Smtp-Source: AA6agR6sXXzrqW04NblckGlbqXqV1UYsxNrNzA/iOY8ECYU7WjBS/pjnOgtbds7HAADn4Lg7FRDjwA== X-Received: by 2002:a05:6512:1687:b0:492:db5e:7768 with SMTP id bu7-20020a056512168700b00492db5e7768mr8804019lfb.118.1662963489273; Sun, 11 Sep 2022 23:18:09 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:08 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 12/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:18 +0200 Message-Id: <20220912061746.6311-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yam= l b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index dbd91d6b63b3..025faf87d147 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -134,34 +134,34 @@ $defs: =20 examples: - | - #include - pinctrl@500000 { - compatible =3D "qcom,sm6375-tlmm"; - reg =3D <0x00500000 0x800000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 157>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio18"; - function =3D "qup13_f2"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio19"; - function =3D "qup13_f2"; - bias-disable; - }; - }; + #include + pinctrl@500000 { + compatible =3D "qcom,sm6375-tlmm"; + reg =3D <0x00500000 0x800000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 157>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio18"; + function =3D "qup13_f2"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio19"; + function =3D "qup13_f2"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6DF5ECAAD5 for ; Mon, 12 Sep 2022 06:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbiILGTf (ORCPT ); Mon, 12 Sep 2022 02:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbiILGSh (ORCPT ); Mon, 12 Sep 2022 02:18:37 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ECD62AC44 for ; Sun, 11 Sep 2022 23:18:24 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id f9so12421871lfr.3 for ; Sun, 11 Sep 2022 23:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=huMBt2cOX5WYiW0m7Bpoars+zfOhAPbHFngq8gou9wo=; b=T8PDwPdVBimQHwxsfBUyfb4uH8nlYDvxv5g/QTxqnWH2LPwNzVda2v1jBaZzGREdVb EeAsURrwAHNtJ635NC2elIa4KJZOf2q08BukMxzmhU8DW8fxkPeDMAhrJUmFJ7jHMHQ1 k5rF/NhwGT2UicyG33Tm5TDHrXdiPTaPB84r38jG+srb5isFjWn1++4Q19e6RWhgjL2f zngl0U+K546t+Ex1Bgkpq+a5fPdxsLjBokKDpiEAUHKNmk6R+bJ6RPGpnR8NoEcjFSgX HG3oXxavYasohtl+8HxkTZbz2Ri5emIttgo+5T/c74/wBwp53gKOSekXze6q/jdla6NN LEZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=huMBt2cOX5WYiW0m7Bpoars+zfOhAPbHFngq8gou9wo=; b=S5dZB6WiQlu2KP74BiMV1fWVf9gJ4xrI4SnGkhLk8RhbS0YvjaTJe+oU96ClDJuK3E qnQKQR4gSaJ/4sVLxvvD5cD5W10AQ2T0iEYVnR0cQ8EyiSvvhzgHaQrUT5hgzO9knjyl HwQs9AFT/mmNrTT/P0Cr2R7GLV96/nrunKgv+aRxUVbTnFKJ8Esdrg8iWK3q7VvAKX26 Dj8MgtShHnNq1uh5KQpTep97XtQ5qQVtYVhyBgQIamps2ODesKwATcK7Az96XNHzs1F2 pMLfcou9vwSFFGKtAxY355dXXvpaxWJ906QEm9W7sdECqOBuGrf0Up3CyyX9UoKrxUiA 5oTA== X-Gm-Message-State: ACgBeo0g6EGlRK9mAp3f1Swn/tBHhWOM+e0qCHy4WYqVCx0joS4cMsMv Co1EoNlYpHX7D85RJFiqW3v28w== X-Google-Smtp-Source: AA6agR6fRJ9q4A31YGpIAzK9KA/cdCWDaEg2eAV3NGrqf+BNeg59ngLbUvMSv4CZ00GGrrC03Inumg== X-Received: by 2002:ac2:4e0f:0:b0:48b:7a5f:91c8 with SMTP id e15-20020ac24e0f000000b0048b7a5f91c8mr9052330lfr.430.1662963490535; Sun, 11 Sep 2022 23:18:10 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:09 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 13/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:19 +0200 Message-Id: <20220912061746.6311-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index 15bb1018cf21..12bdc2e67c4d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -110,7 +110,15 @@ patternProperties: =20 required: - pins - - function + + allOf: + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A86ECAAD5 for ; Mon, 12 Sep 2022 06:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbiILGS4 (ORCPT ); Mon, 12 Sep 2022 02:18:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbiILGSV (ORCPT ); Mon, 12 Sep 2022 02:18:21 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4278C2A40A for ; Sun, 11 Sep 2022 23:18:12 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id y18so9311387ljh.12 for ; Sun, 11 Sep 2022 23:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ShPxgoMmuatqdGQWqNcZcpEJgDBD4NgqwMQX8EaKFn0=; b=Fc6pcgSEjUllry/Al9MHF/KiX476+f53LdQEuOfMlDgUBS0Y2Lysc5JDWCUJWQf/YR mRFsv6PSjAGrtHwJx0Xih2EBD9/NlJc2y4Pb00QpZlzGGHusAbnUn3OSEOy7U+ho1nQw Bxtw/FZYD0UVc8WE5M04VI0pWEfH88l2vEQZKCg7UTF5Mr2zRan172kVk/yiTBXWXjJD E5K7/zTPSikIe+QF+UtZBnoHqhCJMYeYIvbJPWpkM6cdUd4X/8WURI3c2oRGVgvS4kE3 o5lvrBXuf2AqSQ3CfdWB1eC7CC154Dh/VZ88zoxSOwBsvX/nWfwWfnVIhzPW+EyKxs9y MfXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ShPxgoMmuatqdGQWqNcZcpEJgDBD4NgqwMQX8EaKFn0=; b=ysv2g22haP31Ht6tI2cm6kQ5YqK/RL6fmGie4NCFqyQG8XSifjsBTPv0FHOUfUYQ+Z sJwBpzyWBlIzqQueFLa03mnz3GSS17gRKOKWxLdgf0ziVlim/HXEX+mOah92DyWrK8Rz xEd8TJ74NSoTs8ZvgoPRha3dzSoJHaZYI8mdP0V1uTsOkPgiKg1BOf25N9ZmBME4u0SR y64DWAG0fiE9Qd4BpGmkF8qQz3LilZjqv9zGqM4JRgCDZNpIlUyP8TnzKByyYhEM4Txe +npjb49NpBKqaU9m1RemDu0H9MMQQ1MgSOiHG8VvaMBbn4JP3Bxm8GIhYbkzVO7ehzL1 f+Tw== X-Gm-Message-State: ACgBeo0M5MENvHFQM2w2ZKQ5BoBOVMByCC6B8RBVTmFoNwXY42T0xr2J IjP0MLlGUqqOgi0TLWORX8hfyMbRg6d4PQ== X-Google-Smtp-Source: AA6agR75yTn57lU+jCF17X4UVDBlpwHYMObteomolVN1OiWv6zhw6uhH6I3NQc12mYKAd+lqers/MA== X-Received: by 2002:a05:651c:160a:b0:25a:62a4:9085 with SMTP id f10-20020a05651c160a00b0025a62a49085mr7579297ljq.214.1662963491657; Sun, 11 Sep 2022 23:18:11 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:11 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 14/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: reference tlmm common pins Date: Mon, 12 Sep 2022 08:17:20 +0200 Message-Id: <20220912061746.6311-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Each subnode configuring pins (so the final -pins or pinconf) should reference common TLMM pin definition. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index 12bdc2e67c4d..bccc83f22aae 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -112,6 +112,7 @@ patternProperties: - pins =20 allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" - if: properties: pins: --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE338C6FA8B for ; Mon, 12 Sep 2022 06:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbiILGUF (ORCPT ); Mon, 12 Sep 2022 02:20:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbiILGTC (ORCPT ); Mon, 12 Sep 2022 02:19:02 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5AB129811 for ; Sun, 11 Sep 2022 23:18:28 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id f11so13137467lfa.6 for ; Sun, 11 Sep 2022 23:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=qxAFFeV9Jghea1krVGY5BQK+UR1GkKeREC8WB6H5B2c=; b=gTdROqGrrSl+2/wJzwvxlczeW+rqBSo9O5tBZh5AMCfufYpHRu1eptMa2gvOexkH8G HUqG4NBpOoNAEYe+GXhJp035hZEjfPiFHZBKJlHDvqoAuxTtk5M+4K1JUUtQjoGlmaTb VHUfRvTnlzyw/n+Mmev6p/pPh0VGS5XDn9xDY1nDzk0gRpZebTGG9Q1Fpm3Z/cbsXNZV YQ8GEMs+OE5ccWatvCHnJefz6e06Gia1ZHzhzQQUsJtVsgF0aKjPKRpoxhnRlZU3bho9 V8hvIHpY1Bi8MItUeuzWhbfFdd5R6LFF4C5fX0Nb0ytbWreOhkrnovbBchnwFGwkhGUF QWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=qxAFFeV9Jghea1krVGY5BQK+UR1GkKeREC8WB6H5B2c=; b=wNlVxzLQSanV8vPrqkBv6Hz/V3TM1nGYID4F79Aav7P+1jje1S5AihcX2Qll10GQFc H8lN7ovvdc2H+k9HWKwuoSuO8qZtAkcFWX0cFjTtpuI1uV98UnlXAttOzb1bSCR1ZmFk xhzUKmrRoMzgeGbvlcYRJLFyP3S/v5X5/ZVbpcPdsR2iomGqFeii4ZmwmxXP8q1pXDyT WrLNWCBoWed//07LzpvTYTsDIFbeafkwmTlnBjtHprHVyYhqDoaQIRVH3WUTALgc8PzP fIz/TSgsf4w3s8cRybcfdrRFxLml4bfy3R7/jpuQidX4+eR6Ki+h4PRUbQHhkFTN1g3o n9nw== X-Gm-Message-State: ACgBeo3BHajoxcLghorFi3EhKK+udyCD4sq7zzNbnbHItwL/2VPuXBg1 DHKqFVeGnw8SnjYDkkZK+pl4vA== X-Google-Smtp-Source: AA6agR4yo2Oq6q/w+fQcJQJ371CJ+xnE/8UWXETJpk5WRuihsK1HiT2e9lawhz8pPDGJ/Xi8mdW6LA== X-Received: by 2002:a05:6512:6cc:b0:48d:acaa:8a66 with SMTP id u12-20020a05651206cc00b0048dacaa8a66mr9041345lff.272.1662963492830; Sun, 11 Sep 2022 23:18:12 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:12 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 15/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:21 +0200 Message-Id: <20220912061746.6311-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index bccc83f22aae..c44d02d28bc9 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -141,18 +141,18 @@ additionalProperties: false =20 examples: - | - #include - pinctrl@1f00000 { - compatible =3D "qcom,sm8250-pinctrl"; - reg =3D <0x0f100000 0x300000>, - <0x0f500000 0x300000>, - <0x0f900000 0x300000>; - reg-names =3D "west", "south", "north"; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 180>; - wakeup-parent =3D <&pdc>; - }; + #include + pinctrl@1f00000 { + compatible =3D "qcom,sm8250-pinctrl"; + reg =3D <0x0f100000 0x300000>, + <0x0f500000 0x300000>, + <0x0f900000 0x300000>; + reg-names =3D "west", "south", "north"; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 180>; + wakeup-parent =3D <&pdc>; + }; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8B8C6FA82 for ; Mon, 12 Sep 2022 06:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbiILGTH (ORCPT ); Mon, 12 Sep 2022 02:19:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbiILGS2 (ORCPT ); Mon, 12 Sep 2022 02:18:28 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01A242A73B for ; Sun, 11 Sep 2022 23:18:14 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id f9so12422033lfr.3 for ; Sun, 11 Sep 2022 23:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Ix0v/JGnTNkLvR8lnkw4PxO4vTS1Ezmp9TWJ/ylE0lI=; b=RNq2Ay6bofF8EtTn8Aa6fJHXRwtjlaMMQP08M8V+KUrrsyuwbPrNA3XJoxh11yduDU XhOblk3H0YAT/Zaz5e79wMpWLiu64N/MAu1+ByC8ua/LVZgEJzpmQIBVPOMSfff4ZdqF 6NK0B9QpibR84J4dKgbVO07aSpU6jiDS5nPK0BcGUWx/13GHjdssakEgGl008YY8px49 gSUzr0CT98FvcWtoo+NxcOeELtPGmWJtmNsdxlbC684gzYiKKnMMx4mqVL7TTkqpggnN Gsty06IMrt9PG2HOPz2JL5dBVFxW0XKidF/t+Zo1dw9PlC5SkTMTsXni9cCMSOpHua8A 76aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Ix0v/JGnTNkLvR8lnkw4PxO4vTS1Ezmp9TWJ/ylE0lI=; b=UQnlwDzeqAsq2zl8JNezSGMM2eamoOZ280t6LxqfwM6KOV5DUJUdtyvDSDr8PB9bP9 7b6Bpv992dvK0EGLrTl6PgP66HFohw/YNyefHhL2JqLgwDHi5ASDV6JafmvfjC+yvQbr jF5pNziIxp5qVHTVg4dymnxZVjXg0nLi6z1GvKI22SUYlqBYaTovbEi0XGi/Apf+swjN 9qGxPp2kVMTSAsCfsFuejQVy10CzpiKtcRbEfV48gO11ywJ8dguo09KUXwG+IxoYdZOP AcfrdD7pUaL4PDJcG+8KNF+68Lx1Baf9xJ7wkPunLIzb/rCRv8ppPwhMjFEB3/cGVeNu z1rA== X-Gm-Message-State: ACgBeo3MD6VqYnuTqbiypwi8geMsUtceMmHEkqLWaib5Edcim9FBzjO/ Bae5h21cYGw4PgIdLhRFGTn34w== X-Google-Smtp-Source: AA6agR7oxSPmPzWcJYkvHhpvvohJVKs8ewnvLe9zcbvmo5ONG+O/0LmLLaQElLINXty+TqmeG/Q1bw== X-Received: by 2002:a05:6512:118b:b0:492:e3c4:a164 with SMTP id g11-20020a056512118b00b00492e3c4a164mr9200538lfr.598.1662963494177; Sun, 11 Sep 2022 23:18:14 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:13 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 16/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:22 +0200 Message-Id: <20220912061746.6311-17-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: sm8350-hdk.dtb: pinctrl@f100000: qup-uart3-default-state: 'oneOf' conditi= onal failed, one must be fixed: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index 6b7789db2f75..211cca11f94f 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm8350-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm8350-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm8350-tlmm-state: @@ -130,13 +131,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio18"; function =3D "qup3"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio19"; function =3D "qup3"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B46BC6FA89 for ; Mon, 12 Sep 2022 06:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbiILGTQ (ORCPT ); Mon, 12 Sep 2022 02:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiILGS2 (ORCPT ); Mon, 12 Sep 2022 02:18:28 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 068782A947 for ; Sun, 11 Sep 2022 23:18:15 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id z25so13182557lfr.2 for ; Sun, 11 Sep 2022 23:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ZQ3YhRzsCIvzwIGS4j9FwdZrsy4eOBBU0P2zsVYlRwE=; b=YFavRgvL8Jvgg5KSU7zov2VEdf7/zxH1U32/swYPYp5f2qVJbinY5B6l54ABAseTH3 1Fjg9xNatNquSqn5PMqNzm9jp5Qj2LA5RsQuDb9Y10qcTLHaSQJBvXuVrUV8qeDit1AC WBsBwTWptg5bhihq+/lF6h7AYnRRqctNJmof7jLiIMkGbpI21HBCRM6uathMx9S9Qz9/ bgOJ5mNE7KOkBXEyv4jHTodPdYY9tZBZqhxNLlA8kogprxZ0ISEIgzHvu/kgaw5OP5Yq K0BS/X/+yHI+dntmO2WvxDLI3XbYyyDDzu0zTAssVURmNjKweg6HpDE8GDIitcM8chKo UXvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ZQ3YhRzsCIvzwIGS4j9FwdZrsy4eOBBU0P2zsVYlRwE=; b=IJb43CXKBaJe8SukSQVeiX2WipgnuGwR1bz0gFW2ynFCBPSUXkE+MzhJ+/wcoXrJ0I 3DDdAR090Aq9qQ0bp2q8uBJMX1BBM5+DTG8d3kCGo8PFVNpfvxgWwwccNljrT7BuElF5 iVpB7BN024P0kr7hn+TguyHrkdrUsThLPyGVhWQu7+6tmekT+l8dgVaPYfr1zuE7hPBR 1YBa4VzYDzjP7F6wfckPEj0u/YMm0mtWaf7PHe3wadHdsFs6nQmkg6k8AlYqlfJcloPj iDYa7tkKnpJD86SUPBDYEnQrvAGw6x1sW88RwEimQIVuWxvy8h5F13Lg8iVgFpjATyA7 SgTw== X-Gm-Message-State: ACgBeo0DNL+z/MKgWCVp+BcUVK1NxMwiAEuSXCm0UoJp/9v8XNLy+Nhe KdSxDJbLTD29cWBOM5Ee4NnAew== X-Google-Smtp-Source: AA6agR7kBHj+9dOwtJjEUEh1uLmt4hg7BQQArafWb63SmcnqlHqYdmLuiBg9Z7u/AqTNVBUt0yMFuA== X-Received: by 2002:ac2:4bc1:0:b0:48b:2ab9:8745 with SMTP id o1-20020ac24bc1000000b0048b2ab98745mr8996563lfq.75.1662963495403; Sun, 11 Sep 2022 23:18:15 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:15 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 17/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:23 +0200 Message-Id: <20220912061746.6311-18-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index 211cca11f94f..f3106d25adcf 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -114,34 +114,34 @@ $defs: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sm8350-tlmm"; - reg =3D <0x0f100000 0x300000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 203>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio18"; - function =3D "qup3"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio19"; - function =3D "qup3"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sm8350-tlmm"; + reg =3D <0x0f100000 0x300000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 203>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio18"; + function =3D "qup3"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio19"; + function =3D "qup3"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D66EECAAA1 for ; Mon, 12 Sep 2022 06:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229909AbiILGTT (ORCPT ); Mon, 12 Sep 2022 02:19:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbiILGS3 (ORCPT ); Mon, 12 Sep 2022 02:18:29 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DABDC27FFD for ; Sun, 11 Sep 2022 23:18:17 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id x10so9325724ljq.4 for ; Sun, 11 Sep 2022 23:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=BZ9D0FRQE2grk03g+mdXjEXzyihdHpyqrjbkROOcsv4=; b=TTp7DZxGJuSnK3qrqpKDd7lgsAeYbQrUqzjZLtnmGzksft9og6MTCGIPnpRvGH8l78 935LZxGnhSIwJgrDjLwFI03pkV46Nda36x7mJ6BolP2K4222alRCRCwiudqELPhKYC8n C3KEqhN3YLEk1wYeYH8c2irj1tdvCJG7KkmRCrXsy3PciuWRmb+iSMJ02qoEXVY7WDV6 YYjZhGp62s8k9bOkjEsYX9BODC7SQc/E99rJgVI1J5dONR4Lqsc56YtkrEKlWrHPo2mH f4Bk5F2PC9PgnOaEomfA0T4V3l+nNdw7qOMbkofMSGyZkU7WlmbnroeH7KZ8aAw0FxF9 k62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=BZ9D0FRQE2grk03g+mdXjEXzyihdHpyqrjbkROOcsv4=; b=VE2dO29xO0Lu/y13w3lEnMrZytJIMrNqtJ1I3LYflkKNwY/NMx5uCb117dVFmRvG8G Na/p/hsHXeP94fCQzlhexVRKk3bTrrM2vVEKsaMgo4KEjjjkaoz46JFtQMIDPxPEeRVz vyakKopJDVkVOgL2xZ4P2yU+j3asrJgNoOmycbUd6DtFCphqsQlZupzU4FjXc8Yawnnx ek2atajCCeMM+w+GQS1yT5NAV/wdy/xP/q0INgAstPrtS9yZENKGGaXEAAJYwnNbXiA5 1lpdcZXpZupG8ta1MU/E2SbKItqzyF0ps29grgWW75ClRQq2VQzvxFR8HpUY5TaqyLnZ 9mnA== X-Gm-Message-State: ACgBeo0clInVNM14ncNbANX5eXAbl4DIcYey0cRSISP5IKlnidtDQnGk J59ODby1saPCHAyJoy0thWNlqQ== X-Google-Smtp-Source: AA6agR4ojUBJbR98VBNGjH6wUq6Nv9KGgK1AKUNvZJBoFiv1DMMK6QwYkduNkakZUyZXwJv9yrH0Dw== X-Received: by 2002:a05:651c:91:b0:25e:4418:4c20 with SMTP id 17-20020a05651c009100b0025e44184c20mr7478771ljq.131.1662963496904; Sun, 11 Sep 2022 23:18:16 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 18/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:24 +0200 Message-Id: <20220912061746.6311-19-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index f3106d25adcf..6ae5571f60da 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -108,7 +107,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-3])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E036ECAAA1 for ; Mon, 12 Sep 2022 06:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229914AbiILGTX (ORCPT ); Mon, 12 Sep 2022 02:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229872AbiILGSh (ORCPT ); Mon, 12 Sep 2022 02:18:37 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAD0D27FE2 for ; Sun, 11 Sep 2022 23:18:18 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id f14so12193320lfg.5 for ; Sun, 11 Sep 2022 23:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GbjA8/0sNJoSMWK/LnXW+oLOon29f7DAZdcODYnsdAI=; b=erMAGCUjMGkF2Ivsnvzv3t/iPNvuuafZFkalisK7GLrYYBCdZmWuhau5ID5WuhZqTb kr4ysEzdnOmLoI24PE54VWcp/Yj9IP64UgnG2NySQxmwoDwgNq3uhLxCcsHRyeZNXzze qcngVl8HMJjvV8gMbNqVY3QFrTxqyfVoWKJYS1z6f6qdmSuj1jSra1r4awyaEaEfxDOx JXfUWvOrDk/G//9LuBhR4tPYlZQqDPAA1zsuuNWMOTfJJmjX0FpQkmdYXaKFsr1Kx4pZ M2qlCtgzNqhW4g0lkuYQDdqCPOeNDS25ybaO7WoZC+lyGTmj/32vTZv0oA2eGEqmofoK +nGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GbjA8/0sNJoSMWK/LnXW+oLOon29f7DAZdcODYnsdAI=; b=xYXIbQJcTt9hA2falwcK3VFWX4LdiX192mJjiRD8FxlSYoSE5TbFmQpFhTPEfteKl9 W7OI5b+povIEBMNJKnJmmOU7Z6KplOUL496Fo4cpRKSlO70pjX14VoJhTq96tIYO4BD2 0GgYJ5vXSTJyodUzx4Iooc2GTkVK5JIlAwaTs2ar1K9a5Gy38JkzNW1v2wZ/AYBZn7YT LjcbLX4TirKEIQ4XFOXumgfTD2Iz4fCjz5k8C9FZJC9vbLRi67DRYRji9vW7CMV/c+dO z6p0PIDJyj+BxQ2rZg6zaFNpqamvleZugdD/WFVlT5LWzuN+9f2uwFaHmrK9D4TPZp1T U6cQ== X-Gm-Message-State: ACgBeo2cTbjCE6LUZoEt+8ON7wuMDRwC8u+epA1TY49oIyLmUECF9Wk9 gqMuH8wfbmgvn/rGpkRaEV/WJQ== X-Google-Smtp-Source: AA6agR78dE94Pkj7MTVfrXdLrHj56fM2dZpt6YU0K68zVSX1Wj34JmSVk7ltGHP/cfzGrGJn83ASkA== X-Received: by 2002:a05:6512:310:b0:496:a0ca:1613 with SMTP id t16-20020a056512031000b00496a0ca1613mr9200190lfp.394.1662963498186; Sun, 11 Sep 2022 23:18:18 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:17 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 19/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:25 +0200 Message-Id: <20220912061746.6311-20-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: qcom/sm4250-oneplus-billie2.dtb: pinctrl@500000: sdc1-on-state: 'oneOf' c= onditional failed, one must be fixed: 'pins' is a required property 'clk', 'cmd', 'data', 'rclk' do not match any of the regexes: 'pinctrl-= [0-9]+' [[26]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 9c891246245b..d1d1c1455b3c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -43,8 +43,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm8450-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm8450-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm8450-tlmm-state: @@ -127,13 +128,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio26"; function =3D "qup7"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio27"; function =3D "qup7"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6B7ECAAA1 for ; Mon, 12 Sep 2022 06:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbiILGUY (ORCPT ); Mon, 12 Sep 2022 02:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbiILGTS (ORCPT ); Mon, 12 Sep 2022 02:19:18 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE482AE18 for ; Sun, 11 Sep 2022 23:18:35 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id l12so9328298ljg.9 for ; Sun, 11 Sep 2022 23:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=jLZlsEJ5VG4J2SIrJhH+JChzqh+Qp8BnGJ+3NtUQBWY=; b=iy+1E6NNM2NV6qejn/O7aNh2X6cahhiySX7JGDDPWM8fi7pbSxNy1Vy/08sMI9/SwD /Pg38MrUhxzzTL3YQFuIdnpJViM2Wb88kJaZAkfCk4rNCn6WsVjsWyMBjCXVNgYPrjhn +vglAER66aopmjjkNzalteCtuSiCC6nHQ8U5f5Zy7O8eVuZfTUuxeg0jkDPFWRP8BCXl +um5K7Ih0ATyvtrZQTK+fs+Ch18yyL4y0L5HNzCCBvZZm2KeKu13/czNFegoZpZcEYcr wNApHRGtZ4m58YV8YUplpkyh+xf5AIsYWtGaUUWoc6arPYnog5qGi5AuHJLveLSWK+lP GaLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=jLZlsEJ5VG4J2SIrJhH+JChzqh+Qp8BnGJ+3NtUQBWY=; b=TbnxrpTowZ9yhdNZk+cYygTi1xMuNe2bWntKSdFY+SjSXYf/XdAa+n2Qa5fFArhCLK QUii8A7zXBmLis4RfmXidasodDppx+mpZkfXngNf8qaa172q6uCrUcOGBesa3AhIIIwN bo2zjxL8CvHEY6oBiCIP4789ggZSdHemqsxdrlX3aDQ33zPrqzFmQpiyZo4A5SnEZsoi 9qJEJeG8yd9bVO97JpYVb2/X1F98ooug/ipu/7jfE8T5Pc0yYB7rvi7WijupA+bggZDl x1icmrhhVc9CxiFxmJ5xc2wE1ZzHVLRerkfQjEXsBYfeMnebf5jrRD4ZwHhkWD/5igjz u2Wg== X-Gm-Message-State: ACgBeo1CCQZ2IHJTZnIRXlffDSBm4Sh43F3grPs/d1s96E8r9Y+l6/7y Uv4aGV0KbYfc932QlKQnCbYZuA== X-Google-Smtp-Source: AA6agR6SCFQ8A3mDkdUAbA6vJv5w7JkeX3CkwNy4Ko3l8MlMVLJ2U4z8kPRzN1YdMQHNTkqVbseQxQ== X-Received: by 2002:a2e:9b0e:0:b0:26b:e2dc:c0e4 with SMTP id u14-20020a2e9b0e000000b0026be2dcc0e4mr4610047lji.459.1662963499851; Sun, 11 Sep 2022 23:18:19 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:19 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 20/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:26 +0200 Message-Id: <20220912061746.6311-21-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index d1d1c1455b3c..87347e9c5f1c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -111,34 +111,34 @@ $defs: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sm8450-tlmm"; - reg =3D <0x0f100000 0x300000>; - gpio-controller; - #gpio-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 211>; - interrupt-controller; - #interrupt-cells =3D <2>; - interrupts =3D ; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio26"; - function =3D "qup7"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio27"; - function =3D "qup7"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sm8450-tlmm"; + reg =3D <0x0f100000 0x300000>; + gpio-controller; + #gpio-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 211>; + interrupt-controller; + #interrupt-cells =3D <2>; + interrupts =3D ; + + gpio-wo-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-state { + rx-pins { + pins =3D "gpio26"; + function =3D "qup7"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio27"; + function =3D "qup7"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08858ECAAA1 for ; Mon, 12 Sep 2022 06:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbiILGTn (ORCPT ); Mon, 12 Sep 2022 02:19:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbiILGSs (ORCPT ); Mon, 12 Sep 2022 02:18:48 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E072286F5 for ; Sun, 11 Sep 2022 23:18:21 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id z25so13182849lfr.2 for ; Sun, 11 Sep 2022 23:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Ahz8RWfiLMT3ul4AnyZJntS/GGhk6GDdZTcm/1GzutM=; b=XQx4OVoUTJ8zLRAOaa2DLHo6FsqUUIRXo+DobwRnK46uXPNdF1oz4sHjHfhn7VBeDT mahjMNA/0pSp4sFed3g6hRqC4TNGf98zxdJP4fJ0bAMO+jXDBVlCcm/22OJUtITFD4O/ wur/E97wbVnWoiHsX7BhwSEEUw0vEIXN4wsq+gsi8dyzZ6V4mW+R/wPZ+g3jpOJk945n PzOkt9Gq9JKCsg8yTiSqodf20oBnJZUyFFnkP+L8X03h8qML8onuvOzimpqXQ25Zn7Aa BML63mdsfED5Jh7SwV5al2fDm7IAdAg+bdsyLk+uEk3Q6NfPT/BkJMX/utA0Xh5tFfLW BiQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Ahz8RWfiLMT3ul4AnyZJntS/GGhk6GDdZTcm/1GzutM=; b=Gf5d6KPX0TgVN2xQWVlyNdnYZXFpa4azSO7R51wXK5S5sZX6hfV9socU3irN/OQ60s QUiQ5VK2KYi7/VZEPNUKaVLmA6NjpKwQ33t/toXD+5Ge/jzzWaZuQ+PH3wxI4Sz6xYWQ SkinsT9a8dEd4238lguotObMl+vlx6IPCM+DgnN92XpC5XCaoN++7X8797dcNhdGdlqh TvL8Lq6/1muYcqVCFTaL1EBRpG69a0Wqd54QCh0vxat8EUyL3D8ShPV1Qpr+nYUIx+ez acEtxubK/LjHyqUHrXWgA1h0Xsy5cTMx4+rC0Ojfnd20+VxGz3NvMSiiQ5Oy9ogEAt3y vfJw== X-Gm-Message-State: ACgBeo3233cYZ0nXFq0ZjtySt2KC2AvtSVlXzbG8GEuDJhUhTmimn297 KLp2r6nODlqFKcuJwZpNzwE8aA== X-Google-Smtp-Source: AA6agR6CgY6b4wbJXemoxfp6L/GXP1ptnkEcrWxGnEEWlQ57O7w2lOc9yEmiwDdK056mFItPqrKlwQ== X-Received: by 2002:ac2:4e10:0:b0:49a:d44b:426 with SMTP id e16-20020ac24e10000000b0049ad44b0426mr860979lfr.234.1662963500925; Sun, 11 Sep 2022 23:18:20 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:20 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 21/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:27 +0200 Message-Id: <20220912061746.6311-22-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 87347e9c5f1c..296f503c1d97 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -53,7 +53,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -105,7 +104,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-9])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B849ECAAA1 for ; Mon, 12 Sep 2022 06:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbiILGUm (ORCPT ); Mon, 12 Sep 2022 02:20:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbiILGTi (ORCPT ); Mon, 12 Sep 2022 02:19:38 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 772172AE1A for ; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id u18so13146777lfo.8 for ; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=zWIyjK4dxfH9A9tyS53A/sJlwsqf8yeDaeYqVdTxLgc=; b=hpCVVDO6lm/ERZUqGXJ74SnKDvWrhTMHmEv5Fam/9wconDWlH0JRvADTQgdAPsUJJ9 IGTP8/gqha1csTIxGRflb8WaBi8mi+jJpu53V8O2LKO4tA6kcjh0a2Z3TKW2ZfywNaIS xh483O0miukpvmb+SSWep5RbHM8GSqzAuizfdCbMfT25qX6iLaahoI0qvC6Xi9vg5LAf o3IT4r2b8Y74FTGwOWSSJNKjIj2z4g6XAP05NbWYzO5tI9/VFqz0eIVYc/SKzwbEKWUQ Uvveo6ZruqyRw7m3J3Zb2IplLch2HrTmjNuXRKF5MGtWSzjTbFjaT7ldeH2QQDyEWlBG KZuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=zWIyjK4dxfH9A9tyS53A/sJlwsqf8yeDaeYqVdTxLgc=; b=65iAiBWU6h9yoTdKS+J8wO6upnSaoVbhhU4crdy1iktWTOS7nxiEVwq6KkWz9C63m5 CsWlizQJOE6YptqAUd1YG1NUt/lbJjsZEf4x2P+PpNTcsqseJQKs2LdyYJMW+p8UqhNQ ed4TKyGjz5Fh7WuhPWSjmc5Rrgn4bUuhByASQOkdx+DU/bD5Cn02/M9ms1XP24Hj8k4M ZdtADT8cdMIMX+enjIaVLTmqfprP41tu84jJtCma8kSB9SyZGY/XxaTRmgxlfUI37EAz BzeFxLYYwELiR1/BYH66d95BoEtniJB3kPBcml5hA40MXymlxKyTGJaT+Ya63IzwCVS1 nI/w== X-Gm-Message-State: ACgBeo3N4QLpByfu/LOBak9wnsNovfUhDHEUyKeAAHdB2NY7LjW2+UlK SyEoSpAJbSoxCDo4dIg9ccQOdg== X-Google-Smtp-Source: AA6agR5r3zi0vLyk+9FSxThtVD8PFl2WWjBbHuTJ/T97nO1HfcFmdyhBehkF/qXfvwHnllEZGutEMw== X-Received: by 2002:a19:5e5e:0:b0:497:a26d:89ef with SMTP id z30-20020a195e5e000000b00497a26d89efmr9255418lfi.555.1662963502031; Sun, 11 Sep 2022 23:18:22 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:21 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 22/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: add gpio-line-names Date: Mon, 12 Sep 2022 08:17:28 +0200 Message-Id: <20220912061746.6311-23-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add common gpio-line-names property and restrict gpio-reserved-ranges to fixed size. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 296f503c1d97..9cd97a467648 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -27,7 +27,14 @@ properties: interrupt-controller: true '#interrupt-cells': true gpio-controller: true - gpio-reserved-ranges: true + + gpio-reserved-ranges: + minItems: 1 + maxItems: 105 + + gpio-line-names: + maxItems: 209 + '#gpio-cells': true gpio-ranges: true wakeup-parent: true --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBD9C6FA82 for ; Mon, 12 Sep 2022 06:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbiILGT2 (ORCPT ); Mon, 12 Sep 2022 02:19:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbiILGSh (ORCPT ); Mon, 12 Sep 2022 02:18:37 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F40402AC42 for ; Sun, 11 Sep 2022 23:18:23 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id f9so12422482lfr.3 for ; Sun, 11 Sep 2022 23:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=zwTA5qS1hc7D78vIogufG1A3n3m88CDEiwTkMCUDUSY=; b=NDZd5eNQd/ivs/nVIC9+jVJ08nKEpAoyAwhRw1juzvmkT0Hwzf3F5/luL6s/GjkvyQ jKw5zrEGPEvwojwtP+s8ozkk2r7U98apViw+oVHKxu432P/r+Ti9dJpOodQwjxca1vMT +0NMs80i1YSJcBZ0hFOIdhFO+4nGMIP6dFt7jO6KUUXCWvrftuxXFDU39GvyBE0kI8ON dTDO5k72cnTWQqzq2z7Rx0sQfveRhH4g6JADB0BowhRHbo1OBPdN7emxV0rLTm8cxeim G3oJEkRj0HD3yGPLyh5teVSRyNBnpVXVElYHl0dZSIiqODL4f+G3d2Zf2/sEOkSe7ro4 T/gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=zwTA5qS1hc7D78vIogufG1A3n3m88CDEiwTkMCUDUSY=; b=NW9+8Ir3ThAxnN8g8eddlBGxEXx/L/N65vhEa39F5vamF4IcQZR380b2ilfoYdSjfK F+Fd46uqCC3xfxgmE2JXNHlzHx74f85b2YiXxOFSLTeBwKfWHEodlnmY6z1Um0W7xfs6 X7Pdf6zJP/xOZq1QGnzeIoaCFvICgaJxCiJdwPHva62+HJMHNdHLL7TaE4AJbirVafZS YlaVp12Fe2atiSbmXPav5oQ5fo/KpTcP3x4b56OrjtMV3MSobzG+YlwKRe0AhaRIPofm ++0wZjpOptAdxI6RsuO9yGKdSUyEOpp+cA2EON8Q+VyE5kaDlhsqJFzuBSioT6xwiNAq FwtA== X-Gm-Message-State: ACgBeo2JOGsyVucF/H6EtcumO1ksKanuoU3x+v1k4/dEWl4KheKG2uk0 5h1LmKEj9LxpMpV+ap1Ie/q62g== X-Google-Smtp-Source: AA6agR6ed2DHXO6r4Y3xKZSWqZRAbcp2otrsHX/5b3717I2u2EJGrPHBG6Qqasap9hgOmK6nKgPu+w== X-Received: by 2002:a05:6512:15a5:b0:49a:84f4:9284 with SMTP id bp37-20020a05651215a500b0049a84f49284mr1758805lfb.477.1662963503474; Sun, 11 Sep 2022 23:18:23 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 23/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: correct number of GPIOs Date: Mon, 12 Sep 2022 08:17:29 +0200 Message-Id: <20220912061746.6311-24-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are 182 GPIOs on SC7280. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 2bd60c49a442..76de3b1eb8c7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -60,7 +60,7 @@ patternProperties: subnode. items: oneOf: - - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-4])$" + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9]|18[0-2])$" - enum: [ sdc1_rclk, sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data, ufs_reset ] minItems: 1 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99140ECAAA1 for ; Mon, 12 Sep 2022 06:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230074AbiILGTr (ORCPT ); Mon, 12 Sep 2022 02:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbiILGSt (ORCPT ); Mon, 12 Sep 2022 02:18:49 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E3DB2AC46 for ; Sun, 11 Sep 2022 23:18:25 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id bn9so9325582ljb.6 for ; Sun, 11 Sep 2022 23:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=7otNZydIIUOO98pahjg4CEuB5+Fq5/uSk8VTmLsIpzU=; b=y1PkTbkfQaEwzE8pqTvXXEqqyqgNCrhlTm+WskqwrVRcHgZIYMYePo2scrKwo8Ecva LvDAC8NGymufgPa4qEORDD/Wrq5CrWBWa9E+oyAnQPx7MmmwGinLriWtg6V8WCOQQ3fl I2sKhg+kVac8Y5/tnJBTChOa8UrscNYu1O3nVa2hM6+iJ/Pt9EhIEtWL+T2MtBJaBaTX AQQA9ud55nUBZurgUa3xNwm/CLLgLej9tnvGgeKGG0MxkPPzXZD7RvD4vLXhVK6QSKlJ JbrvbYONCzrPcZD4dQroI+Jyg/ZyUW247d06MWkK+JpW5GecpmHirw37alQZmRSfS4YI fhUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=7otNZydIIUOO98pahjg4CEuB5+Fq5/uSk8VTmLsIpzU=; b=Duc296giqeSxhXhvIAbq8YAKbbLGcVwBogmdwQUb3wXRyUt97k6TL7ibUMYBRQ41iH 7jlssL2exYbV3geWzlPS4EsxmptTLtJKSDiQ/NVVYQzO638pu0CwErwnIQw5d6c5fJkV 926Ev7FTfA2E+3kjiUY8BzjjwgS35Bg9NkDImRsKpCfiUYLFVERP4AGSbmGIl+lGborn HA+lXdgzy2PStHqx9CaPbM5mjPxc5U/RI0Roxmn4L84/RjZIhnNP8nUN7j494GrzOzOr CZeuVyeYbz4Hl/2hB9k08VCU3CjeMwpfbwWf1MZapq/DWtolbWlRtaNwhF/1dA5UNNIA TmAQ== X-Gm-Message-State: ACgBeo2gWjGVbG1PiKFt3g2SYOK2QQ7hV6pU1YHeiTCHtJR06IH2ZRBU utKmJTeXHewt+zYDDSjpDDoxBw== X-Google-Smtp-Source: AA6agR5L+ws1m3zLWS/oH5Zrss/Tfueo4yhHwoEwx2izoi+tIo4sz1GHBrQ+L4BNJhVVth2dfNz0ow== X-Received: by 2002:a2e:3817:0:b0:26a:d369:ca71 with SMTP id f23-20020a2e3817000000b0026ad369ca71mr6775219lja.191.1662963504669; Sun, 11 Sep 2022 23:18:24 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:24 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 24/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:30 +0200 Message-Id: <20220912061746.6311-25-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 76de3b1eb8c7..b12e738cabfa 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -51,7 +51,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "/schemas/pinctrl/pincfg-node.yaml" =20 properties: pins: @@ -118,7 +117,16 @@ patternProperties: =20 required: - pins - - function + + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9]|18[0-2])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C138DECAAA1 for ; Mon, 12 Sep 2022 06:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbiILGT7 (ORCPT ); Mon, 12 Sep 2022 02:19:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbiILGS5 (ORCPT ); Mon, 12 Sep 2022 02:18:57 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 329FD2AC50 for ; Sun, 11 Sep 2022 23:18:26 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id a14so7213510ljj.8 for ; Sun, 11 Sep 2022 23:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ecN/gYWUwSiweisrF7KuYwKYJSjUztD/7vYHklQvBvk=; b=IlYDGyr7po16zCLurzL0boVCWpIe2vQrGdxG+n1Dkwb59cE5qATQprDA9UG/pjEjbw ic/0lzmV+44/3QvRGjNPtiPoxjzMFCKBJXYnfjj02xAn4CXb+jyAcLDOUZDwEjVoIBec 34oR1ovQ34/8UMdrKNYgTwpy1BDwEzdd3xfZpiVcDZ8Q/0r0KBPBPHjAxT3KyZVRi65k kDRJ5pDZwqeUnOl4q7dhX+PjXR21GDTorw34XLj46rehoGnqUP8EY2yuT3BmhM54I71b /QkJeO1yf0RTr8JTBbjMkxCuXeW32D8gBkhHgSYCfQxFLYk06Qa2LGVuHt4X/9CaeDB3 KmuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ecN/gYWUwSiweisrF7KuYwKYJSjUztD/7vYHklQvBvk=; b=g3AaSkTSwIbOpVsqEFPZIPDbxqZOpgrvI/EBSW5rJmbR+y1T7ghwGwERCzEB+C7Qb4 k18l85C2dQbjlumIHYLQ3zu9Kg1zuommcgrxdGz0Rkp4bpysClnIROSTFwf6BRTbgkYr 6148N7jgdIm6/TKxSTnWKMp4/JOhpbvG7G6G8X3eGbzptXS96MCMvwqIJg+R3Inz9U9a uxFFSh5BY68O+5rbWDFa7g634QKz2NsgnW3rhKF35YjBu80m6p42K1IFiwVK1sry7C/N f+dUaHBpRWs3fEF9H7L65ZZB8DSHcZplNoEyYLgPOvqkWqvOfg82K8nIFIoboTObaUNa fMGA== X-Gm-Message-State: ACgBeo1d37T0TPOXDXFbwcRcxqqvNs9FyO0Sye0H8Cqz7ImJwlYmv7vo oJEWTCx0T+RYWCYNIRsop7rKCQ== X-Google-Smtp-Source: AA6agR5WeLK4jOC+RH7LR6VxQ2wxUntjRu8GCITTJXfjC05e3A87axkbjrtO+q4v9lFP6N/4UE+QUA== X-Received: by 2002:a05:651c:551:b0:261:dc64:8027 with SMTP id q17-20020a05651c055100b00261dc648027mr7888259ljp.272.1662963506450; Sun, 11 Sep 2022 23:18:26 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:26 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 25/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: add gpio-line-names Date: Mon, 12 Sep 2022 08:17:31 +0200 Message-Id: <20220912061746.6311-26-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add common gpio-line-names property (used on SC7280 Herobrine boards). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index b12e738cabfa..463f2e95e237 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -42,6 +42,9 @@ properties: gpio-ranges: maxItems: 1 =20 + gpio-line-names: + maxItems: 174 + wakeup-parent: true =20 #PIN CONFIGURATION NODES --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DC1ECAAA1 for ; Mon, 12 Sep 2022 06:21:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbiILGVR (ORCPT ); Mon, 12 Sep 2022 02:21:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230135AbiILGUV (ORCPT ); Mon, 12 Sep 2022 02:20:21 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27D512B1BC for ; Sun, 11 Sep 2022 23:18:53 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id bt10so13202071lfb.1 for ; Sun, 11 Sep 2022 23:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Kly+7x9ihf9PeM0EfSaLRyWHlTHThn1xyufL9SH1Mkk=; b=xeBmlterGWh/U+JS0vtsstUra2lrkbxnYk5rWcBKrHL4zZHPzQwCo9nYmNZQAxIkjK 6VFwPt8WK+FDmuCPmaDTrSi1ZLDeY39eECCX7bA4uBCDju99EpmH9GHZJuUdVfQTOY9g sT7zpyYE/CEYlb7UaJpwNjWDztGJlj9V+9rOT4vd9Rzl8+YAt6iK/pMPYyvK2rm5O86E Fxp/Ilz3JM22N3n0rLe0+BwrnjqYZokpG6GDz8GqCNuBoItMuT2LEIPmKToRWTmYTJLw XghwlTnfKpgZ2bTtFXVg7wr7KExiMichaC3ZFk2KBN7DjD0vQ8othz01kg8g2mH68dB7 1muA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Kly+7x9ihf9PeM0EfSaLRyWHlTHThn1xyufL9SH1Mkk=; b=1ODN1J+xmYzux5WA+weOoT+KKx6Pv8IaloSD0a576ciU1xQmyHaQlTH0ZVhE0EZAzz T6luLbNdBOFUS4AwvJOrzKJvfw5prEy36qra3S+fsWy2ND1O+rzPafl4oKKVRsVZxXnJ TQ5OQVnnO53QQ7r+yylcLZzg3QzvE/AriaMG7yVQ2nRccK8h+RNvDu6XBIfgn5tiWno4 lCnCOCRzi8hXHLtzPF4EWMVd2o8yNAiIDcAe3xvEbUP6GOoJQCEi0f6m/mAZVTHCh7CG ssNgvCuHc/0qaZ6pFXUKHn3VCiFwXbcXSCZkbJnRQsu3PB3CnZ73K/SNP/gdKwxf20Lo tYUg== X-Gm-Message-State: ACgBeo0ZsqEcNJtwp40ewjtqJhd/sohl9O9+HCitbk5buke27HWLWt6/ X7qlQvatA4BrxAsHxLpRpEu0xQ== X-Google-Smtp-Source: AA6agR7dtmvrVPKLZRJ5GpakNOHSirzshDenRP6aJbciJLYjckp97je3Um3P2uaRiKUxymcGijX+Vw== X-Received: by 2002:a05:6512:a8c:b0:491:d4b8:47c9 with SMTP id m12-20020a0565120a8c00b00491d4b847c9mr8018352lfu.258.1662963509810; Sun, 11 Sep 2022 23:18:29 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 26/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: reference tlmm schema Date: Mon, 12 Sep 2022 08:17:32 +0200 Message-Id: <20220912061746.6311-27-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Qualcomm TLMM pin controller bindings should reference generic TLMM schema (which also pulls generic pinctrl schema). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 463f2e95e237..2ad79029d9b0 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -134,7 +134,7 @@ patternProperties: additionalProperties: false =20 allOf: - - $ref: "pinctrl.yaml#" + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# =20 required: - compatible --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D78ECAAD5 for ; Mon, 12 Sep 2022 06:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbiILGVL (ORCPT ); Mon, 12 Sep 2022 02:21:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbiILGUP (ORCPT ); Mon, 12 Sep 2022 02:20:15 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EEB12BB17 for ; Sun, 11 Sep 2022 23:18:53 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id k10so13154855lfm.4 for ; Sun, 11 Sep 2022 23:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GuYszGqRUvgj4iSIWHANYUWvhVnhTB9OnVeXvHTw1Z8=; b=WokROcTL8/yBzzsDBvVCTM0Y0+RbY9AuLJwSynt63bAxNV6SvoUh+UOejSoGS4XaUr UqtkazUKgIxgiJ1hLKzRxGAxRSA3XzX5F3OxOxquL7l0FtLl04n11EZ+X0/oNrh0oVf5 6znwMuihyE5TPIwsRYxILuJ2QRGEGajIlIosD/D40qYx1u8/zt2foQoai3cqtOmDRqgy k2ftL43JBKwem6UQW/ZbjR6VHX6rmVRUQq/zu1P/hHxIjwVlEW8sPzRBTw6/mjhpClua IfIa19CMGcTnyWZOpl9zf8UA+dWcitf4EMah9tO6Vmkn/dvNMlgAk+7qMKsjo8IycgH9 3MMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GuYszGqRUvgj4iSIWHANYUWvhVnhTB9OnVeXvHTw1Z8=; b=QyJYsmmLZUeIxG4ad5PL+1MShZ42YxYeGVVS/uickEsM6sFmKwPSsccFfjtbdKPNWg NOIZzU8mKyqxyXz2pJsGLx33J3XxFWn1mFR3tQK9acl7k6H+qegWSzHAK/rchtFrJsFH f+Z5YCy4Y2zK8Msxn5rinblQOJBzxwBWoCYZiQq02oNflllKEF5EaFsHpuRfxJwfQ41T SBbS+RFCTK9z8ydAzfegyejVQVrR4aYXgIV8+RbXyTjS3G+ZuGhyuvE5Y/ioof1FhhXG Xasn4k2qBuNdRjRUDVZtqc9X40ggXM6pxlS6B5CAJnn2FjznZS7Ze6Botz6V/jIAhgiV /WUQ== X-Gm-Message-State: ACgBeo0LjP3hzSV6OyVMWW7KNa0KhAMUrsiHt42JJei0/XQ66NgCma7t ZyVuoZqBaGBl4z5qqo88l484Rw== X-Google-Smtp-Source: AA6agR5oJOWbVa1PdbQ1XCZJ3VJHS6tgg1+MBOSg3drRcILNTZFp/4A7Ah3vRwovv77AcFd92qjd9w== X-Received: by 2002:a05:6512:3407:b0:49a:4862:965b with SMTP id i7-20020a056512340700b0049a4862965bmr1895628lfr.576.1662963510939; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:30 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 27/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:33 +0200 Message-Id: <20220912061746.6311-28-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 2ad79029d9b0..ad3496784678 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -150,22 +150,22 @@ additionalProperties: false =20 examples: - | - #include - tlmm: pinctrl@f000000 { - compatible =3D "qcom,sc7280-pinctrl"; - reg =3D <0xf000000 0x1000000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 175>; - wakeup-parent =3D <&pdc>; - - qup_uart5_default: qup-uart5-pins { - pins =3D "gpio46", "gpio47"; - function =3D "qup13"; - drive-strength =3D <2>; - bias-disable; - }; + #include + tlmm: pinctrl@f000000 { + compatible =3D "qcom,sc7280-pinctrl"; + reg =3D <0xf000000 0x1000000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 175>; + wakeup-parent =3D <&pdc>; + + qup_uart5_default: qup-uart5-pins { + pins =3D "gpio46", "gpio47"; + function =3D "qup13"; + drive-strength =3D <2>; + bias-disable; }; + }; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD27ECAAD5 for ; Mon, 12 Sep 2022 06:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbiILGVW (ORCPT ); Mon, 12 Sep 2022 02:21:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbiILGUW (ORCPT ); Mon, 12 Sep 2022 02:20:22 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F20552BB20 for ; Sun, 11 Sep 2022 23:18:56 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id p5so9309160ljc.13 for ; Sun, 11 Sep 2022 23:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=isoYJKBwL9O1ZTWOtoJy6YqcTPPUMcFYuBQOWK2a8G0=; b=Sn5uYWupsTjYshBneVtvzhVm3tf9tCxdh4UlYVFBt+IUS0/qO8AZG6l1xAt8OTwdcw LqSgZqKAY72eXW7HIgMULuiRS3xGprajeZGJiGeCelFx7FciQ6ekWDZRaV8/z10dk4gS 127eQTscFSplDtvT8htQc83JifHjo++wfC1ErJCMomo10pyjyMeliT0Iu/Pc69Cq7JTf kkzYKb2Zh66/CVOvi25eYko/MCV67RJbLzmpxKnHCPokSsNSre0NdELFow6p5CRQ+CDu d8hREZz8A0EG//L7Kr5EffVi2u2ONDT3bjh4v7h1YagyiR6TD43pdXyGcUg74p0EUZs6 /ZBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=isoYJKBwL9O1ZTWOtoJy6YqcTPPUMcFYuBQOWK2a8G0=; b=x00GH8k0oeMbV+C2t33Y0Cxf8O04q7E4EK4El9FDefa4tGKXGZtgdPwxc/JT1IkkSP YRtfMQ0XScYrt9rIG90cBhKFiTpZRK0XshM9EBxC57Ft3u8v2IbWY929Y2o64BZn12DX y1/KIInjNd79VucM2nA5is8FDarJnUIWew2y/vUkUUsHnGDXp3MflTdjbftbA43sTw9c hdkgjoIDnMOA38pDfqiu53TX6LlA4d4x9I4l6Jk+Q+izVTbqDiJLon1HFhXAsS/Umt8F fq1QANZX8OGzet+uVfoi+I9qjjsxu0Dp37NtjpbbnB5UtzS8RbQUTo9BxiHtohTFgNvX p50w== X-Gm-Message-State: ACgBeo3C6z8kMcjcOMCFr2UsirmMSnAjcXHsr1cQFctWLWiqicbevxJ0 Ll2iJcyuxatuhJnP0qtu+pJ8LA== X-Google-Smtp-Source: AA6agR4xwxfcUqidIq62wQLoSkaPFn1oBOsoXm32yp4o95+WVvQIOqMOm3t2WCydvzEkLmkKr0zW7Q== X-Received: by 2002:a2e:978f:0:b0:26a:a62e:8f2c with SMTP id y15-20020a2e978f000000b0026aa62e8f2cmr7369259lji.153.1662963513116; Sun, 11 Sep 2022 23:18:33 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:32 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 28/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:34 +0200 Message-Id: <20220912061746.6311-29-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 86509172603d..646fabdf81f7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -51,8 +51,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sc8180x-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sc8180x-tlmm-state" + additionalProperties: false =20 '$defs': qcom-sc8180x-tlmm-state: @@ -137,13 +138,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio4"; function =3D "qup6"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio5"; function =3D "qup6"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28852C6FA89 for ; Mon, 12 Sep 2022 06:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbiILGVh (ORCPT ); Mon, 12 Sep 2022 02:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbiILGVD (ORCPT ); Mon, 12 Sep 2022 02:21:03 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11B5B2C10F for ; Sun, 11 Sep 2022 23:18:59 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id s6so1946199lfo.7 for ; Sun, 11 Sep 2022 23:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Z/95Brm84Hs/a3P501KqW9gtmX0Qfi6hmXE/MDLL0vI=; b=PLoAGfgYNr7od2O4N2jBATlyy9GsidtsOIMLThrsH+SM3UaH/dbI0LB74rLQz7mTld BXMJAwXOEC+24QzIPIaMlrAcZTTiWY4OgQDhPMxzxdtgEULAWYZvemx2eE3TBxKA1OSg F0plECT478eM9Y7YmoosYIi+S49h+4fb7ZJqaCF1pH2q4T9gA36lsULF9RWpN7oLFSCW VRTDRuhFLxE7eZ71cXkrLSyH8nCfNfJoFgB/CbGB5FEmaQDNzYDSli9PqfiRUzSC6nq4 0cJFwnb4PJmd98hCiAKVjbdR90vSU6SpukpLUGdvA0rMCJcMrsk+txXTzVVTSN4wmqYe JYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Z/95Brm84Hs/a3P501KqW9gtmX0Qfi6hmXE/MDLL0vI=; b=RdMsLjE/7Z5DhxKkrVBq3JXgYcwkhMC23hsCyUhbtoNrYtECH1im3eqNbprlZYKD3G b3GmUBS/mSsKXVgc60CiwEB2tpU9IidknLUl4x6V5HiliTxYdpn8gUf0HMgobws32Csd K8NnvUDrAyrMw0EI8n/ZFbVOm3K/WrTW8XXc9c9AoSpSoiZ8gaI0/mvQWzy6jWGm9MaK RuhrBU+fUynsrpGhEZYCq2il4q13Mv3NI6eGwbf4obkX9gl4MqtEXuiU4EsHDjGupwY/ MZpUPpFS2r+4zaHRM7sC4bbekQOcs6LLoYGYcMPtYYR25uG5X9MVO/V4o1yn6t0Uxnzc kjjw== X-Gm-Message-State: ACgBeo2EDDDkT/IQf9XWzj3mMcU+PM+77cR6jJ5l+VQ9CKXMYYI2URH9 pn+MMZ5Hv8KTkVWEwtDf/3tnOQ== X-Google-Smtp-Source: AA6agR5oG2zgeaH/mojNn55ZSx64wxS+B+6Ny6B04LZFluXVKFQhqrN6oR2dY8galG82Ymg64bJlzQ== X-Received: by 2002:a05:6512:24b:b0:497:a7a7:2ddf with SMTP id b11-20020a056512024b00b00497a7a72ddfmr8890896lfo.379.1662963514996; Sun, 11 Sep 2022 23:18:34 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:34 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 29/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:35 +0200 Message-Id: <20220912061746.6311-30-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 646fabdf81f7..4afe20bac87c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -61,7 +61,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -112,7 +111,16 @@ patternProperties: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-8][0-9])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8968C6FA8A for ; Mon, 12 Sep 2022 06:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230004AbiILGUU (ORCPT ); Mon, 12 Sep 2022 02:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbiILGTR (ORCPT ); Mon, 12 Sep 2022 02:19:17 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6652329CA9 for ; Sun, 11 Sep 2022 23:18:37 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id a3so1167933lfk.9 for ; Sun, 11 Sep 2022 23:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=nXdmZRWySMH2y4BHslWMyDvfmlDcWpCDzcQgKmezSiA=; b=aS+agOqhWINw9MuAJ0n32qJeHyY3pODek/iNq3Rojv3DYFvibsVMgg5Ku/4AwlqjKS yUX1g0w9BfjFNhByRz4ypR3sjOe976/vzTOP3MHbTCI9TkaPlrZKI9mHSaJ+9nz96KQR Dqx96gtCyqAdr5ltVbudxyFj3SeDsL0nWPL8eb5Fwb2BDPzlg4t0dyn8BNV/bY5jz7Br SCMQch7z2wWWzy5vaCDpDFeaKvU93G/K2PVJr07EEH07WVaLnD4zxaVuz4aOgfE/9iw9 9WVpDL82VrfX5xN+bDgXCG9mxqNOm4ZUnNY6/PBM8IECQrEnrDYA62L37EUmk+DbVNQg fKZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=nXdmZRWySMH2y4BHslWMyDvfmlDcWpCDzcQgKmezSiA=; b=mBoY4k7DeygJAAjQqNmbCZiOePP9D7DyW+6KvAVPAqJZ4HGuOiNNbQg5XukWU3y4af ieHVtsuy1aU4dujpg0HjtSXlRk550oO+vSL5fbNVIkRvRW7uYJSwvqYQYXEOLNUF5TFy mGl8M1794YdBugXZOTaN5o4ga1KOnDpf4rantbkxX1nG6jhAZtslboQEpP6PjOgo3rol 0PzjeBcyLxG6NgUGwTRdVYyfsR1wHzykyKeO25nqNqPGlOxS9mgzQARFbi/ISqdaohQY gMzocqSi7kxOQvK9J9J44gXqX1CCeH/FoyXF6Qu8LCeP7ADi/wAT5kRrGViHj9vdubgr 1TxA== X-Gm-Message-State: ACgBeo0bUXiWlNZIYL7hmvD4IBkc6fglGUoT/QTiat1dpU0RZB32c0vy P13LTkgr+Lsxpd58Oj/3eHffrw== X-Google-Smtp-Source: AA6agR45OVFDsP7/GSM/ZCIfw7CKomhVPysvR/TQNc6CDDrydTsLOCiRTXPAkluJzMM6x8e58vrekg== X-Received: by 2002:a05:6512:682:b0:49a:9db4:5a3f with SMTP id t2-20020a056512068200b0049a9db45a3fmr1641603lfe.214.1662963516774; Sun, 11 Sep 2022 23:18:36 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:36 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 30/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:36 +0200 Message-Id: <20220912061746.6311-31-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../pinctrl/qcom,sc8180x-pinctrl.yaml | 64 +++++++++---------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 4afe20bac87c..b98eeba2c530 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -126,37 +126,37 @@ patternProperties: =20 examples: - | - #include - pinctrl@3100000 { - compatible =3D "qcom,sc8180x-tlmm"; - reg =3D <0x03100000 0x300000>, - <0x03500000 0x700000>, - <0x03d00000 0x300000>; - reg-names =3D "west", "east", "south"; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 190>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio4"; - function =3D "qup6"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio5"; - function =3D "qup6"; - bias-disable; - }; - }; + #include + pinctrl@3100000 { + compatible =3D "qcom,sc8180x-tlmm"; + reg =3D <0x03100000 0x300000>, + <0x03500000 0x700000>, + <0x03d00000 0x300000>; + reg-names =3D "west", "east", "south"; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 190>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio4"; + function =3D "qup6"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio5"; + function =3D "qup6"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C722AECAAD5 for ; Mon, 12 Sep 2022 06:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230283AbiILGVo (ORCPT ); Mon, 12 Sep 2022 02:21:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbiILGVL (ORCPT ); Mon, 12 Sep 2022 02:21:11 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2603A2C138 for ; Sun, 11 Sep 2022 23:19:05 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id f14so12194196lfg.5 for ; Sun, 11 Sep 2022 23:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=bcVZH+vM6VlPj46aHm51wHDmSEBgcg+OmD5GfgTxNm4=; b=IOYLQduKDVqUl2FVMPccdSSq4RPfytAj5bsgcI/Uaj/+kjB/Rlsv+dnvKW0O+wmtlO nsk2UpQKYauZTfMFSGRcTCzzeN74n+6fyXIO+Gx230ej4/RYnBItA2zoyh6JiADlCWlp 4JzDVoYRjQEEbZLY1AX8sxtcJRztvl8fG3ip1M2MwQs+XK9kjCnDQtM+THV/H7aRjkOM gzuyuSzE5xGOSsShos85ncbYSxdoGAFw4T0i64nkWPLYv7MfzlhD/TiCFqug+nheHgIT g9k9DFBRgl/NLcLoEtSugSQBDjYIha+FMBwO9/JClQ7sNe65zfZnPSvClwnGUAg1Trfb jeHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=bcVZH+vM6VlPj46aHm51wHDmSEBgcg+OmD5GfgTxNm4=; b=IyXShX6nhPpRBW7Luq6oh+FGDERcDi8+oIQRHR6QHM20nA4wRl7sKgmf8Kgzgv4vEQ FG9/SdXxkeFgFT/RWA7xDdZKdtWlfrsZ5tYYztGXkxZ/A2t2Za4oA/AVRxgCqHjtIyTb zbnUexGE/67mddIpRI79Qv/lAlJKhTO69kQBWa0kJ2wPm9jZ8BgCFvQFWfMsjLkVJLIZ ZicDEuBvmomea8OX1uT6ShybLS3qfwVxc3XruQOMVk24ohU/zL0c70EJb86PCg1gQHrK ygQykG0Lh/jdqNgo2Gq8wr3UhpZwoTQ5/4ULZjBsVZgwXDRcZ123vl2ptWzycXCfQzcS fngg== X-Gm-Message-State: ACgBeo11hwRxLDJcTNXAQ4l8pQDExj3psV7YKxLLb/vjMbz1fQ9MFXmV w1zv6wjgxVmt0nEsshJRfvCWvg== X-Google-Smtp-Source: AA6agR7TCoX/JggyD8QfNFbQxY7SgJBZR67pv6AvYZGTLMbK2RzG8EEmdtkEnjQDS1+gpUS8RPmq7A== X-Received: by 2002:a05:6512:3b06:b0:498:fa72:c24d with SMTP id f6-20020a0565123b0600b00498fa72c24dmr4978910lfv.538.1662963517852; Sun, 11 Sep 2022 23:18:37 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:37 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 31/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:37 +0200 Message-Id: <20220912061746.6311-32-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctr= l.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.ya= ml index 87a381c9a19d..5147afc28721 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -43,8 +43,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sc8280xp-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sc8280xp-tlmm-state" + additionalProperties: false =20 '$defs': qcom-sc8280xp-tlmm-state: @@ -135,13 +136,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio4"; function =3D "qup14"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio5"; function =3D "qup14"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BA6ECAAA1 for ; Mon, 12 Sep 2022 06:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230086AbiILGUc (ORCPT ); Mon, 12 Sep 2022 02:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiILGTS (ORCPT ); Mon, 12 Sep 2022 02:19:18 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDE9E2AE2F for ; Sun, 11 Sep 2022 23:18:39 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id v6so9374191ljj.0 for ; Sun, 11 Sep 2022 23:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=XCpzuH6l9uwERwbmApSAocGpO1WUQ+kJaH+BaZZ4Pgk=; b=jtakP6ORWyIKPUpkfqal/BV/8/ncUpbuF/5f34Fj9guQlNdQkZWt3NW9uM5z/4dA+Q bk/EgTX/eS9uwqh9E0VzpeV3+t5LfhSDSBe3pFFHuM6IZh7ZzimhHGoKLFNrGY+VOxIM 5Q4Dq2dzny2t6jYuBcPQrjV+DS6WIEONEYjqdsLb+VZdZLHHMiUDqaZtdMgRURp2W33i mzeyml15vQ+BKAhYTYqnPqtjqlY5VouichDNzKL4BWZpjkBkitJaufC7NdSN9LfMOytL mBfR6ETq0FI2E9URYaX81M1b20WZCat4TS9yfNSGdcTjVmiyE5OGQIpZzgMlrLM/Jtzx NO1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=XCpzuH6l9uwERwbmApSAocGpO1WUQ+kJaH+BaZZ4Pgk=; b=mzSbpLwdYyPzWRdYw82beCwxgFv3i+3zanDCJU2JH2iB0ch9/DMLs59Ay93IooeFdB ElUxzKBGMrlVA/K1uiN0NQgQUCkpZDHtgPAvEKJScbgLmQx81u6wKuS6nwqFdVmxraMo tFvH4sc5se9d05jzNyAGXGO/G1v0r1iYouBGTYBg0nKSEHZ30AS+HL/3Q2tvhNGkGYis yusLEBHQQR5bg+XqL0b8y59zTIOtayOVDX17mXi51GdMOtO9fNrWgml8U+bPr/EeopQW KF30VK74Vv4sqFQoxcPSV7kPgpwORycSp6qVFDytUHIk8ELQrikozcr/avOQABhdUjbG lbqw== X-Gm-Message-State: ACgBeo3UqwgsPNvhrpScdbo6k0J/GDUO6xztyXkJWR9CKCwm/qqqXFrC bgYfR29xUA2GbRVp5r6NkOV63A== X-Google-Smtp-Source: AA6agR6gVvk+wjJcy+GsVuOyXfIuM6E7NgxSoHfkKTcN9oVF2DXgcCNIutIim0ZgRFH40l3SGXWrdg== X-Received: by 2002:a05:651c:44f:b0:26b:e48e:5b4e with SMTP id g15-20020a05651c044f00b0026be48e5b4emr4377596ljg.314.1662963518967; Sun, 11 Sep 2022 23:18:38 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:38 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 32/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:38 +0200 Message-Id: <20220912061746.6311-33-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctr= l.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.ya= ml index 5147afc28721..8610f2701388 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -53,7 +53,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -113,7 +112,16 @@ patternProperties: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-1][0-9]|22[= 0-7])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0C6ECAAA1 for ; Mon, 12 Sep 2022 06:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbiILGUf (ORCPT ); Mon, 12 Sep 2022 02:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbiILGT0 (ORCPT ); Mon, 12 Sep 2022 02:19:26 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D22592B193 for ; Sun, 11 Sep 2022 23:18:40 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id s10so8702516ljp.5 for ; Sun, 11 Sep 2022 23:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=691KvJvip9wejzXr7qpWGsmceASveD6n9KP/WuDonD8=; b=d1DHQPk8TiATnt/m6mMQt61SUjKvZhpDvPIkhUG2xBhT2q7YegT1qS0K2WLyXviV7p MBPpZfjbJprK7gQU4RQU3ULzM+eRPx6UwyTgDDq35YgH/1oV3YmB3C+0f+h4LcvWS+yl kGCmB4XV1ADWqH//Z2TdMauEX01fJNC50nqadf+mOZL75OPAj1UrvrXM7jYPWJ6Q+xhK vqvQOg0iOoCRIsamcHzrXhT7qTVd1bvLT8fK7Mk5jPgqqfGvvyn76SgT3jBs7kGFBOVz tElvW2mJBXv0H98qeRcgkgvgKJWOwjRFFJSQxA1eRfOZoaqKJNYxoB0fTS1R/DmMzGoA ESpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=691KvJvip9wejzXr7qpWGsmceASveD6n9KP/WuDonD8=; b=L8cxbGHxZH3bXKYecu0p7r/ofY5PwPMNAjq4aVKsmIplK/oXIioCey64fJ00Vew+IK qU3hWtseuN4EEP91aMTf9nzT/mGexvmwzOJRziEi8kjou88inxoHT+TGU/gp3nrDW3Q0 vTFSV/0h1fxQKLSIw5Vb7Z6sq6dgZD+hiHiKwFXSrmXdBFKQqIqPzMqxJpSkWM0NkRb/ fO0O0xNF27jxdZYHN9sdgfgnloQJpgqVb4krHY7e+Vt8MN8IbOTxvG5R+HWzR2JPF3Y6 EjmfQuytcCqITU5scj2OzyEF9KrUmc//9wAzSU6awSUBldg5xckO3PHjpBjlOxUSY1zY zI7g== X-Gm-Message-State: ACgBeo0PncmSwqBBAV/IyJhBL3eNmt+UVpFy3JCCo4lN/h4MTZBgpZjV cCIxB3K/IrD75vCmUFoKUPNB+g== X-Google-Smtp-Source: AA6agR74Ig3J9SSX0nqCYqvR7QrLh5RKvXE1wOuQ5kJ/yx4ASKopm0Acvfok/VWCHRj9SPWW23EXhw== X-Received: by 2002:a2e:9cf:0:b0:26b:e127:df1 with SMTP id 198-20020a2e09cf000000b0026be1270df1mr4921166ljj.325.1662963520191; Sun, 11 Sep 2022 23:18:40 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:39 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 33/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:39 +0200 Message-Id: <20220912061746.6311-34-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctr= l.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.ya= ml index 8610f2701388..b9ab130cd558 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -127,34 +127,34 @@ patternProperties: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sc8280xp-tlmm"; - reg =3D <0x0f100000 0x300000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 230>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio4"; - function =3D "qup14"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio5"; - function =3D "qup14"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sc8280xp-tlmm"; + reg =3D <0x0f100000 0x300000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 230>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio4"; + function =3D "qup14"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio5"; + function =3D "qup14"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46132ECAAA1 for ; Mon, 12 Sep 2022 06:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230293AbiILGVt (ORCPT ); Mon, 12 Sep 2022 02:21:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbiILGVR (ORCPT ); Mon, 12 Sep 2022 02:21:17 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8B632C643 for ; Sun, 11 Sep 2022 23:19:06 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id p5so9309508ljc.13 for ; Sun, 11 Sep 2022 23:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=e91Jrvw0byDqU3CWt6E5mPoWrF7xdNn1DqHo4tKVYDs=; b=r13KarNKK5ee3JgywvFlXLxKsjaraY1VicrvUPbB9VD8UJfG2zoVaqOKpy3NpmT7jz yFDUpkEtnYRb0TCmtyWSAuUws3fq/Xjg1PGO9Q1L+fV+AF1mMfKmRSjxDAs61iwkv6ha +xs28HP+fPMNtZo/8km1RpdfUjbSTjkctGLmw0+C8CAJ+asTfrIqI9n9erJivduaMs2K n8YOHhZbK+JdWFSAdeD7YpH3veW+IMkFfky+9bOjtKQf9D1hISMWYd9a2sAQQBtvdXig nbyv+E8LEkGnNHmfGH/1GiWlUNUXBoeJrVGkXxluyHKOnmjwqa2mMEZsw7vVP6ebzpm7 eRCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=e91Jrvw0byDqU3CWt6E5mPoWrF7xdNn1DqHo4tKVYDs=; b=7rZ1B3ijskk3emb28t4AYp4gkwJLA9AA1P/3PS8ZT7Avf14upJ3VQg10EgDrzeomFO drkRcLN8C62AJfvPfNmBjLTTAqU7R9NU/BbpEbGRHgXKOq9G1xHc9n642wLa7tIqMeKf 6w8j8heJmhLGvrfEy5KQ8j8KvtCFn6r0gTZlz2q15qsIMQCuQlGWYnCZ4WA+Nc+Z5G2N 5TchetZQ/El1vJJP/UbCyjboSRiCRHosbb/AW8nFVImrn2u5aZTm4HtuoX8Gz8DA8K/a GPTccX9/ksIrwvRsEN5P1aQgidTJ3QoTRypfNIT1syXB0+MbKC++s7pVNPAHb09UJpkA GZxQ== X-Gm-Message-State: ACgBeo2UM/GxAR/C+ozX7G9Tm+83cg1yiyZ7pxESN93vJJmKEgP7ZVNI K2VljQF4gcIX7G0UGIlr6130HQ== X-Google-Smtp-Source: AA6agR5c/r/NiSr82VLsI6pynDVo1A+HrcRDt4+K2JA3uy3KqvQ5lMGUKNHcAxjzW8UzH1/i0M2ccg== X-Received: by 2002:a05:651c:88b:b0:261:ba8e:717a with SMTP id d11-20020a05651c088b00b00261ba8e717amr7168298ljq.401.1662963521401; Sun, 11 Sep 2022 23:18:41 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:41 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:40 +0200 Message-Id: <20220912061746.6311-35-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 4 ++-- arch/arm64/boot/dts/qcom/sm6125.dtsi | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b= /arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts index 0aad2e94e757..6a8b88cc4385 100644 --- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts @@ -87,7 +87,7 @@ &hsusb_phy1 { }; =20 &sdc2_off_state { - sd-cd { + sd-cd-pins { pins =3D "gpio98"; drive-strength =3D <2>; bias-disable; @@ -95,7 +95,7 @@ sd-cd { }; =20 &sdc2_on_state { - sd-cd { + sd-cd-pins { pins =3D "gpio98"; drive-strength =3D <2>; bias-pull-up; diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qco= m/sm6125.dtsi index 8c582a9e4ada..1fe3fa3ad877 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 { #interrupt-cells =3D <2>; =20 sdc2_off_state: sdc2-off-state { - clk { + clk-pins { pins =3D "sdc2_clk"; drive-strength =3D <2>; bias-disable; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; drive-strength =3D <2>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <2>; bias-pull-up; @@ -413,13 +413,13 @@ clk { bias-disable; }; =20 - cmd { + cmd-pins-pins { pins =3D "sdc2_cmd"; drive-strength =3D <10>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <10>; bias-pull-up; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FB8ECAAA1 for ; Mon, 12 Sep 2022 06:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbiILGV6 (ORCPT ); Mon, 12 Sep 2022 02:21:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbiILGVS (ORCPT ); Mon, 12 Sep 2022 02:21:18 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2584A2C658 for ; Sun, 11 Sep 2022 23:19:08 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id p5so9309547ljc.13 for ; Sun, 11 Sep 2022 23:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GgI6sNuIiEld/+iiG14XAnJiIn6TNY0eqR/C3vJoJeY=; b=AZ2/CXMfG94NpKqvmvATbBdh/wh7IGSp/kCNkPmjDqn80oOyEquISBToVUWiKXE/Ak +XdNQSxmSGqe6CZOC+DNfOpgy0wNgLWKmMpluF0ZYQDV+RWoUIgbeVco9uY7YSKamjUY jSUa3W+AmX+vcLr8ElbE7gribHE+ixq4SrK6wJQOigGt3WAS9daXUSINGVolZgT3JWgv nAjkx5nmWIvYBRRKTCiyZjljBm+gso5dKp38A4EWLxkjuFnpErRliqs4BjuzSFEp84T9 LUTBGDbyPcIvv1mCZhS04lAHeUI3ODv9nNe/JA6gOqiTvS7VAlV8RRbgNqIhIS1u2WtT fN9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GgI6sNuIiEld/+iiG14XAnJiIn6TNY0eqR/C3vJoJeY=; b=LVo70wr1SjOoS3klw4U+ZNi1OrDdhSw6jbq51PkIoY3JRKoibLNp7NwZtUKzcq8Ttp jYg45LLA0CiYq5BblPMN/ntIKadbTae2g1kVqEm6d3fVVLunseyS33JPiC3rENG51iAQ A/Bb3HjGwgmMgZNIBLjKZjQJx1e+eIuEOwLmO1+5eZW7mafgZe9SQpFM4XYw6PlbFv55 yZ0XpdctmUyGLlEuKOQJVqPI5QB7C6/r8TXfKRGXO2nJJ2AJnTtxn+n0Je5iDhxPuZLp SN6PCgZYqgEz/LTM9e7fBQcckPEVXjynmm5J39O8jKOmLeY0/PlLediCHKAXyRlRc3jo JOBg== X-Gm-Message-State: ACgBeo0VKBBbP0jgfyk4JDGtjOFoWW3zWHGL+nFGuqm0v/zRfNO5HFTY QI8Qp2RxoimL+yVCwsHcso/3+Q== X-Google-Smtp-Source: AA6agR4YgAvA7zMoENGzSneI75XAZYBTj1RKbWWcfo+LgroyLfiscFA2+fHOpW9UFcMiRO5yEGzBRg== X-Received: by 2002:a2e:a587:0:b0:25f:e6ac:c287 with SMTP id m7-20020a2ea587000000b0025fe6acc287mr7087767ljp.416.1662963522651; Sun, 11 Sep 2022 23:18:42 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:42 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 35/40] arm64: dts: qcom: sm6350: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:41 +0200 Message-Id: <20220912061746.6311-36-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qco= m/sm6350.dtsi index d882c29d53aa..c39de7d3ace0 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1314,49 +1314,49 @@ tlmm: pinctrl@f100000 { #interrupt-cells =3D <2>; gpio-ranges =3D <&tlmm 0 0 157>; =20 - qup_uart9_default: qup-uart9-default { + qup_uart9_default: qup-uart9-default-state { pins =3D "gpio25", "gpio26"; function =3D "qup13_f2"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c0_default: qup-i2c0-default { + qup_i2c0_default: qup-i2c0-default-state { pins =3D "gpio0", "gpio1"; function =3D "qup00"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c2_default: qup-i2c2-default { + qup_i2c2_default: qup-i2c2-default-state { pins =3D "gpio45", "gpio46"; function =3D "qup02"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c6_default: qup-i2c6-default { + qup_i2c6_default: qup-i2c6-default-state { pins =3D "gpio13", "gpio14"; function =3D "qup10"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c7_default: qup-i2c7-default { + qup_i2c7_default: qup-i2c7-default-state { pins =3D "gpio27", "gpio28"; function =3D "qup11"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c8_default: qup-i2c8-default { + qup_i2c8_default: qup-i2c8-default-state { pins =3D "gpio19", "gpio20"; function =3D "qup12"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c10_default: qup-i2c10-default { + qup_i2c10_default: qup-i2c10-default-state { pins =3D "gpio4", "gpio5"; function =3D "qup14"; drive-strength =3D <2>; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18ECFECAAA1 for ; Mon, 12 Sep 2022 06:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbiILGUy (ORCPT ); Mon, 12 Sep 2022 02:20:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiILGT7 (ORCPT ); Mon, 12 Sep 2022 02:19:59 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 564C129821 for ; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id bt10so13202708lfb.1 for ; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Hce0/X2M7TfP4RUEOJj4lD2o6WMQMhsp3Z9J0vMVmr8=; b=ZXKYRnQbMrzbBBMEj5ewTSQLkcTtsF4QhqUnK4rUxBkiQD50Ieq0wUWyfhwd9KToOJ mFeHU7I317N5fNIMGMNiSqiUNKfYg2wkERv0+lWfcLQp0IVkb6dK+wIi3vmaKUoQR7lB 3TfYUbwk+0i6Mn9AC8xYOZ1bypcR8mKVJFlZ3eMo6XuPvkVTbkAEApY5+hyI9s+8ZwbO ygtufrghs+QhH9cJTXUbWEFDgSFcXeaYzkRVarXF3GODspqDRs4unjTVMcR5WpWdA81J Ky5BsIyxt/O7HbYyiMLoiXw3aQfF+dAwwv7Di5DdEW7G4gD3Er3e7qaNfmhgjb8iq++U /9AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Hce0/X2M7TfP4RUEOJj4lD2o6WMQMhsp3Z9J0vMVmr8=; b=orvwroK1Ug9qQfj58pGreHFZQW9W0ZNjz+CFz4WFLvncP1Ur6HeHZsfL6HwYkhB0sO 9sr0i0CnybkKANgWhKoACcsKuSmJ/el+iKUsnwXKpipfRNOh1fl2gxeB1TJueM648RUH BBqIkzHdEkibuzZZaVaeFk4xUKwxj3Jt3fRvTuWLJgtggLJcqX5jlmZkg2KrtV4QMeDn n3Z6wS7qoI/RejqxkitEQzOVxZW+jSQII7E/UucP4uUBZrlg9Wmoo4LthhhmgabefjQN n5jk5B1lwKV/GSWHv5CKQgfIewAvWPudY4j8hATSB5B9Rq/+RJ+jDyjHxziThwZSBuih RYuQ== X-Gm-Message-State: ACgBeo0DtjbD0mT8vsmjF+mixC6IHYkn+YhIphKgEMTS8bpSvwb4ekMt Y0gpVBI+R42UMMD/Z0ZHWNk2CA== X-Google-Smtp-Source: AA6agR7wxJGiPeuK4elaQ/Zq9PldsHu63xZJaoVKvIJwb5wrJqe/x6l3D/S89Et+8uD4aRFo5guISw== X-Received: by 2002:a05:6512:3409:b0:499:f8f1:8322 with SMTP id i9-20020a056512340900b00499f8f18322mr2448812lfr.459.1662963523773; Sun, 11 Sep 2022 23:18:43 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:43 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 36/40] arm64: dts: qcom: sm8350-sagami: correct TS pin property Date: Mon, 12 Sep 2022 08:17:42 +0200 Message-Id: <20220912061746.6311-37-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The pin configuration is selected with "pins", not "pin" property. Fixes: 1209e9246632 ("arm64: dts: qcom: sm8350-sagami: Enable and populate = I2C/SPI nodes") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch= /arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi index cb9bbd234b7b..b702ab1605bb 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi @@ -223,7 +223,7 @@ &tlmm { gpio-reserved-ranges =3D <44 4>; =20 ts_int_default: ts-int-default { - pin =3D "gpio23"; + pins =3D "gpio23"; function =3D "gpio"; drive-strength =3D <2>; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 170A8ECAAD5 for ; Mon, 12 Sep 2022 06:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbiILGUr (ORCPT ); Mon, 12 Sep 2022 02:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbiILGTk (ORCPT ); Mon, 12 Sep 2022 02:19:40 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C0F829C99 for ; Sun, 11 Sep 2022 23:18:45 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id bn9so9326375ljb.6 for ; Sun, 11 Sep 2022 23:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=CL2/j/JItz+3oLrNQS5aOSC401S6zfG+DX5xNbB/udc=; b=rG2VlijA2pc60u0PlEafJ/vMPNVOs3b06FeQdM/PZIIpBk4dgmGeVcICYSUNbXpRDA g/2+1MTu0c1MMvkNsuJtXi2IyLDNESo1U28yAyNwoVG6w5iB0wAJKZJThQ98KWwFbRn9 rqTdIfMwdtmUKi82UqO/Vx2a0tmrGXnHlNoSE1GuddtvgFiFEtDUXfx7JLcaTRXaUlqc Q+fb/Y650xgzz7fQEqsqnAGMC8LNUubfpF04ego2FC8zBHhrZvMBrIpNAZiHIoLVmM1F 79GWmOKVz7htYegd8k4FIvekdQRXWzor0LQoeWRPvRsSfiq6hCRPYPbcnx20EttdskVs PI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=CL2/j/JItz+3oLrNQS5aOSC401S6zfG+DX5xNbB/udc=; b=4BvDY4fbAEEyPvBbD0+yeJ8mpwBR9zmHQjjLqgKE40dBgD6rNU56vydXlNnQf/UPVG wXh7ORgVSZwVhr4TEpZk66bcm07r9sDUOpwWvzyxsWtffdmqRgGzT4Byb17SJHD6Tpgl qZZmJnx3OSyNJPQmTckhe3B39rKH03vbDjviYAiwnP6gb4Ib8DTHXUz7F9JYEkeyKTPo y5VIzwQoimeA313oEkcGXpYK1Cs8vF6bmWtXFxTeSKYzaH5LPMRoZawS4Y9xadRQP6Jh 5pb2zewAd42fJ4thmANW/UfUEcgblKU/Bk4eU1AvsGWfGky3wmKAuJJgeJw10jQG73Fs QQ6g== X-Gm-Message-State: ACgBeo26PzmlRhXLzeZPJpQbSQArkSKQastszVDcyTVCej2LzzMrGfvO MHQp2xxE1nkkWHrlk86twJh3f/vhiRNjNQ== X-Google-Smtp-Source: AA6agR6J734c31m8cKsxH6hs0z5otjzVQUXq/8A1k7uEm/AT3EhLg0T6iy2PHqjAiMgvNb36mNyYvQ== X-Received: by 2002:a2e:5356:0:b0:26b:dce1:419d with SMTP id t22-20020a2e5356000000b0026bdce1419dmr5324319ljd.52.1662963524861; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:44 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 37/40] arm64: dts: qcom: sm8350: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:43 +0200 Message-Id: <20220912061746.6311-38-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../dts/qcom/sm8350-sony-xperia-sagami.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8350.dtsi | 44 +++++++++---------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch= /arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi index b702ab1605bb..b3c9952ac173 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi @@ -222,7 +222,7 @@ &spi14 { &tlmm { gpio-reserved-ranges =3D <44 4>; =20 - ts_int_default: ts-int-default { + ts_int_default: ts-int-default-state { pins =3D "gpio23"; function =3D "gpio"; drive-strength =3D <2>; diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qco= m/sm8350.dtsi index e72a04411888..cd5503642a23 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1762,150 +1762,150 @@ tlmm: pinctrl@f100000 { wakeup-parent =3D <&pdc>; =20 qup_uart3_default_state: qup-uart3-default-state { - rx { + rx-pins { pins =3D "gpio18"; function =3D "qup3"; }; - tx { + tx-pins { pins =3D "gpio19"; function =3D "qup3"; }; }; =20 - qup_uart6_default: qup-uart6-default { + qup_uart6_default: qup-uart6-default-state { pins =3D "gpio30", "gpio31"; function =3D "qup6"; drive-strength =3D <2>; bias-disable; }; =20 - qup_uart18_default: qup-uart18-default { + qup_uart18_default: qup-uart18-default-state { pins =3D "gpio58", "gpio59"; function =3D "qup18"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c0_default: qup-i2c0-default { + qup_i2c0_default: qup-i2c0-default-state { pins =3D "gpio4", "gpio5"; function =3D "qup0"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c1_default: qup-i2c1-default { + qup_i2c1_default: qup-i2c1-default-state { pins =3D "gpio8", "gpio9"; function =3D "qup1"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c2_default: qup-i2c2-default { + qup_i2c2_default: qup-i2c2-default-state { pins =3D "gpio12", "gpio13"; function =3D "qup2"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c4_default: qup-i2c4-default { + qup_i2c4_default: qup-i2c4-default-state { pins =3D "gpio20", "gpio21"; function =3D "qup4"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c5_default: qup-i2c5-default { + qup_i2c5_default: qup-i2c5-default-state { pins =3D "gpio24", "gpio25"; function =3D "qup5"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c6_default: qup-i2c6-default { + qup_i2c6_default: qup-i2c6-default-state { pins =3D "gpio28", "gpio29"; function =3D "qup6"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c7_default: qup-i2c7-default { + qup_i2c7_default: qup-i2c7-default-state { pins =3D "gpio32", "gpio33"; function =3D "qup7"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c8_default: qup-i2c8-default { + qup_i2c8_default: qup-i2c8-default-state { pins =3D "gpio36", "gpio37"; function =3D "qup8"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c9_default: qup-i2c9-default { + qup_i2c9_default: qup-i2c9-default-state { pins =3D "gpio40", "gpio41"; function =3D "qup9"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c10_default: qup-i2c10-default { + qup_i2c10_default: qup-i2c10-default-state { pins =3D "gpio44", "gpio45"; function =3D "qup10"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c11_default: qup-i2c11-default { + qup_i2c11_default: qup-i2c11-default-state { pins =3D "gpio48", "gpio49"; function =3D "qup11"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c12_default: qup-i2c12-default { + qup_i2c12_default: qup-i2c12-default-state { pins =3D "gpio52", "gpio53"; function =3D "qup12"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c13_default: qup-i2c13-default { + qup_i2c13_default: qup-i2c13-default-state { pins =3D "gpio0", "gpio1"; function =3D "qup13"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c14_default: qup-i2c14-default { + qup_i2c14_default: qup-i2c14-default-state { pins =3D "gpio56", "gpio57"; function =3D "qup14"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c15_default: qup-i2c15-default { + qup_i2c15_default: qup-i2c15-default-state { pins =3D "gpio60", "gpio61"; function =3D "qup15"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c16_default: qup-i2c16-default { + qup_i2c16_default: qup-i2c16-default-state { pins =3D "gpio64", "gpio65"; function =3D "qup16"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c17_default: qup-i2c17-default { + qup_i2c17_default: qup-i2c17-default-state { pins =3D "gpio72", "gpio73"; function =3D "qup17"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c19_default: qup-i2c19-default { + qup_i2c19_default: qup-i2c19-default-state { pins =3D "gpio76", "gpio77"; function =3D "qup19"; drive-strength =3D <2>; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99EFECAAA1 for ; Mon, 12 Sep 2022 06:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230206AbiILGU7 (ORCPT ); Mon, 12 Sep 2022 02:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbiILGUE (ORCPT ); Mon, 12 Sep 2022 02:20:04 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C82A2B267 for ; Sun, 11 Sep 2022 23:18:47 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id k10so13155559lfm.4 for ; Sun, 11 Sep 2022 23:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Agf1+UyJe+fVcEGMvuo1mvU0w0VboU6bQsb5wGtqwzo=; b=mt6//2wN69Yj3nOhwlwIpUAf/toiHld+utFjB1UmLCN2F7u3bS+g9Q7MMtqQlZ6Mp4 XXQcTIh6WAoEPkpfXg136mm6SZbTtCQrKwWBObSjwHzmSkcsrlqVfCr3X2tS1g9qmcEk 2Gx4RM5KfVTsc6bMtq3OcjMCsyQBDw1R4fyfuJp4rf6iLKJOmsRSVFCeL5eaifBzn7fS I2lK7Yof/O7gixiqjQTEPHicl+ilas/pprhAAYXOn7pPvCEUizS65eMpyvwb7FmlLcX9 8xXsKH32SUy7iq4Tll0//yWi4dqne6rKcsuF8sHejCwVmIKhK2u3QSdO3mSUrqEKz9c2 3pJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Agf1+UyJe+fVcEGMvuo1mvU0w0VboU6bQsb5wGtqwzo=; b=3QE3KYTHGFgF8ELBakPt4UmumYjy5ZBJnSm2Oh8Hg7xwYuxncHrkBT+m8ZN751/BBU YpzrnRiGD6ib/BexQzJXUA7WhEjrz1wsRUKCCXfn+9k8ICi3nWMLx6lKY+p1lC2sYwiN kLEfkHSyUIAMquSOJn1873ZdIRSpa6CQ4+T1UapnU7tImDsCm586C1//40vR74tAPfD6 BhLHadkdQsUWDC8jb3ZSrNiKDmKOghXlKGrUjtLnGUfDK/b/mtDU9i3B5BYaMnQDVVaH GhWg1JyA9q5ezscTNE0B8sSXwyZ8MdqI3zXD0pK+3nwUcI25hr2vZCPMJJfduWH4kLRT WXjQ== X-Gm-Message-State: ACgBeo1DWIO40/gnok9ZOU0xQO2uk7VYq+8Br4LFXEF0CptFf/QwrcEp afeVUPusu6KQRDd4jQICj/VG/A== X-Google-Smtp-Source: AA6agR61r5W+TqcVo17JrpiKR9RSsLrs8VwNGDA/e499flUqoiGLzql9xlDLfMzGxx6WFGvzei6Qog== X-Received: by 2002:a05:6512:10cd:b0:498:fe5b:8ab3 with SMTP id k13-20020a05651210cd00b00498fe5b8ab3mr4971305lfg.613.1662963526686; Sun, 11 Sep 2022 23:18:46 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:46 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 38/40] arm64: dts: qcom: sm8450: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:44 +0200 Message-Id: <20220912061746.6311-39-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../qcom/sm8450-sony-xperia-nagara-pdx223.dts | 12 +- arch/arm64/boot/dts/qcom/sm8450.dtsi | 152 +++++++++--------- 2 files changed, 82 insertions(+), 82 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts = b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts index 7fe582b92a61..d68765eb6d4f 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts @@ -572,27 +572,27 @@ &spi10 { &tlmm { gpio-reserved-ranges =3D <28 4>; =20 - sdc2_default_state: sdc2-default { - clk { + sdc2_default_state: sdc2-default-state { + clk-pins { pins =3D "sdc2_clk"; drive-strength =3D <16>; bias-disable; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; drive-strength =3D <16>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <16>; bias-pull-up; }; }; =20 - ts_int_default: ts-int-default { + ts_int_default: ts-int-default-state { pins =3D "gpio23"; function =3D "gpio"; drive-strength =3D <2>; @@ -600,7 +600,7 @@ ts_int_default: ts-int-default { input-enable; }; =20 - sdc2_card_det_n: sd-card-det-n { + sdc2_card_det_n: sd-card-det-n-state { pins =3D "gpio92"; function =3D "gpio"; drive-strength =3D <2>; diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index d0ebf61a0074..1d878256028f 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2384,20 +2384,20 @@ tlmm: pinctrl@f100000 { gpio-ranges =3D <&tlmm 0 0 211>; wakeup-parent =3D <&pdc>; =20 - sdc2_sleep_state: sdc2-sleep { - clk { + sdc2_sleep_state: sdc2-sleep-state { + clk-pins { pins =3D "sdc2_clk"; drive-strength =3D <2>; bias-disable; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; drive-strength =3D <2>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <2>; bias-pull-up; @@ -2405,21 +2405,21 @@ data { }; =20 pcie0_default_state: pcie0-default-state { - perst { + perst-pins { pins =3D "gpio94"; function =3D "gpio"; drive-strength =3D <2>; bias-pull-down; }; =20 - clkreq { + clkreq-pins { pins =3D "gpio95"; function =3D "pcie0_clkreqn"; drive-strength =3D <2>; bias-pull-up; }; =20 - wake { + wake-pins { pins =3D "gpio96"; function =3D "gpio"; drive-strength =3D <2>; @@ -2428,21 +2428,21 @@ wake { }; =20 pcie1_default_state: pcie1-default-state { - perst { + perst-pins { pins =3D "gpio97"; function =3D "gpio"; drive-strength =3D <2>; bias-pull-down; }; =20 - clkreq { + clkreq-pins { pins =3D "gpio98"; function =3D "pcie1_clkreqn"; drive-strength =3D <2>; bias-pull-up; }; =20 - wake { + wake-pins { pins =3D "gpio99"; function =3D "gpio"; drive-strength =3D <2>; @@ -2450,350 +2450,350 @@ wake { }; }; =20 - qup_i2c0_data_clk: qup-i2c0-data-clk { + qup_i2c0_data_clk: qup-i2c0-data-clk-state { pins =3D "gpio0", "gpio1"; function =3D "qup0"; }; =20 - qup_i2c1_data_clk: qup-i2c1-data-clk { + qup_i2c1_data_clk: qup-i2c1-data-clk-state { pins =3D "gpio4", "gpio5"; function =3D "qup1"; }; =20 - qup_i2c2_data_clk: qup-i2c2-data-clk { + qup_i2c2_data_clk: qup-i2c2-data-clk-state { pins =3D "gpio8", "gpio9"; function =3D "qup2"; }; =20 - qup_i2c3_data_clk: qup-i2c3-data-clk { + qup_i2c3_data_clk: qup-i2c3-data-clk-state { pins =3D "gpio12", "gpio13"; function =3D "qup3"; }; =20 - qup_i2c4_data_clk: qup-i2c4-data-clk { + qup_i2c4_data_clk: qup-i2c4-data-clk-state { pins =3D "gpio16", "gpio17"; function =3D "qup4"; }; =20 - qup_i2c5_data_clk: qup-i2c5-data-clk { + qup_i2c5_data_clk: qup-i2c5-data-clk-state { pins =3D "gpio206", "gpio207"; function =3D "qup5"; }; =20 - qup_i2c6_data_clk: qup-i2c6-data-clk { + qup_i2c6_data_clk: qup-i2c6-data-clk-state { pins =3D "gpio20", "gpio21"; function =3D "qup6"; }; =20 - qup_i2c8_data_clk: qup-i2c8-data-clk { + qup_i2c8_data_clk: qup-i2c8-data-clk-state { pins =3D "gpio28", "gpio29"; function =3D "qup8"; }; =20 - qup_i2c9_data_clk: qup-i2c9-data-clk { + qup_i2c9_data_clk: qup-i2c9-data-clk-state { pins =3D "gpio32", "gpio33"; function =3D "qup9"; }; =20 - qup_i2c10_data_clk: qup-i2c10-data-clk { + qup_i2c10_data_clk: qup-i2c10-data-clk-state { pins =3D "gpio36", "gpio37"; function =3D "qup10"; }; =20 - qup_i2c11_data_clk: qup-i2c11-data-clk { + qup_i2c11_data_clk: qup-i2c11-data-clk-state { pins =3D "gpio40", "gpio41"; function =3D "qup11"; }; =20 - qup_i2c12_data_clk: qup-i2c12-data-clk { + qup_i2c12_data_clk: qup-i2c12-data-clk-state { pins =3D "gpio44", "gpio45"; function =3D "qup12"; }; =20 - qup_i2c13_data_clk: qup-i2c13-data-clk { + qup_i2c13_data_clk: qup-i2c13-data-clk-state { pins =3D "gpio48", "gpio49"; function =3D "qup13"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c14_data_clk: qup-i2c14-data-clk { + qup_i2c14_data_clk: qup-i2c14-data-clk-state { pins =3D "gpio52", "gpio53"; function =3D "qup14"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c15_data_clk: qup-i2c15-data-clk { + qup_i2c15_data_clk: qup-i2c15-data-clk-state { pins =3D "gpio56", "gpio57"; function =3D "qup15"; }; =20 - qup_i2c16_data_clk: qup-i2c16-data-clk { + qup_i2c16_data_clk: qup-i2c16-data-clk-state { pins =3D "gpio60", "gpio61"; function =3D "qup16"; }; =20 - qup_i2c17_data_clk: qup-i2c17-data-clk { + qup_i2c17_data_clk: qup-i2c17-data-clk-state { pins =3D "gpio64", "gpio65"; function =3D "qup17"; }; =20 - qup_i2c18_data_clk: qup-i2c18-data-clk { + qup_i2c18_data_clk: qup-i2c18-data-clk-state { pins =3D "gpio68", "gpio69"; function =3D "qup18"; }; =20 - qup_i2c19_data_clk: qup-i2c19-data-clk { + qup_i2c19_data_clk: qup-i2c19-data-clk-state { pins =3D "gpio72", "gpio73"; function =3D "qup19"; }; =20 - qup_i2c20_data_clk: qup-i2c20-data-clk { + qup_i2c20_data_clk: qup-i2c20-data-clk-state { pins =3D "gpio76", "gpio77"; function =3D "qup20"; }; =20 - qup_i2c21_data_clk: qup-i2c21-data-clk { + qup_i2c21_data_clk: qup-i2c21-data-clk-state { pins =3D "gpio80", "gpio81"; function =3D "qup21"; }; =20 - qup_spi0_cs: qup-spi0-cs { + qup_spi0_cs: qup-spi0-cs-state { pins =3D "gpio3"; function =3D "qup0"; }; =20 - qup_spi0_data_clk: qup-spi0-data-clk { + qup_spi0_data_clk: qup-spi0-data-clk-state { pins =3D "gpio0", "gpio1", "gpio2"; function =3D "qup0"; }; =20 - qup_spi1_cs: qup-spi1-cs { + qup_spi1_cs: qup-spi1-cs-state { pins =3D "gpio7"; function =3D "qup1"; }; =20 - qup_spi1_data_clk: qup-spi1-data-clk { + qup_spi1_data_clk: qup-spi1-data-clk-state { pins =3D "gpio4", "gpio5", "gpio6"; function =3D "qup1"; }; =20 - qup_spi2_cs: qup-spi2-cs { + qup_spi2_cs: qup-spi2-cs-state { pins =3D "gpio11"; function =3D "qup2"; }; =20 - qup_spi2_data_clk: qup-spi2-data-clk { + qup_spi2_data_clk: qup-spi2-data-clk-state { pins =3D "gpio8", "gpio9", "gpio10"; function =3D "qup2"; }; =20 - qup_spi3_cs: qup-spi3-cs { + qup_spi3_cs: qup-spi3-cs-state { pins =3D "gpio15"; function =3D "qup3"; }; =20 - qup_spi3_data_clk: qup-spi3-data-clk { + qup_spi3_data_clk: qup-spi3-data-clk-state { pins =3D "gpio12", "gpio13", "gpio14"; function =3D "qup3"; }; =20 - qup_spi4_cs: qup-spi4-cs { + qup_spi4_cs: qup-spi4-cs-state { pins =3D "gpio19"; function =3D "qup4"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi4_data_clk: qup-spi4-data-clk { + qup_spi4_data_clk: qup-spi4-data-clk-state { pins =3D "gpio16", "gpio17", "gpio18"; function =3D "qup4"; }; =20 - qup_spi5_cs: qup-spi5-cs { + qup_spi5_cs: qup-spi5-cs-state { pins =3D "gpio85"; function =3D "qup5"; }; =20 - qup_spi5_data_clk: qup-spi5-data-clk { + qup_spi5_data_clk: qup-spi5-data-clk-state { pins =3D "gpio206", "gpio207", "gpio84"; function =3D "qup5"; }; =20 - qup_spi6_cs: qup-spi6-cs { + qup_spi6_cs: qup-spi6-cs-state { pins =3D "gpio23"; function =3D "qup6"; }; =20 - qup_spi6_data_clk: qup-spi6-data-clk { + qup_spi6_data_clk: qup-spi6-data-clk-state { pins =3D "gpio20", "gpio21", "gpio22"; function =3D "qup6"; }; =20 - qup_spi8_cs: qup-spi8-cs { + qup_spi8_cs: qup-spi8-cs-state { pins =3D "gpio31"; function =3D "qup8"; }; =20 - qup_spi8_data_clk: qup-spi8-data-clk { + qup_spi8_data_clk: qup-spi8-data-clk-state { pins =3D "gpio28", "gpio29", "gpio30"; function =3D "qup8"; }; =20 - qup_spi9_cs: qup-spi9-cs { + qup_spi9_cs: qup-spi9-cs-state { pins =3D "gpio35"; function =3D "qup9"; }; =20 - qup_spi9_data_clk: qup-spi9-data-clk { + qup_spi9_data_clk: qup-spi9-data-clk-state { pins =3D "gpio32", "gpio33", "gpio34"; function =3D "qup9"; }; =20 - qup_spi10_cs: qup-spi10-cs { + qup_spi10_cs: qup-spi10-cs-state { pins =3D "gpio39"; function =3D "qup10"; }; =20 - qup_spi10_data_clk: qup-spi10-data-clk { + qup_spi10_data_clk: qup-spi10-data-clk-state { pins =3D "gpio36", "gpio37", "gpio38"; function =3D "qup10"; }; =20 - qup_spi11_cs: qup-spi11-cs { + qup_spi11_cs: qup-spi11-cs-state { pins =3D "gpio43"; function =3D "qup11"; }; =20 - qup_spi11_data_clk: qup-spi11-data-clk { + qup_spi11_data_clk: qup-spi11-data-clk-state { pins =3D "gpio40", "gpio41", "gpio42"; function =3D "qup11"; }; =20 - qup_spi12_cs: qup-spi12-cs { + qup_spi12_cs: qup-spi12-cs-state { pins =3D "gpio47"; function =3D "qup12"; }; =20 - qup_spi12_data_clk: qup-spi12-data-clk { + qup_spi12_data_clk: qup-spi12-data-clk-state { pins =3D "gpio44", "gpio45", "gpio46"; function =3D "qup12"; }; =20 - qup_spi13_cs: qup-spi13-cs { + qup_spi13_cs: qup-spi13-cs-state { pins =3D "gpio51"; function =3D "qup13"; }; =20 - qup_spi13_data_clk: qup-spi13-data-clk { + qup_spi13_data_clk: qup-spi13-data-clk-state { pins =3D "gpio48", "gpio49", "gpio50"; function =3D "qup13"; }; =20 - qup_spi14_cs: qup-spi14-cs { + qup_spi14_cs: qup-spi14-cs-state { pins =3D "gpio55"; function =3D "qup14"; }; =20 - qup_spi14_data_clk: qup-spi14-data-clk { + qup_spi14_data_clk: qup-spi14-data-clk-state { pins =3D "gpio52", "gpio53", "gpio54"; function =3D "qup14"; }; =20 - qup_spi15_cs: qup-spi15-cs { + qup_spi15_cs: qup-spi15-cs-state { pins =3D "gpio59"; function =3D "qup15"; }; =20 - qup_spi15_data_clk: qup-spi15-data-clk { + qup_spi15_data_clk: qup-spi15-data-clk-state { pins =3D "gpio56", "gpio57", "gpio58"; function =3D "qup15"; }; =20 - qup_spi16_cs: qup-spi16-cs { + qup_spi16_cs: qup-spi16-cs-state { pins =3D "gpio63"; function =3D "qup16"; }; =20 - qup_spi16_data_clk: qup-spi16-data-clk { + qup_spi16_data_clk: qup-spi16-data-clk-state { pins =3D "gpio60", "gpio61", "gpio62"; function =3D "qup16"; }; =20 - qup_spi17_cs: qup-spi17-cs { + qup_spi17_cs: qup-spi17-cs-state { pins =3D "gpio67"; function =3D "qup17"; }; =20 - qup_spi17_data_clk: qup-spi17-data-clk { + qup_spi17_data_clk: qup-spi17-data-clk-state { pins =3D "gpio64", "gpio65", "gpio66"; function =3D "qup17"; }; =20 - qup_spi18_cs: qup-spi18-cs { + qup_spi18_cs: qup-spi18-cs-state { pins =3D "gpio71"; function =3D "qup18"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi18_data_clk: qup-spi18-data-clk { + qup_spi18_data_clk: qup-spi18-data-clk-state { pins =3D "gpio68", "gpio69", "gpio70"; function =3D "qup18"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi19_cs: qup-spi19-cs { + qup_spi19_cs: qup-spi19-cs-state { pins =3D "gpio75"; function =3D "qup19"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi19_data_clk: qup-spi19-data-clk { + qup_spi19_data_clk: qup-spi19-data-clk-state { pins =3D "gpio72", "gpio73", "gpio74"; function =3D "qup19"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi20_cs: qup-spi20-cs { + qup_spi20_cs: qup-spi20-cs-state { pins =3D "gpio79"; function =3D "qup20"; }; =20 - qup_spi20_data_clk: qup-spi20-data-clk { + qup_spi20_data_clk: qup-spi20-data-clk-state { pins =3D "gpio76", "gpio77", "gpio78"; function =3D "qup20"; }; =20 - qup_spi21_cs: qup-spi21-cs { + qup_spi21_cs: qup-spi21-cs-state { pins =3D "gpio83"; function =3D "qup21"; }; =20 - qup_spi21_data_clk: qup-spi21-data-clk { + qup_spi21_data_clk: qup-spi21-data-clk-state { pins =3D "gpio80", "gpio81", "gpio82"; function =3D "qup21"; }; =20 - qup_uart7_rx: qup-uart7-rx { + qup_uart7_rx: qup-uart7-rx-state { pins =3D "gpio26"; function =3D "qup7"; drive-strength =3D <2>; bias-disable; }; =20 - qup_uart7_tx: qup-uart7-tx { + qup_uart7_tx: qup-uart7-tx-state { pins =3D "gpio27"; function =3D "qup7"; drive-strength =3D <2>; bias-disable; }; =20 - qup_uart20_default: qup-uart20-default { + qup_uart20_default: qup-uart20-default-state { pins =3D "gpio76", "gpio77", "gpio78", "gpio79"; function =3D "qup20"; }; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5652ECAAA1 for ; Mon, 12 Sep 2022 06:22:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbiILGWD (ORCPT ); Mon, 12 Sep 2022 02:22:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230167AbiILGVa (ORCPT ); Mon, 12 Sep 2022 02:21:30 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61B8C2C674 for ; Sun, 11 Sep 2022 23:19:11 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id bt10so13202918lfb.1 for ; Sun, 11 Sep 2022 23:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=kCmef+I4ubqqGDCcAcc+6D54ls+qXxrTz9AD5rjIgz8=; b=xTRopjT8RULABlCJHqxtuxh/0qxNvnYELgRRhlf/yV20satUbzwzOvennLl0Qd4m9N Qvjj19khSdT/mfewd5E+BA8QWXkYFp6AdFi0+/epYrwaTZdSUnH4yRMLlZAABiisa/p3 /ekgfLNYibWpqe4R7G4RK5aJ0y/qKdSVuoaF6nPPQQ8Ik/In7ed2mZ9KU5kUoVQY72+7 6Cg9V7+xSGFgfS0AAxWM+iZvSk0FoeQrGiq4rFiK2R+AhvnpeOLfOUMQoHexLWeY/PQm mzgigqoLplRq5U7DqGmW7wanEZt4gAeAGSmA+jCHyF9/GnVufOZy6duWj7m+3M/tjAv7 yaCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=kCmef+I4ubqqGDCcAcc+6D54ls+qXxrTz9AD5rjIgz8=; b=ZGPPS+05ijY0ZdHEhTpj4iBflwe9ENVD+bodSk49AjUtjzwARtHtYmsMWcXu/GGhJL t9Kzcb57a1DJS6+EECSEgD1RBZGdJuSwRUtkOn6i75QHEio0juukIOO6Fjz5DP9WMSxG 3kx/h62ah+XrZNCRILOv02YE1yzrQVG3s/kp2x3JW82yt4mRZoORTdmlS42eaLWlSeCQ xjPC+VXoS4UkIq8T5uLVLl0+HD+imAccj7+z3An0q3XDSPFE93zk6Wr/xBkvgz+TWABV jbrk2sZG0Zza3hbho7T5YccUNo+17xvCbTEHPRUbMK3ke5xRN1SNp119PLGQcg9AeNNE MywA== X-Gm-Message-State: ACgBeo3WYVtGR+Q9bZKXHsC1oXdJ8JUF+h7tAYqYkxYixQQNgKiQN7qM qmFG4hzNo7pNO96ClM2JrZFaNw== X-Google-Smtp-Source: AA6agR6lUpkimdHOgaaptYrNlgGPNjggTiAYrXWDC3WCH4/ehXWMlFBARLmq0/i+k0tWHlAUvSIdHg== X-Received: by 2002:a05:6512:3a87:b0:499:2069:17af with SMTP id q7-20020a0565123a8700b00499206917afmr4524286lfu.38.1662963528144; Sun, 11 Sep 2022 23:18:48 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:47 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 39/40] arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:45 +0200 Message-Id: <20220912061746.6311-40-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 44 +-- .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 8 +- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 20 +- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 14 +- arch/arm64/boot/dts/qcom/sc7280.dtsi | 316 +++++++++--------- 5 files changed, 201 insertions(+), 201 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-herobrine.dtsi index 45f6a1e1002e..82307722222a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -717,27 +717,27 @@ &tlmm { pinctrl-names =3D "default"; pinctrl-0 =3D <&bios_flash_wp_od>; =20 - amp_en: amp-en { + amp_en: amp-en-pins { pins =3D "gpio63"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - ap_ec_int_l: ap-ec-int-l { + ap_ec_int_l: ap-ec-int-l-pins { pins =3D "gpio18"; function =3D "gpio"; bias-pull-up; }; =20 - bios_flash_wp_od: bios-flash-wp-od { + bios_flash_wp_od: bios-flash-wp-od-pins { pins =3D "gpio16"; function =3D "gpio"; /* Has external pull */ bias-disable; }; =20 - en_fp_rails: en-fp-rails { + en_fp_rails: en-fp-rails-pins { pins =3D "gpio77"; function =3D "gpio"; bias-disable; @@ -745,60 +745,60 @@ en_fp_rails: en-fp-rails { output-high; }; =20 - en_pp3300_codec: en-pp3300-codec { + en_pp3300_codec: en-pp3300-codec-pins { pins =3D "gpio105"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - en_pp3300_dx_edp: en-pp3300-dx-edp { + en_pp3300_dx_edp: en-pp3300-dx-edp-pins { pins =3D "gpio80"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - fp_rst_l: fp-rst-l { + fp_rst_l: fp-rst-l-pins { pins =3D "gpio78"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - fp_to_ap_irq_l: fp-to-ap-irq-l { + fp_to_ap_irq_l: fp-to-ap-irq-l-pins { pins =3D "gpio61"; function =3D "gpio"; /* Has external pullup */ bias-disable; }; =20 - fpmcu_boot0: fpmcu-boot0 { + fpmcu_boot0: fpmcu-boot0-pins { pins =3D "gpio68"; function =3D "gpio"; bias-disable; }; =20 - gsc_ap_int_odl: gsc-ap-int-odl { + gsc_ap_int_odl: gsc-ap-int-odl-pins { pins =3D "gpio104"; function =3D "gpio"; bias-pull-up; }; =20 - hp_irq: hp-irq { + hp_irq: hp-irq-pins { pins =3D "gpio101"; function =3D "gpio"; bias-pull-up; }; =20 - hub_en: hub-en { + hub_en: hub-en-pins { pins =3D "gpio157"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - pe_wake_odl: pe-wake-odl { + pe_wake_odl: pe-wake-odl-pins { pins =3D "gpio3"; function =3D "gpio"; /* Has external pull */ @@ -807,45 +807,45 @@ pe_wake_odl: pe-wake-odl { }; =20 /* For ap_spi_fp */ - qup_spi9_cs_gpio_init_high: qup-spi9-cs-gpio-init-high { + qup_spi9_cs_gpio_init_high: qup-spi9-cs-gpio-init-high-pins { pins =3D "gpio39"; function =3D "gpio"; output-high; }; =20 /* For ap_ec_spi */ - qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high { + qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high-pins { pins =3D "gpio43"; function =3D "gpio"; output-high; }; =20 - sar0_irq_odl: sar0-irq-odl { + sar0_irq_odl: sar0-irq-odl-pins { pins =3D "gpio141"; function =3D "gpio"; bias-pull-up; }; =20 - sar1_irq_odl: sar1-irq-odl { + sar1_irq_odl: sar1-irq-odl-pins { pins =3D "gpio140"; function =3D "gpio"; bias-pull-up; }; =20 - sd_cd_odl: sd-cd-odl { + sd_cd_odl: sd-cd-odl-pins { pins =3D "gpio91"; function =3D "gpio"; bias-pull-up; }; =20 - ssd_en: ssd-en { + ssd_en: ssd-en-pins { pins =3D "gpio51"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - ssd_rst_l: ssd-rst-l { + ssd_rst_l: ssd-rst-l-pins { pins =3D "gpio2"; function =3D "gpio"; bias-disable; @@ -853,14 +853,14 @@ ssd_rst_l: ssd-rst-l { output-low; }; =20 - tp_int_odl: tp-int-odl { + tp_int_odl: tp-int-odl-pins { pins =3D "gpio7"; function =3D "gpio"; /* Has external pullup */ bias-disable; }; =20 - wf_cam_en: wf-cam-en { + wf_cam_en: wf-cam-en-pins { pins =3D "gpio119"; function =3D "gpio"; /* Has external pulldown */ diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-idp-ec-h1.dtsi index a7c346aa3b02..7f5143e9bb80 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi @@ -79,26 +79,26 @@ cr50: tpm@0 { }; =20 &tlmm { - ap_ec_int_l: ap-ec-int-l { + ap_ec_int_l: ap-ec-int-l-pins { pins =3D "gpio18"; function =3D "gpio"; input-enable; bias-pull-up; }; =20 - h1_ap_int_odl: h1-ap-int-odl { + h1_ap_int_odl: h1-ap-int-odl-pins { pins =3D "gpio104"; function =3D "gpio"; input-enable; bias-pull-up; }; =20 - qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high { + qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high-pins { pins =3D "gpio43"; output-high; }; =20 - qup_spi14_cs_gpio_init_high: qup-spi14-cs-gpio-init-high { + qup_spi14_cs_gpio_init_high: qup-spi14-cs-gpio-init-high-pins { pins =3D "gpio59"; output-high; }; diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts= /qcom/sc7280-idp.dtsi index 0c48db69e1ef..89ecf0d25a12 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -550,18 +550,18 @@ &sdc2_data { }; =20 &tlmm { - bt_en: bt-en { + bt_en: bt-en-pins { pins =3D "gpio85"; function =3D "gpio"; output-low; bias-disable; }; =20 - nvme_pwren: nvme-pwren { + nvme_pwren: nvme-pwren-pins { function =3D "gpio"; }; =20 - pcie1_reset_n: pcie1-reset-n { + pcie1_reset_n: pcie1-reset-n-pins { pins =3D "gpio2"; function =3D "gpio"; =20 @@ -570,7 +570,7 @@ pcie1_reset_n: pcie1-reset-n { bias-disable; }; =20 - pcie1_wake_n: pcie1-wake-n { + pcie1_wake_n: pcie1-wake-n-pins { pins =3D "gpio3"; function =3D "gpio"; =20 @@ -578,7 +578,7 @@ pcie1_wake_n: pcie1-wake-n { bias-pull-up; }; =20 - qup_uart7_sleep_cts: qup-uart7-sleep-cts { + qup_uart7_sleep_cts: qup-uart7-sleep-cts-pins { pins =3D "gpio28"; function =3D "gpio"; /* @@ -591,7 +591,7 @@ qup_uart7_sleep_cts: qup-uart7-sleep-cts { bias-bus-hold; }; =20 - qup_uart7_sleep_rts: qup-uart7-sleep-rts { + qup_uart7_sleep_rts: qup-uart7-sleep-rts-pins { pins =3D "gpio29"; function =3D "gpio"; /* @@ -603,7 +603,7 @@ qup_uart7_sleep_rts: qup-uart7-sleep-rts { bias-pull-down; }; =20 - qup_uart7_sleep_tx: qup-uart7-sleep-tx { + qup_uart7_sleep_tx: qup-uart7-sleep-tx-pins { pins =3D "gpio30"; function =3D "gpio"; /* @@ -613,7 +613,7 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx { bias-pull-up; }; =20 - qup_uart7_sleep_rx: qup-uart7-sleep-rx { + qup_uart7_sleep_rx: qup-uart7-sleep-rx-pins { pins =3D "gpio31"; function =3D "gpio"; /* @@ -624,13 +624,13 @@ qup_uart7_sleep_rx: qup-uart7-sleep-rx { bias-pull-up; }; =20 - sd_cd: sd-cd { + sd_cd: sd-cd-pins { pins =3D "gpio91"; function =3D "gpio"; bias-pull-up; }; =20 - sw_ctrl: sw-ctrl { + sw_ctrl: sw-ctrl-pins { pins =3D "gpio86"; function =3D "gpio"; bias-pull-down; diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/d= ts/qcom/sc7280-qcard.dtsi index 7cd91df7a118..0b56aecf857b 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -542,7 +542,7 @@ pmic_edp_bl_pwm: pmic-edp-bl-pwm-state { }; =20 &tlmm { - mos_bt_en: mos-bt-en { + mos_bt_en: mos-bt-en-pins { pins =3D "gpio85"; function =3D "gpio"; drive-strength =3D <2>; @@ -550,7 +550,7 @@ mos_bt_en: mos-bt-en { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_cts: qup-uart7-sleep-cts { + qup_uart7_sleep_cts: qup-uart7-sleep-cts-pins { pins =3D "gpio28"; function =3D "gpio"; /* @@ -564,7 +564,7 @@ qup_uart7_sleep_cts: qup-uart7-sleep-cts { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_rts: qup-uart7-sleep-rts { + qup_uart7_sleep_rts: qup-uart7-sleep-rts-pins { pins =3D "gpio29"; function =3D "gpio"; /* @@ -577,7 +577,7 @@ qup_uart7_sleep_rts: qup-uart7-sleep-rts { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_rx: qup-uart7-sleep-rx { + qup_uart7_sleep_rx: qup-uart7-sleep-rx-pins { pins =3D "gpio31"; function =3D "gpio"; /* @@ -589,7 +589,7 @@ qup_uart7_sleep_rx: qup-uart7-sleep-rx { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_tx: qup-uart7-sleep-tx { + qup_uart7_sleep_tx: qup-uart7-sleep-tx-pins { pins =3D "gpio30"; function =3D "gpio"; /* @@ -599,13 +599,13 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx { bias-pull-up; }; =20 - ts_int_conn: ts-int-conn { + ts_int_conn: ts-int-conn-pins { pins =3D "gpio55"; function =3D "gpio"; bias-pull-up; }; =20 - ts_rst_conn: ts-rst-conn { + ts_rst_conn: ts-rst-conn-pins { pins =3D "gpio54"; function =3D "gpio"; drive-strength =3D <2>; diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qco= m/sc7280.dtsi index ad04025a8a1a..07fa3e417a96 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4061,791 +4061,791 @@ tlmm: pinctrl@f100000 { gpio-ranges =3D <&tlmm 0 0 175>; wakeup-parent =3D <&pdc>; =20 - dp_hot_plug_det: dp-hot-plug-det { + dp_hot_plug_det: dp-hot-plug-det-pins { pins =3D "gpio47"; function =3D "dp_hot"; }; =20 - edp_hot_plug_det: edp-hot-plug-det { + edp_hot_plug_det: edp-hot-plug-det-pins { pins =3D "gpio60"; function =3D "edp_hot"; }; =20 - mi2s0_data0: mi2s0-data0 { + mi2s0_data0: mi2s0-data0-pins { pins =3D "gpio98"; function =3D "mi2s0_data0"; }; =20 - mi2s0_data1: mi2s0-data1 { + mi2s0_data1: mi2s0-data1-pins { pins =3D "gpio99"; function =3D "mi2s0_data1"; }; =20 - mi2s0_mclk: mi2s0-mclk { + mi2s0_mclk: mi2s0-mclk-pins { pins =3D "gpio96"; function =3D "pri_mi2s"; }; =20 - mi2s0_sclk: mi2s0-sclk { + mi2s0_sclk: mi2s0-sclk-pins { pins =3D "gpio97"; function =3D "mi2s0_sck"; }; =20 - mi2s0_ws: mi2s0-ws { + mi2s0_ws: mi2s0-ws-pins { pins =3D "gpio100"; function =3D "mi2s0_ws"; }; =20 - mi2s1_data0: mi2s1-data0 { + mi2s1_data0: mi2s1-data0-pins { pins =3D "gpio107"; function =3D "mi2s1_data0"; }; =20 - mi2s1_sclk: mi2s1-sclk { + mi2s1_sclk: mi2s1-sclk-pins { pins =3D "gpio106"; function =3D "mi2s1_sck"; }; =20 - mi2s1_ws: mi2s1-ws { + mi2s1_ws: mi2s1-ws-pins { pins =3D "gpio108"; function =3D "mi2s1_ws"; }; =20 - pcie1_clkreq_n: pcie1-clkreq-n { + pcie1_clkreq_n: pcie1-clkreq-n-pins { pins =3D "gpio79"; function =3D "pcie1_clkreqn"; }; =20 - qspi_clk: qspi-clk { + qspi_clk: qspi-clk-pins { pins =3D "gpio14"; function =3D "qspi_clk"; }; =20 - qspi_cs0: qspi-cs0 { + qspi_cs0: qspi-cs0-pins { pins =3D "gpio15"; function =3D "qspi_cs"; }; =20 - qspi_cs1: qspi-cs1 { + qspi_cs1: qspi-cs1-pins { pins =3D "gpio19"; function =3D "qspi_cs"; }; =20 - qspi_data01: qspi-data01 { + qspi_data01: qspi-data01-pins { pins =3D "gpio12", "gpio13"; function =3D "qspi_data"; }; =20 - qspi_data12: qspi-data12 { + qspi_data12: qspi-data12-pins { pins =3D "gpio16", "gpio17"; function =3D "qspi_data"; }; =20 - qup_i2c0_data_clk: qup-i2c0-data-clk { + qup_i2c0_data_clk: qup-i2c0-data-clk-pins { pins =3D "gpio0", "gpio1"; function =3D "qup00"; }; =20 - qup_i2c1_data_clk: qup-i2c1-data-clk { + qup_i2c1_data_clk: qup-i2c1-data-clk-pins { pins =3D "gpio4", "gpio5"; function =3D "qup01"; }; =20 - qup_i2c2_data_clk: qup-i2c2-data-clk { + qup_i2c2_data_clk: qup-i2c2-data-clk-pins { pins =3D "gpio8", "gpio9"; function =3D "qup02"; }; =20 - qup_i2c3_data_clk: qup-i2c3-data-clk { + qup_i2c3_data_clk: qup-i2c3-data-clk-pins { pins =3D "gpio12", "gpio13"; function =3D "qup03"; }; =20 - qup_i2c4_data_clk: qup-i2c4-data-clk { + qup_i2c4_data_clk: qup-i2c4-data-clk-pins { pins =3D "gpio16", "gpio17"; function =3D "qup04"; }; =20 - qup_i2c5_data_clk: qup-i2c5-data-clk { + qup_i2c5_data_clk: qup-i2c5-data-clk-pins { pins =3D "gpio20", "gpio21"; function =3D "qup05"; }; =20 - qup_i2c6_data_clk: qup-i2c6-data-clk { + qup_i2c6_data_clk: qup-i2c6-data-clk-pins { pins =3D "gpio24", "gpio25"; function =3D "qup06"; }; =20 - qup_i2c7_data_clk: qup-i2c7-data-clk { + qup_i2c7_data_clk: qup-i2c7-data-clk-pins { pins =3D "gpio28", "gpio29"; function =3D "qup07"; }; =20 - qup_i2c8_data_clk: qup-i2c8-data-clk { + qup_i2c8_data_clk: qup-i2c8-data-clk-pins { pins =3D "gpio32", "gpio33"; function =3D "qup10"; }; =20 - qup_i2c9_data_clk: qup-i2c9-data-clk { + qup_i2c9_data_clk: qup-i2c9-data-clk-pins { pins =3D "gpio36", "gpio37"; function =3D "qup11"; }; =20 - qup_i2c10_data_clk: qup-i2c10-data-clk { + qup_i2c10_data_clk: qup-i2c10-data-clk-pins { pins =3D "gpio40", "gpio41"; function =3D "qup12"; }; =20 - qup_i2c11_data_clk: qup-i2c11-data-clk { + qup_i2c11_data_clk: qup-i2c11-data-clk-pins { pins =3D "gpio44", "gpio45"; function =3D "qup13"; }; =20 - qup_i2c12_data_clk: qup-i2c12-data-clk { + qup_i2c12_data_clk: qup-i2c12-data-clk-pins { pins =3D "gpio48", "gpio49"; function =3D "qup14"; }; =20 - qup_i2c13_data_clk: qup-i2c13-data-clk { + qup_i2c13_data_clk: qup-i2c13-data-clk-pins { pins =3D "gpio52", "gpio53"; function =3D "qup15"; }; =20 - qup_i2c14_data_clk: qup-i2c14-data-clk { + qup_i2c14_data_clk: qup-i2c14-data-clk-pins { pins =3D "gpio56", "gpio57"; function =3D "qup16"; }; =20 - qup_i2c15_data_clk: qup-i2c15-data-clk { + qup_i2c15_data_clk: qup-i2c15-data-clk-pins { pins =3D "gpio60", "gpio61"; function =3D "qup17"; }; =20 - qup_spi0_data_clk: qup-spi0-data-clk { + qup_spi0_data_clk: qup-spi0-data-clk-pins { pins =3D "gpio0", "gpio1", "gpio2"; function =3D "qup00"; }; =20 - qup_spi0_cs: qup-spi0-cs { + qup_spi0_cs: qup-spi0-cs-pins { pins =3D "gpio3"; function =3D "qup00"; }; =20 - qup_spi0_cs_gpio: qup-spi0-cs-gpio { + qup_spi0_cs_gpio: qup-spi0-cs-gpio-pins { pins =3D "gpio3"; function =3D "gpio"; }; =20 - qup_spi1_data_clk: qup-spi1-data-clk { + qup_spi1_data_clk: qup-spi1-data-clk-pins { pins =3D "gpio4", "gpio5", "gpio6"; function =3D "qup01"; }; =20 - qup_spi1_cs: qup-spi1-cs { + qup_spi1_cs: qup-spi1-cs-pins { pins =3D "gpio7"; function =3D "qup01"; }; =20 - qup_spi1_cs_gpio: qup-spi1-cs-gpio { + qup_spi1_cs_gpio: qup-spi1-cs-gpio-pins { pins =3D "gpio7"; function =3D "gpio"; }; =20 - qup_spi2_data_clk: qup-spi2-data-clk { + qup_spi2_data_clk: qup-spi2-data-clk-pins { pins =3D "gpio8", "gpio9", "gpio10"; function =3D "qup02"; }; =20 - qup_spi2_cs: qup-spi2-cs { + qup_spi2_cs: qup-spi2-cs-pins { pins =3D "gpio11"; function =3D "qup02"; }; =20 - qup_spi2_cs_gpio: qup-spi2-cs-gpio { + qup_spi2_cs_gpio: qup-spi2-cs-gpio-pins { pins =3D "gpio11"; function =3D "gpio"; }; =20 - qup_spi3_data_clk: qup-spi3-data-clk { + qup_spi3_data_clk: qup-spi3-data-clk-pins { pins =3D "gpio12", "gpio13", "gpio14"; function =3D "qup03"; }; =20 - qup_spi3_cs: qup-spi3-cs { + qup_spi3_cs: qup-spi3-cs-pins { pins =3D "gpio15"; function =3D "qup03"; }; =20 - qup_spi3_cs_gpio: qup-spi3-cs-gpio { + qup_spi3_cs_gpio: qup-spi3-cs-gpio-pins { pins =3D "gpio15"; function =3D "gpio"; }; =20 - qup_spi4_data_clk: qup-spi4-data-clk { + qup_spi4_data_clk: qup-spi4-data-clk-pins { pins =3D "gpio16", "gpio17", "gpio18"; function =3D "qup04"; }; =20 - qup_spi4_cs: qup-spi4-cs { + qup_spi4_cs: qup-spi4-cs-pins { pins =3D "gpio19"; function =3D "qup04"; }; =20 - qup_spi4_cs_gpio: qup-spi4-cs-gpio { + qup_spi4_cs_gpio: qup-spi4-cs-gpio-pins { pins =3D "gpio19"; function =3D "gpio"; }; =20 - qup_spi5_data_clk: qup-spi5-data-clk { + qup_spi5_data_clk: qup-spi5-data-clk-pins { pins =3D "gpio20", "gpio21", "gpio22"; function =3D "qup05"; }; =20 - qup_spi5_cs: qup-spi5-cs { + qup_spi5_cs: qup-spi5-cs-pins { pins =3D "gpio23"; function =3D "qup05"; }; =20 - qup_spi5_cs_gpio: qup-spi5-cs-gpio { + qup_spi5_cs_gpio: qup-spi5-cs-gpio-pins { pins =3D "gpio23"; function =3D "gpio"; }; =20 - qup_spi6_data_clk: qup-spi6-data-clk { + qup_spi6_data_clk: qup-spi6-data-clk-pins { pins =3D "gpio24", "gpio25", "gpio26"; function =3D "qup06"; }; =20 - qup_spi6_cs: qup-spi6-cs { + qup_spi6_cs: qup-spi6-cs-pins { pins =3D "gpio27"; function =3D "qup06"; }; =20 - qup_spi6_cs_gpio: qup-spi6-cs-gpio { + qup_spi6_cs_gpio: qup-spi6-cs-gpio-pins { pins =3D "gpio27"; function =3D "gpio"; }; =20 - qup_spi7_data_clk: qup-spi7-data-clk { + qup_spi7_data_clk: qup-spi7-data-clk-pins { pins =3D "gpio28", "gpio29", "gpio30"; function =3D "qup07"; }; =20 - qup_spi7_cs: qup-spi7-cs { + qup_spi7_cs: qup-spi7-cs-pins { pins =3D "gpio31"; function =3D "qup07"; }; =20 - qup_spi7_cs_gpio: qup-spi7-cs-gpio { + qup_spi7_cs_gpio: qup-spi7-cs-gpio-pins { pins =3D "gpio31"; function =3D "gpio"; }; =20 - qup_spi8_data_clk: qup-spi8-data-clk { + qup_spi8_data_clk: qup-spi8-data-clk-pins { pins =3D "gpio32", "gpio33", "gpio34"; function =3D "qup10"; }; =20 - qup_spi8_cs: qup-spi8-cs { + qup_spi8_cs: qup-spi8-cs-pins { pins =3D "gpio35"; function =3D "qup10"; }; =20 - qup_spi8_cs_gpio: qup-spi8-cs-gpio { + qup_spi8_cs_gpio: qup-spi8-cs-gpio-pins { pins =3D "gpio35"; function =3D "gpio"; }; =20 - qup_spi9_data_clk: qup-spi9-data-clk { + qup_spi9_data_clk: qup-spi9-data-clk-pins { pins =3D "gpio36", "gpio37", "gpio38"; function =3D "qup11"; }; =20 - qup_spi9_cs: qup-spi9-cs { + qup_spi9_cs: qup-spi9-cs-pins { pins =3D "gpio39"; function =3D "qup11"; }; =20 - qup_spi9_cs_gpio: qup-spi9-cs-gpio { + qup_spi9_cs_gpio: qup-spi9-cs-gpio-pins { pins =3D "gpio39"; function =3D "gpio"; }; =20 - qup_spi10_data_clk: qup-spi10-data-clk { + qup_spi10_data_clk: qup-spi10-data-clk-pins { pins =3D "gpio40", "gpio41", "gpio42"; function =3D "qup12"; }; =20 - qup_spi10_cs: qup-spi10-cs { + qup_spi10_cs: qup-spi10-cs-pins { pins =3D "gpio43"; function =3D "qup12"; }; =20 - qup_spi10_cs_gpio: qup-spi10-cs-gpio { + qup_spi10_cs_gpio: qup-spi10-cs-gpio-pins { pins =3D "gpio43"; function =3D "gpio"; }; =20 - qup_spi11_data_clk: qup-spi11-data-clk { + qup_spi11_data_clk: qup-spi11-data-clk-pins { pins =3D "gpio44", "gpio45", "gpio46"; function =3D "qup13"; }; =20 - qup_spi11_cs: qup-spi11-cs { + qup_spi11_cs: qup-spi11-cs-pins { pins =3D "gpio47"; function =3D "qup13"; }; =20 - qup_spi11_cs_gpio: qup-spi11-cs-gpio { + qup_spi11_cs_gpio: qup-spi11-cs-gpio-pins { pins =3D "gpio47"; function =3D "gpio"; }; =20 - qup_spi12_data_clk: qup-spi12-data-clk { + qup_spi12_data_clk: qup-spi12-data-clk-pins { pins =3D "gpio48", "gpio49", "gpio50"; function =3D "qup14"; }; =20 - qup_spi12_cs: qup-spi12-cs { + qup_spi12_cs: qup-spi12-cs-pins { pins =3D "gpio51"; function =3D "qup14"; }; =20 - qup_spi12_cs_gpio: qup-spi12-cs-gpio { + qup_spi12_cs_gpio: qup-spi12-cs-gpio-pins { pins =3D "gpio51"; function =3D "gpio"; }; =20 - qup_spi13_data_clk: qup-spi13-data-clk { + qup_spi13_data_clk: qup-spi13-data-clk-pins { pins =3D "gpio52", "gpio53", "gpio54"; function =3D "qup15"; }; =20 - qup_spi13_cs: qup-spi13-cs { + qup_spi13_cs: qup-spi13-cs-pins { pins =3D "gpio55"; function =3D "qup15"; }; =20 - qup_spi13_cs_gpio: qup-spi13-cs-gpio { + qup_spi13_cs_gpio: qup-spi13-cs-gpio-pins { pins =3D "gpio55"; function =3D "gpio"; }; =20 - qup_spi14_data_clk: qup-spi14-data-clk { + qup_spi14_data_clk: qup-spi14-data-clk-pins { pins =3D "gpio56", "gpio57", "gpio58"; function =3D "qup16"; }; =20 - qup_spi14_cs: qup-spi14-cs { + qup_spi14_cs: qup-spi14-cs-pins { pins =3D "gpio59"; function =3D "qup16"; }; =20 - qup_spi14_cs_gpio: qup-spi14-cs-gpio { + qup_spi14_cs_gpio: qup-spi14-cs-gpio-pins { pins =3D "gpio59"; function =3D "gpio"; }; =20 - qup_spi15_data_clk: qup-spi15-data-clk { + qup_spi15_data_clk: qup-spi15-data-clk-pins { pins =3D "gpio60", "gpio61", "gpio62"; function =3D "qup17"; }; =20 - qup_spi15_cs: qup-spi15-cs { + qup_spi15_cs: qup-spi15-cs-pins { pins =3D "gpio63"; function =3D "qup17"; }; =20 - qup_spi15_cs_gpio: qup-spi15-cs-gpio { + qup_spi15_cs_gpio: qup-spi15-cs-gpio-pins { pins =3D "gpio63"; function =3D "gpio"; }; =20 - qup_uart0_cts: qup-uart0-cts { + qup_uart0_cts: qup-uart0-cts-pins { pins =3D "gpio0"; function =3D "qup00"; }; =20 - qup_uart0_rts: qup-uart0-rts { + qup_uart0_rts: qup-uart0-rts-pins { pins =3D "gpio1"; function =3D "qup00"; }; =20 - qup_uart0_tx: qup-uart0-tx { + qup_uart0_tx: qup-uart0-tx-pins { pins =3D "gpio2"; function =3D "qup00"; }; =20 - qup_uart0_rx: qup-uart0-rx { + qup_uart0_rx: qup-uart0-rx-pins { pins =3D "gpio3"; function =3D "qup00"; }; =20 - qup_uart1_cts: qup-uart1-cts { + qup_uart1_cts: qup-uart1-cts-pins { pins =3D "gpio4"; function =3D "qup01"; }; =20 - qup_uart1_rts: qup-uart1-rts { + qup_uart1_rts: qup-uart1-rts-pins { pins =3D "gpio5"; function =3D "qup01"; }; =20 - qup_uart1_tx: qup-uart1-tx { + qup_uart1_tx: qup-uart1-tx-pins { pins =3D "gpio6"; function =3D "qup01"; }; =20 - qup_uart1_rx: qup-uart1-rx { + qup_uart1_rx: qup-uart1-rx-pins { pins =3D "gpio7"; function =3D "qup01"; }; =20 - qup_uart2_cts: qup-uart2-cts { + qup_uart2_cts: qup-uart2-cts-pins { pins =3D "gpio8"; function =3D "qup02"; }; =20 - qup_uart2_rts: qup-uart2-rts { + qup_uart2_rts: qup-uart2-rts-pins { pins =3D "gpio9"; function =3D "qup02"; }; =20 - qup_uart2_tx: qup-uart2-tx { + qup_uart2_tx: qup-uart2-tx-pins { pins =3D "gpio10"; function =3D "qup02"; }; =20 - qup_uart2_rx: qup-uart2-rx { + qup_uart2_rx: qup-uart2-rx-pins { pins =3D "gpio11"; function =3D "qup02"; }; =20 - qup_uart3_cts: qup-uart3-cts { + qup_uart3_cts: qup-uart3-cts-pins { pins =3D "gpio12"; function =3D "qup03"; }; =20 - qup_uart3_rts: qup-uart3-rts { + qup_uart3_rts: qup-uart3-rts-pins { pins =3D "gpio13"; function =3D "qup03"; }; =20 - qup_uart3_tx: qup-uart3-tx { + qup_uart3_tx: qup-uart3-tx-pins { pins =3D "gpio14"; function =3D "qup03"; }; =20 - qup_uart3_rx: qup-uart3-rx { + qup_uart3_rx: qup-uart3-rx-pins { pins =3D "gpio15"; function =3D "qup03"; }; =20 - qup_uart4_cts: qup-uart4-cts { + qup_uart4_cts: qup-uart4-cts-pins { pins =3D "gpio16"; function =3D "qup04"; }; =20 - qup_uart4_rts: qup-uart4-rts { + qup_uart4_rts: qup-uart4-rts-pins { pins =3D "gpio17"; function =3D "qup04"; }; =20 - qup_uart4_tx: qup-uart4-tx { + qup_uart4_tx: qup-uart4-tx-pins { pins =3D "gpio18"; function =3D "qup04"; }; =20 - qup_uart4_rx: qup-uart4-rx { + qup_uart4_rx: qup-uart4-rx-pins { pins =3D "gpio19"; function =3D "qup04"; }; =20 - qup_uart5_cts: qup-uart5-cts { + qup_uart5_cts: qup-uart5-cts-pins { pins =3D "gpio20"; function =3D "qup05"; }; =20 - qup_uart5_rts: qup-uart5-rts { + qup_uart5_rts: qup-uart5-rts-pins { pins =3D "gpio21"; function =3D "qup05"; }; =20 - qup_uart5_tx: qup-uart5-tx { + qup_uart5_tx: qup-uart5-tx-pins { pins =3D "gpio22"; function =3D "qup05"; }; =20 - qup_uart5_rx: qup-uart5-rx { + qup_uart5_rx: qup-uart5-rx-pins { pins =3D "gpio23"; function =3D "qup05"; }; =20 - qup_uart6_cts: qup-uart6-cts { + qup_uart6_cts: qup-uart6-cts-pins { pins =3D "gpio24"; function =3D "qup06"; }; =20 - qup_uart6_rts: qup-uart6-rts { + qup_uart6_rts: qup-uart6-rts-pins { pins =3D "gpio25"; function =3D "qup06"; }; =20 - qup_uart6_tx: qup-uart6-tx { + qup_uart6_tx: qup-uart6-tx-pins { pins =3D "gpio26"; function =3D "qup06"; }; =20 - qup_uart6_rx: qup-uart6-rx { + qup_uart6_rx: qup-uart6-rx-pins { pins =3D "gpio27"; function =3D "qup06"; }; =20 - qup_uart7_cts: qup-uart7-cts { + qup_uart7_cts: qup-uart7-cts-pins { pins =3D "gpio28"; function =3D "qup07"; }; =20 - qup_uart7_rts: qup-uart7-rts { + qup_uart7_rts: qup-uart7-rts-pins { pins =3D "gpio29"; function =3D "qup07"; }; =20 - qup_uart7_tx: qup-uart7-tx { + qup_uart7_tx: qup-uart7-tx-pins { pins =3D "gpio30"; function =3D "qup07"; }; =20 - qup_uart7_rx: qup-uart7-rx { + qup_uart7_rx: qup-uart7-rx-pins { pins =3D "gpio31"; function =3D "qup07"; }; =20 - qup_uart8_cts: qup-uart8-cts { + qup_uart8_cts: qup-uart8-cts-pins { pins =3D "gpio32"; function =3D "qup10"; }; =20 - qup_uart8_rts: qup-uart8-rts { + qup_uart8_rts: qup-uart8-rts-pins { pins =3D "gpio33"; function =3D "qup10"; }; =20 - qup_uart8_tx: qup-uart8-tx { + qup_uart8_tx: qup-uart8-tx-pins { pins =3D "gpio34"; function =3D "qup10"; }; =20 - qup_uart8_rx: qup-uart8-rx { + qup_uart8_rx: qup-uart8-rx-pins { pins =3D "gpio35"; function =3D "qup10"; }; =20 - qup_uart9_cts: qup-uart9-cts { + qup_uart9_cts: qup-uart9-cts-pins { pins =3D "gpio36"; function =3D "qup11"; }; =20 - qup_uart9_rts: qup-uart9-rts { + qup_uart9_rts: qup-uart9-rts-pins { pins =3D "gpio37"; function =3D "qup11"; }; =20 - qup_uart9_tx: qup-uart9-tx { + qup_uart9_tx: qup-uart9-tx-pins { pins =3D "gpio38"; function =3D "qup11"; }; =20 - qup_uart9_rx: qup-uart9-rx { + qup_uart9_rx: qup-uart9-rx-pins { pins =3D "gpio39"; function =3D "qup11"; }; =20 - qup_uart10_cts: qup-uart10-cts { + qup_uart10_cts: qup-uart10-cts-pins { pins =3D "gpio40"; function =3D "qup12"; }; =20 - qup_uart10_rts: qup-uart10-rts { + qup_uart10_rts: qup-uart10-rts-pins { pins =3D "gpio41"; function =3D "qup12"; }; =20 - qup_uart10_tx: qup-uart10-tx { + qup_uart10_tx: qup-uart10-tx-pins { pins =3D "gpio42"; function =3D "qup12"; }; =20 - qup_uart10_rx: qup-uart10-rx { + qup_uart10_rx: qup-uart10-rx-pins { pins =3D "gpio43"; function =3D "qup12"; }; =20 - qup_uart11_cts: qup-uart11-cts { + qup_uart11_cts: qup-uart11-cts-pins { pins =3D "gpio44"; function =3D "qup13"; }; =20 - qup_uart11_rts: qup-uart11-rts { + qup_uart11_rts: qup-uart11-rts-pins { pins =3D "gpio45"; function =3D "qup13"; }; =20 - qup_uart11_tx: qup-uart11-tx { + qup_uart11_tx: qup-uart11-tx-pins { pins =3D "gpio46"; function =3D "qup13"; }; =20 - qup_uart11_rx: qup-uart11-rx { + qup_uart11_rx: qup-uart11-rx-pins { pins =3D "gpio47"; function =3D "qup13"; }; =20 - qup_uart12_cts: qup-uart12-cts { + qup_uart12_cts: qup-uart12-cts-pins { pins =3D "gpio48"; function =3D "qup14"; }; =20 - qup_uart12_rts: qup-uart12-rts { + qup_uart12_rts: qup-uart12-rts-pins { pins =3D "gpio49"; function =3D "qup14"; }; =20 - qup_uart12_tx: qup-uart12-tx { + qup_uart12_tx: qup-uart12-tx-pins { pins =3D "gpio50"; function =3D "qup14"; }; =20 - qup_uart12_rx: qup-uart12-rx { + qup_uart12_rx: qup-uart12-rx-pins { pins =3D "gpio51"; function =3D "qup14"; }; =20 - qup_uart13_cts: qup-uart13-cts { + qup_uart13_cts: qup-uart13-cts-pins { pins =3D "gpio52"; function =3D "qup15"; }; =20 - qup_uart13_rts: qup-uart13-rts { + qup_uart13_rts: qup-uart13-rts-pins { pins =3D "gpio53"; function =3D "qup15"; }; =20 - qup_uart13_tx: qup-uart13-tx { + qup_uart13_tx: qup-uart13-tx-pins { pins =3D "gpio54"; function =3D "qup15"; }; =20 - qup_uart13_rx: qup-uart13-rx { + qup_uart13_rx: qup-uart13-rx-pins { pins =3D "gpio55"; function =3D "qup15"; }; =20 - qup_uart14_cts: qup-uart14-cts { + qup_uart14_cts: qup-uart14-cts-pins { pins =3D "gpio56"; function =3D "qup16"; }; =20 - qup_uart14_rts: qup-uart14-rts { + qup_uart14_rts: qup-uart14-rts-pins { pins =3D "gpio57"; function =3D "qup16"; }; =20 - qup_uart14_tx: qup-uart14-tx { + qup_uart14_tx: qup-uart14-tx-pins { pins =3D "gpio58"; function =3D "qup16"; }; =20 - qup_uart14_rx: qup-uart14-rx { + qup_uart14_rx: qup-uart14-rx-pins { pins =3D "gpio59"; function =3D "qup16"; }; =20 - qup_uart15_cts: qup-uart15-cts { + qup_uart15_cts: qup-uart15-cts-pins { pins =3D "gpio60"; function =3D "qup17"; }; =20 - qup_uart15_rts: qup-uart15-rts { + qup_uart15_rts: qup-uart15-rts-pins { pins =3D "gpio61"; function =3D "qup17"; }; =20 - qup_uart15_tx: qup-uart15-tx { + qup_uart15_tx: qup-uart15-tx-pins { pins =3D "gpio62"; function =3D "qup17"; }; =20 - qup_uart15_rx: qup-uart15-rx { + qup_uart15_rx: qup-uart15-rx-pins { pins =3D "gpio63"; function =3D "qup17"; }; =20 - sdc1_clk: sdc1-clk { + sdc1_clk: sdc1-clk-pins { pins =3D "sdc1_clk"; }; =20 - sdc1_cmd: sdc1-cmd { + sdc1_cmd: sdc1-cmd-pins { pins =3D "sdc1_cmd"; }; =20 - sdc1_data: sdc1-data { + sdc1_data: sdc1-data-pins { pins =3D "sdc1_data"; }; =20 - sdc1_rclk: sdc1-rclk { + sdc1_rclk: sdc1-rclk-pins { pins =3D "sdc1_rclk"; }; =20 - sdc1_clk_sleep: sdc1-clk-sleep { + sdc1_clk_sleep: sdc1-clk-sleep-pins { pins =3D "sdc1_clk"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc1_cmd_sleep: sdc1-cmd-sleep { + sdc1_cmd_sleep: sdc1-cmd-sleep-pins { pins =3D "sdc1_cmd"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc1_data_sleep: sdc1-data-sleep { + sdc1_data_sleep: sdc1-data-sleep-pins { pins =3D "sdc1_data"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc1_rclk_sleep: sdc1-rclk-sleep { + sdc1_rclk_sleep: sdc1-rclk-sleep-pins { pins =3D "sdc1_rclk"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc2_clk: sdc2-clk { + sdc2_clk: sdc2-clk-pins { pins =3D "sdc2_clk"; }; =20 - sdc2_cmd: sdc2-cmd { + sdc2_cmd: sdc2-cmd-pins { pins =3D "sdc2_cmd"; }; =20 - sdc2_data: sdc2-data { + sdc2_data: sdc2-data-pins { pins =3D "sdc2_data"; }; =20 - sdc2_clk_sleep: sdc2-clk-sleep { + sdc2_clk_sleep: sdc2-clk-sleep-pins { pins =3D "sdc2_clk"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc2_cmd_sleep: sdc2-cmd-sleep { + sdc2_cmd_sleep: sdc2-cmd-sleep-pins { pins =3D "sdc2_cmd"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc2_data_sleep: sdc2-data-sleep { + sdc2_data_sleep: sdc2-data-sleep-pins { pins =3D "sdc2_data"; drive-strength =3D <2>; bias-bus-hold; --=20 2.34.1 From nobody Mon Apr 6 01:46:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0804ECAAD5 for ; Mon, 12 Sep 2022 06:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230324AbiILGWH (ORCPT ); Mon, 12 Sep 2022 02:22:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230181AbiILGVc (ORCPT ); Mon, 12 Sep 2022 02:21:32 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 163B128709 for ; Sun, 11 Sep 2022 23:19:15 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id k10so13155694lfm.4 for ; Sun, 11 Sep 2022 23:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=VVRMe5K9zQktuETEV7D34ZSBEU0mHzUqiBeP7TQimRg=; b=E9zZ3Djr07TS3fJj6umSRVrlBqZsmRosVs7UWiwoZ84qNN/a0cVp/MbBsxbDvNCRK4 C5PzUhuDTHzNoejdenm32fJ2OweRU0Ba1IodWlj6HzopWoL+AJtWDhtPW8BCMPIiBu+c l2YkgWv05vztqViwf+jj/DW/l0cVvqcEV3OEmjMYARPhi/aX+/uTK3bTtrxBJngTXC4z HlFxq0wupVH7fGCSL3l+sS8gAkYtfIEbVZpzdORYN/obVqWkMqM44XUykiTw1/g9wYw7 VuVfp5t4SncEfaeUCbiZ0KkYaI/Kn/dEDiajc7EHNyX0bGlUKKNH/42dhQApHtcct4jL sSXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=VVRMe5K9zQktuETEV7D34ZSBEU0mHzUqiBeP7TQimRg=; b=Sk12h8XeMTSTldWwIiJo+klnkq8SBpwRUuO4Qa3q6MXNfJw06oKhQlVDT7fl33SlJD gNWiLpUGBnkL9oQyh/lqzrvVKMvXIjJPXziROUhnifzJDHBWUOBld5JZunKRMj9w4tNl bNyT5mkUOxkquzqYuI5pa4oVl4Ze05LujOFmZB6oYRdlcu2EV4TH8WBbxHD8havQ2zNQ oKCsOM08mCCWzCdHIpDk/iPOfbTA77YxkR5PS1443tUgktR5AVeXc8P1oY93ghYHzKAI 84dJpISeod9ixzX8EKMMXpAsYGsWhPt/dH+SCzoCXYlAIuI6OEApmMlFUiXD9nh/qVwD KkaA== X-Gm-Message-State: ACgBeo1u9VmIn7maAK/KGSnEuvCRxfc5I2QAwREWxNCRO0Ncs6gwi44D T+lewoZCYmL3/Yp7LrCuAVmz8w== X-Google-Smtp-Source: AA6agR5Ef8VuKaloSkqcwAVTmW4EDULh+UlSiGV/k2vvbAxBjr8D2hI70ANVmlLY8cttjljJtvwDYw== X-Received: by 2002:ac2:5a46:0:b0:498:f53b:d19a with SMTP id r6-20020ac25a46000000b00498f53bd19amr5922678lfn.674.1662963529575; Sun, 11 Sep 2022 23:18:49 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:49 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 40/40] arm64: dts: qcom: sc7280-herobrine: correct TLMM gpio-line-names Date: Mon, 12 Sep 2022 08:17:46 +0200 Message-Id: <20220912061746.6311-41-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are 174 GPIOs in SC7280. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64= /boot/dts/qcom/sc7280-herobrine-crd.dts index bc795c480352..3448e9ed8b03 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts @@ -371,7 +371,5 @@ &tlmm { "", /* 170 */ "MOS_BLE_UART_TX", "MOS_BLE_UART_RX", - "", - "", ""; }; --=20 2.34.1