From nobody Mon Apr 6 03:08:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6528C6FA83 for ; Sun, 11 Sep 2022 16:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbiIKQUF (ORCPT ); Sun, 11 Sep 2022 12:20:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiIKQUD (ORCPT ); Sun, 11 Sep 2022 12:20:03 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F91713CEB for ; Sun, 11 Sep 2022 09:20:02 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id lc7so15079737ejb.0 for ; Sun, 11 Sep 2022 09:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GsdpeDwqiQ59y1KF9qjXgzUuhoO/WMpaF1rt8+KLfKc=; b=jEAk2DZ1D4pSbzFy8lLdAgFAIiZb75w2RbVNn5hDJNmFW1f6L3TQAr6G6Tt9lfOQgk vH+f3/7roALGxkIoUit65Ng9lf/Uh9Rhbf2QO3x81r32u8sMp7mq5RbnbkYwN+o/1Hvl ub9IWalSSz5UTwpMPK1hIXYk9NNipRjKQkQTJ09e306nd4i4I5ITLehbzzVNas0X4/3l 4hKLhpO7n0RyiRHVlLo/BDNw2fup4jbMagMbNY2fm7TxJ09UaWawn/nt/kVqvEGCJU+U f7z4ZtlSvkw74qNkvaLKiQCbiQy+JT95/SAPp3M/ox7wQTUjbXGkGwnl00OJKplef6w0 Ymmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GsdpeDwqiQ59y1KF9qjXgzUuhoO/WMpaF1rt8+KLfKc=; b=Cvwp2hagvQ2xLu9i49vi8vOYWYXdK1nnm4cy/ERS9FmKfWoSgtq52MWX6ZvIC2HPVU SqhNBK4TQpRhJMr1OFD3JnpcqGEffxNQYmPCIIrIXbkaIDormP3MSsxxZqJEJZd1BYa6 HxAwC7bzDF9zz6KCBujxDSB+lZBDgVfCx3tL7eNLsBBC+9w8EhkQYXJVcYwfF1+msKcP tdDKbn0WCLsMdZLfAFW8FUcEp4ruHqVWZ3n7yHkzPKx0UKSo/q4ir1u4p3tv2X4tRwl8 n3DdbwqfLkdpkNswLTp976TbIz184DOv2Z+LNRscxV3S76kizHLf762AA606eTpe+5sR 3EUA== X-Gm-Message-State: ACgBeo3bSSD5Nu3A9q9GcBQS6Bov3LDXDEtWSbPA8AinWdtbwiXX8yTW k5+jkB/J3Dsvd/b3yu6ilfM= X-Google-Smtp-Source: AA6agR75KgWe00X/90kNewrayvjKNnBiAKF5xum9uin/07Ow4IuT5iJzfv1899rRu1u5SkMRyhNXaA== X-Received: by 2002:a17:907:9729:b0:77c:3742:137a with SMTP id jg41-20020a170907972900b0077c3742137amr3000202ejc.630.1662913200779; Sun, 11 Sep 2022 09:20:00 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb6b.dynamic.kabel-deutschland.de. [95.90.187.107]) by smtp.gmail.com with ESMTPSA id bt6-20020a170906b14600b00779dc23be62sm3055346ejb.120.2022.09.11.09.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 09:20:00 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/6] staging: r8188eu: rename odm_SignalScaleMapping() Date: Sun, 11 Sep 2022 18:19:44 +0200 Message-Id: <20220911161949.11293-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220911161949.11293-1-straube.linux@gmail.com> References: <20220911161949.11293-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename odm_SignalScaleMapping() to avoid camel case. odm_SignalScaleMapping -> odm_signal_scale_mapping Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 035d94b3458e..cd6af491d5a8 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -13,7 +13,7 @@ static u8 odm_QueryRxPwrPercentage(s8 AntPower) return 100 + AntPower; } =20 -static s32 odm_SignalScaleMapping(struct odm_dm_struct *dm_odm, s32 CurrSi= g) +static s32 odm_signal_scale_mapping(struct odm_dm_struct *dm_odm, s32 Curr= Sig) { s32 RetSig =3D 0; =20 @@ -200,10 +200,10 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct o= dm_dm_struct *dm_odm, /* UI BSS List signal strength(in percentage), make it good looking, from= 0~100. */ /* It is assigned to the BSS List in GetValueFromBeaconOrProbeRsp(). */ if (isCCKrate) { - pPhyInfo->SignalStrength =3D (u8)(odm_SignalScaleMapping(dm_odm, PWDB_AL= L));/* PWDB_ALL; */ + pPhyInfo->SignalStrength =3D (u8)(odm_signal_scale_mapping(dm_odm, PWDB_= ALL));/* PWDB_ALL; */ } else { if (rf_rx_num !=3D 0) - pPhyInfo->SignalStrength =3D (u8)(odm_SignalScaleMapping(dm_odm, total_= rssi /=3D rf_rx_num)); + pPhyInfo->SignalStrength =3D (u8)(odm_signal_scale_mapping(dm_odm, tota= l_rssi /=3D rf_rx_num)); } =20 /* For 88E HW Antenna Diversity */ --=20 2.37.3 From nobody Mon Apr 6 03:08:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC6B7ECAAD3 for ; Sun, 11 Sep 2022 16:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229577AbiIKQUJ (ORCPT ); Sun, 11 Sep 2022 12:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbiIKQUF (ORCPT ); Sun, 11 Sep 2022 12:20:05 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0768913CDA for ; Sun, 11 Sep 2022 09:20:03 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id t5so9495315edc.11 for ; Sun, 11 Sep 2022 09:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=NYhdzoo6tM23KOShyzRyKjHKkaVDcrKz7iHGaueE0HU=; b=SRCxa55iJ/03fwJDnBkzsV38RX0UDP8cPGHBKrsU/GK9UhHXwyZSQhN9SUIbmpOYYR RjafR0Ewp7chC1atKddyjizH9+rUUmTAUhxRlOF7YvY0gJ/iTMqIxitPtMrkcf0aXCVI HhZ0SupndPObbaUQdS+OPeH8JyMcrGscxrBAlTvJRzMHdLcityxbNrCHpuh0AqA9dUGB Mh/62tdJWzqcRAUyTxke4BChSdXaYhgJGiChkN612stqoHlAGmAl2AFMNkNwvBe2KUU+ KQrzDGg6CbQlnH0qP9sz1OEsmYz7BTmQRwzOl9bEn/I5/C0mNI1pfwiJbgvquRkbMS9T whBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=NYhdzoo6tM23KOShyzRyKjHKkaVDcrKz7iHGaueE0HU=; b=qOQNH2I4BFUHddyibWX+hTlccN0E7CLBbwThyC73hQjNVIP2Ly8jK0BIeOR5X2nBI5 /e5hOm8AuXS9W1TVT5etg3LCZlTsufzmumkvcs8+7wFjU3LSxjNe8p01onRq6AKI4/HL 4A5nI7gh07jHIxUfSokSdwPilnb+ItMpiB2hTfyX9b9nU5l2iWibedRZSBrltq5hWd1e AEmyLldVAFSEIIxAB9wOIZVZJXSUh1v8DZNWTnKTCKL0H6+9VJ2bLsGvjO8ycNg2bxZm HGxdhvQhF6CUXHWRhS2GsukAqjpZg3F12MR6GIiuCC06sMxSrFuFzYryIzhix9mC8yoQ /Axw== X-Gm-Message-State: ACgBeo0wivCJErUmvC6rVg1drD6D2mP0fV/P5CjB/3LMuqdgYRRUhUwW xjnPOqluVFRcXqgnIVaSamCEcHC9FGc= X-Google-Smtp-Source: AA6agR7WzDP20gXCr9U5do86/epHo+otMYu6GuGXJyy7XrB9saBTiDGJ0oPBer8TRe/RiyuaHi7u5g== X-Received: by 2002:a05:6402:2694:b0:450:d537:f6d6 with SMTP id w20-20020a056402269400b00450d537f6d6mr13804306edd.344.1662913201636; Sun, 11 Sep 2022 09:20:01 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb6b.dynamic.kabel-deutschland.de. [95.90.187.107]) by smtp.gmail.com with ESMTPSA id bt6-20020a170906b14600b00779dc23be62sm3055346ejb.120.2022.09.11.09.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 09:20:01 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/6] staging: r8188eu: clean up camel case in odm_signal_scale_mapping() Date: Sun, 11 Sep 2022 18:19:45 +0200 Message-Id: <20220911161949.11293-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220911161949.11293-1-straube.linux@gmail.com> References: <20220911161949.11293-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variables in odm_signal_scale_mapping() to avoid camel case. CurrSig -> currsig RetSig -> retsig Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 38 +++++++++++----------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index cd6af491d5a8..5fd53c60f762 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -13,28 +13,28 @@ static u8 odm_QueryRxPwrPercentage(s8 AntPower) return 100 + AntPower; } =20 -static s32 odm_signal_scale_mapping(struct odm_dm_struct *dm_odm, s32 Curr= Sig) +static s32 odm_signal_scale_mapping(struct odm_dm_struct *dm_odm, s32 curr= sig) { - s32 RetSig =3D 0; - - if (CurrSig >=3D 51 && CurrSig <=3D 100) - RetSig =3D 100; - else if (CurrSig >=3D 41 && CurrSig <=3D 50) - RetSig =3D 80 + ((CurrSig - 40) * 2); - else if (CurrSig >=3D 31 && CurrSig <=3D 40) - RetSig =3D 66 + (CurrSig - 30); - else if (CurrSig >=3D 21 && CurrSig <=3D 30) - RetSig =3D 54 + (CurrSig - 20); - else if (CurrSig >=3D 10 && CurrSig <=3D 20) - RetSig =3D 42 + (((CurrSig - 10) * 2) / 3); - else if (CurrSig >=3D 5 && CurrSig <=3D 9) - RetSig =3D 22 + (((CurrSig - 5) * 3) / 2); - else if (CurrSig >=3D 1 && CurrSig <=3D 4) - RetSig =3D 6 + (((CurrSig - 1) * 3) / 2); + s32 retsig =3D 0; + + if (currsig >=3D 51 && currsig <=3D 100) + retsig =3D 100; + else if (currsig >=3D 41 && currsig <=3D 50) + retsig =3D 80 + ((currsig - 40) * 2); + else if (currsig >=3D 31 && currsig <=3D 40) + retsig =3D 66 + (currsig - 30); + else if (currsig >=3D 21 && currsig <=3D 30) + retsig =3D 54 + (currsig - 20); + else if (currsig >=3D 10 && currsig <=3D 20) + retsig =3D 42 + (((currsig - 10) * 2) / 3); + else if (currsig >=3D 5 && currsig <=3D 9) + retsig =3D 22 + (((currsig - 5) * 3) / 2); + else if (currsig >=3D 1 && currsig <=3D 4) + retsig =3D 6 + (((currsig - 1) * 3) / 2); else - RetSig =3D CurrSig; + retsig =3D currsig; =20 - return RetSig; + return retsig; } =20 static u8 odm_evm_db_to_percentage(s8 value) --=20 2.37.3 From nobody Mon Apr 6 03:08:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6DBC54EE9 for ; Sun, 11 Sep 2022 16:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229728AbiIKQUQ (ORCPT ); Sun, 11 Sep 2022 12:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiIKQUF (ORCPT ); Sun, 11 Sep 2022 12:20:05 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C434D13DF7 for ; Sun, 11 Sep 2022 09:20:03 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id e17so9537075edc.5 for ; Sun, 11 Sep 2022 09:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=mslrvAnEr3TpSO5X38U+iS/S6NUXdhZVFElJnWUwu3s=; b=GD3M6ZeYw41YJxJi7HhErMRuFz+d5shSG79sMa/sNp7AOJBdOFt3pHVyTrMIB+ckvD ueHwsKZ6/A3gNHX9f5S9CywFaseSlRQsaIX1M837b8IsWgdB5KlMBqAG5J5AYs0PDapi N8jfeKJS3hdsd5doN2zbEb2qwxUUzXwVK56eGGtqquBfAdz+3YCrUrt3o2NejE8qkz6v nuQ5QQaHh5ND6TXbabOrE8GCx3QMQb0gT4eVrmeNdsnPN+k65x6pFkDrD6WutUWGdqjb acznzub9cg8fMmrkfxMnuUDfIv1wGPjPXZ1zjrLNmTIUxSqlVs4Tm4Y+2KDgZFrwmUvn MEcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=mslrvAnEr3TpSO5X38U+iS/S6NUXdhZVFElJnWUwu3s=; b=Rdc/xpKA5LRg6bRj+i0t7rdVQmixC7kQQc25CSH+6p34tRxvne+M/bj7081fFh8p5n zD/7iCUT4v7eZxBPQWkos79tRaxmBoN1V+C7SEqXttDV2D5AhCwdPPTROkipXcvpCpNe rCpVCmpJ7+MwUy1JePwa2F7sSAuNecKJYAuyTlUueG0525vUTTF0wPoHLROcHIyMQtzj NBtVl6hOrNGzJOJVp5BXORqe21ISbk6S7+kFk03IjdsBDTOXQkKE7a8kb/BQI6t6Xx5+ AczHuRBvxkd1rxiUvvGSScaVDr9DPBoShdsYU4JXy6iqnjDTZ6I1vw62XGdFMH/AVMqb yYMQ== X-Gm-Message-State: ACgBeo1fHM0Yz6mjiq2Vc6vV1yo7IEWcAQ2FOqYpJ+tF5mstdqVhq7tk dIdkC3r0MI9eJ3HirkFyrVY= X-Google-Smtp-Source: AA6agR6tKfXAXP4ZvieTYvpgPNZkdMlKGl526lwtq9Jt3HoZKR16Wluu3yKdKmixn+UXnjxGsaHQ7w== X-Received: by 2002:aa7:c1ce:0:b0:44d:d5b4:adf5 with SMTP id d14-20020aa7c1ce000000b0044dd5b4adf5mr19845305edp.182.1662913202426; Sun, 11 Sep 2022 09:20:02 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb6b.dynamic.kabel-deutschland.de. [95.90.187.107]) by smtp.gmail.com with ESMTPSA id bt6-20020a170906b14600b00779dc23be62sm3055346ejb.120.2022.09.11.09.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 09:20:01 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/6] staging: r8188eu: remove unnecessary initialization Date: Sun, 11 Sep 2022 18:19:46 +0200 Message-Id: <20220911161949.11293-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220911161949.11293-1-straube.linux@gmail.com> References: <20220911161949.11293-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The variable 'retsig' in odm_signal_scale_mapping() is set in the function before it returns, so it is not needed to initialize it. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 5fd53c60f762..a557c5d1542e 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -15,7 +15,7 @@ static u8 odm_QueryRxPwrPercentage(s8 AntPower) =20 static s32 odm_signal_scale_mapping(struct odm_dm_struct *dm_odm, s32 curr= sig) { - s32 retsig =3D 0; + s32 retsig; =20 if (currsig >=3D 51 && currsig <=3D 100) retsig =3D 100; --=20 2.37.3 From nobody Mon Apr 6 03:08:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89DDEC54EE9 for ; Sun, 11 Sep 2022 16:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229492AbiIKQUZ (ORCPT ); Sun, 11 Sep 2022 12:20:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbiIKQUG (ORCPT ); Sun, 11 Sep 2022 12:20:06 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B90F213F02 for ; Sun, 11 Sep 2022 09:20:04 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id wc11so427120ejb.4 for ; Sun, 11 Sep 2022 09:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=5/IIZbWRTXX4L4GClXT0KhOjJ/7HccMx71oM1JZ+Wao=; b=qt8DPBK9nsHDVjwGrqgLpBzVPfG65OzLmfeda/YIKHJx0dLGFN5IpJ0SPQgo4zXgrL q3ZUsNblrO/WcjTt2zoHCg3LI+jX3+XHGc/flOWysgFAkk9kHDfQX07Uz8aJYOQ9t6aS mjY+0vEE7wNFrAR+6S6aryGt73ywxVgDIYmvTdRH0MUK4d7udGVzH6Nfq8rhA84bfAz8 fRZ6gbOHO1gBJCm9Hs5VBNa/WOcH/WL4pHe4pMdP0UqOkf1B0bx357EkzGSmAkrNWYFm e9dpXBps38bCfqH18A41Li2ANSNKWeV8sD+46tciiPQ9aLkEy7JS100oV+qq7MXtL//f Gi5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=5/IIZbWRTXX4L4GClXT0KhOjJ/7HccMx71oM1JZ+Wao=; b=I9Ip9PmXJopFHfogF9/6x8PruNsFvLtHo9HUb4kJYBAs8gQr1uQpuJs2WGoJh+R4tu u2nkGAiNM6BMpq2lLhtCE4bIn1MusxxEhOX0moK6bH+VCZ6k/yJzjoFHuhnio9TcoxAi XiGT9eIvA8/AMGKQl22+kix/hrhHm/5JfmzjhzPtqsajDm5ealaXYK3gTPq8ckpyUway thOEP5edYtnOl6HS0qcDWeNQMxFQDOI61MhzB/9mqiUr9+K9qMSpjPD1XMTCIijTlx8Y men2WAv5FnsI6lT2Qtooj85/Az6zUAYkTcosDL5C0lFWna5B14EVpBcrSrV0VF2TuUV7 jvwQ== X-Gm-Message-State: ACgBeo1bm0V+c7JWKr3qOBtr/LPBq4gKrghOknr+m4I77saF+l4IESAz n/HH4IdeWXLCRWCSICXOiO0= X-Google-Smtp-Source: AA6agR4+ga2QghFLqkPTwzMTva+vEGzt6fMB58RBbVxHQE77kDfdgtbFZmbQmtBlI4nyOY1iQC85Gw== X-Received: by 2002:a17:906:fc6:b0:72f:d080:416 with SMTP id c6-20020a1709060fc600b0072fd0800416mr16218426ejk.1.1662913203217; Sun, 11 Sep 2022 09:20:03 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb6b.dynamic.kabel-deutschland.de. [95.90.187.107]) by smtp.gmail.com with ESMTPSA id bt6-20020a170906b14600b00779dc23be62sm3055346ejb.120.2022.09.11.09.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 09:20:02 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/6] staging: r8188eu: rename odm_QueryRxPwrPercentage() Date: Sun, 11 Sep 2022 18:19:47 +0200 Message-Id: <20220911161949.11293-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220911161949.11293-1-straube.linux@gmail.com> References: <20220911161949.11293-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename odm_QueryRxPwrPercentage() to avoid camel case. odm_QueryRxPwrPercentage -> odm_query_rxpwrpercentage Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index a557c5d1542e..8b292644b38c 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -3,7 +3,7 @@ =20 #include "../include/drv_types.h" =20 -static u8 odm_QueryRxPwrPercentage(s8 AntPower) +static u8 odm_query_rxpwrpercentage(s8 AntPower) { if ((AntPower <=3D -100) || (AntPower >=3D 20)) return 0; @@ -117,7 +117,7 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm= _dm_struct *dm_odm, break; } rx_pwr_all +=3D 6; - PWDB_ALL =3D odm_QueryRxPwrPercentage(rx_pwr_all); + PWDB_ALL =3D odm_query_rxpwrpercentage(rx_pwr_all); if (!cck_highpwr) { if (PWDB_ALL >=3D 80) PWDB_ALL =3D ((PWDB_ALL - 80) << 1) + ((PWDB_ALL - 80) >> 1) + 80; @@ -162,7 +162,7 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm= _dm_struct *dm_odm, pPhyInfo->RxPwr[i] =3D rx_pwr[i]; =20 /* Translate DBM to percentage. */ - RSSI =3D odm_QueryRxPwrPercentage(rx_pwr[i]); + RSSI =3D odm_query_rxpwrpercentage(rx_pwr[i]); total_rssi +=3D RSSI; =20 pPhyInfo->RxMIMOSignalStrength[i] =3D (u8)RSSI; @@ -173,7 +173,7 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm= _dm_struct *dm_odm, /* (2)PWDB, Average PWDB calculated by hardware (for rate adaptive) */ rx_pwr_all =3D (((pPhyStaRpt->cck_sig_qual_ofdm_pwdb_all) >> 1) & 0x7f) = - 110; =20 - PWDB_ALL =3D odm_QueryRxPwrPercentage(rx_pwr_all); + PWDB_ALL =3D odm_query_rxpwrpercentage(rx_pwr_all); =20 pPhyInfo->RxPWDBAll =3D PWDB_ALL; pPhyInfo->RxPower =3D rx_pwr_all; --=20 2.37.3 From nobody Mon Apr 6 03:08:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD674ECAAD3 for ; Sun, 11 Sep 2022 16:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbiIKQUV (ORCPT ); Sun, 11 Sep 2022 12:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbiIKQUG (ORCPT ); Sun, 11 Sep 2022 12:20:06 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F6D313CDA for ; Sun, 11 Sep 2022 09:20:05 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id b16so9529953edd.4 for ; Sun, 11 Sep 2022 09:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=7Js629KccG6US13KeuTls+//WPiM69Qewjdm7oxTyss=; b=exh23MC1wmkoMevZsAfh6BeY6VdclumO4+EVDAW5TaAhleMQFIv46cC/14CfNbIoQL 7PEEyzocz3AqrNvKZIJYYqLbDM5z5GXkb/cSWfaOjey9UkJLEvvAYLU+eUPNtYiQjL+8 lkzPSpxYK1xXSFgI8iuI9UEX8TVE4JUU9AfIdtNppK5VyKImmw7MCzLWwlwRwcKD4pRm EgpITl9WhNURF7hcrNoqDeB1XYfz5lYvBoyBiwJrIBwh3bjedGWBBIVfa6o/Z/3yUbwQ /9IHBILTcp+57nxTEPRv9cO0FsL/s92dzLK9UKELTxE39a38L6d4ZJJ1K5jo3IEBETUf umdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=7Js629KccG6US13KeuTls+//WPiM69Qewjdm7oxTyss=; b=479k2wYamiz+IwqoZFXvm83qTDnEoEPusajSAAVAvkTqV+B6B73G05cWzBrpjruB3M F3TE6vvCxY7YJYtv/0YM1pl36EpNIzAIqFWvNoIlYue96zRfEmSLBIzMBttSC1MyUuGC SjfGOr7YV6h6shJ1T5XRaFfi5rZeIM06XUPfZ9lncw7P9kiZjRbzJeevttAC/b3K20BV RQmYs7zBwdeTIGI8tU2Ciq3nSXZifZ5QKWL+rBQPID5NicAXsf93kjRN0dEkS0w39ezV JVbcsUxMKYASN0Ez75V8fbHBLW65IW9E7Kq/L2pTM9ToVYtbdsGJDWO3ApV1ebn0Pmel SZKA== X-Gm-Message-State: ACgBeo0ZtZZ5EaKF4eFUSSkgJ+7MkDBik1zPYmys46hAQ9TGvoofi0kt 66TqQfg1vCN0X0mqYGuU3RQ= X-Google-Smtp-Source: AA6agR6ZemwosBaG90ca0b8HEp0c1KwbAyNmsaPG+GhcgveHCkzeBHVx/aLKeAMWtdIWbWSKH+UegA== X-Received: by 2002:a05:6402:298d:b0:451:5fc5:d423 with SMTP id eq13-20020a056402298d00b004515fc5d423mr5403672edb.102.1662913203984; Sun, 11 Sep 2022 09:20:03 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb6b.dynamic.kabel-deutschland.de. [95.90.187.107]) by smtp.gmail.com with ESMTPSA id bt6-20020a170906b14600b00779dc23be62sm3055346ejb.120.2022.09.11.09.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 09:20:03 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 5/6] staging: r8188eu: clean up camel case in odm_query_rxpwrpercentage() Date: Sun, 11 Sep 2022 18:19:48 +0200 Message-Id: <20220911161949.11293-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220911161949.11293-1-straube.linux@gmail.com> References: <20220911161949.11293-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename the variable 'AntPower' in odm_query_rxpwrpercentage() to avoid camel case. AntPower -> antpower Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 8b292644b38c..a870973395f6 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -3,14 +3,14 @@ =20 #include "../include/drv_types.h" =20 -static u8 odm_query_rxpwrpercentage(s8 AntPower) +static u8 odm_query_rxpwrpercentage(s8 antpower) { - if ((AntPower <=3D -100) || (AntPower >=3D 20)) + if ((antpower <=3D -100) || (antpower >=3D 20)) return 0; - else if (AntPower >=3D 0) + else if (antpower >=3D 0) return 100; else - return 100 + AntPower; + return 100 + antpower; } =20 static s32 odm_signal_scale_mapping(struct odm_dm_struct *dm_odm, s32 curr= sig) --=20 2.37.3 From nobody Mon Apr 6 03:08:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2246C54EE9 for ; Sun, 11 Sep 2022 16:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiIKQUa (ORCPT ); Sun, 11 Sep 2022 12:20:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbiIKQUL (ORCPT ); Sun, 11 Sep 2022 12:20:11 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8239014029 for ; Sun, 11 Sep 2022 09:20:06 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id y17so9916752ejo.6 for ; Sun, 11 Sep 2022 09:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=xUphcrXxQc1ipnQhfpFIDYBTmrSlFRYJTDjjM/qgN3o=; b=hWI2lxW+3yst5tOygYtWH3uD42UCnBngUblM6Yl6sFe60p/mlNy5ItkZPgWyg8IM+B Bq0M5BY04O4kcIXAe7u5nH0pN5BZcToXyQ3y6ARmtW6yJJlXDV11wEB8cznjrroOK3nP Fvo6LvlKsX4nLh35c89hqbVR1mImbSBqJ6ftnvOyLLR098QvjSy8w7ZVhZ1yYmMvC7hr fG8kYJ7T93BZIdO8A8zaJtfs8CgGxTnIjBEsBwGPC2ZpwFzOX/FKf4UWbvM+GT7csOjl +Su4Ew6tjRJOx32gnbe7auOvnBjzXnz/dupbXyuy7oAXkrOovF9b48dugLe/qwTg5sdu Gm/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=xUphcrXxQc1ipnQhfpFIDYBTmrSlFRYJTDjjM/qgN3o=; b=ZgQuDTxDKUQTZWgKs5k659IDXBJTCbcM2BVETa9FwUwsj9RJxHw82b+331QfZYCfKm E9QE1QP1p8ozNywqeR2vAbJved8gwODiSiRfXC8QL1y7SqYxlbZuLRmCT7Pvb2TAoRnv 3tkDKGqLLzlYsubGbnLficDktAHrKzpqDG/oQNrAeS4puGYnOXNmyWcxTowOi45BCpHz lMD04+VBJIrOsK6tf+Z08SLC9+jKeu1QxF8voQ1XOweoYiVjYo92j1CnozeMU/zBS2Et T75qnrNHHYWF3GkUB/r6DRvMHR+rDNvio/cbP2EtRnKIhHYwOXbqOjAO20sWOe7NuL7Y 5zMw== X-Gm-Message-State: ACgBeo01vJlDehP29L3WHkVOQaSsOFm6qHH0RWLF7Q5ZHROjHG04nbZD UoF4c13YTfwgRU90Lqfm5Fs= X-Google-Smtp-Source: AA6agR7kp7AB1fLPUmeg1WKG0Ar+XXUfe3/HxCUunyPfSboqDsOv1dfV8VH86SApTcJKR2uFcJo7gg== X-Received: by 2002:a17:907:31ce:b0:742:1206:529e with SMTP id xf14-20020a17090731ce00b007421206529emr16006575ejb.643.1662913205042; Sun, 11 Sep 2022 09:20:05 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb6b.dynamic.kabel-deutschland.de. [95.90.187.107]) by smtp.gmail.com with ESMTPSA id bt6-20020a170906b14600b00779dc23be62sm3055346ejb.120.2022.09.11.09.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 09:20:04 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 6/6] staging: r8188eu: replace tabs with space in odm_query_rxpwrpercentage() Date: Sun, 11 Sep 2022 18:19:49 +0200 Message-Id: <20220911161949.11293-7-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220911161949.11293-1-straube.linux@gmail.com> References: <20220911161949.11293-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In statements spaces should be used not tabs. Replace tabs withs spaces in two return statements in odm_query_rxpwrpercentage(). Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index a870973395f6..38f357e8aeda 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -6,9 +6,9 @@ static u8 odm_query_rxpwrpercentage(s8 antpower) { if ((antpower <=3D -100) || (antpower >=3D 20)) - return 0; + return 0; else if (antpower >=3D 0) - return 100; + return 100; else return 100 + antpower; } --=20 2.37.3