From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D99C6FA8D for ; Sun, 11 Sep 2022 11:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbiIKLMS (ORCPT ); Sun, 11 Sep 2022 07:12:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbiIKLMK (ORCPT ); Sun, 11 Sep 2022 07:12:10 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8C532B88 for ; Sun, 11 Sep 2022 04:12:07 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id l12so7395394ljg.9 for ; Sun, 11 Sep 2022 04:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=85V1z4OqIWufHfQcREFlCkHGXRpOp1EI7O4MBaWUk5Y=; b=d6m2dqm0zPkC52J4gJ/OMse/5xIzFQi8llLAstyimsEETJP2U7Ra4+gPqbjPgzhvAi 7qGTBReqynDOhLtW3L+cHA6MpEwyAFlEkurPk8YhiCmIsxyrfJelCWqmHF2GoJqChhI4 YVZKZ/VLS462h9RmZ54uqA7s9SRht66DL5UvNhJgwNQ/YF7emXDKSdzxC6Ez7kjmWlpP gSo4NGEAdR8wKGU8jiWR2ZLec1nGk7Ghk4uDiPCvotS+26sP6cHB0ApEQwrERmYR85ta nQSrf75tF6d7PvTozkGoZlytOvhT1h8kcWM3u+XE/SPFjQASHyVLF97U+IKbk1j+70dQ AU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=85V1z4OqIWufHfQcREFlCkHGXRpOp1EI7O4MBaWUk5Y=; b=wzbtFuI1woiMHbThO8FTgw1do0OvRq2htCqpCapPgqHOHe3ujqXDil97H8tuDWgG9M 09O1OjfKhchepaiNg67V+FIaJDMat4QuyfCC3MuD1euogCbHt8mx5X/Cp0gUfU7dX5fr kEXdy1opf7FOn1jMR67X2eyeeO85iIazSaCMYFZfQNqmbhu0R+eLbRdeX/LXEUs2CI/H M+uNkWvHmhHyvqBDfEhh+AnuMDHED+7WoQX4iQNNKIRDdEEItmlYxUb7aAc6Ucxunjqi jnULOdItFpwK5Pm4wuEqcZBWrtar+BTJmchZoUtMVQ8pmYqBcIiWnfu8Wo7OriC3n/9f Ax+A== X-Gm-Message-State: ACgBeo37hHe6MHjTDNh273WDBw1oBsukJUhIlnT8rOLx6HcNWIEKGPeB 2Iqe6UIe3YHmc15WRmYl1FaO4g== X-Google-Smtp-Source: AA6agR77H1mhR02bURJCSDjh8vvw7TXF9G5tDmwjugg0JNVaapXWHYWsgnrx5kA6sfZStUl0VVF4fA== X-Received: by 2002:a2e:5d0:0:b0:26a:9a2d:ca90 with SMTP id 199-20020a2e05d0000000b0026a9a2dca90mr5946720ljf.102.1662894725931; Sun, 11 Sep 2022 04:12:05 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:05 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 01/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:21 +0200 Message-Id: <20220911111200.199182-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iskren Chernev --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index d8443811767d..8a2b4767c7b6 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -59,8 +59,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6115-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6115-tlmm-state" + additionalProperties: false =20 '$defs': qcom-sm6115-tlmm-state: @@ -155,25 +156,25 @@ examples: gpio-ranges =3D <&tlmm 0 0 114>; =20 sdc2_on_state: sdc2-on-state { - clk { + clk-pins { pins =3D "sdc2_clk"; bias-disable; drive-strength =3D <16>; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; bias-pull-up; drive-strength =3D <10>; }; =20 - data { + data-pins { pins =3D "sdc2_data"; bias-pull-up; drive-strength =3D <10>; }; =20 - sd-cd { + sd-cd-pins { pins =3D "gpio88"; function =3D "gpio"; bias-pull-up; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A48ECAAA1 for ; Sun, 11 Sep 2022 11:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbiIKLMO (ORCPT ); Sun, 11 Sep 2022 07:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230107AbiIKLMK (ORCPT ); Sun, 11 Sep 2022 07:12:10 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E84432B8C for ; Sun, 11 Sep 2022 04:12:08 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id bt10so10404565lfb.1 for ; Sun, 11 Sep 2022 04:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ULI4E1YGBzuTdtZhggajmSSNmIlXGsKZGjNlYp+12Qw=; b=RuYCb2kd6bIExQCrcE/2UvzSKGbCtuvzauVOaDIaH2C4DIjolIQL6ArQE+EsKfd/Kq hayS1iEymsuhuhnkHCAxx8ogff7ELBxPIJ/YUT0c2UGvsaYNvhbVGmuy63smumXCIx9A grFPDUuCLKfFJTsU5WY2jIELdAcY8Y5WXf+t/OI4fbstJlH81l5dZfvi7F8RTxh35FwV 77kv6d9ggFfyultFuxN8lbhMbaDV3H9EyYAD8xR3+dYIUc1TVwbjCiBMiVHFfcUH8gSD 0N9g+XLjNdUBh//sKa9uSWivA0LKU1jxDHK6RXjpPpshoLjJ7Tp7zqP3b86dU40dOg5f OIZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ULI4E1YGBzuTdtZhggajmSSNmIlXGsKZGjNlYp+12Qw=; b=E2FWUWZ+vz0M4k5YK1MUI9P/MVGrF6PZ5A+J32k5TnqqfjhFRUk18H+e4CjhgdOqMN r0O4IleyOF98IHq0Q9mEEHEgALSINyT6e0g4rPTJ/G9OSXRwznuKBHom+t+kGv+AHvzd /5ZYqLi+VLa+1u/g/ON5RvKmxgbDAwF5PWUv6GqiLmpYf+lq0r+aYrQDH31Pwi9RGhIm U+zKswdvrmPto8RvGfDzm/46/nokbwNHne0nR/+9MvIBA3XR0Xk85xYN2jNvxZWoROP/ 7HDb0y43NrLoHDcBkoXuDpSq29b/Gke59AatsP0/PQ/ej6SnVeQUZEibSfS/ZdOJiDcv 9Tew== X-Gm-Message-State: ACgBeo09z2dsbYK046tPRCtO37K1VLJkJwM1Y8qOV1ObStN3gUacjGU6 8+JDrRi+4ikn5aGCXd3NDNuIxg== X-Google-Smtp-Source: AA6agR4mVMIRU8kdKCWGn6F7du/Q7/hA9RJ8JPUJVZgTSHFVXov+ZPEGgjpDXMtmlvkLdSGUmnI/Og== X-Received: by 2002:a05:6512:2294:b0:494:8dc5:10af with SMTP id f20-20020a056512229400b004948dc510afmr6718001lfu.426.1662894727027; Sun, 11 Sep 2022 04:12:07 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:06 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix matching SD card pins Date: Sun, 11 Sep 2022 13:11:22 +0200 Message-Id: <20220911111200.199182-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" SD card pins do not have function, so do not require it: pinctrl@500000: sdc2-off-state: 'oneOf' conditional failed, one must be f= ixed: 'pins' is a required property 'bias-disable;' is a required property 'clk-pins' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index 8a2b4767c7b6..28b29bf714b4 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -69,7 +69,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -121,6 +120,16 @@ patternProperties: required: - pins =20 + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" + then: + required: + - function + additionalProperties: false =20 allOf: --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E77AC6FA8E for ; Sun, 11 Sep 2022 11:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230158AbiIKLMZ (ORCPT ); Sun, 11 Sep 2022 07:12:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230150AbiIKLMM (ORCPT ); Sun, 11 Sep 2022 07:12:12 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53CC532AAD for ; Sun, 11 Sep 2022 04:12:09 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id f14so9403125lfg.5 for ; Sun, 11 Sep 2022 04:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=WuNuBKTLriSBOY3KzJZlVDULqq0LYp0F6kHtXN1EUic=; b=JRVUwSOVnd3I2XhJVPfw5ZXXfOBdv1fHnkR2UdcVEgvbqgjvgVcyoxPjDFx9sUD4PT 8eSCCWyBGTDgQK53BeTrbwokhrk5dJmAkiwuZ73toHD62VHTeteJi/LhdrhtY50uYvBU ol74O8Lxw6Rh+bvp7JOfFnJcQfqVD6GXOrMToa0DJk/WwzGbFE8T7+EumKyKJhSMdLgm JJp2Nc6xiEfRNxwCNvQZiD+ek+YTBvNC7tO/G76NKsOUnuUqAQNq/F2dXO7OTWGlizdo b/QNvsnFpmJPRJqvB9wWYwsF9D6RNWhKuvwXsrtgXtKfhKaMl+RJgxzjJyECCJKvTd5G Y6Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=WuNuBKTLriSBOY3KzJZlVDULqq0LYp0F6kHtXN1EUic=; b=mhVAZlHXSdDBUYJXu+9GH+mcJ7RmTbotVwLJ6Ic2yZOjbqUuicOXlwcl29Rny7sea1 bXyCKYOXNcNdQ9Ep9j0C+xRoyHtOdiNeIwupmyo6ozbZ8L8hYLFF562RcmAdTrZYBhGl fzWNDUbDyCaYBy7gKy4JImOl+UNfPFyvaSjCnJ/+boQmM6crnco0iUQz6dX0aeHj7RCf VrqQva1waraa8yiUoTBrfERZfRj4lMa5LfLeHqDg3UilJ16aScytdEKuNSILPD5l/uG8 LlJ0td43hnESxHtq8i/gPclffx5JCYrpy9x+L8bbwvAXEJM8oW4JSnPag7KZzZR6T7un 0VrA== X-Gm-Message-State: ACgBeo2kWm/kvWDUuPcQG/LVBG7uCjJ3eCd7joyDVaXqqy8/tn9H8XZS 4gg5H/+b9HktMAD0f8cGsgcFYg== X-Google-Smtp-Source: AA6agR6n3KRWcd5ghmh4ehITymhk7BjNz8BbyRpDkNRt2KauvnkCpwjY1w0Vmw+d/+xowTwzmTzzPg== X-Received: by 2002:a05:6512:2302:b0:492:ce48:1bab with SMTP id o2-20020a056512230200b00492ce481babmr6680085lfu.266.1662894728127; Sun, 11 Sep 2022 04:12:08 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:07 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 03/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:23 +0200 Message-Id: <20220911111200.199182-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 80 +++++++++---------- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index 28b29bf714b4..e39fbb36d8c1 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -150,44 +150,44 @@ additionalProperties: false =20 examples: - | - #include - tlmm: pinctrl@500000 { - compatible =3D "qcom,sm6115-tlmm"; - reg =3D <0x500000 0x400000>, - <0x900000 0x400000>, - <0xd00000 0x400000>; - reg-names =3D "west", "south", "east"; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 114>; - - sdc2_on_state: sdc2-on-state { - clk-pins { - pins =3D "sdc2_clk"; - bias-disable; - drive-strength =3D <16>; - }; - - cmd-pins { - pins =3D "sdc2_cmd"; - bias-pull-up; - drive-strength =3D <10>; - }; - - data-pins { - pins =3D "sdc2_data"; - bias-pull-up; - drive-strength =3D <10>; - }; - - sd-cd-pins { - pins =3D "gpio88"; - function =3D "gpio"; - bias-pull-up; - drive-strength =3D <2>; - }; - }; + #include + tlmm: pinctrl@500000 { + compatible =3D "qcom,sm6115-tlmm"; + reg =3D <0x500000 0x400000>, + <0x900000 0x400000>, + <0xd00000 0x400000>; + reg-names =3D "west", "south", "east"; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 114>; + + sdc2_on_state: sdc2-on-state { + clk-pins { + pins =3D "sdc2_clk"; + bias-disable; + drive-strength =3D <16>; + }; + + cmd-pins { + pins =3D "sdc2_cmd"; + bias-pull-up; + drive-strength =3D <10>; + }; + + data-pins { + pins =3D "sdc2_data"; + bias-pull-up; + drive-strength =3D <10>; + }; + + sd-cd-pins { + pins =3D "gpio88"; + function =3D "gpio"; + bias-pull-up; + drive-strength =3D <2>; + }; }; + }; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C25C6FA83 for ; Sun, 11 Sep 2022 11:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbiIKLM2 (ORCPT ); Sun, 11 Sep 2022 07:12:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbiIKLMM (ORCPT ); Sun, 11 Sep 2022 07:12:12 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6850032B80 for ; Sun, 11 Sep 2022 04:12:11 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id w8so10343140lft.12 for ; Sun, 11 Sep 2022 04:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ceh+f8TxlJi2UoKOPdsH4JvikLyBx6shEQIrAtyynsY=; b=WfK/Jj6vCrrI4K9oreM/jR8blTb/kZ9Dw/WbHpBVLrTRS/R8Hdb1MR+waGki2bYiQn DqiUEvzcAH+LQiWqu4OqX9A7LdtqNIRCmlZ6qmRMKgU+ftnuZe+KjKGWGkkhvn/ZoMDO gNx9dMtZSj45os4B4cRyPIuoJ0Pkpy8SOeaIRbfIJ/gzjQjUAd1va30+6IImx7TNQRWK Vf3BRFrlX7rcA0dNI8o6gIKOpDFJJse/3mhhKeHkyxOpX3V0LTCHc4KcimXIwmvL21ob IXlmvoQBnVlUDLnU3EkFa4e4vyr+Yt9A5R/jsvmOWbGPIpnG0bugZiguJqQHYlIqjIIm EbDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ceh+f8TxlJi2UoKOPdsH4JvikLyBx6shEQIrAtyynsY=; b=hCH9iOlzBy5JATk6DJvSKOI1VnZnW57rPfCcqWWB9MBbCxONrMQdiqIuqoRNoIhHoW N+C3eX1MdyzmobqzxcaO2B9xcwbDY/B0r+lKHudlp0aeh53Eqv65Ugaw5YT7fVaFjLah gV/JVWYE2j1F8kvwWiMzeNHmpM04c0+g7TWgLBDMxzWRAbFvhVrEJbNhrWflruMOdOAa Np03oYSYrk42rcQz0JdI7tpZWR1n2MoIudh/P1d7vyQ+ZW/huOJWLS+fxlRBkzBTP97F JrfhVo+azcIOIGSDhI+rE5X97jeELvJaFxii96Bqwuu9Ln1bLMikrZjyyGvz99L7Z7wi jK/Q== X-Gm-Message-State: ACgBeo0eeepi2Xd/ZXM1UYsZBPV2kANf2kHctSnbWy1KO+awZHydyNzu cBrGL5BGo5KUsqpEsKhege6hMw== X-Google-Smtp-Source: AA6agR4i4kvqK8g4bENIZvSOxBq2z8uvod9PUVwWkOa9hx9Gdg6rM99cSX/Ae0xhDeyDcJ0cgf28LQ== X-Received: by 2002:a05:6512:224e:b0:498:f21f:3500 with SMTP id i14-20020a056512224e00b00498f21f3500mr4879493lfu.581.1662894729537; Sun, 11 Sep 2022 04:12:09 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:09 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 04/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:24 +0200 Message-Id: <20220911111200.199182-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index c8eec845ade9..84ed16f9915d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -51,8 +51,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6125-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6125-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm6125-tlmm-state: --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4176EECAAA1 for ; Sun, 11 Sep 2022 11:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230338AbiIKLMh (ORCPT ); Sun, 11 Sep 2022 07:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbiIKLMO (ORCPT ); Sun, 11 Sep 2022 07:12:14 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F73832B8E for ; Sun, 11 Sep 2022 04:12:12 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id w8so10343190lft.12 for ; Sun, 11 Sep 2022 04:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=fEX3mEf1YS0VEGkwrFu/5ECJ6Ev0hCKVagP2clm1WMU=; b=qeciX+TWGDfUK40JVCy8bjdUUjMi4bEQkh5hMq0SRZhDTi43dQ6/Ck0gV7nTCQ6oA0 ncU4DoBuR57Mih3OnSjoAdJ6WBu/VFJ/J8GOrHZ9vYJNIc+2MtjMF59haBCgbyI/Yw/t 1qpcGoWU2uEuOGUWNKiBR6BwrukF9gZamU51NjO7NH5Goe/5REwPz6SJBwL2slfMh7VY 9F82YKUyW6oQqtAEF93+fFskexR0RLUuywZOynPhGZ5GaMQCvJfUsDzHtaqmXEAvW+GB ykfznPsu1hvJfvQxy/iME39wL5ZO3BcceLppXcxv9E477TDiv5GZFbrYJ8SQNs8hL2PW 0czA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=fEX3mEf1YS0VEGkwrFu/5ECJ6Ev0hCKVagP2clm1WMU=; b=qiH4VQt4Juy68jXpQUrIHNjkdAz9HiB6mwfqcXxf/Leez8j9oRcZs5z8dYhgZOaiKi JO/QIUkENT8NpPZhe46YifUkA2hX7TMeCS0iiWRUM0/Ow4M+6SQdQeRKh0z7OL1tYmjp g+zeEYp79wFbZ02pSnM/tNJU2WuwvjxHzBYY/ks69/E3WQEjTHYo9G5hqaeTQR6yHRMc vhXr2pNsmkGuNhcfQVVxxZNxhrMyhGINX43/TpkvKO2Il3P0/FO/D3tiWmhZn/6QLVex RR993ScZ5tyBj8f+yyji0pM1bPt0AejAQIWTYf3e4A2oq/KWyasihB4uQ/TNUMV25dwu WuWg== X-Gm-Message-State: ACgBeo0riTQR41XMWpX3TXWWs8Ep59GkrFsRzxTFO8ja632IT+NmqGCo 9Ji0rldT4pcQ21VTt4rWdrFPpQ== X-Google-Smtp-Source: AA6agR6HhHU4p1Z34Whm2Z68eV/aRL0t7FUMIYY9sEGr+GOVpWdXE1O+lEfazFZ1yAJmklfBDDJGVA== X-Received: by 2002:ac2:4f02:0:b0:496:d15:ea89 with SMTP id k2-20020ac24f02000000b004960d15ea89mr6859532lfr.69.1662894730819; Sun, 11 Sep 2022 04:12:10 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:10 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 05/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:25 +0200 Message-Id: <20220911111200.199182-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index 84ed16f9915d..735eb5d6834d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -61,7 +61,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -112,7 +111,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio[0-9]|[1-9][0-9]|1[0-2][0-9]|13[0-2]$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34044C6FA83 for ; Sun, 11 Sep 2022 11:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbiIKLMf (ORCPT ); Sun, 11 Sep 2022 07:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbiIKLMP (ORCPT ); Sun, 11 Sep 2022 07:12:15 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC09B32B90 for ; Sun, 11 Sep 2022 04:12:13 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id p5so7368092ljc.13 for ; Sun, 11 Sep 2022 04:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=F43nv8/M+cL0CQPWEGRQlPTNWaqRQm3bONcFJuSIY7A=; b=LsReYflfbBL3iiZZG7OX3s8/hgRs6zfXJ5bXYW4hiRJnUffTliin2kTLChdCNcarWF IYPW6OasF5VkqNGa9lPZPF3N0H1ExqBc4R7FsK5Vj98crFO8N7N2P3BZplZl0ftVkJYg e9ITsRvdU3W1BF2cY0TRxNpfYzVbVIdo2wqXDI9rtDzBKYVgS0o2gko/NRWgvNKc3F5R xG45zsHUmIVkKtT4krBUK4alhRi4jnx4Xnmg8EtOIXcWsmEovLY+Fl86wXdw03hRlf1+ ZMIAVtwg/I9orYokEk6OLjzw73Mq8fgF743BpMeDrdF+soj1jmZUkFBPk3HjxLp8ZcHm D+wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=F43nv8/M+cL0CQPWEGRQlPTNWaqRQm3bONcFJuSIY7A=; b=cDaF4fe+trNhCCzFd/eqkjBwZcSKX+EkfF0iPOic+TCMiQwhZTofcYZs6VfEo3lPFq ZP0NkIXkqDvm3Fkz26hBR364AKXgcN5WbGZPMBVUPY+vOnEwlbZ/XctLUW2tPv4caWoX KqAR07xkVRcapPBAhKBvcnTlhzAZPxkr5ZMrmKmOgP1VIIC11Bs9cyEKsmDpW0s9T6lx 2sF2Tq0W817gq/jjOmTWmPV50AK5YDK6hVwLrzuwlLETSo2/AJsasMyKksqqXDyE67jY lbUZnrI5xmRrXgJ1QKzkbGRu1dANcpn8deI+am8Q2GnJFY8Y12+3sVCCppQo/qEEQ2+p tVhg== X-Gm-Message-State: ACgBeo0OvItABdQk4XjQRS2aANAG1PcAffqbBaNQETaIqP74kL68exaE tJ+avYQoh/RmBdRuZSmaAH3kKQ== X-Google-Smtp-Source: AA6agR4Z1Rd6NN9rS7Zi/77PfBeN4yxF4gC5dX6zDtptsktgkP4U5WZYdDxqk9pzUXwpGjL2gIgOtA== X-Received: by 2002:a05:651c:b2c:b0:261:d82f:75b8 with SMTP id b44-20020a05651c0b2c00b00261d82f75b8mr6166137ljr.266.1662894731998; Sun, 11 Sep 2022 04:12:11 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:11 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 06/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: extend example Date: Sun, 11 Sep 2022 13:11:26 +0200 Message-Id: <20220911111200.199182-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Extend example with children for pin configuration and indent it with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 46 +++++++++++++------ 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index 735eb5d6834d..5cb8b272cb7d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -126,17 +126,37 @@ $defs: =20 examples: - | - #include - pinctrl@500000 { - compatible =3D "qcom,sm6125-tlmm"; - reg =3D <0x00500000 0x400000>, - <0x00900000 0x400000>, - <0x00d00000 0x400000>; - reg-names =3D "west", "south", "east"; - interrupts =3D ; - gpio-controller; - gpio-ranges =3D <&tlmm 0 0 134>; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; + #include + pinctrl@500000 { + compatible =3D "qcom,sm6125-tlmm"; + reg =3D <0x00500000 0x400000>, + <0x00900000 0x400000>, + <0x00d00000 0x400000>; + reg-names =3D "west", "south", "east"; + interrupts =3D ; + gpio-controller; + gpio-ranges =3D <&tlmm 0 0 134>; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + + sdc2-off-state { + clk-pins { + pins =3D "sdc2_clk"; + drive-strength =3D <2>; + bias-disable; + }; + + cmd-pins { + pins =3D "sdc2_cmd"; + drive-strength =3D <2>; + bias-pull-up; + }; + + data-pins { + pins =3D "sdc2_data"; + drive-strength =3D <2>; + bias-pull-up; + }; }; + }; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27EF4ECAAA1 for ; Sun, 11 Sep 2022 11:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230397AbiIKLMv (ORCPT ); Sun, 11 Sep 2022 07:12:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbiIKLMQ (ORCPT ); Sun, 11 Sep 2022 07:12:16 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5926832B82 for ; Sun, 11 Sep 2022 04:12:15 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id z25so10391316lfr.2 for ; Sun, 11 Sep 2022 04:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=7BAXPGxWo40q91XDsq23ZI9ewONcXW0hOeLyfkEAbn4=; b=DyF+J3EmHQHuNVgK+TPDZe28N7cH8+NQm2tTpC+va/NuZzlLQGg15BlVMUi0wZtlns sM9LOBW7InI69qkSLZCDjyAZOPfUOh25OLoW+JPaNq/6+V2JB0Uez7Ri//WaSshyA5rQ ptmj4QBCWa/ybz4Ewj1uo6JkewNxm5+XgWsCYMtO+tu/691rvhTMHsoqDVfiYKvpzWOa yIOKRiY/RjwWh9+urJNLJGP5D+piWLn54pt3NhdT78Ezfv1aXRND90a9UK6PhtadPadF LmVC4jjgoiiHiVKplM5WacmR8VS6j90Fd9+aKUrOkJ6/D1uzXvItXd+qKpHHWrLjPn9R Wnpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=7BAXPGxWo40q91XDsq23ZI9ewONcXW0hOeLyfkEAbn4=; b=WoU8VNhSjokEzQdIuXb/3G242Lxz+nrAxRB57o3oBZRuCvfN0kH/E+h1yOAidCfW9/ +FXZduvxwREIVNUpJh9fkZrew5iVEI1R1Mw3L6Yd+IsMttoUFN22drTmOXEzxWNA5xoR bk+63z7m8i3AW1KN21f8hy6/BbewZvoCcEIJ4fOc2cahPwfZQE4Z+sJqLz3f0cTqzIP5 vsc8ecRp1RhnwgtXX/m0WSr8tZ3e/JuBGmXGeeZH9o4/Zcq4jVJyd6nPYfZnsbeOWywn u1DvCIoLqV9MwcNHJmJVV/UjvwYJkzBYhDUfPvRLTtUWby1l9Y9OwbmocX26UfvOxrAV R+dA== X-Gm-Message-State: ACgBeo33M4FfF992PVim26gUKwiw6QKoipxMazYJJFVrqqmubqxAVjil rTQFRST9OiQCO4hG9ngdlwcJXQ== X-Google-Smtp-Source: AA6agR79XuwzYM7RRzJeJ5CZNI2AZ0IPbPuBDyEanulOIsldJ64eLJr0RroHmIteVNwWvI3jcpvClw== X-Received: by 2002:a05:6512:c2a:b0:497:a1ee:7a21 with SMTP id z42-20020a0565120c2a00b00497a1ee7a21mr7230608lfu.221.1662894733296; Sun, 11 Sep 2022 04:12:13 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:12 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 07/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:27 +0200 Message-Id: <20220911111200.199182-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 898608671c4b..85a4ff5a5625 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6350-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6350-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm6350-tlmm-state: @@ -133,13 +134,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio25"; function =3D "qup13_f2"; bias-disable; }; =20 - tx { + tx-pins { pins =3D "gpio26"; function =3D "qup13_f2"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FE7ECAAA1 for ; Sun, 11 Sep 2022 11:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbiIKLMq (ORCPT ); Sun, 11 Sep 2022 07:12:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbiIKLMS (ORCPT ); Sun, 11 Sep 2022 07:12:18 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3696132BB1 for ; Sun, 11 Sep 2022 04:12:16 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id bn9so7399078ljb.6 for ; Sun, 11 Sep 2022 04:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=QW6MO1hMHGswxNmgzSJJEoxkkpvgP7Us3KREmZxCiHY=; b=eyeXN9Le/aPSWoxIrfrsLAdbjSJy4EuQYeJyu7Lcit4T9HVME/yo7Y3GoZzc8vCsvR VCCvqP7BYX45NmvzokK5tX951hLpcQZQ4hTnJG2He5Cx/ZK3kCNbrfGZ7lgudu3C0tJI crYHnII73yh24E4yx2tkGhza7jxrYR/0r8qQnIwbsnY1fqH5GrDUyNsdvFqd1joqmJs9 W1KRIzbabLt+hhw/m3TTlXcqhox5rR3tPg51F3hxvrjq/wZLdJnuBty/81dxFqug4C3B f+1R9C56WwR3TI+nkr/HvS4NY50+ZmW7jcm+0V/FDXhUVaP0ZHZcOHdLmDI3lIayiVl2 0d4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=QW6MO1hMHGswxNmgzSJJEoxkkpvgP7Us3KREmZxCiHY=; b=p3gjn2rGYVAggrS1j1X6gwJ/hXKq4hrIKr9K0348UUQyzR0y8bv+1wpy8Wh1vkhznS sapLmXf/7mps3XAauT7AwpLfrU65wi4Bi5N/J9UWUM5CF2Y5mb349Jmz8Ky2sUrYdob8 8Dhdfl0tCo2LTzPtUi4DU9i1P3D3fp070iDQNmEN+WW+i8pL2stqnUMTOe7P+BQAojhQ sf692duvDW0ml6olcAjnB2P/bQuT55Jt/7uGkqc6sRfoTMvio36LoHFXk5Hs3pjZOYBA zTMBfQmkLoP44MjMfZiXW9ZXFBQTelPgTMSIE+gaJ4HGc587eJ/M0FAqiVWeuwRG+kt1 sWLQ== X-Gm-Message-State: ACgBeo0vU1Q/S7nakQdFRaPTnGNjM5Jy18lMZDFCMXSHOYjhXwFw9/64 t+00I3yDehlGtIIs80roqnJE+w== X-Google-Smtp-Source: AA6agR7BV8HBCwYB1jzJXqz85cIhYPcJQ7yITXg8fPLl6vijl1milInz0nx5/IJi/IVn9w/OmT6Wdw== X-Received: by 2002:a2e:7314:0:b0:26a:ca18:60eb with SMTP id o20-20020a2e7314000000b0026aca1860ebmr5969946ljc.69.1662894734365; Sun, 11 Sep 2022 04:12:14 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:13 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 08/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:28 +0200 Message-Id: <20220911111200.199182-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 85a4ff5a5625..0c4bf6e90ba0 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -111,7 +110,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-7])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BE1C6FA89 for ; Sun, 11 Sep 2022 11:12:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbiIKLMk (ORCPT ); Sun, 11 Sep 2022 07:12:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbiIKLMS (ORCPT ); Sun, 11 Sep 2022 07:12:18 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35CFF32BAB for ; Sun, 11 Sep 2022 04:12:16 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id i26so10340820lfp.11 for ; Sun, 11 Sep 2022 04:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=dSJXKFEZI4T1kbFyh1aKF3VNgs72FXruybc3OKrfZRY=; b=jo8qL1lzX6sqaYGkYSiIkt9PrTiHRayD48nKuHJiOgVjCt/HedHQe5b6w1I/3MN3Ro dnqfXQzy2+czLjGKwYVv5TihLCXba6DjR8UJVJ6MBU9byse1BggQQgavNTn4WAKyJluo 9fSTUQqR75eYIdwnpDXilI08olf8O+kZ2lDwBShnmbwDhlIKd459csM0erQtRGH+OOJT 3JDA5wCs0PUvIlQJvZjFpmfBMlkavkbouz3HsLK6OvYhbSPqKhH6Cv2LmfVNd9AZKX2j +PqQN2qL24oIFSQRTkCom00Wu1eMkySP2mAw5LfTs9f2aPx7ZxAcCYrXTULNfuPjWmTb 1GNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=dSJXKFEZI4T1kbFyh1aKF3VNgs72FXruybc3OKrfZRY=; b=j1ADZWVfKZTlWHrnEOhE9L4QMx72o4GmPTzd77ekO2AtlfuyhmfvzT8MgeqVd6zDvN 0fLZWt9/QZqid6dg2qTAx2CnWOjruFAD67Eq1gBgJEcy0e358OTaDPPqSN2ZAdNYFinu 9pTjO4U4iNoFnjkHzlSR5zX9X5SelSbpOQMM848wlVpghevAASqyYOoJp1Qv5qQdDATx EMC+dArxCNZRtr9wEdD0j1ZwWh4f6VHLZHVWYDnzqPesTOUuFOm1gzKqm+lqLfTpHcyO qDXlTv0WSZkf0U8g+9MD2LfFnnDqH9oZ1hhTqELVlzRiHpXB3SGWo891gFrcy9dalxj3 mpsQ== X-Gm-Message-State: ACgBeo1hc+gk+kJblUEBfsLmLjvzjWjIJxnSUhwp6Tv8a2m0o0gXPHaU uMEpYghvPSO6XPkMNlsc2Gt9qw== X-Google-Smtp-Source: AA6agR4xs6t/I6gKtYWYbmzLXuTI/TdMbZcCMwUyt2/psDoE//q5TwFBWMJL/FECB777AUpK+gM2iA== X-Received: by 2002:a05:6512:21c8:b0:494:6f67:34b0 with SMTP id d8-20020a05651221c800b004946f6734b0mr7030752lft.543.1662894735657; Sun, 11 Sep 2022 04:12:15 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:15 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 09/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:29 +0200 Message-Id: <20220911111200.199182-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 0c4bf6e90ba0..856b9c567ecb 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -125,34 +125,34 @@ $defs: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sm6350-tlmm"; - reg =3D <0x0f100000 0x300000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 157>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio25"; - function =3D "qup13_f2"; - bias-disable; - }; - - tx-pins { - pins =3D "gpio26"; - function =3D "qup13_f2"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sm6350-tlmm"; + reg =3D <0x0f100000 0x300000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 157>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio25"; + function =3D "qup13_f2"; + bias-disable; + }; + + tx-pins { + pins =3D "gpio26"; + function =3D "qup13_f2"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C26C6FA83 for ; Sun, 11 Sep 2022 11:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230406AbiIKLM4 (ORCPT ); Sun, 11 Sep 2022 07:12:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbiIKLMU (ORCPT ); Sun, 11 Sep 2022 07:12:20 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7085532B99 for ; Sun, 11 Sep 2022 04:12:17 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id m15so10342539lfl.9 for ; Sun, 11 Sep 2022 04:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=4rHHwOUbpZ1zz0X1ZCBP3fMB8RXmrk772qwdEx5p1YY=; b=Fu8ptctQDaI2uIgJo8917Xzo89LGap2DEDz7xxZZ0J+f8RgN6xDMxGGSW5uxQ6Lb5Y EQAoRbF9O2Dp2tgZrGjw2/ToX3w2pCWo9ecmTrDPZoAtOHFSgYLaPesqs2xuKWclWSVK LC9LGiEQRPl4QmWPkb5KIj/hxgX4cMmNIpccy0Cr3HqDIXWQSgI5q1VOACFcubb9Rdiw StDJp2/wTqZH3pyLXYAwnI+O13nxXvgl0p1BXSlaqfsadVrbhfJS8MM2jHrLGmMIgBk1 gr8qXUG2XR7cuUwh97Z99HEoynxvzaVyo3SdHewyTyrLglE1k7Ta0PYRlUmLYwN3ja/O j7mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=4rHHwOUbpZ1zz0X1ZCBP3fMB8RXmrk772qwdEx5p1YY=; b=c7QY4Ptss0QbVMiIdZloxBnXlOEpVkyuSFUnHcoryGTtRxPSV96OPiB7QQssXijZ7O ipYs7ABi09rANh+6jMlL4m7vnX04OPEtS6BAwyMK7ptGW5zWCSfGXAF5sGWQh3PhO12y Ev4HQ+BTRDo6PAhXTQa0ARSb2KsOcoBhb7tImlBkkLAzMEz45KDpdD/7VSuFcdksvRo8 gy6q9VGwl0YKmyKLxGYuPa1iPDcm9nx6QwV5dniqqeMGvAbS4sRaZ/X0bmEI1q8zFwEJ edsMEIi0f3OW0YP5LEdlC+1PZV6TEy5qBWOlzfhFlvPaa9vMfI7pTT5xcOjPWvoSpS+I K8pw== X-Gm-Message-State: ACgBeo2q9FY3jBRbIbDkF0dCTmnjHVrAN49gheoHZtG59RhLRovZ9Gdi XqixBgTM/w/Pq3I2AuPNhsVszg== X-Google-Smtp-Source: AA6agR5qnkA8Y8vV+2+FmuTE621GPU+psjfZnO6j9Nu+3Q+XpjYO4iEuWqxxbJXj4X6NC6K02mMQwQ== X-Received: by 2002:a05:6512:2a88:b0:499:3bde:9630 with SMTP id dt8-20020a0565122a8800b004993bde9630mr2705951lfb.147.1662894736724; Sun, 11 Sep 2022 04:12:16 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 10/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:30 +0200 Message-Id: <20220911111200.199182-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yam= l b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index 3908807a8339..50f0ca5ab7e7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6375-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6375-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm6375-tlmm-state: @@ -142,13 +143,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio18"; function =3D "qup13_f2"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio19"; function =3D "qup13_f2"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56379ECAAA1 for ; Sun, 11 Sep 2022 11:13:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230441AbiIKLNh (ORCPT ); Sun, 11 Sep 2022 07:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230359AbiIKLND (ORCPT ); Sun, 11 Sep 2022 07:13:03 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DACB3335F for ; Sun, 11 Sep 2022 04:12:20 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id r12so5839444ljg.10 for ; Sun, 11 Sep 2022 04:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ozqjcsR32neOzHv2L/2DOKBG63rqHKYUg3f24PJLOOc=; b=GK88lwecgkTizgJh3GKvFnjgNw7U1/lM6XE8hqiam83MYylcrebe/xhqceJed3AKY1 HNTcCNyLrXxIZx3Z7u5nBapp2paLpQLvThc/f5FPXggAEp1yERCAgmoEelbAn1sMqFkn lKHHUaR6dPZR5QiQwJ/rQ6MIbG4v7tEQpCUQO+1/SxigjE+WqWYLpVJCIEb5J2ipwMmI 8l4Z6dAtkFmY2XUtjY33A/5mz6e8fUQrx3+ozGCy8nIqa7mpou5VKBE96/SZqr6MaZCy mjNMtHyjWCJ/2mnmy6bNbEVbUyleC0Qd4xHO7Aqcbd3ywVArgat36FepOkOhMRX9LvSv ALJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ozqjcsR32neOzHv2L/2DOKBG63rqHKYUg3f24PJLOOc=; b=uJJQ/uFGuq4cwmlovSR0/HGexwfVuXG2MC0WwScPZA2SCrOOSJzKXg9uv/XxVeOkj7 8cYJ5z9vbgxaNR2lnt9DqafCYoHxL2pW5JJx+DiHxJCrameXUHiSCBKSoYVcCTwDL5aH 1KaZYEH76V45kUXsWPfPJX7cZM+YQX6wtACCkvDCY5Pl/uG2zzeEuKOvhU642p6ngjGx 8CHV24XBqUTWgR1oASYxps4uNLOnvU+E0mOLe+iXUXePTlXozvKhncCy0fqsdQOM3zYa yPrWhFKTJBhYqaQKWBMaza3wkGoXEafHPC4/ug4hlrByuRDMgFRkrdWZA4ibc5r1i0IY LA8Q== X-Gm-Message-State: ACgBeo3kaxinGZ0If40g+nxGanB2+qFupuSgGk3ZkAzklNHvbINf577y IZMamQG3u50T4LjMSDpNjvvjkTZhSv2wWw== X-Google-Smtp-Source: AA6agR762iiL5ojhwyiA2ZJI0eAuNMgBz1devbGS6PL3OdLnl1YSzbPBjipjNZ9BjzcriWAq5Qxiww== X-Received: by 2002:a2e:9e48:0:b0:261:c713:37dd with SMTP id g8-20020a2e9e48000000b00261c71337ddmr6126947ljk.385.1662894738003; Sun, 11 Sep 2022 04:12:18 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:17 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 11/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:31 +0200 Message-Id: <20220911111200.199182-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yam= l b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index 50f0ca5ab7e7..dbd91d6b63b3 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -120,7 +119,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-6])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52C2C6FA83 for ; Sun, 11 Sep 2022 11:13:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230446AbiIKLNG (ORCPT ); Sun, 11 Sep 2022 07:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230271AbiIKLMh (ORCPT ); Sun, 11 Sep 2022 07:12:37 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8E8732EE2 for ; Sun, 11 Sep 2022 04:12:19 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id w8so10343529lft.12 for ; Sun, 11 Sep 2022 04:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=BzxKI895lpDHkY+H8tKxOiDzUL4EnCHd/mNz95fFCeE=; b=y4vPVjYXVGihY9jOAnssEJR0Pr8jmuplVjE0qhtCRzZcz5n6eychsgTMYEAOtOPLet 0cPwB7ldGNthyDD8lM/zfAvlgmvv/2IrNBBF1AEM8s0NaGXwcaIE1PTuQa013YcVa+sj 6OuvRF6GCzAQstfai1DWgSpEUUHiGmmqBcaJcvcqWnwWSfBGUP1dVgkgn/PiZn/+let6 hkK7L00kPj3TpP5bY8mghJjaY0qyESaMX623fogNk8EzDpj2Bqbf2lPkJHQlzM2DUidc k5Hf+wEIzuJ6dbDyuv1U4sq8HR0XBZejuup3fdzvd8HhbTnUCdRY34Am83bJrPVXegTe BB/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=BzxKI895lpDHkY+H8tKxOiDzUL4EnCHd/mNz95fFCeE=; b=2pXVXkVBjtWUIiTEPlE4QAj6xFD8RsdT4vgGfoQxdAo2NA3PkWQ37LNMFxBtZQRM3z ufacadZq7H+wFeRDg2T50FOyFkjkJf6l7hghuhkEVrwGbGTwt/0HI5IA5Fe5QK1PvxZY lFtbUxJRtDq5lKU9WjZFRwsj/beQ+jXkpdQjIrbc3URATa7/h7/RAfgZJnC/neuIKmDz VuEagNsIoZy06zgWDDw0daXbMM8zWT07ZN2lsaiigJASXPmJEtWiuYRi7BqQk5hMsxZs JrY1Go6pKASMN2vHfSAEGN70V639+WqI7kLRpTKkSG2spA7gh6NSGrN1HP2dxau1rhDU bM5g== X-Gm-Message-State: ACgBeo2LCSwejmnK7RHGIf38sxrsM+cj9o16akLR8fRlENDdBxLw7VDc hSD/RQBJzzQRACrtiP3Q5lhbnw== X-Google-Smtp-Source: AA6agR5JjGDgdu4McNBE7qGn+b8q77xSBjub9bkSNoXAx0gj8ZE477KyuwN+Vy0iDurh8E/tsO1VQw== X-Received: by 2002:a19:f246:0:b0:493:50d:6bb with SMTP id d6-20020a19f246000000b00493050d06bbmr6865471lfk.461.1662894739265; Sun, 11 Sep 2022 04:12:19 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:18 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 12/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:32 +0200 Message-Id: <20220911111200.199182-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yam= l b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index dbd91d6b63b3..025faf87d147 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -134,34 +134,34 @@ $defs: =20 examples: - | - #include - pinctrl@500000 { - compatible =3D "qcom,sm6375-tlmm"; - reg =3D <0x00500000 0x800000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 157>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio18"; - function =3D "qup13_f2"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio19"; - function =3D "qup13_f2"; - bias-disable; - }; - }; + #include + pinctrl@500000 { + compatible =3D "qcom,sm6375-tlmm"; + reg =3D <0x00500000 0x800000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 157>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio18"; + function =3D "qup13_f2"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio19"; + function =3D "qup13_f2"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED30C6FA83 for ; Sun, 11 Sep 2022 11:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230403AbiIKLNP (ORCPT ); Sun, 11 Sep 2022 07:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230401AbiIKLMw (ORCPT ); Sun, 11 Sep 2022 07:12:52 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A15F133420 for ; Sun, 11 Sep 2022 04:12:21 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id bt10so10405075lfb.1 for ; Sun, 11 Sep 2022 04:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=huMBt2cOX5WYiW0m7Bpoars+zfOhAPbHFngq8gou9wo=; b=gjjFGcTzNIJEpTozDwXlCSQu9pxjor0DOliAlVN4b3xO3s+BMl9gcVSKWAmyPezafe stShxSixpggf+L5Ut3/uAnnWPvHw2CVeUTtPWQC2lEhfZAZEj9+AZA0Oj0M7W2SxAaRN gwffL4xCb6oQI/13wC5i5HtgY3xpVlo5iWdlMxpOt9ajb2Np/fzwUBemzBo76Xjpm+3e FHMzR1Gwu/tywUBKZqePd3b/Ak+TBkAEXrsh3A4N72e7HdMEPX3zFjV2djtdKDrHScuP nKKBGJn/bWpLcj/A7qXa5ehbHCQOYvUtiaMyYhzISPh281JdnJ7TLUvJNXfkBDsiIuRH hAAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=huMBt2cOX5WYiW0m7Bpoars+zfOhAPbHFngq8gou9wo=; b=ap0ldE9JKJwLu9a7eRd0ItDSY/+mwD9tOrT8EOqL358y+6STGKfq/3AluTsbSbwc9x xx6QlZYKTj4B765qmk7nJ/+sk7eK3ZUDEWWIBXRerYLqU4CPwbE3X2fBA6+wWi15UdF8 sxp5Wkrd2WRHMcEy3h5HQ/Fe701otgyZLmvSKH1ZuwCKrFSI0UBXZTiuW0GvO0kaxUds i/Wgfmn/TlHtpAuQIPaPZ9ZRy8W6BIsNZu7dxogMJx//irhy8mUR5rgDG40uvMtkOguU OLgvbZ8jKDYwQ4Mgu3bFjgfu1wAjdEWuxDV1sCSXjwZf3xotAYT1Fj7EW/JKOj8+Mf8b BY1g== X-Gm-Message-State: ACgBeo2b3p/l3qJQNKuNarQzW5atPRJ1KRfUsY812M0ozYH/dQ0g4SqX OLTkFVpDVjBOXTjIsaibnIUuOA== X-Google-Smtp-Source: AA6agR6di+WIA1ch9u/rQZkDKXpzRSwuSZEtWBV8LhyTjERbH1hCrJWCet09H3Un6djVDYxi792y5w== X-Received: by 2002:a05:6512:3403:b0:48c:9727:50b0 with SMTP id i3-20020a056512340300b0048c972750b0mr6898768lfr.309.1662894740977; Sun, 11 Sep 2022 04:12:20 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:20 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 13/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:33 +0200 Message-Id: <20220911111200.199182-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index 15bb1018cf21..12bdc2e67c4d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -110,7 +110,15 @@ patternProperties: =20 required: - pins - - function + + allOf: + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19506C6FA83 for ; Sun, 11 Sep 2022 11:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230432AbiIKLNX (ORCPT ); Sun, 11 Sep 2022 07:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbiIKLNB (ORCPT ); Sun, 11 Sep 2022 07:13:01 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E67F332BBE for ; Sun, 11 Sep 2022 04:12:22 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id s10so6772689ljp.5 for ; Sun, 11 Sep 2022 04:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ShPxgoMmuatqdGQWqNcZcpEJgDBD4NgqwMQX8EaKFn0=; b=DHP+jlt/E508Xv9iSxNq/GTHVPkKnFhmT4qxAzzHSJDH/cXXAve7zIzeb0/DykHttt hvrGvHRxd+VN/E/pd3aIB8uIT22M/f69/zEVkK1b0ix5hWpCfccUlvADMrwNRhpsFzqw 8FaaZTtA+ZAaJtvEGOTTEoNbQqo3Pozh5Qt3GwBZSNDlJ6PNznxSeU16KqNL7S5aLsgt Jcf6zeaCTuoFwYAXzPdDJxM8/2W7ncJCVblarYhbXXpFhN9kijV3l8e54jI4iKhp/unc PeoQeAG++TPRyMsqpuWGiSJQ2ri9vmMiImHrnlmQLRC0m3RAG3wDuKdwQTpQPYWfRK4T fivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ShPxgoMmuatqdGQWqNcZcpEJgDBD4NgqwMQX8EaKFn0=; b=zAgKO18by6tV0HGmcsdZZLTjhLq251QYxj9+2J435tGZlNjJfoyW2pDfbSmZOm3f4o RSikBkqR4UGbJ2uIZOgZAoD00GhzPpTzMdHa34TWkRK6gW9PIjW3BidaFm0PPfoY8tdY 1VwRCK8/AZL+yQcDgTYoHN9BggTOkU15NX1EqvXbkNSvz6684xeDcvH1IZusK4WP/TLj S5Q1XFcPpk/2Hfm/fVIavd2LrzpIEXgr7szaxLLQ60Rc1nRZvaipBGSr0ojbof5WU53s blD1ekNaNbdUBWmZTx47qhl7mWs1siNZuTJuSHPSdtTe4yuCKRZbdADLiWDpLUzrYRYW Hovg== X-Gm-Message-State: ACgBeo3V5OD0l2SS2Pp21+LBoHTwvHd+3Y5a5SC3Lpw7BvZZlWtvm6Yt BrHUjEVoALqEAIpSSFcvMJ6ysQ== X-Google-Smtp-Source: AA6agR571Fj41lyHAFhyGUDDlkIECF++W//6UfXv4X11c7ukU2cevSz0vIUMWA77oDUddJAiiQE5ew== X-Received: by 2002:a2e:7309:0:b0:26b:df01:9f03 with SMTP id o9-20020a2e7309000000b0026bdf019f03mr3905831ljc.221.1662894742330; Sun, 11 Sep 2022 04:12:22 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:21 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 14/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: reference tlmm common pins Date: Sun, 11 Sep 2022 13:11:34 +0200 Message-Id: <20220911111200.199182-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Each subnode configuring pins (so the final -pins or pinconf) should reference common TLMM pin definition. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index 12bdc2e67c4d..bccc83f22aae 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -112,6 +112,7 @@ patternProperties: - pins =20 allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" - if: properties: pins: --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A486EECAAA1 for ; Sun, 11 Sep 2022 11:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbiIKLOx (ORCPT ); Sun, 11 Sep 2022 07:14:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231160AbiIKLNq (ORCPT ); Sun, 11 Sep 2022 07:13:46 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACF843CBEA for ; Sun, 11 Sep 2022 04:12:43 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 9so6488739ljr.2 for ; Sun, 11 Sep 2022 04:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=qxAFFeV9Jghea1krVGY5BQK+UR1GkKeREC8WB6H5B2c=; b=vjDiFJjLjvVI78IsYrKcOiG51LrE9dKnNKMIGWEpkis5uGIWdl4xLXgYFt1lZVWh3G ehSGvB4AUACWBv+SnQ1vIvsHIRoJWndg9K9qu0EWroN7X08gd4uBqsIkfNLIPAcBFbDx wm7sZVt0Kzbr3mM7FQ0vzvBf9qu/y5JNF0vPOJtjM/k9UGY4RBqx5FZtB1mILwacSDEG CErzrlLMVABD2WtJYl0AbAOc6vvxFOqlUcrqk4EasADkyrXzW7q/o4BYQo3q1S0cTO86 q7NLV3osWIx1v4TFZK7HsN4tIXeL3gn0EdJtZhl8IOlelgXeVloyjLgJx5D0CZ4ypibr neJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=qxAFFeV9Jghea1krVGY5BQK+UR1GkKeREC8WB6H5B2c=; b=WmoDL8CsUiLC8QHNO7x2hEl3QblStUuhQdj0XPAVsTs39vIO5CnWanlTjms9m6BpPB MTPR9PpnVEI4tY3AlTTTI6CwBOg0ZbS/3oAQ6wMycXNLbGH/r0tHsubs+unHA6Q6x+Fk qhv2kBmNgJW68f2lvzUr8pSAMwR6k0dDk4QKXo/3jStzy8CBGUg26zD6+gIzLxNkbIek U8DaDS1l4KY5/C6QevosG/tn6Lv8mL6Md4Vj+ZDUlTkQWscKOPls4CjZpJYDfZhY2Kuy 1PB+O+GgvxN95idPuoP+pgaWApjib+MQnCWLCF/g6xqmFmjyqP4fjIYnyzt1+NopYqz6 TT5w== X-Gm-Message-State: ACgBeo0wgXkGWGNTSdcuM968KW+OxflYOddqVySzIrZnJ/XKeB20VorK M2g6ppxyDqFwB/AuKDyPpSvG1w== X-Google-Smtp-Source: AA6agR446cy+OdRmEkwDeI+yVptxip8u3RlG0YbI8CjPb6fQZmEJOF+4at5PXvMi1L8IqnkPHn7Efg== X-Received: by 2002:a2e:2d09:0:b0:25a:816a:2e62 with SMTP id t9-20020a2e2d09000000b0025a816a2e62mr6039682ljt.147.1662894743551; Sun, 11 Sep 2022 04:12:23 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 15/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:35 +0200 Message-Id: <20220911111200.199182-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index bccc83f22aae..c44d02d28bc9 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -141,18 +141,18 @@ additionalProperties: false =20 examples: - | - #include - pinctrl@1f00000 { - compatible =3D "qcom,sm8250-pinctrl"; - reg =3D <0x0f100000 0x300000>, - <0x0f500000 0x300000>, - <0x0f900000 0x300000>; - reg-names =3D "west", "south", "north"; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 180>; - wakeup-parent =3D <&pdc>; - }; + #include + pinctrl@1f00000 { + compatible =3D "qcom,sm8250-pinctrl"; + reg =3D <0x0f100000 0x300000>, + <0x0f500000 0x300000>, + <0x0f900000 0x300000>; + reg-names =3D "west", "south", "north"; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 180>; + wakeup-parent =3D <&pdc>; + }; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 622A4C6FA83 for ; Sun, 11 Sep 2022 11:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbiIKLNc (ORCPT ); Sun, 11 Sep 2022 07:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230424AbiIKLNC (ORCPT ); Sun, 11 Sep 2022 07:13:02 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75B1B33E10 for ; Sun, 11 Sep 2022 04:12:25 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id by6so7372608ljb.11 for ; Sun, 11 Sep 2022 04:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=VrVKTm5IPzB9yPQM4on4vs6doVXn79UQwYvWB99boi4=; b=xp8r29ET1cxQ+YxztbEsZyuaJwy68xG2X0SIkGHow5xmqIrQ/vTfLpzs5tE347LYML sJPHMphD0xXFXzkUhnMgVM4raNi2sRQWNBu2THFQNxRky78fpDqr6nMqju7K061euIAJ S7v7/FcC6MlePhgwVX4zIja2l/RV3DxuKVH9lArKp86CVbvF7ofncpc79mWvZD8xK9c5 DiumwaFteDOEiHHE3lZqdV4+eFW+u1UEVF5REOQa4+68pvpcVczcEHcuniQ0lJyCaSVF av8pjtNccI9wQMG2ztNRbPprBSb/5nRluqTTj7waRAIKyijMPr3i6KcJ5eM3htwSRUrb EsGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=VrVKTm5IPzB9yPQM4on4vs6doVXn79UQwYvWB99boi4=; b=puS0kX0b3J4fNVpPb2a9BCFx+9hfC/YAhrD1QhAPyU7twu9I0iVHdm32l8x+l37O/N 8HpDgQ9CJyyXbWrDpJCOL7654Z3GZwPUXQS9y3ah4SuibmIjzRdZqSJ9sSszh8Rfr1/e olqZp+d+4u9/iSXcbMUgYA+Xi5mDyQ6jIPmPUB+e9EUSGuXwfiQpXzFCNNJf7oTe2Wcq xEZfRYkcw5XiM0156ghduTnU45YVNtTLRQN1zjkRHOSpAxfckH/HaJ/krZ7Qya1vImHO OT88YtEp0NP7avS6IaP8Oq1vyi+rD3uuFAjt25Hu5jSL3PntFdOMmGKvPqHdlnN/V0/4 t05A== X-Gm-Message-State: ACgBeo1pl5LjJyRUu8habYsFLOlxH/+J3I9lvYYQiJGqJPl/r7ljbNJE fYxHH2CtgEnwONBUg9uS+CPHvg== X-Google-Smtp-Source: AA6agR53u8ue1LzW/SyFNgMGGcOf64oJdDOv2ATgNfXGuNbU05Za4Mc1pxScULpuI0moW2wWFPhjGw== X-Received: by 2002:a05:651c:1116:b0:26b:e28a:6919 with SMTP id e22-20020a05651c111600b0026be28a6919mr3494238ljo.461.1662894744654; Sun, 11 Sep 2022 04:12:24 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:24 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 16/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:36 +0200 Message-Id: <20220911111200.199182-17-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: sm8350-hdk.dtb: pinctrl@f100000: qup-uart3-default-state: 'oneOf' conditi= onal failed, one must be fixed: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index 6b7789db2f75..211cca11f94f 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm8350-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm8350-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm8350-tlmm-state: @@ -130,13 +131,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio18"; function =3D "qup3"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio19"; function =3D "qup3"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A2BC6FA83 for ; Sun, 11 Sep 2022 11:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230463AbiIKLNs (ORCPT ); Sun, 11 Sep 2022 07:13:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbiIKLNF (ORCPT ); Sun, 11 Sep 2022 07:13:05 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1B133E2C for ; Sun, 11 Sep 2022 04:12:26 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id w8so10343780lft.12 for ; Sun, 11 Sep 2022 04:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ZQ3YhRzsCIvzwIGS4j9FwdZrsy4eOBBU0P2zsVYlRwE=; b=W4/6KU6ZUrKCN0WQFUgo0TlWmpJJrB8H0uKo0z0DL9g3XTEqN0y6Oq8xoX5k5APwHn FvfyoBzf6psGe+Ds5jGa/XKt1eQjLa70Yqtn0MSbgHtB/wYTWO1jcqXYGz56MD1x6O3b I8RdXwIhgS6/c6FE/7/OomwuwyKVNMC7dsUr0rRQJc0EeXgCk7mQdQqWUIsQIjDKIsLM h4WPPNTdSpYTaSLTM0qWe8MihDuI7bU/SzDcGXeeOnnp1q7JVcpLVB/17Vk6wKp95SWE 30gsUcz7++OIWmAM7KWlB0Zsj5i3OYmCiIU0IpGqhhMk43cS58bpbaXjHseTDHwJGSKF r+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ZQ3YhRzsCIvzwIGS4j9FwdZrsy4eOBBU0P2zsVYlRwE=; b=qcMd29MN/ZlW3zm1WgAUMnUwe6I2NYnBHJ0T2QhNbhBJTvcFRJVWiw+Aqc0wQVyM6T Wzj6VKQ4dLDfBiIFzIPkT9BczFS58CwSLihdY8Pg+4CAFtmbsFwBoT2rhb3D7KyQMQZT JBGUBM0L+HtVzwPHqMYAUHrIq9OCWDsgaBMP5rIGxPinfqyqWQA0ORdLJH+6+cqJL0v+ sJ31X22jV2khNZ83Ag2Ct83Q6NhbKp7vLxwac/9A03QVGEL7ljEq/1GqLutgHozIWpz/ XDgBqJlYbkncVtFeWnTHRxWGwWCOAtQKC7lWq83Elfdud63D4lTRg78Ki5HcHM/ai9NC WDtg== X-Gm-Message-State: ACgBeo0nYIBZ3ubiEsOrGJf6wE6BS3A1ajNuX7pxP5doOzeUL+5eK4YE 552tC/0MoXkp0Jl0z1aITz/dYQ== X-Google-Smtp-Source: AA6agR6ZNdnhdZ/hIUFuUULBqH5iiPIwd/niiKFSI3FzwD2uGfxJYsj0ont6BmsaHYsqFFxPuoH/cA== X-Received: by 2002:a05:6512:2381:b0:492:afa4:6b67 with SMTP id c1-20020a056512238100b00492afa46b67mr6806512lfv.621.1662894746041; Sun, 11 Sep 2022 04:12:26 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:25 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 17/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:37 +0200 Message-Id: <20220911111200.199182-18-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index 211cca11f94f..f3106d25adcf 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -114,34 +114,34 @@ $defs: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sm8350-tlmm"; - reg =3D <0x0f100000 0x300000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 203>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio18"; - function =3D "qup3"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio19"; - function =3D "qup3"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sm8350-tlmm"; + reg =3D <0x0f100000 0x300000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 203>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio18"; + function =3D "qup3"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio19"; + function =3D "qup3"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74704C6FA83 for ; Sun, 11 Sep 2022 11:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230414AbiIKLNS (ORCPT ); Sun, 11 Sep 2022 07:13:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230409AbiIKLNA (ORCPT ); Sun, 11 Sep 2022 07:13:00 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3A4333E34 for ; Sun, 11 Sep 2022 04:12:27 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id k10so10370083lfm.4 for ; Sun, 11 Sep 2022 04:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=BZ9D0FRQE2grk03g+mdXjEXzyihdHpyqrjbkROOcsv4=; b=Uq+Waa+MOIP9pYf+FiYpnLRgnmgR/SfA/kJzGTRDaGZVDZUjhCBA94ITxnluyrTt4U JjIZGF2eBuwfGJeS3BeYTXDcio+S75AmvGwQjxEiTrfvflvygITINWCBp7lNp3a5Llla TbfgQvMRX63u6qitw8QQZWT5fr/73f9YCKD5kTUgKdHK4AULMLrG8B6XKwWo3ii7m+yx QhOV7EDmjfAPBbXwB58zr8YEWUzTvHSOf5MsA1X6m1Ij90yuNCF4BaPkC7LmIuUxiplm dakJKP1fbaM/U1G7k90vJfm4GviIMO1HxvacqSKc1gn0mJycv3PvMXVAWBEjPZr87+zw CP8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=BZ9D0FRQE2grk03g+mdXjEXzyihdHpyqrjbkROOcsv4=; b=AOeGZpoH3EfBbppzIDO6amfWS58xjQFbdjC/0e6DJP7PLQ1ynnm5u+21M7SW0uvhEe 373y9Au9XhVAXpMy8kwEEuWNSn3P/G9OSPoxVXEorTfKifjaBT140LdhMcUUDmoNK4Lb v9A06SWuJ0F3vgj46y3iF58v0IN1grJ6vJq/GsuegVMB7jEIr8U1Fqkdcss3k2N5qgRR HG/W1s3BGydX+NFDhrOjgmaE/p0hKWwa0inj3a5CceqTdIypqGcXswkt/bFxMabsjJOI TJfsCEm1usqFpIrZTPqrOumbWbRq85v36NjeDNF7Jm0StcWckHB8FAR4HATaRwaEPFHu bKIw== X-Gm-Message-State: ACgBeo0gZ0Q6UimzrYE9oZ57XnbvC+sfkX6Y929O/yAuhisDvcHZ4WxK u0mxTfRGg2rWHYBoFA9oKYakaw== X-Google-Smtp-Source: AA6agR75xSzW2FO1RR+w4Xef54cJTvNyPsu/Jhldn59qzhVCOmobsJSeB//MjmmWzRRGlhCxkA1O3Q== X-Received: by 2002:a05:6512:31c4:b0:49a:a463:51ab with SMTP id j4-20020a05651231c400b0049aa46351abmr394253lfe.12.1662894747400; Sun, 11 Sep 2022 04:12:27 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:26 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 18/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:38 +0200 Message-Id: <20220911111200.199182-19-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index f3106d25adcf..6ae5571f60da 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -108,7 +107,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-3])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F85ECAAA1 for ; Sun, 11 Sep 2022 11:13:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbiIKLNn (ORCPT ); Sun, 11 Sep 2022 07:13:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230377AbiIKLNF (ORCPT ); Sun, 11 Sep 2022 07:13:05 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21B3833A2E for ; Sun, 11 Sep 2022 04:12:29 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id v6so7446525ljj.0 for ; Sun, 11 Sep 2022 04:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=11whfBmZQZTESKD6+YPUVTdrbpEpmk+FiIRnZHBW3ck=; b=Pve93wqdlwmK5mjKf0pPzYZhKuqHUik7JU0zfO0y1gXK+JKDzB7WsO25wrjmtnsBup 4NXxcf0zwpFyPvxBkPobcHFtzLLkANUALGK/0q30EqbVswYwO/CMpkwKWHcM1Jw8ocIr RORF9+Cgt3S7URWiK9qgLp+OQYZh6dW/dhV4wTz/CbmMs5UlVRiC1lInL9jlLy+vPAnk QPJrnGYjnIPT1rAGV8RS2i02F/5VHDVtznlaJWqtAVRrYjPND4oenu23r1WO9HVoK6o4 4FwN2AeMW4crduOaJcUNIqffEx8zJXcpeAXqUgoJGs15yHrmk42i+oMdR6MSH26TsOFU ULhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=11whfBmZQZTESKD6+YPUVTdrbpEpmk+FiIRnZHBW3ck=; b=HpPzoxw/8Y60e98ohZr9izS+XALJR7EjJRj+4SjWRtHJnj4VLAY4O3g3CEhkwmNZUA f8clDDzmFreuLkW0znUAcOQS1cK6jeg5JzkPktxHF/fiGMpeBMoyZcKhLSl9vXgPDlg3 Q/CMaT4zewLjQ1GpRE9HdRD7ZnTSmRXixhTwA7SovESNcG7bT1sqNEK7AI2ZTueuG0kW LGGK9MWxNGD6UhoZazZgs5rFqx5Gq9sCmhjTXxCSWPfQ7UPdDszS8Lk90Sl+DOxXQuJ2 jwNHKsT/g63Vl1xOi0uCgpPGivVtRlEJdTNqBhUkG9Fp4LU86PTNy4SkQ1NvUYkyemXS Lfvg== X-Gm-Message-State: ACgBeo37X/JbOMiJsqs/ASwIBSnRRi4o2bWhByc53HUgwVq4rB4WqGMJ /NvCd3bKDzN40tWDnO/azGZC7w== X-Google-Smtp-Source: AA6agR70mp0hoUv7NrTPXl4ZjssyLfQ8EXRd4kH3UQ32x1WRcdBhcBMORnVzYq+ABfa2+UjRI/UrPA== X-Received: by 2002:a2e:9e11:0:b0:268:c7d0:9662 with SMTP id e17-20020a2e9e11000000b00268c7d09662mr6093546ljk.309.1662894748500; Sun, 11 Sep 2022 04:12:28 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:28 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 19/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:39 +0200 Message-Id: <20220911111200.199182-20-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: qcom/sm4250-oneplus-billie2.dtb: pinctrl@500000: sdc1-on-state: 'oneOf' c= onditional failed, one must be fixed: 'pins' is a required property 'clk', 'cmd', 'data', 'rclk' do not match any of the regexes: 'pinctrl-= [0-9]+' [[26]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 9c891246245b..d1d1c1455b3c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -43,8 +43,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm8450-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm8450-tlmm-state" + additionalProperties: false =20 $defs: qcom-sm8450-tlmm-state: @@ -127,13 +128,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio26"; function =3D "qup7"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio27"; function =3D "qup7"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E957C6FA83 for ; Sun, 11 Sep 2022 11:15:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbiIKLPu (ORCPT ); Sun, 11 Sep 2022 07:15:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231131AbiIKLO1 (ORCPT ); Sun, 11 Sep 2022 07:14:27 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F6773DF16 for ; Sun, 11 Sep 2022 04:13:04 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id u18so10359249lfo.8 for ; Sun, 11 Sep 2022 04:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=jLZlsEJ5VG4J2SIrJhH+JChzqh+Qp8BnGJ+3NtUQBWY=; b=lPPmou8Plr4qIHzjUl0pjjVP5lMFawqBGTCSR8459+GKtTM/YTDxjQxD1eLfWzAbD8 wT5YVscwIM35mO9RyS5jCtGzVP2+tvt4qOI5MLLmHMsLwBpDA6X/3SvSw+A5H5+D0Zqx ms2FX30RtLvGOxyZNagyKpCanr9UOeCDibOBTpn3LYEJtNxJIv6U2g4miHba+NrEZuOz p3Wpf9d081jRUZ1NLzS49iehhkZxgnGfp12XEvAlJrc67rkUk5ci7wjP/sgQmeerD/SL DJQG1cLOMIQ2zPgUWOhyCRlHYcW8RW6IkIreRTPAunUBho24utDWsLsj2F5B5kF8ABFw uM6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=jLZlsEJ5VG4J2SIrJhH+JChzqh+Qp8BnGJ+3NtUQBWY=; b=fDxNewVrAN29ejAAF0uiu5F6SSn3vitj0zKPIkhcAq4w18K2+Pc5JFbYnX3Jyf4fIY hUZ/zHJqr17SA9Lfy7tEVudjguT1nm9cvg+nLswKLaYYvdQJlPfgZvUFlsrJd8fsO4OT JKuxfJAmOlOuHNu0aA4QSqhqI4Z7jeyND3FqMYnplSdyVnE6jEiVlnQ7joJxVNr1k0qC Jy+PnZEoOk6iY6n30lel6C3GPSeaXnJKlxKWG/TfJsRgYtuWOaD7/knLcTqHCtOJIwgP NSU2U6R+SnHoeOXOY5c9Ago0O2PSJqrmFsf7c/NMHfS25vFFpuIv8smXCJV6blUij/CD kvKQ== X-Gm-Message-State: ACgBeo1tDqQdHdXlKTvEr5NQnizPFvJ4chLzsv6e9D9Swfnelm0Lv1Vu oJ7QPUtq3rT1K8fKLd7jajHddQ== X-Google-Smtp-Source: AA6agR72YO+XkKAOFG8EAWqhfJS9DgsgeqJVD0/dznf5HUHe32DG3AI0WIFn4S2T657w/aH1MH8O0Q== X-Received: by 2002:a05:6512:3fa7:b0:497:369b:47db with SMTP id x39-20020a0565123fa700b00497369b47dbmr6947362lfa.657.1662894749731; Sun, 11 Sep 2022 04:12:29 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 20/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:40 +0200 Message-Id: <20220911111200.199182-21-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index d1d1c1455b3c..87347e9c5f1c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -111,34 +111,34 @@ $defs: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sm8450-tlmm"; - reg =3D <0x0f100000 0x300000>; - gpio-controller; - #gpio-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 211>; - interrupt-controller; - #interrupt-cells =3D <2>; - interrupts =3D ; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio26"; - function =3D "qup7"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio27"; - function =3D "qup7"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sm8450-tlmm"; + reg =3D <0x0f100000 0x300000>; + gpio-controller; + #gpio-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 211>; + interrupt-controller; + #interrupt-cells =3D <2>; + interrupts =3D ; + + gpio-wo-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-state { + rx-pins { + pins =3D "gpio26"; + function =3D "qup7"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio27"; + function =3D "qup7"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41089C6FA83 for ; Sun, 11 Sep 2022 11:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231183AbiIKLPy (ORCPT ); Sun, 11 Sep 2022 07:15:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbiIKLOn (ORCPT ); Sun, 11 Sep 2022 07:14:43 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE5633374 for ; Sun, 11 Sep 2022 04:13:06 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id by6so7372823ljb.11 for ; Sun, 11 Sep 2022 04:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Ahz8RWfiLMT3ul4AnyZJntS/GGhk6GDdZTcm/1GzutM=; b=X6S0AXvZ0GFb67PsY8UTn1E7CLRrGB7f9EO8RnF4G36cG4M0UC4NOMBuSrQXmASFEj tovjfH7GpwCXlChlLmg1z2ZNUw3SehaWDStuL3L7EeLYShLfSz4TlEqUll6s2OMua+Mu CP0wbhHKuvpefbxJYx1u2yfTOBE1RhV5A5jkOsQdluh9QvRiLsqiJag+u+nZqpiWCGBY lfYi218xBFNTklNfniNPD7KhOrdN+F7h6F9T0O5Jv8kJP+MDbL5tK/K3Aa+M1qOPFKXv TY5DH0mSJAff015iB4Hje3xKqdenlWaHyiPW4Yl292uMJgueyWn8nL3s8cVtvr5fXb8T HgtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Ahz8RWfiLMT3ul4AnyZJntS/GGhk6GDdZTcm/1GzutM=; b=6KtZhNtxG/GzlJajt8OvzN1rGLC1YVd8CO1mnxy3/hWhJELOgIjLY9geHxwgil1RTG B55LTnXYOn8yC5fEXwRwK2DKmPIuIpBKiiWG25PoT9OIsiCKcoa+ju80eUfJbv1fXcyd N3tYV1FLXXI3D5IRlFnSPTYr1pfEL3tLPkuA7gKZrYKyZTG9AzitmQyLtYZdVbWIDnhq YxFtC7qvlg72TGhhqHLKI/2Zj4lWuxSYDlxxeTYmR/7l2ooIi9oORuEWyIzaGTpM8jrT hW4yl5hP1EOxeq2RhFQQtSgrnov2qLOpQneza0NChfK26oYvKhLyVIUzYxHfbyx8t6kS 3CMQ== X-Gm-Message-State: ACgBeo2PKQ6lmnY0Ks+naM+qK4m1CDa1C9SOuUGU5oEyOWSkw+QGPw58 kxi1Ptc4hQz1rp9WFL5HxCRQrA== X-Google-Smtp-Source: AA6agR64bxwtgvwgbQMkFzqZVQ3tvDucah3rX04eMkfwm2nmiPYdiaRY3kUrzgzEmMPDrE8lb1ZKEQ== X-Received: by 2002:a2e:84d6:0:b0:26b:dce5:2fe5 with SMTP id q22-20020a2e84d6000000b0026bdce52fe5mr4205708ljh.12.1662894750790; Sun, 11 Sep 2022 04:12:30 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:30 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 21/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:41 +0200 Message-Id: <20220911111200.199182-22-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 87347e9c5f1c..296f503c1d97 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -53,7 +53,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -105,7 +104,16 @@ $defs: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-9])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B47C6FA89 for ; Sun, 11 Sep 2022 11:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbiIKLNz (ORCPT ); Sun, 11 Sep 2022 07:13:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230384AbiIKLNI (ORCPT ); Sun, 11 Sep 2022 07:13:08 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E85173AB39 for ; Sun, 11 Sep 2022 04:12:33 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id s10so6772996ljp.5 for ; Sun, 11 Sep 2022 04:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=zWIyjK4dxfH9A9tyS53A/sJlwsqf8yeDaeYqVdTxLgc=; b=tUD1+6C3hCVPVFOS3id5nXTI6adwuUFvb3Z/8cNVtDl8VCPzz9mnjmlCyZ2ZrRKXt+ 8d1B5zdYjVt1iR7lJ26Lfazrolozts9OgUQoNw24bp4BPkMXY6ed74YLqdgvstfe0iWi 7hFFJIzUm9XcJ4xChvC+fXyWlEPgRmNvs591hu0nKy+9B8wGAmQ/yarQHInvHNuapX8x hPwlq/Iwj12iIJWyTwHvF+yRam2VTqOckAkfVnmYeOKKWxYGvJPpPuLh9EOGoHerQL85 gJf5LAhLMdphfq4kJy1JV5mzjc82W8rB9jdGjosuJ9DlcOxIVMYcB4yl948SgYBvkgu3 UHOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=zWIyjK4dxfH9A9tyS53A/sJlwsqf8yeDaeYqVdTxLgc=; b=MfU1Od/0/ppjMEYpMbjS6Vm5tOQg/MFaAvCrCDXnXzKuMb309GBL/iBJtjFWSb8QSL 1s2e7vJVe4o1nyMcWpP2cuYbhOHbz3I/Dq73RiZ6DzH5goTEhipC/Yba7ODUtAEE+jas ecoGzcFej2CL8BqwS3eP24r0KiTcGRzIyiHVCHFLkU12yccXQ/CySJlwfYTvUJnyVmkc BTXvZWrYulfXJAMOREdn5bINLZh28Frs6JKwwyI8IAo6mcZhS7KoZfAtc7oEJNSRVOJk T7v2QprdcWw0UDKjFH5SB0yPTve0Shq1LE6gV7UDATqCyiMGzt+Hs9HQobLOgylnf9bT eO0Q== X-Gm-Message-State: ACgBeo2bxDTKrOUApD16iUSUF1fu8G00GNtY2gyv/uBYmaABCV8Wu6pE HffLqEUbOtfqMSVtR/09V7Za6g== X-Google-Smtp-Source: AA6agR7xzMEvsn9zwERj173UliSnQ0E3HepcVO7+NPt1sn/QisreddnFlYb9sow1/tebXUzP+r4bRg== X-Received: by 2002:a2e:a887:0:b0:25e:3174:fb67 with SMTP id m7-20020a2ea887000000b0025e3174fb67mr6114743ljq.337.1662894753224; Sun, 11 Sep 2022 04:12:33 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:31 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 22/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: add gpio-line-names Date: Sun, 11 Sep 2022 13:11:42 +0200 Message-Id: <20220911111200.199182-23-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add common gpio-line-names property and restrict gpio-reserved-ranges to fixed size. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 296f503c1d97..9cd97a467648 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -27,7 +27,14 @@ properties: interrupt-controller: true '#interrupt-cells': true gpio-controller: true - gpio-reserved-ranges: true + + gpio-reserved-ranges: + minItems: 1 + maxItems: 105 + + gpio-line-names: + maxItems: 209 + '#gpio-cells': true gpio-ranges: true wakeup-parent: true --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10C3C6FA83 for ; Sun, 11 Sep 2022 11:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbiIKLOF (ORCPT ); Sun, 11 Sep 2022 07:14:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230469AbiIKLNJ (ORCPT ); Sun, 11 Sep 2022 07:13:09 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D69B43C165 for ; Sun, 11 Sep 2022 04:12:35 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id a8so10315348lff.13 for ; Sun, 11 Sep 2022 04:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=RY4LaWL+dRkOu6EloL5DY96DFt8TJE+sYnYh5l+nQqI=; b=idUywnLAj7qxOrZIs0y5P2qUJwo0mP+QB9qcQnsR25Xf1Pt9trvXVvE3H/OeMNITEW YBCVfrdbhxludiG67ik0J8RtwbWONK2FKdvPUP7u9AAhDk2B7u1yak1Znk3vYNcs9Pe3 IMObQU4bmjAq5aa/FKxNNAY29dZFdSNPXq+RcWuGNXUfb8bKhIp0qy37x8thE3WzjhCr vFYQRMlU9JBdxN44ntITPoiZRmNYlCOyoxZQA8SyxTpp1khTfy3hHgpmz6OqKd9sC7Wl wrjNMdBNN9djnWzC8pG81IBPhgdX7enTN35X30FNT1Em6l7xw5iZfOMsQDDoN9yu4GiU 23Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=RY4LaWL+dRkOu6EloL5DY96DFt8TJE+sYnYh5l+nQqI=; b=ax+LwFeqS9qXNEACHyjYGLkDs20tnp/aNJ7UgmZ89P0k/QkAztggtyn8O8XY7An2u2 k608hvnYvA1V/ur9d4EZcbABJ0t9mw5kmMhOGx6jzugotz3kZeyo8/D52Aw2wrQ0tEkg 7ju6HHRga1UJ4+4kV1UMbo6fG9aXB+cLnaFDsl+C0/J28jpxgiRXQj6cFNWeXE2/xFQ2 l+IRI5kTkviAfALMXB+9uNcbmB9DiKGodNfY9wZ64ftYAHuIH5O3gj3QzZ0A2fJaiR31 ERUxVtD8unHz64RLg25Afgfmd9n0i6/vIXD82l9XIaINOuQrfiM16hVFM7QambuP/3jO XZqg== X-Gm-Message-State: ACgBeo2FVsp/HLi9WttXI26IWuD9YPo+1fV5iL6UgSnmvQ0yoAQR+A89 zD+j3EeTl4oRdcBG73GhckJKzA== X-Google-Smtp-Source: AA6agR4LjjyJAjqMv6SGvaFJ69Y9MD+1lhdnDHmZCFNZPkBz6UXWDkwXWa7lr35f1RBe+jQnRvFqyQ== X-Received: by 2002:a05:6512:401d:b0:496:9971:78c5 with SMTP id br29-20020a056512401d00b00496997178c5mr6813980lfb.337.1662894754898; Sun, 11 Sep 2022 04:12:34 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:34 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 23/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: correct number of GPIOs Date: Sun, 11 Sep 2022 13:11:43 +0200 Message-Id: <20220911111200.199182-24-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are 182 GPIOs on SC7280. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 2d228164357c..f948a7f30f6a 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -60,7 +60,7 @@ patternProperties: subnode. items: oneOf: - - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-4])$" + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9]|18[0-2])$" - enum: [ sdc1_rclk, sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data, ufs_reset ] minItems: 1 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E763C6FA83 for ; Sun, 11 Sep 2022 11:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231211AbiIKLOL (ORCPT ); Sun, 11 Sep 2022 07:14:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbiIKLNK (ORCPT ); Sun, 11 Sep 2022 07:13:10 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 099EB32BBA for ; Sun, 11 Sep 2022 04:12:36 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id w8so10344166lft.12 for ; Sun, 11 Sep 2022 04:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=VjyXZG5WEWMmFKlfVnHeZRcue/3s1E0AVQ/ZTDMMIro=; b=VcZLlKfWfGvOgDWeCjGT5u4JPbqgGrFS9XabUJP6NCC2hK9TYQzhJM0iMhw7ykDDB7 Rqp/YybXIE30dGIuRCzm/DeBMLPVYjLb7zXGzBD1aWu0teTjFokjOPfDWZCUTnD/697D ZvCqfSXponcmK9K+WvPPozBB8+LwtHPz7/CMEkAqxWphycl1OdqS/U3oqmB8Tbp4Deoa Nfmpos3izoN7WqM9mVqz3YkdfCohwJhC3qs2wM1kq7zimL89SchA+oLgCKcG62zxR6lm mkthYnnrhkrIZgtOQgRD4k9auoTxts/BKnTbJ+WLtVZKoDCFyUMNV54De9CVf3c5Kf0T Xjyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=VjyXZG5WEWMmFKlfVnHeZRcue/3s1E0AVQ/ZTDMMIro=; b=vQKz69sgJNPOmrnf1SESyG/nu9B7X1bPoa9yBSy/iuw21jeuuFXnysqtHL1hoGCI2U gcps3aAIi/QVPwNCQs2ix57B+mBhWXquPNiEiKgoxQTLuKNjN3athxFe5Cm390EBGTDu nF1es2cZFViBUuw8k8MZUk+l5LUxbETJs+YeG/4/hAUVGCjGhLd+z6ORD6o7QHdlnjFk I/JSDivfAsKq5BvjM1C0VxZGSAKXwyqKt+tfH+scCoyZeoshYNnF7dTL67WE8Sy2k+6r 55ygGNxRmZAGDsSAe57gqt7pJAmF17r++T7aeEBAEsD+pKp3l+o63sTr63MQZ+uFnDAa 43Iw== X-Gm-Message-State: ACgBeo36JSGmTOkxUc+0n8uB3dcmviouG0uj4wuGjNEtj1xgdwnoRa6J 4TrhKD6ig+zbRCuX8obybzmdKw== X-Google-Smtp-Source: AA6agR6aZKdkJKzOG8y3SYo6qdQpTLkkBQ5gAzMlZEfZihhcjRLLfdtUvnYhbH+18I84CCtUBtNAag== X-Received: by 2002:a05:6512:3fa8:b0:492:d80a:e54a with SMTP id x40-20020a0565123fa800b00492d80ae54amr6920958lfa.173.1662894756232; Sun, 11 Sep 2022 04:12:36 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:35 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 24/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:44 +0200 Message-Id: <20220911111200.199182-25-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index f948a7f30f6a..9bd5fbdde9a2 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -51,7 +51,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "/schemas/pinctrl/pincfg-node.yaml" =20 properties: pins: @@ -118,7 +117,16 @@ patternProperties: =20 required: - pins - - function + + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9]|18[0-2])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84AC9C6FA83 for ; Sun, 11 Sep 2022 11:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbiIKLOB (ORCPT ); Sun, 11 Sep 2022 07:14:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbiIKLNJ (ORCPT ); Sun, 11 Sep 2022 07:13:09 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2678F3C17F for ; Sun, 11 Sep 2022 04:12:37 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id x10so7399102ljq.4 for ; Sun, 11 Sep 2022 04:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=E8Itur3iOiuWyn1wg10ogGLwaqdoS7iW/Pz+k6Unb5M=; b=zM8SjuRF+fdc7U44IskbAZtjD5OQnSfgy2A19OaEb4qbQ8mdRPTq7GlE6rZl+KbqHY 9O900GZ3TEzxZ0HFTK6RGRbWF9GjQ67RgvWWSkBKpKDSLlBqBVvB8J2keUkc4ePynWHV Px0LgN060gPTJSlCI+CTxAEmF4Vpc9EoyAdmCDZP8dec7ap4/hPHkqkqY9wLLmQJxym8 xy8hDfWMt2quNPO8pL2+mGJJ6GTxsLxWuSL6ZhI1ej0THOryG5Pz13fd3JjY4qD74Om6 wLAD0Ylv7aFMdauF/kCzDSo6vAcstsPeV7eIPki7rcZDaBrU1zF39KoqjEM/ughgGpT3 9XZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=E8Itur3iOiuWyn1wg10ogGLwaqdoS7iW/Pz+k6Unb5M=; b=2r9SgJQx7BZWs1plTeW3k6Pr0oTQk+9uUzGa5UydJiDeA/S72vjzASGFJWVvjxRYal wwIvIpLppAe1AXKUMgf5uTk9bwhCYpXaboV8MCDt77ViqFa6qJshuUC4wMQ8rA0l5eNo 058x6zzbQ1CYXT+DO3dfVzFtB0Z2zbRccZnuzVmjTsp76BOkXhXCl7TxJf0No7lIZ6Fd rJrwKlQaktiQW1VM5Wpm9WsccX9Ef8fgZD8n7/Z19IYt+6wCs5G47laPS+06LLcXphh5 JGrl1XHFhe4+HMzT5R3DSLRemPZQD6ShVwDkCK8K5vYx9eit7tk+3p4Uh7OzkpA4jysA MnIg== X-Gm-Message-State: ACgBeo1FKxtczhgf3qeGqkktr03g8XEYFcgMDhmw+OiJTTL+oUSvYUM2 0NZ5LaGq2niHd4PVKbrbnX3N9Q== X-Google-Smtp-Source: AA6agR4OlfkdwenjZs9F0LdlvajDspnil4ZBDroaoegHdPq8JVb9CGo+23IToeRslD+L9KjcKo3HMg== X-Received: by 2002:a2e:b4ad:0:b0:26c:24f:b260 with SMTP id q13-20020a2eb4ad000000b0026c024fb260mr639838ljm.173.1662894757357; Sun, 11 Sep 2022 04:12:37 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:36 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 25/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: add gpio-line-names Date: Sun, 11 Sep 2022 13:11:45 +0200 Message-Id: <20220911111200.199182-26-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add common gpio-line-names property (used on SC7280 Herobrine boards). Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 9bd5fbdde9a2..35d3962dac58 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -42,6 +42,9 @@ properties: gpio-ranges: maxItems: 1 =20 + gpio-line-names: + maxItems: 174 + wakeup-parent: true =20 #PIN CONFIGURATION NODES --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6473C6FA83 for ; Sun, 11 Sep 2022 11:16:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbiIKLQK (ORCPT ); Sun, 11 Sep 2022 07:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231234AbiIKLPm (ORCPT ); Sun, 11 Sep 2022 07:15:42 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EA163DF34 for ; Sun, 11 Sep 2022 04:13:18 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id m15so10343325lfl.9 for ; Sun, 11 Sep 2022 04:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ZI124F7nFvecFQ6h5oN/++WSRxanSVcUeZ0lQ6afuW0=; b=zlAYo3ARhSagRIyM8pMBozYeCVh+GZM9nwNF3eMunOVp4+60djhiSTSPFzotCJlwnf 5mR/X2Hw5rO9HB0F7I+sG9JdKSYhZLknhKpiTBkQ78zTxnKLTESmnrdVKDYJHuMh/2aC ZcHHUOpeeXSVpaJF0e2HRP25ZJmWlvfiAKRpFrsIjxUOi825d6+eK9fY2lFf9IeLH1sC fV4F6AddIOcVyh0w8hJhGa8fIVWHwoeNcrFCcBDc+hm2fxeujJf0JMet8jTSbTZ9TafG cOJqO8TV2YpQgiLjqc+Gc3MuuevbS+f9tIDmA5qnZWFIcrK8Anwu4P6QBmKI9pqMo7zd gfjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ZI124F7nFvecFQ6h5oN/++WSRxanSVcUeZ0lQ6afuW0=; b=H82NvFQz2V5mjNXMJShMVcaV0QFU1q+YpyNMWzrSHcQF8/+ZSEZzE2s/wKoY1krv/G OST8ynoRG9mpGTZ56i/NTyTCo0Z0bVwMYzUeSsoxzmL4j5s8y83AeLHNaTS4U92sEdIw bH0TQzFtmkc+/nKGeMA+3T6dxoA8KtWwJTJfmBlH0aW7VYkulfnyr4XTUqkIScSSrPYB 34eUegRbDMubcEdqrXuvTmbwTeBH87tHaXu2aCHdDD3Qzv19yV8RAxE+Jg238gSTQl81 41sTEdBLNK6H+3OTPjufo26hz7mF10DKo9iB/PqPW3kwd2fm3WLvdpZkNFvIqU8mMTqi 5yOQ== X-Gm-Message-State: ACgBeo38W3REgfsW5bM9KFfVucHhLvAM0gcSL+UyFHXuGt5ndXRsM4FP AS+OmqlFq8GVi2OrtFXQugzn3Q== X-Google-Smtp-Source: AA6agR4Hl7vpJPy1Av5m6PEy6vumrvOlEFfhHsyZAj/7n2Ulwx882n5nr/jJtIbfPjN1gsXMbCSxGQ== X-Received: by 2002:ac2:4bc1:0:b0:48b:2ac7:bd67 with SMTP id o1-20020ac24bc1000000b0048b2ac7bd67mr7231159lfq.499.1662894758471; Sun, 11 Sep 2022 04:12:38 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:38 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 26/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: reference tlmm schema Date: Sun, 11 Sep 2022 13:11:46 +0200 Message-Id: <20220911111200.199182-27-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Qualcomm TLMM pin controller bindings should reference generic TLMM schema (which also pulls generic pinctrl schema). Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 35d3962dac58..b29fac302e6e 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -134,7 +134,7 @@ patternProperties: additionalProperties: false =20 allOf: - - $ref: "pinctrl.yaml#" + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# =20 required: - compatible --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0C4C6FA83 for ; Sun, 11 Sep 2022 11:16:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbiIKLQN (ORCPT ); Sun, 11 Sep 2022 07:16:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231244AbiIKLPp (ORCPT ); Sun, 11 Sep 2022 07:15:45 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87A1033E0E for ; Sun, 11 Sep 2022 04:13:18 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id y29so7396148ljq.7 for ; Sun, 11 Sep 2022 04:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=fSGDJbvwyUNRzf7TxRi3X4pjWeIi4tImKHqgX99wRZg=; b=SJuJT4hOKlR7HkL5zvZBRHZP8tWF16TPXkik1KzTvZKM7k0OV6vnOGvwwpEwhKBAVf SdquDefRsUIUCnXgTsXjcwXtV5qkn2VvZYLv/vf8cmL6qeSu1neSmg9XScchjI976ef3 qRHdNIjscj+dSTFRaQqGsLHB/1ROMzxPIK3WF5oroJBr9tbkZKv2vIpmjXnALId+/iqa 7BS2qFPHwsANKHYa1numidkzho9zzplKKZwLXmkPFUUsNGwtqpZ8GV9ELLEtyWSUk5oE p5aFJyUDS4U435LALlxrP7XvsSZG8BQF+q8mctMjHcoW43a1UG9zv3NCbkVojJKiI61n QJuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=fSGDJbvwyUNRzf7TxRi3X4pjWeIi4tImKHqgX99wRZg=; b=xZVy4+WblCk4aCxuZH14wxHeb6Hp1rzI7VUtQzOjsdxXPW6GQANJqml1Alju20AcBK BP1xTAApu/Z5FE2vap8+SbeSy4u1H6A9pYAWsWOSCisP5t7byuXx2OaFEjP77EbC+kQA INqhF01cROTcn1rQKiBj8OTsGTQVbsX3vIE6rGHn8e+1UzOUWsV5VhkrXBeu3I9X9I6z z0qfhRU/RHqsJSqdqEqnGopiHaMAIDBE2Yejbz1ISr5kw4jRvoZjdaeI1UFg0Wfy8Na1 gSotF++yCxcUHpjj+QhC/VkZ9V652pwX1JIp0noZfpV8hZmMpUPqeiN7bd0uC6nPL1UB cRSg== X-Gm-Message-State: ACgBeo0eevLVhDVlUJphBAHAX04PTYyw8ajyfIvqfNw1IMyk8aHViKAU gDyloDD6PLLu73v8LFfK7nx/PQ== X-Google-Smtp-Source: AA6agR7PJ5OEvlARW6u9NTBlWeXwmRIK33GdiFkFXp5EnT0Mj13LONe2oVSj5SPn1toJleAObn9LLQ== X-Received: by 2002:a2e:9a90:0:b0:26b:efd1:18fc with SMTP id p16-20020a2e9a90000000b0026befd118fcmr1929275lji.499.1662894759628; Sun, 11 Sep 2022 04:12:39 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:39 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 27/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:47 +0200 Message-Id: <20220911111200.199182-28-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.= yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index b29fac302e6e..30e682579391 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -150,22 +150,22 @@ additionalProperties: false =20 examples: - | - #include - tlmm: pinctrl@f000000 { - compatible =3D "qcom,sc7280-pinctrl"; - reg =3D <0xf000000 0x1000000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 175>; - wakeup-parent =3D <&pdc>; - - qup_uart5_default: qup-uart5-pins { - pins =3D "gpio46", "gpio47"; - function =3D "qup13"; - drive-strength =3D <2>; - bias-disable; - }; + #include + tlmm: pinctrl@f000000 { + compatible =3D "qcom,sc7280-pinctrl"; + reg =3D <0xf000000 0x1000000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 175>; + wakeup-parent =3D <&pdc>; + + qup_uart5_default: qup-uart5-pins { + pins =3D "gpio46", "gpio47"; + function =3D "qup13"; + drive-strength =3D <2>; + bias-disable; }; + }; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BAB2C6FA8B for ; Sun, 11 Sep 2022 11:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbiIKLOZ (ORCPT ); Sun, 11 Sep 2022 07:14:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbiIKLNS (ORCPT ); Sun, 11 Sep 2022 07:13:18 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6AC73C8F2 for ; Sun, 11 Sep 2022 04:12:41 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id f9so9636202lfr.3 for ; Sun, 11 Sep 2022 04:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=qSa6F8HJSYWjDBg+j7oIEuAdlpcYu3Iz+kDxwwRpkho=; b=fcT6LABS3+06XZ+IpQVOFKLZ6waL4mRDByzgK2SU8YdN3vIM7Jhblze2xDl5hWgPvc HIp4AnYPRme4ihYksJnB9YqXhwGhMbPRLTBB+panMzpn8Ztmyi44R0rhdk2JksrzMKoK LtpCMFtY06R3b86YngSFYaq5gSi/KaBGHQRfaaMF4E8WhCtup5wYrXh137Mna1v1LS2M lAkMq0BuA5ZH5/YMHAgS3tK0OLGcfNSWdVQn9XjW7jUb4voorburunyWw5jc6SfxmDW3 NOmU5rDsN2VENXGG22XR0jG3/j1x+bYd7/N3qrg0JXrtyZW0hYZxwrPjhhQ7dW08up2c jb9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=qSa6F8HJSYWjDBg+j7oIEuAdlpcYu3Iz+kDxwwRpkho=; b=oh9IECe3UJ3eWzhQymxeAIC0L7mblFtoGXN3W4+LNm9CMLrR3Crv7lDSbZ/sTJ2nll wv1lNmRe7V79xDBa3i5NKCg0ljL98X9Tkkd51nzqFKjiX35coLnxZcpWirkSL3dS3OoV CNtzLxWWMj9K+lW4lPGGcMXMimmSAvrSFADyScPN/hipQsf0F+DI5GHOPySGFN7T+htq YKVNNMMIRF1UHcVbkeYlcPuiFCB7W6tnLBDNj8n54ZDeGIPRmOKT4PAqiAlUvTYYlx0N VS2WwTnTfytKPOAT7m5BnjZ9UQUDbcSsDk2MHVhP0255MKVw9/HH685Fa5bpIZ5XpA7Q LL0A== X-Gm-Message-State: ACgBeo1US7mr6bkoviMldGkn+tluH+hPwXwKBqJCPVK1p6keqPChpfZg kHgTBSlmDbBYCEjCP/xFTEjAHg== X-Google-Smtp-Source: AA6agR5YHFeNsypLF6H4/v9a+555z9gDBP6k/IZpoOWSqfNKrbVWO4xSoWLUtKAtlz2xtxkSqGZnqA== X-Received: by 2002:a05:6512:1588:b0:498:eb9c:2fda with SMTP id bp8-20020a056512158800b00498eb9c2fdamr5306190lfb.91.1662894760677; Sun, 11 Sep 2022 04:12:40 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:40 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 28/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:48 +0200 Message-Id: <20220911111200.199182-29-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 86509172603d..646fabdf81f7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -51,8 +51,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sc8180x-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sc8180x-tlmm-state" + additionalProperties: false =20 '$defs': qcom-sc8180x-tlmm-state: @@ -137,13 +138,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio4"; function =3D "qup6"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio5"; function =3D "qup6"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B8DECAAA1 for ; Sun, 11 Sep 2022 11:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231262AbiIKLO3 (ORCPT ); Sun, 11 Sep 2022 07:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbiIKLNY (ORCPT ); Sun, 11 Sep 2022 07:13:24 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E94DB3CBD4 for ; Sun, 11 Sep 2022 04:12:42 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id bq23so10362973lfb.7 for ; Sun, 11 Sep 2022 04:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Z/95Brm84Hs/a3P501KqW9gtmX0Qfi6hmXE/MDLL0vI=; b=AcIh6NSSNJ/VA5Tz1zWjElrJZBfojwpeWF8hLMoTQh9+nsXu8edbrEGZPXd8IUwADp CD+zaRzDmFIW05Q1715P3cHv+8s53yPUYaalUc8O6joV3HE/refgbKQwg3rwZ328K5LW YM9leS3TfwC/sCNfjbiYko0tYqOa1f2TqOFi/Fn/EOSTdbxLFp25mBL8fSeta99ITaNd JZzlHzSi4ahtNKGOARCwOHitYk/oC3F/C4Gch21FD3U0b2o2ixnhKaWYTowdhcecaqpl AeZLDoGGXqKF4vcmCsR8XAjVpfslATC5l4hlOS/olziY7lIim9fujf6jlhhXTi6iML1Q uBkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Z/95Brm84Hs/a3P501KqW9gtmX0Qfi6hmXE/MDLL0vI=; b=l4P3SmrE60gHB0K3h0Ji+FKX9lgkVKkFSh3gQmNy0KdD669YN7FvRSKlrhDNlLbvY8 7xAKra5OClOAcRshD+M4sgzMQsv2x6aNGc1x6qRTLVJGg80s67OMJ8jpRMOthUxQWQS/ rfjBPKG71ognQhAy4dtirGNQlOjXimqT8drYU52InHWLebUiFjeG0O+z4b6fw3bp95Wr YUxYbRWgjRUC54f/+29KpH+ZDIWgp+BUDJeYhu4WOTTMYDnfXYlHJMwenHP1PSaBGOCI DGlLOX/QzLyfV/i9D8TONRSMLFGFvlgTPGR9MFqHs+M3xCd7p85EmnzjCQEY+SYJmuId +C1g== X-Gm-Message-State: ACgBeo3brpYfj/ditAGre2UlI/+bKlg7Sahl+/tpjuoZaoIvDQ8Wf9fl YMrbfTXgMywFfTEit14YGtJI2A== X-Google-Smtp-Source: AA6agR6IKPVduQUCvJSyGJ0T/BoU98cLLGYwkErlZbKVII4M/wu8OPGzMYdlZzHq5TqNHc1IWPffCA== X-Received: by 2002:a05:6512:33c8:b0:48a:fe63:e4ea with SMTP id d8-20020a05651233c800b0048afe63e4eamr6915390lfg.415.1662894761803; Sun, 11 Sep 2022 04:12:41 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:41 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 29/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:49 +0200 Message-Id: <20220911111200.199182-30-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 646fabdf81f7..4afe20bac87c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -61,7 +61,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -112,7 +111,16 @@ patternProperties: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-8][0-9])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB40ECAAA1 for ; Sun, 11 Sep 2022 11:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbiIKLOg (ORCPT ); Sun, 11 Sep 2022 07:14:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230436AbiIKLN2 (ORCPT ); Sun, 11 Sep 2022 07:13:28 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87D6E3CBDA for ; Sun, 11 Sep 2022 04:12:43 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id z20so7409070ljq.3 for ; Sun, 11 Sep 2022 04:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=nXdmZRWySMH2y4BHslWMyDvfmlDcWpCDzcQgKmezSiA=; b=UlAZv0nKRhX0fZ+HjxVuvwBdtMlpVeVd2Yi/2YXQvSZsjL0fTglhvwEeKCmDs1I0Fd 91bvvkZcyAnrEyTlUF9qT4WdyFP+uuIPiZa+xh8YuzoBfU+ZTSWH97ZwmP4ORq/dSB8x Gl90lDAZXu92HgwgaROu/29xE70zaxvUDL6ooCPb9EL+m+xZ5hxuZDAktxEI0XoHiUCT JBo0TJE718Y5oZlXEP4RykdUoy6W/XFNxGlsR6R8ZsB/yzmPV81EmytddUar1Q4u3zjx NOnt1dGvqjLTQ1eRwSxhnZJkmRqJ4WyqvSmeNYIonsGypHPElXvNV57u1PT13f7Tx/O0 YAMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=nXdmZRWySMH2y4BHslWMyDvfmlDcWpCDzcQgKmezSiA=; b=FckZJBGzDgpTIJqMtQFYFuSf0VYmPse11LH49/UpdIkUhgKWsJtlhQbexxvJ3Ijk3i a77Zi1WHnaYuaygmaQ1fXR2vTGoKrh6UfGTZ5arRcUjPOPL92wUbQ67uPJKJXGZI9Loc Qg4ubtbkQf5GhDIZW8onPFWonQOzbX/uLXzyDmDRsJLUfBnSwrGwB5OWzC5c2z5SgXNI 9n34gsYv59OhZmIg3kqdc2b39GAYxF94QFdZ0fvcHYZGAWpZh4RaaysuI/3NKrY+Ct2l Yczg7z1Kngz1hGUBj2DeiJ5fjpGj7LgPLzrSmKkzvwnpMLR4V+I3mnlxSPJ3lMPcjjb3 HXaQ== X-Gm-Message-State: ACgBeo2uFwnQr8z1+lVqhadfDby3kagWBZppqqA7sormpqQilu8za9KP Klb141uY0GMrhWRoDrTmfWaYvw== X-Google-Smtp-Source: AA6agR5I/tGMgMOjbRLS0g2D7/H7nug+yH6MMWQA8TT4KGFTnqcJFWtdQduFm8lM0QIvCSSDsAXAdw== X-Received: by 2002:a2e:bc11:0:b0:26c:565:12f6 with SMTP id b17-20020a2ebc11000000b0026c056512f6mr300214ljf.91.1662894763042; Sun, 11 Sep 2022 04:12:43 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:42 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 30/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:50 +0200 Message-Id: <20220911111200.199182-31-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../pinctrl/qcom,sc8180x-pinctrl.yaml | 64 +++++++++---------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 4afe20bac87c..b98eeba2c530 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -126,37 +126,37 @@ patternProperties: =20 examples: - | - #include - pinctrl@3100000 { - compatible =3D "qcom,sc8180x-tlmm"; - reg =3D <0x03100000 0x300000>, - <0x03500000 0x700000>, - <0x03d00000 0x300000>; - reg-names =3D "west", "east", "south"; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 190>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio4"; - function =3D "qup6"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio5"; - function =3D "qup6"; - bias-disable; - }; - }; + #include + pinctrl@3100000 { + compatible =3D "qcom,sc8180x-tlmm"; + reg =3D <0x03100000 0x300000>, + <0x03500000 0x700000>, + <0x03d00000 0x300000>; + reg-names =3D "west", "east", "south"; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 190>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio4"; + function =3D "qup6"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio5"; + function =3D "qup6"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A50ECAAA1 for ; Sun, 11 Sep 2022 11:16:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231436AbiIKLQS (ORCPT ); Sun, 11 Sep 2022 07:16:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231146AbiIKLPr (ORCPT ); Sun, 11 Sep 2022 07:15:47 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE873ECDF for ; Sun, 11 Sep 2022 04:13:22 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id z25so10392462lfr.2 for ; Sun, 11 Sep 2022 04:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=LY6MROhdDWqu/4edFHort3LM4phvkt99NZ7SpMsHito=; b=UlXwv8zHCBGWyOuF0fWGnm/+ajG1lCVWlYEsBbu/dKAvoHgwdqOuQgjf/WTOzXSvUq MqrbG3c8nac+2YDkXM7lDCliEMZm2Q9693NYyn/7thWYtKG2+fDMmCh16CkxP0xQBWak yVIBYEgDNEALssE4NdniucFuuaqHJAlbkR6H/NZiUqYp02tQxdJsLW7n1Kgfg5fwcUxf AXxb34hgNGmQv0niVlnCuIlqF51KT8+u8vYR2iza4VmyvXiENAwTwjZB2evzmqYHLWKl fzwpSwZETKk4A27gXcd3BPk8SSl8C/t4Q1+2ceHaOeE/5KEOMwOnyVFXURUG8TffgOWZ gn1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=LY6MROhdDWqu/4edFHort3LM4phvkt99NZ7SpMsHito=; b=edYSagK9xUGzRYlaZ1TUPjTJm4oX5ZBFztCYXDBur+Chd1PQ8ufUVGusWgpWCrRZAY 4bjogq4SfNZzECo4iCgaKRB4GqjMLduM751+2+U1yVesFwLtwjkkhqATapycVo5dFoUC z2enXC9x7WrB2GiiVE19WPA5/t3gRf0PmtaQGRNaNhB1XWuKBfR9CIQcKaFNy+Q1oy9z jdFjqUywT49kicIg3Cz8F9zUWAeWlwaTmxujVyvQSwj+uUrmnX1CwuTUxFJdFwIYmw1O 7TQYK1j9b8REstuhF0GO+4lxuaBfsHSpv+qUi7zCy7X+VUXDZPjhiuAPnKBnEdgNy7xU O4Jw== X-Gm-Message-State: ACgBeo1pH8w4GliGeEZcPUXm1Pc7/vLe3GVn/aRtnU0Sss7krTD2rBxg iw00uzw4MM7hiMld1sshUIeBGA== X-Google-Smtp-Source: AA6agR75JudROwn7bBCFv7WnkmTOAERMdjhFVJG5LusllC9UtEA8ZA4zgLpjORcn6SoUc/vBMI+PDQ== X-Received: by 2002:a05:6512:3a90:b0:48a:fcf6:3137 with SMTP id q16-20020a0565123a9000b0048afcf63137mr6654623lfu.255.1662894764144; Sun, 11 Sep 2022 04:12:44 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:43 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 31/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix matching pin config Date: Sun, 11 Sep 2022 13:11:51 +0200 Message-Id: <20220911111200.199182-32-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be either named 'pinconfig' or followed with '-pins' prefix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctr= l.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.ya= ml index 87a381c9a19d..5147afc28721 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -43,8 +43,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sc8280xp-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sc8280xp-tlmm-state" + additionalProperties: false =20 '$defs': qcom-sc8280xp-tlmm-state: @@ -135,13 +136,13 @@ examples: }; =20 uart-w-subnodes-state { - rx { + rx-pins { pins =3D "gpio4"; function =3D "qup14"; bias-pull-up; }; =20 - tx { + tx-pins { pins =3D "gpio5"; function =3D "qup14"; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6508DECAAA1 for ; Sun, 11 Sep 2022 11:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbiIKLOr (ORCPT ); Sun, 11 Sep 2022 07:14:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbiIKLNe (ORCPT ); Sun, 11 Sep 2022 07:13:34 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 185C93D58A for ; Sun, 11 Sep 2022 04:12:45 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id q21so10451118lfo.0 for ; Sun, 11 Sep 2022 04:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=XCpzuH6l9uwERwbmApSAocGpO1WUQ+kJaH+BaZZ4Pgk=; b=XfWPipm8NHuHGFvOkzCgPBObPaQVO60zqd+ssj/FBsKKyHzkIDUsRCDAeiJ9gY71e4 89VeL0jtf76X+KYLAp81TQb8bZYYM3cXdHE98pISUzxac0+907bctyFIc04qvtAkCvEk CKVu6AB0eqEcaIQnnQ3AwJWJE2mJLLB3lJgxt2BVUIMbJwsVCpDTDRkUAJORNS+09pmr Y3cOd1FwbKeBAldntvZY8urBxPxZqV44rNlGZjH6tgPDOyHOPSCDKy0aOLAizBejtOME kA4KKNUoBuMOm+TPYvpj8+9FL+Dq45dBlb2OFWWUol1+ZVX7+LufOK9sOlYCrjmmbRl6 f8sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=XCpzuH6l9uwERwbmApSAocGpO1WUQ+kJaH+BaZZ4Pgk=; b=ZjGutgFI8COEKjwTXtKUendYXeCMQYcqPZ5u19ZfeYv9s7AiFotDuGYNYQ2RhqDxPl BHhJSWME86+mzLEj564Wfj6+JWAcYaNUgi7whW3w/O3zEHDLgm2fbWxiAYs4ZVxkMAjA pJqtgTpgKB/g9pB9OA6Ywyj/3ddALGK73OHOgs8e5floUSJwqXbuZMuRp4fTLG5qcxOx JZ8bQTpHE7gi+i4bsOYB0/VbIO12+A0NCHp9OvhqQG3yLnd619pDmacew9WgWFDX2Is/ lQIL3IU5FRBsLKLIoR67640Eo893K6HkH5mfpmfP5HBsK5JF6gKortwRoa6B1XplVeNb qqWg== X-Gm-Message-State: ACgBeo0XOqCOIQWAdP7a8GPu4pgjdDbGirqkQcDg5Lu78AGpRWCcEkgx sLkXNYWsg76qTUhclteOzTYybg== X-Google-Smtp-Source: AA6agR7kqkbFDwS3KArvaunAcNLIXhS1j02OhPXcOWC979/CGLTm+hr9z1H2bOvTyArfhByimnr6mw== X-Received: by 2002:a05:6512:3fa9:b0:492:d799:1038 with SMTP id x41-20020a0565123fa900b00492d7991038mr7303081lfa.574.1662894765340; Sun, 11 Sep 2022 04:12:45 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:44 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 32/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: do not require function on non-GPIOs Date: Sun, 11 Sep 2022 13:11:52 +0200 Message-Id: <20220911111200.199182-33-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctr= l.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.ya= ml index 5147afc28721..8610f2701388 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -53,7 +53,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configura= tion. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" =20 properties: pins: @@ -113,7 +112,16 @@ patternProperties: =20 required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-1][0-9]|22[= 0-7])$" + then: + required: + - function =20 additionalProperties: false =20 --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE309C6FA83 for ; Sun, 11 Sep 2022 11:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231340AbiIKLPC (ORCPT ); Sun, 11 Sep 2022 07:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbiIKLOD (ORCPT ); Sun, 11 Sep 2022 07:14:03 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 853BF3D59A for ; Sun, 11 Sep 2022 04:12:47 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id bt10so10405950lfb.1 for ; Sun, 11 Sep 2022 04:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=691KvJvip9wejzXr7qpWGsmceASveD6n9KP/WuDonD8=; b=aLxzrcdLFl7uHztPJyUgymD5UhbCoTd0RuTnr82HkYmtqvQC6quDqk7QuKKlfCvpE2 ZWt5m1TnHf869tugxUfGIeJ3AZikUniA4tBcEcf3gHjVrGqvDUyDkzfcquv8sgn2Pw2u ioUOqm62ozdo5LkDtD5Kn6C4LPyQh0oOyrJ89x5YHwaYHnoqqL51RK3tTpIBS4S9Ra4b QkP6BXmSXUVaVagMf+PDk5T+rrAkpV6302BOcpNewVZAZ2Ce0LaBjE9ekkDTQk9BL7y7 MFUIF1u062dVDxX3xPxebENZn3Xwj8FLvkmiSPWIjJxRf61MDlBpxkxdj9Lf/iLLuO/w 4krw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=691KvJvip9wejzXr7qpWGsmceASveD6n9KP/WuDonD8=; b=yXEhdkHZuuBcO3M0uy14gstwTuSYjIzY6PIDuVoGEWcZMDRXcyNwCvHsX4gMvQXSwP TPG27SP/0nJubv3D3h34KEJG2zzvr6eGTyzxqg0d76GbS8xGHpQi8z1eNnNQyKW70GL8 MHziulz0V2HOcpwEH3O5tlVfU4n1A1spox8avqCtqkIxxFiVHeBcivKYtXIUoTWd/tef IgG57VLeIht3i+9MQzXj19NdBJ7xQAK7VnVBt3KnkWTXL78vhCQ4U+uqeP3BD9gfpzZU 1k+LP3I46iVvmFHEdAZy4Va2yLSNGK8aORI3dtjylMuCXf9VLt9/pbgcoxXbWoMq+Nzx M+EA== X-Gm-Message-State: ACgBeo0C2zN7tpXcka7eQD9f+xlelwVCM+R5zccXnIyEgSYD9HxZcRd1 TlZf4l9NwOlHgBGHVWZy1l2a6w== X-Google-Smtp-Source: AA6agR6qAHPE5W4Bko0Tyb5fzR49diqQfAoaniDLvQD3dg29AqngAImjgUcacpSEDX2hqyFe4h2u5w== X-Received: by 2002:a05:6512:1188:b0:499:6fbf:d751 with SMTP id g8-20020a056512118800b004996fbfd751mr2716870lfr.51.1662894766675; Sun, 11 Sep 2022 04:12:46 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:46 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 33/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix indentation in example Date: Sun, 11 Sep 2022 13:11:53 +0200 Message-Id: <20220911111200.199182-34-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctr= l.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.ya= ml index 8610f2701388..b9ab130cd558 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -127,34 +127,34 @@ patternProperties: =20 examples: - | - #include - pinctrl@f100000 { - compatible =3D "qcom,sc8280xp-tlmm"; - reg =3D <0x0f100000 0x300000>; - interrupts =3D ; - gpio-controller; - #gpio-cells =3D <2>; - interrupt-controller; - #interrupt-cells =3D <2>; - gpio-ranges =3D <&tlmm 0 0 230>; - - gpio-wo-subnode-state { - pins =3D "gpio1"; - function =3D "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins =3D "gpio4"; - function =3D "qup14"; - bias-pull-up; - }; - - tx-pins { - pins =3D "gpio5"; - function =3D "qup14"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible =3D "qcom,sc8280xp-tlmm"; + reg =3D <0x0f100000 0x300000>; + interrupts =3D ; + gpio-controller; + #gpio-cells =3D <2>; + interrupt-controller; + #interrupt-cells =3D <2>; + gpio-ranges =3D <&tlmm 0 0 230>; + + gpio-wo-subnode-state { + pins =3D "gpio1"; + function =3D "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins =3D "gpio4"; + function =3D "qup14"; + bias-pull-up; + }; + + tx-pins { + pins =3D "gpio5"; + function =3D "qup14"; + bias-disable; + }; + }; + }; ... --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78FFECAAA1 for ; Sun, 11 Sep 2022 11:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231283AbiIKLOl (ORCPT ); Sun, 11 Sep 2022 07:14:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230526AbiIKLN3 (ORCPT ); Sun, 11 Sep 2022 07:13:29 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CF5F32D81 for ; Sun, 11 Sep 2022 04:12:48 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id z25so10392609lfr.2 for ; Sun, 11 Sep 2022 04:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=e91Jrvw0byDqU3CWt6E5mPoWrF7xdNn1DqHo4tKVYDs=; b=enIi1l91688Uylbui5XHd2/yt57W1FH/w89unA4B82kU/cO1uZBT5JQCdy9Ai2ikKx wUeXJfJSRT4IlBuOpR2FI7TJGRfzGQYFrzkUVC/4u88KVVX+2oExO+4WjRhpmF8hT0Pa sMXOYBwsIG2d8nvO+wDa9g13V9Gma591dDAHxlm3BBbNnWPnCw2XVfJojofq3UQ+TDjg 0okC/ZlaAq+1+fup+fKuczLxdiQEtYad42JVjqvwIJ0LXBPKMFPxbhMmGYfJNc4uLdpf qHZ0BtX8jgo5CVRJ7H0B8lArDO+PZt3C9xwJAXSPRbzepGFDg83NKCIiQJ1Vg8QfAsQo w40w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=e91Jrvw0byDqU3CWt6E5mPoWrF7xdNn1DqHo4tKVYDs=; b=KkS9C86FPpRRZMBNxcYlBw3orsyp8ISQIu89NRIVB83xJlPL8TrsJlNwJndLkN1eXD JB6D3SVAs2SFNhxgRx9tt+KuCizvvknE3/aDf7wu/o8//iQASAk/7XxT4UqQRRxt24DA Af6U4n8GC+i4cgZ2d3ovsoZP5TnTNM2+X+maYKKwu2L7DtqcuI2SAVOeBjI2b8JcUDTQ wLpSEmdpNFhhqGDt4WSQlyXbUV5/x/5XJ58ZXmUofCasI5TAcv/6nP04iJk4MVpbu8tG si1sBF3nKmTcclJ0CNWUeQ3aBHQFW2lKdSime/HwuEY0sOfGNCepS7TzkVw26mvpnE0r +Tvg== X-Gm-Message-State: ACgBeo0vow+D3LT7cg+g84yzc6I2zBYBNkkpHUz4LpxXHnlaCkNc112r /vHqr+wZTxQKV+oWThX8TpqeyQ== X-Google-Smtp-Source: AA6agR7RDHlm1PY+nYi3QuP1c/tOFiE46t0Sq5QC8f9PuEUrvs9WUaMQzaWGD4+uh+eZ/EONPDn61A== X-Received: by 2002:a05:6512:3b94:b0:492:bbe1:df3e with SMTP id g20-20020a0565123b9400b00492bbe1df3emr8119832lfv.371.1662894767815; Sun, 11 Sep 2022 04:12:47 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:47 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema Date: Sun, 11 Sep 2022 13:11:54 +0200 Message-Id: <20220911111200.199182-35-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 4 ++-- arch/arm64/boot/dts/qcom/sm6125.dtsi | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b= /arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts index 0aad2e94e757..6a8b88cc4385 100644 --- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts @@ -87,7 +87,7 @@ &hsusb_phy1 { }; =20 &sdc2_off_state { - sd-cd { + sd-cd-pins { pins =3D "gpio98"; drive-strength =3D <2>; bias-disable; @@ -95,7 +95,7 @@ sd-cd { }; =20 &sdc2_on_state { - sd-cd { + sd-cd-pins { pins =3D "gpio98"; drive-strength =3D <2>; bias-pull-up; diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qco= m/sm6125.dtsi index 8c582a9e4ada..1fe3fa3ad877 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 { #interrupt-cells =3D <2>; =20 sdc2_off_state: sdc2-off-state { - clk { + clk-pins { pins =3D "sdc2_clk"; drive-strength =3D <2>; bias-disable; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; drive-strength =3D <2>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <2>; bias-pull-up; @@ -413,13 +413,13 @@ clk { bias-disable; }; =20 - cmd { + cmd-pins-pins { pins =3D "sdc2_cmd"; drive-strength =3D <10>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <10>; bias-pull-up; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 364A2ECAAA1 for ; Sun, 11 Sep 2022 11:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbiIKLPV (ORCPT ); Sun, 11 Sep 2022 07:15:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231205AbiIKLOH (ORCPT ); Sun, 11 Sep 2022 07:14:07 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93FF93D5B5 for ; Sun, 11 Sep 2022 04:12:49 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id u18so10359929lfo.8 for ; Sun, 11 Sep 2022 04:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GgI6sNuIiEld/+iiG14XAnJiIn6TNY0eqR/C3vJoJeY=; b=L7H8zUOiqJ2tFqdxdf/JxX7apiRalZmhatFV320dks5MvMQzkdX4Q9k3P5xULYmB5E USOzgtPSo3bpYrTGSD2m//G7AWBH193tCA4no0h5dOF8CyHG2ThVEdPtq+AI7DPp2clh /nCngcJt/i50nKduun+fB9DIU3ghr03Ea9HfwbEESNiJXe0v9W7dRkMzcPAP1n1kNa6G m77TBO3AhSfhQoGKliaAJ7svEKlQA66L+QWNAs55L5L7u2CCJ4tNelpTgaaVA/15xjxd 3oEhcc+aX6wWlkGE/dowKGaZXVcQZl/Q0yDTaONI0oG3pt9y58r3ULsgQ+5buaImKkWl XRww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GgI6sNuIiEld/+iiG14XAnJiIn6TNY0eqR/C3vJoJeY=; b=5TR21smF4kg9o4WnbnSF71Ecl1juvXb3H8pHv93vAvFa3cT5T4iDmuqd0/hbfgO52n Y6PSeNhdmwBFICZY9IhOnes7gxHH6QM8oj4LZotFcwISCuWT5JF68vNt075aCyjjNWLt Jr+LLlMKXCoclYlR8FT7wD3gPDmZcelo4gF2Yzrokbgc/Zn+u9GX90OELMwNt3c2/hyK 7NWOuTn6Va/f8roD2hs3ZcP/3Ho5vwhKqDuw2iT3lCmsosQmWnhcLOMm41JWyjdKrOB6 iopmR1aUPuEDyQtDn1OjP2En6cGIPHq3fToYRA1YLPT+pR364PQB8HE4hKsj5bBttDZ4 j36Q== X-Gm-Message-State: ACgBeo0b3xw06i9fh39q10NdKPlOcrYBst+vgZIQi96wVaMZWfqpET5K bIMQmVSxxvaAspk9JeWUi29jpQJ0b1YhJg== X-Google-Smtp-Source: AA6agR68sMPLZnvoRAYJzhIZXXYbc7px+8AGg3MkpnSNS1rRV5tbRqx8eQJ54qUdZCi5CBrMSMEnzg== X-Received: by 2002:a05:6512:682:b0:49a:9db4:5a3f with SMTP id t2-20020a056512068200b0049a9db45a3fmr486649lfe.214.1662894769000; Sun, 11 Sep 2022 04:12:49 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:48 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 35/40] arm64: dts: qcom: sm6350: align TLMM pin configuration with DT schema Date: Sun, 11 Sep 2022 13:11:55 +0200 Message-Id: <20220911111200.199182-36-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qco= m/sm6350.dtsi index d882c29d53aa..c39de7d3ace0 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1314,49 +1314,49 @@ tlmm: pinctrl@f100000 { #interrupt-cells =3D <2>; gpio-ranges =3D <&tlmm 0 0 157>; =20 - qup_uart9_default: qup-uart9-default { + qup_uart9_default: qup-uart9-default-state { pins =3D "gpio25", "gpio26"; function =3D "qup13_f2"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c0_default: qup-i2c0-default { + qup_i2c0_default: qup-i2c0-default-state { pins =3D "gpio0", "gpio1"; function =3D "qup00"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c2_default: qup-i2c2-default { + qup_i2c2_default: qup-i2c2-default-state { pins =3D "gpio45", "gpio46"; function =3D "qup02"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c6_default: qup-i2c6-default { + qup_i2c6_default: qup-i2c6-default-state { pins =3D "gpio13", "gpio14"; function =3D "qup10"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c7_default: qup-i2c7-default { + qup_i2c7_default: qup-i2c7-default-state { pins =3D "gpio27", "gpio28"; function =3D "qup11"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c8_default: qup-i2c8-default { + qup_i2c8_default: qup-i2c8-default-state { pins =3D "gpio19", "gpio20"; function =3D "qup12"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c10_default: qup-i2c10-default { + qup_i2c10_default: qup-i2c10-default-state { pins =3D "gpio4", "gpio5"; function =3D "qup14"; drive-strength =3D <2>; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B09C0C6FA8A for ; Sun, 11 Sep 2022 11:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231335AbiIKLOz (ORCPT ); Sun, 11 Sep 2022 07:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231189AbiIKLOB (ORCPT ); Sun, 11 Sep 2022 07:14:01 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27D613DBC9 for ; Sun, 11 Sep 2022 04:12:50 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id bq23so10363241lfb.7 for ; Sun, 11 Sep 2022 04:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Hce0/X2M7TfP4RUEOJj4lD2o6WMQMhsp3Z9J0vMVmr8=; b=rZgTdAqItCFyZh63OZsdxrE0d4cx/dx4j5/jscohM/bFsQpG61a9lhL/umobyCPtMo 5JtqLG29ilQELBtL+xEt8Cxa344KdRb0RaKlxC8lc+H6zf0vV8WMtsKFhf1nXMlJvjqC v+3jAzWz8QrrRc1BbQ5nY7OCweszJ8j61sCa8xahZZGjX1uQZva/5swvL+g+L/01qYey TkIPOWM1xo49QHucPAN0YDTZcaO4SxrkgbGV0usIdS3R0vMrNXE9VczX7iNG7aJe/P2R cnHzA+7uGEN854QdTnxKMbjvqCo4itc5QUPdx048ormVxc4sFG3UOb4+63vWsb/I7Tm6 BalA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Hce0/X2M7TfP4RUEOJj4lD2o6WMQMhsp3Z9J0vMVmr8=; b=lUAKX09EfGi93CZo9kmzpbd9gcA3ZW849KMTLvP7ylTQN5fM5+0lKkb+1jDTmOi9GZ ACynShdAiwjT/3UAfY8pYG48AsDpjYhB2S1pGALGKzCACFVTChegmCTFuDjHTEx5JSPQ IPYH9z2TIO/Y7nX8zc0t1e6poGPy0Y7gSmHgUIdHWjTsxgVctp82WMRzCgg/fCDMxEEk u2QrIhaahUCLjPDDXFoHB1m0pE/d6+ZASo6YCmDAsqvPohiOB3mguIzdlLGzIf2Hgfz+ 8/ZGltDvIqnRBbAzr+2JqaAZXNDHuc8pxRMZ/1wvFrT2p166T4EXct0LQKfRYnHaWTMc 9LmA== X-Gm-Message-State: ACgBeo2uvShrWT+YD7J+FkXud7jmUwVxhDhODFgM9QSxR+MPdtl8pKZB Yfdg7xBQWW4xqo+XMAg2KkFhpQ== X-Google-Smtp-Source: AA6agR4p3BfpWezOw2hVfzNm1/m4P65C6K1bqFsghD91FNHniDAm2QB+BJljlpGRYewolA2YH+2MzQ== X-Received: by 2002:a05:6512:3090:b0:48b:6e1:1b55 with SMTP id z16-20020a056512309000b0048b06e11b55mr7862927lfd.535.1662894770276; Sun, 11 Sep 2022 04:12:50 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:49 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 36/40] arm64: dts: qcom: sm8350-sagami: correct TS pin property Date: Sun, 11 Sep 2022 13:11:56 +0200 Message-Id: <20220911111200.199182-37-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The pin configuration is selected with "pins", not "pin" property. Fixes: 1209e9246632 ("arm64: dts: qcom: sm8350-sagami: Enable and populate = I2C/SPI nodes") Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch= /arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi index cb9bbd234b7b..b702ab1605bb 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi @@ -223,7 +223,7 @@ &tlmm { gpio-reserved-ranges =3D <44 4>; =20 ts_int_default: ts-int-default { - pin =3D "gpio23"; + pins =3D "gpio23"; function =3D "gpio"; drive-strength =3D <2>; bias-disable; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D96ECAAA1 for ; Sun, 11 Sep 2022 11:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbiIKLPQ (ORCPT ); Sun, 11 Sep 2022 07:15:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbiIKLOH (ORCPT ); Sun, 11 Sep 2022 07:14:07 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3264932D8C for ; Sun, 11 Sep 2022 04:12:53 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id z23so7427914ljk.1 for ; Sun, 11 Sep 2022 04:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=CL2/j/JItz+3oLrNQS5aOSC401S6zfG+DX5xNbB/udc=; b=p1o0qlHK47licEeXcSEOxvdC4w42n+HpYsRejgOMH6KBJaR6EGFBYltiadanLkADDJ fOyHDuYa2rzgAju0CJJJnUiu0N1OOMfGfTqyuXoTNBhKjGUQ5Rk+X5u376iV1lq3f1yK po3VtgrOvazLMGEWoiVUujZUVnKlA+M/FzKjFtEUODnAROEvCwR763TNEh8BGkxgbRT1 CJSwwm2u6nnjaYbVl2jMTWrn0S5xTI26mH2kSk+njz49t/e5YNBzUBcNNCKgE/jbOoRB PuqvbBEMHG//ITtop2fV/EnHSJOhmNiAst62LOWmkEzZ0SNHX+i8di9ooYiBnLpRKzie L7sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=CL2/j/JItz+3oLrNQS5aOSC401S6zfG+DX5xNbB/udc=; b=v3yt4AmZO7sOlVbVKhpXBEL6UOAm1N3Q2xYnydDglnBu3xglt2Nyk41r6EjvZ0vxBe rVZupGyOlfOUjJ4t6y7yJzs5Oc8S4ftMIR6MkxGLFHtj+k7q/1ou9+5P0EjbLQo1P7JU NJ1VffrSozEOwf8vU+bZGNEwHS8egUrjNS8/rxzRSdO7d1CzXDXCFpy60VNMWU5xgd0K vMCWU8z5It2xDgHJ2FfX8DivUXzFG2LeUOUm368PH3P2YIgECUD7gOZfqG7X/PGqzHFk ZX9kg1cLyyNk/U1Z8qKM2gHKI/glX2A5/WkOtCSxN2aELE6aifHop/IjMsCcY2Nphhod pSMw== X-Gm-Message-State: ACgBeo17mkOGFAvD6UfYVsL+3vFew330WRflG7DADQVSrAziypy/IuEb vJAr6UDj6bX7S8KIuYTWGzm9ww== X-Google-Smtp-Source: AA6agR5kGSIUGOJg3pllHovdg/FAi8EeRBdF9haQMJlycsyu9wEzNRl6O0W6185/GX7SL5j9g9zBlQ== X-Received: by 2002:a05:651c:1a14:b0:26a:c8ca:7ed8 with SMTP id by20-20020a05651c1a1400b0026ac8ca7ed8mr6219435ljb.415.1662894772539; Sun, 11 Sep 2022 04:12:52 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:51 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 37/40] arm64: dts: qcom: sm8350: align TLMM pin configuration with DT schema Date: Sun, 11 Sep 2022 13:11:57 +0200 Message-Id: <20220911111200.199182-38-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../dts/qcom/sm8350-sony-xperia-sagami.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8350.dtsi | 44 +++++++++---------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch= /arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi index b702ab1605bb..b3c9952ac173 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi @@ -222,7 +222,7 @@ &spi14 { &tlmm { gpio-reserved-ranges =3D <44 4>; =20 - ts_int_default: ts-int-default { + ts_int_default: ts-int-default-state { pins =3D "gpio23"; function =3D "gpio"; drive-strength =3D <2>; diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qco= m/sm8350.dtsi index e72a04411888..cd5503642a23 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1762,150 +1762,150 @@ tlmm: pinctrl@f100000 { wakeup-parent =3D <&pdc>; =20 qup_uart3_default_state: qup-uart3-default-state { - rx { + rx-pins { pins =3D "gpio18"; function =3D "qup3"; }; - tx { + tx-pins { pins =3D "gpio19"; function =3D "qup3"; }; }; =20 - qup_uart6_default: qup-uart6-default { + qup_uart6_default: qup-uart6-default-state { pins =3D "gpio30", "gpio31"; function =3D "qup6"; drive-strength =3D <2>; bias-disable; }; =20 - qup_uart18_default: qup-uart18-default { + qup_uart18_default: qup-uart18-default-state { pins =3D "gpio58", "gpio59"; function =3D "qup18"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c0_default: qup-i2c0-default { + qup_i2c0_default: qup-i2c0-default-state { pins =3D "gpio4", "gpio5"; function =3D "qup0"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c1_default: qup-i2c1-default { + qup_i2c1_default: qup-i2c1-default-state { pins =3D "gpio8", "gpio9"; function =3D "qup1"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c2_default: qup-i2c2-default { + qup_i2c2_default: qup-i2c2-default-state { pins =3D "gpio12", "gpio13"; function =3D "qup2"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c4_default: qup-i2c4-default { + qup_i2c4_default: qup-i2c4-default-state { pins =3D "gpio20", "gpio21"; function =3D "qup4"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c5_default: qup-i2c5-default { + qup_i2c5_default: qup-i2c5-default-state { pins =3D "gpio24", "gpio25"; function =3D "qup5"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c6_default: qup-i2c6-default { + qup_i2c6_default: qup-i2c6-default-state { pins =3D "gpio28", "gpio29"; function =3D "qup6"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c7_default: qup-i2c7-default { + qup_i2c7_default: qup-i2c7-default-state { pins =3D "gpio32", "gpio33"; function =3D "qup7"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c8_default: qup-i2c8-default { + qup_i2c8_default: qup-i2c8-default-state { pins =3D "gpio36", "gpio37"; function =3D "qup8"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c9_default: qup-i2c9-default { + qup_i2c9_default: qup-i2c9-default-state { pins =3D "gpio40", "gpio41"; function =3D "qup9"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c10_default: qup-i2c10-default { + qup_i2c10_default: qup-i2c10-default-state { pins =3D "gpio44", "gpio45"; function =3D "qup10"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c11_default: qup-i2c11-default { + qup_i2c11_default: qup-i2c11-default-state { pins =3D "gpio48", "gpio49"; function =3D "qup11"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c12_default: qup-i2c12-default { + qup_i2c12_default: qup-i2c12-default-state { pins =3D "gpio52", "gpio53"; function =3D "qup12"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c13_default: qup-i2c13-default { + qup_i2c13_default: qup-i2c13-default-state { pins =3D "gpio0", "gpio1"; function =3D "qup13"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c14_default: qup-i2c14-default { + qup_i2c14_default: qup-i2c14-default-state { pins =3D "gpio56", "gpio57"; function =3D "qup14"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c15_default: qup-i2c15-default { + qup_i2c15_default: qup-i2c15-default-state { pins =3D "gpio60", "gpio61"; function =3D "qup15"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c16_default: qup-i2c16-default { + qup_i2c16_default: qup-i2c16-default-state { pins =3D "gpio64", "gpio65"; function =3D "qup16"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c17_default: qup-i2c17-default { + qup_i2c17_default: qup-i2c17-default-state { pins =3D "gpio72", "gpio73"; function =3D "qup17"; drive-strength =3D <2>; bias-disable; }; =20 - qup_i2c19_default: qup-i2c19-default { + qup_i2c19_default: qup-i2c19-default-state { pins =3D "gpio76", "gpio77"; function =3D "qup19"; drive-strength =3D <2>; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8095EC6FA83 for ; Sun, 11 Sep 2022 11:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbiIKLPI (ORCPT ); Sun, 11 Sep 2022 07:15:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbiIKLOD (ORCPT ); Sun, 11 Sep 2022 07:14:03 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC1653DBD4 for ; Sun, 11 Sep 2022 04:12:54 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id k10so10371044lfm.4 for ; Sun, 11 Sep 2022 04:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Agf1+UyJe+fVcEGMvuo1mvU0w0VboU6bQsb5wGtqwzo=; b=aZaft94OTXKGR48Ftyd2ImJwsd2fXk749YSYN9nASR7mDdKv6B+5s+s2sL79RBAFJb vnz+OQCH6Tw+9Mw84kGxM7dV9Dp+UmC+dKYfnLOeXFZY/F4+UKO/fsDCGAne9bB/18zu ipRefuwWenjKtA/4A0aMSDCi7zbIp3w0P9Wd0T/UTq6ED4QVmL3xfc8aW1iffyjhPt5t IG5WAaFMb0XzzuyQVUp9YkMEIeILMyssyw9/vFiLqCbGxT3ST+ih1wCFSMWY2Ni0oF1Y g8kdwMutP/kdmw/+R4HHPc2igH2je+oDmuIE21D1rCz8ucoZg2IkRh76M6N5snMl0f3N jEmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Agf1+UyJe+fVcEGMvuo1mvU0w0VboU6bQsb5wGtqwzo=; b=z6dWa6CIrUDEi61FTDNJMGVmzZiGU8fODGjjwY6NeDUfm5sSAQ20TH2TCRcdJPbMHg 7SF9FYbLAjQ+KnBFYf/nOvIWyr6iTru08CpZNy6lBme93wD7tW39H3aatCqcJjOMPDaJ ryJSCJOtv2EnWfRuVINXIjt20bO3kIfpSp9C9axGWBA7ijOpXeBY+ARVYTRlz0lzSzGk aFyoT6YgTfYhbwz2/tHqFDMLewmCVNVTD0ELu3crif2VDwYIckKhxCyfypDjaVEbjsGv 569PSc3m/0fcQKfO3aPYkcF/tWkrxmLucOwfB61t90aUqDrWJdNqZevD2PoQpnxMhI4/ vbSg== X-Gm-Message-State: ACgBeo3GlbUIQLdG3gPAuHuUMqzR9uqyGbynlknzw38d3uWYwGZ6G0Fo OwTB0G0YMHFHE+xqQsKOSz4gsg== X-Google-Smtp-Source: AA6agR5tueT9iwPpPMc1OjRz6CzT/EI9yxWuHOuYmwtPctXn2OGcpl4VV5ldunR354zl7wsOKD/53Q== X-Received: by 2002:a05:6512:6c8:b0:49a:1765:335d with SMTP id u8-20020a05651206c800b0049a1765335dmr948235lff.29.1662894773909; Sun, 11 Sep 2022 04:12:53 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:53 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 38/40] arm64: dts: qcom: sm8450: align TLMM pin configuration with DT schema Date: Sun, 11 Sep 2022 13:11:58 +0200 Message-Id: <20220911111200.199182-39-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../qcom/sm8450-sony-xperia-nagara-pdx223.dts | 12 +- arch/arm64/boot/dts/qcom/sm8450.dtsi | 152 +++++++++--------- 2 files changed, 82 insertions(+), 82 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts = b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts index 7fe582b92a61..d68765eb6d4f 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts @@ -572,27 +572,27 @@ &spi10 { &tlmm { gpio-reserved-ranges =3D <28 4>; =20 - sdc2_default_state: sdc2-default { - clk { + sdc2_default_state: sdc2-default-state { + clk-pins { pins =3D "sdc2_clk"; drive-strength =3D <16>; bias-disable; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; drive-strength =3D <16>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <16>; bias-pull-up; }; }; =20 - ts_int_default: ts-int-default { + ts_int_default: ts-int-default-state { pins =3D "gpio23"; function =3D "gpio"; drive-strength =3D <2>; @@ -600,7 +600,7 @@ ts_int_default: ts-int-default { input-enable; }; =20 - sdc2_card_det_n: sd-card-det-n { + sdc2_card_det_n: sd-card-det-n-state { pins =3D "gpio92"; function =3D "gpio"; drive-strength =3D <2>; diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index d0ebf61a0074..1d878256028f 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2384,20 +2384,20 @@ tlmm: pinctrl@f100000 { gpio-ranges =3D <&tlmm 0 0 211>; wakeup-parent =3D <&pdc>; =20 - sdc2_sleep_state: sdc2-sleep { - clk { + sdc2_sleep_state: sdc2-sleep-state { + clk-pins { pins =3D "sdc2_clk"; drive-strength =3D <2>; bias-disable; }; =20 - cmd { + cmd-pins { pins =3D "sdc2_cmd"; drive-strength =3D <2>; bias-pull-up; }; =20 - data { + data-pins { pins =3D "sdc2_data"; drive-strength =3D <2>; bias-pull-up; @@ -2405,21 +2405,21 @@ data { }; =20 pcie0_default_state: pcie0-default-state { - perst { + perst-pins { pins =3D "gpio94"; function =3D "gpio"; drive-strength =3D <2>; bias-pull-down; }; =20 - clkreq { + clkreq-pins { pins =3D "gpio95"; function =3D "pcie0_clkreqn"; drive-strength =3D <2>; bias-pull-up; }; =20 - wake { + wake-pins { pins =3D "gpio96"; function =3D "gpio"; drive-strength =3D <2>; @@ -2428,21 +2428,21 @@ wake { }; =20 pcie1_default_state: pcie1-default-state { - perst { + perst-pins { pins =3D "gpio97"; function =3D "gpio"; drive-strength =3D <2>; bias-pull-down; }; =20 - clkreq { + clkreq-pins { pins =3D "gpio98"; function =3D "pcie1_clkreqn"; drive-strength =3D <2>; bias-pull-up; }; =20 - wake { + wake-pins { pins =3D "gpio99"; function =3D "gpio"; drive-strength =3D <2>; @@ -2450,350 +2450,350 @@ wake { }; }; =20 - qup_i2c0_data_clk: qup-i2c0-data-clk { + qup_i2c0_data_clk: qup-i2c0-data-clk-state { pins =3D "gpio0", "gpio1"; function =3D "qup0"; }; =20 - qup_i2c1_data_clk: qup-i2c1-data-clk { + qup_i2c1_data_clk: qup-i2c1-data-clk-state { pins =3D "gpio4", "gpio5"; function =3D "qup1"; }; =20 - qup_i2c2_data_clk: qup-i2c2-data-clk { + qup_i2c2_data_clk: qup-i2c2-data-clk-state { pins =3D "gpio8", "gpio9"; function =3D "qup2"; }; =20 - qup_i2c3_data_clk: qup-i2c3-data-clk { + qup_i2c3_data_clk: qup-i2c3-data-clk-state { pins =3D "gpio12", "gpio13"; function =3D "qup3"; }; =20 - qup_i2c4_data_clk: qup-i2c4-data-clk { + qup_i2c4_data_clk: qup-i2c4-data-clk-state { pins =3D "gpio16", "gpio17"; function =3D "qup4"; }; =20 - qup_i2c5_data_clk: qup-i2c5-data-clk { + qup_i2c5_data_clk: qup-i2c5-data-clk-state { pins =3D "gpio206", "gpio207"; function =3D "qup5"; }; =20 - qup_i2c6_data_clk: qup-i2c6-data-clk { + qup_i2c6_data_clk: qup-i2c6-data-clk-state { pins =3D "gpio20", "gpio21"; function =3D "qup6"; }; =20 - qup_i2c8_data_clk: qup-i2c8-data-clk { + qup_i2c8_data_clk: qup-i2c8-data-clk-state { pins =3D "gpio28", "gpio29"; function =3D "qup8"; }; =20 - qup_i2c9_data_clk: qup-i2c9-data-clk { + qup_i2c9_data_clk: qup-i2c9-data-clk-state { pins =3D "gpio32", "gpio33"; function =3D "qup9"; }; =20 - qup_i2c10_data_clk: qup-i2c10-data-clk { + qup_i2c10_data_clk: qup-i2c10-data-clk-state { pins =3D "gpio36", "gpio37"; function =3D "qup10"; }; =20 - qup_i2c11_data_clk: qup-i2c11-data-clk { + qup_i2c11_data_clk: qup-i2c11-data-clk-state { pins =3D "gpio40", "gpio41"; function =3D "qup11"; }; =20 - qup_i2c12_data_clk: qup-i2c12-data-clk { + qup_i2c12_data_clk: qup-i2c12-data-clk-state { pins =3D "gpio44", "gpio45"; function =3D "qup12"; }; =20 - qup_i2c13_data_clk: qup-i2c13-data-clk { + qup_i2c13_data_clk: qup-i2c13-data-clk-state { pins =3D "gpio48", "gpio49"; function =3D "qup13"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c14_data_clk: qup-i2c14-data-clk { + qup_i2c14_data_clk: qup-i2c14-data-clk-state { pins =3D "gpio52", "gpio53"; function =3D "qup14"; drive-strength =3D <2>; bias-pull-up; }; =20 - qup_i2c15_data_clk: qup-i2c15-data-clk { + qup_i2c15_data_clk: qup-i2c15-data-clk-state { pins =3D "gpio56", "gpio57"; function =3D "qup15"; }; =20 - qup_i2c16_data_clk: qup-i2c16-data-clk { + qup_i2c16_data_clk: qup-i2c16-data-clk-state { pins =3D "gpio60", "gpio61"; function =3D "qup16"; }; =20 - qup_i2c17_data_clk: qup-i2c17-data-clk { + qup_i2c17_data_clk: qup-i2c17-data-clk-state { pins =3D "gpio64", "gpio65"; function =3D "qup17"; }; =20 - qup_i2c18_data_clk: qup-i2c18-data-clk { + qup_i2c18_data_clk: qup-i2c18-data-clk-state { pins =3D "gpio68", "gpio69"; function =3D "qup18"; }; =20 - qup_i2c19_data_clk: qup-i2c19-data-clk { + qup_i2c19_data_clk: qup-i2c19-data-clk-state { pins =3D "gpio72", "gpio73"; function =3D "qup19"; }; =20 - qup_i2c20_data_clk: qup-i2c20-data-clk { + qup_i2c20_data_clk: qup-i2c20-data-clk-state { pins =3D "gpio76", "gpio77"; function =3D "qup20"; }; =20 - qup_i2c21_data_clk: qup-i2c21-data-clk { + qup_i2c21_data_clk: qup-i2c21-data-clk-state { pins =3D "gpio80", "gpio81"; function =3D "qup21"; }; =20 - qup_spi0_cs: qup-spi0-cs { + qup_spi0_cs: qup-spi0-cs-state { pins =3D "gpio3"; function =3D "qup0"; }; =20 - qup_spi0_data_clk: qup-spi0-data-clk { + qup_spi0_data_clk: qup-spi0-data-clk-state { pins =3D "gpio0", "gpio1", "gpio2"; function =3D "qup0"; }; =20 - qup_spi1_cs: qup-spi1-cs { + qup_spi1_cs: qup-spi1-cs-state { pins =3D "gpio7"; function =3D "qup1"; }; =20 - qup_spi1_data_clk: qup-spi1-data-clk { + qup_spi1_data_clk: qup-spi1-data-clk-state { pins =3D "gpio4", "gpio5", "gpio6"; function =3D "qup1"; }; =20 - qup_spi2_cs: qup-spi2-cs { + qup_spi2_cs: qup-spi2-cs-state { pins =3D "gpio11"; function =3D "qup2"; }; =20 - qup_spi2_data_clk: qup-spi2-data-clk { + qup_spi2_data_clk: qup-spi2-data-clk-state { pins =3D "gpio8", "gpio9", "gpio10"; function =3D "qup2"; }; =20 - qup_spi3_cs: qup-spi3-cs { + qup_spi3_cs: qup-spi3-cs-state { pins =3D "gpio15"; function =3D "qup3"; }; =20 - qup_spi3_data_clk: qup-spi3-data-clk { + qup_spi3_data_clk: qup-spi3-data-clk-state { pins =3D "gpio12", "gpio13", "gpio14"; function =3D "qup3"; }; =20 - qup_spi4_cs: qup-spi4-cs { + qup_spi4_cs: qup-spi4-cs-state { pins =3D "gpio19"; function =3D "qup4"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi4_data_clk: qup-spi4-data-clk { + qup_spi4_data_clk: qup-spi4-data-clk-state { pins =3D "gpio16", "gpio17", "gpio18"; function =3D "qup4"; }; =20 - qup_spi5_cs: qup-spi5-cs { + qup_spi5_cs: qup-spi5-cs-state { pins =3D "gpio85"; function =3D "qup5"; }; =20 - qup_spi5_data_clk: qup-spi5-data-clk { + qup_spi5_data_clk: qup-spi5-data-clk-state { pins =3D "gpio206", "gpio207", "gpio84"; function =3D "qup5"; }; =20 - qup_spi6_cs: qup-spi6-cs { + qup_spi6_cs: qup-spi6-cs-state { pins =3D "gpio23"; function =3D "qup6"; }; =20 - qup_spi6_data_clk: qup-spi6-data-clk { + qup_spi6_data_clk: qup-spi6-data-clk-state { pins =3D "gpio20", "gpio21", "gpio22"; function =3D "qup6"; }; =20 - qup_spi8_cs: qup-spi8-cs { + qup_spi8_cs: qup-spi8-cs-state { pins =3D "gpio31"; function =3D "qup8"; }; =20 - qup_spi8_data_clk: qup-spi8-data-clk { + qup_spi8_data_clk: qup-spi8-data-clk-state { pins =3D "gpio28", "gpio29", "gpio30"; function =3D "qup8"; }; =20 - qup_spi9_cs: qup-spi9-cs { + qup_spi9_cs: qup-spi9-cs-state { pins =3D "gpio35"; function =3D "qup9"; }; =20 - qup_spi9_data_clk: qup-spi9-data-clk { + qup_spi9_data_clk: qup-spi9-data-clk-state { pins =3D "gpio32", "gpio33", "gpio34"; function =3D "qup9"; }; =20 - qup_spi10_cs: qup-spi10-cs { + qup_spi10_cs: qup-spi10-cs-state { pins =3D "gpio39"; function =3D "qup10"; }; =20 - qup_spi10_data_clk: qup-spi10-data-clk { + qup_spi10_data_clk: qup-spi10-data-clk-state { pins =3D "gpio36", "gpio37", "gpio38"; function =3D "qup10"; }; =20 - qup_spi11_cs: qup-spi11-cs { + qup_spi11_cs: qup-spi11-cs-state { pins =3D "gpio43"; function =3D "qup11"; }; =20 - qup_spi11_data_clk: qup-spi11-data-clk { + qup_spi11_data_clk: qup-spi11-data-clk-state { pins =3D "gpio40", "gpio41", "gpio42"; function =3D "qup11"; }; =20 - qup_spi12_cs: qup-spi12-cs { + qup_spi12_cs: qup-spi12-cs-state { pins =3D "gpio47"; function =3D "qup12"; }; =20 - qup_spi12_data_clk: qup-spi12-data-clk { + qup_spi12_data_clk: qup-spi12-data-clk-state { pins =3D "gpio44", "gpio45", "gpio46"; function =3D "qup12"; }; =20 - qup_spi13_cs: qup-spi13-cs { + qup_spi13_cs: qup-spi13-cs-state { pins =3D "gpio51"; function =3D "qup13"; }; =20 - qup_spi13_data_clk: qup-spi13-data-clk { + qup_spi13_data_clk: qup-spi13-data-clk-state { pins =3D "gpio48", "gpio49", "gpio50"; function =3D "qup13"; }; =20 - qup_spi14_cs: qup-spi14-cs { + qup_spi14_cs: qup-spi14-cs-state { pins =3D "gpio55"; function =3D "qup14"; }; =20 - qup_spi14_data_clk: qup-spi14-data-clk { + qup_spi14_data_clk: qup-spi14-data-clk-state { pins =3D "gpio52", "gpio53", "gpio54"; function =3D "qup14"; }; =20 - qup_spi15_cs: qup-spi15-cs { + qup_spi15_cs: qup-spi15-cs-state { pins =3D "gpio59"; function =3D "qup15"; }; =20 - qup_spi15_data_clk: qup-spi15-data-clk { + qup_spi15_data_clk: qup-spi15-data-clk-state { pins =3D "gpio56", "gpio57", "gpio58"; function =3D "qup15"; }; =20 - qup_spi16_cs: qup-spi16-cs { + qup_spi16_cs: qup-spi16-cs-state { pins =3D "gpio63"; function =3D "qup16"; }; =20 - qup_spi16_data_clk: qup-spi16-data-clk { + qup_spi16_data_clk: qup-spi16-data-clk-state { pins =3D "gpio60", "gpio61", "gpio62"; function =3D "qup16"; }; =20 - qup_spi17_cs: qup-spi17-cs { + qup_spi17_cs: qup-spi17-cs-state { pins =3D "gpio67"; function =3D "qup17"; }; =20 - qup_spi17_data_clk: qup-spi17-data-clk { + qup_spi17_data_clk: qup-spi17-data-clk-state { pins =3D "gpio64", "gpio65", "gpio66"; function =3D "qup17"; }; =20 - qup_spi18_cs: qup-spi18-cs { + qup_spi18_cs: qup-spi18-cs-state { pins =3D "gpio71"; function =3D "qup18"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi18_data_clk: qup-spi18-data-clk { + qup_spi18_data_clk: qup-spi18-data-clk-state { pins =3D "gpio68", "gpio69", "gpio70"; function =3D "qup18"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi19_cs: qup-spi19-cs { + qup_spi19_cs: qup-spi19-cs-state { pins =3D "gpio75"; function =3D "qup19"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi19_data_clk: qup-spi19-data-clk { + qup_spi19_data_clk: qup-spi19-data-clk-state { pins =3D "gpio72", "gpio73", "gpio74"; function =3D "qup19"; drive-strength =3D <6>; bias-disable; }; =20 - qup_spi20_cs: qup-spi20-cs { + qup_spi20_cs: qup-spi20-cs-state { pins =3D "gpio79"; function =3D "qup20"; }; =20 - qup_spi20_data_clk: qup-spi20-data-clk { + qup_spi20_data_clk: qup-spi20-data-clk-state { pins =3D "gpio76", "gpio77", "gpio78"; function =3D "qup20"; }; =20 - qup_spi21_cs: qup-spi21-cs { + qup_spi21_cs: qup-spi21-cs-state { pins =3D "gpio83"; function =3D "qup21"; }; =20 - qup_spi21_data_clk: qup-spi21-data-clk { + qup_spi21_data_clk: qup-spi21-data-clk-state { pins =3D "gpio80", "gpio81", "gpio82"; function =3D "qup21"; }; =20 - qup_uart7_rx: qup-uart7-rx { + qup_uart7_rx: qup-uart7-rx-state { pins =3D "gpio26"; function =3D "qup7"; drive-strength =3D <2>; bias-disable; }; =20 - qup_uart7_tx: qup-uart7-tx { + qup_uart7_tx: qup-uart7-tx-state { pins =3D "gpio27"; function =3D "qup7"; drive-strength =3D <2>; bias-disable; }; =20 - qup_uart20_default: qup-uart20-default { + qup_uart20_default: qup-uart20-default-state { pins =3D "gpio76", "gpio77", "gpio78", "gpio79"; function =3D "qup20"; }; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB9FC6FA83 for ; Sun, 11 Sep 2022 11:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231376AbiIKLPd (ORCPT ); Sun, 11 Sep 2022 07:15:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231223AbiIKLOU (ORCPT ); Sun, 11 Sep 2022 07:14:20 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2C4E3DBE4 for ; Sun, 11 Sep 2022 04:12:55 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id z20so7409386ljq.3 for ; Sun, 11 Sep 2022 04:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=kCmef+I4ubqqGDCcAcc+6D54ls+qXxrTz9AD5rjIgz8=; b=ex0a+jyQOnRAtTKr/Yc98Qi+peFlDEDUqi0LYoRmKI3gQrWplXKlOrfZu2mm26DpRM JQXtyEc5QIOPKKa9L6V3HwzX5ERU2jULMb24Z28blRR5HoTmrDInTuXQrMknRxc6I5fy nV5/fIegvqHbeIl9fDJZQqSghRZg2YwBSHi7VeFTBMdN9S8SbWFbtccvXh+tBAjxZ06M eSNcL1jJ8NacGGZrnpTYNZeNLg+zPlIgxsK+eY4m8ffHLqi4SI6vE+xt+3sYnGAP38pr cziFsLH+iemHBQWfQfxcfRUPWnbRdhc7CRPEm4uHKNKG1VeiYKlccBaHgr3GbYV/FFKO POGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=kCmef+I4ubqqGDCcAcc+6D54ls+qXxrTz9AD5rjIgz8=; b=RjY1J8tpx8DFt6yMzqwNYQgYoatLs4VFs4Xrj4oNec7Bo++c0aJBE2vvc95tTukR/W hRUs7d1lqX+ml7kk8+cl016zq0PjVHAyUp9Kd0PiDK++mrNL85SUFqGTc4YRwi2/iGez Bli0D3OK/IWe2SqWRgf5byBKcVm2KNaGQ1ocqdtCIWAhBIzzHZTW2M9mA+2HAEJyiQvY rmwrHCoi9p4xL/fRWHXgca2Wj56jA0nmVsDicDLHmPVvxu367LrJX39pmymQLYE8wVEw lC9BeTPBxaLtDxA+VmxNjdhGHsibjrV18zK5H2y7qhiW5+KmqNvm9Bgzm0/Z1VH5RNbd xTSQ== X-Gm-Message-State: ACgBeo0pNfQ+oEw6tPvViC4yE9r6h+Azb8E3R8DxtkY2frskUwlQqGsn wNzOSjLTbPZJjXPVh0nNNwoJgA== X-Google-Smtp-Source: AA6agR6oCocBmlshXl3+ShRbzz/pY6YzTrXsZ7zZIyvEWnhzU8ytO7FM9xltMQLc40NvlarFUzMN8Q== X-Received: by 2002:a05:651c:114a:b0:25d:5ae6:42a4 with SMTP id h10-20020a05651c114a00b0025d5ae642a4mr6308479ljo.255.1662894775159; Sun, 11 Sep 2022 04:12:55 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:54 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 39/40] arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema Date: Sun, 11 Sep 2022 13:11:59 +0200 Message-Id: <20220911111200.199182-40-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 44 +-- .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 8 +- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 20 +- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 14 +- arch/arm64/boot/dts/qcom/sc7280.dtsi | 316 +++++++++--------- 5 files changed, 201 insertions(+), 201 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-herobrine.dtsi index 45f6a1e1002e..82307722222a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -717,27 +717,27 @@ &tlmm { pinctrl-names =3D "default"; pinctrl-0 =3D <&bios_flash_wp_od>; =20 - amp_en: amp-en { + amp_en: amp-en-pins { pins =3D "gpio63"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - ap_ec_int_l: ap-ec-int-l { + ap_ec_int_l: ap-ec-int-l-pins { pins =3D "gpio18"; function =3D "gpio"; bias-pull-up; }; =20 - bios_flash_wp_od: bios-flash-wp-od { + bios_flash_wp_od: bios-flash-wp-od-pins { pins =3D "gpio16"; function =3D "gpio"; /* Has external pull */ bias-disable; }; =20 - en_fp_rails: en-fp-rails { + en_fp_rails: en-fp-rails-pins { pins =3D "gpio77"; function =3D "gpio"; bias-disable; @@ -745,60 +745,60 @@ en_fp_rails: en-fp-rails { output-high; }; =20 - en_pp3300_codec: en-pp3300-codec { + en_pp3300_codec: en-pp3300-codec-pins { pins =3D "gpio105"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - en_pp3300_dx_edp: en-pp3300-dx-edp { + en_pp3300_dx_edp: en-pp3300-dx-edp-pins { pins =3D "gpio80"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - fp_rst_l: fp-rst-l { + fp_rst_l: fp-rst-l-pins { pins =3D "gpio78"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - fp_to_ap_irq_l: fp-to-ap-irq-l { + fp_to_ap_irq_l: fp-to-ap-irq-l-pins { pins =3D "gpio61"; function =3D "gpio"; /* Has external pullup */ bias-disable; }; =20 - fpmcu_boot0: fpmcu-boot0 { + fpmcu_boot0: fpmcu-boot0-pins { pins =3D "gpio68"; function =3D "gpio"; bias-disable; }; =20 - gsc_ap_int_odl: gsc-ap-int-odl { + gsc_ap_int_odl: gsc-ap-int-odl-pins { pins =3D "gpio104"; function =3D "gpio"; bias-pull-up; }; =20 - hp_irq: hp-irq { + hp_irq: hp-irq-pins { pins =3D "gpio101"; function =3D "gpio"; bias-pull-up; }; =20 - hub_en: hub-en { + hub_en: hub-en-pins { pins =3D "gpio157"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - pe_wake_odl: pe-wake-odl { + pe_wake_odl: pe-wake-odl-pins { pins =3D "gpio3"; function =3D "gpio"; /* Has external pull */ @@ -807,45 +807,45 @@ pe_wake_odl: pe-wake-odl { }; =20 /* For ap_spi_fp */ - qup_spi9_cs_gpio_init_high: qup-spi9-cs-gpio-init-high { + qup_spi9_cs_gpio_init_high: qup-spi9-cs-gpio-init-high-pins { pins =3D "gpio39"; function =3D "gpio"; output-high; }; =20 /* For ap_ec_spi */ - qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high { + qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high-pins { pins =3D "gpio43"; function =3D "gpio"; output-high; }; =20 - sar0_irq_odl: sar0-irq-odl { + sar0_irq_odl: sar0-irq-odl-pins { pins =3D "gpio141"; function =3D "gpio"; bias-pull-up; }; =20 - sar1_irq_odl: sar1-irq-odl { + sar1_irq_odl: sar1-irq-odl-pins { pins =3D "gpio140"; function =3D "gpio"; bias-pull-up; }; =20 - sd_cd_odl: sd-cd-odl { + sd_cd_odl: sd-cd-odl-pins { pins =3D "gpio91"; function =3D "gpio"; bias-pull-up; }; =20 - ssd_en: ssd-en { + ssd_en: ssd-en-pins { pins =3D "gpio51"; function =3D "gpio"; bias-disable; drive-strength =3D <2>; }; =20 - ssd_rst_l: ssd-rst-l { + ssd_rst_l: ssd-rst-l-pins { pins =3D "gpio2"; function =3D "gpio"; bias-disable; @@ -853,14 +853,14 @@ ssd_rst_l: ssd-rst-l { output-low; }; =20 - tp_int_odl: tp-int-odl { + tp_int_odl: tp-int-odl-pins { pins =3D "gpio7"; function =3D "gpio"; /* Has external pullup */ bias-disable; }; =20 - wf_cam_en: wf-cam-en { + wf_cam_en: wf-cam-en-pins { pins =3D "gpio119"; function =3D "gpio"; /* Has external pulldown */ diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-idp-ec-h1.dtsi index a7c346aa3b02..7f5143e9bb80 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi @@ -79,26 +79,26 @@ cr50: tpm@0 { }; =20 &tlmm { - ap_ec_int_l: ap-ec-int-l { + ap_ec_int_l: ap-ec-int-l-pins { pins =3D "gpio18"; function =3D "gpio"; input-enable; bias-pull-up; }; =20 - h1_ap_int_odl: h1-ap-int-odl { + h1_ap_int_odl: h1-ap-int-odl-pins { pins =3D "gpio104"; function =3D "gpio"; input-enable; bias-pull-up; }; =20 - qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high { + qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high-pins { pins =3D "gpio43"; output-high; }; =20 - qup_spi14_cs_gpio_init_high: qup-spi14-cs-gpio-init-high { + qup_spi14_cs_gpio_init_high: qup-spi14-cs-gpio-init-high-pins { pins =3D "gpio59"; output-high; }; diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts= /qcom/sc7280-idp.dtsi index 0c48db69e1ef..89ecf0d25a12 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -550,18 +550,18 @@ &sdc2_data { }; =20 &tlmm { - bt_en: bt-en { + bt_en: bt-en-pins { pins =3D "gpio85"; function =3D "gpio"; output-low; bias-disable; }; =20 - nvme_pwren: nvme-pwren { + nvme_pwren: nvme-pwren-pins { function =3D "gpio"; }; =20 - pcie1_reset_n: pcie1-reset-n { + pcie1_reset_n: pcie1-reset-n-pins { pins =3D "gpio2"; function =3D "gpio"; =20 @@ -570,7 +570,7 @@ pcie1_reset_n: pcie1-reset-n { bias-disable; }; =20 - pcie1_wake_n: pcie1-wake-n { + pcie1_wake_n: pcie1-wake-n-pins { pins =3D "gpio3"; function =3D "gpio"; =20 @@ -578,7 +578,7 @@ pcie1_wake_n: pcie1-wake-n { bias-pull-up; }; =20 - qup_uart7_sleep_cts: qup-uart7-sleep-cts { + qup_uart7_sleep_cts: qup-uart7-sleep-cts-pins { pins =3D "gpio28"; function =3D "gpio"; /* @@ -591,7 +591,7 @@ qup_uart7_sleep_cts: qup-uart7-sleep-cts { bias-bus-hold; }; =20 - qup_uart7_sleep_rts: qup-uart7-sleep-rts { + qup_uart7_sleep_rts: qup-uart7-sleep-rts-pins { pins =3D "gpio29"; function =3D "gpio"; /* @@ -603,7 +603,7 @@ qup_uart7_sleep_rts: qup-uart7-sleep-rts { bias-pull-down; }; =20 - qup_uart7_sleep_tx: qup-uart7-sleep-tx { + qup_uart7_sleep_tx: qup-uart7-sleep-tx-pins { pins =3D "gpio30"; function =3D "gpio"; /* @@ -613,7 +613,7 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx { bias-pull-up; }; =20 - qup_uart7_sleep_rx: qup-uart7-sleep-rx { + qup_uart7_sleep_rx: qup-uart7-sleep-rx-pins { pins =3D "gpio31"; function =3D "gpio"; /* @@ -624,13 +624,13 @@ qup_uart7_sleep_rx: qup-uart7-sleep-rx { bias-pull-up; }; =20 - sd_cd: sd-cd { + sd_cd: sd-cd-pins { pins =3D "gpio91"; function =3D "gpio"; bias-pull-up; }; =20 - sw_ctrl: sw-ctrl { + sw_ctrl: sw-ctrl-pins { pins =3D "gpio86"; function =3D "gpio"; bias-pull-down; diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/d= ts/qcom/sc7280-qcard.dtsi index 7cd91df7a118..0b56aecf857b 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -542,7 +542,7 @@ pmic_edp_bl_pwm: pmic-edp-bl-pwm-state { }; =20 &tlmm { - mos_bt_en: mos-bt-en { + mos_bt_en: mos-bt-en-pins { pins =3D "gpio85"; function =3D "gpio"; drive-strength =3D <2>; @@ -550,7 +550,7 @@ mos_bt_en: mos-bt-en { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_cts: qup-uart7-sleep-cts { + qup_uart7_sleep_cts: qup-uart7-sleep-cts-pins { pins =3D "gpio28"; function =3D "gpio"; /* @@ -564,7 +564,7 @@ qup_uart7_sleep_cts: qup-uart7-sleep-cts { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_rts: qup-uart7-sleep-rts { + qup_uart7_sleep_rts: qup-uart7-sleep-rts-pins { pins =3D "gpio29"; function =3D "gpio"; /* @@ -577,7 +577,7 @@ qup_uart7_sleep_rts: qup-uart7-sleep-rts { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_rx: qup-uart7-sleep-rx { + qup_uart7_sleep_rx: qup-uart7-sleep-rx-pins { pins =3D "gpio31"; function =3D "gpio"; /* @@ -589,7 +589,7 @@ qup_uart7_sleep_rx: qup-uart7-sleep-rx { }; =20 /* For mos_bt_uart */ - qup_uart7_sleep_tx: qup-uart7-sleep-tx { + qup_uart7_sleep_tx: qup-uart7-sleep-tx-pins { pins =3D "gpio30"; function =3D "gpio"; /* @@ -599,13 +599,13 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx { bias-pull-up; }; =20 - ts_int_conn: ts-int-conn { + ts_int_conn: ts-int-conn-pins { pins =3D "gpio55"; function =3D "gpio"; bias-pull-up; }; =20 - ts_rst_conn: ts-rst-conn { + ts_rst_conn: ts-rst-conn-pins { pins =3D "gpio54"; function =3D "gpio"; drive-strength =3D <2>; diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qco= m/sc7280.dtsi index ad04025a8a1a..07fa3e417a96 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4061,791 +4061,791 @@ tlmm: pinctrl@f100000 { gpio-ranges =3D <&tlmm 0 0 175>; wakeup-parent =3D <&pdc>; =20 - dp_hot_plug_det: dp-hot-plug-det { + dp_hot_plug_det: dp-hot-plug-det-pins { pins =3D "gpio47"; function =3D "dp_hot"; }; =20 - edp_hot_plug_det: edp-hot-plug-det { + edp_hot_plug_det: edp-hot-plug-det-pins { pins =3D "gpio60"; function =3D "edp_hot"; }; =20 - mi2s0_data0: mi2s0-data0 { + mi2s0_data0: mi2s0-data0-pins { pins =3D "gpio98"; function =3D "mi2s0_data0"; }; =20 - mi2s0_data1: mi2s0-data1 { + mi2s0_data1: mi2s0-data1-pins { pins =3D "gpio99"; function =3D "mi2s0_data1"; }; =20 - mi2s0_mclk: mi2s0-mclk { + mi2s0_mclk: mi2s0-mclk-pins { pins =3D "gpio96"; function =3D "pri_mi2s"; }; =20 - mi2s0_sclk: mi2s0-sclk { + mi2s0_sclk: mi2s0-sclk-pins { pins =3D "gpio97"; function =3D "mi2s0_sck"; }; =20 - mi2s0_ws: mi2s0-ws { + mi2s0_ws: mi2s0-ws-pins { pins =3D "gpio100"; function =3D "mi2s0_ws"; }; =20 - mi2s1_data0: mi2s1-data0 { + mi2s1_data0: mi2s1-data0-pins { pins =3D "gpio107"; function =3D "mi2s1_data0"; }; =20 - mi2s1_sclk: mi2s1-sclk { + mi2s1_sclk: mi2s1-sclk-pins { pins =3D "gpio106"; function =3D "mi2s1_sck"; }; =20 - mi2s1_ws: mi2s1-ws { + mi2s1_ws: mi2s1-ws-pins { pins =3D "gpio108"; function =3D "mi2s1_ws"; }; =20 - pcie1_clkreq_n: pcie1-clkreq-n { + pcie1_clkreq_n: pcie1-clkreq-n-pins { pins =3D "gpio79"; function =3D "pcie1_clkreqn"; }; =20 - qspi_clk: qspi-clk { + qspi_clk: qspi-clk-pins { pins =3D "gpio14"; function =3D "qspi_clk"; }; =20 - qspi_cs0: qspi-cs0 { + qspi_cs0: qspi-cs0-pins { pins =3D "gpio15"; function =3D "qspi_cs"; }; =20 - qspi_cs1: qspi-cs1 { + qspi_cs1: qspi-cs1-pins { pins =3D "gpio19"; function =3D "qspi_cs"; }; =20 - qspi_data01: qspi-data01 { + qspi_data01: qspi-data01-pins { pins =3D "gpio12", "gpio13"; function =3D "qspi_data"; }; =20 - qspi_data12: qspi-data12 { + qspi_data12: qspi-data12-pins { pins =3D "gpio16", "gpio17"; function =3D "qspi_data"; }; =20 - qup_i2c0_data_clk: qup-i2c0-data-clk { + qup_i2c0_data_clk: qup-i2c0-data-clk-pins { pins =3D "gpio0", "gpio1"; function =3D "qup00"; }; =20 - qup_i2c1_data_clk: qup-i2c1-data-clk { + qup_i2c1_data_clk: qup-i2c1-data-clk-pins { pins =3D "gpio4", "gpio5"; function =3D "qup01"; }; =20 - qup_i2c2_data_clk: qup-i2c2-data-clk { + qup_i2c2_data_clk: qup-i2c2-data-clk-pins { pins =3D "gpio8", "gpio9"; function =3D "qup02"; }; =20 - qup_i2c3_data_clk: qup-i2c3-data-clk { + qup_i2c3_data_clk: qup-i2c3-data-clk-pins { pins =3D "gpio12", "gpio13"; function =3D "qup03"; }; =20 - qup_i2c4_data_clk: qup-i2c4-data-clk { + qup_i2c4_data_clk: qup-i2c4-data-clk-pins { pins =3D "gpio16", "gpio17"; function =3D "qup04"; }; =20 - qup_i2c5_data_clk: qup-i2c5-data-clk { + qup_i2c5_data_clk: qup-i2c5-data-clk-pins { pins =3D "gpio20", "gpio21"; function =3D "qup05"; }; =20 - qup_i2c6_data_clk: qup-i2c6-data-clk { + qup_i2c6_data_clk: qup-i2c6-data-clk-pins { pins =3D "gpio24", "gpio25"; function =3D "qup06"; }; =20 - qup_i2c7_data_clk: qup-i2c7-data-clk { + qup_i2c7_data_clk: qup-i2c7-data-clk-pins { pins =3D "gpio28", "gpio29"; function =3D "qup07"; }; =20 - qup_i2c8_data_clk: qup-i2c8-data-clk { + qup_i2c8_data_clk: qup-i2c8-data-clk-pins { pins =3D "gpio32", "gpio33"; function =3D "qup10"; }; =20 - qup_i2c9_data_clk: qup-i2c9-data-clk { + qup_i2c9_data_clk: qup-i2c9-data-clk-pins { pins =3D "gpio36", "gpio37"; function =3D "qup11"; }; =20 - qup_i2c10_data_clk: qup-i2c10-data-clk { + qup_i2c10_data_clk: qup-i2c10-data-clk-pins { pins =3D "gpio40", "gpio41"; function =3D "qup12"; }; =20 - qup_i2c11_data_clk: qup-i2c11-data-clk { + qup_i2c11_data_clk: qup-i2c11-data-clk-pins { pins =3D "gpio44", "gpio45"; function =3D "qup13"; }; =20 - qup_i2c12_data_clk: qup-i2c12-data-clk { + qup_i2c12_data_clk: qup-i2c12-data-clk-pins { pins =3D "gpio48", "gpio49"; function =3D "qup14"; }; =20 - qup_i2c13_data_clk: qup-i2c13-data-clk { + qup_i2c13_data_clk: qup-i2c13-data-clk-pins { pins =3D "gpio52", "gpio53"; function =3D "qup15"; }; =20 - qup_i2c14_data_clk: qup-i2c14-data-clk { + qup_i2c14_data_clk: qup-i2c14-data-clk-pins { pins =3D "gpio56", "gpio57"; function =3D "qup16"; }; =20 - qup_i2c15_data_clk: qup-i2c15-data-clk { + qup_i2c15_data_clk: qup-i2c15-data-clk-pins { pins =3D "gpio60", "gpio61"; function =3D "qup17"; }; =20 - qup_spi0_data_clk: qup-spi0-data-clk { + qup_spi0_data_clk: qup-spi0-data-clk-pins { pins =3D "gpio0", "gpio1", "gpio2"; function =3D "qup00"; }; =20 - qup_spi0_cs: qup-spi0-cs { + qup_spi0_cs: qup-spi0-cs-pins { pins =3D "gpio3"; function =3D "qup00"; }; =20 - qup_spi0_cs_gpio: qup-spi0-cs-gpio { + qup_spi0_cs_gpio: qup-spi0-cs-gpio-pins { pins =3D "gpio3"; function =3D "gpio"; }; =20 - qup_spi1_data_clk: qup-spi1-data-clk { + qup_spi1_data_clk: qup-spi1-data-clk-pins { pins =3D "gpio4", "gpio5", "gpio6"; function =3D "qup01"; }; =20 - qup_spi1_cs: qup-spi1-cs { + qup_spi1_cs: qup-spi1-cs-pins { pins =3D "gpio7"; function =3D "qup01"; }; =20 - qup_spi1_cs_gpio: qup-spi1-cs-gpio { + qup_spi1_cs_gpio: qup-spi1-cs-gpio-pins { pins =3D "gpio7"; function =3D "gpio"; }; =20 - qup_spi2_data_clk: qup-spi2-data-clk { + qup_spi2_data_clk: qup-spi2-data-clk-pins { pins =3D "gpio8", "gpio9", "gpio10"; function =3D "qup02"; }; =20 - qup_spi2_cs: qup-spi2-cs { + qup_spi2_cs: qup-spi2-cs-pins { pins =3D "gpio11"; function =3D "qup02"; }; =20 - qup_spi2_cs_gpio: qup-spi2-cs-gpio { + qup_spi2_cs_gpio: qup-spi2-cs-gpio-pins { pins =3D "gpio11"; function =3D "gpio"; }; =20 - qup_spi3_data_clk: qup-spi3-data-clk { + qup_spi3_data_clk: qup-spi3-data-clk-pins { pins =3D "gpio12", "gpio13", "gpio14"; function =3D "qup03"; }; =20 - qup_spi3_cs: qup-spi3-cs { + qup_spi3_cs: qup-spi3-cs-pins { pins =3D "gpio15"; function =3D "qup03"; }; =20 - qup_spi3_cs_gpio: qup-spi3-cs-gpio { + qup_spi3_cs_gpio: qup-spi3-cs-gpio-pins { pins =3D "gpio15"; function =3D "gpio"; }; =20 - qup_spi4_data_clk: qup-spi4-data-clk { + qup_spi4_data_clk: qup-spi4-data-clk-pins { pins =3D "gpio16", "gpio17", "gpio18"; function =3D "qup04"; }; =20 - qup_spi4_cs: qup-spi4-cs { + qup_spi4_cs: qup-spi4-cs-pins { pins =3D "gpio19"; function =3D "qup04"; }; =20 - qup_spi4_cs_gpio: qup-spi4-cs-gpio { + qup_spi4_cs_gpio: qup-spi4-cs-gpio-pins { pins =3D "gpio19"; function =3D "gpio"; }; =20 - qup_spi5_data_clk: qup-spi5-data-clk { + qup_spi5_data_clk: qup-spi5-data-clk-pins { pins =3D "gpio20", "gpio21", "gpio22"; function =3D "qup05"; }; =20 - qup_spi5_cs: qup-spi5-cs { + qup_spi5_cs: qup-spi5-cs-pins { pins =3D "gpio23"; function =3D "qup05"; }; =20 - qup_spi5_cs_gpio: qup-spi5-cs-gpio { + qup_spi5_cs_gpio: qup-spi5-cs-gpio-pins { pins =3D "gpio23"; function =3D "gpio"; }; =20 - qup_spi6_data_clk: qup-spi6-data-clk { + qup_spi6_data_clk: qup-spi6-data-clk-pins { pins =3D "gpio24", "gpio25", "gpio26"; function =3D "qup06"; }; =20 - qup_spi6_cs: qup-spi6-cs { + qup_spi6_cs: qup-spi6-cs-pins { pins =3D "gpio27"; function =3D "qup06"; }; =20 - qup_spi6_cs_gpio: qup-spi6-cs-gpio { + qup_spi6_cs_gpio: qup-spi6-cs-gpio-pins { pins =3D "gpio27"; function =3D "gpio"; }; =20 - qup_spi7_data_clk: qup-spi7-data-clk { + qup_spi7_data_clk: qup-spi7-data-clk-pins { pins =3D "gpio28", "gpio29", "gpio30"; function =3D "qup07"; }; =20 - qup_spi7_cs: qup-spi7-cs { + qup_spi7_cs: qup-spi7-cs-pins { pins =3D "gpio31"; function =3D "qup07"; }; =20 - qup_spi7_cs_gpio: qup-spi7-cs-gpio { + qup_spi7_cs_gpio: qup-spi7-cs-gpio-pins { pins =3D "gpio31"; function =3D "gpio"; }; =20 - qup_spi8_data_clk: qup-spi8-data-clk { + qup_spi8_data_clk: qup-spi8-data-clk-pins { pins =3D "gpio32", "gpio33", "gpio34"; function =3D "qup10"; }; =20 - qup_spi8_cs: qup-spi8-cs { + qup_spi8_cs: qup-spi8-cs-pins { pins =3D "gpio35"; function =3D "qup10"; }; =20 - qup_spi8_cs_gpio: qup-spi8-cs-gpio { + qup_spi8_cs_gpio: qup-spi8-cs-gpio-pins { pins =3D "gpio35"; function =3D "gpio"; }; =20 - qup_spi9_data_clk: qup-spi9-data-clk { + qup_spi9_data_clk: qup-spi9-data-clk-pins { pins =3D "gpio36", "gpio37", "gpio38"; function =3D "qup11"; }; =20 - qup_spi9_cs: qup-spi9-cs { + qup_spi9_cs: qup-spi9-cs-pins { pins =3D "gpio39"; function =3D "qup11"; }; =20 - qup_spi9_cs_gpio: qup-spi9-cs-gpio { + qup_spi9_cs_gpio: qup-spi9-cs-gpio-pins { pins =3D "gpio39"; function =3D "gpio"; }; =20 - qup_spi10_data_clk: qup-spi10-data-clk { + qup_spi10_data_clk: qup-spi10-data-clk-pins { pins =3D "gpio40", "gpio41", "gpio42"; function =3D "qup12"; }; =20 - qup_spi10_cs: qup-spi10-cs { + qup_spi10_cs: qup-spi10-cs-pins { pins =3D "gpio43"; function =3D "qup12"; }; =20 - qup_spi10_cs_gpio: qup-spi10-cs-gpio { + qup_spi10_cs_gpio: qup-spi10-cs-gpio-pins { pins =3D "gpio43"; function =3D "gpio"; }; =20 - qup_spi11_data_clk: qup-spi11-data-clk { + qup_spi11_data_clk: qup-spi11-data-clk-pins { pins =3D "gpio44", "gpio45", "gpio46"; function =3D "qup13"; }; =20 - qup_spi11_cs: qup-spi11-cs { + qup_spi11_cs: qup-spi11-cs-pins { pins =3D "gpio47"; function =3D "qup13"; }; =20 - qup_spi11_cs_gpio: qup-spi11-cs-gpio { + qup_spi11_cs_gpio: qup-spi11-cs-gpio-pins { pins =3D "gpio47"; function =3D "gpio"; }; =20 - qup_spi12_data_clk: qup-spi12-data-clk { + qup_spi12_data_clk: qup-spi12-data-clk-pins { pins =3D "gpio48", "gpio49", "gpio50"; function =3D "qup14"; }; =20 - qup_spi12_cs: qup-spi12-cs { + qup_spi12_cs: qup-spi12-cs-pins { pins =3D "gpio51"; function =3D "qup14"; }; =20 - qup_spi12_cs_gpio: qup-spi12-cs-gpio { + qup_spi12_cs_gpio: qup-spi12-cs-gpio-pins { pins =3D "gpio51"; function =3D "gpio"; }; =20 - qup_spi13_data_clk: qup-spi13-data-clk { + qup_spi13_data_clk: qup-spi13-data-clk-pins { pins =3D "gpio52", "gpio53", "gpio54"; function =3D "qup15"; }; =20 - qup_spi13_cs: qup-spi13-cs { + qup_spi13_cs: qup-spi13-cs-pins { pins =3D "gpio55"; function =3D "qup15"; }; =20 - qup_spi13_cs_gpio: qup-spi13-cs-gpio { + qup_spi13_cs_gpio: qup-spi13-cs-gpio-pins { pins =3D "gpio55"; function =3D "gpio"; }; =20 - qup_spi14_data_clk: qup-spi14-data-clk { + qup_spi14_data_clk: qup-spi14-data-clk-pins { pins =3D "gpio56", "gpio57", "gpio58"; function =3D "qup16"; }; =20 - qup_spi14_cs: qup-spi14-cs { + qup_spi14_cs: qup-spi14-cs-pins { pins =3D "gpio59"; function =3D "qup16"; }; =20 - qup_spi14_cs_gpio: qup-spi14-cs-gpio { + qup_spi14_cs_gpio: qup-spi14-cs-gpio-pins { pins =3D "gpio59"; function =3D "gpio"; }; =20 - qup_spi15_data_clk: qup-spi15-data-clk { + qup_spi15_data_clk: qup-spi15-data-clk-pins { pins =3D "gpio60", "gpio61", "gpio62"; function =3D "qup17"; }; =20 - qup_spi15_cs: qup-spi15-cs { + qup_spi15_cs: qup-spi15-cs-pins { pins =3D "gpio63"; function =3D "qup17"; }; =20 - qup_spi15_cs_gpio: qup-spi15-cs-gpio { + qup_spi15_cs_gpio: qup-spi15-cs-gpio-pins { pins =3D "gpio63"; function =3D "gpio"; }; =20 - qup_uart0_cts: qup-uart0-cts { + qup_uart0_cts: qup-uart0-cts-pins { pins =3D "gpio0"; function =3D "qup00"; }; =20 - qup_uart0_rts: qup-uart0-rts { + qup_uart0_rts: qup-uart0-rts-pins { pins =3D "gpio1"; function =3D "qup00"; }; =20 - qup_uart0_tx: qup-uart0-tx { + qup_uart0_tx: qup-uart0-tx-pins { pins =3D "gpio2"; function =3D "qup00"; }; =20 - qup_uart0_rx: qup-uart0-rx { + qup_uart0_rx: qup-uart0-rx-pins { pins =3D "gpio3"; function =3D "qup00"; }; =20 - qup_uart1_cts: qup-uart1-cts { + qup_uart1_cts: qup-uart1-cts-pins { pins =3D "gpio4"; function =3D "qup01"; }; =20 - qup_uart1_rts: qup-uart1-rts { + qup_uart1_rts: qup-uart1-rts-pins { pins =3D "gpio5"; function =3D "qup01"; }; =20 - qup_uart1_tx: qup-uart1-tx { + qup_uart1_tx: qup-uart1-tx-pins { pins =3D "gpio6"; function =3D "qup01"; }; =20 - qup_uart1_rx: qup-uart1-rx { + qup_uart1_rx: qup-uart1-rx-pins { pins =3D "gpio7"; function =3D "qup01"; }; =20 - qup_uart2_cts: qup-uart2-cts { + qup_uart2_cts: qup-uart2-cts-pins { pins =3D "gpio8"; function =3D "qup02"; }; =20 - qup_uart2_rts: qup-uart2-rts { + qup_uart2_rts: qup-uart2-rts-pins { pins =3D "gpio9"; function =3D "qup02"; }; =20 - qup_uart2_tx: qup-uart2-tx { + qup_uart2_tx: qup-uart2-tx-pins { pins =3D "gpio10"; function =3D "qup02"; }; =20 - qup_uart2_rx: qup-uart2-rx { + qup_uart2_rx: qup-uart2-rx-pins { pins =3D "gpio11"; function =3D "qup02"; }; =20 - qup_uart3_cts: qup-uart3-cts { + qup_uart3_cts: qup-uart3-cts-pins { pins =3D "gpio12"; function =3D "qup03"; }; =20 - qup_uart3_rts: qup-uart3-rts { + qup_uart3_rts: qup-uart3-rts-pins { pins =3D "gpio13"; function =3D "qup03"; }; =20 - qup_uart3_tx: qup-uart3-tx { + qup_uart3_tx: qup-uart3-tx-pins { pins =3D "gpio14"; function =3D "qup03"; }; =20 - qup_uart3_rx: qup-uart3-rx { + qup_uart3_rx: qup-uart3-rx-pins { pins =3D "gpio15"; function =3D "qup03"; }; =20 - qup_uart4_cts: qup-uart4-cts { + qup_uart4_cts: qup-uart4-cts-pins { pins =3D "gpio16"; function =3D "qup04"; }; =20 - qup_uart4_rts: qup-uart4-rts { + qup_uart4_rts: qup-uart4-rts-pins { pins =3D "gpio17"; function =3D "qup04"; }; =20 - qup_uart4_tx: qup-uart4-tx { + qup_uart4_tx: qup-uart4-tx-pins { pins =3D "gpio18"; function =3D "qup04"; }; =20 - qup_uart4_rx: qup-uart4-rx { + qup_uart4_rx: qup-uart4-rx-pins { pins =3D "gpio19"; function =3D "qup04"; }; =20 - qup_uart5_cts: qup-uart5-cts { + qup_uart5_cts: qup-uart5-cts-pins { pins =3D "gpio20"; function =3D "qup05"; }; =20 - qup_uart5_rts: qup-uart5-rts { + qup_uart5_rts: qup-uart5-rts-pins { pins =3D "gpio21"; function =3D "qup05"; }; =20 - qup_uart5_tx: qup-uart5-tx { + qup_uart5_tx: qup-uart5-tx-pins { pins =3D "gpio22"; function =3D "qup05"; }; =20 - qup_uart5_rx: qup-uart5-rx { + qup_uart5_rx: qup-uart5-rx-pins { pins =3D "gpio23"; function =3D "qup05"; }; =20 - qup_uart6_cts: qup-uart6-cts { + qup_uart6_cts: qup-uart6-cts-pins { pins =3D "gpio24"; function =3D "qup06"; }; =20 - qup_uart6_rts: qup-uart6-rts { + qup_uart6_rts: qup-uart6-rts-pins { pins =3D "gpio25"; function =3D "qup06"; }; =20 - qup_uart6_tx: qup-uart6-tx { + qup_uart6_tx: qup-uart6-tx-pins { pins =3D "gpio26"; function =3D "qup06"; }; =20 - qup_uart6_rx: qup-uart6-rx { + qup_uart6_rx: qup-uart6-rx-pins { pins =3D "gpio27"; function =3D "qup06"; }; =20 - qup_uart7_cts: qup-uart7-cts { + qup_uart7_cts: qup-uart7-cts-pins { pins =3D "gpio28"; function =3D "qup07"; }; =20 - qup_uart7_rts: qup-uart7-rts { + qup_uart7_rts: qup-uart7-rts-pins { pins =3D "gpio29"; function =3D "qup07"; }; =20 - qup_uart7_tx: qup-uart7-tx { + qup_uart7_tx: qup-uart7-tx-pins { pins =3D "gpio30"; function =3D "qup07"; }; =20 - qup_uart7_rx: qup-uart7-rx { + qup_uart7_rx: qup-uart7-rx-pins { pins =3D "gpio31"; function =3D "qup07"; }; =20 - qup_uart8_cts: qup-uart8-cts { + qup_uart8_cts: qup-uart8-cts-pins { pins =3D "gpio32"; function =3D "qup10"; }; =20 - qup_uart8_rts: qup-uart8-rts { + qup_uart8_rts: qup-uart8-rts-pins { pins =3D "gpio33"; function =3D "qup10"; }; =20 - qup_uart8_tx: qup-uart8-tx { + qup_uart8_tx: qup-uart8-tx-pins { pins =3D "gpio34"; function =3D "qup10"; }; =20 - qup_uart8_rx: qup-uart8-rx { + qup_uart8_rx: qup-uart8-rx-pins { pins =3D "gpio35"; function =3D "qup10"; }; =20 - qup_uart9_cts: qup-uart9-cts { + qup_uart9_cts: qup-uart9-cts-pins { pins =3D "gpio36"; function =3D "qup11"; }; =20 - qup_uart9_rts: qup-uart9-rts { + qup_uart9_rts: qup-uart9-rts-pins { pins =3D "gpio37"; function =3D "qup11"; }; =20 - qup_uart9_tx: qup-uart9-tx { + qup_uart9_tx: qup-uart9-tx-pins { pins =3D "gpio38"; function =3D "qup11"; }; =20 - qup_uart9_rx: qup-uart9-rx { + qup_uart9_rx: qup-uart9-rx-pins { pins =3D "gpio39"; function =3D "qup11"; }; =20 - qup_uart10_cts: qup-uart10-cts { + qup_uart10_cts: qup-uart10-cts-pins { pins =3D "gpio40"; function =3D "qup12"; }; =20 - qup_uart10_rts: qup-uart10-rts { + qup_uart10_rts: qup-uart10-rts-pins { pins =3D "gpio41"; function =3D "qup12"; }; =20 - qup_uart10_tx: qup-uart10-tx { + qup_uart10_tx: qup-uart10-tx-pins { pins =3D "gpio42"; function =3D "qup12"; }; =20 - qup_uart10_rx: qup-uart10-rx { + qup_uart10_rx: qup-uart10-rx-pins { pins =3D "gpio43"; function =3D "qup12"; }; =20 - qup_uart11_cts: qup-uart11-cts { + qup_uart11_cts: qup-uart11-cts-pins { pins =3D "gpio44"; function =3D "qup13"; }; =20 - qup_uart11_rts: qup-uart11-rts { + qup_uart11_rts: qup-uart11-rts-pins { pins =3D "gpio45"; function =3D "qup13"; }; =20 - qup_uart11_tx: qup-uart11-tx { + qup_uart11_tx: qup-uart11-tx-pins { pins =3D "gpio46"; function =3D "qup13"; }; =20 - qup_uart11_rx: qup-uart11-rx { + qup_uart11_rx: qup-uart11-rx-pins { pins =3D "gpio47"; function =3D "qup13"; }; =20 - qup_uart12_cts: qup-uart12-cts { + qup_uart12_cts: qup-uart12-cts-pins { pins =3D "gpio48"; function =3D "qup14"; }; =20 - qup_uart12_rts: qup-uart12-rts { + qup_uart12_rts: qup-uart12-rts-pins { pins =3D "gpio49"; function =3D "qup14"; }; =20 - qup_uart12_tx: qup-uart12-tx { + qup_uart12_tx: qup-uart12-tx-pins { pins =3D "gpio50"; function =3D "qup14"; }; =20 - qup_uart12_rx: qup-uart12-rx { + qup_uart12_rx: qup-uart12-rx-pins { pins =3D "gpio51"; function =3D "qup14"; }; =20 - qup_uart13_cts: qup-uart13-cts { + qup_uart13_cts: qup-uart13-cts-pins { pins =3D "gpio52"; function =3D "qup15"; }; =20 - qup_uart13_rts: qup-uart13-rts { + qup_uart13_rts: qup-uart13-rts-pins { pins =3D "gpio53"; function =3D "qup15"; }; =20 - qup_uart13_tx: qup-uart13-tx { + qup_uart13_tx: qup-uart13-tx-pins { pins =3D "gpio54"; function =3D "qup15"; }; =20 - qup_uart13_rx: qup-uart13-rx { + qup_uart13_rx: qup-uart13-rx-pins { pins =3D "gpio55"; function =3D "qup15"; }; =20 - qup_uart14_cts: qup-uart14-cts { + qup_uart14_cts: qup-uart14-cts-pins { pins =3D "gpio56"; function =3D "qup16"; }; =20 - qup_uart14_rts: qup-uart14-rts { + qup_uart14_rts: qup-uart14-rts-pins { pins =3D "gpio57"; function =3D "qup16"; }; =20 - qup_uart14_tx: qup-uart14-tx { + qup_uart14_tx: qup-uart14-tx-pins { pins =3D "gpio58"; function =3D "qup16"; }; =20 - qup_uart14_rx: qup-uart14-rx { + qup_uart14_rx: qup-uart14-rx-pins { pins =3D "gpio59"; function =3D "qup16"; }; =20 - qup_uart15_cts: qup-uart15-cts { + qup_uart15_cts: qup-uart15-cts-pins { pins =3D "gpio60"; function =3D "qup17"; }; =20 - qup_uart15_rts: qup-uart15-rts { + qup_uart15_rts: qup-uart15-rts-pins { pins =3D "gpio61"; function =3D "qup17"; }; =20 - qup_uart15_tx: qup-uart15-tx { + qup_uart15_tx: qup-uart15-tx-pins { pins =3D "gpio62"; function =3D "qup17"; }; =20 - qup_uart15_rx: qup-uart15-rx { + qup_uart15_rx: qup-uart15-rx-pins { pins =3D "gpio63"; function =3D "qup17"; }; =20 - sdc1_clk: sdc1-clk { + sdc1_clk: sdc1-clk-pins { pins =3D "sdc1_clk"; }; =20 - sdc1_cmd: sdc1-cmd { + sdc1_cmd: sdc1-cmd-pins { pins =3D "sdc1_cmd"; }; =20 - sdc1_data: sdc1-data { + sdc1_data: sdc1-data-pins { pins =3D "sdc1_data"; }; =20 - sdc1_rclk: sdc1-rclk { + sdc1_rclk: sdc1-rclk-pins { pins =3D "sdc1_rclk"; }; =20 - sdc1_clk_sleep: sdc1-clk-sleep { + sdc1_clk_sleep: sdc1-clk-sleep-pins { pins =3D "sdc1_clk"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc1_cmd_sleep: sdc1-cmd-sleep { + sdc1_cmd_sleep: sdc1-cmd-sleep-pins { pins =3D "sdc1_cmd"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc1_data_sleep: sdc1-data-sleep { + sdc1_data_sleep: sdc1-data-sleep-pins { pins =3D "sdc1_data"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc1_rclk_sleep: sdc1-rclk-sleep { + sdc1_rclk_sleep: sdc1-rclk-sleep-pins { pins =3D "sdc1_rclk"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc2_clk: sdc2-clk { + sdc2_clk: sdc2-clk-pins { pins =3D "sdc2_clk"; }; =20 - sdc2_cmd: sdc2-cmd { + sdc2_cmd: sdc2-cmd-pins { pins =3D "sdc2_cmd"; }; =20 - sdc2_data: sdc2-data { + sdc2_data: sdc2-data-pins { pins =3D "sdc2_data"; }; =20 - sdc2_clk_sleep: sdc2-clk-sleep { + sdc2_clk_sleep: sdc2-clk-sleep-pins { pins =3D "sdc2_clk"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc2_cmd_sleep: sdc2-cmd-sleep { + sdc2_cmd_sleep: sdc2-cmd-sleep-pins { pins =3D "sdc2_cmd"; drive-strength =3D <2>; bias-bus-hold; }; =20 - sdc2_data_sleep: sdc2-data-sleep { + sdc2_data_sleep: sdc2-data-sleep-pins { pins =3D "sdc2_data"; drive-strength =3D <2>; bias-bus-hold; --=20 2.34.1 From nobody Mon Apr 6 03:14:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC39ECAAA1 for ; Sun, 11 Sep 2022 11:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231222AbiIKLP2 (ORCPT ); Sun, 11 Sep 2022 07:15:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbiIKLON (ORCPT ); Sun, 11 Sep 2022 07:14:13 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83FFE3DBF5 for ; Sun, 11 Sep 2022 04:12:57 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id z25so10392933lfr.2 for ; Sun, 11 Sep 2022 04:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=VVRMe5K9zQktuETEV7D34ZSBEU0mHzUqiBeP7TQimRg=; b=TPRQYWyFaIE2NL91c/UGueEkDW+rrjJMXDWHFp3TrW0bEJZUszkyyLiQmYzzLZvmmw U1XLWPKZV6bgbcsX2kD8DFzB7Tlvp3okZ5qRN0cigKsRKnD1GBoJag3BUmIZJRGXJbhd LZiaSAVKs6/j7UhQ7uATMq64MWXHqaG8zfqCtNuau6c85ZJkESg53zXuEj3/yS80lFWc korb9iy5j8zNONCMdBNacqFphfPMkxxJJG/JjzAAkOUIgG+/jMgdtjcdEhnJl39Gctd9 m8Hndvu9g8QEweuTC8OsvHtqcB8gQxEOemjE780WBtyNZlGfC/SeZE7qd8O8upE43KGx kd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=VVRMe5K9zQktuETEV7D34ZSBEU0mHzUqiBeP7TQimRg=; b=YMsOCD9hfs4BGeiX13tTSgEKgy7NBqw8/JJU2AeBdMXLhybpd6Pv2lZDTS0kUBfRgM empG3/XNu5JTFX4ca3xZ2PYWwJ1TbaZBlkAkrEDOZVGgVPvtu5dRPcQKWXC142ZfME20 mrSbbss1ccaTsi14uczwtyXfZlInKmnVe4IdrO6zZtnv2hPHO1oMK0EtHJl21zPg1rf2 x6jFGcidUpkaFYmaByGMcLVwJemQcQRuPueNmFP2l/3QMOwn+IZ4xrLFVrXx3d2RaMea Z+dQQsYgSzO3TPW7btYEVBJ7WD4MIwy9EYlIRWUIQ2OUxAUDU6TNXJ5nJJHdTdjnlCbw fazA== X-Gm-Message-State: ACgBeo13AIGMCzehq7v3VUM91Eq+afgfthtwLYh7Yg4K4Ksa6kqIEWsp GOEXpQL2u2OkdpEvXWjJ1yNZDA== X-Google-Smtp-Source: AA6agR44IqbVtkDkNkeYN3N9BRB2ZKYL9EtrOXYqnVwp98NIzDUbDtydQjTlzVwyacE/DG3gHC7ayA== X-Received: by 2002:a05:6512:c1c:b0:499:acb9:5788 with SMTP id z28-20020a0565120c1c00b00499acb95788mr2203332lfu.347.1662894776682; Sun, 11 Sep 2022 04:12:56 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 11-20020a05651c128b00b0025dfd8c9287sm607365ljc.69.2022.09.11.04.12.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 04:12:56 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Rajendra Nayak , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 40/40] arm64: dts: qcom: sc7280-herobrine: correct TLMM gpio-line-names Date: Sun, 11 Sep 2022 13:12:00 +0200 Message-Id: <20220911111200.199182-41-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> References: <20220911111200.199182-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are 174 GPIOs in SC7280. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64= /boot/dts/qcom/sc7280-herobrine-crd.dts index bc795c480352..3448e9ed8b03 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts @@ -371,7 +371,5 @@ &tlmm { "", /* 170 */ "MOS_BLE_UART_TX", "MOS_BLE_UART_RX", - "", - "", ""; }; --=20 2.34.1