From nobody Mon Apr 6 04:44:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE2FC6FA83 for ; Sun, 11 Sep 2022 08:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbiIKIru (ORCPT ); Sun, 11 Sep 2022 04:47:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229969AbiIKIrs (ORCPT ); Sun, 11 Sep 2022 04:47:48 -0400 Received: from mx-out.tlen.pl (mx-out.tlen.pl [193.222.135.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5177C3206E for ; Sun, 11 Sep 2022 01:47:47 -0700 (PDT) Received: (wp-smtpd smtp.tlen.pl 12976 invoked from network); 11 Sep 2022 10:47:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=o2.pl; s=1024a; t=1662886064; bh=LG1nA/NbcwJ6Bmnos7szIV25H+uEv8jBm87oL1DXQ20=; h=From:To:Cc:Subject; b=bDFTJ9H7RIPdNrmWKFKmg8lEjO5k554CvwJ1y2D13E+i1MbCOGEOLo3mGMFiv62g7 6Q6Oe3xeuERZFwMnI1Zd8WbdFTZtqzfOwadOsg7DszfJlpP6lXBAlwXoSgRYm+FnEX y63HRx7d/aITpiawwtsdNfRE6o/4Ef+aNqnW8oiA= Received: from aafh243.neoplus.adsl.tpnet.pl (HELO localhost.localdomain) (mat.jonczyk@o2.pl@[83.4.137.243]) (envelope-sender ) by smtp.tlen.pl (WP-SMTPD) with SMTP for ; 11 Sep 2022 10:47:44 +0200 From: =?UTF-8?q?Mateusz=20Jo=C5=84czyk?= To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: =?UTF-8?q?Mateusz=20Jo=C5=84czyk?= , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Johan Hovold , "Maciej W. Rozycki" , Yinghai Lu Subject: [PATCH v2 02/10] x86/apic: fix panic message when x2APIC is not supported Date: Sun, 11 Sep 2022 10:47:03 +0200 Message-Id: <20220911084711.13694-3-mat.jonczyk@o2.pl> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220911084711.13694-1-mat.jonczyk@o2.pl> References: <20220911084711.13694-1-mat.jonczyk@o2.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-WP-MailID: b23c894c89c5d3368c5a99d8a5418887 X-WP-AV: skaner antywirusowy Poczty o2 X-WP-SPAM: NO 0000000 [cdMU] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The correct course of action is to enable x2APIC support in the kernel, not to disable it in the BIOS (which may be impossible). x2APIC has performance and functionality benefits, so it is best to use it if it is available on the platform. Signed-off-by: Mateusz Jo=C5=84czyk Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: Johan Hovold Cc: "Maciej W. Rozycki" Cc: Yinghai Lu --- v2: add a newline at the end of the text arch/x86/kernel/apic/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 6d303d1d276c..206a2693a27a 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1902,7 +1902,7 @@ static int __init validate_x2apic(void) /* * Checkme: Can we simply turn off x2apic here instead of panic? */ - panic("BIOS has enabled x2apic but kernel doesn't support x2apic, please = disable x2apic in BIOS.\n"); + panic("Kernel does not support x2APIC, please recompile with CONFIG_X86_X= 2APIC or disable x2APIC in BIOS.\n"); } early_initcall(validate_x2apic); =20 --=20 2.25.1