From nobody Mon Apr 6 04:44:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98A7C6FA89 for ; Sat, 10 Sep 2022 22:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230008AbiIJW1t (ORCPT ); Sat, 10 Sep 2022 18:27:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiIJW1i (ORCPT ); Sat, 10 Sep 2022 18:27:38 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9323738474 for ; Sat, 10 Sep 2022 15:27:37 -0700 (PDT) Message-ID: <20220910222300.466273303@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1662848855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=E5VNsdhocstLmuIwTiCMPIibe4zDdVnAf/ePac5FTrs=; b=Zy3HnUi2VBS5ut9uhR/yxiVuE5M61YjpLA/xPSpsVmYTNqV9p1HHw6cB+/BmwvbvS24vk9 IXDNJmqT1Xe0owRlb//4pc09RTWehYtFXH1BrH2NPDemslzdvI6AeOTfzT1MgCokpYDKXu ijPjGyH+G2WfmZ7QX2ggS/onqNdrBwKvMxjI36H1TZNVjj6UOIkpHSBRhpN5AR5XzAiOBi TqCMSn9Qh4VYejlys4zK5yhUO5ia1wMOUTFQSWtvkmN0pJVBxGEEYfXFbEBOiT01lJMIoN ZdMFegZcBoiBeIbeKQ8qllxcTH6MuyVadZ9fcei/utfLciJhmnFdGH6+4cCKtQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1662848855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=E5VNsdhocstLmuIwTiCMPIibe4zDdVnAf/ePac5FTrs=; b=FW65dlnuCZ6asy8+cb0W/jTJqUbzHFWiipkPt5DjzbMJfAqlNSVG5p7HeFUfebCJj9UYNm VrtaqLn3el0Lq/CQ== From: Thomas Gleixner To: LKML Cc: John Ogness , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Peter Zijlstra , "Paul E. McKenney" , Daniel Vetter , Greg Kroah-Hartman , Helge Deller , Jason Wessel , Daniel Thompson Subject: [patch RFC 02/29] printk: Declare log_wait properly References: <20220910221947.171557773@linutronix.de> MIME-Version: 1.0 Date: Sun, 11 Sep 2022 00:27:34 +0200 (CEST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kernel/printk/printk.c:365:1: warning: symbol 'log_wait' was not declared. = Should it be static? Signed-off-by: Thomas Gleixner Reviewed-by: Sergey Senozhatsky --- fs/proc/kmsg.c | 2 -- include/linux/syslog.h | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c @@ -17,8 +17,6 @@ =20 #include =20 -extern wait_queue_head_t log_wait; - static int kmsg_open(struct inode * inode, struct file * file) { return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_PROC); --- a/include/linux/syslog.h +++ b/include/linux/syslog.h @@ -8,6 +8,8 @@ #ifndef _LINUX_SYSLOG_H #define _LINUX_SYSLOG_H =20 +#include + /* Close the log. Currently a NOP. */ #define SYSLOG_ACTION_CLOSE 0 /* Open the log. Currently a NOP. */ @@ -35,5 +37,6 @@ #define SYSLOG_FROM_PROC 1 =20 int do_syslog(int type, char __user *buf, int count, int source); +extern wait_queue_head_t log_wait; =20 #endif /* _LINUX_SYSLOG_H */