From nobody Mon Apr 6 11:36:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BCEC38145 for ; Thu, 8 Sep 2022 08:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231569AbiIHIOD (ORCPT ); Thu, 8 Sep 2022 04:14:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231628AbiIHINg (ORCPT ); Thu, 8 Sep 2022 04:13:36 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E859D9EBE for ; Thu, 8 Sep 2022 01:13:17 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id l65so17147763pfl.8 for ; Thu, 08 Sep 2022 01:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=jD1WgCeSA8uWA865ybZkInzC4AA4C89F3a1ntZPiE8k=; b=gRx+CxMIiN6H9pj7fPVTKTaBOZuCbadXfe/izl78J7zwh9G/F/ZZfhDRPAR4KUqpIT tzTV7y+tG4VbrnkuhCTSDnVuChYd1LK08RhOcWwdzZIjw2AGCjLp9xz3DJj7dl2RNmhS laBZg/+nT7AZB8IzBfjPX3AwryZn3ulbsNQ5g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=jD1WgCeSA8uWA865ybZkInzC4AA4C89F3a1ntZPiE8k=; b=ZRTyGuNKbudMGgBlgNjVO6JFy7iYHP4Zn2dASuFOveN1y/2w0DedpMC2DiSinDm2bb OVcPZ7A6gWQIP3SwI3+IJTAH2NacKXOKNoCtk6+Q4o1hOQ344kbPlg4TAbpThHQ/auQ0 HhWfHfa+K8jRxmLMz4cDazm7BR8rU6EANU0FbSAuzSW7eaOimINGMTEWf+nG4hc3Y/jQ TtyVRPx8y4I06bn2bOOe+p7shYh+/4+dVsDzarmVybIowKOH+gdUfAk1xgYMtP2wpgJM fYXPtv0nkJdMJ3COa71L9tQ9LpLN5nE+DV5SaJ+FhQNeTlRZps4zo2NEIv6YQLXfFmfE NMgQ== X-Gm-Message-State: ACgBeo2c1vcFfy+VDPAiWp35KHF0FEnTrbXkqb+23m7g5nwY6OZBWgmd jOuGnyQecIfCDXYGElp7zQZsvQ== X-Google-Smtp-Source: AA6agR5pAxhOg42yEVQWiNBTst6BWefRDET/Dw+fjQjsfFbYbib4gMXfhh2kApJRsESI7zxngjveLQ== X-Received: by 2002:a63:6683:0:b0:42b:1d69:a0ff with SMTP id a125-20020a636683000000b0042b1d69a0ffmr6965140pgc.475.1662624796587; Thu, 08 Sep 2022 01:13:16 -0700 (PDT) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:5237:c185:9b01:8955]) by smtp.gmail.com with ESMTPSA id z22-20020aa79496000000b0052d4cb47339sm14159702pfk.151.2022.09.08.01.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:13:16 -0700 (PDT) From: Pin-yen Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter Cc: Hermes Wu , Allen Chen , Hsin-Yi Wang , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Pin-yen Lin Subject: [PATCH 2/2] drm/bridge: it6505: Add pre_enable/post_disable callback Date: Thu, 8 Sep 2022 16:12:58 +0800 Message-Id: <20220908081259.503236-3-treapking@chromium.org> X-Mailer: git-send-email 2.37.2.789.g6183377224-goog In-Reply-To: <20220908081259.503236-1-treapking@chromium.org> References: <20220908081259.503236-1-treapking@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add atomic_pre_enable and atomic_post_disable callback to make sure the bridge is not powered off until atomic_post_disable is called. This prevents a power leakage when it6505 is powered off, but the upstream DRM bridge is still sending display signals. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/i= te-it6505.c index 9d37660545fb..f5eea138ace4 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -2984,6 +2984,28 @@ static void it6505_bridge_atomic_disable(struct drm_= bridge *bridge, } } =20 +static void it6505_bridge_atomic_pre_enable(struct drm_bridge *bridge, + struct drm_bridge_state *old_state) +{ + struct it6505 *it6505 =3D bridge_to_it6505(bridge); + struct device *dev =3D &it6505->client->dev; + + DRM_DEV_DEBUG_DRIVER(dev, "start"); + + pm_runtime_get_sync(dev); +} + +static void it6505_bridge_atomic_post_disable(struct drm_bridge *bridge, + struct drm_bridge_state *old_state) +{ + struct it6505 *it6505 =3D bridge_to_it6505(bridge); + struct device *dev =3D &it6505->client->dev; + + DRM_DEV_DEBUG_DRIVER(dev, "start"); + + pm_runtime_put_sync(dev); +} + static enum drm_connector_status it6505_bridge_detect(struct drm_bridge *bridge) { @@ -3018,6 +3040,8 @@ static const struct drm_bridge_funcs it6505_bridge_fu= ncs =3D { .mode_valid =3D it6505_bridge_mode_valid, .atomic_enable =3D it6505_bridge_atomic_enable, .atomic_disable =3D it6505_bridge_atomic_disable, + .atomic_pre_enable =3D it6505_bridge_atomic_pre_enable, + .atomic_post_disable =3D it6505_bridge_atomic_post_disable, .detect =3D it6505_bridge_detect, .get_edid =3D it6505_bridge_get_edid, }; --=20 2.37.2.789.g6183377224-goog