From nobody Sat Apr 11 13:18:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 829ADECAAA1 for ; Tue, 6 Sep 2022 06:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238017AbiIFGUp (ORCPT ); Tue, 6 Sep 2022 02:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230056AbiIFGUh (ORCPT ); Tue, 6 Sep 2022 02:20:37 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B1AA222B9; Mon, 5 Sep 2022 23:20:37 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id t11-20020a17090a510b00b001fac77e9d1fso13878018pjh.5; Mon, 05 Sep 2022 23:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=nGBVFgXS0eqoiY86MSD6T7/S6VN4vNYiYOjgs/oE4mY=; b=KyXRFDauk1axtxubltzu8BL+9pcdtxnAvJKf+Xw9R/aDIRKMEHXxUXHNyFcdP60sIO +3AtxKFVqBcoQH27ignZ39T5f7Y9tT3ze/AAQ/thdm0vLFaNBnNxQEaX78lCtjCGwwaz 4BmDjwFL8PNJn8vW/YpYg0s+kmvpEiLMslNQgk5G8amP8+R7qzmXF/WBkx0xpIlrWJ/c xID8JpzAwaYSUgFc+RYodWx8A4EBque0dhLl/U1vmCKz0OIVNWArVOW2u7PYwana5ntt Pc0h2VD1ncsV7y+n273AlV0CieRr8fyqOCTynk9uzk+TquvyQDwMDLb6reEGou32+UxD hX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=nGBVFgXS0eqoiY86MSD6T7/S6VN4vNYiYOjgs/oE4mY=; b=Wq1q9uf05ZQPXgGsl8yPkiS46qkYgYFUhb6z2rZo2f4uyfWzzRqaLsFKmKuPVAw/5b 4GCmlOQnmIpsVkjDvgPTzStmUBAngBRGQFlZmZZ7yaL/Gdr68RmKmvUtuu3RLVAirGjm 638era5eyWwKw+wz8IzsFtq23/gEMEOefj8gMMCgF+KQKKXqdeS04OxFm0de6VEd8TbY mmHnCji4tnYPiZDNVpRcTLv05PnpXB9WG7F1L9sXr+piRhPgI4wokC/qn3JjejGGGrXi xuwEkUbjqo18j8jiVFe5kfMl10rCxBlJw+uYZw/qrXLet+RP/KbBEsDvBlkD7X+QLHgs gNzg== X-Gm-Message-State: ACgBeo0qx11Imza3w+M8xmJqATLiGDmBvs1VdRst0k+tA04YtDF0NUAf SHTUCnN1iAZ03CXiLrusVpE= X-Google-Smtp-Source: AA6agR53PUca4ir2leHPUVovDvemsSXgnFsYiOcmz3zQdzyDkaeSkXfx+UaVJ9p02CUgb1p2FUTNjA== X-Received: by 2002:a17:902:7845:b0:16e:d647:a66c with SMTP id e5-20020a170902784500b0016ed647a66cmr50876749pln.64.1662445236481; Mon, 05 Sep 2022 23:20:36 -0700 (PDT) Received: from localhost.localdomain ([76.132.249.1]) by smtp.gmail.com with ESMTPSA id m16-20020a170902db1000b00172dd10f64fsm8877798plx.263.2022.09.05.23.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 23:20:35 -0700 (PDT) From: rentao.bupt@gmail.com To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heyi Guo , Dylan Hung , Guangbin Huang , Liang He , Hao Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Tao Ren , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Tao Ren Subject: [PATCH net-next v2 1/2] net: ftgmac100: support fixed link Date: Mon, 5 Sep 2022 23:20:25 -0700 Message-Id: <20220906062026.57169-2-rentao.bupt@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220906062026.57169-1-rentao.bupt@gmail.com> References: <20220906062026.57169-1-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tao Ren Support fixed link in ftgmac100 driver. Fixed link is used on several Meta OpenBMC platforms, such as Elbert (AST2620) and Wedge400 (AST2520). Signed-off-by: Tao Ren Reviewed-by: Andrew Lunn --- Changes in v2: None drivers/net/ethernet/faraday/ftgmac100.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/etherne= t/faraday/ftgmac100.c index 9277d5fb5052..da04beee5865 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1701,10 +1701,14 @@ static int ftgmac100_setup_mdio(struct net_device *= netdev) =20 static void ftgmac100_phy_disconnect(struct net_device *netdev) { + struct ftgmac100 *priv =3D netdev_priv(netdev); + if (!netdev->phydev) return; =20 phy_disconnect(netdev->phydev); + if (of_phy_is_fixed_link(priv->dev->of_node)) + of_phy_deregister_fixed_link(priv->dev->of_node); } =20 static void ftgmac100_destroy_mdio(struct net_device *netdev) @@ -1867,6 +1871,26 @@ static int ftgmac100_probe(struct platform_device *p= dev) err =3D -EINVAL; goto err_phy_connect; } + } else if (np && of_phy_is_fixed_link(np)) { + struct phy_device *phy; + + err =3D of_phy_register_fixed_link(np); + if (err) { + dev_err(&pdev->dev, "Failed to register fixed PHY\n"); + goto err_phy_connect; + } + + phy =3D of_phy_get_and_connect(priv->netdev, np, + &ftgmac100_adjust_link); + if (!phy) { + dev_err(&pdev->dev, "Failed to connect to fixed PHY\n"); + of_phy_deregister_fixed_link(np); + err =3D -EINVAL; + goto err_phy_connect; + } + + /* Display what we found */ + phy_attached_info(phy); } else if (np && of_get_property(np, "phy-handle", NULL)) { struct phy_device *phy; =20 --=20 2.37.3 From nobody Sat Apr 11 13:18:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3EF6ECAAA1 for ; Tue, 6 Sep 2022 06:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238379AbiIFGU7 (ORCPT ); Tue, 6 Sep 2022 02:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238085AbiIFGUu (ORCPT ); Tue, 6 Sep 2022 02:20:50 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3BC52B636; Mon, 5 Sep 2022 23:20:43 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id t11-20020a17090a510b00b001fac77e9d1fso13878220pjh.5; Mon, 05 Sep 2022 23:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=3Kvr9t8tl1/ms0/7xPHpz9WdqpLe/wgSflXORB7TJd0=; b=Fl4hRRFl5sMh4BN5/k16jkd3sP6MTf3gaTHSBGMWQ6tlGQgGIVMGz1MsvoHYey997j ylt+tl6FiSGMSMJqweBQVHc+Yz/Q9wqhd8sEsdxcpFLFb9LpaaFDGMA8vFP56lbPLa2F Laho1GWqhs5jrLoFarET3QX1qzHALDUK6Q381LQalztW/EmeIvMHXyq/25oCKXPKQ2XI r9D0nzjt+BoRMTXh+TmeV84uOaPsh9wbvdyElKy28cVu+og91IwhZSdSPQSl+qVOAMLg gGgWcup79BJw06q4InpwI5cxsjSTlIBS4rysbxcjQaoXJcGb1hzce65Z9/ABgK58f3z0 qojQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=3Kvr9t8tl1/ms0/7xPHpz9WdqpLe/wgSflXORB7TJd0=; b=R/Zur/1ww4hZg/AgZtZeXZ4QPZI/P+wkhiVrUotQWAaGtWXTYdzoNcewN9K//fp2s2 1yL6X4flf4uQgWqKHWWEdqJ6sVhsKSBjbMAJifDK/OTy/4bzDaTjTP9yuubTSiyisddK bd9XQ9R+rJiBJ+FZsQ1M2b/E6LJvGV89CyDBLg2v3m+fXBXNS0Qm/rmygFqgYfppIWJq JS5H3wlMox12MjfY3tJ/1I0bdQMoksJXv5MVk77Qo/DdwzAOpOUB/oWcM94Svt+SS80X P85CvKlTz1iC8ockD8+iniORUrDSxZFJ9B1f7Trtyc/uhKehMZCl5GTOmUnZorYpAlpA 4bmA== X-Gm-Message-State: ACgBeo0Oz+opdlEoHar0Cg+ywFvzQMvOeqEnQd0dVek0UwujnYIFJ9ra wJodI4LSdOswpZE3AtvPZeM= X-Google-Smtp-Source: AA6agR6mgN6a8EMCkb2sUzh84tuyTkJRzb3cEOqOWShLqubfN42tc50cBynnYgKnWZ78FPXvtqlsow== X-Received: by 2002:a17:902:ab98:b0:172:a566:d462 with SMTP id f24-20020a170902ab9800b00172a566d462mr51817770plr.53.1662445243373; Mon, 05 Sep 2022 23:20:43 -0700 (PDT) Received: from localhost.localdomain ([76.132.249.1]) by smtp.gmail.com with ESMTPSA id m16-20020a170902db1000b00172dd10f64fsm8877798plx.263.2022.09.05.23.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 23:20:42 -0700 (PDT) From: rentao.bupt@gmail.com To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heyi Guo , Dylan Hung , Guangbin Huang , Liang He , Hao Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Tao Ren , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Tao Ren Subject: [PATCH net-next v2 2/2] ARM: dts: aspeed: elbert: Enable mac3 controller Date: Mon, 5 Sep 2022 23:20:26 -0700 Message-Id: <20220906062026.57169-3-rentao.bupt@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220906062026.57169-1-rentao.bupt@gmail.com> References: <20220906062026.57169-1-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tao Ren Enable mac3 controller in Elbert dts: Elbert MAC3 is connected to the BCM53134P onboard switch's IMP_RGMII port directly (fixed link, no PHY between BMC MAC and BCM53134P). Note: BMC's mdio0 controller is connected to BCM53134P's MDIO interface for debugging purposes only: BCM53134P always loads configurations from its EEPROM, and users should not configure the switch via the MDIO interface. As a result, the MDIO connection is disabled in dts. Signed-off-by: Tao Ren --- Changes in v2: - updated comments and patch description. .../boot/dts/aspeed-bmc-facebook-elbert.dts | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts b/arch/arm/bo= ot/dts/aspeed-bmc-facebook-elbert.dts index 27b43fe099f1..36657d8fdb73 100644 --- a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts @@ -183,3 +183,23 @@ imux31: i2c@7 { &i2c11 { status =3D "okay"; }; + +/* + * BMC's "mac3" is connected to BCM53134P's IMP_RGMII port directly (no + * PHY in between). + * Although BMC's "mdio0" controller is connected to BCM53134P's MDIO + * interface, it's only for debugging purposes: BCM53134P always loads + * configurations from its EEPROM, and users should not configure the + * switch through MDIO interface in regular operations. As a result, + * the MDIO connection is disabled in dts. + */ +&mac3 { + status =3D "okay"; + phy-mode =3D "rgmii"; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&pinctrl_rgmii4_default>; + fixed-link { + speed =3D <1000>; + full-duplex; + }; +}; --=20 2.37.3