From nobody Mon Apr 6 17:08:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E05FC54EE9 for ; Mon, 5 Sep 2022 14:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235644AbiIEOCS (ORCPT ); Mon, 5 Sep 2022 10:02:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231255AbiIEOCO (ORCPT ); Mon, 5 Sep 2022 10:02:14 -0400 Received: from m12-15.163.com (m12-15.163.com [220.181.12.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F01EAEE3D; Mon, 5 Sep 2022 07:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Pi1na IghCtZpY2AFv6eJH51PFyGAYP4iWrNPySGgJsk=; b=fuPr5/wN6PDmBtr1p1nKV ElI+lP7U+R2s+smwa1Uqls4quD28z0ync5YLSRVCZrD9EFz96qGzOAmp2o8qUo02 JMEM2tndc9TXqZ9XistwYagF90TPscWsvl1fP7WEXB6+49XGInuTAL+rag9v6pQ5 j9vvrqIlsBfbscTYJbMmAM= Received: from f00160-VMware-Virtual-Platform.localdomain (unknown [1.203.67.201]) by smtp11 (Coremail) with SMTP id D8CowAAnPcFDARZj8ytLAA--.15537S4; Mon, 05 Sep 2022 22:02:03 +0800 (CST) From: Jingyu Wang To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jingyu Wang Subject: [PATCH] pci: cleanup coding styling in pci-driver.c Date: Mon, 5 Sep 2022 22:01:36 +0800 Message-Id: <20220905140136.25066-1-jingyuwang_vip@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: D8CowAAnPcFDARZj8ytLAA--.15537S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZFW8ZrWxJr1xKr4ktFykAFb_yoW8uw45pF Z3JayYkrW8JF47Xr4DtF4DAFyrAws2gayfKrWxGw1SgFsIyryDtF1rJFyYva4rArWkur47 t3WDtr4I9a10qr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pERp9iUUUUU= X-Originating-IP: [1.203.67.201] X-CM-SenderInfo: 5mlqw5xxzd0whbyl1qqrwthudrp/1tbishtzF1UMWRFl+wAAsC Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Signed-off-by: Jingyu Wang --- drivers/pci/pci-driver.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 49238ddd39ee..bba486f5e5fe 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -204,6 +204,7 @@ static ssize_t new_id_store(struct device_driver *drive= r, const char *buf, =20 if (fields !=3D 7) { struct pci_dev *pdev =3D kzalloc(sizeof(*pdev), GFP_KERNEL); + if (!pdev) return -ENOMEM; =20 @@ -222,8 +223,8 @@ static ssize_t new_id_store(struct device_driver *drive= r, const char *buf, return retval; } =20 - /* Only accept driver_data values that match an existing id_table - entry */ + /* Only accept driver_data values that match an existing id_table entry + */ if (ids) { retval =3D -EINVAL; while (ids->vendor || ids->subvendor || ids->class_mask) { @@ -272,6 +273,7 @@ static ssize_t remove_id_store(struct device_driver *dr= iver, const char *buf, spin_lock(&pdrv->dynids.lock); list_for_each_entry_safe(dynid, n, &pdrv->dynids.list, node) { struct pci_device_id *id =3D &dynid->id; + if ((id->vendor =3D=3D vendor) && (id->device =3D=3D device) && (subvendor =3D=3D PCI_ANY_ID || id->subvendor =3D=3D subvendor) && @@ -537,6 +539,7 @@ static int pci_restore_standard_config(struct pci_dev *= pci_dev) =20 if (pci_dev->current_state !=3D PCI_D0) { int error =3D pci_set_power_state(pci_dev, PCI_D0); + if (error) return error; } @@ -705,6 +708,7 @@ static int pci_pm_prepare(struct device *dev) =20 if (pm && pm->prepare) { int error =3D pm->prepare(dev); + if (error < 0) return error; =20 @@ -1364,7 +1368,7 @@ static int pci_pm_runtime_idle(struct device *dev) return 0; =20 if (!pm) - return -ENOSYS; + return -ENODEV; =20 if (pm->runtime_idle) return pm->runtime_idle(dev); @@ -1471,6 +1475,7 @@ struct pci_driver *pci_dev_driver(const struct pci_de= v *dev) return dev->driver; else { int i; + for (i =3D 0; i <=3D PCI_ROM_RESOURCE; i++) if (dev->resource[i].flags & IORESOURCE_BUSY) return &pci_compat_driver; base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 --=20 2.34.1