From nobody Tue Apr 7 00:42:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D90ECAAD5 for ; Mon, 5 Sep 2022 07:35:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236706AbiIEHe6 (ORCPT ); Mon, 5 Sep 2022 03:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236392AbiIEHeu (ORCPT ); Mon, 5 Sep 2022 03:34:50 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE74110FD7 for ; Mon, 5 Sep 2022 00:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662363288; x=1693899288; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5+cFdZuhJFU58XSt+XWu8IhXjGVt378HIsUWt4m88gg=; b=QovO8eKqoEB4fi6dKneCY7r8XVM6JI0zz4OVgobFoU0cOpQtMyLRI7kK nBEZXGFt2AnI0O+2VAbea/+s0M641CRYoBrAOvRk1hD3KUt4gp15b4UZu 0fnAmXoa/3vU7Nr+TeSaFzJouc1VsfR1oThTrwVEGXe6xysYEjk/EaSju Qxra5mQOWXszWx75D99hMX8mMkENqlo9wRZS/JTF/yQ69efSFf+fNnBBJ vy8evHEWEFx6FiEU6j+pMiZNXU7zHdBXTDkELZIjFzWZLxMglJuI0BSGL s95ICnW6kG3yAHWHhcd/ky03oUmWWmdLaJoxuhnMAr84qkipGTx+vhhxT Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10460"; a="296332700" X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="296332700" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2022 00:34:48 -0700 X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="609595386" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.252.56.151]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2022 00:34:46 -0700 From: Adrian Hunter To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org Subject: [PATCH V2 4/6] perf intel-pt: Improve object code read error message Date: Mon, 5 Sep 2022 10:34:22 +0300 Message-Id: <20220905073424.3971-5-adrian.hunter@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220905073424.3971-1-adrian.hunter@intel.com> References: <20220905073424.3971-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The offset is more readable in hex instead of decimal. Signed-off-by: Adrian Hunter Reviewed-by: Andi Kleen --- tools/perf/util/intel-pt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c index d5e9fc8106dd..c01ff8001501 100644 --- a/tools/perf/util/intel-pt.c +++ b/tools/perf/util/intel-pt.c @@ -842,7 +842,8 @@ static int intel_pt_walk_next_insn(struct intel_pt_insn= *intel_pt_insn, offset, buf, INTEL_PT_INSN_BUF_SZ); if (len <=3D 0) { - intel_pt_log("ERROR: failed to read at %" PRIu64 " ", offset); + intel_pt_log("ERROR: failed to read at offset %#" PRIx64 " ", + offset); if (intel_pt_enable_logging) dso__fprintf(al.map->dso, intel_pt_log_fp()); return -EINVAL; --=20 2.25.1