From nobody Mon Apr 6 21:57:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74171ECAAD5 for ; Fri, 2 Sep 2022 11:23:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236041AbiIBLXu (ORCPT ); Fri, 2 Sep 2022 07:23:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235893AbiIBLWz (ORCPT ); Fri, 2 Sep 2022 07:22:55 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 328A6D290F; Fri, 2 Sep 2022 04:22:47 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MJwR91gmRzlWhT; Fri, 2 Sep 2022 19:19:17 +0800 (CST) Received: from huawei.com (10.175.101.6) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 2 Sep 2022 19:22:44 +0800 From: Zhengchao Shao To: , , , , , , , , , , CC: , , , , , , , , , , , , Subject: [PATCH net-next 15/22] net: sched: act_police: get rid of tcf_police_walker and tcf_police_search Date: Fri, 2 Sep 2022 19:24:39 +0800 Message-ID: <20220902112446.29858-16-shaozhengchao@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220902112446.29858-1-shaozhengchao@huawei.com> References: <20220902112446.29858-1-shaozhengchao@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500026.china.huawei.com (7.185.36.106) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use __tcf_generic_walker() and __tcf_idr_search() helpers by saving police_net_id when registering act_police_ops. And then remove the walk and lookup hook functions in act_police. Signed-off-by: Zhengchao Shao --- net/sched/act_police.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/net/sched/act_police.c b/net/sched/act_police.c index b759628a47c2..a9dd89210bd4 100644 --- a/net/sched/act_police.c +++ b/net/sched/act_police.c @@ -25,16 +25,6 @@ static unsigned int police_net_id; static struct tc_action_ops act_police_ops; =20 -static int tcf_police_walker(struct net *net, struct sk_buff *skb, - struct netlink_callback *cb, int type, - const struct tc_action_ops *ops, - struct netlink_ext_ack *extack) -{ - struct tc_action_net *tn =3D net_generic(net, police_net_id); - - return tcf_generic_walker(tn, skb, cb, type, ops, extack); -} - static const struct nla_policy police_policy[TCA_POLICE_MAX + 1] =3D { [TCA_POLICE_RATE] =3D { .len =3D TC_RTAB_SIZE }, [TCA_POLICE_PEAKRATE] =3D { .len =3D TC_RTAB_SIZE }, @@ -412,13 +402,6 @@ static int tcf_police_dump(struct sk_buff *skb, struct= tc_action *a, return -1; } =20 -static int tcf_police_search(struct net *net, struct tc_action **a, u32 in= dex) -{ - struct tc_action_net *tn =3D net_generic(net, police_net_id); - - return tcf_idr_search(tn, a, index); -} - static int tcf_police_act_to_flow_act(int tc_act, u32 *extval, struct netlink_ext_ack *extack) { @@ -508,13 +491,12 @@ MODULE_LICENSE("GPL"); static struct tc_action_ops act_police_ops =3D { .kind =3D "police", .id =3D TCA_ID_POLICE, + .net_id =3D &police_net_id, .owner =3D THIS_MODULE, .stats_update =3D tcf_police_stats_update, .act =3D tcf_police_act, .dump =3D tcf_police_dump, .init =3D tcf_police_init, - .walk =3D tcf_police_walker, - .lookup =3D tcf_police_search, .cleanup =3D tcf_police_cleanup, .offload_act_setup =3D tcf_police_offload_act_setup, .size =3D sizeof(struct tcf_police), --=20 2.17.1