From nobody Mon Apr 6 23:08:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63067ECAAD3 for ; Fri, 2 Sep 2022 01:01:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235157AbiIBBBa (ORCPT ); Thu, 1 Sep 2022 21:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235145AbiIBBBF (ORCPT ); Thu, 1 Sep 2022 21:01:05 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AC04A50ED for ; Thu, 1 Sep 2022 18:00:53 -0700 (PDT) Received: from localhost.localdomain (unknown [182.2.38.99]) by gnuweeb.org (Postfix) with ESMTPSA id 950B180C12; Fri, 2 Sep 2022 01:00:48 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662080452; bh=9mn+NsOQ1zaPJ1WbjFHcvyNU4C6nPGPxtaZbqetpeAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I7fFVRdMdz1lfJVbKj0RbWr/+JfX5pdiOFDMt/H/z02R1rIbqOhT7cdA/uvDleWwW fsQiRQijO6dK0PTkHdD9KRCkuilkN5EnLon7028gKCTQN2BaLABSYwcWRI1eOEPw0B 1nYOGX4jWUq83wXK2qthJzIMlddhTeSF5jeJIwpwX1t3k6HEnDwv5IGn3QKnAkdx+Y 0RAAwlT5CKEKV/mPnoURRe218PD56EJogbMsikAswqz5H8ve2NeByhjaY+avxLl4gZ o/w6EnsIBHOhYBg3Ki7vqZXXtNwl4OWhcTNwCV1/ZNgkzuG/XmTAmDeEE1lKd4xDZJ SwF8U7IeLVPIw== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Dylan Yudaken , Facebook Kernel Team , Pavel Begunkov , Kanna Scarlet , Muhammad Rizki , GNU/Weeb Mailing List , io-uring Mailing List , Linux Kernel Mailing List Subject: [PATCH liburing v1 08/12] t/connect: Don't use a static port number Date: Fri, 2 Sep 2022 07:59:42 +0700 Message-Id: <20220902005825.2484023-9-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220902005825.2484023-1-ammar.faizi@intel.com> References: <20220902005825.2484023-1-ammar.faizi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Ammar Faizi Don't use a static port number. It might already be in use, resulting in a test failure. Use an ephemeral port to make this test reliable. Cc: Dylan Yudaken Cc: Facebook Kernel Team Cc: Pavel Begunkov Signed-off-by: Ammar Faizi --- test/accept.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/accept.c b/test/accept.c index b35ded4..1821faa 100644 --- a/test/accept.c +++ b/test/accept.c @@ -184,31 +184,28 @@ static int start_accept_listen(struct sockaddr_in *ad= dr, int port_off, =20 int32_t val =3D 1; ret =3D setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, &val, sizeof(val)); assert(ret !=3D -1); ret =3D setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)); assert(ret !=3D -1); =20 struct sockaddr_in laddr; =20 if (!addr) addr =3D &laddr; =20 addr->sin_family =3D AF_INET; - addr->sin_port =3D htons(0x1235 + port_off); addr->sin_addr.s_addr =3D inet_addr("127.0.0.1"); - - ret =3D bind(fd, (struct sockaddr*)addr, sizeof(*addr)); - assert(ret !=3D -1); + assert(!t_bind_ephemeral_port(fd, addr)); ret =3D listen(fd, 128); assert(ret !=3D -1); =20 return fd; } =20 static int set_client_fd(struct sockaddr_in *addr) { int32_t val; int fd, ret; =20 fd =3D socket(AF_INET, SOCK_STREAM | SOCK_CLOEXEC, IPPROTO_TCP); =20 --=20 Ammar Faizi