From nobody Mon Apr 6 23:08:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C87ECAAD2 for ; Fri, 2 Sep 2022 01:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235007AbiIBBBF (ORCPT ); Thu, 1 Sep 2022 21:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234836AbiIBBAi (ORCPT ); Thu, 1 Sep 2022 21:00:38 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90B2B48CA6 for ; Thu, 1 Sep 2022 18:00:35 -0700 (PDT) Received: from localhost.localdomain (unknown [182.2.38.99]) by gnuweeb.org (Postfix) with ESMTPSA id 306D380C0E; Fri, 2 Sep 2022 01:00:30 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662080435; bh=qs4JWXzimskB0a0dxpXuwJq+RPw5p6Ix1O988JFqCXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KFNn40UYvQ4q7OUbaNPIHEDdxDyVPJu4V3423xzNxkvVntWFVsuDK9clwX0Kbk3Ic rNYzP71HYXwvfugIWjJBA5zYwspn9hzBqxn6CznbImonljgWZ3GIC7Hg3+nXd4XjYw W1axHUf68kA6cZm//gdXdDJYwTGFCR+cYd1lsotPgtWBRgW7/Jwdh/FpqJGZ9KZCc8 x2te4tc412nqE6FMg1pUHPQXZOU+u4EJOSZybSJspHc/3es2ivkRrQVXfjdrAZ95Mi wkdJ3bCM8gI7YwrHaP2a7GxEp6Lt+iRT12O4bFpQvE1ZD+qCszrmNpc1zpOl/qfYvP WHntArYofsaQA== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Dylan Yudaken , Facebook Kernel Team , Pavel Begunkov , Kanna Scarlet , Muhammad Rizki , GNU/Weeb Mailing List , io-uring Mailing List , Linux Kernel Mailing List Subject: [PATCH liburing v1 04/12] t/socket-rw-eagain: Don't brute force the port number Date: Fri, 2 Sep 2022 07:59:38 +0700 Message-Id: <20220902005825.2484023-5-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220902005825.2484023-1-ammar.faizi@intel.com> References: <20220902005825.2484023-1-ammar.faizi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Ammar Faizi Don't brute force the port number, use `t_bind_ephemeral_port()`, much simpler and reliable for choosing a port number that is not in use. Cc: Dylan Yudaken Cc: Facebook Kernel Team Cc: Pavel Begunkov Signed-off-by: Ammar Faizi --- test/socket-rw-eagain.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/test/socket-rw-eagain.c b/test/socket-rw-eagain.c index 2d6a817..a12c70d 100644 --- a/test/socket-rw-eagain.c +++ b/test/socket-rw-eagain.c @@ -8,61 +8,51 @@ #include #include =20 #include #include #include #include #include #include #include #include =20 #include "liburing.h" +#include "helpers.h" =20 int main(int argc, char *argv[]) { int p_fd[2], ret; int32_t recv_s0; int32_t val =3D 1; struct sockaddr_in addr; struct iovec iov_r[1], iov_w[1]; =20 if (argc > 1) return 0; =20 srand(getpid()); =20 recv_s0 =3D socket(AF_INET, SOCK_STREAM | SOCK_CLOEXEC, IPPROTO_TCP); =20 ret =3D setsockopt(recv_s0, SOL_SOCKET, SO_REUSEPORT, &val, sizeof(val)); assert(ret !=3D -1); ret =3D setsockopt(recv_s0, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)); assert(ret !=3D -1); =20 addr.sin_family =3D AF_INET; addr.sin_addr.s_addr =3D inet_addr("127.0.0.1"); - - do { - addr.sin_port =3D htons((rand() % 61440) + 4096); - ret =3D bind(recv_s0, (struct sockaddr*)&addr, sizeof(addr)); - if (!ret) - break; - if (errno !=3D EADDRINUSE) { - perror("bind"); - exit(1); - } - } while (1); - + assert(!t_bind_ephemeral_port(recv_s0, &addr)); ret =3D listen(recv_s0, 128); assert(ret !=3D -1); =20 p_fd[1] =3D socket(AF_INET, SOCK_STREAM | SOCK_CLOEXEC, IPPROTO_TCP); =20 val =3D 1; ret =3D setsockopt(p_fd[1], IPPROTO_TCP, TCP_NODELAY, &val, sizeof(val)); assert(ret !=3D -1); =20 int32_t flags =3D fcntl(p_fd[1], F_GETFL, 0); assert(flags !=3D -1); =20 flags |=3D O_NONBLOCK; --=20 Ammar Faizi