From nobody Mon Apr 6 23:08:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D40ECAAD3 for ; Fri, 2 Sep 2022 01:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235094AbiIBBBr (ORCPT ); Thu, 1 Sep 2022 21:01:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235181AbiIBBBI (ORCPT ); Thu, 1 Sep 2022 21:01:08 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AF1BA61EE for ; Thu, 1 Sep 2022 18:01:01 -0700 (PDT) Received: from localhost.localdomain (unknown [182.2.38.99]) by gnuweeb.org (Postfix) with ESMTPSA id 5405880C14; Fri, 2 Sep 2022 01:00:57 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662080461; bh=TNBQyUndOwcKgHkPQpPb2W5jDyTNkUXpBwq2t+iephY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QkimsktItTYLJPUPpfZI3v4cKtooxKWxJsVWk1YNrTRdA8tDT9V7gZ0kII3y7FwBP t8Sm2cl6/pdVDZGOJSNah2yH+eF7XPh/YTBXHWZus21kp8W/DMFbu6lgbJcG0QxMT2 Sk/ZTB94Cr9aGYWSaikJ2m8fEQMTs9euhZqf4/iV0tcacx2xU1gHajauyuzLl6aal0 kCoBDi4Arv3TZXh87K9lSQaoj+uWuN9qzOY7Egwm2MjOopvf0VuCe8GnUP9r8wf7K/ qPai9HDiue1wCBekbHNqR2F3SOU3+ZX2Vv3yHeo3P+HK03/bERMK5FwUOoLrZUwCNK gv9y8qsyb/T8A== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Dylan Yudaken , Facebook Kernel Team , Pavel Begunkov , Kanna Scarlet , Muhammad Rizki , GNU/Weeb Mailing List , io-uring Mailing List , Linux Kernel Mailing List Subject: [PATCH liburing v1 10/12] t/recv-msgall: Don't use a static port number Date: Fri, 2 Sep 2022 07:59:44 +0700 Message-Id: <20220902005825.2484023-11-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220902005825.2484023-1-ammar.faizi@intel.com> References: <20220902005825.2484023-1-ammar.faizi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Ammar Faizi Don't use a static port number. It might already be in use, resulting in a test failure. Use an ephemeral port to make this test reliable. Cc: Dylan Yudaken Cc: Facebook Kernel Team Cc: Pavel Begunkov Signed-off-by: Ammar Faizi --- test/recv-msgall.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/recv-msgall.c b/test/recv-msgall.c index a6f7cfc..ae123e4 100644 --- a/test/recv-msgall.c +++ b/test/recv-msgall.c @@ -6,57 +6,55 @@ #include #include #include #include #include #include #include #include =20 #include "liburing.h" #include "helpers.h" =20 #define MAX_MSG 128 - -#define PORT 10201 #define HOST "127.0.0.1" +static __be16 bind_port; =20 static int recv_prep(struct io_uring *ring, struct iovec *iov, int *sock, int use_recvmsg) { struct sockaddr_in saddr; struct io_uring_sqe *sqe; int sockfd, ret, val; struct msghdr msg =3D { }; =20 memset(&saddr, 0, sizeof(saddr)); saddr.sin_family =3D AF_INET; saddr.sin_addr.s_addr =3D htonl(INADDR_ANY); - saddr.sin_port =3D htons(PORT); =20 sockfd =3D socket(AF_INET, SOCK_DGRAM, 0); if (sockfd < 0) { perror("socket"); return 1; } =20 val =3D 1; setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)); =20 - ret =3D bind(sockfd, (struct sockaddr *)&saddr, sizeof(saddr)); - if (ret < 0) { + if (t_bind_ephemeral_port(sockfd, &saddr)) { perror("bind"); goto err; } + bind_port =3D saddr.sin_port; =20 sqe =3D io_uring_get_sqe(ring); if (!use_recvmsg) { io_uring_prep_recv(sqe, sockfd, iov->iov_base, iov->iov_len, MSG_WAITALL); } else { msg.msg_namelen =3D sizeof(struct sockaddr_in); msg.msg_iov =3D iov; msg.msg_iovlen =3D 1; io_uring_prep_recvmsg(sqe, sockfd, &msg, MSG_WAITALL); } =20 sqe->user_data =3D 2; @@ -155,27 +153,27 @@ static int do_send(void) =20 ret =3D io_uring_queue_init(2, &ring, 0); if (ret) { fprintf(stderr, "queue init failed: %d\n", ret); return 1; } =20 buf =3D malloc(MAX_MSG * sizeof(int)); for (i =3D 0; i < MAX_MSG; i++) buf[i] =3D i; =20 memset(&saddr, 0, sizeof(saddr)); saddr.sin_family =3D AF_INET; - saddr.sin_port =3D htons(PORT); + saddr.sin_port =3D bind_port; inet_pton(AF_INET, HOST, &saddr.sin_addr); =20 sockfd =3D socket(AF_INET, SOCK_DGRAM, 0); if (sockfd < 0) { perror("socket"); return 1; } =20 ret =3D connect(sockfd, (struct sockaddr *)&saddr, sizeof(saddr)); if (ret < 0) { perror("connect"); return 1; } --=20 Ammar Faizi