From nobody Mon Apr 6 23:12:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BECECAAD1 for ; Thu, 1 Sep 2022 10:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233342AbiIAK24 (ORCPT ); Thu, 1 Sep 2022 06:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234044AbiIAK2h (ORCPT ); Thu, 1 Sep 2022 06:28:37 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58FED27B16 for ; Thu, 1 Sep 2022 03:28:36 -0700 (PDT) Received: from localhost.localdomain (unknown [83.149.199.65]) by mail.ispras.ru (Postfix) with ESMTPSA id E5B9B40D403D; Thu, 1 Sep 2022 10:28:31 +0000 (UTC) From: Valentina Goncharenko To: Jaroslav Kysela Cc: Valentina Goncharenko , Takashi Iwai , Eliot Blennerhassett , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak() Date: Thu, 1 Sep 2022 13:28:14 +0300 Message-Id: <20220901102814.131855-1-goncharenko.vp@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The hpi_meter_get_peak() function contains the expression "hm.obj_index =3D hm.obj_index", which does not carry any semantic load. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards") Signed-off-by: Valentina Goncharenko --- sound/pci/asihpi/hpifunc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c index 1de05383126a..24047fafef51 100644 --- a/sound/pci/asihpi/hpifunc.c +++ b/sound/pci/asihpi/hpifunc.c @@ -2020,7 +2020,6 @@ u16 hpi_meter_get_peak(u32 h_control, short an_peakdB= [HPI_MAX_CHANNELS] HPI_CONTROL_GET_STATE); if (hpi_handle_indexes(h_control, &hm.adapter_index, &hm.obj_index)) return HPI_ERROR_INVALID_HANDLE; - hm.obj_index =3D hm.obj_index; hm.u.c.attribute =3D HPI_METER_PEAK; =20 hpi_send_recv(&hm, &hr); --=20 2.25.1