From nobody Mon Apr 6 23:12:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528B3ECAAD3 for ; Thu, 1 Sep 2022 07:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233222AbiIAHr6 (ORCPT ); Thu, 1 Sep 2022 03:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233399AbiIAHrQ (ORCPT ); Thu, 1 Sep 2022 03:47:16 -0400 Received: from cstnet.cn (smtp23.cstnet.cn [159.226.251.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E6BA213F81 for ; Thu, 1 Sep 2022 00:45:29 -0700 (PDT) Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-03 (Coremail) with SMTP id rQCowABnyHETYxBjIoMgAA--.64009S2; Thu, 01 Sep 2022 15:45:24 +0800 (CST) From: Jiasheng Jiang To: hdegoede@redhat.com, arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] virt: vbox: Add check for device_create_file Date: Thu, 1 Sep 2022 15:45:21 +0800 Message-Id: <20220901074521.3448337-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowABnyHETYxBjIoMgAA--.64009S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CFWxGw1ruF1DuF1fGw1kuFg_yoW8Jw18pF 47Ca4ay3yFgw4jgw47ta4qqFyYgrWxt397urWxAw1rWr97A39YvFWDGayUZrZ8ZFZ5GF1r Xw1Utr1rCa1UWFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyC14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxG rwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4 vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IY x2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26c xKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7Cj xVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUywZ7UUUUU= X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" As device_create_file() can return error number, it should be better to check the return value and deal with the exception. Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest inte= gration") Signed-off-by: Jiasheng Jiang --- drivers/virt/vboxguest/vboxguest_linux.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxgu= est/vboxguest_linux.c index 4ccfd30c2a30..0fee8e6ee6e0 100644 --- a/drivers/virt/vboxguest/vboxguest_linux.c +++ b/drivers/virt/vboxguest/vboxguest_linux.c @@ -390,8 +390,13 @@ static int vbg_pci_probe(struct pci_dev *pci, const st= ruct pci_device_id *id) } =20 pci_set_drvdata(pci, gdev); - device_create_file(dev, &dev_attr_host_version); - device_create_file(dev, &dev_attr_host_features); + + ret =3D device_create_file(dev, &dev_attr_host_version); + if (ret) + goto err_unregister_misc_device_user; + ret =3D device_create_file(dev, &dev_attr_host_features); + if (ret) + goto err_unregister_misc_device_user; =20 vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %= pap (size %pap)\n", gdev->misc_device.minor, pci->irq, gdev->io_port, --=20 2.25.1