From nobody Tue Apr 7 05:43:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B80ECAAD4 for ; Wed, 31 Aug 2022 00:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231236AbiHaABJ (ORCPT ); Tue, 30 Aug 2022 20:01:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230241AbiHaAA7 (ORCPT ); Tue, 30 Aug 2022 20:00:59 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03061696CD for ; Tue, 30 Aug 2022 17:00:58 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id s129-20020a625e87000000b005383388a6bcso3079394pfb.2 for ; Tue, 30 Aug 2022 17:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc; bh=HjUp0+XGX7I9pp1rwUfEKS1ZQ3tXMZ53vYRIKHPszec=; b=PlaHhbkkfyCu7zAcx6wxZJlKMNEW34EZejuQEmTlmm/CP0cfEaYlGWVW+MWr/AV5on +9Oyj7XiMxBnejeGsablgXp8wfcg9qHu0UoKA058ojeBK+tKlHXp5uOdm2nzdaVIAlkt 2+CWPToHxPAWcYeDdq2V9cI9MgjzEH0ius2XrFiohVZ963FjaSoIpPJqZd3VmFtjfF29 chObz/FQ32Ff+LwhplTN6N3SGyVJ8lIYqgyvMJwaLy2XwGiwsgaF6S4MbLVAUlNrrw4y Fcrlrhgl8ECpYQ4nCCju3y6RtZmxmBo0N9OAgbLJaX1X/LR3yXURMLUeaNG4vwr5lp4Y Eieg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc; bh=HjUp0+XGX7I9pp1rwUfEKS1ZQ3tXMZ53vYRIKHPszec=; b=pXzVOYcu3N4GE03FUhhIY2K+jt/G7INvEj2GzvMU8YVAN+bLag0lRxD2ssgA3rd2MC JhyiKl2AbW0zws61f4bzDgkjeEniA3LPgEQfsmx4xYbxkqRMX9I1L4rCXgOLmX9DisUu gc3l0wh/cMc20DdRvS6pscHukl0pUY9zoNOctH9ixN3gcSDMqeMRngXk3KPFHm5p5gmE 98IKLLzv1jAws9qypP58vMa5VP9dkSjM6mE+i6sXSEkHHZ0r9jfDARJd9pLOCc0YOAL0 mpGcnsXoQeQzPckxd8oK1BWu/VY9gYpYPxH2CukEqpnkWewYmnr5UK35aeFLvmxj1PK6 y1Vg== X-Gm-Message-State: ACgBeo3Voo6Z1i6ZuFXKbAOs5T8f98SGXauJvCclDtXWkZfqExNkw+kZ 5s7n9C5M3hf2OcHUud9QZDzH4KgjcZU= X-Google-Smtp-Source: AA6agR4bzFoFtOfSYApxa64iuwbXdswW+XlYkRQHFxA89Xel0/yW91r0PpgxrKN76mN32s9Iu5kl3UX2uEU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:aa7:8882:0:b0:52f:1ead:2c21 with SMTP id z2-20020aa78882000000b0052f1ead2c21mr23652721pfe.15.1661904057468; Tue, 30 Aug 2022 17:00:57 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 31 Aug 2022 00:00:50 +0000 In-Reply-To: <20220831000051.4015031-1-seanjc@google.com> Mime-Version: 1.0 References: <20220831000051.4015031-1-seanjc@google.com> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog Message-ID: <20220831000051.4015031-3-seanjc@google.com> Subject: [PATCH v3 2/3] perf/x86/core: Drop the unnecessary return value from x86_perf_get_lbr() From: Sean Christopherson To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Sean Christopherson , Paolo Bonzini Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Like Xu Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the return value from x86_perf_get_lbr() now that there's no stub, i.e. now that success is guaranteed (which is a bit of a lie since success was always guaranteed, it's just more obvious now). Signed-off-by: Sean Christopherson --- arch/x86/events/intel/lbr.c | 6 +----- arch/x86/include/asm/perf_event.h | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c index 4f70fb6c2c1e..b8ad31c52cf0 100644 --- a/arch/x86/events/intel/lbr.c +++ b/arch/x86/events/intel/lbr.c @@ -1868,10 +1868,8 @@ void __init intel_pmu_arch_lbr_init(void) * x86_perf_get_lbr - get the LBR records information * * @lbr: the caller's memory to store the LBR records information - * - * Returns: 0 indicates the LBR info has been successfully obtained */ -int x86_perf_get_lbr(struct x86_pmu_lbr *lbr) +void x86_perf_get_lbr(struct x86_pmu_lbr *lbr) { int lbr_fmt =3D x86_pmu.intel_cap.lbr_format; =20 @@ -1879,8 +1877,6 @@ int x86_perf_get_lbr(struct x86_pmu_lbr *lbr) lbr->from =3D x86_pmu.lbr_from; lbr->to =3D x86_pmu.lbr_to; lbr->info =3D (lbr_fmt =3D=3D LBR_FORMAT_INFO) ? x86_pmu.lbr_info : 0; - - return 0; } EXPORT_SYMBOL_GPL(x86_perf_get_lbr); =20 diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_= event.h index f839eb55f298..f6d9230cdfab 100644 --- a/arch/x86/include/asm/perf_event.h +++ b/arch/x86/include/asm/perf_event.h @@ -528,7 +528,7 @@ extern int x86_perf_rdpmc_index(struct perf_event *even= t); =20 #ifdef CONFIG_CPU_SUP_INTEL extern struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr, void *da= ta); -extern int x86_perf_get_lbr(struct x86_pmu_lbr *lbr); +extern void x86_perf_get_lbr(struct x86_pmu_lbr *lbr); extern void intel_pt_handle_vmx(int on); #endif /* CONFIG_CPU_SUP_INTEL */ =20 --=20 2.37.2.672.g94769d06f0-goog