From nobody Tue Apr 7 05:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AE9ECAAA1 for ; Tue, 30 Aug 2022 22:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbiH3W6n (ORCPT ); Tue, 30 Aug 2022 18:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbiH3W6g (ORCPT ); Tue, 30 Aug 2022 18:58:36 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0D237D7BB for ; Tue, 30 Aug 2022 15:58:34 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id x23so12511090pll.7 for ; Tue, 30 Aug 2022 15:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=k6LA1rNyhTjjcasNmZFLeY+W8E8y8NGMThT486iHSoY=; b=Ep24sHO070cnIFiiLG6kNJPWDqR2eSE+4qF+qy1Dpph5f6mj79zWGMf3QxdFk/MnWf S5NN4Jf7V/9x14Ed4VoZUnHArb2dtaW8KqL3LDsl17cTZoAmeNNJHhe90BGX5qkR34Gd UEfG8SF4TaeCxXk2M0BoSMAIfW2qddG9ZcM7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=k6LA1rNyhTjjcasNmZFLeY+W8E8y8NGMThT486iHSoY=; b=JlDuU9TtD5Prfb7UhmmoeyJi2xyFtur4v3WOHrJn9+6QlTD/BEvLM0njZn4IHqqBTx tqSPJJr+BR3KEPFskuZUkmjxQjhPwm9Bddsi2Bp+E/DXK4p62M4ZoHvVZYsLDVD0uKEN bH4/UFGm6nxTvijDnsrh0Gq01YPdHgynDAKHpj2R3qk4iCLjMrYPT/yQoTZaWcsVwvWs aLoYO3LkU4ziz6D6jCdzNYSxLqSPCiLNvZMR1qbgj+EdpE2sLJm9XTjbg4G7WP1chGFf Oerf8baX2LHv1KQE8u770ud3uKPmrTOI8boK/zjzDCLHMmVBcRza0zEZgAZ9ztG6IAZk rDOg== X-Gm-Message-State: ACgBeo1Y6MBLpBYl/dlWH9n3JAALqfIObmMapTWeXFKJCUzJK/et+LhL A5eHG6/tD30wHYEX3zykF1Ngbw== X-Google-Smtp-Source: AA6agR6soIRzWhUs7dOLjwua1oVBUDAFDTUzVhZQra4bxTiH3oROVieLZEHDWGIr1KvJ5tedIvAXHw== X-Received: by 2002:a17:90a:f2cb:b0:1fd:90a0:56e3 with SMTP id gt11-20020a17090af2cb00b001fd90a056e3mr269959pjb.113.1661900314469; Tue, 30 Aug 2022 15:58:34 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5f34:2f6:2856:188e]) by smtp.gmail.com with ESMTPSA id bf3-20020a170902b90300b001743be790b4sm10083539plb.215.2022.08.30.15.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 15:58:34 -0700 (PDT) From: Stephen Boyd To: Prashant Malani , Benson Leung Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Tzung-Bi Shih Subject: [PATCH 1/4] platform/chrome: cros_typec_switch: Add missing newline on printk Date: Tue, 30 Aug 2022 15:58:28 -0700 Message-Id: <20220830225831.2362403-2-swboyd@chromium.org> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220830225831.2362403-1-swboyd@chromium.org> References: <20220830225831.2362403-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We need a newline here to ensure the next printk starts fresh. Cc: Prashant Malani Cc: Tzung-Bi Shih Fixes: affc804c44c8 ("platform/chrome: cros_typec_switch: Add switch driver= ") Signed-off-by: Stephen Boyd Acked-by: Prashant Malani --- drivers/platform/chrome/cros_typec_switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform= /chrome/cros_typec_switch.c index f85687adb594..383daf2c66b7 100644 --- a/drivers/platform/chrome/cros_typec_switch.c +++ b/drivers/platform/chrome/cros_typec_switch.c @@ -244,7 +244,7 @@ static int cros_typec_register_switches(struct cros_typ= ec_switch_data *sdata) } =20 if (index < 0 || index >=3D EC_USB_PD_MAX_PORTS) { - dev_err(fwnode->dev, "Invalid port index number: %llu", index); + dev_err(fwnode->dev, "Invalid port index number: %llu\n", index); ret =3D -EINVAL; goto err_switch; } --=20 https://chromeos.dev From nobody Tue Apr 7 05:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA29ECAAD4 for ; Tue, 30 Aug 2022 22:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiH3W6s (ORCPT ); Tue, 30 Aug 2022 18:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbiH3W6g (ORCPT ); Tue, 30 Aug 2022 18:58:36 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91418982C for ; Tue, 30 Aug 2022 15:58:35 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id j9-20020a17090a3e0900b001fd9568b117so9659005pjc.3 for ; Tue, 30 Aug 2022 15:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=HwGs98rx5BCd9/rgNaN7+8SbaVUbF2hiZY4CVcaNvm4=; b=eB3MC0Tad/kB+uoOqsolA2dlwF8ySo8h9JTtZjitG+Gquo+Dyd6U0wXrnhlI9wf5fq JlVczQudCM5itV8dzFwRom6m3cIaoIo5oy2Ux5geWqHMWOZtyA6kqkxgfBqQeedxrt6u bi0PcJIDVpLWQgfcc1QRNrVY0jqV+m7v4XbbU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=HwGs98rx5BCd9/rgNaN7+8SbaVUbF2hiZY4CVcaNvm4=; b=iIj8YU0nk5qd9UO09wTrIOvPWPS6g4H6sa8pINVQaE9gARP7FrS2n3alFwfaVVwRz7 ZVMg8cmSvSFcs4u8PyU289BGaomGMplRFOtSCv/+oz8AWl87fLAidAkhIawcwVGsLJ+i i/o/bRdrmCPLXlTGrJmnoId0NReqyP0AUtE2zvImTtrQDVOQXi0KXyY8KjN/Hwmyhijw /5BTzLtROeZlYIeNv1W8KdGmrQZ+U/8Ku/Ep+YUc2k60IbXE2CYPv8DBMfmiH5VNdMIw wypW6AVCx2XCKvd5pXPDYpXa03OaL0w/Gf6Ppf9WhHBkJVlBOP6dkVWS8OJ67LWaL7AF 1K0w== X-Gm-Message-State: ACgBeo1glrwzehaQ90lT0kN+Flqk+3EydeGxSsNJW+wM1hIrFAQgOP7V /NzSupcNgazvJNe5QrBwvtB90g== X-Google-Smtp-Source: AA6agR45HAcVMAFaGvKD+VuQ2Xa/q4B6SQ6eo25+pm9MGhFjmFQmLdcpsmWTCIr9hw1VRWyt+jKH8Q== X-Received: by 2002:a17:90b:4b48:b0:1fd:d2cd:896c with SMTP id mi8-20020a17090b4b4800b001fdd2cd896cmr296743pjb.120.1661900315349; Tue, 30 Aug 2022 15:58:35 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5f34:2f6:2856:188e]) by smtp.gmail.com with ESMTPSA id bf3-20020a170902b90300b001743be790b4sm10083539plb.215.2022.08.30.15.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 15:58:35 -0700 (PDT) From: Stephen Boyd To: Prashant Malani , Benson Leung Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Tzung-Bi Shih Subject: [PATCH 2/4] platform/chrome: cros_typec_switch: Remove impossible condition Date: Tue, 30 Aug 2022 15:58:29 -0700 Message-Id: <20220830225831.2362403-3-swboyd@chromium.org> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220830225831.2362403-1-swboyd@chromium.org> References: <20220830225831.2362403-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The type of 'index' is unsigned long long, which can't possibly be less than zero. Remove the impossible check. Cc: Prashant Malani Cc: Tzung-Bi Shih Signed-off-by: Stephen Boyd Acked-by: Prashant Malani --- drivers/platform/chrome/cros_typec_switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform= /chrome/cros_typec_switch.c index 383daf2c66b7..3381d842c307 100644 --- a/drivers/platform/chrome/cros_typec_switch.c +++ b/drivers/platform/chrome/cros_typec_switch.c @@ -243,7 +243,7 @@ static int cros_typec_register_switches(struct cros_typ= ec_switch_data *sdata) goto err_switch; } =20 - if (index < 0 || index >=3D EC_USB_PD_MAX_PORTS) { + if (index >=3D EC_USB_PD_MAX_PORTS) { dev_err(fwnode->dev, "Invalid port index number: %llu\n", index); ret =3D -EINVAL; goto err_switch; --=20 https://chromeos.dev From nobody Tue Apr 7 05:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E2AECAAA1 for ; Tue, 30 Aug 2022 22:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbiH3W6v (ORCPT ); Tue, 30 Aug 2022 18:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231481AbiH3W6h (ORCPT ); Tue, 30 Aug 2022 18:58:37 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0017D7BB for ; Tue, 30 Aug 2022 15:58:36 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id o4so12504311pjp.4 for ; Tue, 30 Aug 2022 15:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=WK5uBdkvj+rzMOTx0eBPWRcJ3NkDpCrdfS9GYKxjc4Q=; b=K/Dv61fWG2RK5uP019ajuvWGOsaYy/JwPd+i+ycqaCclO2jktpeGBCOdGEJwue7Svf LFuue3Jw2/IhLPZzIDc+oSEoPyjT7Vv75KikMIlx3sZGkKcI1jfYCdnz+tXgxvZaTRUz mdDnW/OVw+tIn2VPx14agQ4ltazeNCRbuECis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=WK5uBdkvj+rzMOTx0eBPWRcJ3NkDpCrdfS9GYKxjc4Q=; b=3P39/wlrHxuBZtGt8JhWnfqTo5pgdeJLu/DmBX1pJcv0PoOAIgTp+d68HsPfqTTZFU BlpIPeEygpdLZBGoFKJl0cLuuWtXpikCzHRrTrlmKZsW+T0EdMUW19YdLJCrlj8Jiu7m Af0uaZV3YNAPSFWIhqmzw6fLY32IsAwYr4aFO+qvnbxIOGRk5zmNKFUbbQyjEbEpuI13 0Xvv/sWIrpfUVwcseg9M7VWcFs89o+FlxFxEFfoxbk/+47/Wj/8TtgIIkysqiVGxRmML u5rThHqiJn5MlNZaClkREP4xWl3jXO0k3SCOPoXH0ifCYVgvuHVanAJFlRbqi/M6sCim KJpQ== X-Gm-Message-State: ACgBeo1iY3xfMonAjTgyJOc2UtJN/x1ZWsxeq6hqgYM+EFPW7oepjDij +GUTpjldn14n3D9wTPtypLrizQ== X-Google-Smtp-Source: AA6agR5BwgwGGR8CVgQETFRT37ajSM4Zq99RJV+txl3EQeraAhpPRS7nmypBzKJjaJBmUzqCHE10CA== X-Received: by 2002:a17:902:8f87:b0:172:83b5:d771 with SMTP id z7-20020a1709028f8700b0017283b5d771mr23053534plo.159.1661900316268; Tue, 30 Aug 2022 15:58:36 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5f34:2f6:2856:188e]) by smtp.gmail.com with ESMTPSA id bf3-20020a170902b90300b001743be790b4sm10083539plb.215.2022.08.30.15.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 15:58:35 -0700 (PDT) From: Stephen Boyd To: Prashant Malani , Benson Leung Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Tzung-Bi Shih Subject: [PATCH 3/4] platform/chrome: cros_typec_switch: Use PTR_ERR_OR_ZERO() to simplify Date: Tue, 30 Aug 2022 15:58:30 -0700 Message-Id: <20220830225831.2362403-4-swboyd@chromium.org> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220830225831.2362403-1-swboyd@chromium.org> References: <20220830225831.2362403-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use the standard error pointer macro to shorten the code and simplify. Cc: Prashant Malani Cc: Tzung-Bi Shih Signed-off-by: Stephen Boyd Acked-by: Prashant Malani --- drivers/platform/chrome/cros_typec_switch.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform= /chrome/cros_typec_switch.c index 3381d842c307..09ad0d268f4b 100644 --- a/drivers/platform/chrome/cros_typec_switch.c +++ b/drivers/platform/chrome/cros_typec_switch.c @@ -185,10 +185,8 @@ static int cros_typec_register_mode_switch(struct cros= _typec_port *port, }; =20 port->mode_switch =3D typec_mux_register(port->sdata->dev, &mode_switch_d= esc); - if (IS_ERR(port->mode_switch)) - return PTR_ERR(port->mode_switch); =20 - return 0; + return PTR_ERR_OR_ZERO(port->mode_switch); } =20 static int cros_typec_register_retimer(struct cros_typec_port *port, struc= t fwnode_handle *fwnode) @@ -201,10 +199,8 @@ static int cros_typec_register_retimer(struct cros_typ= ec_port *port, struct fwno }; =20 port->retimer =3D typec_retimer_register(port->sdata->dev, &retimer_desc); - if (IS_ERR(port->retimer)) - return PTR_ERR(port->retimer); =20 - return 0; + return PTR_ERR_OR_ZERO(port->retimer); } =20 static int cros_typec_register_switches(struct cros_typec_switch_data *sda= ta) --=20 https://chromeos.dev From nobody Tue Apr 7 05:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5325ECAAD4 for ; Tue, 30 Aug 2022 22:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231684AbiH3W6z (ORCPT ); Tue, 30 Aug 2022 18:58:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231528AbiH3W6i (ORCPT ); Tue, 30 Aug 2022 18:58:38 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97BAA82F8E for ; Tue, 30 Aug 2022 15:58:37 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id y1so10650359plb.2 for ; Tue, 30 Aug 2022 15:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=9i6pUjJNJbv0URDTN17d2CcuUvvkFRJoPPsB0ChrC84=; b=K2J5xRAk/tKVnjvdGCtwzZC/znuGdEUztUB2UHn4wXft/46xq8gyf0Ddl57gL2NETG M0vOBzYECWvKK4hidx1uBJNXH2NsR9pGU3zcm1+sXOa9rrbJrvaKTah1s9gjtU1As/XQ +GhjBJOLmxYXJbLlpGP3ExvkBiOw6dPva01r4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=9i6pUjJNJbv0URDTN17d2CcuUvvkFRJoPPsB0ChrC84=; b=XUHt/w+2jZj6J+XIsfjcyjYDihAZAWi8w20OaH7WEHD71Wax6GqwIFUgZFFxTvzPi5 3sPs7/zLI0JFO1CtUmynOdscrDNNDnBy51h1VjuMQopi3Q0WAfegUGWPr3e99au5+/Ps BlNPIsDUmeAJKWVxgRa7GDXDNusLKi36bSU7pw+vEAEIae4x8wbFTONI1t+gZ3tGT0es poWPXzA+geeI9OcwtqaKh6cvmrQ6qAnddqE30bcKjJCoTN16fL9jtbNtQl6hLQrUSQs5 urRk8vxr9BvgTqt1JqKBtSfuPqoDssGBrxO2r5UuMhIwzDMTxAJ0y+X/vaqrEeo5Zzpg hozg== X-Gm-Message-State: ACgBeo0nxGCAC/KtLVp8TX1Da/XYEc6XRIU1br+gu92RBWfTSgr2CUZG mgURD6LCSIBVeEcwf+GYLtlsSw== X-Google-Smtp-Source: AA6agR6wm6nWs+6nAf9TZDvola8E8ygfG4X7jJS1hsOIaTMHd8b0kiBAbmAJLdFsGBuzT3sT26/VrA== X-Received: by 2002:a17:90b:4d8f:b0:1fc:314a:17e7 with SMTP id oj15-20020a17090b4d8f00b001fc314a17e7mr284377pjb.194.1661900317130; Tue, 30 Aug 2022 15:58:37 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5f34:2f6:2856:188e]) by smtp.gmail.com with ESMTPSA id bf3-20020a170902b90300b001743be790b4sm10083539plb.215.2022.08.30.15.58.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 15:58:36 -0700 (PDT) From: Stephen Boyd To: Prashant Malani , Benson Leung Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Tzung-Bi Shih Subject: [PATCH 4/4] platform/chrome: cros_typec_switch: Inline DRV_NAME Date: Tue, 30 Aug 2022 15:58:31 -0700 Message-Id: <20220830225831.2362403-5-swboyd@chromium.org> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220830225831.2362403-1-swboyd@chromium.org> References: <20220830225831.2362403-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This macro is only used one place, let's inline it instead to save a line or two. Cc: Prashant Malani Cc: Tzung-Bi Shih Signed-off-by: Stephen Boyd Acked-by: Prashant Malani --- drivers/platform/chrome/cros_typec_switch.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform= /chrome/cros_typec_switch.c index 09ad0d268f4b..a26219e97c93 100644 --- a/drivers/platform/chrome/cros_typec_switch.c +++ b/drivers/platform/chrome/cros_typec_switch.c @@ -18,8 +18,6 @@ #include #include =20 -#define DRV_NAME "cros-typec-switch" - /* Handles and other relevant data required for each port's switches. */ struct cros_typec_port { int port_num; @@ -309,7 +307,7 @@ MODULE_DEVICE_TABLE(acpi, cros_typec_switch_acpi_id); =20 static struct platform_driver cros_typec_switch_driver =3D { .driver =3D { - .name =3D DRV_NAME, + .name =3D "cros-typec-switch", .acpi_match_table =3D ACPI_PTR(cros_typec_switch_acpi_id), }, .probe =3D cros_typec_switch_probe, --=20 https://chromeos.dev