From nobody Tue Apr 7 04:35:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5ACBC0502C for ; Tue, 30 Aug 2022 19:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230517AbiH3Thy (ORCPT ); Tue, 30 Aug 2022 15:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbiH3Thw (ORCPT ); Tue, 30 Aug 2022 15:37:52 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC56661B1A; Tue, 30 Aug 2022 12:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=L6awvjwg9m446Cc0NaY17Ohs5TKfbD/iLDd614/eBJE=; b=bTem0HI6OUZpSypgfJGXXqd3Y3 7CowSAzXAEMztBafjK2JmKBKy3Kjah5mOEElJ56pmPZTYS7/k2hTxfgWgQLyhBfyObkxINL13UaF4 KCYlaNiNDChZwrHorCdrEeKlBDtoe0Rhlr/vOw1Wcu3MSX+HLlV8/+t9pCs+Ra2enI8EW1IzKdIcH ihiKGiU4ch5fyPXkI7EnfcEIZXhfwEoCttFmpY3OMkLUnrIx58uw6fwiwAnGf+s0271TKv+GmONO4 MgPfaOX4pnNtxobp6Lxx08zz3ayPPlQqs9muBEhJEo57T+4iSulrZWGnXytB36Q7zaa8x9sglFkmN GvlduvLw==; Received: from [2601:1c0:6280:3f0::a6b3] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oT73R-004Ms3-8y; Tue, 30 Aug 2022 19:37:46 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Igor Zhbanov , "David S. Miller" , sparclinux@vger.kernel.org, Dan Carpenter , Nick Alcock , Sam Ravnborg , Andrew Morton , stable@vger.kernel.org Subject: [PATCH v3] sparc: vDSO: fix return value of __setup handler Date: Tue, 30 Aug 2022 12:37:38 -0700 Message-Id: <20220830193738.27802-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" __setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) argument or environment strings. Also, error return codes don't mean anything to obsolete_checksetup() -- only non-zero (usually 1) or zero. So return 1 from vdso_setup(). Fixes: 9a08862a5d2e ("vDSO for sparc") Signed-off-by: Randy Dunlap Reported-by: Igor Zhbanov Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru Cc: "David S. Miller" Cc: sparclinux@vger.kernel.org Cc: Dan Carpenter Cc: Nick Alcock Cc: Sam Ravnborg Cc: Andrew Morton Cc: stable@vger.kernel.org --- v2: correct the Fixes: tag (Dan Carpenter) v3: add more Cc's; correct Igor's email address; change From: Igor to Reported-by: Igor; arch/sparc/vdso/vma.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/arch/sparc/vdso/vma.c +++ b/arch/sparc/vdso/vma.c @@ -449,9 +449,8 @@ static __init int vdso_setup(char *s) unsigned long val; =20 err =3D kstrtoul(s, 10, &val); - if (err) - return err; - vdso_enabled =3D val; - return 0; + if (!err) + vdso_enabled =3D val; + return 1; } __setup("vdso=3D", vdso_setup);