From nobody Thu Apr 9 12:50:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBDA2ECAAD5 for ; Mon, 29 Aug 2022 16:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbiH2Qu1 (ORCPT ); Mon, 29 Aug 2022 12:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiH2QuS (ORCPT ); Mon, 29 Aug 2022 12:50:18 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DCF657207 for ; Mon, 29 Aug 2022 09:50:17 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id p18so8556512plr.8 for ; Mon, 29 Aug 2022 09:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=/JqFRsfWc9SAzvod+scKS9vCJ/82zulusd10VvDyv/U=; b=k/bSbr13oFJgDwbXV7O3MysZvt1jGmJvRITnPBuHM+KO0HO0Yn5/m8e7G0rDhxcUdu MbdpxQLMOwIIfw16H0JoOhRnRkcROUuSgg9K9+WXlJj2oZGV9nq+r6Ex4eYUJGv/jKoD 3FlrMucgfLYmWwcz4I+KgVkTdLIMjw7pArRso= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=/JqFRsfWc9SAzvod+scKS9vCJ/82zulusd10VvDyv/U=; b=NC6dyolO2Y0Lp6EKfy60ewTvCybmjr9d+la9up1ugXDm5vkW098Dw+K9FxVBoxDYaM 546KlCJhQlZJ2pF7boCRejs31OoCrj0RI4tCDP7DLxvBXLwbESN0LxZSKGDeFFtXXnhp SYcsn6BzUAN6FxPiug1E3wI8BSxeka/xSUJAYY+NWGpWHOtNZf30BPuw8jnAKVDWE5gk ziq+sigXqqrVdPV8Kl5ln9MmNpQ/zrLTH/FsUADHYMBsQgE7qcTy4+nc99pMqqQHIbmd 7SGdCDWb776UCjBfbxMm8A0k+rF0/Q4Nt/rZIeByUu3Ls5lBEfKHTwwwDT71BFMM5kI9 cO6w== X-Gm-Message-State: ACgBeo2pgdFKHmmXlsGugTKJZ7f52QHliYdxbw8rXG3VUW2gl67caat7 UKqVYLFn/127ijBZPGA9Sin0HA== X-Google-Smtp-Source: AA6agR6a+oYSlVo22PUDaC+EZo/UuSwM2itcan9ouOvKUC3GSZN8+L4ll/q2sZeyrbhRfXBY2PqbIQ== X-Received: by 2002:a17:90b:4f4e:b0:1f5:8a65:9192 with SMTP id pj14-20020a17090b4f4e00b001f58a659192mr18973833pjb.224.1661791816976; Mon, 29 Aug 2022 09:50:16 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:16 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , Bhupesh Sharma , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/6] arm64: dts: qcom: sa8155p-adp: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:47 -0700 Message-Id: <20220829094903.v2.1.Id59c32b560c4662d8b3697de2bd494d08d654806@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. NOTE: while here, let's also remove the nonsensical "regulator-allow-set-load" on the fixed regulator "vreg_s4a_1p8". [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c672= 08fa9edda4a08847c304@changeid Fixes: 5b85e8f2225c ("arm64: dts: qcom: sa8155p-adp: Add base dts file") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- Changes in v2: - Added note about removing regulator-allow-set-load from vreg_s4a_1p8 arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts= /qcom/sa8155p-adp.dts index ba547ca9fc6b..ddb9cb182152 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -43,7 +43,6 @@ vreg_s4a_1p8: smps4 { =20 regulator-always-on; regulator-boot-on; - regulator-allow-set-load; =20 vin-supply =3D <&vreg_3p3>; }; @@ -137,6 +136,9 @@ vreg_l5a_0p88: ldo5 { regulator-max-microvolt =3D <880000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l7a_1p8: ldo7 { @@ -152,6 +154,9 @@ vreg_l10a_2p96: ldo10 { regulator-max-microvolt =3D <2960000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l11a_0p8: ldo11 { @@ -258,6 +263,9 @@ vreg_l5c_1p2: ldo5 { regulator-max-microvolt =3D <1200000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l7c_1p8: ldo7 { @@ -273,6 +281,9 @@ vreg_l8c_1p2: ldo8 { regulator-max-microvolt =3D <1200000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l10c_3p3: ldo10 { --=20 2.37.2.672.g94769d06f0-goog From nobody Thu Apr 9 12:50:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 578E3ECAAD2 for ; Mon, 29 Aug 2022 16:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbiH2Quh (ORCPT ); Mon, 29 Aug 2022 12:50:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbiH2QuU (ORCPT ); Mon, 29 Aug 2022 12:50:20 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A854DF1E for ; Mon, 29 Aug 2022 09:50:19 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id f4so8183521pgc.12 for ; Mon, 29 Aug 2022 09:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=9W9NsQUbz7AavjIDVz3BLDZG1GcuJCI43e/2DHtW2Y0=; b=ht5+HjIYWz4mvtqaU4uf/mWFrg2hKAMlh6K/v8r52ZJa0oOrP2weoPFbV0SZ/SObnt ywW0rBWAxRY4FXH1FpwW/w+MR02Ff5J0c760h6rOEUMqnTULT6DtgO5/cT+wm3GsXSV0 hMr5LnIxgHq7KS1O/iXKj4zPRW3vNoZ/xECRE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=9W9NsQUbz7AavjIDVz3BLDZG1GcuJCI43e/2DHtW2Y0=; b=bGaysDtTBwNBGEMg7xyDAiGjsCukMBxXbY12GYjLePAxjL9leyMDR3pJKYJhlL4/Rs 0i8mSe1p5Ujj8Tm/gXYsG3TGdOjbNbw9e17ih3KERSOfivkrz6GqQIQkksp+PKSDk9Nw DAwwyXqOmJgCWbbblBwiAP3h19NGRK5ae6lb44npNbusDbNrFMFH50izbQ2VtpuHm0dV tOAvX9qHog6QHuPL3ZyU2bp4wOXXzLMU+3Qunp5FDvjXyaiHcERET9K2z7ag7cyiay38 0Po0EW6SVsjriLflJrbh1xu3E/ly3UPQaozvDFcn6mLgNYFjSSryKdUtZruHlDrBFU2e R74w== X-Gm-Message-State: ACgBeo3oanFbBIfV0HqN2qD7izdEXHwhJ8pFLnnsCRgCm+LDUwmIqO3A wngOQlxdij35nG1158iNf2b52g== X-Google-Smtp-Source: AA6agR5AqZJZaSTtizeBZ9ngSnj9GjAhvUxOaHQpix0O57qZk+CRLhrsw+lkhaf51mA7ZC5xypbA7A== X-Received: by 2002:a63:334f:0:b0:42b:15a6:826a with SMTP id z76-20020a63334f000000b0042b15a6826amr14486037pgz.14.1661791818594; Mon, 29 Aug 2022 09:50:18 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:18 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , Johan Hovold , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/6] arm64: dts: qcom: sa8295p-adp: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:48 -0700 Message-Id: <20220829094903.v2.2.I430a56702ab0af65244e62667bb7743107de0c96@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c672= 08fa9edda4a08847c304@changeid Fixes: 519183af39b2 ("arm64: dts: qcom: add SA8540P and ADP") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio Reviewed-by: Johan Hovold --- Changes in v2: - Rebased atop ("...: sa8295p-adp: disallow regulator mode switches") arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts= /qcom/sa8295p-adp.dts index ca5f5ad32ce5..5b16ac76fefb 100644 --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts @@ -83,6 +83,9 @@ vreg_l3c: ldo3 { regulator-max-microvolt =3D <1200000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l4c: ldo4 { @@ -98,6 +101,9 @@ vreg_l6c: ldo6 { regulator-max-microvolt =3D <1200000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l7c: ldo7 { @@ -113,6 +119,9 @@ vreg_l10c: ldo10 { regulator-max-microvolt =3D <2504000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l17c: ldo17 { @@ -121,6 +130,9 @@ vreg_l17c: ldo17 { regulator-max-microvolt =3D <2504000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; }; =20 --=20 2.37.2.672.g94769d06f0-goog From nobody Thu Apr 9 12:50:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BBE2C0502F for ; Mon, 29 Aug 2022 16:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbiH2Quz (ORCPT ); Mon, 29 Aug 2022 12:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbiH2QuX (ORCPT ); Mon, 29 Aug 2022 12:50:23 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB6BA61D5C for ; Mon, 29 Aug 2022 09:50:20 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id 72so8744900pfx.9 for ; Mon, 29 Aug 2022 09:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=19oJyst1cXhX6ExrR+4lzX9FM+Aou98SW9ohKM60LiE=; b=FdwePFKjyhAG2YJEV2p+eSvD9wAlfIXs+xt3A2gYuxH8ASej4TPnhf2V5z3S7jXTNY ymKKBFCJV+4lva7k6btjMrpOpWfBY+osD1B7gWEfaRXUKPjDRrX9E+A+5n/QmmJltPtJ dnFJrESa/htd5+ntnX+GgIVsuCWMi1ltmFcmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=19oJyst1cXhX6ExrR+4lzX9FM+Aou98SW9ohKM60LiE=; b=fCaiVtb3baW1uEbcvIM6jChFAzyB3m308Cpr3AqtkwyTA0DPmVReGSaorR43UAR+TW m6Yg6p1N1EGaZVac157fP7fKc3vz3cEEL4YVrY4shx9QVAocJLZSitDXEQtm1x6jYAgC +swh9lGTmNb2JJoZY/ld+V21bga48LK0+crchCbmtcswkO/bNLHpAXArTyCzlAWCeeJ7 O4wEJtFybvxhOdJMqX5dsvzkoLR2XzpXpiMRz2bkYRuILPUgmyeiPNZn2mzsAdiV7Quj QYWwvsya56ZIjG0GSFDsrAyD4b1qV2/wGL1tAibDznNktA7RylIHaIqFNBuz8XFiEtX+ vEtA== X-Gm-Message-State: ACgBeo1hs1YFDfK+So1NspQX4jR5+t9kFs19QYLcm64xTAb7BfAxL7PL 8b6fDqRP9clSjWs7qn2FlBdhBg== X-Google-Smtp-Source: AA6agR7wP/U/djs4TOG4BcQegSxHOfMHn/NiIKogfPKTanFruFSM5vbVqZ4vop+1Fm/kzKbn+eW8Ww== X-Received: by 2002:a63:40e:0:b0:42b:890d:594e with SMTP id 14-20020a63040e000000b0042b890d594emr11792368pge.331.1661791820217; Mon, 29 Aug 2022 09:50:20 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:19 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , Johan Hovold , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] arm64: dts: qcom: sc8280xp-crd: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:49 -0700 Message-Id: <20220829094903.v2.3.Ie7d2c50d2b42ef2d364f3a0c8e300e5ce1875b79@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c672= 08fa9edda4a08847c304@changeid Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio Reviewed-by: Johan Hovold --- Changes in v2: - Rebased atop ("...: sc8280xp-crd: disallow regulator mode switches") arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dt= s/qcom/sc8280xp-crd.dts index fea7d8273ccd..5e30349efd20 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -124,6 +124,9 @@ vreg_l7c: ldo7 { regulator-max-microvolt =3D <2504000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l13c: ldo13 { @@ -146,6 +149,9 @@ vreg_l3d: ldo3 { regulator-max-microvolt =3D <1200000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l4d: ldo4 { --=20 2.37.2.672.g94769d06f0-goog From nobody Thu Apr 9 12:50:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8327ECAAD5 for ; Mon, 29 Aug 2022 16:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbiH2Qu6 (ORCPT ); Mon, 29 Aug 2022 12:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbiH2QuZ (ORCPT ); Mon, 29 Aug 2022 12:50:25 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2445765540 for ; Mon, 29 Aug 2022 09:50:22 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id p18so8556744plr.8 for ; Mon, 29 Aug 2022 09:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=BxQqHwLkPhmUcTslqYQ4b+VZsZjUArhc5KFTdI1uAuI=; b=Ob+7ECVRm7EAiRAnh+Y3EbOAI8asNMEM3zSNO6pqaOBlJiPuCHlkrookGt6fH8yyOU X+b41ysdhe95Iz/43v9UgBXQ+tLzdmdr946ej23XF5IWlb0pA4q1QaMiTqUytYadv7nY Akv05QtST0xdSFbA5NoyPApWyz5QvdvqrjT5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=BxQqHwLkPhmUcTslqYQ4b+VZsZjUArhc5KFTdI1uAuI=; b=EgHia+f5XNMWf57S/sHvF7cDlQyRLIkrRmma2OFjU5d8WkrfDLupHiJkyuvY1Lh8hM 39MPX6ZseIdRAKWJanZ4XyslySk613VlR5xPo2O3yg8ednx4hSZdxyXfSoOQaF+TZWsB LuWoRaqEL+dmgd+TxBewnTXtM2GGns//SxHtQP0kuk+VYgsfD9bN9IiY6Uh/6PcLJgK4 FrojtrfvzoPXw3NI1s0oRQsS3KDbXV56AWy/qTjNQKIXpv/zaPt0z/B+WxQrN4NpYJ2i cruLoAs5TkZES8YaP1oMVZ3R2N95eeJwweG6zZ6hFssjNW9uIRMqfQu5I+Zlc28e/r03 Sz/w== X-Gm-Message-State: ACgBeo3VSK85Ys5N6B+PdT5XvbpsH2f/Wup7bvdmxAKy8cAFcYXaRP4n bnsfS3CEvZPf4lG40aVXIP/HyA== X-Google-Smtp-Source: AA6agR6mqfgmUmDi33l0/vpHcAlm37qsOHl0kd3HkZrS6xj+iK15kNMJZoQzwiWseZblLmw+xa75Iw== X-Received: by 2002:a17:90a:b00f:b0:1f7:67c6:5df5 with SMTP id x15-20020a17090ab00f00b001f767c65df5mr18916536pjq.59.1661791821821; Mon, 29 Aug 2022 09:50:21 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:21 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] arm64: dts: qcom: sm8150-xperia-kumano: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:50 -0700 Message-Id: <20220829094903.v2.4.I51d60414a42ba9e3008e208d60a04c9ffc425fa7@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c672= 08fa9edda4a08847c304@changeid Fixes: d0a6ce59ea4e ("arm64: dts: qcom: sm8150: Add support for SONY Xperia= 1 / 5 (Kumano platform)") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch= /arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi index 014fe3a31548..fb6e5a140c9f 100644 --- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi @@ -348,6 +348,9 @@ vreg_l6c_2p9: ldo6 { regulator-max-microvolt =3D <2960000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l7c_3p0: ldo7 { @@ -367,6 +370,9 @@ vreg_l9c_2p9: ldo9 { regulator-max-microvolt =3D <2960000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l10c_3p3: ldo10 { --=20 2.37.2.672.g94769d06f0-goog From nobody Thu Apr 9 12:50:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6234ECAAD5 for ; Mon, 29 Aug 2022 16:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231130AbiH2QvF (ORCPT ); Mon, 29 Aug 2022 12:51:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbiH2Quo (ORCPT ); Mon, 29 Aug 2022 12:50:44 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA977392D for ; Mon, 29 Aug 2022 09:50:24 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id t5so8630909pjs.0 for ; Mon, 29 Aug 2022 09:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=nhn/w5h2jny0OsR9Iya6bJX/FfXt3qTgdH67oe8iCrw=; b=Xe1e4Nq/i7gkbY3ptMSC/LQQ9HFvyzIIhZ0blm+9Dy5QvOULptYN2Bx5jQRfGGudbK 5jtt/GZy1OMN3NnY6PEQiMS2DBMOX3xv908rYMbgS/+QJD2gpizWJDeLN6ChkjxhPBNe e7J0NDRd7U96dHg8vsXWZgsLhsWF/m4lgHyfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=nhn/w5h2jny0OsR9Iya6bJX/FfXt3qTgdH67oe8iCrw=; b=gRCx9a4A07tTbp5bj+cxyFFKvVu4cey4DzmEYl4AuW5jwHKpGkC3X/3c6S7Zb9yyX3 Ed/JTUzGdok5x8wPR8TTcJt3Kvp5bCwywwhGMbqbwDHHvOfuNp6sa4Of/cQJwqPQpHYw 0tBWA1MV6ERHXmH6gb2WSAfvBaUsnTfqJuEbg4ljZqraVtPeaviQEoXyOk3rePlXQNjU Qs3KScM7o9EiJVWdW+aCnWr5n/NxKoSVasgEdzCV34Fx2QhjxakTRyBloz6IMVKNlGyR AYjF8AjtA838GsgIXjLlHIoXgv0Cqp06btFXPxcoXGw3IY7ETsztO/A2yt5kH8UV8WCK l8Bw== X-Gm-Message-State: ACgBeo3zqHqX0xVdEyxdAeNwbrUkrm6y4S8mSjhby/i/bKgyjjZbvo4R GD0jO+727btH3IvDLr45SCt+yg== X-Google-Smtp-Source: AA6agR69yrznAbc4gS1Ofi8dCrVzKMw/LDZ6plYxItqYU0dO2S2KPp/NgysrQjGpbzqjpYnTt7kkpQ== X-Received: by 2002:a17:90a:cf01:b0:1fd:5bed:bf55 with SMTP id h1-20020a17090acf0100b001fd5bedbf55mr18532160pju.14.1661791823525; Mon, 29 Aug 2022 09:50:23 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:23 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] arm64: dts: qcom: sm8250-xperia-edo: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:51 -0700 Message-Id: <20220829094903.v2.5.Ie446d5183d8b1e9ec4e32228ca300e604e3315eb@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c672= 08fa9edda4a08847c304@changeid Fixes: 69cdb97ef652 ("arm64: dts: qcom: sm8250: Add support for SONY Xperia= 1 II / 5 II (Edo platform)") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/ar= m64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi index 549e0a2aa9fe..5428aab3058d 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi @@ -317,6 +317,9 @@ vreg_l6c_2p9: ldo6 { regulator-max-microvolt =3D <2960000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l7c_2p85: ldo7 { @@ -339,6 +342,9 @@ vreg_l9c_2p9: ldo9 { regulator-max-microvolt =3D <2960000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l10c_3p3: ldo10 { --=20 2.37.2.672.g94769d06f0-goog From nobody Thu Apr 9 12:50:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F27ECAAD5 for ; Mon, 29 Aug 2022 16:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbiH2QvK (ORCPT ); Mon, 29 Aug 2022 12:51:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbiH2Qup (ORCPT ); Mon, 29 Aug 2022 12:50:45 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 978877AC0D for ; Mon, 29 Aug 2022 09:50:26 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id y141so8759494pfb.7 for ; Mon, 29 Aug 2022 09:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=woneQpwMOMgIO7e0hCdrCZoj4JrbV7vkhMtZpv1/ep8=; b=kmSDFY9nq5Z5Qb5YraZhZdKCocvVR+dWWSurViHAeY24Ijr3xQyq61FPn2WNDBleHT iiG4iERxcptn2BsoT3XiLjGtMjivx/5G9UueB3ywrsSXZxfv5ftP1eSjabPgj4NKMXrh qt8vfKX4rym2utpsMZdYtSymG8SUSMgUAjjAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=woneQpwMOMgIO7e0hCdrCZoj4JrbV7vkhMtZpv1/ep8=; b=cjr6GXw4iLJt0+wJldMdPyLBiuj7v9HMZFeMMyqd6J1jgjWElObC7UQPoWqGmdhHua tGSRdfl1hD2EFD8KFgsHitsxCWsMCJoZUoSPacZYSfwbET+Fa5KF+9TLVq5ylr60YkMI z6Cbt11nRp4y2aRMQ9zQiJg2u+mEU0LyPewrrdObObMvOLPDHyriCpDWXaWQ9tRuwb4w Y+2qgpaAF2UOhZznI22aYysyu++aRIi1YpHjcKJhxsh0s7F6fbDw8G2Ee6WunJn1Nu9y t4dFPJO7XATfGksrXRC8uNRYi8UPBphGAiZrvR+rOSABw/Wxa3gr9qgBRJCp4GY1RZgx D+lw== X-Gm-Message-State: ACgBeo0v7Kx6GxO0IePSn0Jg5KKY+G69PH//vgGQexBl7WMSb9CQ6EHR +kAxgENIyRTAyOg1KbyZ/F+kQw== X-Google-Smtp-Source: AA6agR4VOEmzb8h688Hlh10n5OC2JGl7tx4FZ9QIiaFqDYhrKJQYQ0M7KGv2bhGU1bVC3w2/4zclgw== X-Received: by 2002:a63:6a46:0:b0:41a:3e67:67cd with SMTP id f67-20020a636a46000000b0041a3e6767cdmr14844814pgc.94.1661791825380; Mon, 29 Aug 2022 09:50:25 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:24 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Vinod Koul , Konrad Dybcio , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] arm64: dts: qcom: sm8350-hdk: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:52 -0700 Message-Id: <20220829094903.v2.6.I6799be85cf36d3b494f803cba767a569080624f5@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c672= 08fa9edda4a08847c304@changeid Fixes: 9208c19f2124 ("arm64: dts: qcom: Introduce SM8350 HDK") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Vinod Koul Reviewed-by: Konrad Dybcio --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/= qcom/sm8350-hdk.dts index 0fcf5bd88fc7..69ae6503c2f6 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts @@ -107,6 +107,9 @@ vreg_l5b_0p88: ldo5 { regulator-max-microvolt =3D <888000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l6b_1p2: ldo6 { @@ -115,6 +118,9 @@ vreg_l6b_1p2: ldo6 { regulator-max-microvolt =3D <1208000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l7b_2p96: ldo7 { @@ -123,6 +129,9 @@ vreg_l7b_2p96: ldo7 { regulator-max-microvolt =3D <2504000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; =20 vreg_l9b_1p2: ldo9 { @@ -131,6 +140,9 @@ vreg_l9b_1p2: ldo9 { regulator-max-microvolt =3D <1200000>; regulator-initial-mode =3D ; regulator-allow-set-load; + regulator-allowed-modes =3D + ; }; }; =20 --=20 2.37.2.672.g94769d06f0-goog