From nobody Tue Apr 7 12:05:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920E5ECAAD5 for ; Mon, 29 Aug 2022 16:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbiH2QaC (ORCPT ); Mon, 29 Aug 2022 12:30:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230356AbiH2Q34 (ORCPT ); Mon, 29 Aug 2022 12:29:56 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2041.outbound.protection.outlook.com [40.107.92.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AFAB60E9; Mon, 29 Aug 2022 09:29:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyrxVzwXrSJBkk5qgyvmxi9PO5Bi/fpvXDnQuyiIK93kclVSOGl+qtsM0Q5WYZBm93ow/oOaMJHr+7W99AtG3MQR+mvlgjEMUx0vSeWEm9OuiiEGbu3MsSDOSenajEqBbpn1SXfe50l+fEPeuBp8X64XxtQA+5fRPkVtnlxDQ8FzJYnAKUSEPYzJ/F/8+a+Q3Tpvl8Ds9Mn+iv/WWnmv51QkIvaKrS83c6jBh7VEFA2/I6oQNban4X5wICcDSPPuBhwqPsNMsAjMkAtwzuN3gENUj7HibU1E+0Wk8sBiOdu8Lntdx2LAw1MA0FrmtJwu/cTv50o6P2IgNp6QCAaB1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cb2Ept+u+ewMhpGkAhWhnISYkF5IZQ4dtnvc2u3KeNc=; b=Dw1SXC0lFLmRAvzOHffADxEYZQB7X16eaMGbGzMfJcQCTjo3M5ZGEEy4mCyi59h7sX/3ovejsxpYqkOdqy7wJgiQpsWK2PVR9RHY2CttpDMDVxnu07YGAREPwyQievnNJlnFjSqmnMaDZ77AKMqqdAl1GJW0uVd05VpoQCxrX82dUk1FE/JMT9MMr6tbAVxWFmW6PG5a1gE/X+6CNRIUuFMLDB7vyI43E4ewGKt/iungEIrHwxmAQxLD+SXEUUV2Oj/F8w+Qso8jQBoZYyevitmJTc8B9M37b6YU0I/2+9sGwR1FZTMJd8DtV8HPiUYFv7JITc1hs+65//9RJAXNKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cb2Ept+u+ewMhpGkAhWhnISYkF5IZQ4dtnvc2u3KeNc=; b=Y0vpIHRlAQT3qkHfi7hgzw+SKEO41ffllDuTJQY8dZj8qJP4UuMXrzZz3pDrqxUknFCE3Pu726PxQ0egc1/fAbI5eFHWaepKQhrHZGEe2ZYVRnBLa5Aq+dER44FHcJLeRmR+sndw+C96fNqJb4EmHlKp50RjzM44SpqtyJe7/JU= Received: from MW4PR03CA0024.namprd03.prod.outlook.com (2603:10b6:303:8f::29) by DM6PR12MB4975.namprd12.prod.outlook.com (2603:10b6:5:1bd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 16:29:49 +0000 Received: from CO1NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::ac) by MW4PR03CA0024.outlook.office365.com (2603:10b6:303:8f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 16:29:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT082.mail.protection.outlook.com (10.13.175.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 16:29:49 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 11:29:47 -0500 From: Mario Limonciello To: , "Rafael J. Wysocki" , "Len Brown" , Pavel Machek CC: , , , Subject: [PATCH v3 1/4] ACPI: s2idle: Add a new ->check() callback for platform_s2idle_ops Date: Mon, 29 Aug 2022 11:29:49 -0500 Message-ID: <20220829162953.5947-2-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829162953.5947-1-mario.limonciello@amd.com> References: <20220829162953.5947-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9279c4f2-6ab6-47e2-97a4-08da89dbb152 X-MS-TrafficTypeDiagnostic: DM6PR12MB4975:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Kks2yAlutitOSK5ZFYR6gwfxvJlWsdERE+q3Ugr+WyNzS5+POgz4l24EjRh/GmkXGQgWgZKlJxgejrEv8IkfliBoleEEYcAlEkWFtVzYHKWbeNIiFIVf70YmnqOvHixgyk246xPRV5jb6Lti5fU543ApSIxNzp0J/tEo6WbACJvGmIyBkSJyXwvKXDCkapbd0NSmrkq61D1cmOgCM6IJDaQZBYuTJJOhmG2MUA4WGLqy3jDSrmv+9J/RKP3j3+2JEzDyAn0lx/hWgzuhL60LWt38zpuuuRQ4CTDbcSy0OGYpQzpM3bCSrSH/hCNxD0OAbAZO7XoRD9hN9EHnY0RbThwuYZ8Bwcq1wnrnGKGc4TB550pFbDbrmd0kgaPD2YqUsICCQJ5mUTXeGU+bL8/jE7OPOTaecK+X3kTdF+atabfvOApAuDDgA68YMqQ7EtTBjUjvOFRXUZSV75PMKtkqanUHQ71841RrlKKUHic7ansG4KEQPz80hmvfbCTh6ygJHuKLmBiRut8iV0+15kOoYejTmn9oU6M01wfNarGrV/Q23c+oecnJvxd5AlltasspEa0lo28H65sSY3su5C4X8NEuUwQND9WBffVu+UDntL0gP5AiYYdvXS2mAiQQJpocvzmaGjyDzslDTAiCLFy+gjvYj0+rGP9+zJseuLta+pr8U6jcXmAwjpF7RsyjW/xi9FbXm3QraBP0StcGUFkGbw+GHi4Sfl15x+zKgEijfXhxfWR01EZPmeQ1bXMy2n330dxWgeaugWmSV7ULOIIHcE5/QE3DiE/6x247PhxhfQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(396003)(36840700001)(40470700004)(46966006)(81166007)(41300700001)(40460700003)(5660300002)(36860700001)(8936002)(40480700001)(16526019)(336012)(186003)(83380400001)(426003)(47076005)(2616005)(86362001)(1076003)(7696005)(44832011)(2906002)(26005)(82310400005)(36756003)(316002)(110136005)(478600001)(54906003)(82740400003)(356005)(70206006)(70586007)(8676002)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 16:29:49.0294 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9279c4f2-6ab6-47e2-97a4-08da89dbb152 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4975 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On some platforms it is found that Linux more aggressively enters s2idle than Windows enters Modern Standby and this uncovers some synchronization issues for the platform. To aid in debugging this class of problems in the future, add support for an extra optional callback intended for drivers to emit extra debugging. Signed-off-by: Mario Limonciello Acked-by: Rafael J. Wysocki --- v2->v3: * Rename to *check v1->v2: * Add a prototype for `acpi_s2idle_enter` drivers/acpi/sleep.h | 1 + drivers/acpi/x86/s2idle.c | 14 ++++++++++++++ include/linux/acpi.h | 1 + include/linux/suspend.h | 1 + kernel/power/suspend.c | 3 +++ 5 files changed, 20 insertions(+) diff --git a/drivers/acpi/sleep.h b/drivers/acpi/sleep.h index 7fe41ee489d6..d960a238be4e 100644 --- a/drivers/acpi/sleep.h +++ b/drivers/acpi/sleep.h @@ -18,6 +18,7 @@ static inline acpi_status acpi_set_waking_vector(u32 wake= up_address) extern int acpi_s2idle_begin(void); extern int acpi_s2idle_prepare(void); extern int acpi_s2idle_prepare_late(void); +extern void acpi_s2idle_check(void); extern bool acpi_s2idle_wake(void); extern void acpi_s2idle_restore_early(void); extern void acpi_s2idle_restore(void); diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c index f9ac12b778e6..474aa46f82f6 100644 --- a/drivers/acpi/x86/s2idle.c +++ b/drivers/acpi/x86/s2idle.c @@ -486,6 +486,19 @@ int acpi_s2idle_prepare_late(void) return 0; } =20 +void acpi_s2idle_check(void) +{ + struct acpi_s2idle_dev_ops *handler; + + if (!lps0_device_handle || sleep_no_lps0) + return; + + list_for_each_entry(handler, &lps0_s2idle_devops_head, list_node) { + if (handler->check) + handler->check(); + } +} + void acpi_s2idle_restore_early(void) { struct acpi_s2idle_dev_ops *handler; @@ -527,6 +540,7 @@ static const struct platform_s2idle_ops acpi_s2idle_ops= _lps0 =3D { .begin =3D acpi_s2idle_begin, .prepare =3D acpi_s2idle_prepare, .prepare_late =3D acpi_s2idle_prepare_late, + .check =3D acpi_s2idle_check, .wake =3D acpi_s2idle_wake, .restore_early =3D acpi_s2idle_restore_early, .restore =3D acpi_s2idle_restore, diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 6f64b2f3dc54..acaa2ddc067d 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -1075,6 +1075,7 @@ acpi_status acpi_os_prepare_extended_sleep(u8 sleep_s= tate, struct acpi_s2idle_dev_ops { struct list_head list_node; void (*prepare)(void); + void (*check)(void); void (*restore)(void); }; int acpi_register_lps0_dev(struct acpi_s2idle_dev_ops *arg); diff --git a/include/linux/suspend.h b/include/linux/suspend.h index 70f2921e2e70..03ed42ed2c7f 100644 --- a/include/linux/suspend.h +++ b/include/linux/suspend.h @@ -191,6 +191,7 @@ struct platform_s2idle_ops { int (*begin)(void); int (*prepare)(void); int (*prepare_late)(void); + void (*check)(void); bool (*wake)(void); void (*restore_early)(void); void (*restore)(void); diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 827075944d28..c6272d466e58 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -136,6 +136,9 @@ static void s2idle_loop(void) break; } =20 + if (s2idle_ops && s2idle_ops->check) + s2idle_ops->check(); + s2idle_enter(); } =20 --=20 2.34.1 From nobody Tue Apr 7 12:05:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF2AECAAD5 for ; Mon, 29 Aug 2022 16:30:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbiH2QaH (ORCPT ); Mon, 29 Aug 2022 12:30:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbiH2Q34 (ORCPT ); Mon, 29 Aug 2022 12:29:56 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2071.outbound.protection.outlook.com [40.107.220.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45E6410EC; Mon, 29 Aug 2022 09:29:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LuyGtbTL1Jie724JAIBnSJgsV2ZK3QbFE0NptWAQhpIN1DPKsJ2+iz6Ndt2k0a7S+9T5Ly3P8Knfkqnpk8uAi5iVx2UolEnHiPZhMElhJmUzn1SXvAA+9OoDAMqzLjdG7I0L6lgaplR3L6Ana+uPiso/9Yr1yg3aR3/DBMYQVnymDKDmshfmKmRgFJtC5jThMJLh4YSzp4fBdd7zJC//DDyWFFcRd3XV1KLIpGDZNoGDKZj55HMPKbblyPIOVgqyALzMAk9JjK5cY/8bwbjOOAmiUGe5so+4xAU68o9Iy2dESFjl1q0LwS6FEugNzCEyMPOX8btjV6+C3ns2o/r6ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XnZ/N898WaCzVG9jDcNt0kIKmLu//Xa4CSeyFO1a5j0=; b=VrYUGA5m4Boro3JP7Ucrwc5xAtgo2+RBbc72cse9HB6uSXR+FEanxMxYpRSyewFFw/mEKtt0l3bXBS1jca0Ko3i5Y0ltN8ub0dT5C8oCa1DD2emuGYUD+pQ9jDHnzLmKqAEkVn2TShV7u6oeW2dljeuI2HUJyPXIKJXQQOoE5yKoLRoDRaEus/Yp9iEmEQcy/gbudZH+Nu1IgQrk3embQACAgP1x+VhcJyOUZ5yCnV4CZ28X91G90Hgm8Eqa2YlIFTi5UX9o7XSJVW7DEQvavy23M7+UjeS5whJey09FglA+YtUQ4XKVlEGMbZvF7vT50FQ9Kcdl3jcAjDHvJAZUSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XnZ/N898WaCzVG9jDcNt0kIKmLu//Xa4CSeyFO1a5j0=; b=CE1i65ncXuyXhSPrTX+RCye5odvwqKAYqpYJnN9ZAd3lVeZF/41CI4pBrAhcoVLpjsYYO/IxVe1nBwRd54zwyMHPO/LqKPsmJrxSUVinqFfcp3WnAottZWQ9HUaPO2InKOHUlTm7x91KLf2aMh4SdD5d0MXqw5GKD8Oi6y2PKvs= Received: from MW4PR03CA0023.namprd03.prod.outlook.com (2603:10b6:303:8f::28) by DS0PR12MB6608.namprd12.prod.outlook.com (2603:10b6:8:d0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Mon, 29 Aug 2022 16:29:50 +0000 Received: from CO1NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::b0) by MW4PR03CA0023.outlook.office365.com (2603:10b6:303:8f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14 via Frontend Transport; Mon, 29 Aug 2022 16:29:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT082.mail.protection.outlook.com (10.13.175.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 16:29:49 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 11:29:48 -0500 From: Mario Limonciello To: , Shyam Sundar S K CC: , , Mark Gross , , Subject: [PATCH v3 2/4] platform/x86/amd: pmc: Add defines for STB events Date: Mon, 29 Aug 2022 11:29:50 -0500 Message-ID: <20220829162953.5947-3-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829162953.5947-1-mario.limonciello@amd.com> References: <20220829162953.5947-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bbc982b-2253-403b-56e9-08da89dbb1b4 X-MS-TrafficTypeDiagnostic: DS0PR12MB6608:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7WwQkCNMrtCadaHE9UH6+ElNIa6e3iiTaCjJv10X8OD73EFZmL8WUEIXDpJ07RUDu/vc8FWT9de/hxA32DyS7WfvDMME5DnZkJGCY7+c1hy4jyI1uOfpk9evREddZ435gFa+HerMxCXA1cMNMptsJ2qCjFg/9QlVvcNEE1p3bBV3aXT3ixutnUsG9emoBVFKbsq3MavaOpIDdtoruPGoFTXhbi80gHZit3U2X3k2o7Ha2y4ymRNDZG+aKcpFarfjDQawCpwlv1XXa9xDgejo90fGJP4YBGys12ZydmaxTCyNDM0XpLexHOjDZymwcQfmO4Y0iD5UnFl7uPSr32Fgbc0cdX39+FvsoLqB4bYUfxyi72ahpJMIKhedNoXOCLXO2X6BWZeAF8T2BKJnysUmLV9PHyOWsOWnd8McVV6EPzK4RMZuqOV8nl3ltsdPm+nKe5VN4D1nyrMXEXhQBhmQQ7/pMYo3Y5tFvXiAn+3TrKfF/j9RZZeY4TFkRRE/llIxpYdLcmRbqvzrGLVc3GoFx7Po8yg70LKt18J9v59OthH48Y/YgjWFVo1TPGV9pqZvL/+bDb87HD9T8ft9lc49ZNdKIbg5sB5QYe44u5q+GWb7YId922xBNKLVLeSm7fJIqVYJKh0IS1rGEQrcwwq7GdNvUAbnhrqBxrYIu5Y8yBDHO5K5TPfgPG2SA68MFUuyNVMbhYORS0P9GdRJoTL89blWr8l84Xym/GBAzMxhRpTD91TdYB8JR5H113ds/d8gamqKeeHGgMI2IZLpEJVxS9+V1rj2XKHNruK1jVZILGINk0ypczjFV0cmJTbU0/zL X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(346002)(39860400002)(36840700001)(46966006)(40470700004)(316002)(54906003)(81166007)(110136005)(8676002)(86362001)(4326008)(70586007)(6636002)(40460700003)(70206006)(478600001)(5660300002)(36756003)(356005)(8936002)(41300700001)(44832011)(2616005)(6666004)(82740400003)(1076003)(7696005)(82310400005)(2906002)(426003)(16526019)(36860700001)(40480700001)(47076005)(336012)(83380400001)(26005)(186003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 16:29:49.6700 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bbc982b-2253-403b-56e9-08da89dbb1b4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6608 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently `amd-pmc` has two events, but just adds one to the first to distinguish the second. Add a clear definition what these events mean. Signed-off-by: Mario Limonciello --- drivers/platform/x86/amd/pmc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 700eb19e8450..39e6ab88861d 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -39,7 +39,8 @@ #define AMD_PMC_STB_INDEX_ADDRESS 0xF8 #define AMD_PMC_STB_INDEX_DATA 0xFC #define AMD_PMC_STB_PMI_0 0x03E30600 -#define AMD_PMC_STB_PREDEF 0xC6000001 +#define AMD_PMC_STB_S2IDLE_PREPARE 0xC6000001 +#define AMD_PMC_STB_S2IDLE_RESTORE 0xC6000002 =20 /* STB S2D(Spill to DRAM) has different message port offset */ #define STB_SPILL_TO_DRAM 0xBE @@ -701,7 +702,7 @@ static void amd_pmc_s2idle_prepare(void) } =20 if (enable_stb) { - rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_PREDEF); + rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_S2IDLE_PREPARE); if (rc) dev_err(pdev->dev, "error writing to STB: %d\n", rc); } @@ -724,9 +725,8 @@ static void amd_pmc_s2idle_restore(void) /* Dump the IdleMask to see the blockers */ amd_pmc_idlemask_read(pdev, pdev->dev, NULL); =20 - /* Write data incremented by 1 to distinguish in stb_read */ if (enable_stb) { - rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_PREDEF + 1); + rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_S2IDLE_RESTORE); if (rc) dev_err(pdev->dev, "error writing to STB: %d\n", rc); } --=20 2.34.1 From nobody Tue Apr 7 12:05:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF88AECAAD5 for ; Mon, 29 Aug 2022 16:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbiH2QaT (ORCPT ); Mon, 29 Aug 2022 12:30:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230491AbiH2Q36 (ORCPT ); Mon, 29 Aug 2022 12:29:58 -0400 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2070.outbound.protection.outlook.com [40.107.102.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4678863B4; Mon, 29 Aug 2022 09:29:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BxHEbtntgk/GPwPb9528wkZTaX7kvflJ548VrD5IFC5hX8sUIaug0W4vQbxSys/i4JBCK+ERC8718FzMbfLzazTMtetkMYI4ZKTC7gKIZSVho90Wv3BvGFV+MEXAOnbniKsn6/3g1wNss+fKb9bPoK5Eg6Bl/amE4xBRbZJPdIQmaDe6wcIt69D3phzMzmSGYbquIDrtd5ORhvGnqnVMAZPMKpbPYUaqs8+D/jR4IeqD2TsC1ilBF24ak2ij6cfEF3S37GpiGUsRgbwwD59Gt68UMnn/bxEff+CAaiXB0DqcPbJ7/FVPo+B4+/k332B/0RFV86gdniyIyj/8Lp4G3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ilsrEfqeQeGNIwJPwlMXeq9QSa2qNQJ8jTqOJs0TQOw=; b=S4lr89OfHa81hNHdGAdDY+/7M7BpuZ6tOuU+nLI8cg5PS8KL+7RPlK7o4+JB9LwXSuCrqa24k+RowV6ci2q/LGVwPuDMpWWRblQikx8LWbkb3S4VrKoDOewAivlfl8r6g6la54mLKky3nhEYuhgnZUM0TrcAdq0XXCcBeeevMTj2H8GMTpjDwKfPfv9764sG+5cbYZEo7uU4Lo5zKfsNaaSR4YXhFlk70T0d6Hr+ag9uxkN+cYTaNrAxbLwdEA1pL+lQ+nGfzrkPnmNIO8yNS5/9pgZDVfcwxxIkc2miig6HUk89m14HqdwGFd1xsph8knnmX+uQX6meZ58opILQwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ilsrEfqeQeGNIwJPwlMXeq9QSa2qNQJ8jTqOJs0TQOw=; b=W602nvGHVYK9ejT+8qoiGi1c1Lhckl4ij+LjizuBrnM4nVoHpGomT4zAL/oX63PWG1PgU1rAFVip/qQw/dwLd271YrDojmeCyoMRcUUL55NUM4KkgF44og/DdWtPz8vL7YUfVR9BI6kDahRpXzKrwnyH7M4TuqUXY1YQcfvkI9A= Received: from MW4PR03CA0020.namprd03.prod.outlook.com (2603:10b6:303:8f::25) by MW4PR12MB6802.namprd12.prod.outlook.com (2603:10b6:303:20f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 16:29:50 +0000 Received: from CO1NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::75) by MW4PR03CA0020.outlook.office365.com (2603:10b6:303:8f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14 via Frontend Transport; Mon, 29 Aug 2022 16:29:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT082.mail.protection.outlook.com (10.13.175.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 16:29:50 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 11:29:49 -0500 From: Mario Limonciello To: , Shyam Sundar S K CC: , , Mark Gross , , Subject: [PATCH v3 3/4] platform/x86/amd: pmc: Always write to the STB Date: Mon, 29 Aug 2022 11:29:51 -0500 Message-ID: <20220829162953.5947-4-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829162953.5947-1-mario.limonciello@amd.com> References: <20220829162953.5947-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e18b13a-cdc8-4cb4-76ae-08da89dbb237 X-MS-TrafficTypeDiagnostic: MW4PR12MB6802:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 71U17kD87FR2HVUfOL5tx3ZVKCiwgsauxFLfCyUDEMQCAcJpM1ftYLYaqnNuZBy7IlBYcksbC+gAc1K2meK4vY+LkIDE4nq1ZFvv5acdUAXnNDS+apoo4DSK8FysEfmBstN9X4TOnEI9IzmFoS+ZiOKFYV+68o2mkAp86WyFVf5q4/b430pwwSft/ec81cGe8BTEwedg5W1LCptYxB/9HgMInvN3KJByUnpGnu/rMW5JwsWCij7vegu8pSoug9t/uJll+tvfeiRZxlh+Q2JegVplUrB/lG+r2yrLXJD1XVszwdZK0Hr5wtRgaObe7EK6FwcsCNP38bsBPJ7hywAM+jHRUulHsHjBqY0nB0Cxc7ZDnLd5meUmz6Q6yfw00n+gvlCY+NM+V7XuccWhdHCaz2o515SoWss35kUORz5A5nNHICnt7lm6xgVTDGBQQuS9Qo2KYp9nMyTbpiJkUfLtY7xnAaLKGXHgmZhV8CD7z1adakq44b1BhjbaXVwftQ8SRnX+xdpsUdpm16R30s1eEF/RJDVFHYPxdvbWukjnx/MHFsk6N3ixJHhzCmSf3UrFvdm1DBcQlHYq4T+PBEu/WXeuqtbko7/A4pfnjjhfocZ8BRJlfvQ4rBSwDXxRqSm31PSeld4bohVUzeBNL4PN0q4T/Pi6nlmozHTaP8/zqg1zfsd/6o2hzCNBw+CgfXpqaxD8WPzHLaLl1dfwG/h5w7cDfeQ6aCB7Lxj9U2/u8GMuPd+SH9VlAOBFWRTYNPYsJYnYaHueAsp0jQSd9c9alICZaCfE74FcMlDBFeqkQdcuyDZJYdPzp5pN5zIB37mL X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(396003)(346002)(40470700004)(46966006)(36840700001)(8676002)(110136005)(4326008)(54906003)(6636002)(316002)(70586007)(70206006)(356005)(8936002)(86362001)(5660300002)(478600001)(81166007)(41300700001)(36756003)(82310400005)(2616005)(2906002)(44832011)(82740400003)(6666004)(26005)(83380400001)(36860700001)(47076005)(336012)(7696005)(40480700001)(40460700003)(426003)(16526019)(1076003)(186003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 16:29:50.5450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e18b13a-cdc8-4cb4-76ae-08da89dbb237 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6802 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The kernel parameter `enable_stb` currently gates the access to the STB from debugfs and also controls whether the kernel writes events to the STB. Even if not accessing STB data from the kernel it's useful to have this data stored to review the STB. So in suspend/resume always write it. Signed-off-by: Mario Limonciello --- drivers/platform/x86/amd/pmc.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 39e6ab88861d..fba42036682d 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -701,11 +701,9 @@ static void amd_pmc_s2idle_prepare(void) return; } =20 - if (enable_stb) { - rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_S2IDLE_PREPARE); - if (rc) - dev_err(pdev->dev, "error writing to STB: %d\n", rc); - } + rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_S2IDLE_PREPARE); + if (rc) + dev_err(pdev->dev, "error writing to STB: %d\n", rc); } =20 static void amd_pmc_s2idle_restore(void) @@ -725,11 +723,9 @@ static void amd_pmc_s2idle_restore(void) /* Dump the IdleMask to see the blockers */ amd_pmc_idlemask_read(pdev, pdev->dev, NULL); =20 - if (enable_stb) { - rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_S2IDLE_RESTORE); - if (rc) - dev_err(pdev->dev, "error writing to STB: %d\n", rc); - } + rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_S2IDLE_RESTORE); + if (rc) + dev_err(pdev->dev, "error writing to STB: %d\n", rc); =20 /* Notify on failed entry */ amd_pmc_validate_deepest(pdev); --=20 2.34.1 From nobody Tue Apr 7 12:05:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4363ECAAD2 for ; Mon, 29 Aug 2022 16:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbiH2QaZ (ORCPT ); Mon, 29 Aug 2022 12:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbiH2QaA (ORCPT ); Mon, 29 Aug 2022 12:30:00 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2051.outbound.protection.outlook.com [40.107.93.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1026E1275D; Mon, 29 Aug 2022 09:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lbXsAQXBmn4XvZA1TelTttIXr7MhN6nzzNn/JBy3cQqq9wd2ZA9INCEAjADBQEcePw6KPN6MTiI0pLss8wUo10HauYnG6GeFY5eMDcqbPY04nqQX6zTGMzaMrUNNgCXSimXZKKDJI1diTBysqIWrdgs4A541TGG7B+t1Js7MyN54jeWChQ/n1ko5epSe/RU8tztnVTD+nEn/YPkD1DDXWpM27Ioxnxheav0pH8HtES+pPsYEPh6ajQGWfTq3jW7W12R9Rn6mWnfL3MuAHGyHpCCVlelhSngH4aoWR6fnmMhy35lvWuGllcSZCf0yddym/NvNxVfj1TrDWtZvw0FnvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LfXiFbTGb1mzgC7Zy/gE2k2b7jylUR+qD4FfYjlHBVg=; b=XUTZg2tOM1B78d4oMwf7SB+yOJytNl9evmUAI4G+u+KTZdiE01K3XklE2wFJmaeHFNTVjW+3nQIauUcn0dWBGycBOWK7MmQVAO0CTmbCk7EZugN2aYFEbj0bsZTQPAdulRP4r0ORdPsig3ixR1brzs5j5fIbHAErRtsCDVCL34k54z+6XwTD7D/TAVMEEqwSjedXm59O84ASWEdEQTV0GZzQ5MO/FEtPVLzwpjhYY8lxZakWN00SZaHdYVockLd29CfEn7XhXQGG2iZmJnJP58o31/Jd53NHe1g/NWKSVpM3s1XMVXBcMfBv6c0c0+0SNUm17eWVpezl/sr2w33Kag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LfXiFbTGb1mzgC7Zy/gE2k2b7jylUR+qD4FfYjlHBVg=; b=rqqPwaJDAV3YoOxO20j216rfLv3ob6AiCbpIC3eTKlA6Qs/SSclp9OdlTH6BFi63wq7HT4768aIQkHDQx8fIcGYtxp5A8lmr2vZz/PmCSHCxHoPR7N4+VgjWkoIK2OiaJKMM6EKUZz/o+QqWLO4QsZiv+ou+JDjBOaAh5g9YEr0= Received: from MW4PR03CA0003.namprd03.prod.outlook.com (2603:10b6:303:8f::8) by MN2PR12MB3326.namprd12.prod.outlook.com (2603:10b6:208:cb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 16:29:53 +0000 Received: from CO1NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::82) by MW4PR03CA0003.outlook.office365.com (2603:10b6:303:8f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14 via Frontend Transport; Mon, 29 Aug 2022 16:29:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT082.mail.protection.outlook.com (10.13.175.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 16:29:53 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 11:29:50 -0500 From: Mario Limonciello To: , Shyam Sundar S K CC: , , Mark Gross , , Subject: [PATCH v3 4/4] platform/x86/amd: pmc: Add an extra STB message for checking s2idle entry Date: Mon, 29 Aug 2022 11:29:52 -0500 Message-ID: <20220829162953.5947-5-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829162953.5947-1-mario.limonciello@amd.com> References: <20220829162953.5947-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7160cd53-f773-46b6-ad3f-08da89dbb3d8 X-MS-TrafficTypeDiagnostic: MN2PR12MB3326:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WYuLKc3KuiQukfEwsvMRFiKiMVywKb+Ik+WnKM0r56Bflp1uHIfhnHAiZnU1FBE5uFYy/9BX+dBLzrg4lf/l4pBQHMA356mDkjSFHDNdOUc+lTfirgNO3UviWsFOUBgXTRRmuXZu5h8+D0s98rM4IHILWLBb7/O8Tqit/CX9gxA8iUZ6Wp9mcAJiFbrmyhEfkmWmnc25RWIhYpeY8xzwuVRCtgvzxczDmy0G7WHQ/lgLKVsViP8pVHtuk6JvkVpDuwW3IORRLTIIUVp5v34pY9TJDWYQfwHytBFvgiYTx3BejTovD6jy3mqJcfaw9Syj+jOHgEdVwVqTDo0CJoWwR/MOHrfFUi9FmIGBIpE97IAJtUejDeGHq1o2GdvROBPbfAErnVSo7+uD2ob0Y61n+sg4SkZSuXKORULTP2QxOrPlnvO3erqMZjONY0m+gSpMelXagf70PD12YZ5dcDZSN+4TjaCyCjsFnY0CmdH+LWr98mCJ5r4Thq78X848oFt6gaqkOwKr/C1MJKTa/ALIwEeAjk+moJrN2g81gMbG880XcNfaBi9jwvaoJpTwPmion+i5Cy/jVDquUIEKQsFkyM01Ca4JA5wiERfR99HDQ3hjMndYiyLXtpZ3rCBrBujkYkpA2rahEPUISWz1+eCW58TbX74WMYEHiVVSIaaE6MTymw6Ms0bNoqCtbY58sVL5II+h4NyCtC/cMwebyFPmtVJQ76KIAb97z5gank77leDs+GSI9zBc079z7ivejZbNeT2Umt8Ri4xTKoRka/7ARDZ+waKJTIuaHEPrv6F3sMU5Pgt/BuZVmNqhcYZZQBIT X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(376002)(136003)(40470700004)(46966006)(36840700001)(4326008)(82310400005)(40480700001)(36860700001)(356005)(86362001)(82740400003)(54906003)(110136005)(81166007)(8676002)(70586007)(41300700001)(478600001)(5660300002)(8936002)(40460700003)(70206006)(47076005)(16526019)(316002)(6636002)(186003)(1076003)(2616005)(83380400001)(2906002)(44832011)(7696005)(426003)(15650500001)(336012)(26005)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 16:29:53.2636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7160cd53-f773-46b6-ad3f-08da89dbb3d8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3326 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The `check` callback is run right before the cores are put into HLT. This will allow checking synchronization problems with other software that writes into the STB. Signed-off-by: Mario Limonciello --- v2->v3: * Update for changes in patch 1/4. drivers/platform/x86/amd/pmc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index fba42036682d..32887687f888 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -41,6 +41,7 @@ #define AMD_PMC_STB_PMI_0 0x03E30600 #define AMD_PMC_STB_S2IDLE_PREPARE 0xC6000001 #define AMD_PMC_STB_S2IDLE_RESTORE 0xC6000002 +#define AMD_PMC_STB_S2IDLE_CHECK 0xC6000003 =20 /* STB S2D(Spill to DRAM) has different message port offset */ #define STB_SPILL_TO_DRAM 0xBE @@ -706,6 +707,16 @@ static void amd_pmc_s2idle_prepare(void) dev_err(pdev->dev, "error writing to STB: %d\n", rc); } =20 +static void amd_pmc_s2idle_check(void) +{ + struct amd_pmc_dev *pdev =3D &pmc; + int rc; + + rc =3D amd_pmc_write_stb(pdev, AMD_PMC_STB_S2IDLE_CHECK); + if (rc) + dev_err(pdev->dev, "error writing to STB: %d\n", rc); +} + static void amd_pmc_s2idle_restore(void) { struct amd_pmc_dev *pdev =3D &pmc; @@ -733,6 +744,7 @@ static void amd_pmc_s2idle_restore(void) =20 static struct acpi_s2idle_dev_ops amd_pmc_s2idle_dev_ops =3D { .prepare =3D amd_pmc_s2idle_prepare, + .check =3D amd_pmc_s2idle_check, .restore =3D amd_pmc_s2idle_restore, }; #endif --=20 2.34.1