From nobody Tue Apr 7 16:36:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA3EECAAD6 for ; Fri, 26 Aug 2022 18:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344441AbiHZSeI (ORCPT ); Fri, 26 Aug 2022 14:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbiHZSde (ORCPT ); Fri, 26 Aug 2022 14:33:34 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B23BE3C30; Fri, 26 Aug 2022 11:33:21 -0700 (PDT) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 15366FF806; Fri, 26 Aug 2022 18:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1661538800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4o3mcOJ3LXjZa5Hp4EJXM7u0pr41x6gcWEkiEDyC0Lk=; b=Tc77NU/jeX85h8eSEYFhfaV9iZThofyAq21eus+B4vfYp3/JAMHdlpGA+Z5uW/2spY3ZKs gJkMnvcNL/4RAdHLVduBmlxJC8/1fl7UA9H/CWrfpkQZ2HcjSJWDcGfU93Omh10/3nTog3 BE9hl97CiBXlK6nzXc6Wd9HlkPMda29BpRurD+UwQ9E+fIOsaLF2KKwYiXlODDX4u2lo4p xKBh8INOCAG0OnjS5ks9jzydELX11GsT5W5WfDUuNG+EggTltUXCXHEzN51CQUgwlyz7vd YUerCF6HX4PRwxmR4i8FPKgPhyfUFMmoSrnD9YTfEPuZPkDNCS23AUShCcpl9A== From: Paul Kocialkowski To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Cc: Yong Deng , Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: [PATCH v6 11/43] media: sun6i-csi: Register the media device after creation Date: Fri, 26 Aug 2022 20:32:08 +0200 Message-Id: <20220826183240.604834-12-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220826183240.604834-1-paul.kocialkowski@bootlin.com> References: <20220826183240.604834-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is no particular need to register the media device in the subdev notify complete callback. Register it in the v4l2 code instead where it's more in-context. Signed-off-by: Paul Kocialkowski Acked-by: Jernej Skrabec --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/m= edia/platform/sunxi/sun6i-csi/sun6i_csi.c index a55347b7a6d6..e3d60b647cb2 100644 --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c @@ -638,7 +638,7 @@ static int sun6i_subdev_notify_complete(struct v4l2_asy= nc_notifier *notifier) if (ret < 0) return ret; =20 - return media_device_register(&v4l2->media_dev); + return 0; } =20 static const struct v4l2_async_notifier_operations sun6i_csi_async_ops =3D= { @@ -685,6 +685,12 @@ static int sun6i_csi_v4l2_setup(struct sun6i_csi_devic= e *csi_dev) =20 media_device_init(media_dev); =20 + ret =3D media_device_register(media_dev); + if (ret) { + dev_err(dev, "failed to register media device: %d\n", ret); + goto error_media; + } + /* V4L2 Control Handler */ =20 ret =3D v4l2_ctrl_handler_init(&v4l2->ctrl_handler, 0); @@ -744,6 +750,7 @@ static int sun6i_csi_v4l2_setup(struct sun6i_csi_device= *csi_dev) v4l2_ctrl_handler_free(&v4l2->ctrl_handler); =20 error_media: + media_device_unregister(media_dev); media_device_cleanup(media_dev); =20 return ret; --=20 2.37.1