From nobody Thu Apr 9 12:00:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FB3C04AA5 for ; Thu, 25 Aug 2022 08:58:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237975AbiHYI6w (ORCPT ); Thu, 25 Aug 2022 04:58:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237255AbiHYI6h (ORCPT ); Thu, 25 Aug 2022 04:58:37 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B2DEA8CD2; Thu, 25 Aug 2022 01:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661417913; x=1692953913; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YcSvNB23AhSi5EswqOVHYUWtaN9VoCvzviSsnzaVGZo=; b=Vz3tdMAVMZJYa4sCxqp/mHg1yX+4SBT1g5I52dNaEtHuwa4K4p2/00sz CqLjnPHQfjhJmmvQ0/HN2DXBLu3432y+wlHv1ZvasrcJR6ED8V8Q7oiYF FZczXvN5Zz1s3LM98+VtcOJWezoEVJ6QUEQH5eTkxtv2SiIhUHce2Ccyz 9ehUqtTjSuTBTOuoB3AG78xVfHyXOESSLnViv0XKJsFIcwyHWsBweEdDk 0lTio3BoJ3fPiBnNKuIP+4TpQnkXLik9qZUPZ3/IpL2YitITQSM9rfjuy msj2v98/qeC1jTVH4QCPo1p6WHMbgZ8fX72QQbxspzpIt2rNxyAkrMBNL Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10449"; a="273941431" X-IronPort-AV: E=Sophos;i="5.93,262,1654585200"; d="scan'208";a="273941431" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2022 01:58:33 -0700 X-IronPort-AV: E=Sophos;i="5.93,262,1654585200"; d="scan'208";a="670893942" Received: from mblazque-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.249.44.101]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2022 01:58:31 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH 4/5] serial: sunsab: Remove frame size calculation dead-code Date: Thu, 25 Aug 2022 11:58:09 +0300 Message-Id: <20220825085810.7290-5-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220825085810.7290-1-ilpo.jarvinen@linux.intel.com> References: <20220825085810.7290-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver features a custom frame length calculation but the result is never used. Remove it. Signed-off-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/sunsab.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial/sunsab.c b/drivers/tty/serial/sunsab.c index 6ea52293d9f3..f7968f73753d 100644 --- a/drivers/tty/serial/sunsab.c +++ b/drivers/tty/serial/sunsab.c @@ -681,27 +681,23 @@ static void sunsab_convert_to_sab(struct uart_sunsab_= port *up, unsigned int cfla unsigned int quot) { unsigned char dafo; - int bits, n, m; + int n, m; =20 /* Byte size and parity */ switch (cflag & CSIZE) { - case CS5: dafo =3D SAB82532_DAFO_CHL5; bits =3D 7; break; - case CS6: dafo =3D SAB82532_DAFO_CHL6; bits =3D 8; break; - case CS7: dafo =3D SAB82532_DAFO_CHL7; bits =3D 9; break; - case CS8: dafo =3D SAB82532_DAFO_CHL8; bits =3D 10; break; + case CS5: dafo =3D SAB82532_DAFO_CHL5; break; + case CS6: dafo =3D SAB82532_DAFO_CHL6; break; + case CS7: dafo =3D SAB82532_DAFO_CHL7; break; + case CS8: dafo =3D SAB82532_DAFO_CHL8; break; /* Never happens, but GCC is too dumb to figure it out */ - default: dafo =3D SAB82532_DAFO_CHL5; bits =3D 7; break; + default: dafo =3D SAB82532_DAFO_CHL5; break; } =20 - if (cflag & CSTOPB) { + if (cflag & CSTOPB) dafo |=3D SAB82532_DAFO_STOP; - bits++; - } =20 - if (cflag & PARENB) { + if (cflag & PARENB) dafo |=3D SAB82532_DAFO_PARE; - bits++; - } =20 if (cflag & PARODD) { dafo |=3D SAB82532_DAFO_PAR_ODD; --=20 2.30.2