From nobody Tue Apr 7 21:27:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2EC5C28D13 for ; Thu, 25 Aug 2022 04:39:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbiHYEjT (ORCPT ); Thu, 25 Aug 2022 00:39:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230038AbiHYEjP (ORCPT ); Thu, 25 Aug 2022 00:39:15 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F96A9D8D4 for ; Wed, 24 Aug 2022 21:39:14 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id s36-20020a17090a69a700b001faad0a7a34so3695173pjj.4 for ; Wed, 24 Aug 2022 21:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=aWppyUtM+Ea1Sr+ncZrJMkFAdR9P7Fn07pUZ4EuIiPw=; b=Ohfw9I2Oi0RoWD+PbEpH6aUJtS0tOh4ruoTJ4LwFKthdU9FnM4DnqiOFIYjiDnyExl 43c4oIGrwWmSQXC1Dy3mgBUAcP+wxzg4hW51gN2+B1M1ED91k63HuMEgKmzxnLPIVbLA 5+gqqdt0+75xUdDI3VX9LT6cC86s1dOL7HVT/frF22b3NLT3kANaBcKm45urvmNCgli0 h33NBqk6YCd28ABUllGtvgcE/Id/ZelpWwZngTmBzrQxq4bv8ZucdpS13Lw5kuGNNLGI Wn+Q/CdSfmUsVE9WCuxIZf51bEhWefioc8IsY9uG3LfY7VMzjpEoF0bo/98cWuHpR1Ja 6cDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=aWppyUtM+Ea1Sr+ncZrJMkFAdR9P7Fn07pUZ4EuIiPw=; b=h5aOpMSYcctKvvB/ctu5cGKWcaH6/uueEAgh/qfWbGaD4IQZdI/tvZNW/ZUUx8ClD1 DmEWzaMXy+x5SWSXBvvWB+HD1Tt1QoqcOJGvFo3g8Fmh/ezNchia+N/jzdg+12LoO5MO J/lNR8znUmRWS5hjpAOmj978Rp9cl3bWsaQXAyar2thxwLqV3nCNo1mYZ5RBq5Qz4ViA IEb2OEQi4BdrHWuU+bnH1zPoNhnRoIsmSWEbsJcUI6r4o3m25gnRPENqKjle993XXANj tLr0JElfJlpN9arzDJTMApEJnSol6mLxE+OtP/B8ZjF7XwD3PTIknuL3DOQeuhgo/AHU Ku5g== X-Gm-Message-State: ACgBeo20uOw8zqCyKHznh1NA29lpI4j8mcNhgFvs33BUqW04LZH06KMm 1Gu64usXs4b96ZFzTUJGr/WF X-Google-Smtp-Source: AA6agR7YwTO3FKw89YVvxmLuWLLsTUs4qM9Z8BTuTggXyxmIU27IIrbZFX/+YFTP/wGkSus9OGLRfQ== X-Received: by 2002:a17:903:245:b0:16f:85be:f33b with SMTP id j5-20020a170903024500b0016f85bef33bmr2214611plh.96.1661402353840; Wed, 24 Aug 2022 21:39:13 -0700 (PDT) Received: from localhost.localdomain ([117.207.24.28]) by smtp.gmail.com with ESMTPSA id i11-20020a17090a64cb00b001fa9f86f20csm2294296pjm.49.2022.08.24.21.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 21:39:13 -0700 (PDT) From: Manivannan Sadhasivam To: bjorn.andersson@linaro.org, bp@alien8.de, mchehab@kernel.org Cc: james.morse@arm.com, rric@kernel.org, linux-arm-msm@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, quic_tsoni@quicinc.com, quic_saipraka@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v3 1/5] soc: qcom: llcc: Rename reg_offset structs to reflect LLCC version Date: Thu, 25 Aug 2022 10:08:55 +0530 Message-Id: <20220825043859.30066-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825043859.30066-1-manivannan.sadhasivam@linaro.org> References: <20220825043859.30066-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The register offsets used by the LLCC block retains its layout for multiple versions. For instance, starting from version v1.0.0 to v2.0.1 the offsets are same. And starting from v2.1.0, the offsets changed. But the current reg_offset naming convention is confusing. So to reflect this change correctly in driver, let's encode the start version from which the offsets got changed in reg_offset struct name. This will be llcc_v1_reg_offset for v1.0.0 and llcc_v2_1_reg_offset for v2.1.0. This will allow multiple SoCs to use the same reg_offset clearly. And in the future if the offsets got changed again, then that specific version could be encoded in the struct name. Suggested-by: Sai Prakash Ranjan Signed-off-by: Manivannan Sadhasivam Reviewed-by: Sai Prakash Ranjan --- drivers/soc/qcom/llcc-qcom.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 38d7296315a2..0dc2bb0c23cc 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -296,12 +296,14 @@ static const struct llcc_slice_config sm8450_data[] = =3D { {LLCC_AENPU, 8, 2048, 1, 1, 0xFFFF, 0x0, 0, 0, 0, 0, 0, 0, 0 }, }; =20 -static const u32 llcc_v1_2_reg_offset[] =3D { +/* LLCC register offset starting from v1.0.0 */ +static const u32 llcc_v1_reg_offset[] =3D { [LLCC_COMMON_HW_INFO] =3D 0x00030000, [LLCC_COMMON_STATUS0] =3D 0x0003000c, }; =20 -static const u32 llcc_v21_reg_offset[] =3D { +/* LLCC register offset starting from v2.0.1 */ +static const u32 llcc_v2_1_reg_offset[] =3D { [LLCC_COMMON_HW_INFO] =3D 0x00034000, [LLCC_COMMON_STATUS0] =3D 0x0003400c, }; @@ -310,70 +312,70 @@ static const struct qcom_llcc_config sc7180_cfg =3D { .sct_data =3D sc7180_data, .size =3D ARRAY_SIZE(sc7180_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sc7280_cfg =3D { .sct_data =3D sc7280_data, .size =3D ARRAY_SIZE(sc7280_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sc8180x_cfg =3D { .sct_data =3D sc8180x_data, .size =3D ARRAY_SIZE(sc8180x_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sc8280xp_cfg =3D { .sct_data =3D sc8280xp_data, .size =3D ARRAY_SIZE(sc8280xp_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sdm845_cfg =3D { .sct_data =3D sdm845_data, .size =3D ARRAY_SIZE(sdm845_data), .need_llcc_cfg =3D false, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sm6350_cfg =3D { .sct_data =3D sm6350_data, .size =3D ARRAY_SIZE(sm6350_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sm8150_cfg =3D { .sct_data =3D sm8150_data, .size =3D ARRAY_SIZE(sm8150_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sm8250_cfg =3D { .sct_data =3D sm8250_data, .size =3D ARRAY_SIZE(sm8250_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sm8350_cfg =3D { .sct_data =3D sm8350_data, .size =3D ARRAY_SIZE(sm8350_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v1_2_reg_offset, + .reg_offset =3D llcc_v1_reg_offset, }; =20 static const struct qcom_llcc_config sm8450_cfg =3D { .sct_data =3D sm8450_data, .size =3D ARRAY_SIZE(sm8450_data), .need_llcc_cfg =3D true, - .reg_offset =3D llcc_v21_reg_offset, + .reg_offset =3D llcc_v2_1_reg_offset, }; =20 static struct llcc_drv_data *drv_data =3D (void *) -EPROBE_DEFER; --=20 2.25.1