From nobody Wed Apr 8 02:52:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52B3C00140 for ; Wed, 24 Aug 2022 04:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234238AbiHXECG (ORCPT ); Wed, 24 Aug 2022 00:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbiHXECC (ORCPT ); Wed, 24 Aug 2022 00:02:02 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E453F71BFA; Tue, 23 Aug 2022 21:01:59 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id x63-20020a17090a6c4500b001fabbf8debfso302036pjj.4; Tue, 23 Aug 2022 21:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=6rqGt2HECmyWVySSRPmsVLXpDMjQHW89zdrF6Uaa9Go=; b=qNI+Wccmbs61DxivbeWnR1PjHf3zguDNC7LtoV1kGJKl47X802NludrCcVmEhX8ln+ 1wQu8kbrw0IgIxqNey60vBcraFpHVA33aVXBBGKss9e+zrYSIGS1tetTQkEbAwVHaQIt 60veos1D8ou+tXlqwuRvWlx6/+L4xRn3vza4MstspX3coyHvXDna3c6oDG353Uuzzgxo OiLlCXqw65P9wJsN8nhiPee09D8dAa1Rh2mGkwlchVdQR2UdcvNn1hM+A4Fzoc/NXbPj tgpufNqW2dOjTgaE6SX5ujQZmOXBm4EhaotnPf/uw5cljbCKhqZi39GfSBeyDF4R/8Z7 NB1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=6rqGt2HECmyWVySSRPmsVLXpDMjQHW89zdrF6Uaa9Go=; b=BScE749Eoedg4Pcjt2yn6H11e8pT+a/qMyf07exYfZGGcvyMJxAGVYFMvZvv4X6jWr fIXy3Esj/UfBh3N+B/YIzBHGJzdCfdNgq4qC+0rNb8xcjuWd+IzHCPc5soP+PsDvplyC 4l9F6RA1Nr0lO5VkkrqxHBpyIIsKToYVrXL1tBxeYVgpjXL6GTmqojma9+M6Me6SV0Xc h+6vr6caVISr+nEZTL8jU9BBHfIeoLknqs9YD31DVw8xNIgbl0QlUu9L/zkwgFMNgxiP 2MO6fPTdC6TaK+Gv3s2s34R2l9wxPdelhTSrX+UGGPu9d4aaaSjzG3w08SONCb63+eT0 sIpA== X-Gm-Message-State: ACgBeo3m7Vg32VVVmRRkmhwqkkh3leSDR5KPDlifFWW/US+QgMbpQgP4 IMmWymW1/lYpTmFPNCQXb1I= X-Google-Smtp-Source: AA6agR6dILThb7G09ug65nK1BovcekJnf2vbw8kik1d+rkwqW/XM/BP71zTpQFYe0ePfp9Lz/oqoKA== X-Received: by 2002:a17:902:bd08:b0:16e:e00c:dd48 with SMTP id p8-20020a170902bd0800b0016ee00cdd48mr27294120pls.93.1661313719363; Tue, 23 Aug 2022 21:01:59 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id bk2-20020a056a02028200b0041c0c9c0072sm9925880pgb.64.2022.08.23.21.01.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 21:01:59 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: akpm@linux-foundation.org Cc: adobriyan@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, xu xin , Xiaokai Ran , Yang Yang , CGEL ZTE Subject: [PATCH v2 1/2] ksm: count allocated ksm rmap_items for each process Date: Wed, 24 Aug 2022 04:01:53 +0000 Message-Id: <20220824040153.215059-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220824040036.215002-1-xu.xin16@zte.com.cn> References: <20220824040036.215002-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" KSM can save memory by merging identical pages, but also can consume additional memory, because it needs to generate rmap_items to save each scanned page's brief rmap information. Some of these pages may be merged, but some may not be abled to be merged after being checked several times, which are unprofitable memory consumed. The information about whether KSM save memory or consume memory in system-wide range can be determined by the comprehensive calculation of pages_sharing, pages_shared, pages_unshared and pages_volatile. A simple approximate calculation: profit =3D~ pages_sharing * sizeof(page) - (all_rmap_items) * sizeof(rmap_item); where all_rmap_items equals to the sum of pages_sharing, pages_shared, pages_unshared and pages_volatile. But we cannot calculate this kind of ksm profit inner single-process wide because the information of ksm rmap_item's number of a process is lacked. For user applications, if this kind of information could be obtained, it helps upper users know how beneficial the ksm-policy (like madvise) they are using brings, and then optimize their app code. For example, one application madvise 1000 pages as MERGEABLE, while only a few pages are really merged, then it's not cost-efficient. So we add a new interface /proc//ksm_rmp_items for each process to indicate the total allocated ksm rmap_items of this process. Similarly, we can calculate the ksm profit approximately for a single-process by: profit =3D~ ksm_merging_pages * sizeof(page) - ksm_rmp_items * sizeof(rmap_item); where ksm_merging_pages and ksm_rmp_items are both under /proc//. Signed-off-by: xu xin Reviewed-by: Xiaokai Ran Reviewed-by: Yang Yang Signed-off-by: CGEL ZTE --- fs/proc/base.c | 15 +++++++++++++++ include/linux/mm_types.h | 5 +++++ mm/ksm.c | 2 ++ 3 files changed, 22 insertions(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index 93f7e3d971e4..b6317981492a 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -3196,6 +3196,19 @@ static int proc_pid_ksm_merging_pages(struct seq_fil= e *m, struct pid_namespace * =20 return 0; } +static int proc_pid_ksm_rmp_items(struct seq_file *m, struct pid_namespace= *ns, + struct pid *pid, struct task_struct *task) +{ + struct mm_struct *mm; + + mm =3D get_task_mm(task); + if (mm) { + seq_printf(m, "%lu\n", mm->ksm_rmp_items); + mmput(mm); + } + + return 0; +} #endif /* CONFIG_KSM */ =20 #ifdef CONFIG_STACKLEAK_METRICS @@ -3331,6 +3344,7 @@ static const struct pid_entry tgid_base_stuff[] =3D { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; =20 @@ -3668,6 +3682,7 @@ static const struct pid_entry tid_base_stuff[] =3D { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; =20 diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index cf97f3884fda..0b9e76275ea7 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -671,6 +671,11 @@ struct mm_struct { * merging. */ unsigned long ksm_merging_pages; + /* + * Represent how many pages are checked for ksm merging + * including merged and not merged. + */ + unsigned long ksm_rmp_items; #endif } __randomize_layout; =20 diff --git a/mm/ksm.c b/mm/ksm.c index 478bcf26bfcd..fc9879d7049f 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -421,6 +421,7 @@ static inline struct rmap_item *alloc_rmap_item(void) static inline void free_rmap_item(struct rmap_item *rmap_item) { ksm_rmap_items--; + rmap_item->mm->ksm_rmp_items--; rmap_item->mm =3D NULL; /* debug safety */ kmem_cache_free(rmap_item_cache, rmap_item); } @@ -2265,6 +2266,7 @@ static struct rmap_item *get_next_rmap_item(struct mm= _slot *mm_slot, if (rmap_item) { /* It has already been zeroed */ rmap_item->mm =3D mm_slot->mm; + rmap_item->mm->ksm_rmp_items++; rmap_item->address =3D addr; rmap_item->rmap_list =3D *rmap_list; *rmap_list =3D rmap_item; --=20 2.25.1 From nobody Wed Apr 8 02:52:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC7EC00140 for ; Wed, 24 Aug 2022 04:03:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234472AbiHXEDZ (ORCPT ); Wed, 24 Aug 2022 00:03:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbiHXEDX (ORCPT ); Wed, 24 Aug 2022 00:03:23 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9F9E79610; Tue, 23 Aug 2022 21:03:19 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id x19so12545574pfq.1; Tue, 23 Aug 2022 21:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=C9ysgA8b1YgCBIvEexgqiQq6OdwO0KDUjA0c2BYGnmA=; b=VEsHOnCWEXfZFWljS3gMXqT+43LsE3qQQEn6Wxws2JCmIAj78tGJc65sRXirHy62g9 o4Vkh+lrklx0j5niQvV1bTn5+OvjBmMSXd1f3nOBgrUtssCjOwAigJ8NOzks/Gf5v+2P tHKZK+1d97PbfG94gV7iFbXwNlCD/U16aA6QaUmNlu7BSlQAmPYh8np1fNKRqVolcGK/ Hh/05DNxZN50tBa+DXpz6wGuH2S7mTQiZvV5hpEhBVZanzKiRQdEns9K5Am8sDbsGWmR opE8XDGLDhiQA7CMWo8HA3g39ytKGDIs+5RM2P3hyMIAHCOo5zZZH0XgjxgtYNw0WqEJ 6NGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=C9ysgA8b1YgCBIvEexgqiQq6OdwO0KDUjA0c2BYGnmA=; b=XwGwZtdv7zRkaKaftusrpP1FEw5jGzDaULoLmdZLhsqcx6Mz9JGmHtS+cOCmHs6tlk AgS2f4rhW6WATjC7u8S1iARWshAVKoyKvYBZ0csSO9bXcKYlcApwy82oHKbI5VGQJFMY zrV71LW/WcA0xWlKAHsE1F+z0S/gzWfHspFy0waMJm+t0klziC6XIZLOaSa7O/NOReKV 92Ra79RMV0tKeZkCfL2QYz2L5IXgpNcqnxJ+lnLgshZO/jVKXFsjVKtGYnqv0z3AadM6 r7kUudejoa6YPaZ+EUE6l8+choLhj3PTWMZ3jeLHQYBwHHyJV1vL6Q6TIH5bSKECor5j QpAQ== X-Gm-Message-State: ACgBeo24AOG7LYPHCCKnvP0m/pAOOWh9WQeWqlAQaRo59j6/GRIhP5oX CErRNPQeYUmZS8Y9JNnC7rk= X-Google-Smtp-Source: AA6agR6IzgeF8jGuGG1mbk2YL+egSHkQLMmccGQwPlHhVJ1tdw9/WNs4QOtdcEhb/viGaO7zAfJ1Wg== X-Received: by 2002:a05:6a00:244a:b0:52b:e9a8:cb14 with SMTP id d10-20020a056a00244a00b0052be9a8cb14mr28070025pfj.32.1661313799208; Tue, 23 Aug 2022 21:03:19 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id n17-20020a170902e55100b0016dbaf3ff2esm11427481plf.22.2022.08.23.21.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 21:03:18 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: akpm@linux-foundation.org, corbet@lwn.net Cc: adobriyan@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, xu xin , Xiaokai Ran , Yang Yang Subject: [PATCH v2 2/2] ksm: add profit monitoring documentation Date: Wed, 24 Aug 2022 04:03:13 +0000 Message-Id: <20220824040313.215119-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220824040036.215002-1-xu.xin16@zte.com.cn> References: <20220824040036.215002-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the description of KSM profit and how to determine it separately in system-wide range and inner a single process. Signed-off-by: xu xin Reviewed-by: Xiaokai Ran Reviewed-by: Yang Yang --- Documentation/admin-guide/mm/ksm.rst | 36 ++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-gui= de/mm/ksm.rst index b244f0202a03..40bc11f6fa15 100644 --- a/Documentation/admin-guide/mm/ksm.rst +++ b/Documentation/admin-guide/mm/ksm.rst @@ -184,6 +184,42 @@ The maximum possible ``pages_sharing/pages_shared`` ra= tio is limited by the ``max_page_sharing`` tunable. To increase the ratio ``max_page_sharing`` m= ust be increased accordingly. =20 +Monitoring KSM profit +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +KSM can save memory by merging identical pages, but also can consume +additional memory, because it needs to generate a number of rmap_items to +save each scanned page's brief rmap information. Some of these pages may +be merged, but some may not be abled to be merged after being checked +several times, which are unprofitable memory consumed. + +1) How to determine whether KSM save memory or consume memory in system-wi= de +range? Here is a simple approximate calculation for reference: + + general_profit =3D~ pages_sharing * sizeof(page) - (all_rmap_items) * + sizeof(rmap_item); + +where all_rmap_items can be easily obtained by summing ``pages_sharing``, +``pages_shared``, ``pages_unshared`` and ``pages_volatile``. + +2) The KSM profit inner a single process can be similarly obtained by the +following approximate calculation: + + process_profit =3D~ ksm_merging_sharing * sizeof(page) - + ksm_rmp_items * sizeof(rmap_item). + +where both ksm_merging_sharing and ksm_rmp_items are shown under the direc= tory +``/proc//``. + +From the perspective of application, a high ratio of ``ksm_rmp_items`` to +``ksm_merging_sharing`` means a bad madvise-applied policy, so developers = or +administrators have to rethink how to change madvise policy. Giving an exa= mple +for reference, a page's size is usually 4K, and the rmap_item's size is +separately 32B on 32-bit CPU architecture and 64B on 64-bit CPU architectu= re. +so if the ``ksm_rmp_items/ksm_merging_sharing`` ratio exceeds 64 on 64-bit= CPU +or exceeds 128 on 32-bit CPU, then the app's madvise policy should be drop= ped, +because the ksm profit is approximately zero or negative. + Monitoring KSM events =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.25.1