From nobody Thu Dec 18 12:47:27 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 128F2C32792 for ; Tue, 23 Aug 2022 08:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241304AbiHWI7z (ORCPT ); Tue, 23 Aug 2022 04:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242382AbiHWI7a (ORCPT ); Tue, 23 Aug 2022 04:59:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 091D47390D; Tue, 23 Aug 2022 01:26:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F9FE6132D; Tue, 23 Aug 2022 08:19:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9620EC433C1; Tue, 23 Aug 2022 08:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661242780; bh=XlMZgAVmfzFK13clljcDaBlkofv50XjrF8t/pOrnWB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=02JmD+6zlWbV8ucyrKGnxopIWxMIOa3Eu92BjLeo8jDw/l5+kBtSRbnpMCv4ap8BG YKEaswPB+NkA8eS6dcPBgOIdY9VmMDzkSuMr5ml8ojl/Idfk/ekgGFKe8m6ofv17GQ Re84frg140FpQNhXjRlhbyDzH40m6TOwLIz1isg4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pablo Neira Ayuso Subject: [PATCH 5.19 196/365] netfilter: nf_tables: possible module reference underflow in error path Date: Tue, 23 Aug 2022 10:01:37 +0200 Message-Id: <20220823080126.432710514@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220823080118.128342613@linuxfoundation.org> References: <20220823080118.128342613@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Pablo Neira Ayuso commit c485c35ff6783ccd12c160fcac6a0e504e83e0bf upstream. dst->ops is set on when nft_expr_clone() fails, but module refcount has not been bumped yet, therefore nft_expr_destroy() leads to module reference underflow. Fixes: 8cfd9b0f8515 ("netfilter: nftables: generalize set expressions suppo= rt") Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/nf_tables_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -5566,7 +5566,7 @@ int nft_set_elem_expr_clone(const struct =20 err =3D nft_expr_clone(expr, set->exprs[i]); if (err < 0) { - nft_expr_destroy(ctx, expr); + kfree(expr); goto err_expr; } expr_array[i] =3D expr;