From nobody Thu Dec 18 13:02:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17511C32774 for ; Tue, 23 Aug 2022 08:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241864AbiHWIJk (ORCPT ); Tue, 23 Aug 2022 04:09:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240089AbiHWIIi (ORCPT ); Tue, 23 Aug 2022 04:08:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 867EA2F3B9; Tue, 23 Aug 2022 01:05:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 64972B81C20; Tue, 23 Aug 2022 08:05:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6126C433D6; Tue, 23 Aug 2022 08:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661241939; bh=cf9BwUvZvDQMwkdXe0mV+IKj6xyH7BXJvPveNDCzud8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vVplw9goX3xMY7LwuEN+jSjxJRgke+Mg/xmc/PjNhcGWgtEoOjGG8VWlUK2iyZci3 FHsU/ZDuHryqCt9lYr9UNJREuJZ7QaIEM8cMj/59ldp6VabrxYt+VPGS+cJuvcvCSg HpyvFyrtTELBYWrT96k8DQ+O6ki6p7pv9rwSv1ig= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Wilson , Fei Yang , Tvrtko Ursulin , Andi Shyti , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Mauro Carvalho Chehab , Rodrigo Vivi Subject: [PATCH 5.19 025/365] drm/i915/gt: Skip TLB invalidations once wedged Date: Tue, 23 Aug 2022 09:58:46 +0200 Message-Id: <20220823080119.270557694@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220823080118.128342613@linuxfoundation.org> References: <20220823080118.128342613@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Wilson commit e5a95c83ed1492c0f442b448b20c90c8faaf702b upstream. Skip all further TLB invalidations once the device is wedged and had been reset, as, on such cases, it can no longer process instructions on the GPU and the user no longer has access to the TLB's in each engine. So, an attempt to do a TLB cache invalidation will produce a timeout. That helps to reduce the performance regression introduced by TLB invalidate logic. Cc: stable@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Tvrtko Ursulin Reviewed-by: Andi Shyti Acked-by: Thomas Hellstr=C3=B6m Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Andi Shyti Link: https://patchwork.freedesktop.org/patch/msgid/5aa86564b9ec5fe7fe605c1= dd7de76855401ed73.1658924372.git.mchehab@kernel.org (cherry picked from commit be0366f168033374a93e4c43fdaa1a90ab905184) Signed-off-by: Rodrigo Vivi Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/gt/intel_gt.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -1191,6 +1191,9 @@ void intel_gt_invalidate_tlbs(struct int if (I915_SELFTEST_ONLY(gt->awake =3D=3D -ENODEV)) return; =20 + if (intel_gt_is_wedged(gt)) + return; + if (GRAPHICS_VER(i915) =3D=3D 12) { regs =3D gen12_regs; num =3D ARRAY_SIZE(gen12_regs);