From nobody Tue Apr 14 17:13:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3856C32793 for ; Mon, 22 Aug 2022 11:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbiHVLxc (ORCPT ); Mon, 22 Aug 2022 07:53:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232841AbiHVLxM (ORCPT ); Mon, 22 Aug 2022 07:53:12 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B570B33A15; Mon, 22 Aug 2022 04:53:09 -0700 (PDT) Received: from stanislav-HLY-WX9XX.. (unknown [46.172.13.71]) by mail.ispras.ru (Postfix) with ESMTPSA id 12A9640D4004; Mon, 22 Aug 2022 11:53:01 +0000 (UTC) From: Stanislav Goriainov To: Miklos Szeredi Cc: Stanislav Goriainov , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] ovl: Fix potential memory leak Date: Mon, 22 Aug 2022 14:52:57 +0300 Message-Id: <20220822115257.7457-1-goriainov@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" ovl: Fix potential memory leak in ovl_lookup() If memory for uperredirect was allocated with kstrdup() in upperdir !=3D NULL and d.redirect !=3D NULL path, it may be lost when upperredirect is reassigned later. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Stanislav Goriainov Reviewed-by: David Disseldorp --- fs/overlayfs/namei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c index 69dc577974f8..226c69812379 100644 --- a/fs/overlayfs/namei.c +++ b/fs/overlayfs/namei.c @@ -1085,6 +1085,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct d= entry *dentry, .mnt =3D ovl_upper_mnt(ofs), }; =20 + kfree(upperredirect); upperredirect =3D ovl_get_redirect_xattr(ofs, &upperpath, 0); if (IS_ERR(upperredirect)) { err =3D PTR_ERR(upperredirect); --=20 2.34.1