From nobody Fri Apr 10 15:43:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25716C28D13 for ; Mon, 22 Aug 2022 16:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236427AbiHVQqf (ORCPT ); Mon, 22 Aug 2022 12:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235283AbiHVQqe (ORCPT ); Mon, 22 Aug 2022 12:46:34 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7708D1D0DF for ; Mon, 22 Aug 2022 09:46:33 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-336c3b72da5so191779887b3.6 for ; Mon, 22 Aug 2022 09:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc; bh=rtaEMsVUgxkEpbiKW/IF/USL8m9F2ihukaZ79pkCq9I=; b=mjqMv7yH264vsDiv7u0L+VSabvq7vtfkSvTACtXqss1McRB5WTAjXotwOuQPfHoVcI 4ALfVqaz/i/+R9HFZDHd+cuKM2aZXIOo9h27kRzBozz1Bfou4C32SWVET0W4VM7ykgig F4kFVGyhXN+nCcvNwy+4Fo87+LmmRcAhkTRCN9tBMOKRJeA2w0aNEywMYbBGWbZwfa2V Jc1mjfXsz5UWcDQba1FCyc5jtmXgulIIjtprrGPdbZawbNtPC6+x14nLlJBYPNGHxRxH X+nmRev7OSqjtLLteH/fslfAn46KdkaDn+SDK1icthm98S5+HJ7m+Z32FyvCyEtvnB2t 32qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc; bh=rtaEMsVUgxkEpbiKW/IF/USL8m9F2ihukaZ79pkCq9I=; b=1+GgFJAMjwcTDeYaRUydGj0UslxW6DS7u/XjrnL4P8lQvLODh+JVoRIYcGsjG+S/mP dc8sPtMcLH1Ed7N1z3yigWh9zmvYAjXEdDQXmSiR9HVb6fSX5tO8ynJRo8FPgmIAa3bh FS19gUEZaI/i9Uc6e65aMVfu5ychUTkkqFXmFgkpW6JYDN7QvC8dO8l1+310vsNsaDQO S3MTHxw71/x2ClNFuxgEPiq6PpMhcGIA4PTzLmkScgKgwleD2FYpNrfRpd0eZPA1VbU8 9aD2e7EYH2/soc7ofQ+lnTpFsVvSibMPMtTNP704BiTh4phqZvySc9RlbeovTE5lZO7v DjNA== X-Gm-Message-State: ACgBeo0IJ9ZN4r1qlpF+ybhyfNlXUcnS5XsFzOI+YrX4f+JyRWTUmBnn NxX3cbC7BSeA2tzMDDVkoLwQQgRePA== X-Google-Smtp-Source: AA6agR73Sy+VVh3pbE8Fb3F5GAchuoB8ByQOwyUn1gZ4RUvfD1b2rHWZBQAjl5Z99T3oBIwnrEepHKeZpg== X-Received: from timvp-p620-9115096.bld.corp.google.com ([2620:15c:183:200:762:7c61:946f:731]) (user=timvp job=sendgmr) by 2002:a05:690c:823:b0:339:cd73:5be9 with SMTP id by3-20020a05690c082300b00339cd735be9mr11068057ywb.21.1661186792797; Mon, 22 Aug 2022 09:46:32 -0700 (PDT) Date: Mon, 22 Aug 2022 10:46:30 -0600 Message-Id: <20220822104624.v5.1.If155ede36f7d344f15d153d5d75b45c7612bcb8c@changeid> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog Subject: [PATCH v5] platform/chrome: cros_ec_lpc: Move host event to prepare/complete From: Tim Van Patten To: rrangel@chromium.org, robbarnes@google.com Cc: Tim Van Patten , Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM .prepare() and cros_ec_lpc_complete() during .complete(). This moves the host event that the AP sends and allows the EC to log entry/exit of AP's suspend/resume more accurately. Signed-off-by: Tim Van Patten --- Changes in v5: - Restore fixes from v3. Changes in v4: - Update title and description. Changes in v3: - Update cros_ec_lpc_suspend() to cros_ec_lpc_prepare() - Update cros_ec_lpc_resume() to cros_ec_lpc_complete() Changes in v2: - Include cros_ec_resume() return value in dev_info() output. - Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP. drivers/platform/chrome/cros_ec_lpc.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrom= e/cros_ec_lpc.c index 7677ab3c0ead..5a8f3a3f9c85 100644 --- a/drivers/platform/chrome/cros_ec_lpc.c +++ b/drivers/platform/chrome/cros_ec_lpc.c @@ -530,23 +530,31 @@ static const struct dmi_system_id cros_ec_lpc_dmi_tab= le[] __initconst =3D { MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table); =20 #ifdef CONFIG_PM_SLEEP -static int cros_ec_lpc_suspend(struct device *dev) +static int cros_ec_lpc_prepare(struct device *dev) { struct cros_ec_device *ec_dev =3D dev_get_drvdata(dev); =20 + dev_info(dev, "Prepare EC suspend\n"); + return cros_ec_suspend(ec_dev); } =20 -static int cros_ec_lpc_resume(struct device *dev) +static int cros_ec_lpc_complete(struct device *dev) { struct cros_ec_device *ec_dev =3D dev_get_drvdata(dev); + int ret; + + ret =3D cros_ec_resume(ec_dev); =20 - return cros_ec_resume(ec_dev); + dev_info(dev, "EC resume completed: ret =3D %d\n", ret); } #endif =20 static const struct dev_pm_ops cros_ec_lpc_pm_ops =3D { - SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume) +#ifdef CONFIG_PM_SLEEP + .prepare =3D cros_ec_lpc_prepare, + .complete =3D cros_ec_lpc_complete +#endif }; =20 static struct platform_driver cros_ec_lpc_driver =3D { --=20 2.37.1.595.g718a3a8f04-goog