From nobody Fri Apr 10 17:09:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC51BC3F6B0 for ; Mon, 22 Aug 2022 01:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232244AbiHVBha (ORCPT ); Sun, 21 Aug 2022 21:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231851AbiHVBh2 (ORCPT ); Sun, 21 Aug 2022 21:37:28 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB37320F44; Sun, 21 Aug 2022 18:37:26 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id r69so8132554pgr.2; Sun, 21 Aug 2022 18:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=JYeDgo4BH0cqlWQE9A7b6GDBdTM8D8fxekVdXdAbBXo=; b=EgI2rsJEN8dXZrcfyF0z/7L6GsEorS3Y/X2XqgoYPFA4Dfc7MVK8Et6vUwSdr0RtY5 UME69CrAeLPmbGkOHb4R6rzEwCX0dLqGtsp/HUXpgowaFdnsvj0182mby1dI3wntBEax jvQwcwr4omNIqNahfhXuAJbmRem/uSzzytG0XYL5RNrWWzpSlXzu8oHQ9Y7OIsw1v4Oe o+uimydwqmIfc1T+8f91MS1nIxPpQFgU5xoasR6Mo+y0Uk+wu7xEaZcfYD+42yl/HWBy EQE44kzBBIBlNDZ4Vu54kDs91A0Bdv01cOIFdEyYAWIMqzansrrH6wkKB4MrqchYczlc PysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=JYeDgo4BH0cqlWQE9A7b6GDBdTM8D8fxekVdXdAbBXo=; b=3xx0MOHCNDcT7Ts3qjOaBjO91TxHKUSyYMr2FLvVtsfv3Irwooa1HgDCoZtYLRfEdM 3pfduBhr7ze1uZhK/8r5JhWPe+Bc72VGmIKQg1QDFCck1CiGL/OeimAenIP92ibaE/CH U5GmfmtIypaSAcVGA6Oj/EAxZ3c24GlwCoELdrtNkHv0IWYsvenVggwcUm1lLS/nxoqz HpStcZ0TjBwLsCaKYb50ixNSnsZNmzWTQTaMDUTniaAfv6Fa1zFsmprLrNpZhjH7bfWr PKAmkYLjsBlcgH6uVdybU7wspSw6OuO0Jcp95XHzSwfBUif/CMfCFTbHCayilfGSjg1H NQ7g== X-Gm-Message-State: ACgBeo22Kgmap8cBvV4ZuPRRgMXDf2U2Z/9kY25Y10fDvVl0Y5kVBpIP dBdWKjduO7yJ19ga8Rym4Jlm/F6jeqY= X-Google-Smtp-Source: AA6agR480J6nT8JPDWkIdj0GINl2OslL/GR05i5SE5Z+09zC9SyVLBrf89VzEYsRUdV+7hj1/cUCdQ== X-Received: by 2002:a05:6a02:115:b0:41c:4d5f:876 with SMTP id bg21-20020a056a02011500b0041c4d5f0876mr15480717pgb.419.1661132246112; Sun, 21 Aug 2022 18:37:26 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id x3-20020a170902a38300b0016f154c8910sm7044406pla.204.2022.08.21.18.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Aug 2022 18:37:25 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: ye.xingchen@zte.com.cn To: seanjc@google.com Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, ye xingchen Subject: [PATCH linux-next v2] KVM: SVM: Remove the unneeded result variable Date: Mon, 22 Aug 2022 01:37:20 +0000 Message-Id: <20220822013720.199757-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: ye xingchen Return the value from sev_guest_activate(&activate, error) and sev_issue_cmd_external_user(f.file, id, data, error) directly instead of storing it in another redundant variable.And also change the position of handle and asid to simplify the code. Signed-off-by: ye xingchen Suggested-by: SeanChristopherson --- v1 -> v2 Suggested-by: SeanChristopherson Change the position of handle and asid. Change the explain about this patch. Dropping the comment about asid + handle. arch/x86/kvm/svm/sev.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 28064060413a..4448f2e512b9 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -276,31 +276,24 @@ static int sev_guest_init(struct kvm *kvm, struct kvm= _sev_cmd *argp) =20 static int sev_bind_asid(struct kvm *kvm, unsigned int handle, int *error) { - struct sev_data_activate activate; - int asid =3D sev_get_asid(kvm); - int ret; - - /* activate ASID on the given handle */ - activate.handle =3D handle; - activate.asid =3D asid; - ret =3D sev_guest_activate(&activate, error); + struct sev_data_activate activate =3D { + .handle =3D handle, + .asid =3D sev_get_asid(kvm), + }; =20 - return ret; + return sev_guest_activate(&activate, error); } =20 static int __sev_issue_cmd(int fd, int id, void *data, int *error) { struct fd f; - int ret; =20 f =3D fdget(fd); if (!f.file) return -EBADF; =20 - ret =3D sev_issue_cmd_external_user(f.file, id, data, error); - fdput(f); - return ret; + return sev_issue_cmd_external_user(f.file, id, data, error); } =20 static int sev_issue_cmd(struct kvm *kvm, int id, void *data, int *error) --=20 2.25.1