From nobody Wed Apr 8 12:36:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDDF0C32771 for ; Fri, 19 Aug 2022 19:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351143AbiHSTIh (ORCPT ); Fri, 19 Aug 2022 15:08:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351066AbiHSTIZ (ORCPT ); Fri, 19 Aug 2022 15:08:25 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F56C2A412 for ; Fri, 19 Aug 2022 12:08:23 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id j1so240694pjg.5 for ; Fri, 19 Aug 2022 12:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=tlVqcJR2RWJzIVx+j8QXqXkEF4w+7JdP2qYqCLd2xU4=; b=MTI4vdwl4gqRh60KksQSrtWRv3xKQhL4y0uyrbG6EjptfSnhYcS/a2IpoCAADgnsj3 /UA8bAe96gCub5qyGe1JCpglsSCvv8stYJ71yjXiPbOm1hQq8V5KlyMXspDtHeEdtetG 6C3hMAN05XCtZ7qvcPGFYqj4O39JqGpaHzHEc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=tlVqcJR2RWJzIVx+j8QXqXkEF4w+7JdP2qYqCLd2xU4=; b=NHNyQ8IrZrKxwcfP2NOSgK6pxkcR2iFj5u/9pC1em8boAcUBSnJjteQCw1NXUwpFAL 8pe9g7YSOiQ9mNKGueVRaibfP7HsJrEdpSewaJQZlbiEaGT91FcH3lc7cC5rQ9hWXVXF PzW1n9j0OXAJeqydz19zagM3ewGKsrQw+bQt9xKiIu1cj+VKwaX/1EZMrEbitZ4dq33a VJKdtwxDSfO6ObHeS9XqJbmUGHSWxev4X5lFsHaaWHQ6N0KlciWuY99DbFTSAkJWhgeS 1rYqv/pfr21x7KikUufT7B2ZtunLxQ2kQlAEALrbTFIVxLq5i02kMHxiTAU6cPrcMQmk ZTYA== X-Gm-Message-State: ACgBeo090mBrBBs9revmQK3V3iq7a4exRELkXKpU8Egm9tJsb+vVFlgX upB+Kjrb8cTLbcTsqVBFp8qBRYAJPXI3cg== X-Google-Smtp-Source: AA6agR7nsL+lGm9wkhClhGQEYjdyYIzCzzJ7BrY20bzxN4eaO+k5+HpggVpEqvpCtXksK6OiKfxxig== X-Received: by 2002:a17:902:b483:b0:170:a89f:32b3 with SMTP id y3-20020a170902b48300b00170a89f32b3mr8695426plr.149.1660936102550; Fri, 19 Aug 2022 12:08:22 -0700 (PDT) Received: from pmalani.c.googlers.com.com (137.22.168.34.bc.googleusercontent.com. [34.168.22.137]) by smtp.gmail.com with ESMTPSA id b14-20020a170903228e00b00172a567d910sm3499775plh.289.2022.08.19.12.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:08:22 -0700 (PDT) From: Prashant Malani To: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: bleung@chromium.org, Prashant Malani , Enric Balletbo i Serra , Guenter Roeck , Heikki Krogerus Subject: [PATCH 1/4] platform/chrome: cros_ec_typec: Add bit offset for DP VDO Date: Fri, 19 Aug 2022 19:08:02 +0000 Message-Id: <20220819190807.1275937-2-pmalani@chromium.org> X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog In-Reply-To: <20220819190807.1275937-1-pmalani@chromium.org> References: <20220819190807.1275937-1-pmalani@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use the right macro while constructing the DP_PORT_VDO to ensure the Pin Assignment offsets are correct. Fixes: 1ff5d97f070c ("platform/chrome: cros_ec_typec: Register port altmode= s") Signed-off-by: Prashant Malani Acked-by: Heikki Krogerus Reviewed-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chr= ome/cros_ec_typec.c index de6ee0f926a6..4d81d8d45b73 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -25,7 +25,8 @@ =20 #define DRV_NAME "cros-ec-typec" =20 -#define DP_PORT_VDO (BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D) | DP_CAP_= DFP_D) +#define DP_PORT_VDO (DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_= PIN_ASSIGN_D)) | \ + DP_CAP_DFP_D) =20 /* Supported alt modes. */ enum { --=20 2.37.1.595.g718a3a8f04-goog From nobody Wed Apr 8 12:36:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D59C32771 for ; Fri, 19 Aug 2022 19:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351159AbiHSTIu (ORCPT ); Fri, 19 Aug 2022 15:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351114AbiHSTIa (ORCPT ); Fri, 19 Aug 2022 15:08:30 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E414A48C80 for ; Fri, 19 Aug 2022 12:08:28 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id y127so2138861pfy.5 for ; Fri, 19 Aug 2022 12:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=NY3og6uVOGIRfydWAoiK8DTzipQrxXXqtzrWPkrx8rE=; b=VJQxFgKABXidqeK6PcYka/SLJnrMhsN5piLG5aBGrmKOX55QepEObQ88MWMkZXJH0H MiYLtWEBXs8MGcNVMdwZMFOJBshSIXYwtMBZzDrFt9ptpY6CdufVoVXJu16TZ0tajZkv YxXPq9YarjoNbmyvcRjmrlu7hctfeeWFP38yY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=NY3og6uVOGIRfydWAoiK8DTzipQrxXXqtzrWPkrx8rE=; b=TFkIhEj++Mhbl6cVY8o/BtpMhpwBNOedrwEyJB7LiSTlErXlLIDb8Jgm8kt0PcrBl9 iFbQoHH/h+9JlpL//X0thEwZmXdS9e9wT/Rq0lDAqynWTPzpp6H3fRpekzpvW2CQ8ZfP xnbchgMv3KOpY0IdBYL/6+wB0/t5BaLqewUNbbUZi+vMovJGNMO7VAOvYDWJZOHhKA3o dq+N/d2ogUDPrMdU453pYZuxK3dw6gD8iVnsf++8Tx44WxHBmAQ0JYDJQjM08MDGn1vx 37M76NcIg/yet2KnOGDqGowoSd5EQoDMPl4SlB5X/6NMXQvpeeyjw5/q9iRGKX/g+dcX HTrQ== X-Gm-Message-State: ACgBeo38yPdLTX+h94qBZPLT+17L0edSvib3MxacoD6qsN/9QJeDNvNU M/ySamLtauYlHh89E8HkGXg+oThUMp4Xew== X-Google-Smtp-Source: AA6agR4hHW67M1U75F44AWEu1mn0JI3XHNB4+7SKR0ssNvQHD9p15ZaaWOD10jBLMG5e8LtgM67xsg== X-Received: by 2002:a63:6b02:0:b0:422:7cf8:4bf with SMTP id g2-20020a636b02000000b004227cf804bfmr7501437pgc.92.1660936108315; Fri, 19 Aug 2022 12:08:28 -0700 (PDT) Received: from pmalani.c.googlers.com.com (137.22.168.34.bc.googleusercontent.com. [34.168.22.137]) by smtp.gmail.com with ESMTPSA id b14-20020a170903228e00b00172a567d910sm3499775plh.289.2022.08.19.12.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:08:28 -0700 (PDT) From: Prashant Malani To: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: bleung@chromium.org, Prashant Malani , Enric Balletbo i Serra , Guenter Roeck , Heikki Krogerus Subject: [PATCH 2/4] platform/chrome: cros_ec_typec: Correct alt mode index Date: Fri, 19 Aug 2022 19:08:03 +0000 Message-Id: <20220819190807.1275937-3-pmalani@chromium.org> X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog In-Reply-To: <20220819190807.1275937-1-pmalani@chromium.org> References: <20220819190807.1275937-1-pmalani@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Alt mode indices used by USB PD (Power Delivery) start with 1, not 0. Update the alt mdoe registration code to factor this in to the alt mode descriptor. Fixes: de0f49487db3 ("platform/chrome: cros_ec_typec: Register partner altm= odes") Signed-off-by: Prashant Malani Acked-by: Heikki Krogerus Reviewed-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_ec_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chr= ome/cros_ec_typec.c index 4d81d8d45b73..dc5722db2066 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -698,7 +698,7 @@ static int cros_typec_register_altmodes(struct cros_typ= ec_data *typec, int port_ for (j =3D 0; j < sop_disc->svids[i].mode_count; j++) { memset(&desc, 0, sizeof(desc)); desc.svid =3D sop_disc->svids[i].svid; - desc.mode =3D j; + desc.mode =3D j + 1; desc.vdo =3D sop_disc->svids[i].mode_vdo[j]; =20 if (is_partner) --=20 2.37.1.595.g718a3a8f04-goog From nobody Wed Apr 8 12:36:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE293C32771 for ; Fri, 19 Aug 2022 19:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351220AbiHSTI4 (ORCPT ); Fri, 19 Aug 2022 15:08:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351140AbiHSTIg (ORCPT ); Fri, 19 Aug 2022 15:08:36 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3FC2520AD for ; Fri, 19 Aug 2022 12:08:32 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id c2so4902368plo.3 for ; Fri, 19 Aug 2022 12:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=LRNQZAQfuVWPtn0ySqLWsoQsRuvJYWivZoqggybL5d4=; b=OJYjgn5Ecua8yljlsSDpa51lK5T4ff4foNJdIiSLf5dNe6a6frhKr7dxS9Bbj8nSoo HnirEUD7kvbmjSOXMm+vZvJWj9rRAvvR6hfXpQowjzOFLjXwmEz0eKisYWgGc6noO/v0 yHP6AClXhnWajIVHARTyTmYCabfyodtv1lpm0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=LRNQZAQfuVWPtn0ySqLWsoQsRuvJYWivZoqggybL5d4=; b=J/lPMQ1XOjLM4emE8ROyfGch/2m6tYUbjaQ0SD37kpl5G/OHjn0kOjz/fYPxpZNg/V +s21D58bLkbgz1wlony2BdRoG8WmvwO9QsrofIQlsSoMjkE9OrxdHQqQfEDY/YjbIJv7 C5bmjHDcCeEkegpXZDgs2nwTWuxyDJdu7f4XJ8P5FUI98RR6c/7rScG6OYBuIyIjRzM/ x8mXbqEwaKkOoMOjhII/pnctDZW8NLy3tJsmncjIy+Gl7BCC/KS1vxLMDEZAMsm68PlX j3a6+EDOHep10u4UafanpN6QwiCaRCUfvP1L8Uw0cW/75MNlPXVgAH+m7w1lvivEhHCT EKTg== X-Gm-Message-State: ACgBeo2J/iVKHvU55Aq1BHfRh8M/h0a1bRjxYEd9ou3496Mhj+QIJmk+ unGlPL6Bw+0y/8nVBxFC/8u4qb6XWIhz9g== X-Google-Smtp-Source: AA6agR5y8NDxG372IwiHy3L/WeoVZMiJNDnSzObCzFMnj9kywQ5kojSHeAn2uZkfOggsjIO+U3I8Zw== X-Received: by 2002:a17:903:494:b0:172:9823:e355 with SMTP id jj20-20020a170903049400b001729823e355mr8608235plb.75.1660936112240; Fri, 19 Aug 2022 12:08:32 -0700 (PDT) Received: from pmalani.c.googlers.com.com (137.22.168.34.bc.googleusercontent.com. [34.168.22.137]) by smtp.gmail.com with ESMTPSA id b14-20020a170903228e00b00172a567d910sm3499775plh.289.2022.08.19.12.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:08:32 -0700 (PDT) From: Prashant Malani To: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: bleung@chromium.org, Prashant Malani , Enric Balletbo i Serra , Guenter Roeck , Heikki Krogerus Subject: [PATCH 3/4] platform/chrome: cros_ec_typec: Stash port driver info Date: Fri, 19 Aug 2022 19:08:04 +0000 Message-Id: <20220819190807.1275937-4-pmalani@chromium.org> X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog In-Reply-To: <20220819190807.1275937-1-pmalani@chromium.org> References: <20220819190807.1275937-1-pmalani@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Stash port number and a pointer to the driver-specific struct in the local Type-C port struct. These can be useful to the port driver to figure out how to communicate with the ChromeOS EC when an altmode driver related callback is invoked from the Type-C class code. Signed-off-by: Prashant Malani --- drivers/platform/chrome/cros_ec_typec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chr= ome/cros_ec_typec.c index dc5722db2066..7daf4207c11e 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -44,6 +44,7 @@ struct cros_typec_altmode_node { /* Per port data. */ struct cros_typec_port { struct typec_port *port; + int port_num; /* Initial capabilities for the port. */ struct typec_capability caps; struct typec_partner *partner; @@ -71,6 +72,8 @@ struct cros_typec_port { struct ec_response_typec_discovery *disc_data; struct list_head partner_mode_list; struct list_head plug_mode_list; + + struct cros_typec_data *typec_data; }; =20 /* Platform-specific data for the Chrome OS EC Type C controller. */ @@ -368,6 +371,8 @@ static int cros_typec_init_ports(struct cros_typec_data= *typec) goto unregister_ports; } =20 + cros_port->port_num =3D port_num; + cros_port->typec_data =3D typec; typec->ports[port_num] =3D cros_port; cap =3D &cros_port->caps; =20 --=20 2.37.1.595.g718a3a8f04-goog From nobody Wed Apr 8 12:36:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C1AC32771 for ; Fri, 19 Aug 2022 19:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351238AbiHSTJA (ORCPT ); Fri, 19 Aug 2022 15:09:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351147AbiHSTIi (ORCPT ); Fri, 19 Aug 2022 15:08:38 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF3E20F7C for ; Fri, 19 Aug 2022 12:08:36 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id 20so4879160plo.10 for ; Fri, 19 Aug 2022 12:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DqrEek4KEewVAx/BWFwpw/lOY/BhLwmErxM0R0EWxLo=; b=MwFNBQo0TZ6ZipDVfvyCnneHe7+leBOXAzZu5KqzchrPPb9Yjc/vvEEVuvx+qV39vO V5YCldxxCyOYEdgy093cDUANWG7mMGS+mR3UEfYCTayQ2a4lv/xVijHlz9ZSl8fLus7o 3YcHWTykQ89fdE+pG+jslDjXurkjxMpD/BRHU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DqrEek4KEewVAx/BWFwpw/lOY/BhLwmErxM0R0EWxLo=; b=c27RviL+l3J/AhnA6MMW3KNSvcXSkkc1ikFsDHibduU3ds3Yvplc09RUKTKoU+mh0q ryGVXykiViOFESMWuaEehonCWKagWp08HnkJH1Xs0vYkWRc3GpjywSQmxw+bemgRVGiT SSro/Q8G0zl+oaOQZ54iG8aiNPlz0ph5QzTFS6hHcvnodzaKTInBp2/sTErLuOOCidZG yCHwSuucPkjQ3BlAFIpl+Dk2VHpiV1of+TRDTNQP1bHlFwIvw4dz/svWi/wJuDuyibTJ DrL80KaXlsZ3re9izlexuPF4s6g1MVnfCTNuir0dbHmvQ+lrT5W/V7/rtab9aTQb+sBc b7BA== X-Gm-Message-State: ACgBeo0s0kmvFngwJalXMuvIZRiPPNOuWd6TDnVzpxzMR0wGi3B+qrEo ZGyi1EKHTfW4H4iBv3+rOA2czgRXcN73EA== X-Google-Smtp-Source: AA6agR4T/qUdLe4Pb2e1At9eR7z2ZJw11QKB/5L2FNFC3ZuaAZNkzzsZtZz5GcksgRnluCf8GT0Tyw== X-Received: by 2002:a17:90b:4b89:b0:1f5:68b:b14e with SMTP id lr9-20020a17090b4b8900b001f5068bb14emr16054333pjb.30.1660936115902; Fri, 19 Aug 2022 12:08:35 -0700 (PDT) Received: from pmalani.c.googlers.com.com (137.22.168.34.bc.googleusercontent.com. [34.168.22.137]) by smtp.gmail.com with ESMTPSA id b14-20020a170903228e00b00172a567d910sm3499775plh.289.2022.08.19.12.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:08:35 -0700 (PDT) From: Prashant Malani To: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: bleung@chromium.org, Prashant Malani , Enric Balletbo i Serra , Guenter Roeck , Heikki Krogerus Subject: [PATCH 4/4] platform/chrome: cros_ec_typec: Use Type-C driver data Date: Fri, 19 Aug 2022 19:08:05 +0000 Message-Id: <20220819190807.1275937-5-pmalani@chromium.org> X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog In-Reply-To: <20220819190807.1275937-1-pmalani@chromium.org> References: <20220819190807.1275937-1-pmalani@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Altmode driver callbacks need EC-specific port information to communicate with the ChromeOS EC. To accomplish this, save a pointer to the driver-specific port struct in the Type-C port's driver data field. Signed-off-by: Prashant Malani --- drivers/platform/chrome/cros_ec_typec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chr= ome/cros_ec_typec.c index 7daf4207c11e..e3f75440030d 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -379,6 +379,7 @@ static int cros_typec_init_ports(struct cros_typec_data= *typec) ret =3D cros_typec_parse_port_props(cap, fwnode, dev); if (ret < 0) goto unregister_ports; + cap->driver_data =3D cros_port; =20 cros_port->port =3D typec_register_port(dev, cap); if (IS_ERR(cros_port->port)) { --=20 2.37.1.595.g718a3a8f04-goog