From nobody Tue Dec 16 16:37:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 376F4C28B2B for ; Fri, 19 Aug 2022 16:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353283AbiHSQhB (ORCPT ); Fri, 19 Aug 2022 12:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353692AbiHSQcY (ORCPT ); Fri, 19 Aug 2022 12:32:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 610BF65676; Fri, 19 Aug 2022 09:06:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4DC08B82813; Fri, 19 Aug 2022 16:06:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B081C433C1; Fri, 19 Aug 2022 16:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660925181; bh=xf9Y3gmJByI0qAsBgLCdnLTBO1pzDeKO1fEdRz4ygII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CrZ+TsMyZQR4dOZyoO7UtA/5bsvAl6xa7fEHsOW4bu8uFELScrKL8OlvMgdX4rNV0 Zw7faTGw+s3O8jgYLauxZKC851Tyxaa0pZ7uIL1ll3BZBiVMRklqkA7aDwPYqJiI7p Weng2NjIpcVeslIwoTT5Xj3roF++h3xkSvN1vEp0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Krzysztof Kozlowski , Mark Brown , Sasha Levin Subject: [PATCH 5.10 380/545] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables Date: Fri, 19 Aug 2022 17:42:30 +0200 Message-Id: <20220819153846.419427223@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220819153829.135562864@linuxfoundation.org> References: <20220819153829.135562864@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tom Rix [ Upstream commit d2294461b90e0c5b3bbfaaf2c8baff4fd3e2bb13 ] sparse reports sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_p= ower' was not declared. Should it be static? sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' w= as not declared. Should it be static? Both gpiod_speaker_power and rx1950_audio are only used in rx1950_uda1380.c, so their storage class specifiers should be static. Fixes: 83d74e354200 ("ASoC: samsung: rx1950: turn into platform driver") Signed-off-by: Tom Rix Reviewed-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220629185345.910406-1-trix@redhat.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/samsung/rx1950_uda1380.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/samsung/rx1950_uda1380.c b/sound/soc/samsung/rx1950_= uda1380.c index 400a7f77c711..354f379268d9 100644 --- a/sound/soc/samsung/rx1950_uda1380.c +++ b/sound/soc/samsung/rx1950_uda1380.c @@ -128,7 +128,7 @@ static int rx1950_startup(struct snd_pcm_substream *sub= stream) &hw_rates); } =20 -struct gpio_desc *gpiod_speaker_power; +static struct gpio_desc *gpiod_speaker_power; =20 static int rx1950_spk_power(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, int event) @@ -227,7 +227,7 @@ static int rx1950_probe(struct platform_device *pdev) return devm_snd_soc_register_card(dev, &rx1950_asoc); } =20 -struct platform_driver rx1950_audio =3D { +static struct platform_driver rx1950_audio =3D { .driver =3D { .name =3D "rx1950-audio", .pm =3D &snd_soc_pm_ops, --=20 2.35.1