From nobody Tue Dec 16 16:20:49 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774DDC28B2B for ; Fri, 19 Aug 2022 16:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351641AbiHSQJF (ORCPT ); Fri, 19 Aug 2022 12:09:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351679AbiHSQGU (ORCPT ); Fri, 19 Aug 2022 12:06:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777021EC5C; Fri, 19 Aug 2022 08:55:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E99D36174E; Fri, 19 Aug 2022 15:55:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7965C433C1; Fri, 19 Aug 2022 15:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660924515; bh=tMmXL/qGN8JSHOlxpl85Dsz797mO7n/oV3gAG5EougU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eIqW+cPdwa2ia9pyn/ILp4Hv96ndisLUucM/amxtnCLjtQhukX914CpoAOnQNc7N3 Bl4efvqQg7QFVyLezfQTmS41qz1wNpm0QgTF9urW1TZKzDImmzsGfvWTQcmVNVRQ2y fe0NSmJTYdlGNvBgJTHLvSTY3/ti43mtYEJlKyWc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Stevenson , Maxime Ripard , Sasha Levin Subject: [PATCH 5.10 196/545] drm/vc4: dsi: Register dsi0 as the correct vc4 encoder type Date: Fri, 19 Aug 2022 17:39:26 +0200 Message-Id: <20220819153838.136072639@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220819153829.135562864@linuxfoundation.org> References: <20220819153829.135562864@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Dave Stevenson [ Upstream commit 4d9273c978d4c1af15d7874c10c732ec83d444d0 ] vc4_dsi was registering both dsi0 and dsi1 as VC4_ENCODER_TYPE_DSI1 which seemed to work OK for a single DSI display, but fails if there are two DSI displays connected. Update to register the correct type. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Dave Stevenson Link: https://lore.kernel.org/r/20220613144800.326124-15-maxime@cerno.tech Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 2cedf1cf6758..8e2d5c4237ae 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -1488,7 +1488,8 @@ static int vc4_dsi_bind(struct device *dev, struct de= vice *master, void *data) return -ENOMEM; =20 INIT_LIST_HEAD(&dsi->bridge_chain); - vc4_dsi_encoder->base.type =3D VC4_ENCODER_TYPE_DSI1; + vc4_dsi_encoder->base.type =3D dsi->variant->port ? + VC4_ENCODER_TYPE_DSI1 : VC4_ENCODER_TYPE_DSI0; vc4_dsi_encoder->dsi =3D dsi; dsi->encoder =3D &vc4_dsi_encoder->base.base; =20 --=20 2.35.1