From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D499C25B0E for ; Fri, 19 Aug 2022 08:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237247AbiHSIcY (ORCPT ); Fri, 19 Aug 2022 04:32:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347158AbiHSIcS (ORCPT ); Fri, 19 Aug 2022 04:32:18 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 361C2E9905 for ; Fri, 19 Aug 2022 01:32:17 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id o2so5248338lfb.1 for ; Fri, 19 Aug 2022 01:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=N4cVOvKLw+JRrcyC9iyaAUwD4TmpSDd50ehLIjD+FJ8=; b=LTrLSr8d2izE40ursGNIZ1/Uum5CUAczfSeWIwEnU1CtE8uxPAk8+eaNoBuGKnsy1V kYQLR4EIDZcZPOrmJuzbkBJAJAt2Be7bAsdjxQYUDhhcPfy/vQb2JLuFpk99eienrX4u y06p2PKRXwW72F200b+X0HIavY9rJqtnBxp7otNY5F346lISBkQTjBQKHzBpvn/DDttX 6uxN9VJpklj/YWZW2ZdwWTrKzxyepXk0Rf/tGJALluMRyd4TiiaaXqZbv2mtDlanPnOO 1VQRJOFGqaUB99NV2OuZyyzYuOwFZ0rzAF7lYclTtYQah/0FxHurMtrRSxiAc25OyAPr n4aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=N4cVOvKLw+JRrcyC9iyaAUwD4TmpSDd50ehLIjD+FJ8=; b=PDh3zYHnIYRlN/Qp/DJpyZ79EZ3tfzFO8A7+Pax1ekPF0qCAhseWvXsBUjuIutgcNv m+8Y4UVenbJkllAKI0wgoptKz+sLDWPGU6kCucXR56/GsvP6wfJs1GV3xvxt+/6oSfas mjMTcTgtMHfI04WXMsvu51m0T1RqCx34nlztIusQ7I8/azFZifjj12cTNkblgUSGuJiV snE4u4l7V2C1/E2bTGvzif3lgy3TBGGbo/wvM4/JYT8EBs9TxgDDACGShxFz3jGtwF1P Bn+xczdt7ts9wUB3u06WVjr2srcatpXCVfQtTz2uo5ClMDqs6oofJetMYOp5cwU77Mlx yXUw== X-Gm-Message-State: ACgBeo3KSNbYRPKx3e3/ailtskUc/UUiAW5qAKuH0E+sdyTTB5SP5OYX iQeJxr31dUMXjuqVvudgd/pu7g== X-Google-Smtp-Source: AA6agR5THR1kx33I9E3d3N3nFfvgn8gtcpulk86lo1PcTv3kHAzcJwC2u917khiPO4EROMZsomS9Ag== X-Received: by 2002:a05:6512:3c9b:b0:48b:40ea:c9f2 with SMTP id h27-20020a0565123c9b00b0048b40eac9f2mr2036846lfv.170.1660897935494; Fri, 19 Aug 2022 01:32:15 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:15 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 01/16] dt-bindings: mfd: qcom,tcsr: add several devices Date: Fri, 19 Aug 2022 11:31:54 +0300 Message-Id: <20220819083209.50844-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon registers (QCS404, SC7180, SDM630, SDM845, SM8150, MSM8998). Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Changes since v2: 1. Add more compatibles. Changes since v1: 1. Correct order of compatibles. --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documen= tation/devicetree/bindings/mfd/qcom,tcsr.yaml index 2f816fd0c9ec..d3c25daa995e 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,13 @@ properties: oneOf: - items: - enum: + - qcom,msm8998-tcsr + - qcom,qcs404-tcsr + - qcom,sc7180-tcsr + - qcom,sc7280-tcsr + - qcom,sdm630-tcsr + - qcom,sdm845-tcsr + - qcom,sm8150-tcsr - qcom,tcsr-apq8064 - qcom,tcsr-apq8084 - qcom,tcsr-ipq8064 @@ -27,6 +34,7 @@ properties: - qcom,tcsr-msm8953 - qcom,tcsr-msm8960 - qcom,tcsr-msm8974 + - qcom,tcsr-msm8996 - const: syscon - items: - const: qcom,tcsr-ipq6018 --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FA4C25B0E for ; Fri, 19 Aug 2022 08:32:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347343AbiHSIc1 (ORCPT ); Fri, 19 Aug 2022 04:32:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347276AbiHSIcU (ORCPT ); Fri, 19 Aug 2022 04:32:20 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AFE0E97F8 for ; Fri, 19 Aug 2022 01:32:18 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id x10so3889864ljq.4 for ; Fri, 19 Aug 2022 01:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=bSmakT1vdCHgEKF8qCqyNm6SNZVWPZI3wfwFHGWqtB4=; b=CCvUcvjt98Fr4igCTaHPTFj+RnhBjAOxYI3X2/G0dWEV3CrvNwsGLwhQFia3yLImcY j59ivJ/dZQOyZXNT5py+SKq9+sh6n78YoRpKHkVcNzLZ+DYqcwbR2sh8VYrDLemXXJu4 NXLdNdr3BA/VkK34JUz4FcAShKHcOxMCBSlVC8tXnCKCxma4hNajIWyBgaGtfk7uhZz7 GFt1KezmcF7rd+ygh/9iq/vqdFEsRS30vaZ1Qb82wevhasB85ZXudr3TaFW9qZUXNNNw sNR4v4hw6+X2oTkGLGkNZfgcKjrs+A113WpERHpU1MnrVDo3+1BR4fFVw9CwpWQQUFcR m9Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=bSmakT1vdCHgEKF8qCqyNm6SNZVWPZI3wfwFHGWqtB4=; b=QreDmJ/TN7eChVMVWlZdtxH/T0hsH+01CxaxU9bMrVsnAdaaSj3pSmVgmd5KQIlfom YIm+FgmIr84gP81O6UEBXi90W7CxcSfWuSSzR3oD8UXx0eVyPK2q5P+xADJ5Jv6ExdRR 528s5AYdsT/ZxN4v3lLrM8PTYjk2sFlqxJ7ZwDfzxE2Jd5C3w8r+31aUzVsIDG8Lvhd2 Xb0iOQdO11FzNu0+7sPWoMsHHrnOKpuuA235KzMSxZnSxRx8uJqm8dcHYrBzk/mzvdvx /R9NwtomDhworgMRBoSYaPYHStJ9J8vLdKZi7/8gOVnelCFeoj+2sNftI+z+92QLF7Oc /Obg== X-Gm-Message-State: ACgBeo3avhHJpug3sVlvNEGz05nE5qkMvRV3DPnNZtEfXImYSoNDbCv/ upDhSJi+4QZg873NTG/ulCeKpw== X-Google-Smtp-Source: AA6agR79bH3x4HCzZtPJLf+xIcNftzO6hiXEXp2Wgv+HLmznRikp9QsLsVuu6Qe8yQ9KCHYZEaVt7g== X-Received: by 2002:a2e:be06:0:b0:261:be8b:64f3 with SMTP id z6-20020a2ebe06000000b00261be8b64f3mr460430ljq.193.1660897936812; Fri, 19 Aug 2022 01:32:16 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 02/16] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Date: Fri, 19 Aug 2022 11:31:55 +0300 Message-Id: <20220819083209.50844-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex (in one address block called TCSR_MUTEX), so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qc= om/msm8996.dtsi index 742eac4ce9b3..3411ced96db6 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -359,7 +359,7 @@ opp-2150400000 { firmware { scm { compatible =3D "qcom,scm-msm8996", "qcom,scm"; - qcom,dload-mode =3D <&tcsr 0x13000>; + qcom,dload-mode =3D <&tcsr_2 0x13000>; }; }; =20 @@ -840,10 +840,15 @@ pnoc: interconnect@5c0000 { =20 tcsr_mutex_regs: syscon@740000 { compatible =3D "syscon"; - reg =3D <0x00740000 0x40000>; + reg =3D <0x00740000 0x20000>; }; =20 - tcsr: syscon@7a0000 { + tcsr_1: sycon@760000 { + compatible =3D "qcom,tcsr-msm8996", "syscon"; + reg =3D <0x00760000 0x20000>; + }; + + tcsr_2: syscon@7a0000 { compatible =3D "qcom,tcsr-msm8996", "syscon"; reg =3D <0x007a0000 0x18000>; }; @@ -2413,7 +2418,7 @@ mss_pil: remoteproc@2080000 { qcom,smem-states =3D <&mpss_smp2p_out 0>; qcom,smem-state-names =3D "stop"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_1 0x3000 0x5000 0x4000>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228E5C25B0E for ; Fri, 19 Aug 2022 08:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347226AbiHSIca (ORCPT ); Fri, 19 Aug 2022 04:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347316AbiHSIcV (ORCPT ); Fri, 19 Aug 2022 04:32:21 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD605E97FE for ; Fri, 19 Aug 2022 01:32:19 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id z20so3892096ljq.3 for ; Fri, 19 Aug 2022 01:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=qy9TWkJXZUtfWQLTmK1W0ItQxoNRQincIzjRzs6MIKA=; b=vX0/jTHc82btt23YwOjDhmsjce0tdypxUEa1vZJFlByPF5N1iXDKckLBAd9/M5pEMn vJbHO3sJ+QhTWfxUDzNolo5PYfdSOU24IM1mVye0e5WQ8UZIUAfXiRXS8Sl747hsCdra iuBehp2aY1PJxnbuYx2RFGg+InVWBU9fkvoyDGjafwLPm7dsnqxuA+pBuuPAlW95O8vX IKdnBeHmTBg07dfQoePP6SzcJbBADk20PhAj9qrGMAojPFb9jCyfiwK1tu7wKE38RrPu I7f6FE443sXjCk9ryTVd0kbMP6fBx4QzVh9Uth1N99tze+StexA3aTi0+KWgJCpx2Xl/ dsTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=qy9TWkJXZUtfWQLTmK1W0ItQxoNRQincIzjRzs6MIKA=; b=ulvrU0gJyhww7xaZ12EgpccX654/tJwREAL2kQ/Umn+8rrsHKxH4ZP2ChF5MG1HMJ6 GBTIOzOx/4YGPU0wOgoSCGRCJHTe5r2ctUm9ttVnAQXf256A0XUwJzmqH9NMcNI0iJRE gW2VxRLHoQvT3Y6yn2JVBSzUi73S1AhYIPvAjyTl6JAv3jhVF2HG/Sev1auohjvFqF2e 2QTy2GEz0xFn5UZ3Az2YeR45Q/xp9qU7kzsPdMQhyzr4kmBEBIu6YFcbN8IG9aJFceZK FD//SBhOyIdY00JMgXONnHxRedVcgYH+nROiDx6QeEbURLWcjL7THCfsPV76Cs7pXc2h GaQA== X-Gm-Message-State: ACgBeo0Em2aXWeUuS+lgooDlURzmg2r5ZaAKBseonvAtTXid31246gF9 fqf7XDAE6NxMaF10pDI1euvq4Q== X-Google-Smtp-Source: AA6agR5BgMAA8ole7CO+TTXK5IFql3pEQSDpaD4Q/U9GU4pEqaF2Xhd+deXfcE9Fd3tOJvGVx+8cDQ== X-Received: by 2002:a2e:9b47:0:b0:25e:6dac:8c8c with SMTP id o7-20020a2e9b47000000b0025e6dac8c8cmr1915596ljj.113.1660897938075; Fri, 19 Aug 2022 01:32:18 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:17 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 03/16] arm64: dts: qcom: msm8996: switch TCSR mutex to MMIO Date: Fri, 19 Aug 2022 11:31:56 +0300 Message-Id: <20220819083209.50844-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'reg' is a required property qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'syscon' does not match any of t= he regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qc= om/msm8996.dtsi index 3411ced96db6..166374566a49 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -363,12 +363,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - memory@80000000 { device_type =3D "memory"; /* We expect the bootloader to fill in the reg */ @@ -838,9 +832,10 @@ pnoc: interconnect@5c0000 { <&rpmcc RPM_SMD_PCNOC_A_CLK>; }; =20 - tcsr_mutex_regs: syscon@740000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@740000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x00740000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_1: sycon@760000 { --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D40C32771 for ; Fri, 19 Aug 2022 08:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346806AbiHSIcc (ORCPT ); Fri, 19 Aug 2022 04:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347354AbiHSIcW (ORCPT ); Fri, 19 Aug 2022 04:32:22 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1136AE97F8 for ; Fri, 19 Aug 2022 01:32:21 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id l19so728949ljg.8 for ; Fri, 19 Aug 2022 01:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=5WfuABgGkL9AfK5HJrbpixzed3bcUcc9/3Q45QgNRXA=; b=Ak1QpTr/VKgCehxKnxF4AVejAldH2KkNQfQzNsGLMm2tObgmonqMF/UtYy12/dJ3gw dSYoWGDuofnANi9zuQLbbvCM5dFGmcZjf4QrC8Ct2PznxP9Yep4fnItYam4hEW6Zhg9K JoMGzVyhay/L+ctJetYYSOtMfvlTD1wXZQpk+ab8aaB8i4KO6ANrz/PE0Y+rHqqUaFhF guBFgKEfPxAKoMjH9MtM5U3nCFKdLghP3/70KnBcb7APTv3xoEqPnaGIqHVxRWAYLNLB E+9o0q6jFukdpzahrP0bAZZSQfxAUqtTzhbJVbaN2rYkyxChXkaJ7O2pwvCiYbis2GBO VKpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=5WfuABgGkL9AfK5HJrbpixzed3bcUcc9/3Q45QgNRXA=; b=XhUxrT1U4+ldZNplxIxagDzKmZswniBkNHVMZCHWaHZWm70zH4YdRPOU2DcTlgagY/ bsCYPTXLFk9ZjzE5/3tsRCGSsSZnZUrM+9FAsth3+m9+rxECjgXcALZrc6vk63HeX0xd JjilwzPRWrR5texUiI1MldzELbayrksqCWfv/a5ZEtoAy3Da4azTaePgsy3ZSGB/DoYH kL+K0cKF9ldcoO+a9khQpaKCwOM8WdvwTc6wj20maYLI6eucit0siian81YAluriEZh1 XYcklGk8GSERXdwxDjzSJFGsVwyMrjx/2kCGi6SaSzcpfgsLSAXoMFZXlHe0xLnj1j/I GIUw== X-Gm-Message-State: ACgBeo2/QDiyPKtGY/Rf47fbSZY9XYjEukHp3U5wMW3sx1i0OUpZpiuX GToTjip3Tswi2defWyE17U0q6A== X-Google-Smtp-Source: AA6agR7Ph2MRxoCWXinqtcheu7CvhmScE8OpNiYuTQCdKm1lTOpi/K7x8dS/H00qwV7GYWbPqcn1dA== X-Received: by 2002:a2e:b8d5:0:b0:25f:e94d:10a2 with SMTP id s21-20020a2eb8d5000000b0025fe94d10a2mr1993685ljp.274.1660897939400; Fri, 19 Aug 2022 01:32:19 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:19 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 04/16] arm64: dts: qcom: msm8998: split TCSR halt regs out of mutex Date: Fri, 19 Aug 2022 11:31:57 +0300 Message-Id: <20220819083209.50844-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex (in one address block called TCSR_MUTEX), so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qc= om/msm8998.dtsi index 02d21bff2198..f0806ed103f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1049,7 +1049,12 @@ ufsphy_lanes: phy@1da7400 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0x01f40000 0x40000>; + reg =3D <0x01f40000 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,msm8998-tcsr", "syscon"; + reg =3D <0x01f60000 0x20000>; }; =20 tlmm: pinctrl@3400000 { @@ -1340,7 +1345,7 @@ remoteproc_mss: remoteproc@4080000 { resets =3D <&gcc GCC_MSS_RESTART>; reset-names =3D "mss_restart"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; =20 power-domains =3D <&rpmpd MSM8998_VDDCX>, <&rpmpd MSM8998_VDDMX>; --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E211C3F6B0 for ; Fri, 19 Aug 2022 08:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347293AbiHSIcq (ORCPT ); Fri, 19 Aug 2022 04:32:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347472AbiHSIcZ (ORCPT ); Fri, 19 Aug 2022 04:32:25 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7319E990D for ; Fri, 19 Aug 2022 01:32:22 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id h5so4954880lfk.3 for ; Fri, 19 Aug 2022 01:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=eD+vvaVGBlUcCXOKP3ANbRbef4Wta7oOIdhhSq0Fgqw=; b=w7xq+DeKlMgrmICZ39PCb/6Q8yvh730lY6ThiE6Ll7EFTlbvqgps24gBpg1JjHBKaZ eWyxoYwBe2niTLmtulRMg7V1e8JrCWBA+KR5a8L97cLSGVFYYZqAI+5hGuGbcHgfID0m Y/9nXpVJaE567RihAUPGmgxsYcQOcUdqytIafR1FpXS2b4GXYPznb5xc/zhmjnUew5es MPtD6R6dWK1VwWoKWJoq1EnJHEvdoeip6tNada3AWbAUXQL2MVKCoVDt5/viyOiMYaNV E4PCAVT7cOpwfK8eal5W6TrnTfhK1NW7Yxi2z4GatkXaqDmIex1iI3uqJ0kyLCRFjdtv 2vSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=eD+vvaVGBlUcCXOKP3ANbRbef4Wta7oOIdhhSq0Fgqw=; b=y75FuLMFwrHYcqxfvri0mW2mzvEIF+PVKHfjlN/N64eIXe5h7Ev/FVrbsvfqWioOuV nPGa4ONY5hKDE/6Xxr+nODW1RwZr6qJjAy9y2XNS6CvgekrjLoOkfuqkKSlPDTuAAbro tChoXiECpR6WSA7FAiDd4AXaRCcEXuFxby3Nsnq2fFwTwQIzumf+yN/TVV+E8vstCZ4n nLPsoa9FrxCUxWzy/zMdteIYIBli9+uiqT55t9hNxMCe/IX3BT0ZI/a2+Jv9SlK9qtwq 7a+7Xmglu6bVlk92w1oagkGy6p/JkPXJsSyyS9hT7t7LmB2PkNaPMGyS0ntoewJVYSpa Inrg== X-Gm-Message-State: ACgBeo3th8IKaf+5wBz8u9mAMk4R2u8yydlxA6RTHzJrgyw8muxbi7G+ BsgpDTIy83+tXRqKClmAT9mvxF7PSXwHfzHp X-Google-Smtp-Source: AA6agR4AdJbHeukS6kjEOmGNyNW4p1APIhICE/o1N4MSxFkbRJiScDApC1w50+Jh+Im7FEGG7tSNdg== X-Received: by 2002:ac2:482d:0:b0:48b:2373:9980 with SMTP id 13-20020ac2482d000000b0048b23739980mr2042813lft.97.1660897940996; Fri, 19 Aug 2022 01:32:20 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:20 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 05/16] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO Date: Fri, 19 Aug 2022 11:31:58 +0300 Message-Id: <20220819083209.50844-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'reg' is a required property qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'syscon' does not match any= of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qc= om/msm8998.dtsi index f0806ed103f1..22b2da74d105 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -308,12 +308,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - psci { compatible =3D "arm,psci-1.0"; method =3D "smc"; @@ -1047,9 +1041,10 @@ ufsphy_lanes: phy@1da7400 { }; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x01f40000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7586C25B0E for ; Fri, 19 Aug 2022 08:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347415AbiHSIcu (ORCPT ); Fri, 19 Aug 2022 04:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347572AbiHSIc0 (ORCPT ); Fri, 19 Aug 2022 04:32:26 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9037E97E7 for ; Fri, 19 Aug 2022 01:32:23 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id a7so181639ljr.1 for ; Fri, 19 Aug 2022 01:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Wsi3drafxqLS5hS9Kxb/pKatr5Z8SKnnBwYatfij3pE=; b=bCx2wf7Gj13i2aYFNWF1S2YJa3874Em7xBh3dz+DlznXqkiHAbqCp7Lmvx05DjVx49 8MokVyRwI6Hu4E0Lu8oRWqg39+m/+i1cxYR3KFSIgRI6wzlcxL3L7ZWOfiJJHptW86bq E3qU/3lqoeyvWooRjBl5bnSjrxyBt04/9POIs+Ey7XJiprekCNEU8VggbykzRC4gjrvt B4RdsniibMPgWMkIoBhoyI60N1bG4NanhOdSr8UB+M/XI2vDHp+q4Ro7ogu+RsqG3ARn /bV1tUzvmFEd13YWxNtiZJmHjkTjyLfCKTd75MWCKqd76PFUaWiDnEC7MzIV3WaUVZCt 3Gmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Wsi3drafxqLS5hS9Kxb/pKatr5Z8SKnnBwYatfij3pE=; b=Sct3DXFUKsa82SDOnOwZ+BHof6Gv/ZPfT2dfx4CchpYgjaTw/Eiwwpdmxdh9pZctzP G3yIroQkg9KET7DQ3wfQykzuBSZSKkx8QnbPOwQlosmjZ6Rs50qyYcsxAXDeZKYaF3WP kAh+YefgQjWOZkKLMj/pTntgG+KB12ZjJ63vHB9u8UHtwPJjHkLmrYt5XoJvjQyBrQz/ yJ6sZqXDSePuS3xYSIS55vv3hPvLALhphvDs5AGRAA/i0gM+gBGmfsNLZ4AtrFrc0n3z 9iq0W58XPtaYJLqymlyzYImdaV+l0Ek3Xfu2rhGosA2dctOu/ieJny3yDNxjkQXcH21Y YCgQ== X-Gm-Message-State: ACgBeo3M/fQoSUE99jJjp1SOEzxP88kXg1Z/1OyqeXrWK79QmQT3/EZ7 hNQ8kwh9d6P04i/z5ftSr0T9sg== X-Google-Smtp-Source: AA6agR6A2YcKoHFlzcNoal/jwdNC0x/6ogLThhKLnILp0GCISzgz8kd/p0I0Hfb65XJ4cujOuJ2oGA== X-Received: by 2002:a05:651c:23a6:b0:25e:63bf:c46f with SMTP id bk38-20020a05651c23a600b0025e63bfc46fmr1901220ljb.76.1660897942256; Fri, 19 Aug 2022 01:32:22 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:21 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 06/16] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible Date: Fri, 19 Aug 2022 11:31:59 +0300 Message-Id: <20220819083209.50844-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index b82c335c25af..49f28cb531f6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1468,7 +1468,7 @@ tcsr_mutex_regs: syscon@1f40000 { }; =20 tcsr_regs: syscon@1fc0000 { - compatible =3D "syscon"; + compatible =3D "qcom,sc7180-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x40000>; }; =20 --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B36DC25B0E for ; Fri, 19 Aug 2022 08:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347735AbiHSIdD (ORCPT ); Fri, 19 Aug 2022 04:33:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347590AbiHSIck (ORCPT ); Fri, 19 Aug 2022 04:32:40 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10568E991A for ; Fri, 19 Aug 2022 01:32:24 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id v4so3930359ljg.0 for ; Fri, 19 Aug 2022 01:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=txjXCRtOELuunkCVXNi0V+0kB2LPofpz702NPuFtQkk=; b=WRo0rSEUtXYkkgU2C5eUCi8no3l41nxekq4KYhtKWXLw17rKIRxMDevgKTOadNaswI T5IhnPrrfeK1kO8NO8FSkT3yKAlnLbGPc4jiAyA/jwCvs/o5V3kEub3lebz7qvSE5yO5 av0KlJhL4k3Ot0DwqQB0fZGserk+d7JyKPGy3/TvwkPivyF2DzkU48PHf0RRmXt5fVaO qUyngmY5mosnEunSSgpKyjcnpBfr+KXuTDiCopqBClqAWQSR5vbQF57NDeRXwRokZiBd k5zShAn096Y713nnFW9rb9+VYA90JBlAT35gmsypAQARbothyuMm5WutD7DrOhWo0Zbe EIUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=txjXCRtOELuunkCVXNi0V+0kB2LPofpz702NPuFtQkk=; b=RfftOhlGREwoHT52ahucrnqGtCG711NoZF/xuh8e05T1uaD79yOfOb27FF1Y4SxT44 nrsoe0hmoVI0gOJq+KU5Hghw3f3V1D2HuSxKIJn7thrCLLmhA8CBqNM4x73IGvtRcoav AbdGXXXYaQ0KHEWbS9oD93HB3ld36XgzIZXwKi4Oxp3bC9CcQc5l+m8lxBY/QflSrIg6 RJc64axrNxFN5MySoKybSLUyUY2YeAoFIDXfArKcKhFf8vfVnaumftkbrgGgrMHtodG9 XNISQlMdj7g/6a1HoOIny5W8dJ1RnimAtYdQHlzfjoP74+IH2mCn/ezIlJelvR6TNHs8 V1OA== X-Gm-Message-State: ACgBeo1lxPgk6tmz+Pj4B438+BsQMGtA7VL2IPvLh76jW8vFEngJoioW 30r6CDng5ZsGj+dN5KPS1ikleg== X-Google-Smtp-Source: AA6agR60V4CvViYgSN+CSY/0Z+KZgBs1aH1KfkqRX4Lh7lZX4cZinLOIDaoJsobPydS9XPWJzZ6JBA== X-Received: by 2002:a05:651c:50e:b0:25f:f52b:3c91 with SMTP id o14-20020a05651c050e00b0025ff52b3c91mr2042344ljp.391.1660897943626; Fri, 19 Aug 2022 01:32:23 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 07/16] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Date: Fri, 19 Aug 2022 11:32:00 +0300 Message-Id: <20220819083209.50844-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex (in one address block called TCSR_MUTEX), so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 49f28cb531f6..5d2dd21da79c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1464,10 +1464,15 @@ ipa: ipa@1e40000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + reg =3D <0 0x01f40000 0 0x20000>; }; =20 - tcsr_regs: syscon@1fc0000 { + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sc7180-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; + }; + + tcsr_regs_2: syscon@1fc0000 { compatible =3D "qcom,sc7180-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x40000>; }; @@ -1932,8 +1937,8 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; - qcom,spare-regs =3D <&tcsr_regs 0xb3e4>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; + qcom,spare-regs =3D <&tcsr_regs_2 0xb3e4>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1617AC25B0E for ; Fri, 19 Aug 2022 08:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347354AbiHSIc6 (ORCPT ); Fri, 19 Aug 2022 04:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347580AbiHSIck (ORCPT ); Fri, 19 Aug 2022 04:32:40 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F2FE992E for ; Fri, 19 Aug 2022 01:32:26 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id d23so865185lfl.13 for ; Fri, 19 Aug 2022 01:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=8kKp2gVxl2IVtU6eBY60iDxS0j0PaTIOrvwgxTS4yV4=; b=WjZtC4ADWuqaywxx98ACB+Zd6WWZIbxhCkhYbD1R5SPGwubtGl7crrwW3VZqDwKv4l qspJRZMkY0RPZOfvEg4miGXS1EnV0EkmjbsZdadw21AGgYjsSNnuixwYOhsc44mOYf6S CfemEizejIsVbK8aGAZZC9W1rh1CD82bRS3TFq1brO2zjwlnEeBUUSXYCM+LvBSlaFrl 3UsGCFXtuETx2OBDAc0NNfoLmxSWMGSZnSTGuobKg6H4u++ch1RrQlYpf+dk+n7rCevt L9C1rEjdG/YlOMcAbfujTDbTPyOu1Kiz2NKMoUgD00SNZNS7927Yk0kOw4c89LUiA7iy OT9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=8kKp2gVxl2IVtU6eBY60iDxS0j0PaTIOrvwgxTS4yV4=; b=Tnif1ctnYrG4BcRy6gO0JjdsvXyNI/bGJPX3kzbOfQ7I/Tu9xycZqbKwk7pCNf8HBp U699WLePlT3nWSu7itbLgbWhOVWVi5lKGym0513Owu50+neFwc0ZtxM3fVJ+sZDcq/rF QHA7pIhcQUxgC08OT13K2voKxSegBwKd+qzmwjKm6ZktJicF/Y7uI7F6kfot6Sxq2zqq OKZ6Ojuh/6Obr6jSHzZSUDKkCx8vOUxcPEETuyyMIV1yKab0EfVPS222pY/dZNOkoThD sOEbxPtjuI7rHDLXctTc0PzoF3GtqiUeGCKT/K2Wppv5uvkl1t+gI3rfeNJTMmczIs1H 5Z7Q== X-Gm-Message-State: ACgBeo1Me3LyctvMMHP8W/4GTUHiNG6CgCtfWtEEPobDUlRDd5Skb7On PY0dlkYYYkjRT7b0fI/ehSNm1g== X-Google-Smtp-Source: AA6agR5isHHMh5jJA4xgLZE7AfZda2RabaQQ8z+Srqh3cVKl26ot3hQsxzAxApePeqsJZhIoaQLobQ== X-Received: by 2002:a05:6512:3d08:b0:48b:123e:fcf3 with SMTP id d8-20020a0565123d0800b0048b123efcf3mr2080662lfv.418.1660897944944; Fri, 19 Aug 2022 01:32:24 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:24 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 08/16] arm64: dts: qcom: sc7180: switch TCSR mutex to MMIO Date: Fri, 19 Aug 2022 11:32:01 +0300 Message-Id: <20220819083209.50844-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'reg' is a required= property qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'syscon' does not m= atch any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 5d2dd21da79c..e8debb0da411 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -555,12 +555,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - smem { compatible =3D "qcom,smem"; memory-region =3D <&smem_mem>; @@ -1462,9 +1456,10 @@ ipa: ipa@1e40000 { status =3D "disabled"; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2786C25B0E for ; Fri, 19 Aug 2022 08:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346712AbiHSIdJ (ORCPT ); Fri, 19 Aug 2022 04:33:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347405AbiHSIck (ORCPT ); Fri, 19 Aug 2022 04:32:40 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6CDCE990C for ; Fri, 19 Aug 2022 01:32:26 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id o2so5248777lfb.1 for ; Fri, 19 Aug 2022 01:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=r9Tkhs8iRZKA/xD9KN/+OgaKLtO/SCM3ARj69+DISGs=; b=zh6eWeXmxOqbTaUiUKsju+FNFWmsNstbBDDBboZI42HImzRtnU3ztlpFZAiPMHnjFR V4BuQrft+UoJx4szA/dkwsZJvOnb8Y5ylF6vEz/b6ne7RislpT4LrKoYSWgeD5NbR2EE Hok2LVuOUF21WrwRyYhRU5IP48RehmquufONZKHTGD8SDdoa693E1o2n2f+rVg8v8EUW oS/AdrNR9sJt2t8/KgtKYHzKdf+tfTcWSf6OHqWi0JzyTq39mCJFsXAAaGqF6lRGcp8l kabBjmojFm7TgzXqbqwxGfr87R2SS2kHoyA0EdsqMYUbKQmK91ogvmFK5J3f85GfOu+P VEMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=r9Tkhs8iRZKA/xD9KN/+OgaKLtO/SCM3ARj69+DISGs=; b=unl50uB7yrBzcc6bZ2PflqXdj/73xkjsJFQRrjAzL/rXUw01cQt1BriYg0L0Avtuxh N1wDabLJTybIvYcnvLTcuGJ3vlmPRZVbvRISlh/Y2vR5euWfw0ll0CfA0wPHMr/CEEzF UymoU7RYMYU+tLgp1IHhl9pJXrso1L802w4j3j00HJv+EhMqxMah5Al7XXheHvHPm2ul olqxz8eAWfa82UYhIJHwXATxWYAy4i2mMsALKDGKWCJ6Z3gM0RYinWvlV1bz0FwAWQz2 8H2gBmr0PlvLrDS6Dq/FIkDhwyPA8Phlqi46gYoIztyp4e9eWMsDxkJo3DfsRrLXY8rE dr+w== X-Gm-Message-State: ACgBeo1HCNtDvLmqJ26byk2FuG5/O73JDMx+Jt3MSKXnehwaaxPgvRhj XIofTP7tFSguHxhQfGvy/BzJsWfmVk8vNvRu X-Google-Smtp-Source: AA6agR5FIc0QGMG/pMBu109cR90TvStFdFPoZIj7ftDcLQh/GukBI9Rw0g1pIyYWxjf/6HiU2bpYiA== X-Received: by 2002:a05:6512:118a:b0:492:a32d:3678 with SMTP id g10-20020a056512118a00b00492a32d3678mr1963460lfr.259.1660897946189; Fri, 19 Aug 2022 01:32:26 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:25 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 09/16] arm64: dts: qcom: sc7280: split TCSR halt regs out of mutex Date: Fri, 19 Aug 2022 11:32:02 +0300 Message-Id: <20220819083209.50844-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex (in one address block called TCSR_MUTEX), so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space, and allows to remove incorrect syscon compatible from TCSR mutex: qcom/sc7280-herobrine-crd.dtb: hwlock@1f40000: compatible: ['qcom,tcsr-mu= tex', 'syscon'] is too long Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qco= m/sc7280.dtsi index 13d7f267b289..89a8e6b9822a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2155,12 +2155,17 @@ ipa: ipa@1e40000 { }; =20 tcsr_mutex: hwlock@1f40000 { - compatible =3D "qcom,tcsr-mutex", "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0 0x01f40000 0 0x20000>; #hwlock-cells =3D <1>; }; =20 - tcsr: syscon@1fc0000 { + tcsr_1: sycon@1f60000 { + compatible =3D "qcom,sc7280-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; + }; + + tcsr_2: syscon@1fc0000 { compatible =3D "qcom,sc7280-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x30000>; }; @@ -2522,9 +2527,9 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>; - qcom,ext-regs =3D <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>; - qcom,qaccept-regs =3D <&tcsr_mutex 0x23030 0x23040 0x23020>; + qcom,halt-regs =3D <&tcsr_1 0x3000 0x5000 0x8000 0x13000>; + qcom,ext-regs =3D <&tcsr_2 0x10000 0x10004 &tcsr_1 0x6004 0x6008>; + qcom,qaccept-regs =3D <&tcsr_1 0x3030 0x3040 0x3020>; =20 status =3D "disabled"; =20 @@ -3259,7 +3264,7 @@ remoteproc_wpss: remoteproc@8a00000 { <&pdc_reset PDC_WPSS_SYNC_RESET>; reset-names =3D "restart", "pdc_sync"; =20 - qcom,halt-regs =3D <&tcsr_mutex 0x37000>; + qcom,halt-regs =3D <&tcsr_1 0x17000>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B50C25B0E for ; Fri, 19 Aug 2022 08:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347568AbiHSIdO (ORCPT ); Fri, 19 Aug 2022 04:33:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347253AbiHSIcm (ORCPT ); Fri, 19 Aug 2022 04:32:42 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 173C2E9A8E for ; Fri, 19 Aug 2022 01:32:29 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id x19so5212799lfq.7 for ; Fri, 19 Aug 2022 01:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=E+17Qxxn21Uu6LvEIhuc2ojzyXZWgnM8bM1M23WOvqM=; b=eI9FvXYmtBy87bejmWl5mEBHmnpmC7hddgW4zvoPYswRxCfZPtIStdiZQoc3w471zE 7a/UsxfxMsv6UjIU1XJW6E3DDiNY/2kzkUM5UK69YvYTb57v0d9CIt9Pn6wxNqoLmqQP N5smsEcImoMBmKkdOceOsr3JFPaYci94XqzaFKiBZBgrmpF8ptBpsQukaj5+3mCCrxtH ydz8mQ+wgp87aQuejZvQ2tkEAlxH0cAFM6DqubZ5VXh+hLi61NbW9ql4UJ3bH7EFT7yb MblCen9Op/zruiVde3V9PhMTcqVUqZSQdPNmDF+K89coHvlsl9AYE7tXHE/jDRik4hOD ICzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=E+17Qxxn21Uu6LvEIhuc2ojzyXZWgnM8bM1M23WOvqM=; b=DJXduDiZrPwgg8CKn6ql+2K93OZAPV2Jc1lJ8/UTejm7w6lH5WsAiX3EIFuJ4/c56J 0sT+ktCm3sR7xHcQADvXhXU8yk8nKJ1J43jBJYE60zUD6s3GIIDH3Ws+x+DiX6oXT20a DexEXd8KGOg1oY9dvZy0e3ulxifa9yJfLMbTXqojPDYY/5GNsJX6WJwbvFTrJTKTGZtd rl2q4w7E0VGlaE9TZ3HFv/B0y4luWdwXfU1zsw2JfnZ6xllruO5/OzcrxGtSQX4YYgE2 WL8G3ib44XzHxk4iVEaxKObiVBPAZBaSaWVp5vfXMNcfPQ6VJmWWhniOAmIsg6CVCVdc VAjA== X-Gm-Message-State: ACgBeo3EJdppRpGj2qHom0VuE1vHrTa0JWu/sgf9kGeo7fCFVIbHH3PW jXhk8EuNwzKNvf77Pm83jGsFbQ== X-Google-Smtp-Source: AA6agR65Pux9Q6UuNKdMfHI9jiKB+6inzGUrjhufALKPQAuPflJALLwzwmR5m/YxJmT2symi+YIMeQ== X-Received: by 2002:a05:6512:21a6:b0:48d:13c4:df1f with SMTP id c6-20020a05651221a600b0048d13c4df1fmr2151780lft.576.1660897947484; Fri, 19 Aug 2022 01:32:27 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:27 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 10/16] arm64: dts: qcom: sdm845: split TCSR halt regs out of mutex Date: Fri, 19 Aug 2022 11:32:03 +0300 Message-Id: <20220819083209.50844-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex (in one address block called TCSR_MUTEX), so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qco= m/sdm845.dtsi index f0e286715d1b..21ed14200986 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2590,7 +2590,12 @@ ipa: ipa@1e40000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + reg =3D <0 0x01f40000 0 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sdm845-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; }; =20 tlmm: pinctrl@3400000 { @@ -3207,7 +3212,7 @@ mss_pil: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; =20 power-domains =3D <&rpmhpd SDM845_CX>, <&rpmhpd SDM845_MX>, --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FF6C25B0E for ; Fri, 19 Aug 2022 08:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347346AbiHSIdR (ORCPT ); Fri, 19 Aug 2022 04:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347640AbiHSIcn (ORCPT ); Fri, 19 Aug 2022 04:32:43 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 535D2E9A92 for ; Fri, 19 Aug 2022 01:32:29 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id x25so3880716ljm.5 for ; Fri, 19 Aug 2022 01:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=ccVNEGUyoLcQaI8UdynUDOxJeKEsV/fbBjw/mDhwVlQ=; b=YeBXMKhczh3OUm5tRZmsWzu8W6h3U6BxytA9zHgyzijvmxaYWMNcbpDU6cFzzneNzV cWYinBJR47zs1M8BfncTWEBA8YqxeephXrgGUSgog3pDfarqxPfK3UwdxQsVZaoWrRuU xXPWCbVDulY4BNgr2h5phO5izQMv9BSdNWz3ca9lcR+1LC9ydglzveCp5iujqYwF4EKo K9lpLtCQE5OcPLRRAitBEUwNu0RpiZEh/I42yFer4LUxmetZcADGEDlCI8YGM3Vke266 1pKHbXgESX7ywcxnee/v9WX7En3WC7PoxvAREIA1vXBELwfeTBGQHC9rtzyo282atoAf z95w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=ccVNEGUyoLcQaI8UdynUDOxJeKEsV/fbBjw/mDhwVlQ=; b=06G7/ij4+Eu8Xo35WbByR6Py4HD9MoQES6R6h2RMoy9QDhNa9gv3guu3+tNeg5Ebpp 41beLLQ2M010pYN6dDoWMHdJlnhd9H+tqCUbKJVHJefwDwuPsIcw/j5AYh1XtPjX00+Y jEfyNGe6xrMs49q0snx6SuudWAdpiE4ZZO6C3ws9yonLEEuGpmRD+4x5tfDXZidJEFI6 a8oHNZs0gIyD+GX1/2q0RKGP/d+3VR6zFoYuRjh6EWPNln2JMU4+XD8IxZ7BK/y/xjJA 9h6T+ikCN4g+0r4KVR7AbK9cVWday0NpgCK2eT2J7XOoH1+0lK6kSu8bzsrTIMQuaAkh e7Dg== X-Gm-Message-State: ACgBeo1bJWFdG5OmkSUixA2kHj6F3eOSGa4QLxfoL47Z6WHTCqcNpSSl F8Et1RcYpy4FzdAn0z4tWvOLyQ== X-Google-Smtp-Source: AA6agR7qqaBvWZNiZs3HGRYQ2Gh7LZMn4wZs4cz/1KhQKcIsqoikGcj0ftgaNfEvhDVKdsoEH9jiFA== X-Received: by 2002:a2e:9254:0:b0:25e:4f20:8d3a with SMTP id v20-20020a2e9254000000b0025e4f208d3amr2018059ljg.233.1660897948918; Fri, 19 Aug 2022 01:32:28 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:28 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 11/16] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Date: Fri, 19 Aug 2022 11:32:04 +0300 Message-Id: <20220819083209.50844-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm845-shift-axolotl.dtb: hwlock: 'reg' is a required property qcom/sdm845-shift-axolotl.dtb: hwlock: 'syscon' does not match any of the= regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qco= m/sdm845.dtsi index 21ed14200986..bd0ec0664283 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -919,12 +919,6 @@ compute-cb@8 { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - smp2p-cdsp { compatible =3D "qcom,smp2p"; qcom,smem =3D <94>, <432>; @@ -2588,9 +2582,10 @@ ipa: ipa@1e40000 { status =3D "disabled"; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E64C25B0E for ; Fri, 19 Aug 2022 08:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347585AbiHSIdW (ORCPT ); Fri, 19 Aug 2022 04:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346719AbiHSIcn (ORCPT ); Fri, 19 Aug 2022 04:32:43 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94D43E9AA2 for ; Fri, 19 Aug 2022 01:32:30 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id d23so865388lfl.13 for ; Fri, 19 Aug 2022 01:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=nR+TfTCxfwnZ0rpriGE1cYNwcjlY22/4IV6KiuLJyUA=; b=qWxpF6hFApW+kugscYVZOXUTnHoiBN8s32bAEQQdloNlE2m/km+jumHc9TS+vUlDEb R380ExFQFz7T3W23cCMPgQ+iH4vPNAMTredFdX9PcQDEfaT7t9990KPNJehOwHbqj12t HQabq9i8SDjuwwh9rw6yAJjtmcR4qMdmIC5N5fbH00cxQhmk9lGIOZ8UEZyaGWLuGwYL QTkNl+Nmd2dGzeTnXGZts8vWADoph1oMiXF02LAKcZxl/31vJ3nsYwsVYOH+8TO2drEr +CFr/WtZXya4le2wVu7FLKqhi315bTmUwbmtVAcJR/Dlh/e6iTO6JOVOJw5/0FHZVlrA K2xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=nR+TfTCxfwnZ0rpriGE1cYNwcjlY22/4IV6KiuLJyUA=; b=V/e3sIvUIs7TiTgpN0SuGu1JdeZGLv78mpSg8guFyAyKUkiq8ii0TQQY+8ZSLhYpNM 67rF8NbvAXTclY/9n5RPkMqypH0j05gdBLmOVNlUN8MBVPeZtzZh0xlhnx20MeUMsbCR hGX8EPOV8FXsHrxiL4vDMMKAXttCoJMLoJU4LswE3BRWdoNQDIEcj60rH0Fgx08wgDhS YQ7UbFrub0xGJ2e33yAVsnxsUlYUpQj7Zg2AqQznWeGEvwa2qjEDNrqOOP88CaOiMkqH FJ5q4qP6bx62jBcGuORitdEbvR9NCrKEPVrInIz6GUScq8mOn4gA1sBAStwAtCoELYOA 6qlg== X-Gm-Message-State: ACgBeo1N7xk61ovnHcInX+xVqPi/unBNqbI9Gk2jBA5h80h9nAS5WmkI u3O4g/5OdCduZJbMa9ZbQw60Bw== X-Google-Smtp-Source: AA6agR4K4pT+dAmoviSKHdNtbVIjG/ib3kJ7FVBQIXjODSWNhzjCrASZVBi9CHFQilZWCaeXGrKxmA== X-Received: by 2002:a05:6512:e99:b0:492:cf19:875 with SMTP id bi25-20020a0565120e9900b00492cf190875mr92408lfb.690.1660897950192; Fri, 19 Aug 2022 01:32:30 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 12/16] arm64: dts: qcom: qcs404: switch TCSR mutex to MMIO Date: Fri, 19 Aug 2022 11:32:05 +0300 Message-Id: <20220819083209.50844-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/qcs404-evb-4000.dtb: hwlock: 'reg' is a required property qcom/qcs404-evb-4000.dtb: hwlock: 'syscon' does not match any of the rege= xes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qco= m/qcs404.dtsi index 9ab990061522..3a94eb2cc448 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -295,12 +295,6 @@ smem { hwlocks =3D <&tcsr_mutex 3>; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - soc: soc@0 { #address-cells =3D <1>; #size-cells =3D <1>; @@ -726,9 +720,10 @@ gcc: clock-controller@1800000 { assigned-clock-rates =3D <19200000>; }; =20 - tcsr_mutex_regs: syscon@1905000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1905000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x01905000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr: syscon@1937000 { --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4BAC28B2B for ; Fri, 19 Aug 2022 08:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347245AbiHSIdf (ORCPT ); Fri, 19 Aug 2022 04:33:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347658AbiHSIco (ORCPT ); Fri, 19 Aug 2022 04:32:44 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 245D8E9A82 for ; Fri, 19 Aug 2022 01:32:33 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id b38so2614045lfv.4 for ; Fri, 19 Aug 2022 01:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=+kinn7FouMNpw/yKeKaQATpcIgCOeso1VYgBKDbxVYo=; b=RKXxm+SDvm6sTqNszupfoIxaFYIrwkDEug0oB549p3/EqwD2n6PQ78FLDNtdCf7Vsx bE8bYf47YP7rsQT9ixmS0v4FEI07qlBaJfWCi0GkDRZWoafSebX3KbQ01N6bSNpIPY2U 6103pvlb+gsnIu8Go516RXltyk9PgAx92etxTsEVpxVgTG3QrzHjiLBB8LO1O2MLtGCf gIyt/IiNQNyuOfeaG932bihxCoSGmPqDDwhTzFU8iCS7aDu1OcwrfGHxabeqZgdjLaAD pJxtBZ/DDaeGS3fgIZdrbjGGwnGLV7oioWVPZPvVX3k7j16qxrWaFSbOSiHYU+Mn1NAK wXKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=+kinn7FouMNpw/yKeKaQATpcIgCOeso1VYgBKDbxVYo=; b=hJmc6mL+WnMJvsYHV/Jd1g81l9m4vlnsoaK1UEna3nFSZjllSc8ONKe3FHG3JvjuAC QzOr8KdX1+2SkuB9ozwojkU2apTM5+HQ+1bAJSPZhnUsGPclkEZX6mJSBCo3iAh6J6rN OrmbarloQ3dL4dCn0hcUcNr8/fUSvlH4Da8sBErXrPYGYLyv+EgRn7tWCFVH/K0OMSe7 TY2P11MLK4yLzxT4xWITP80xJ09AQaEsTlqxp4yEumI4jvihWNdzGcKQj5eL00BHVn3j MlT09sWOQSvXPUSH5MebPuLDnf/sU0Rj5eAlTWYlU71PTxV5jZ5XDshT+rwfzLUQ4nPz JJag== X-Gm-Message-State: ACgBeo0vIU82F8eFUkY5foL/vJJTFzPp1ZDTtCxl2NlBYk1+eVijyEex x7ecJSjd4BqHDBVmbGNqUIz4WCxzmqyDNAC3 X-Google-Smtp-Source: AA6agR4CLMLtr/xKoBlXz1v1rcyLD+1DC3Zg/+CkiI0xDB8n0AYOii5VQNkb2YO578SOgaaXHVnYXA== X-Received: by 2002:a05:6512:280f:b0:48d:81c:27de with SMTP id cf15-20020a056512280f00b0048d081c27demr2141319lfb.378.1660897951498; Fri, 19 Aug 2022 01:32:31 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:31 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 13/16] arm64: dts: qcom: sdm630: split TCSR halt regs out of mutex Date: Fri, 19 Aug 2022 11:32:06 +0300 Message-Id: <20220819083209.50844-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex (in one address block called TCSR_MUTEX), so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Changes since v2: 1. New patch --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qco= m/sdm630.dtsi index 1bc9091cad2a..a4f73be3d60a 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -699,7 +699,12 @@ tsens: thermal-sensor@10ae000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0x01f40000 0x40000>; + reg =3D <0x01f40000 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sdm630-tcsr", "syscon"; + reg =3D <0x01f60000 0x20000>; }; =20 tlmm: pinctrl@3100000 { --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0561C25B0E for ; Fri, 19 Aug 2022 08:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346362AbiHSId1 (ORCPT ); Fri, 19 Aug 2022 04:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347663AbiHSIco (ORCPT ); Fri, 19 Aug 2022 04:32:44 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BB27E9AAE for ; Fri, 19 Aug 2022 01:32:33 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id q16so3304026ljp.7 for ; Fri, 19 Aug 2022 01:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=HUb81+JEG6Xfm8piVDwL1AMOuxmRGVBYXMDhN0hd0ms=; b=rYqOxrMR0a43Wuh/jdIepeZapi1JH23fopQiltPNP2wyBw5Imbcp6XyhQ0g8ZKzu0e Fc/5pkNrZMinq05pftWxFxF23KP/ZQZkqtNSEYAQN0v6m3q1bO8L0TxoaJt//06BWOdb PAH52qj9Po5SQ+7G//uBQ2h01WvPv3vRIxvAXwPSBUgPUYLzNb2/YSmogTyKRQKDdHVa KUviwKlqHP7dGGM7Lu/FZPsiWb5RFd+ZX90OeJaiUQ0wYWj/b4j309WYi6atoI2/AWFg o4gWzHU4Hh24juderxgFKmusH4ZxQlqRj+yM2k/tflM21i23/xIsQZmBkLpJgBa80yXL 753Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=HUb81+JEG6Xfm8piVDwL1AMOuxmRGVBYXMDhN0hd0ms=; b=XxkVY54WoN+e9QZ0y0JhY0Scp3VqFP0SycaPDPHP8BRoSr4dua9X37tv4ApzUNFJEr IaiGyug4yR2m8m9xlTAuwPIhw4MWPsGKVWwoFzuj4EaqSNAYWqCX1Q87HnACDJ09rVI4 kIszqOvi+Cs6p6/4RU3BRhGyEYSoM3+GMYJVB/A0vSayU7cENbfJuNXnzumG4rzNOzCM ZkmemBCACVh8BgaO4tq2lNk5gf+WX6J/uJSxRTeLz1mem7t92kwy8pwAOvGo9iR66TCl F9Iq4KTYUyJoAddbG7PvElQtV1gQsc4C1fu5BIs6vk2tJ6nEaiIDisYvYynFUIq6kjDJ sF9w== X-Gm-Message-State: ACgBeo1dC7LnIlactKTblcfJgmXrmX8gF7BGo1EtP0bRM2O2g+gsuACQ d5Q4k1k6AWsaxC4XKJKh1IYlUw== X-Google-Smtp-Source: AA6agR7zfGoVmGIWmhB1UGGA3KQnBfEKQNYXqcnoAuy4DHb0Gpt5hHDIJV17efLJKrHd7A1oUfbuuA== X-Received: by 2002:a2e:8515:0:b0:25e:5582:388f with SMTP id j21-20020a2e8515000000b0025e5582388fmr1730529lji.261.1660897952818; Fri, 19 Aug 2022 01:32:32 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:32 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 14/16] arm64: dts: qcom: sdm630: switch TCSR mutex to MMIO Date: Fri, 19 Aug 2022 11:32:07 +0300 Message-Id: <20220819083209.50844-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'reg' is a required p= roperty qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'syscon' does not mat= ch any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qco= m/sdm630.dtsi index a4f73be3d60a..9ae6610af93a 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -697,9 +697,10 @@ tsens: thermal-sensor@10ae000 { #thermal-sensor-cells =3D <1>; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x01f40000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { @@ -2356,12 +2357,6 @@ intc: interrupt-controller@17a00000 { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - sound: sound { }; =20 --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E96EC25B0E for ; Fri, 19 Aug 2022 08:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347461AbiHSIdk (ORCPT ); Fri, 19 Aug 2022 04:33:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347667AbiHSIco (ORCPT ); Fri, 19 Aug 2022 04:32:44 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 991B1E9AB3 for ; Fri, 19 Aug 2022 01:32:34 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id x10so3890435ljq.4 for ; Fri, 19 Aug 2022 01:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=aF1kTOExhxJ5LhZnkigAMIE3Og/cjDqIZ0JV+mWnMgg=; b=b8DvidfLi+K7kGfFf1QKaFrYO7KrGRMn+DztPWASn5wxp41FkPsFAXyRdYxKfIX11u GWPaDRM6Ixd6HlnXMvoRoWVtci6X+Q3IYfN2DWV/JC9oS6rX2iSXMDTQryjBUEy7sdTT 7ce5dhSca/eP1c1D7KUM1Nouy/Jy0O6Tpde6tKMmDMj3PBeWG3ZmeNMStQKKLPiEXj5E 4xisLrl0TF+6DNAbedEleTix4fT9XfidVwuUpmmZV5z/VhQ5Qs34ERijU1/yPLEq7olh 6/hK/K+DPjdamhDvVsURSPMxZ49IMPt73IkXrufDz17b1jidI8awrDP8RY0ttx19Mz0O lI2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=aF1kTOExhxJ5LhZnkigAMIE3Og/cjDqIZ0JV+mWnMgg=; b=I4LOvi1+EnobewLzqLBQrW6fVJMAEjeQRJSC6326CpJIA7wWdIal0K67dJOwO8c0j1 0eYYYJqa8mdPdtPo+PqDPKrTUJFWUNFVK3F8/3GGckG3V2fiDDWtZYhMZ8L1r9Iz2dtm Lr/hiWeGsucgAaIrkchFS9HN6Fwyu1Hg9ZnrTScNgTcjITi749N8Z4ejEDwT8ziEYj2v D/pD7CSXGUvh0pchIjTrg8ZpOL1gsbv1hpMwdylddTG+jkKxtJZF/Ah+EWpJNeOFHA2w r5lzUvmM2sDTkhUqhYW1VU6la4uls7JUaCjA2KMIRmaKyS7o0awbQeSxEP+ZibM7IE9s lEFA== X-Gm-Message-State: ACgBeo0SoroGYpKhYcXMa819YfJwsCcTaBIg59PYkr22vlYwRBQ/hwqs w7+qbNnwi0FMdvuVMTuvDB7mWw== X-Google-Smtp-Source: AA6agR6XRfFnswT27eivG55n2X6GuJgt/JHyayGyQW+0bgLjG2m6ACmKTArmnrpY8QmOaX0Z/3vO8A== X-Received: by 2002:a05:651c:514:b0:25e:7113:396b with SMTP id o20-20020a05651c051400b0025e7113396bmr1737625ljp.65.1660897954103; Fri, 19 Aug 2022 01:32:34 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:33 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 15/16] arm64: dts: qcom: sm8150: split TCSR halt regs out of mutex Date: Fri, 19 Aug 2022 11:32:08 +0300 Message-Id: <20220819083209.50844-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex (in one address block called TCSR_MUTEX), so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Changes since v2: 1. New patch --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qco= m/sm8150.dtsi index 7d509ecd44da..6df2e6828282 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -2056,7 +2056,12 @@ ipa_virt: interconnect@1e00000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0x0 0x01f40000 0x0 0x40000>; + reg =3D <0x0 0x01f40000 0x0 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sm8150-tcsr", "syscon"; + reg =3D <0x0 0x01f60000 0x0 0x20000>; }; =20 remoteproc_slpi: remoteproc@2400000 { --=20 2.34.1 From nobody Fri Apr 10 20:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B60C25B0E for ; Fri, 19 Aug 2022 08:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347569AbiHSIdp (ORCPT ); Fri, 19 Aug 2022 04:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347479AbiHSIcp (ORCPT ); Fri, 19 Aug 2022 04:32:45 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09F00E97F7 for ; Fri, 19 Aug 2022 01:32:37 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id z6so5217309lfu.9 for ; Fri, 19 Aug 2022 01:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=kO40mQ5LLiZM72PI1BOZaM3hZEnsq6qb9gCyjdGLi8E=; b=g1vh6m10ovfpwnHEpYd5bleuB3ieTl0HlOZy9kcgToeIlnHokH2a6h36qB/Bz7bqtY rnjOjsJydffU24SgMyQLzR+6ldMGAEFkIrt4kJVVujYzUHiP3VOC6HAY7nebnULJnFDn IlL06PdoFY1GpUlxMT0UqPrQD3SE9lB97QmIoTP3GIMcseDK6XXBjqYnW9ogMstg9IjA gcdesJFbkkrDkbKEL7KrXrhIn7XO+3SSWFRIUoCNwWukhk2aOe7Tq56YEhN+66aHASN4 6joodtqmahp03Bw+KMQvjvkLNs7kHDbFhp/YdfaIH0+uvRnkuXamKGbsmvju7zj8J6Cz +PKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=kO40mQ5LLiZM72PI1BOZaM3hZEnsq6qb9gCyjdGLi8E=; b=x1ZiGHbMY6nsKAVvPLpmpF8t5sFTRfTQxMJJHLfYxv50Fv57e+uJiGfQyDdlrelyIh vUkEHqsmXoq03mlbo9OqO85QWrg/ijN/H0q4iVjYBAxEnyvvk6aAmLT4MDM4aVi0GWPo C5hgHi3ztOYY1n7Lp/zG/NX4GAgl6FfF+5XlqnNJtsYvDkYu1EXq3ecDXwT97Y8zvK+d Mx3xuZ94fISjxx8MV+7YMFn3BfDSQd/6Ia8rcXQsMyc98U/edvOdeUFPUVDCQZJrFBcb Vh/aMbK10+VRggwAa2rKH1EeAgN+tSzFGhRqqNY9beDSah5UUi18KFq1RHvDeZEl9hsZ IH/g== X-Gm-Message-State: ACgBeo1+QTOVawAW3wCSkXpPHFQJxb/irfWrVosq/2R28TG7FgLIrohT 5sC6dp3IsU81JGJQOPwn1zSAdw== X-Google-Smtp-Source: AA6agR7KumzH+lH7XCNHMJ0xX3epEUY1/e/6aC/dy4l7Gna3s4wt6/o6JpLuJTOao+IuaHNwqY2TGg== X-Received: by 2002:a05:6512:3090:b0:48b:6e1:1b55 with SMTP id z16-20020a056512309000b0048b06e11b55mr2325331lfd.535.1660897955437; Fri, 19 Aug 2022 01:32:35 -0700 (PDT) Received: from krzk-bin.. (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id j8-20020a19f508000000b00492a54f0be1sm545355lfb.284.2022.08.19.01.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 01:32:35 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v3 16/16] arm64: dts: qcom: sm8150: switch TCSR mutex to MMIO Date: Fri, 19 Aug 2022 11:32:09 +0300 Message-Id: <20220819083209.50844-17-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> References: <20220819083209.50844-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sm8150-mtp.dtb: hwlock: 'reg' is a required property qcom/sm8150-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: = 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qco= m/sm8150.dtsi index 6df2e6828282..da737ba54490 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -585,12 +585,6 @@ scm: scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - memory@80000000 { device_type =3D "memory"; /* We expect the bootloader to fill in the size */ @@ -2054,9 +2048,10 @@ ipa_virt: interconnect@1e00000 { qcom,bcm-voters =3D <&apps_bcm_voter>; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x0 0x01f40000 0x0 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1