From nobody Fri Apr 10 20:20:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEAA0C25B0E for ; Fri, 19 Aug 2022 07:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347190AbiHSHq0 (ORCPT ); Fri, 19 Aug 2022 03:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346383AbiHSHqY (ORCPT ); Fri, 19 Aug 2022 03:46:24 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B778CD7422 for ; Fri, 19 Aug 2022 00:46:23 -0700 (PDT) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M8DJ21Zr4zkWYv; Fri, 19 Aug 2022 15:42:58 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 15:46:21 +0800 Received: from huawei.com (10.67.174.169) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 15:46:21 +0800 From: Chen Lifu To: , , , , , , , , , , , CC: Subject: [PATCH -next] powerpc/powermac: Fix symbol not declared warnings Date: Fri, 19 Aug 2022 15:43:11 +0800 Message-ID: <20220819074311.862263-1-chenlifu@huawei.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.169] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 1. ppc_override_l2cr and ppc_override_l2cr_value are only used in l2cr_init() function, so move them inside the function. 2. has_l2cache is not used outside of the file, so mark it static, and do not initialise statics to 0. Fixes the following warning: arch/powerpc/platforms/powermac/setup.c:74:5: warning: symbol 'ppc_override= _l2cr' was not declared. Should it be static? arch/powerpc/platforms/powermac/setup.c:75:5: warning: symbol 'ppc_override= _l2cr_value' was not declared. Should it be static? arch/powerpc/platforms/powermac/setup.c:76:5: warning: symbol 'has_l2cache'= was not declared. Should it be static? Signed-off-by: Chen Lifu --- arch/powerpc/platforms/powermac/setup.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platfor= ms/powermac/setup.c index 04daa7f0a03c..f8b847a2f5b5 100644 --- a/arch/powerpc/platforms/powermac/setup.c +++ b/arch/powerpc/platforms/powermac/setup.c @@ -68,13 +68,11 @@ =20 #include "pmac.h" =20 #undef SHOW_GATWICK_IRQS =20 -int ppc_override_l2cr =3D 0; -int ppc_override_l2cr_value; -int has_l2cache =3D 0; +static int has_l2cache; =20 int pmac_newworld; =20 static int current_root_goodness =3D -1; =20 @@ -226,10 +224,13 @@ static void __init ohare_init(void) } } =20 static void __init l2cr_init(void) { + int ppc_override_l2cr =3D 0; + int ppc_override_l2cr_value; + /* Checks "l2cr-value" property in the registry */ if (cpu_has_feature(CPU_FTR_L2CR)) { struct device_node *np; =20 for_each_of_cpu_node(np) { --=20 2.37.1