From nobody Fri Apr 10 22:01:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C639FC00140 for ; Thu, 18 Aug 2022 21:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347061AbiHRVOh (ORCPT ); Thu, 18 Aug 2022 17:14:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346883AbiHRVKn (ORCPT ); Thu, 18 Aug 2022 17:10:43 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C4F7D8E22 for ; Thu, 18 Aug 2022 14:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=k1; bh=WBtPemeBcZtvbF6Vw3AnEIWalgE 2124YVWxaAhR87Ok=; b=kTNFp5Bq9Fi6etIu068n2GHDkP4F7gak9kIH8FZjpfU LSFudQbVft8VmKVcV6nhdBaU47CSkEojD8hXwr0Gt47nOzVFfSKOEF9tA7MhcdJm r3DbFAjkoy83p7Fg92otO3mFdu98ShecxCe8nTL/0Pjsk++U45RbmpP9LMnJUBeY = Received: (qmail 3963297 invoked from network); 18 Aug 2022 23:02:27 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 18 Aug 2022 23:02:27 +0200 X-UD-Smtp-Session: l3s3148p1@awOITIrmgrAucref From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: [PATCH] packet: move from strlcpy with unused retval to strscpy Date: Thu, 18 Aug 2022 23:02:27 +0200 Message-Id: <20220818210227.8611-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=3DwgfRnXz0W3D37d01q3JFkr_i_uTL=3DV6A6= G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang --- net/packet/af_packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 5cbe07116e04..7de46d831349 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1905,7 +1905,7 @@ static int packet_rcv_spkt(struct sk_buff *skb, struc= t net_device *dev, */ =20 spkt->spkt_family =3D dev->type; - strlcpy(spkt->spkt_device, dev->name, sizeof(spkt->spkt_device)); + strscpy(spkt->spkt_device, dev->name, sizeof(spkt->spkt_device)); spkt->spkt_protocol =3D skb->protocol; =20 /* @@ -3565,7 +3565,7 @@ static int packet_getname_spkt(struct socket *sock, s= truct sockaddr *uaddr, rcu_read_lock(); dev =3D dev_get_by_index_rcu(sock_net(sk), READ_ONCE(pkt_sk(sk)->ifindex)= ); if (dev) - strlcpy(uaddr->sa_data, dev->name, sizeof(uaddr->sa_data)); + strscpy(uaddr->sa_data, dev->name, sizeof(uaddr->sa_data)); rcu_read_unlock(); =20 return sizeof(*uaddr); --=20 2.35.1